[00:41:48] 06Collaboration-Team-Triage, 10Thanks: Thanks logs page id 0 - https://phabricator.wikimedia.org/T136048#2321425 (10happy5214) I //think// (I could be wrong, since I'm new to the code.) that `logging.log_page` is the page ID of the user page for the user being thanked. If that user doesn't have such a page, it... [05:39:38] (03PS1) 10SamanthaNguyen: Remove deprecated PHP entry point [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/342572 (https://phabricator.wikimedia.org/T140007) [06:55:54] 06Collaboration-Team-Triage, 10WikiLove, 07Malayalam-Sites: WikiLove message on User Page - https://phabricator.wikimedia.org/T46383#481462 (10Quiddity) I don't think this request is likely to be implemented. 1) Editors currently only get a 'notification' about the update, if it's on their talkpage. 2) Man... [09:12:06] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 05Goal: Help to define next steps concerning Flow development, based on the Flow Satisfaction Survey - https://phabricator.wikimedia.org/T137796#3097286 (10Qgil) [14:08:00] 06Collaboration-Team-Triage, 10Notifications: Show Echo web notification (asking users to consider providing an email) to users who don't have an e-mail address associated with their account - https://phabricator.wikimedia.org/T58028#617097 (10Reedy) Certainly we need this for unconfirmed emails, ala T58074 B... [15:26:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3098157 (10Halfak) It seems that the only other... [16:15:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3098400 (10SBisson) a:03SBisson [17:03:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3098604 (10jmatazzoni) > That overlap is certai... [17:38:38] 06Collaboration-Team-Triage, 10Notifications: Idea: Make the use of ping more easy for new users (e.g. when a username is prefixed by '@') - https://phabricator.wikimedia.org/T159908#3083015 (10Catrope) Very related: {T128535} [17:43:50] 06Collaboration-Team-Triage, 10Notifications: Idea: Make the use of ping more easy for new users (e.g. when a username is prefixed by '@') - https://phabricator.wikimedia.org/T159908#3098768 (10Catrope) A system that opens a box for a username when you type '@' already exists in Flow. Porting that to wikitext... [17:48:08] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Failed mention and Successful mention notifications don't work on Flow - https://phabricator.wikimedia.org/T160088#3088314 (10Catrope) A patch was submitted to add mention success/failure notifications to Flow, but it was never merged or followed up on. [17:48:17] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Failed mention and Successful mention notifications don't work on Flow - https://phabricator.wikimedia.org/T160088#3098783 (10Catrope) [17:48:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 3 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3098786 (10Catrope) [17:56:56] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 10Wikimedia-Interwiki-links: Interlanguage links not appearing on Flow pages - https://phabricator.wikimedia.org/T160274#3098847 (10Catrope) I'm guessing this is probably a bug in how #wikidata injects these language links? If it turns out to be a bug in Flo... [17:57:54] (03CR) 10Catrope: [C: 032] Use words for describing notification counts in HTML text node [extensions/Echo] - 10https://gerrit.wikimedia.org/r/342327 (https://phabricator.wikimedia.org/T160277) (owner: 10Esanders) [17:59:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 13Patch-For-Review: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3078520 (10Catrope) a:03Catrope [18:04:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Transitive closures for RCFilters supersets - https://phabricator.wikimedia.org/T160443#3098865 (10Mattflaschen-WMF) [18:09:13] (03Merged) 10jenkins-bot: Use words for describing notification counts in HTML text node [extensions/Echo] - 10https://gerrit.wikimedia.org/r/342327 (https://phabricator.wikimedia.org/T160277) (owner: 10Esanders) [18:20:33] RoanKattouw, reviewed and +2'ed. Turns out the branch cut was 10 AM Pacific today, though: https://phabricator.wikimedia.org/source/mediawiki/browse/wmf%252F1.29.0-wmf.16/ . [18:20:38] I'll do a minor followup. [18:20:50] That's OK, we discovered a few things are broken [18:21:03] in other areas, like conflict states in the UI [18:21:11] So we're going to delay by a week [18:22:04] I see [18:22:14] RoanKattouw, did you and jmatazzoni_ decide whether to get rid of the conflict messages? [18:22:22] Custom ones I mean. [18:22:53] RoanKattouw, also, I forgot, it's missing conflictsWith for log entries. [18:22:57] I'll add that in my follow up too. [18:23:10] Log entries conflict with what? [18:23:13] RoanKattouw, ORES. [18:23:25] Hmm yes true [18:23:38] It's in the spec too, I just forgot. [18:23:40] 06Collaboration-Team-Triage, 10Notifications: Kill the 10th edit notification - https://phabricator.wikimedia.org/T160446#3098954 (10kaldari) [18:24:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3098967 (10Catrope) [18:28:32] 06Collaboration-Team-Triage, 10Notifications: Kill the 10th edit notification - https://phabricator.wikimedia.org/T160446#3098954 (10Mattflaschen-WMF) > I can understand having a notification for your first edit, but having one for your 10th edit is just annoying. When we were originally developing Echo, we di... [18:29:47] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications - https://phabricator.wikimedia.org/T160446#3099024 (10kaldari) [18:31:13] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3099075 (10Mattflaschen-WMF) [18:31:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3099076 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [18:35:17] (03CR) 10jenkins-bot: Use words for describing notification counts in HTML text node [extensions/Echo] - 10https://gerrit.wikimedia.org/r/342327 (https://phabricator.wikimedia.org/T160277) (owner: 10Esanders) [18:36:14] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3099098 (10kaldari) @Mattflaschen-WMF: That page is just one example, they also [[ https://meta.wikimedia.org/wiki/Research:Post-edit_feedback#PEF-2:_Historical_Feedb... [18:45:22] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3099129 (10kaldari) And even if we were going to have such notifications, it would make a lot more sense to show them as post-edit messages than Echo notifications. H... [18:53:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] The red highlighting for conflicting filter states is gone - https://phabricator.wikimedia.org/T160453#3099150 (10Etonkovidova) [18:57:00] Get rid of them? [19:07:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the old parts of the new RC form work in the same, ... - https://phabricator.wikimedia.org/T157594#3099250 [19:08:28] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3099257 (10kaldari) Looking at the [[ https://meta.wikimedia.org/wiki/Research:Post-edit_feedback/PEF-2 | results from the PEF-2 experiment ]], it looks like editors... [19:35:45] jmatazzoni_: Matt and I discussed the idea of only having a generic conflict message and not having specific case-by-case conflict messages (hence "custom ones, I mean") [19:54:40] matt_flaschen: Can I grab a quick +2 on https://gerrit.wikimedia.org/r/342681 ? [20:19:32] 10Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, and 4 others: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#3099573 (10Mattflaschen-WMF) a:05matthiasmullie>03None [20:34:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3099659 (10jmatazzoni) >>! In T159345#3094465, @Quiddity wrote: > they sometimes visit the RC page primarily... [20:35:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3099665 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [20:36:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3099666 (10jmatazzoni) [20:39:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3099678 (10Mattflaschen-WMF) [20:39:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: For Conflict States, short-circuit the fruitless searches so as to save processing effort - https://phabricator.wikimedia.org/T160220#3099677 (10Mattflaschen-WMF) [20:42:55] RoanKattouw: matt_flaschen: RC on betalabs displays /wiki/Special:RecentChanges RuntimeException from line 53 of /srv/mediawiki/php-master/extensions/ORES/includes/Api.php: Failed to make ORES request to [https://ores-beta.wmflabs.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json], There was a problem during the HTTP request: 400 BAD REQUEST [20:43:30] is anyone enabling ORES by default, and beta feature for ORES is disabled already? [20:44:52] RoanKattouw, it's not enabled on testwiki for some reason, I'll put up a change. [20:44:57] https://ores-beta.wmflabs.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json https://ores-beta.wmflabs.org/scores/enwiki/goodfaith/?model_info=test_stats&format=json [20:45:01] testwiki, enwiki [20:47:45] RoanKattouw, halfak, do you know how we would enable it on ores-beta? [20:48:12] And the difference between https://ores-beta.wmflabs.org/scores/testwiki/damaging/?model_info=test_stats&format=json ("Returns the last two digits in a rev_id as a score") vs. https://ores-beta.wmflabs.org/scores/enwiki/damaging/?model_info=test_stats&format=json ? [20:48:12] what is [it]? [20:48:31] halfak, 'goodfaith' model on testwiki Beta Cluster [20:48:51] Ahh... I'm working on a deployment now. I can do that. Can you give me a task for it? [20:49:01] Make it a sub-task of https://phabricator.wikimedia.org/T160279 [20:49:25] halfak, will do, first one more question. Is testwiki damaging also not available? https://ores-beta.wmflabs.org/scores/testwiki/damaging/?model_info=test_stats&format=json does't say "not available for testwiki", but the output is different. [20:50:13] matt_flaschen, not sure what you're asking [20:50:26] What do you mean it doesn't say ... What do you mean that the output is "different"? [20:50:44] halfak, it seems Beta Cluster enwiki damaging is working (https://ores-beta.wmflabs.org/scores/enwiki/damaging/?model_info=test_stats&format=json has output that looks complete). [20:50:58] halfak, it also seems disabled models say "Model 'something' not available for testwiki" [20:51:05] https://ores-beta.wmflabs.org/scores/testwiki/damaging/?model_info=test_stats&format=json is neither so I'm a bit confused. [20:51:22] Looks like it is enabled to me [20:51:24] It says "{"behavior": "Returns the last two digits in a rev_id as a score.", "type": "RevIDScorer", "version": "0.0.3"}" [20:51:27] Right [20:51:41] No test statistics or configuration parameters for that kind of model. [20:51:58] It just returns the last two digits of whatever revid you give it. [20:52:08] halfak, I see, so it's inventing a score from the rev_id, but the API is working. [20:52:28] Yeah. [20:53:27] halfak, thanks. [20:53:29] Task is at T160467 [20:53:30] T160467: Enable 'goodfaith' on testwiki on Beta Cluster - https://phabricator.wikimedia.org/T160467 [20:53:41] Great. Will do. [20:53:56] Thanks [20:54:00] And thanks to etonkovidova for the heads-up [20:54:04] * halfak already has the config open [20:55:53] matt_flaschen: glad that I helped :) How about fixing Internal error on RC in betalabs ? [20:56:21] etonkovidova, the RuntimeException you just mentioned, or different? [20:56:35] matt_flaschen: yes, that one [20:56:41] halfak is working on it. [20:57:37] Could have a beta deploy in ~30 minutes depending on how fast I can get some code review :) [20:58:46] 06Collaboration-Team-Triage, 10Notifications: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3099804 (10Mattflaschen-WMF) >>! In T160446#3099098, @kaldari wrote: > @Mattflaschen-WMF: That page is just one example, they also [[ https://meta.wikimedia.org/wiki/... [21:05:26] RoanKattouw, I'll do the conflictsWith for ORES, unless you started that. [21:08:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3099862 (10jmatazzoni) [21:14:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (instead of behind ... - https://phabricator.wikimedia.org/T158225#3099895 [21:15:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3077869 (10jmatazzoni) [21:15:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3099900 (10jmatazzoni) [21:16:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (instead of behind ... - https://phabricator.wikimedia.org/T158225#3030378 [21:38:17] matt_flaschen: Go ahead, I haven't [21:38:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3077869 (10jmatazzoni) @Catrope and @Etonko... [21:43:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3100080 (10Catrope) >>! In T159763#3100052,... [21:43:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342730 (owner: 10L10n-bot) [21:53:04] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3100087 (10Catrope) Right, I forgot that it... [21:53:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3100088 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [22:03:29] RoanKattouw, do we have a task tracking the MVP? [22:03:45] T158025 also needs to be in, since we removed a conflict state based on that. [22:03:45] T158025: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025 [22:11:36] Hmm I don't think we do [22:16:23] matt_flaschen, halfak: What's the status of enabling goodfaith on beta? Should we revert my config change to unbreak beta for the time being? [22:19:30] If we get that in beta today, it will show up in a couple hours. [22:19:34] No guarantees. [22:19:41] * halfak runs to dinner [22:19:41] o/ [22:22:30] RoanKattouw, only testwiki Beta is broken, I can disable if you want, but I'd suggest we just fix it. People can test on enwiki Beta in the meantime. [22:24:16] halfak, just wondering, where is your patch. I can try to code-review it (though this is my first time looking at the config). [22:25:10] matt_flaschen: enwiki beta is broken for me... [22:25:28] [WMhr3wpEE4AAADrrGxUAAAAG] /wiki/Special:RecentChanges RuntimeException from line 53 of /srv/mediawiki/php-master/extensions/ORES/includes/Api.php: Failed to make ORES request to [https://ores-beta.wmflabs.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json], There was a problem during the HTTP request: 400 BAD REQUEST [22:25:33] RoanKattouw, oh really? I thought that was okay, since https://ores-beta.wmflabs.org/scores/enwiki/goodfaith/?model_info=test_stats&format=json looks good. [22:25:40] Despite the "testwiki" in the URL, that error is coming from https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges [22:25:48] Wat [22:26:01] Yeah... I think maybe it's for the fake scores? [22:26:14] As opposed to trying to score things from the real enwiki? [22:26:35] But https://ores-beta.wmflabs.org/scores/enwiki/goodfaith/?model_info=test_stats&format=json seems to be hooked up. [22:26:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/342726 (owner: 10L10n-bot) [22:27:12] RoanKattouw, looking into why it's using the wrong one on enwiki. [22:45:20] milimetric: Do you know why/how it is that https://edit-analysis.wmflabs.org/beta-enables/ shows only the Flow and Cross-wiki beta features but not the others from https://gerrit.wikimedia.org/r/#/c/289007/4/manifests/role/statistics.pp ? I'm trying and failing to find the code/config/repo that drives that stuff [22:46:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3100184 (10jmatazzoni) [22:46:34] (Use case: I want to track a new beta feature there, but I'm worried that it might not work if some of the existing ones already don't work; also do we have more standard infra for tracking beta feature adoption?) [22:47:45] we don't have anything else that tracks beta feature adoption that I know of, but maybe Neil does, I'm guessing there's just no metrics configured for the new data you have, that's all still manual and improving as we go [22:47:50] I'll take a look [22:49:29] RoanKattouw: Because you lot wrote that, and you whitelist the pref changes you care about. [22:49:39] RoanKattouw: I asked a while ago for you to track other ones to no avail. :-P [22:50:09] After I wrote that milimetric went and un-consolidated these things back into separate repos [22:50:13] RoanKattouw: https://analytics.wikimedia.org/datasets/periodic/reports/metrics/beta-feature-enables/ this is where any jobs would output to, so I'm checking backwards now [22:50:27] And I can't find out what drives that wmflabs domain because my labs-fu is inadequate [22:50:46] Neil doesn't know either, I asked him first [22:50:48] no that's not your fault, we need to link up configs from the interface better [22:51:07] Yeah an interface->config link would be wonderful [22:51:22] there was a task a volunteer was doing, not sure where she's at with it [22:51:50] Ah, it changed again? [22:51:54] Ooh Neil just found https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=&namespace=482 [22:52:18] RoanKattouw: so just crosswiki-beta and flow-beta are what you're tracking, right? [22:52:40] yeah, that's just one config, though, I wanted to make sure all the data you think you're collecting is there [22:52:48] Those are the ones that are currently rendering there, but the code in the limn-*-data repos is trying to track at least one other one AFAICT [22:52:50] And I want to add one [22:52:57] But https://meta.wikimedia.org/wiki/Config:Dashiki:FlowByWiki looks suspiciously related [22:53:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3100220 (10jmatazzoni) [22:54:17] right, https://meta.wikimedia.org/wiki/Config:Dashiki:FlowByWiki is what's configuring the current dashboard [22:54:28] but you're saying it's missing metrics, right? [22:54:37] Yeah and I don't know what they would be called [22:54:37] Like [22:54:38] do you know what script executes the missing ones? [22:54:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3077869 (10jmatazzoni) I fixed up the descr... [22:54:46] metrics [22:54:46] "Flow Beta Enables" [22:54:46] "Crosswiki Beta Enables" [22:54:57] Great, but what maps those names to config.json files? [22:55:06] right, those are https://analytics.wikimedia.org/datasets/periodic/reports/metrics/beta-feature-enables/flow_beta/ and https://analytics.wikimedia.org/datasets/periodic/reports/metrics/beta-feature-enables/crosswiki_beta/ respectively [22:55:33] all metrics are configured here: https://meta.wikimedia.org/wiki/Dashiki:CategorizedMetrics [22:55:59] (and I know Neil already chastised us for not cleaning this up, but at least we're rendering some dashiki stuff a little nicer, right? :)) [22:56:05] Aha! [22:56:12] OK I think that makes the puzzle fit together [22:56:38] but I still can't find any more scripts that you have running, so isn't that a problem? [22:56:41] that's what I was looking for [22:57:07] So if I wanted to add a brand new beta feature (which I do), then I create an entry in e.g. limn-ee-data/ee-beta-features/config.yaml , add it to CategorizedMetrics, and then to FlowByWiki [22:57:15] Ahm looking hold on [22:57:26] I can add it to CategorizedMetrics so you don't have to worry about breaking stuff [22:57:31] (you're welcome to if you want) [22:58:05] There's https://github.com/wikimedia/analytics-limn-language-data/blob/master/language/config.yaml but that may run on its own dashboard actually [22:58:15] but yes, write script, add to config.yaml, merge, data runs and syncs, configure metric, then configure dashboard to include it [22:58:36] oh yeah, it does: https://language-reportcard.wmflabs.org/#projects=ptwiki,idwiki,eswiki,viwiki,ukwiki,dewiki,trwiki,ruwiki,frwiki/metrics=Content%20Translation [22:58:38] Yes it does [22:58:54] But the whole point of edit-analysis is to unify things [22:59:02] I'll complain to Neil about it not having an index page [22:59:19] well, that one's super easy to bring into the beta enables dashboard, want me to do that? [23:00:04] Yes please [23:00:19] It does seem to have two submetrics, a normal one and a "manual" one, not sure what that's about but Amir would know [23:00:51] Anyway, I gotta run, but thanks, I now feel confident that I can easily add a metric for the beta feature my team is about to introduce [23:01:08] And we might as well add one for the NWE beta feature I suppose (cc James_F ) [23:01:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3100269 (10jmatazzoni) [23:01:31] RoanKattouw: I did that with them, manual is for people who turn it on without having opted in to "enable all beta features" [23:01:37] That'd be nice. [23:01:47] OK, cool [23:01:55] Also RoanKattouw you need to vamoose. [23:02:01] yea, ping me if you get into any trouble at all, happy to help until this is friendlier [23:02:59] k, those metrics are now joined https://edit-analysis.wmflabs.org/beta-enables/#projects=testwiki,zhwiki,wikidatawiki,cawiki,urwiki,bswiki,mediawikiwiki/metrics=Content%20Translation [23:03:21] diff for reference: https://meta.wikimedia.org/w/index.php?title=Config%3ADashiki%3AFlowByWiki&type=revision&diff=16432720&oldid=16432711 [23:08:41] RoanKattouw (when you get back), or James_F, https://gerrit.wikimedia.org/r/#/c/342767/ . [23:09:07] Ha. [23:09:12] matt_flaschen: For SWAT? [23:09:18] On Beta Cluster, apparently only enwiki has 'goodfaith' currently, but halfak is adding it to testwiki: https://ores-beta.wmflabs.org/scores/enwiki/goodfaith/?model_info=test_stats&format=json [23:09:23] * James_F nods. [23:09:42] James_F, it's Beta Cluster, so people can +2 anytime, and I can deploy it to prod (you still have to deploy labs to prod to avoid false alarms) [23:09:50] Yeah. [23:10:20] For T160467 Phab says "Halfak moved this task from Active to Done on the Revision-Scoring-As-A-Service board." so is that fixed? [23:10:21] T160467: Enable 'goodfaith' on testwiki on Beta Cluster - https://phabricator.wikimedia.org/T160467 [23:10:34] James_F, he said it needs to be code-reviewed, but I don't know where the patch is. [23:10:40] Ha. [23:10:55] I asked above, but he is AFK. [23:11:19] Doesn't look like it's in https://gerrit.wikimedia.org/r/#/c/342704/ [23:11:41] Is wp10 not wanted in testing enwiki? [23:11:56] matt_flaschen: How does the wgOresWikiId thing explain why I was seeing errors about testwiki on English? [23:12:11] Or did you add that setting just today? [23:12:44] RoanKattouw: Currently wgOresWikiId is hard-coded to BC-testwiki everywhere, this fixes that for BC-enwiki. [23:13:23] RoanKattouw, before it always used testwiki everywhere. But based on InitialiseSettings-labs.php, it was supposed to use enwiki on enwiki (which goodfaith does support on Beta). [23:13:33] RoanKattouw: As of https://gerrit.wikimedia.org/r/#/c/272466/ (13 months ago). [23:13:43] James_F, it does seem to be in there, thanks. 296 of https://gerrit.wikimedia.org/r/#/c/342704/2/config/00-main.yaml . [23:13:51] But why does IS not override CS here? [23:14:10] RoanKattouw, I think Init is loaded at the beginning of Common. [23:14:12] Let me check. [23:14:14] I guess maybe CS just wins? [23:14:32] matt_flaschen: Aha, nice, I just searched for testwiki and gerrit didn't see it but you're right. [23:14:36] I don't fully understand the new extension registration world sometimes [23:17:05] RoanKattouw, InitialiseSettings.php is loaded 4% (thanks emacs ;) ) into CommonSettings.php, InitialiseSettings-labs.php is loaded from the end of InitialiseSettings.php, and CommonSettings-labs.php is loaded from the end of CommonSettings.php [23:17:07] So it's: [23:17:10] 1. Load IS [23:17:17] 2. Load IS-labs (only on labs] [23:17:27] 3. Load meat of CS. [23:17:34] 4. Load CS-labs (only on labs) [23:21:16] James_F, re wp10 I don't know. I just copied wikipedia (which had wp10 false) to enwiki, then overrode enwiki to support 'goodfaith' [23:21:26] * James_F nods. [23:21:57] If we're not planning on exposing wp10 stuff through RCFilters it doesn't matter at all; if we are it means etonkovidova won't be able to QA perfectly but it should be OK. [23:21:58] And I don't think that ordering is new. It has to be that way, for the wmg's to work. [23:22:07] wp10 is an enwiki-only thing, I… think? [23:22:21] James_F, pretty sure it hasn't been spec'ed at all for Beta Filters. [23:22:27] WFM. [23:23:24] matt_flaschen: Want to add goodfaith to shared (testwiki) stuff given it's now done? [23:23:43] Right, makes sense (re ordering) [23:24:33] James_F, no, it's not deployed yet to the ORES service: https://ores-beta.wmflabs.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json [23:24:52] Oh, meh. [23:25:17] In that case, want to deploy? [23:25:36] I meant spec'ed for RC Filters. [23:25:53] I think wp10 is assessing the article, not the revision. It does exist for 3, not just enwiki: https://meta.wikimedia.org/wiki/Objective_Revision_Evaluation_Service/wp10 [23:25:53] Yeah. [23:26:32] Might be an interesting (future) filter – "Edits to important articles", "Edits to unimportant articles". [23:27:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3100184 (10jmatazzoni) @SBisson this is assigned to you because it was... [23:27:26] * ebernhardson might be careful with words like "important articles" :P [23:27:47] ebernhardson: Quite so. [23:28:02] "Edits to valuable articles", "Edits to nonsense articles". ;-) [23:28:36] James_F, wp10 is quality scale, not importance scale. Most WikiProjects have both. [23:28:43] "This article has been rated as FA-Class on the project's quality scale." [23:28:48] "This article has been rated as Top-importance on the project's importance scale." [23:29:00] James_F, I'll ask since SWAT is ongoing. [23:29:27] matt_flaschen: I kid. [23:29:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100362 (10Etonkovidova) [23:31:57] RoanKattouw, are you around? [23:32:23] Yes [23:32:28] (on mobile) [23:33:17] ( mooeypoo ) [23:33:23] Oh, did you go to sfo? [23:33:43] ok nm I found where I was being silly. [23:33:47] Yeah, on the train over there now [23:34:02] * mooeypoo started getting failures because filter conflicts were mapped with "group1_group1_filter1" [23:34:48] scoured the code for where I prefix it twice... [23:34:57] conflict.filter = conflict.group + '_' + conflict.filter; [23:34:57] adjustedConflicts[ conflict.group + '_' + conflict.filter ] = conflict; [23:35:01] pff [23:39:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#2772942 (10Etonkovidova) @jmatazzo... [23:50:06] mooeypoo, I'll put in some code to make sure the names can't contain underscores. [23:50:44] matt_flaschen, name can contain underscores, but the initializer shouldn't double-prefix them :P [23:51:00] I am not getting any info from that name (I don't break it to see what the group name is) it's just a way to create a unique name [23:51:27] ... it would just be great if I don't double-prefix the conflicts, because then the name is not the same as the **actual filter** they reference >.< [23:51:45] mooeypoo, if you have a group called 'a' and a filter called 'b_c', and a group called 'a_b', and a group called 'c' it's a collision. [23:51:55] 'c' should be a filter, I mean. [23:52:53] uh [23:52:57] holycrap [23:53:07] * mooeypoo 's brain explodes [23:53:34] mooeypoo, that's a "it's all so clear now" "brain explodes" right? [23:53:36] matt_flaschen, who's the... why would... what in... [23:53:50] why would anyone name their groups like that [23:54:01] but yes, please, no underscores is a good idea [23:54:09] I can change the name to use : or something too [23:54:10] mooeypoo, I agree, but I could see people using underscores without trying to cause problems. [23:54:11] group1:filter1 [23:54:13] or something [23:54:18] Yes, please. [23:54:20] ok [23:54:26] And I'll still prevent people from using it. [23:54:41] I agree it's unlikely and that's a contrived example, but it shouldn't be possible. [23:55:12] Colon is good [23:55:16] * mooeypoo nods [23:55:33] Luckily, I thought of us having to change the structure so I made groupModel.getNamePrefix() [23:55:43] so if we ever want to change the way naming works, we only change it there [23:55:57] groupModel.getNamePrefix() + filterParamName [23:56:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Special:RecentChangesLinked page does not have "No changes during the given period matching these criteria." - https://phabricator.wikimedia.org/T160482#3100439 (10Etonkovidova) [23:57:33] These conflict unit tests are going to be the end of me [23:58:31] matt_flaschen, AAAAAAAAAAAAAAAAAAAAAAAAA I changed _ to : and now ALL MY TESTS FAIL AGAIN AND AAAAA [23:58:32] * mooeypoo sighs [23:58:36] changing names again [23:59:38] ... [23:59:52] matt_flaschen, now I need to encapsulate them all with quotes