[00:37:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3090026 (10jmatazzoni) @Pginer-WMF, I talked to James about our idea of putting the links into a user-editab... [00:58:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3090055 (10... [01:27:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3090087 (10jmatazzoni) >>! In T149385#3088952, @Mattflaschen-WMF wrote: >> [rollover for tags when ALL filters in the... [04:00:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3090189 (10Catrope) >>! In T156864#3090184, @gerritbot wrote: > Change 342165 had a related pa... [04:03:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3090192 (10Catrope) >>! In T149385#3090087, @jmatazzoni wrote: > **[rollover for tags when selecting redundant ORES f... [04:03:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3090194 (10Mooeypoo) >>! In T156864#3090189, @Catrope wrote: > Second, when the viewport is s... [04:04:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3090196 (10Catrope) >>! In T156864#3090194, @Mooeypoo wrote: > If only popups could adjust the... [04:14:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3090198 (10Catrope) ...and having seen the other messages that are supposed to appear in on-hover popups (the "all se... [04:27:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Unbalanced spacing above and below the active filters label - https://phabricator.wikimedia.org/T159966#3090204 (10Catrope) [09:21:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3090556 (10Pginer-WMF) >>! In T156864#3090189, @Catrope wrote: > @jmatazzoni: I think we need... [09:35:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3090581 (10Pginer-WMF) >>! In T159345#3090026, @jmatazzoni wrote: > Which means I'm back to thinking our best... [11:19:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Unbalanced spacing above and below the active filters label - https://phabricator.wikimedia.org/T159966#3090698 (10Pginer-WMF) The proposal makes the space much bigger than the ~10px reference indicates. When measuri... [14:44:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add technology so we'll be able to track usage of RC Page highlighting - https://phabricator.wikimedia.org/T158344#3091069 (10SBisson) "Adding highlight parameters to the EventLogging schema" can be done but it woul... [16:34:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add technology so we'll be able to track usage of RC Page highlighting - https://phabricator.wikimedia.org/T158344#3091272 (10jmatazzoni) >>! In T158344#3091069, @SBisson wrote: > It would be useful to know what kin... [16:42:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3091275 (10jmatazzoni) @Pginer-WMF asks: > If it is ok to make those links collapsible, why not make them c... [16:48:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3091284 (10Trizek-WMF) If we pack this with the Beta feature and if users's choice is memorized somewhere (co... [16:51:14] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Failed mention and Successful mention notifications don't work on Flow - https://phabricator.wikimedia.org/T160088#3088314 (10Etonkovidova) Confirmed in betalabs. [17:00:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add technology so we'll be able to track usage of RC Page highlighting - https://phabricator.wikimedia.org/T158344#3091304 (10SBisson) >! In T158344#3091272, @jmatazzoni wrote: > ... > If instrumenting highlighting... [17:03:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3091309 (10jmatazzoni) I can certainly shorten the tooltip, but: - The illustration above s... [17:04:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the beta preference option for RC Filters proj... - https://phabricator.wikimedia.org/T159007#3091311 [17:04:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3091313 (10jmatazzoni) BTW, filternames are meant to be displayed in quotation marks. (I can s... [17:17:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the beta preference option for RC Filters proj... - https://phabricator.wikimedia.org/T159007#3091348 [18:08:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3091513 (10Catrope) >>! In T156864#3091313, @jmatazzoni wrote: > BTW, filternames are meant to... [18:48:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3091655 (10Mattflaschen-WMF) [18:48:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2836859 (10Mattflaschen-WMF) [18:50:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3091657 (10Mattflaschen-WMF) >>! In T149385#3090087, @jmatazzoni wrote: > Meanwhile, do you want me to redo the one f... [18:54:29] stephanebisson: The two main things I wanted to work on today are T159763 and T159787. If you'd like to do (or help with) either one of those, take your pick. There's also the frontend-name-collision issue that mooey|lunch said you could work on if you like. [18:54:30] T159787: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787 [18:54:30] T159763: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763 [18:56:11] RoanKattouw: I've leave you T159787. You have all the context since you've done the same thing for ORES. [18:57:06] RoanKattouw: I'm reviewing your ORES patch. I can comment on the tests, and generally, but I can't tell if you're using Matt Filter Definition Technology right [18:57:52] RoanKattouw: After that, I'll take T159763 and support mooey|lunch as needed [18:58:05] OK sounds good [18:59:07] RoanKattouw: I've looked at mw.tract, it's purposefully built for what I'm doing but it needs exactly the same amount of code as using hooks [18:59:17] *mw.track [19:00:27] Does it? There's a generic mw.track listener in EventLogging that logs events [19:05:24] oh, I missed that [19:07:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3091696 (10jmatazzoni) [19:10:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3091711 (10jmatazzoni) @Catrope and @Mattflaschen-WMF, As requested, I've shortened both of the No Effect messages so... [19:10:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3091713 (10jmatazzoni) [19:11:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3091716 (10jmatazzoni) As requested, I shortened these messages somewhat. See T149385 [19:19:33] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 07Community-Wishlist-Survey-2016: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#3091814 (10Stevietheman) I'm thinking this should apply to major editors of a p... [19:35:24] stephanebisson: (Sorry for the delay, was walking to the office) It looks like you can do mw.track( 'event.eventName', { key: value } ); [19:36:38] Does 'event'eventName' need to be registered with the name and version of the schema somewhere? [19:39:44] It magically goes and loads schema.eventName [19:40:03] Which needs to exist, but you already have that [19:40:54] Or... oh. I was confused [19:40:56] Hold on lemme see [19:43:44] stephanebisson: OK, yes, you need an EventLoggingRegisterSchemas hooks in order to expose schemas to the client. It's a bit confusing that WMEvents doesn't do this, but I guess it only contains server-side-only schemas [19:44:06] Oh or just add to EventLoggingSchemas in the extension.json config [20:26:38] I'm going to get lunch and go to the coworking space. [20:43:42] 06Collaboration-Team-Triage, 10Thanks: $1 displayed for Thanks error (upon trying to thank self) - https://phabricator.wikimedia.org/T133003#2216730 (10happy5214) I tried to replicate this bug on enwiki, attempting to thank myself for a revision on my user page, and it gave me the following error message: > Y... [20:53:24] 06Collaboration-Team-Triage, 10Thanks: $1 displayed for Thanks error (upon trying to thank self) - https://phabricator.wikimedia.org/T133003#3092121 (10matmarex) 05Open>03Resolved a:03Anomie It seems this was fixed by {a9cbd9471ba9e9d69c4f40da7bc9c029eb60db83}. Special:Thanks calls the API internally, an... [21:27:06] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3092147 (10srishakatux) @jayvdb I'm wondering if you would be comfortable mentoring this project by yourself, or you would need another m... [21:49:53] (03CR) 10SamanthaNguyen: "Thanks for the feedback - If it's best to abandon this, I'll mark it as abandoned. Thoughts on that?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338704 (https://phabricator.wikimedia.org/T158526) (owner: 10SamanthaNguyen) [21:52:18] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3092174 (10jayvdb) Hi @srishakatux , I guess that depending on the applicant. @happy5214 is interested, has a good background knowledge... [22:49:31] (03Abandoned) 10Mattflaschen: Replace duplicated i18n messages with core provided i18n messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338704 (https://phabricator.wikimedia.org/T158526) (owner: 10SamanthaNguyen) [22:52:34] 06Collaboration-Team-Triage, 10Flow: Flow: Parsoid HTML for videos doesn't work - https://phabricator.wikimedia.org/T63769#3092284 (10Arlolra) [23:19:18] mooeypoo: where does the code live that adds the "New filters for edit review" beta feature? [23:19:31] i mean, the preference. not the actual feature. [23:21:52] nevermind, i found it. WikimediaMessages [23:26:48] RoanKattouw, mooeypoo, have you seen "Error: Called start() outside of a test context too many times" in QUnit? [23:27:27] Not recently, but I think I might have seen it as an intermittent frivolous error sometimes? It can be a legitimate error but only if you're changing async tests [23:27:34] Which you probably are not [23:28:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)): Close small gap between top of the Dropdown Filter Panel and the bottom of the Filter Search Bar - https://phabricator.wikimedia.org/T160213#3092360 (10jmata... [23:28:51] No, not right now. Just trying to fix the rcfilters QUnit. It's showing that instead of the real errors. [23:30:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Recent-changes: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP exceptions) - https://phabricator.wikimedia.org/T160214#3092381 (10matmarex) [23:36:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP except... - https://phabricator.wikimedia.org/T160214#3092415 [23:37:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3092416 (10jmatazzoni) [23:37:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3092419 (10jmatazzoni) [23:39:31] mooeypoo, RoanKattouw, if either of you are available to pair sometime, let me know. In the meantime, I uploaded one of the fixes, so Jenkins can re-run, and I'm running git-update to try to fix QUnit locally. [23:39:49] matt_flaschen: Give me a minute to wrap up this Wikidata change and then I'll pair with you [23:40:12] matt_flaschen: Also if you have uploaded your changes now, I'd like to amend your patch to fix some documentation [23:40:28] Assuming you have no unsubmitted local changes right now [23:41:49] RoanKattouw, yeah, I don't, go ahead. [23:41:55] I'll call you back from the phone room. [23:42:09] OK cool [23:42:33] You might want to look at my conflict patch, it at least deals with the conflict qunit [23:42:39] https://gerrit.wikimedia.org/r/#/c/342284/ [23:45:54] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3092428 (10srishakatux) [23:46:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3092429 (10jmatazzoni) [23:47:56] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3092430 (10srishakatux) [23:54:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3092433 (10jmatazzoni)