[00:00:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3086203 (10jmatazzoni) [00:00:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3086201 (10jmatazzoni... [00:01:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Build user interface for the Highlight Tools and impl... - https://phabricator.wikimedia.org/T149467#3086205 [00:01:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): RC filters - add tooltips to 'Highlight results' button and to the highlig... - https://phabricator.wikimedia.org/T159587#3086204 [00:01:36] (03CR) 10Catrope: [C: 032] Fix RTL popup alignment for changes in OOjs UI 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [00:10:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3086242 (10JKatzWMF) @jmatazzoni on a related note, just caught thi... [00:13:04] (03Merged) 10jenkins-bot: Fix RTL popup alignment for changes in OOjs UI 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [00:18:12] (03CR) 10jenkins-bot: Fix RTL popup alignment for changes in OOjs UI 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [00:19:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 3 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3086293 (10Catrope) [00:20:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 3 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3085950 (10Catrope) Patch is deployed, bug looks fixed to me. [00:25:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 3 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3086300 (10IKhitron) Vv. Thahk you very much for your help.... [00:25:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 3 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3086302 (10IKhitron) 05Open>03Resolved a:03IKhitron [00:25:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 3 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3085950 (10IKhitron) a:05IKhitron>03Catrope [00:28:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Beta-Cluster-Infrastructure, 13Patch-For-Review, 07Performance: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#850716 (10Jdforrester-WMF) Is this still an is... [00:32:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3086344 (10Etonkovido... [00:33:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3054205 (10Etonkovido... [00:37:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3086386 (10jmatazzoni) Thanks @JKatzWMF. Very interesting. I like RT... [00:44:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): RC filters - Clicking on "Show new changes starting from..." does not disp... - https://phabricator.wikimedia.org/T159582#3086486 [00:46:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3086487 (10jm... [00:59:30] (03Draft2) 10TTO: ContributionsQuery: Disregard bots whose group membership has expired [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) [01:00:57] (03CR) 10TTO: "Note I didn't reference the feature flag $wgDisableUserGroupExpiry. On Wikimedia wikis, the column now exists, so the new condition will w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) (owner: 10TTO) [01:04:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): The Filter Search Bar - adjustments to RC page layout - https://phabricator.wikimedia.org/T158018#3086567 (10jmatazzoni) 05... [01:18:12] (03CR) 10Catrope: "Nah, Flow master depending on MW master is fine" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) (owner: 10TTO) [01:18:37] (03CR) 10Catrope: [C: 032] ContributionsQuery: Disregard bots whose group membership has expired [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) (owner: 10TTO) [01:31:01] (03Merged) 10jenkins-bot: ContributionsQuery: Disregard bots whose group membership has expired [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) (owner: 10TTO) [01:31:18] (03CR) 10jenkins-bot: ContributionsQuery: Disregard bots whose group membership has expired [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341943 (https://phabricator.wikimedia.org/T157017) (owner: 10TTO) [02:05:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 07Easy, 06Stewards-and-global-tools (Temporary-UserRights), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Update Flow for expiring user groups - https://phabricator.wikimedia.org/T157017#3086577 (10TTO) [02:05:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Create a way to clear the "Show new changes starting from..." setting - https://phabricator.wikimedia.org/T160028#3086588 (10jmatazzoni) [02:05:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Create a way to clear the "Show new changes starting from..." setting - https://phabricator.wikimedia.org/T160028#3086588 (10jmatazzoni) I'm copying Timo on this, since he is expert in practices on small wikis, where... [02:05:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Create a way to clear the "Show new changes starting from..." setting - https://phabricator.wikimedia.org/T160028#3086601 (10jmatazzoni) I should have said I'm copying @Krinkle, so that he'll see the above question. [02:05:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 06Revision-Scoring-As-A-Service, and 3 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#2840415... [02:06:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport - https://phabricator.wikimedia.org/T160001#3086623 (10Catrope) [02:06:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: RC - Selecting all filters in a group makes them grey out - https://phabricator.wikimedia.org/T156429#3086628 (10Etonkovidova) The fix is in place - the... [02:06:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport - https://phabricator.wikimedia.org/T160001#3085998 (10Catrope) Normally `max-height: 70vh` ensures that this ca... [02:06:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 07Easy, 06Stewards-and-global-tools (Temporary-UserRights), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Update Flow for expiring user groups - https://phabricator.wikimedia.org/T157017#3086654 (10TTO) 05Open>03Resolved a:03TTO [02:08:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): RC filters - 'Restore default filters' should cancel previous selections ... - https://phabricator.wikimedia.org/T159848#3086659 [02:25:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: RC - Selecting all filters in a group makes them grey out - https://phabricator.wikimedia.org/T156429#2974392 (10jmatazzoni) It sounds like the current b... [02:26:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Make it so the Help link on the RC page links to beta feature help for bet... - https://phabricator.wikimedia.org/T158819#3086692 [02:26:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 06Revision-Scoring-As-A-Service, and 3 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3086693... [02:27:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#3086696 (10jmatazzoni) [02:27:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: RC - Selecting all filters in a group makes them grey out - https://phabricator.wikimedia.org/T156429#3086695 (10jmatazzoni) 05Open>03Resolved [03:22:15] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3086723 (10jayvdb) @happy5214 , I've removed myself from other mentoring projects, but I am interesting in doing this one if you want to... [08:11:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): The Filter Search Bar - adjustments to RC page layout - https://phabricator.wikimedia.org/T158018#3086942 (10Pginer-WMF) >>!... [08:28:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3086992 (10Pg... [09:27:08] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3087102 (10Pginer-WMF) >>! In T159942#3086017, @jmatazzoni wrote: > I like the direction you're going here. If I understand c... [10:27:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3087201 (10Pginer-WMF) [10:31:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3087205 (10Pginer-WMF) >>! In T151006#3085699, @jmatazzoni wrote: > Thanks @Pginer-WMF. Let's go with... [10:39:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3087210 (10Trizek-WMF) >>! In T159345#3085735, @jmatazzoni wrote: > Sigh. James says that we can't change th... [10:50:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3087223 (10Trizek-WMF) I've a... [10:55:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3087238 (10Trizek-WMF) Shouldn't we have a "learn more"-like link somethere? [11:47:30] 06Collaboration-Team-Triage, 10Flow, 07I18n, 13Patch-For-Review, 07Technical-Debt: Flow provides custom i18n messages which duplicate core i18n messages - https://phabricator.wikimedia.org/T158526#3087338 (10Liuxinyu970226) >>! In T158526#3039678, @SamanthaNguyen wrote: > Note: Running `grep -ri flow-sho... [12:00:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3087404 (10SBisson) I've updated the text and allowed it to be dismissed by clicking anywhe... [12:09:25] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3087424 (10Lea_WMDE) [12:10:02] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3087441 (10Lea_WMDE) [12:11:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3087444 (10SBisson) This is what it looks like with minimal styling (only to deal with the... [12:30:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3087473 (... [13:38:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3087636 (10Nikerabbit) @jmatazzoni I checked the pages you linked, but it seems they are all user documentation. I was actuall... [13:50:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07I18n, 13Patch-For-Review, and 4 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3087649 (10IKhitron) Hello @Catrope and everyone, here are t... [13:50:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3087650 (... [15:06:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add technology so we'll be able to track usage of RC Page highlighting - https://phabricator.wikimedia.org/T158344#3087912 (10SBisson) a:03SBisson [15:53:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3087473 (... [16:19:05] (03CR) 10Mattflaschen: [C: 04-1] "The general recommendation (https://www.mediawiki.org/wiki/Localisation#Avoid_message_re-use) is not to do this: "Although two concepts ca" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338704 (https://phabricator.wikimedia.org/T158526) (owner: 10SamanthaNguyen) [16:19:45] (03CR) 10Mattflaschen: [C: 04-1] "Translation memory makes it easy for translators to reuse the translation when appropriate." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338704 (https://phabricator.wikimedia.org/T158526) (owner: 10SamanthaNguyen) [16:35:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3088243 (10jm... [17:07:55] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Failed mention and Successful mention notifications don't work on Flow - https://phabricator.wikimedia.org/T160088#3088314 (10Trizek-WMF) [17:21:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3088377 (... [17:41:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes: Handle default for 'string_options' groups - https://phabricator.wikimedia.org/T160092#3088442 (10Mattflaschen-WMF) [17:45:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3088467 (10Trizek-WMF) >>! In T159942#3087102, @Pginer-WMF wrote: >> =Users >> Interesting, but what is the use case here? I... [19:00:54] (03PS5) 10Esanders: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 [19:08:15] (03CR) 10jerkins-bot: [V: 04-1] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:09:45] (03PS6) 10Esanders: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 [19:11:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3088804 (... [19:13:57] mooeypoo, should I change _ to j or something (i is taken), or just leave it? [19:18:27] RoanKattouw, is: [19:18:29] data.filters[ i ].class [19:18:31] safe now? [19:18:46] That requires ES5 support at the syntax level (not poly-fillable) IIRC. Not sure if we still support any browser without that. [19:18:54] matt_flaschen, RoanKattouw commented on it too about it being an unused param -- **personally** I would name it something even if it's unused, since we don't see that pattern in JS that much, but if not, we can also just document it with a comment or something. It's just something I've never seen in JS before, so I don't think our styleguide is for it. [19:19:12] jQuery usually just uses something like function ( i, element ) { ... } and never uses i or something [19:19:15] Hmm, not sure [19:19:27] That's a question for Krinkle or James_F [19:19:54] I think it probably safest to rename tht key [19:19:56] is that the css class? [19:20:01] mooeypoo, yeah. Will do. [19:20:10] matt_flaschen: MW requiring ES5 parsing support is coming, but not for a few months. [19:20:11] we are using a literal "cssClass" for highlights in the JS side [19:20:36] Thanks, James_F [19:21:00] 'cause also you run into things like having a getter "getClass()" which makes it sound like you're asking for a JS object/class and is confusing. [19:21:58] stephane and I went back and forth on naming the 'cssClass' property for highlights for that. We started out with "class" from the backend and "class" in the front, but then renamed it to "identifier" which was still confusing, and so we just settled on the more understandable "cssClass" :p [19:22:34] Only on the front-end of the front-end. [19:22:42] yeah [19:22:53] matt_flaschen, I'm thinking of starting a patch above yours to implement the popup-message for conflicts [19:23:07] but I don't want to mess up your work -- you think that's okay or should I wait? [19:23:32] mooeypoo, no, go ahead. I was thinking that would be a good approach. [19:23:42] It's rebased already. [19:24:25] I'm going to head into the office now [19:24:41] When I get there I will work on updating my ORES patch for the changes in Matt's patch [19:24:43] matt_flaschen, RoanKattouw am I missing something? in initializeFilters, 'filters' is now an array, not an object, right? [19:24:54] matt_flaschen: When are you taking off, and what remains to be done on your patch? [19:25:07] I think we can do filters.forEach( function ( data ) { ... } ); instead of $.each( filters, function ( _, data ) { ... } ) [19:25:23] I didn't load the code to verify it's an array yet though, so just checking [19:25:32] mooeypoo, yes, that's intentional. Order of iteration is not defined in JavaScript for objects. This way you can iterate the array in the same order every time. [19:25:36] I fixed that already, though. [19:25:51] wait, $.each() preserves order!? [19:25:56] and .forEach() doesn't!? [19:26:09] I thought that array order is always preserved -- just not key order in objects [19:26:12] mooeypoo, it's not a question of the wrapper, since ultimately it's on top of the low-level iteration. [19:26:17] it's only defined for arrays. [19:26:37] If I loop over { foo: 1, bar: 2 }, foo and bar can be in different orders in different browsers. [19:26:51] yeah, but you're iterating over arrays, not object keys [19:26:51] mooeypoo, wait, I missed your last comment. [19:26:58] It sounds like Moriel's point is that you can use .forEach() and .map() instead of $.each() and $.map() [19:27:05] yep [19:27:06] Because es5-shim polyfills those things [19:27:12] and that's the pattern we're usually using, too [19:27:22] (And we are soon going to only serve JS to ES5 clients anyway) [19:27:24] Also, I think that would make it possible to get rid of the unused param there [19:27:26] mooeypoo, yeah, I changed it to array on purpose. Sorry, I misinterpreted "am I missing something? in initializeFilters, 'filters' is now an array, not an object, right?" [19:27:31] Yeah, will fix. [19:27:36] * mooeypoo nods [19:27:46] wasn't 100% sure so I didn't want to leave a CR before I validate [19:27:54] matt_flaschen: Anyway, so what are the remaining TODOs, and how can we help move this along while you're out later today? [19:28:19] RoanKattouw, not sure yet, I can keep working on it for now. [19:29:22] RoanKattouw, remaining TODOs are basically: fix conflicts, random front-end regressions I don't know about yet, fix Jenkins. [19:29:30] OK [19:29:50] T151873 (including the weird hidebots + hideliu + etc. redirect) needs to be merged in conjunction. That is assigned to Stephane, but I could amend it. [19:29:50] T151873: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873 [19:30:27] RoanKattouw, I think Moriel is going to fix conflicts and add the messages. [19:30:45] matt_flaschen, you can prioritize the random UI regressions lower if you want and I'll fix them [19:30:49] up to you [19:31:07] OK so Stephane's patch needs to be rebased onto yours and integrated somehow, possibly using conflicts from the definitions [19:31:32] I will fix up + rebase my ORES patch and add subsets [19:31:51] It sounds like Moriel will deal with front-end conflict stuff and any other front-end regressions [19:32:18] Then after the ORES patch I will look at rebasing/integrating Stephane's patch for the redirect thing [19:32:59] But first, I will walk to the office [19:34:05] RoanKattouw, the redirect thing is not considered a conflict. There are lots of those (e.g. hideminor=1&hidemajor=1), but they're not marked as conflicts because they're impossible to create in the UI. [19:34:10] It's really just one back-compat redirect we need. [19:34:15] Hmm OK [19:34:54] Stephane's patch does something different [19:35:08] https://www.irccloud.com/pastebin/SblGaXkF/ [19:35:33] I've only skimmed the rest of the patch but I think that snippet tells you all you need to know [19:36:16] RoanKattouw, yeah, you're right. [19:36:34] Anyway, I'm heading out for real now. Let us know where you're at and how we can help when you do leave for the day [19:38:06] I was just looking at it too. It is a type of conflict (and they are redirects), but not quite the same as how we define conflicts. [19:38:22] I think it's basically just if everything in a ChangesListBooleanFilterGroup is on/active/hidden. [19:39:08] mooeypoo, yeah, you can do the remaining front-end stuff that blocks merge of this. I don't know what it is, though. [19:41:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14), 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Unbalanced spacing above and below the active filters... - https://phabricator.wikimedia.org/T159966#3088891 [19:41:24] matt_flaschen, I'll work on a subsequent commit on top [19:41:50] matt_flaschen, also, eh, how does this pass tests... [19:42:00] did you change the JS tests? [19:42:17] It should fail now, I think. We're using object for tests in JS in initializeFilters() [19:43:24] ah, it doesn't. I can change that too [19:43:24] (03CR) 10Jforrester: [C: 031] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:43:59] mooeypoo, you don't need to find the QUnit, since I need to do that to get my patch passing. [19:44:44] yeah I was just surprised it would pass given that we're feeding the test the wrong structure now, but then noticed it doesn't anyways [19:44:56] Are you going to fix up the tests or do you want me to? [19:45:21] mooeypoo, I will. [19:45:36] matt_flaschen, I'm going to change the initialize method to feed down the conflicts to the filters [19:45:44] you're giving some of them in the group level [19:46:03] mooeypoo, yeah, they're bidirectional, but any combination is allowed. [19:46:07] Thanks. [19:46:25] Which is fine, I just want to avoid adding conflict consideration to the JS groups because that would likely just add unnecessary complexity to the already-complex "find conflicts" algorithm [19:46:43] so yeah, i'll just have the initializeFilters assess and "feed" the group conflicts down to all filters [19:57:29] matt_flaschen, is the 'subset' definition the same as the 'conflict' definition (containing message + group + affected filters) ? [19:57:44] did we need specialized messages for that, I don't remember. [19:57:50] I can't find an example of a subset yet, so not sure [19:59:18] mooeypoo, yes, except there is no global message if I read it right, just a single context (tooltip) one. [19:59:23] mooeypoo, yeah, it's ORES, one sec. [19:59:43] * mooeypoo nods [20:00:03] I need to change the way the filters store and fetch the conflicts so I want to see if it's also subsets [20:00:28] [rollover for tags when selecting redundant ORES filters] [20:00:30] The ["SelectedFiltername"] filter as no effect currently because its results are a subset of “Filtername b.” Consider highlighting with a color to distinguish. [20:00:45] mooeypoo, yeah, it is: T149385 [20:00:46] T149385: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385 [20:00:55] yeah, I wasn't sure I remembered something like that [20:01:10] btw, I'm about to do a bit of a massive rewrite of initializeFilters part about conflicts/subsets -- should I wait a bit for you to send your new patch ? [20:01:13] mooeypoo, to (possibly) make it mildly easier, I added the group here too, even though subsets only make sense within the same group (I throw an exception if it's *not* the same group) [20:01:14] actually, I'm going to get lunch anyways [20:01:22] * mooeypoo nods [20:01:51] yeah I'm going to make the filters store all that info, but then output the array of filter *names* for the reassessFilterInteraction algorithm [20:02:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3088952 (10Mattflaschen-WMF) > [rollover for tags when ALL filters in the same group are selected] > The ["SelectedFi... [20:02:26] so having that information is good in any case, but the adjustment will just be a bit bigger than just a small how to read it change [20:02:47] the items will need to store and then give out the proper info depending on what is needed for the messages, too. [20:02:57] anyways, I'm going to get lunch, be back in a bit [20:03:43] mooey|lunch, yeah, I know. I only did that quick map thing to make sure I didn't cause a regression for the existing subset code. [20:05:23] mooey|lunch, not sure if relevant, but RoanKattouw and I agreed that filter names are not unique at a global level and we will not try to make them. Just mentioning in case. [20:11:04] (03PS6) 10Fomafix: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323677 (https://phabricator.wikimedia.org/T117845) [20:13:21] (03PS3) 10Fomafix: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/323684 (https://phabricator.wikimedia.org/T117845) [20:22:28] mooey|lunch: 'cssClass' => ChangesListBooleanFilterGroup::class, [20:45:00] matt_flaschen: Ahm, that seems wrong? [20:45:10] Find+replace snafu? [20:45:15] RoanKattouw, yeah, it was a reference to her similar find-replace faux-pas a while back. [20:45:22] Fixed, not actually uploaded. [20:46:00] haha [20:46:02] I see [21:14:12] matt_flaschen: Wait, so I'm looking at setAsSupersetOf(), and the docs say "This means that anything in the results for the current filter is also in the results for the other one.", but doesn't that mean that this is a *sub*set of other? [21:14:45] If $this is a superset of $other, then everything that appears in the results of $other also appears in the results of $this, not the other way around, right? [21:18:08] RoanKattouw, doh, fixed, thanks. [21:18:33] Just to check, $newDamagingGroup->getFilter( 'maybebad' )->setAsSupersetOf( $newDamagingGroup->getFilter( 'likelybad' ) ); is the right way around, right? [21:18:48] Yes, since maybe bad is a superset of likelybad. [21:18:58] Cool, thanks [21:19:21] RoanKattouw, mooey|lunch, anything else you would like to discuss before I head out? [21:19:58] Ah you uploaded a new patch, I'll look [21:20:09] matt_flaschen: Any TODOs that we can help with in your absence? [21:20:35] In addition to small stuff you mentioned (and a minor issue with attribution), I started fixing the QUnit, but it's not done. [21:21:01] You can pick up anything, or I will come back to it tomorrow. [21:21:09] OK, cool [21:21:31] After I finish the ORES patch I'll try to fix QUnit [21:21:37] And work with Moriel and front-end stuff [21:21:56] Okay, thanks, I'll talk to you soon. [22:17:55] 06Collaboration-Team-Triage, 10Flow, 10Parsoid, 07Parsoid-Token-Stream-Transforms: LInks: Add support for self-links - https://phabricator.wikimedia.org/T69486#3089625 (10Jdforrester-WMF) [22:18:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342115 (owner: 10L10n-bot) [22:20:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/342112 (owner: 10L10n-bot) [23:41:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3089876 (... [23:56:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), and 2 others: Unbalanced spacing above and b... - https://phabricator.wikimedia.org/T159966#3089947