[00:04:29] (03CR) 10Catrope: [C: 032] Add and listen to 'modified' event for popup clip() [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341709 (owner: 10Catrope) [00:04:49] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 4 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3082440 (10matmarex) [00:19:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082515 (10Mooeypoo) This should be fixed with this commit: https://gerrit.wikimedia.org/r/#/c/341702 It's also being deplo... [00:19:22] (03Merged) 10jenkins-bot: Add and listen to 'modified' event for popup clip() [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341709 (owner: 10Catrope) [00:19:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082516 (10Mooeypoo) @Etonkovidova this should already be fixed in beta labs. [00:19:50] etonkovidova, can you double-check the crazy popup bug in beta? RoanKattouw is deploying to production but it should have already fixed beta [00:20:04] mooeypoo: checking.... [00:20:06] etonkovidova, this T159888 [00:20:06] T159888: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888 [00:22:05] (03CR) 10jenkins-bot: Add and listen to 'modified' event for popup clip() [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341709 (owner: 10Catrope) [00:27:15] mooeypoo: T159888 seems to be fine [00:27:21] T159888: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888 [00:27:39] \o/ [00:27:42] thanks etonkovidova [00:27:48] It should be in production soon [00:28:01] quiddity, the fix is being deployed now - thanks for reporting this [00:28:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082544 (10Etonkovidova) Checked in betalabs - the issue is not present anymore. [00:28:06] :> [00:28:12] I still don't know why the race condition was exposed *now* [00:28:16] I mean... this code existed for months [00:28:24] but it's fixed now (hopefully) [00:44:36] It's deployed but I'm not trying to figure out why it broke in the first place [00:46:41] Partial answer: clippable mis-measures the height of the popup for some reason, and then tries to set the height of the popup body to -602px [00:48:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3082636 (10jmatazzoni) [00:51:22] RoanKattouw, another point of consideration -- the "use event when dom is ready" **fixes** it [00:51:44] So the consideration of the fact that the clip tried to clip *before* the DOM was ready may have something in it? [01:00:50] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3082697 (10Jdforrester-WMF) [01:07:54] (03CR) 10Jforrester: [C: 032] Add namespace translations for Western Punjabi (pnb) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341714 (https://phabricator.wikimedia.org/T157871) (owner: 10Bartosz Dziewoński) [01:13:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3082782 (10jmatazzoni) [01:14:54] 06Collaboration-Team-Triage, 10Notifications: Develop a properly-designed way to tag groups of users - https://phabricator.wikimedia.org/T148154#3082789 (10DannyH) [01:20:44] (03PS1) 10Catrope: Revert "Remove FloatableElement hack, no longer needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341725 (https://phabricator.wikimedia.org/T159888) [01:21:12] (03Merged) 10jenkins-bot: Add namespace translations for Western Punjabi (pnb) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341714 (https://phabricator.wikimedia.org/T157871) (owner: 10Bartosz Dziewoński) [01:23:13] (03PS2) 10Catrope: Revert "Remove FloatableElement hack, no longer needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341725 (https://phabricator.wikimedia.org/T159888) [01:25:59] (03CR) 10jenkins-bot: Add namespace translations for Western Punjabi (pnb) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341714 (https://phabricator.wikimedia.org/T157871) (owner: 10Bartosz Dziewoński) [01:26:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3082847 (10jmatazzoni) @Pginer-WMF, I've got a couple of suggested changes to this ticket. Let me know... [01:27:51] (03CR) 10Jforrester: [C: 032] "Oy." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341725 (https://phabricator.wikimedia.org/T159888) (owner: 10Catrope) [01:30:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3082875... [01:34:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3082878 (10jmatazzoni) @Pginer-WMF, what do you think about including a "Learn more" link to [[ https://www.media... [01:48:28] (03Merged) 10jenkins-bot: Revert "Remove FloatableElement hack, no longer needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341725 (https://phabricator.wikimedia.org/T159888) (owner: 10Catrope) [01:51:02] (03CR) 10jenkins-bot: Revert "Remove FloatableElement hack, no longer needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341725 (https://phabricator.wikimedia.org/T159888) (owner: 10Catrope) [01:54:51] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#2892002 (10Legoktm) The job queue already supports delayed jobs, w... [02:03:25] matt_flaschen: When defining a filter group in an extension (where I don't have access to registerFiltersFromDefinitions()), 'priority' is not optional. Could it be made optional and default to the lowest value? That would make it a lot easier to write "don't care" care [02:03:29] *"don't care" code [02:05:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): RC filters - 'Restore default filters' should cancel previous selections ... - https://phabricator.wikimedia.org/T159848#3082947 [02:06:32] RoanKattouw, yeah, but don't we want ORES at the top? [02:06:46] matt_flaschen: Yes, but I'm configuring the legacy ORES filter now [02:06:53] So yeah for the new-style ones I have to set priority [02:07:05] Yeah, will do. [02:07:08] But for the old-style "Hide probably good edits" I don't [02:07:09] Cool [02:08:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): [minor] RC filters - "Below are the changes since... " is partially displa... - https://phabricator.wikimedia.org/T159766#3082958 [02:09:29] I've set it to 'priority' => -1, for now [02:13:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): RC filters - colored bullet points displayed overlapped - https://phabricator.wikimedia.org/T159586#3082963 (10Etonkovidova)... [02:26:48] matt_flaschen: Also, can 'default' be made optional? (Defaulting to false / NONE as appropriate) [02:27:03] Right now if I don't pass it I get a crash from inside FormOptions [02:29:04] RoanKattouw, that one probably shouldn't be optional (even old RecentChanges class passes it in), but I will throw it directly. [02:29:27] Because people might not know whether it defaults to hidden or shown. [02:29:29] OK, yeah that would work too [02:29:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Build user interface for the Highlight Tools and impl... - https://phabricator.wikimedia.org/T149467#3082984 [02:29:49] Right now it tries to call FormOptions::add('blah', null) which calls FormOptions::guessType(null) which barfs [02:29:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): RC filters - colored bullet points displayed overlapped - https://phabricator.wikimedia.org/T159586#3082983 (10jmatazzoni) ... [02:30:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): [minor] RC filters - "Below are the changes since... " is partially displa... - https://phabricator.wikimedia.org/T159766#3082985 [02:31:34] Hmm, why does my code work on watchlist [02:31:37] I feel like it shouldn't [02:31:54] Ooh nm [02:31:58] I'm confusing watchlist with contributions [02:35:47] 18:35:32  (PS1) Catrope: [WIP] Add ORES filters to new RCFilters [extensions/ORES] - https://gerrit.wikimedia.org/r/341732 (https://phabricator.wikimedia.org/T158459) [02:36:20] Need to clean that up a bit (remove old hooks etc), but I got it working already, both in the old and the new UI [02:36:43] I'm going home now, but tomorrow I'll remove the old hooks and clean up what I can [02:37:02] Oh and I need to add subset registration still once that is available, but that should be easy [02:38:17] ( matt_flaschen FYI ---^^ ) [02:40:02] Thanks, I'll ping you when that's up. [02:53:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3083013 (10Etonkovidova) @SBisson It seems that something else... [03:40:47] 06Collaboration-Team-Triage, 10Notifications: Idea: Make the use of ping more easy for new users - https://phabricator.wikimedia.org/T159908#3083065 (10Legoktm) [07:17:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3083219 (10Pginer-WMF) > Coloring the summary line isn't logical, since different colors might apply to different changes hid... [07:20:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3083223 (10Pg... [07:36:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3083228 (10Pginer-WMF) >>! In T151006#3082847, @jmatazzoni wrote: > @Pginer-WMF, I've got a couple of... [08:11:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3078912 (10Nikerabbit) Is this something you are planning to do, or are you seeking for someone else to work on this? If forme... [09:20:07] 06Collaboration-Team-Triage, 10Notifications: Email notifications - https://phabricator.wikimedia.org/T159920#3083377 (10Alicia_Fagerving_WMSE) [09:27:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3083399 (10Trizek-WMF) >>! In... [09:40:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3083461 (10Trizek-WMF) >>! In T159345#3075151, @Pginer-WMF wrote: >>>! In T159345#3065456, @jmatazzoni wrote:... [10:51:52] (03PS6) 10WMDE-Fisch: DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) [10:52:34] (03CR) 10WMDE-Fisch: "PS6: Manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [10:56:40] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#3083724 (10TTO) >>! In T153817#3082933, @Legoktm wrote: > The job... [10:58:32] (03CR) 10jerkins-bot: [V: 04-1] DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [11:00:35] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 5 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3083743 (10matmarex) @75.Abbasdhothar Is it possible to use a different translation for "REDIRECT" that is only a single word (no spaces)?... [12:00:43] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 07Tracking: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3083836 (10Pginer-WMF) [12:09:10] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 5 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3083849 (1075.Abbasdhothar) yes ,translate redirect as: REDIRECT=مڑجوڑ [12:12:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3083853 (10SBisson) @Etonkovidova the lines you have circled in... [12:15:31] 06Collaboration-Team-Triage, 10Notifications: Email notifications - https://phabricator.wikimedia.org/T159920#3083858 (10Aklapper) @Benjaminikuta: Is this the same as T90067 ? [12:18:33] 06Collaboration-Team-Triage, 10Notifications: Email notifications - https://phabricator.wikimedia.org/T159920#3083873 (10Benjaminikuta) @Aklapper I think so. [13:16:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3083963 (10Pginer-WMF) [13:17:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#2621630 (10Pginer-WMF) I described a system to support the more complex filters t... [13:21:20] 06Collaboration-Team-Triage, 10Notifications: Idea: Make the use of ping more easy for new users (e.g. when a username is prefixed by '@') - https://phabricator.wikimedia.org/T159908#3083989 (10Aklapper) [13:39:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3084032 (10Pginer-WMF) >>! In... [13:51:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3084070 (10Pginer-WMF) >>! In T159010#3082878, @jmatazzoni wrote: > @Pginer-WMF, what do you think about includin... [13:57:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3084092 (10Trizek-WMF) >>! In... [15:07:42] 06Collaboration-Team-Triage, 10Flow, 07Tracking: Flow's keyboard-shortcuts / access-keys / hotkeys (tracking) - https://phabricator.wikimedia.org/T108739#3084309 (10Trizek-WMF) [15:07:44] 06Collaboration-Team-Triage, 10Flow: Have all VE sequences available on Flow - https://phabricator.wikimedia.org/T134167#3084306 (10Trizek-WMF) 05Open>03Resolved a:03Trizek-WMF All shortcuts have been solved by https://gerrit.wikimedia.org/r/#/c/340541/, except shortcut to save a post, handled by {T63517... [15:09:40] RoanKattouw, what is the status for this task? https://phabricator.wikimedia.org/T150999 [15:37:21] 06Collaboration-Team-Triage, 10Notifications: Email notifications - https://phabricator.wikimedia.org/T159920#3084395 (10Aklapper) [15:37:24] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Email notifications sent both by Echo for core edits and by Flow for replys/mentions/etc should include as much context as is feasible so i can just read my email and not visit the website. - https://phabricator.wikimedia.org/T90067#3084398 (10Aklapper) [16:15:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3084504 (10jmatazzoni) Nonono... [16:26:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Bot' and Experience level /Page Edits filters selection - https://phabricator.wikimedia.org/T159184#3084542 (10jmatazzoni) Part of the reason I'm not concerned is that users who don't want to see bots... [16:40:38] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Mobile, 13Patch-For-Review, 07User-notice-collaboration: [mobile] Special:Notifications the counter does not display the count - https://phabricator.wikimedia.org/T150999#3084573 (10Catrope) Per Elena's comment on Nov 28, this seems fixed? Not s... [16:42:41] Thanks RoanKattouw ! [17:03:09] (03PS37) 10Etonkovidova: [WIP] RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [17:15:02] (03PS38) 10Etonkovidova: [WIP] RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [17:42:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3084686 (10Etonkovidova) >the lines you have circled in red are... [17:53:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Build user interface for the Highlight Tools and impl... - https://phabricator.wikimedia.org/T149467#3084754 [17:55:01] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 07Tracking: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3084770 (10jmatazzoni) [17:55:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15), 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Build user interface for the Highlight Tools and impl... - https://phabricator.wikimedia.org/T149467#3084769 [17:59:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters UI ViewModel: Create group models in the ViewModel and attach to FilterGroupWidgets - https://phabricator.wikimedia.org/T156533#3084786 (10jmatazzoni) [17:59:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - filter search area (FF only): lower border is missing when the filter drop down is displayed - https://phabricator.wikimedia.org/T158931#3084787 (10jmatazzoni) [18:00:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): RC filters: filter selector drop down is misplaced in RTL - https://phabricator.wikimedia.org/T157189#3084788 (10jmatazzoni) [18:00:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): RC filters - Console errors for clicking on selected filters - https://phabricator.wikimedia.org/T158368#3084789 (10jmatazzo... [18:04:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): RC filters - add tooltips to 'Highlight results' button and to the highlig... - https://phabricator.wikimedia.org/T159587#3084795 [18:25:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14), 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Unbalanced spacing above and below the active filters... - https://phabricator.wikimedia.org/T159966#3084859 [18:26:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14), 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Unbalanced spacing above and below the active filters... - https://phabricator.wikimedia.org/T159966#3084859 [18:30:29] RoanKattouw, realized I should create a better class hierarchy for the two kinds of filters, or we're going to regret it when we add 'tagfilter', etc. [18:30:33] Shouldn't take long. [18:30:55] Something like ChangesListBooleanFilter and ChangesListGroupedStringFilter [18:30:59] Oh you mean STRING_OPTIONS vs the other one? [18:31:00] Ah yes [18:31:46] Then we can just add ChangesListStringFilter (not in this patch, but the opening is there for later) for simple string filters that don't work in groups [18:32:06] ? [18:32:31] Like tagfilter would be ChangesListStringFilter, once it's ported to the new UI. [18:32:41] I wouldn't do that now, but the better class hierarchy would make room for it. [18:33:37] Oh, I see [18:34:10] Yeah it's also kinda awkward to have to make a group for individual hideblah filters for the old UI [18:34:29] But I can see how it is useful to group hideliu and hideanons together [18:34:52] RoanKattouw, you can add it core's 'unstructured' group if you want. [18:34:53] RoanKattouw: https://phabricator.wikimedia.org/project/edit/2415/ [18:35:10] And now https://phabricator.wikimedia.org/project/edit/2659/ [18:35:11] Hah, didn't know that existed [18:35:15] I did consider that (unnecessary groups), but consider we're moving away from that UI, I thought it was fine. [18:35:57] RoanKattouw, but hideliu and hideanons are the same filters in the old and new UI. [18:36:12] Same object, same behavior, just doesn't display in a group in the old one. [18:36:19] Yeah, true [18:36:29] And yeah unnecessary groups aren't a big deal [18:49:27] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Mobile, 13Patch-For-Review: [mobile] Special:Notifications the counter does not display the count - https://phabricator.wikimedia.org/T150999#3084938 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [19:24:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3085138 (10Etonkovido... [19:25:19] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 4 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3019286 (10matmarex) 05Open>03Resolved All done. The new translations should become available on Western Punjabi Wikipedia next week,... [19:40:34] matt_flaschen: Do you have any thoughts on how I can do the query modifications that ORES needs to do even when not filtering? (It needs to join and get the scores for each row so it can add the "r"s) [19:41:00] I suppose I could just add this unconditionally from the old ChangesListQuery hook or something [19:51:40] RoanKattouw, yeah, ChangesListSpecialPageQuery is not deprecated, you can still use that. [19:51:50] OK, cool, will do [19:52:37] Flow does something similar with ChangesListInitRows, but if you just need a join, that is probably more appropriate. [19:52:44] ^ RoanKattouw [19:52:56] Hi, there is in the fatalmonitor logs a small message (twice): 2 Warning: Invalid parameter for message "flow-rev-message-hid-post": a:1:{s:9:"plaintext";N;} in /srv/mediawiki/php-1.29.0-wmf.14/includes/Me [19:52:57] Hmm OK will look [19:53:00] ssage.php on line 1172 [19:53:03] ^ [19:53:12] That's probably a typo? -hid- instead of -hide- ? [19:53:33] Or... maybe it's that weird bug again where it's doing weird black magic with arrays [19:53:47] I thought I had fixed that earlier [19:57:31] RoanKattouw: https://phabricator.wikimedia.org/T159888 is scheduled only for .wmf16 ? Not cherry-picked? [19:58:00] No that was cherry-picked, the bot just doesn't understand that [19:58:02] I'll retag it [19:58:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3085346 (10Catrope) [20:09:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Create a delay when opening the RCFilters CapsuleItemWidget "description/c... - https://phabricator.wikimedia.org/T158993#3053825 [20:18:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Create a delay when opening the RCFilters CapsuleItemWidget "description/c... - https://phabricator.wikimedia.org/T158993#3085436 [20:40:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Make it so the Help link on the RC page links to beta feature help for bet... - https://phabricator.wikimedia.org/T158819#3048337 [21:19:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): The Filter Search Bar - adjustments to RC page layout - https://phabricator.wikimedia.org/T158018#3085588 (10Etonkovidova) V... [21:23:21] matt_flaschen: Is it possible to modify the text of built-in buttons in a guided tour? I have buttons: [ { namemsg: 'some-message', action: 'end' } ] and it only shows the default check mark, not the message text. [21:23:57] stephanebisson, IIRC, no. Let me check. [21:24:19] If I make it a custom button ( { namemsg: 'some-message', action: 'okay', onclick: ... } it works but then it adds another standard 'end' button after [21:25:13] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#3085598 (10Tgr) [21:26:00] stephanebisson, it looks like you can, but you have to use name:, and call mw.message yourself. [21:26:14] oh, let me try [21:26:26] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#677888 (10Tgr) [21:26:45] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#677888 (10Tgr) [21:26:46] stephanebisson, if that doesn't work, you can pass allowAutomaticOkay: false to block thte automatic end. [21:28:52] matt_flaschen: in the step of tour config? [21:28:56] or* [21:29:42] stephanebisson, yep, step level. [21:30:21] It looks like the name thing should work, though (getActionButton) [21:34:36] matt_flaschen: AFAICT it works for custom buttons (without { action: ... } ) [21:35:15] stephanebisson, the name part? [21:35:23] yep [21:36:47] matt_flaschen: FYI: https://gerrit.wikimedia.org/r/#/c/341860/ [21:37:19] stephanebisson, okay, I'll try that in a sec. [21:48:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3078912 (10jmatazzoni) Hi @Nikerabbit, Thanks for asking. These documentation pages are good sources of info (though they are... [21:51:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085681 (10SBisson) Do we want to message to close when the user clicks on the page, outsid... [21:53:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3085685 (10Mattflaschen-WMF) >>! In T159795#3083241, @Nikerabbit wrote: > Is this something you are planning to do, or are you... [21:53:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3085699 (10jmatazzoni) Thanks @Pginer-WMF. Let's go with this text: **Color Code Your Results** Use... [21:56:07] RoanKattouw, do we really need the non-standard GuidedTour formatting? [21:56:21] What non-standard formatting? [21:56:31] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/341860/2/modules/rcfilters-beta-tour.less . [21:57:43] Maybe not. Depends on what it looks like with and without those styles. Generally speaking, though, I'm in favor of using standard tools and libraries and if we don't like their appearance, fixing the tool/library rather than customizing [21:57:55] Other than the background. [21:58:29] I'm prepping for the revision table RFC meeting in two mins, but after that I can take a look at that patch and try it with and without those styles [21:59:27] ^ stephanebisson [22:01:13] stephanebisson, I see what you mean. It works internally (and for the ARIA label), but not really. [22:01:19] Although this is also the library convention. [22:03:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3085735 (10jmatazzoni) [22:03:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3064846 (10jmatazzoni) Sigh. James says that we can't change the links without some kind of community proces... [22:14:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3085757 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni As... [22:15:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085774 (10Mattflaschen-WMF) >>! In T159010#3082301, @Mattflaschen-WMF wrote: > The BetaFea... [22:15:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3082636 (10jmatazzoni) [22:33:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085801 (10jmatazzoni) [22:35:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085810 (10jmatazzoni) >>! In T159010#3085681, @SBisson wrote: > Do we want to message to c... [22:36:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085811 (10jmatazzoni) @SBisson, please note that I've changed the text. In particular, I w... [22:39:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3085829 (10jmatazzoni) [22:52:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3085871 (10Etonkovidova) Checked with wmf.15 (testwiki and... [23:10:21] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3085950 (10IKhitron) [23:10:38] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3085963 (10IKhitron) p:05Triage>03Unbreak! [23:15:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3085967 (10jmatazzoni) >>! In T159010#3085810, @jmatazzoni wrote: >>>! In T159010#3085681,... [23:17:07] 15:16:46  (PS2) Catrope: Add ORES filters to new RCFilters [extensions/ORES] - https://gerrit.wikimedia.org/r/341732 (https://phabricator.wikimedia.org/T158459) [23:18:27] matt_flaschen: I un-WIPed my ORES patch --^^, it still needs subset support but that's about it. There's more things we need to do there like make the old filter use one of the new categories instead of having its own thresholds, but we can do that later [23:20:51] Cool [23:22:06] RoanKattouw, did you see T159999 ? [23:22:07] T159999: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999 [23:22:16] Whoa wat [23:22:18] Looking now [23:22:55] His screenshots didn't come through to wikitech-l, unsurprisingly [23:23:22] But yeah it's pretty broken in RTL [23:24:47] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3085950 (10Catrope) This is what I see, which doesn't look as terrible as what @IKhitron describes but does look pretty broken: {F6347831} [23:26:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport - https://phabricator.wikimedia.org/T160001#3085998 (10Etonkovidova) [23:27:00] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3086010 (10IKhitron) It looks fine, indeed. So maybe it works different in different circumstances. Please see the screenshots I sent. [23:28:23] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3086012 (10IKhitron) By the way, maybe your screen just have more width than mine. See the bubbke arrow on you screen, it's in wrong pos... [23:31:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3086017 (10jmatazzoni) I like the direction you're going here. If I understand correctly, the User, Namespace and Tags button... [23:33:41] OK, I've found the cause [23:33:47] matt_flaschen: Thanks for bringing that to my attention [23:34:13] One of my OOUI changes in last week's release broke it, and then my popup changes in this week's release broke it differently [23:35:22] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL, 07Regression: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3086025 (10Catrope) Yes, if I narrow my screen the popup runs off-screen. I can't use the screenshots you sent because they never made i... [23:36:40] (03PS1) 10Catrope: Fix RTL popup alignment for changes in 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) [23:37:07] (03PS2) 10Catrope: Fix RTL popup alignment for changes in OOjs UI 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) [23:38:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3086046 (10jmatazzoni) [23:38:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 07Tracking: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3086047 (10jmatazzoni) [23:38:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3086044 (10jmatazzoni) 05Ope... [23:40:10] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 13Patch-For-Review, and 2 others: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3086064 (10IKhitron) Thank you! About the files, I checked now, they wait for moderation. [23:41:01] (03PS1) 10Catrope: Fix RTL popup alignment for OOjs UI 0.19.5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341931 (https://phabricator.wikimedia.org/T159999) [23:41:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3086088 (10jmatazzoni) [23:42:14] (03CR) 10Jforrester: [C: 031] Fix RTL popup alignment for OOjs UI 0.19.5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341931 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [23:42:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3054205 (10jmatazzoni... [23:42:57] (03CR) 10Jforrester: [C: 031] Fix RTL popup alignment for changes in OOjs UI 0.19.4 [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341927 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [23:43:27] (03CR) 10Jforrester: [C: 032] Fix RTL popup alignment for OOjs UI 0.19.5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341931 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [23:45:46] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 13Patch-For-Review, and 2 others: Today deployment made RTL notifications unvisible - https://phabricator.wikimedia.org/T159999#3086108 (10Catrope) >>! In T159999#3086026, @gerritbot wrote: > Change 341927 had a related patch set uploaded (by Catrope):... [23:46:32] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 13Patch-For-Review, and 2 others: 1.29.0-wmf.15 regression: notification popup misaligned, partially off-screen in RTL - https://phabricator.wikimedia.org/T159999#3086127 (10Catrope) [23:54:21] (03Merged) 10jenkins-bot: Fix RTL popup alignment for OOjs UI 0.19.5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341931 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope) [23:54:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3086186 (10Et... [23:57:22] (03CR) 10jenkins-bot: Fix RTL popup alignment for OOjs UI 0.19.5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341931 (https://phabricator.wikimedia.org/T159999) (owner: 10Catrope)