[00:06:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078245 (10Mattflaschen-WMF) [00:06:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#3078244 (10Mattflaschen-WMF) [00:08:06] mooeypoo, you don't have a data structure for "One filter implies another, so selecting the other would have no effect (e.g. likely damaging is a super set of very likely damaging)." since there are non in core, right? [00:10:12] yeah that's "included" / "subset" [00:10:17] mooeypoo: li.mw-changeslist-line-watched, li.mw-history-line-updated [00:10:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078251 (10Mattflaschen-WMF) [00:25:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - colored bullet points displayed overlapped - https://phabricator.wikimedia.org/T159586#3078266 (10Mooeypoo) a:03Mooeypoo [00:26:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - colored bullet points displayed overlapped - https://phabricator.wikimedia.org/T159586#3072497 (10Mooeypoo) This was caused due to a style in betalabs -- the commit is to try and pr... [00:54:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078311 (10Mattflaschen-WMF) [00:54:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078325 (10Mattflaschen-WMF) [00:54:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078324 (10Mattflaschen-WMF) [00:54:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078311 (10Mattflaschen-WMF) [00:54:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2859076 (10Mattflaschen-WMF) [00:54:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078311 (10Mattflaschen-WMF) [00:54:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2859076 (10Mattflaschen-WMF) [00:57:19] matt_flaschen, I just realized another thing to add to group definition [00:57:33] matt_flaschen, T159186 <-- [00:57:33] T159186: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186 [00:57:36] :\ [00:58:14] matt_flaschen, I just realized I'll need all the text for the "What's This?" for each group. Also, seems to be separate between -title and -content as two messages [00:58:24] matt_flaschen, how much did I just blow up your work? [00:58:52] matt_flaschen, sorry, plus another message -link that's at the end... that one seems to be per-group too [01:02:08] mooeypoo, already on the backend task, and my TODO list. [01:02:11] (Before that) [01:02:24] mooeypoo, one of those little things I haven't quite finished. [01:02:52] * mooeypoo nods [01:03:05] just checking, I was going to implement it in the UI and then realized I needed the messages from the backend [01:03:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078337 (10Mattflaschen-WMF) [01:06:55] mooeypoo, no problem, right now I'm going through and making sure we have tasks for all the extensions that use any of the old hooks. Some will be in the new UI initally, some not. [01:07:05] * mooeypoo nods [01:07:06] sounds good [01:12:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - add tooltips to 'Highlight results' button and to the highlight menu - https://phabricator.wikimedia.org/T159587#3078374 (10Mooeypoo) Added tooltip for the individual highlight menu... [01:12:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - add tooltips to 'Highlight results' button and to the highlight menu - https://phabricator.wikimedia.org/T159587#3078378 (10Mooeypoo) a:03Mooeypoo [01:37:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078416 (10Mattflaschen-WMF) [01:53:49] stephanebisson, mooeypoo, just realized that that Mobile has its own watchlist class (SpecialMobileWatchlist), with a hierarchy (MobileSpecialPage => MobileSpecialPageFeed => SpecialMobileWatchlist) that does not touch ChangesListSpecialPage. [02:40:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-WikimediaEvents: Update filter logging for refactoring - https://phabricator.wikimedia.org/T159786#3078505 (10Mattflaschen-WMF) [02:45:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Wikidata: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3078520 (10Mattflaschen-WMF) [02:45:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3078534 (10Mattflaschen-WMF) [02:45:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078535 (10Mattflaschen-WMF) [02:45:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Wikidata: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3078533 (10Mattflaschen-WMF) [02:46:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Wikidata: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3078520 (10Mattflaschen-WMF) [02:46:32] matt_flaschen: Hmm I've downloaded your patch but something about legacy filters seems to be broken, I'm getting warnings about call_user_func_array() being called on null, because $this->queryCallable is null for 'damaging' [02:47:24] RoanKattouw, hmm, thanks, one sec. [02:48:08] I'm running zend+xdebug so I get giant red boxes obscuring half the page every time someone indexes into an array wrong :D [02:49:26] Given how the legacy hooks work I think it's probably OK to just skip calling $this->queryCallable if it's null [02:49:28] so I'll try that [02:52:55] RoanKattouw, I agree. I would like to warn non-legacy users if they are missing parameters, but currently I don't know if the Filter is part of a hide-based or a STRING_OPTIONS, so I can't. [02:53:11] So I did probably the same as you, just returning if it's null (also, not sure why there was a return for the normal case, removed that) [02:53:19] WTF now I'm getting MWException from line 146 of /vagrant/mediawiki/includes/FormOptions.php: Invalid option newcomer all of a sudden [02:53:29] Not sure where that came from, I logged in, but it does it in incognito too [02:53:31] RoanKattouw, that's not a valid option, it's a valid value. [02:53:35] userExpLevel=newcomer [02:53:38] Yeah [02:53:42] Or userExpLevel=newcomer,learned [02:53:44] etc. [02:53:56] If I give it a full query string it goes away [02:54:05] RoanKattouw, what's your URL? [02:54:22] Bare /wiki/Special:RecentChanges explodes, if I add ?userExpLevel=all it's happy [02:57:34] matt_flaschen: Found it [02:57:43] Yeah, me too , the NONE thing [02:58:05] https://www.irccloud.com/pastebin/y6ojIy6D/ [02:58:32] if $filterGroup->isPerRequestParameter() is true, we need to not go to the else branch, even if the value is NONE [02:58:41] Yeah, fixed. [03:01:04] matt_flaschen: Do you already have local work to have the ORES extension hook into the new hooks? [03:01:21] No, I haven't started that one. [03:07:13] OK, then I'll take a stab at it if you don't mind [03:10:28] No, go head. [03:13:52] Okay, it works again. :) [03:14:18] Changed some other stuff locally, I forgot that Special:RecentChanges doesn't call doMainQuery's parent. [03:14:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add ORES to RCFilters - https://phabricator.wikimedia.org/T158459#3078621 (10Mattflaschen-WMF) a:03Catrope [03:26:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791#3078657 (10Mattflaschen-WMF) [03:27:00] RoanKattouw, if you know anything about T159791 (e.g. whether "reviewed" in hideReviewed are always patrolled, where this option fits, etc.), please comment. [03:27:01] T159791: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791 [03:27:23] We might be able to do it with a subset/superset and "Review status", but not investigated yet. [03:27:33] Hmm, not sure [03:27:44] I think there's some sort of interaction like marking something as reviewed also marks it as patrolled [03:27:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791#3078676 (10Mattflaschen-WMF) Need to investigate how this relates to patrol, and 'Review status'. [03:27:55] Yeah, that's what I'm hoping for, but I didn't actually check that. [03:27:56] But Cenarium would know best, I suppose [03:28:08] I think he said something like that, but it was months ago so I don't remember it that well [03:28:17] It would be pretty confusing to have a 'Review status' that is unrelated to hideReviewed. [03:28:37] Also I think he said it in the context of "we should fix this", so it was either that it's doing that but he wants that behavior to be disableable, or it's not doing it but he wants it to [03:28:48] I think it might have been the former, and I'm pretty sure he filed a phab task about it some time in December [03:30:16] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791#3078681 (10Mattflaschen-WMF) [03:30:31] RoanKattouw, okay, that is specific enough to try to find it. :) [03:31:55] Breaking for dinner. [03:32:06] It is not literally in December, but I'll expand the search when I get back. [03:49:14] I've gotten it to work superficially, breaking to go home and eat dinner [03:49:46] I need to add subsets and stuff, and also migrate the legacy filters so they work again [03:50:08] (i.e. so that ORES works without rcfilters) [04:25:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: The filter panel for Recent changes does not adapt well to narrow windows - https://phabricator.wikimedia.org/T158956#3078784 (10Jdforrester-WMF) [05:15:10] RoanKattouw, yeah, I'm trying to think of the right way to do that. The other show/hide links just move into the new UI (somewhere, but the same filter). This is tricky, because it's not the same. [05:15:32] I was thinking I'd define another group+filter that's old-UI-only [05:15:46] But implement it using the new hook, not the old one' [05:15:56] I was thinking isAllowed, but if you fully port it then use isAllowed, old URLs won't work with the new system (since isAllowed also controls whether the query runs) [05:16:01] which requires a bit of cleanup because with the old hooks everything's scattered across 3 or 4 functions [05:16:27] True; but I think that's unavoidable [05:16:50] The old URLs look like &hidenondamaging=1, the new ones have to be something like &damaging=good,maybebad [05:17:50] RoanKattouw, if you're okay with the old URLs breaking, you can just use isAllowed, but if you want them to keep working, you can define it as only showing in the old system. [05:18:09] Oh, I see what you mean [05:18:15] showHide but no label/description. [05:18:28] Even if a filter does not show, are its params still respected? [05:18:51] RoanKattouw, but then the problem you'll run into is it will show at the bottom of the new UI (since it doesn't know that it's been migrated). [05:19:21] RoanKattouw, whether the params are respeted is controlled by isAllowed. [05:20:18] Hmm OK [05:20:18] RoanKattouw, also, the old filters should probably keep working for no-JS users (especially when it's out of beta). [05:20:31] Yes [05:20:52] Hmm so you're saying the code that removes show/hide link for filters that are defined for both the old and new UI won't know what's going on? [05:21:01] That seems plausible as I'll have to define them separately [05:21:13] (The old UI presumably does not know how to render STRING_OPTIONS groups) [05:21:16] RoanKattouw, yes, because they're separate in this case, unlike e.g hidebots which is the same just in two places. [05:22:11] RoanKattouw, I think what we need is something like $filter->markReplaced() to signify this. [05:22:22] Yeah that sounds good [05:22:43] So you can just define it normally in the old system, but then I will put the same class I put for ones that go in both, and it will just get removed. [05:22:54] There might be something simpler, but I can't think of it. [05:23:25] Class being a CSS class mooeypoo requested to help remove the old show/hide links (originally ones like hidebots that are in both, but I can reuse it here) [05:25:37] Will add that [05:28:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078859 (10Mattflaschen-WMF) [05:31:35] Or I guess it can just be isReplacedInStructuredUi => true in constructor [05:32:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3078860 (10Mattflaschen-WMF) [05:36:09] RoanKattouw, I guess you're referring to T150086 . Anyway, that is sufficient to break reviewed -> patrolled. [05:36:10] T150086: Don't autopatrol autoreviewed users in protection-based configs - https://phabricator.wikimedia.org/T150086 [05:36:19] Yes that's the one [05:36:22] OK I was wrong then [05:38:28] RoanKattouw, it actually depends on the config, but we'll have to see how we want to handle that. [05:38:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791#3078862 (10Mattflaschen-WMF) [05:39:44] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078866 (10Mattflaschen-WMF) [05:39:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters - https://phabricator.wikimedia.org/T159791#3078657 (10Mattflaschen-WMF) [05:41:31] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078311 (10Mattflaschen-WMF) [05:42:54] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078869 (10Mattflaschen-WMF) [06:00:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MobileFrontend: Handle MobileWatchlist in regards to Edit Review Improvements - https://phabricator.wikimedia.org/T159793#3078877 (10Mattflaschen-WMF) [06:08:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3078912 (10Mattflaschen-WMF) [06:12:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3078939 (10Mattflaschen-WMF) [06:15:44] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3078940 (10Mattflaschen-WMF) [06:21:36] RoanKattouw, accounted for all the Gerrit-hosted extensions either firing or listening to any of the relevant hooks. [06:22:09] In addition to the ones in the initial Beta Feature (Wikidata, ORES), there are also a couple other actionable ones, sub-tasks of https://phabricator.wikimedia.org/T159778 . [06:22:17] FlaggedRevs and Translate. [06:22:24] Ah yes [06:22:27] We don't have to take action on them, though. It should just keep working. [06:22:40] So when you say accounted for, you mean filed tasks for, not written code for? [06:22:56] Yeah [06:36:17] Next I'll implement the subset/includes/no-effect tracking, then T152797 [06:36:18] T152797: Attribute RC lines to their sources - https://phabricator.wikimedia.org/T152797 [06:36:51] (Implmenting it into the new system) [06:41:27] RoanKattouw, new WIP up: https://gerrit.wikimedia.org/r/337546 . [06:58:18] Have a good night, everyone. [08:04:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3079128 (10Pginer-WMF) >>! In... [09:02:27] (03CR) 10Hashar: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340123 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:08:35] (03CR) 10Hashar: [C: 032] Update tests to Selenium 3 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340122 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:09:49] (03CR) 10Hashar: [C: 032] Update tests to Selenium 3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340123 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:14:30] (03CR) 10Hashar: "check experimental" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/340126 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:14:33] (03CR) 10Hashar: "check experimental" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/340133 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:23:10] (03Merged) 10jenkins-bot: Update tests to Selenium 3 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340122 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:23:49] (03Merged) 10jenkins-bot: Update tests to Selenium 3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340123 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:24:06] (03CR) 10jenkins-bot: Update tests to Selenium 3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340123 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:24:42] (03CR) 10jenkins-bot: Update tests to Selenium 3 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340122 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:34:24] (03CR) 10Hashar: [C: 032] Update tests to Selenium 3 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/340133 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:34:27] (03CR) 10Hashar: [C: 032] Update tests to Selenium 3 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/340126 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:35:49] (03Merged) 10jenkins-bot: Update tests to Selenium 3 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/340133 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [09:38:26] (03Merged) 10jenkins-bot: Update tests to Selenium 3 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/340126 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [13:57:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#3080091 (10Pg... [16:11:19] (03PS1) 10Reedy: Convert PageTriage to extension registration (again) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/341561 (https://phabricator.wikimedia.org/T87954) [16:13:25] (03CR) 10jerkins-bot: [V: 04-1] Convert PageTriage to extension registration (again) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/341561 (https://phabricator.wikimedia.org/T87954) (owner: 10Reedy) [16:14:03] (03PS2) 10Reedy: Convert PageTriage to extension registration (again) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/341561 (https://phabricator.wikimedia.org/T87954) [16:51:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Restore default filters' should cancel previous selections of filters' highlighting - https://phabricator.wikimedia.org/T159848#3080659 (10Etonkovidova) [17:44:30] stephanebisson: I need wiki with not-enabled ores, and it seems that dewikinews and dewikivoyage do not have 'ores-enabled' fin user_properties. But [17:45:07] stephanebisson: I am getting 'no wiki found' for https://de.wikinews.beta.wmflabs.org/wiki/Hauptseite [17:45:20] stephanebisson: what I am missing? [17:45:28] etonkovidova, if it's any help, we don't have ORES enabled for dewiki either. [17:49:28] halfak: hmm... not in wmflabs dewiki :( [17:49:47] Oh! gotcha. [17:50:27] Wait. Yes it is! https://de.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Hauptseite [17:51:15] halfak: I see ORES as beta feature is present there [17:51:24] etonkovidova, oh i see. That seems wrong. [17:51:45] halfak: :)) [17:51:56] It's not available on de.wikipedia.org. [17:52:01] Shouldn't the configs be the same? [17:56:31] halfak: betalabs has master and I often do many things that I would not do in production... [17:57:23] gotcha. Sorry I couldn't help more. Do feel free to ping me any time. :) [17:57:33] Which saying "ores" usually does. :D [17:58:38] halfak: hehe - thx! [18:18:57] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (and "Global rename script"?)? - https://phabricator.wikimedia.org/T126229#3081073 (10MarcoAurelio) @Mattflaschen-WMF: New issue with this [[ https://zh.wikipedia.org/w/index.php?title=Special%3A%E6%97%A5%E5%BF%9... [18:20:22] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3081091 (10MarcoAurelio) (cross-posting... [18:43:28] 06Collaboration-Team-Triage, 10Notifications, 07Regression, 06Stewards-and-global-tools (Temporary-UserRights): User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3081240 (10Catrope) @TTO Do you plan on updating the user righ... [18:43:42] 06Collaboration-Team-Triage, 10Flow, 07Easy: [.wmf14] Adding tables to Board description breaks the footer - https://phabricator.wikimedia.org/T159282#3081242 (10Catrope) Probably just needs a `
` before the footer. [18:43:58] 06Collaboration-Team-Triage, 10Thanks, 07User-notice-collaboration: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3081246 (10Trizek-WMF) Have something less confusing than two blue bold links in the middle of a pack of bolded blue links would help too. :) [18:46:01] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (and "Global rename script"?)? - https://phabricator.wikimedia.org/T126229#3081265 (10Mattflaschen-WMF) >>! In T126229#3081073, @MarcoAurelio wrote: > @Mattflaschen-WMF: New issue with this [[ https://zh.wikipedi... [18:48:14] RoanKattouw: I think I know what the problem is with my ores patch. I'll test and fix as soon as my mw-vagrant is back up. [18:48:32] Some wikis (including testwiki) don't have the goodfaith model apparently [18:48:40] right [18:48:40] right [18:52:28] And when you try to request data for it, you get a 400(?!) [19:05:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3081363 (10Mooeypoo) If you add a definition of the steps ("windows" / where they point to on the screen) and the... [19:12:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Restore default filters' should cancel previous selections of filters' highlighting - https://phabricator.wikimedia.org/T159848#3080659 (10Mooeypoo) I think this invalidates the ticket {T159503} ? [19:14:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Implement arrow keys in the Dropdown Filter Panel for results found by filter search - https://phabricator.wikimedia.org/T159768#3081384 (10jmatazzoni) [19:17:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3081396 (10jmatazzoni) 05Open>03Invalid [19:17:23] stephanebisson, your fix still has the same bug with the back button -- if I start on a completely new window (incognito, even) in http://dev.wiki.local.wmftest.net:8080/wiki/Special:RecentChanges and then I have my defaults, so I unset a default, then highlight another filter -- if I click "back" once, I ndo the highlight (good) then back again, I undo the removal of the filter (good) but then I can just click back again and again [19:17:23] and it keeps requesting the ajax repeatedly [19:18:39] stephanebisson, but there are no duplicate entries in the history [19:18:42] it seems like a browser behavior [19:18:47] mooeypoo: I didn't see that, letme try again [19:18:52] the browser just re-requests the same url [19:18:57] or something like that [19:19:03] has a popstate without really popping state [19:19:17] something like that, surely. when I long-press the back button at that point, I only have 1 entry. [19:19:28] so *inserting* into history only once seems to be working [19:19:36] it should go back to an empty browser window [19:19:40] It doesn't [19:20:03] I hit back repeatedly, it just shows the pending state on the fieldset and results list [19:20:16] Testing in Firefox now [19:20:22] (this is in Chrome) [19:20:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3081404 (10Catrope) @SBisson Pointed out that GuidedTour is an extension, and our code is in core. So maybe we pu... [19:20:37] did it update the url with a bunch of param on load? [19:20:43] yes [19:21:01] and this happens the same way in firefox to [19:21:03] too [19:21:09] Initial load results in URL beingupdated correctly [19:21:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: The filter panel for Recent changes does not adapt well to narrow windows - https://phabricator.wikimedia.org/T158956#3081411 (10Catrope) @Mooeypoo We might be able to address this quickly with something like `max-wi... [19:21:39] I remove a filter from the capsule, then click "back", it undos the removal, but then another "back" just stays in that page but requests the list again and again [19:24:02] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: The filter panel for Recent changes does not adapt well to narrow windows - https://phabricator.wikimedia.org/T158956#3081428 (10jmatazzoni) [19:24:30] I see it :( Let me shuffle the bytes some more [19:31:10] * mooeypoo nods [19:37:52] stephanebisson, also added 2 minor comments [19:38:15] mooeypoo: thanks, I'll fix those [19:56:03] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3081629 (10Jdforrester-WMF) 05Open>03Reso... [20:15:35] 06Collaboration-Team-Triage, 10Notifications, 07Regression, 06Stewards-and-global-tools (Temporary-UserRights): User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3081705 (10TTO) My busy-ness level has jumped, so I don't anti... [20:17:09] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (and "Global rename script"?)? - https://phabricator.wikimedia.org/T126229#3081724 (10MarcoAurelio) >>! In T126229#3081265, @Mattflaschen-WMF wrote: > > Did you start with the global rename, or start with the a... [20:34:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Restore default filters' should cancel previous selections of filters' highlighting - https://phabricator.wikimedia.org/T159848#3081784 (10SBisson) a:03SBisson [20:39:59] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3081800 (10Etonkovidova) This issue has been fixed - the edits to preformatted text that are done via VE can be saved. {T159231} is still valid since it is addressi... [20:40:16] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3081801 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Normal [20:41:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3081816 (10SBisson) a:03SBisson [21:07:18] stephanebisson: Does https://gerrit.wikimedia.org/r/#/c/341596/ fix the beta labs error thing? [21:09:42] RoanKattouw: I think it will [21:09:53] I feel like it probably will too [21:10:21] There's an easy way to find out... [21:11:05] I just +2ed it if that's what you mean ;) [21:42:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341660 (owner: 10L10n-bot) [21:48:34] RoanKattouw, problem with Echo in latest train deploy. Try your notification popup. [21:48:52] at mw.o [21:50:39] also ping mooeypoo, ^, as I don't know Roan's current schedule. Screenshot: http://imagizer.imageshack.com/img922/7812/17tQcK.png [21:50:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341654 (owner: 10L10n-bot) [21:50:57] O.O [21:51:15] * mooeypoo looks for RoanKattouw -- could the popup work affected this?? [21:52:22] quiddity, if yuou close it and reopen does it sort itself out? [21:53:10] close the tab and reopen, no. I can't close firefox completely, too many tabs!!! [21:53:24] no no no [21:53:30] I meant click somewhere else in the window [21:53:42] and reclick the notification popup [21:53:44] oh, yes [21:53:59] So it seems to only happen the first load [21:54:00] ? [21:54:09] That's what I see now in mw.org, trying to confirm [21:54:38] yup. for every first load though. (If i close the tab completely, and then re-open, the first load shows the error again) [21:54:44] I think I know what's happening but no idea why it happens now... RoanKattouw looks like we might be calling clippable too soon? [21:54:50] * mooeypoo nods [21:58:59] quiddity, another test if you don't mind -- when it opens like this, if you resize the window, does it grow back? [21:59:29] yup! (and happy to help :) [21:59:33] Yup. Clippable. Meh. I'm on it. [21:59:37] thanks! [21:59:40] <3 [22:00:24] Didn't happen in Beta Cluster for some reason. [22:00:34] It happens for me in master [22:00:40] I am just wondering why *now* [22:00:52] something changed in popups, probably affected this, but this seems to be clippable-related [22:01:13] And we *are* calling .clip() after it's populated [22:01:51] wow, clip() MAKES it shirnk [22:01:54] uh oh [22:02:04] * mooeypoo suspects something changed in the way a popup calculates its dimensions [22:34:45] I noticed it locally while I had a bunch of weird code running, so it worried me, but it could have been the weird code, so I forgot about it [22:35:05] From talking to Moriel at her desk just now it seems like she's got a solution that she's working on [22:38:25] quiddity, is there a task? [22:38:45] (03PS1) 10Mooeypoo: Add and listen to 'modified' event for popup clip() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341702 [22:38:46] ^^ [22:39:02] mooeypoo, no, it was reported to me in gchat, and i passed along here. I can create a brief placeholder, if desired. [22:39:04] That should fix it, but this is hard to test [22:39:22] I'm just concerned it should go through deployment + testing [22:39:36] nod, I'll whip something together quick [22:39:42] mooeypoo: quiddity -- the issue was present in .wmf14 [22:41:04] does not have reliable steps to reproduce - and it happens in betalabs too. I am suspecting that it happens only when there are lots of unseen notifications [22:41:11] and I am checking it now [22:42:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082271 (10Quiddity) [22:42:16] ^ or https://phabricator.wikimedia.org/T159888 [22:42:46] * quiddity grabs lunch before next meeting. [22:43:39] mooeypoo: the issue does not happen to all users [22:49:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082271 (10Etonkovidova) Noticed in .wmf14 (and still exists in .wmf15). Betlabs has it too: {F6305708} {F6305723} [22:53:35] etonkovidova, i have 0 unseen notifications, but hundreds of seen notifications. In case that helps. [22:53:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3082301 (10Mattflaschen-WMF) >>! In T159010#3081404, @Catrope wrote: > @SBisson Pointed out that GuidedTour is an... [22:54:14] quiddity: sigh - yeah, I cannot see the pattern ... :( [22:55:28] quiddity: I was secretly waiting for you to file such a bug, it will be of the highest priority :)) Btw, you do not see 'Failed to fetch notifications' on the first load? [22:56:15] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3082307 (10Mattflaschen-WMF) >>! In T15... [22:56:44] I can't see anything in the window, just per my screenshot. -Nothing in webconsole [22:59:19] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (and "Global rename script"?)? - https://phabricator.wikimedia.org/T126229#3082311 (10Mattflaschen-WMF) >>! In T126229#3081724, @MarcoAurelio wrote: >>>! In T126229#3081265, @Mattflaschen-WMF wrote: >> >> Did yo... [22:59:30] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards - https://phabricator.wikimedia.org/T126229#3082312 (10Mattflaschen-WMF) 05Open>03Resolved a:05Mattflaschen-WMF>03None [23:01:39] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3082326 (10Mattflaschen-WMF) [23:07:36] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3082351 (10Mattflaschen-WMF) >>! In T15... [23:08:29] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3082354 (10Mattflaschen-WMF) [23:09:45] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#3082355 (10Mattflaschen-WMF) 05Resolved>03Open [23:14:15] (03CR) 10Catrope: [C: 032] Add and listen to 'modified' event for popup clip() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341702 (owner: 10Mooeypoo) [23:24:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3082362 (10Etonkovidova) It seems that the users with the number of notifications with notification_read_timestamp NULL >25 w... [23:25:49] (03Merged) 10jenkins-bot: Add and listen to 'modified' event for popup clip() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341702 (owner: 10Mooeypoo) [23:27:25] (03CR) 10jenkins-bot: Add and listen to 'modified' event for popup clip() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341702 (owner: 10Mooeypoo) [23:37:10] RoanKattouw, we also need to deploy this [23:37:20] Crap yeah I forgot [23:37:27] I'll list it for SWAT in 20 mins [23:37:54] ARGH [23:37:57] And Gerrit just went down [23:38:34] RoanKattouw, I have a temporary but strong aversion to "Down" right now -- James_F showed me the "Top to bottom" demo [23:38:35] wtf [23:38:43] haha yeah [23:38:47] Timo showed me that last week [23:39:09] (03PS1) 10Catrope: Add and listen to 'modified' event for popup clip() [extensions/Echo] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/341709 [23:40:46] it makes no sense [23:40:50] none at all [23:59:44] (03PS1) 10Bartosz Dziewoński: Add namespace translations for Western Punjabi (pnb) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/341714 (https://phabricator.wikimedia.org/T157871)