[00:10:31] etonkovidova, I'm running out of things to fix [00:10:44] etonkovidova, I refuse to believe that all's good. SOMETHING MUST BE BROKEN SOMEWHERE [00:24:38] haha [00:26:32] mooeypoo: ha! How about that detached highlighting colors box which is part of https://phabricator.wikimedia.org/T158118 ? [00:27:58] RoanKattouw, less is driving me mad [00:28:03] I shall cry for help in a few minutes [00:28:43] etonkovidova, that's a (annoying) ooui bug [00:28:51] an* [00:29:04] mooeypoo: What's up? [00:29:18] Not Less. [00:29:25] My less is down. [00:29:32] meh. [00:31:01] mooeypoo: ok, then can you check why the trash bin icon RC page in betalabs needs "double" click? - maybe it's just my mac ...hmm [00:31:17] ... [00:31:21] what [00:31:57] mooeypoo: sorry - never mind argh... [00:32:30] RoanKattouw, all my backgrounds for the capsule widget are being eaten away by an ooui rule [00:33:03] .oo-ui-capsuleItemWidget.oo-ui-widget-enabled { ... } [00:33:12] and when I try to add that to mine, less ignores me [00:33:27] Do you remember the trick for checking LESS's output? [00:34:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 06Revision-Scoring-As-A-Service, and 2 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3069686... [00:35:04] Yes [00:36:25] I usually start debugging by doing that and throwing the generated selector into $( 'selector here' ) to see what it matches [00:44:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters -should 'Restore default filters' return 'Highlight results' button to inactive state? - https://phabricator.wikimedia.org/T159503#3069709 (10Etonkovidova) [00:45:11] .oo-ui-capsuleItemWidget.oo-ui-widget-enabled.mw-rcfilters-ui-capsuleItemWidget { [00:45:11] &-muted { [00:45:14] ^ RoanKattouw [00:45:17] should work [00:45:19] and yet it doesn't [00:45:22] oh [00:45:23] wait [00:45:26] goddamnit [00:45:32] quac [00:45:33] k [00:45:50] :D [00:46:56] >.< [00:48:09] RoanKattouw, how is this: [00:48:15] .mw-rcfilters-ui-capsuleItemWidget { [00:48:16] &.oo-ui-capsuleItemWidget.oo-ui-widget-enabled { [00:48:16] &-muted { [00:48:17] ... [00:48:23] Turning to this: [00:48:29] .mw-rcfilters-ui-capsuleItemWidget.oo-ui-capsuleItemWidget.oo-ui-widget-enabled-conflicted { ... } [00:48:34] oh [00:48:39] GODDAMNIT [00:49:01] I CAN'T DO .oo-ui-capsuleItemWidget.oo-ui-widget-enabled.& {..} because Less craps out [00:49:06] .me growls [00:49:36] And I can't do just straight up .oo-ui-capsuleItemWidget.oo-ui-widget-enabled..mw-rcfilters-ui-capsuleItemWidget { ..} because it's already under .mw-rcfilters-ui-capsuleItemWidget [00:50:32] and this doesn't work either: [00:50:32] &-muted.oo-ui-capsuleItemWidget.oo-ui-widget-enabled { [00:51:58] ok it works now [00:52:03] * mooeypoo growls at less [00:55:23] RoanKattouw, https://gerrit.wikimedia.org/r/340909 etonkovidova I am not sure I implemented the completely correct tones, but I went with the palette [00:55:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add ORES to RCFilters - https://phabricator.wikimedia.org/T158459#3069751 (10Mattflaschen-WMF) [01:34:05] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for core HTML email - https://phabricator.wikimedia.org/T156231#3069789 (10srishakatux) It now looks like a decent Outreachy project IMO, involving a bit of design/ documentation. In the pas... [01:37:11] ... James_F RoanKattouw **why** did you add a 2px whitespace when we're complaining about how all icons have whitespaces? :\ [01:37:28] Because either all icons must have whitespace, or none [01:37:38] Let's start with not, incrementally! [01:37:50] You can't write CSS rules for padding etc in a world where some do and some don't [01:38:03] This one has its own css rule anyways [01:38:10] And you can create a rule that starts it [01:38:14] Sure, but we want to upstream it into OOUI don't we? [01:38:29] why not... write another class that fixes its dimensions [01:38:41] ok how about this -- [01:38:50] you put this icon as it should be, without whitespace. [01:39:07] You set it up with width/height a little smaller + margin to compensate [01:39:12] you can make the corrections a mixin [01:39:18] then you can slowly fix THE OTHER ICONS [01:39:20] \o/ [01:39:45] Sounds good to me but talk to James_F / MatmaRex / Volker [01:39:54] They're the Masters of OOUI [01:40:01] James_F, MatmaRex ^^^ [01:40:14] should I copy/paste it for Volker in -editing ? [01:41:02] Yeah or move the discusion there [01:41:04] for CSS, it's mostly Volker [01:41:08] More appropriate channel anyways [01:41:12] althought for icons CSS, it's mostly Ed [01:41:14] * mooeypoo moves it there [01:41:23] * MatmaRex reading scrollback [01:41:54] oh no, icon whitespace [01:42:00] it's hopeless. [01:42:54] we used to have whitespace in the SVG for all icons. then, we imported all of the "MediaWiki UI" icons, which had none or little. and since then, all new additions have been a mess [02:01:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Highlight Tools and implement highlighting in... - https://phabricator.wikimedia.org/T149467#3069816 [02:05:48] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069819 (10Mattflaschen-WMF) It looks from https://ca.wikipedia.org/w/index.php?title=Usuari_Discussi%C3%B3:Kano_Kano&diff=18196140&oldid=18196131... [02:16:37] mooeypoo: I think it'd be a mistake to mix the whitespace one at a time. [02:17:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Highlight Tools and implement highlighting in... - https://phabricator.wikimedia.org/T149467#3069841 [02:19:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [regression betalabs] The colored circles for highlighting become stretched vertically when selected - https://phabricator.wikimedia.org/T159391#3069842 (10Etonkovidova) Checked - it's fixed. [02:20:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [regression betalabs] The colored circles for highlighting become stretched vertically when selected - https://phabricator.wikimedia.org/T159391#3069843 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Normal [02:50:13] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Improve Special:RecentChangesLinked to filter categories and sub-categories - https://phabricator.wikimedia.org/T158572#3069880 (10Mattflaschen-WMF) [03:12:02] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3069902 (10Mattflaschen-WMF) Unfortunately, we were not able to complete this today. There was a regression from 9d087... [03:12:45] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3069904 (10Mattflaschen-WMF) [06:51:36] https://gerrit.wikimedia.org/r/#/c/337546/ [08:33:58] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3070127 (10Vriullop) > @Vriullop Is it okay to make all non-existent pages in the namespace Flow? > It is okey. Initial motivation was to enable... [08:49:36] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3070151 (10Vriullop) >>! In T159482#3069819, @Mattflaschen-WMF wrote: > you may need to change the template not to mention the name due to some is... [08:56:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - Selecting 'full coverage' and 'conflict' filters makes any additionally selected filter(s) be displayed as active without affecting the result set - https://phabricator.wikimedia.org/T159199#3070155 (10... [10:11:45] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3070268 (10Trizek-WMF) The community is now aware of that schecule change. [10:42:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Dots in the Highlight menu are oval - https://phabricator.wikimedia.org/T159341#3070294 (10Trizek-WMF) >>! In T159341#3065435, @Aklapper wrote: > (if I wanted to reproduce, where could I try? I failed to find a link to some test instance looking... [11:11:36] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, and 2 others: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3070330 (10Trizek-WMF) [12:35:27] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#2980123 (10IKhitron) Hi everyone. Saw this in the Tech news draft. Now I see why I have a p... [13:02:48] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#2980123 (10bmansurov) @IKhitron thanks for the comment. I've created a task (T159526) to ca... [13:04:15] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3070501 (10IKhitron) Thank you and no problem. [13:34:55] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 5 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3070593 (10Liuxinyu970226) [14:30:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 06Revision-Scoring-As-A-Service, and 2 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3070690... [16:06:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 06Revision-Scoring-As-A-Service, and 2 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3070942... [17:09:36] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3071112 (10ABorbaWMF) We have tried both logged in and logged out and with beta features en... [17:12:16] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3071127 (10IKhitron) One of ten seems to me even worth - it's not deterministic. Maybe some... [17:32:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - Selecting 'full coverage' and 'conflict' filters makes any additionally selected filter(s) be displayed as active without affecting the result set - https://phabricator.wikimedia.org/T159199#3071255 (10... [17:34:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10Etonkovidova) @Cat... [17:44:56] (03CR) 10Jforrester: [C: 032] "Prod this now that composer issues are fixed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [17:46:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10SBisson) >>! In T1... [18:02:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3071473 (10Pginer-WMF) >>! In... [18:06:26] (03Merged) 10jenkins-bot: Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [18:06:44] (03CR) 10jenkins-bot: Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [18:15:23] (03PS3) 10Jforrester: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [18:22:00] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/340365/2 LGTM too if you're in a merge spree. :-) and https://gerrit.wikimedia.org/r/#/c/340522/ once I've crush the SVGs. [18:27:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10Nemo_bis) For maxi... [18:32:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10Jdforrester-WMF) >... [18:48:24] (03CR) 10jerkins-bot: [V: 04-1] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [18:50:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3071571 (10Etonkovidova) Than... [18:55:23] RoanKattouw: we can enable the beta feature on betalabs now that the patches are merged, any reasons we shouldn't? [18:55:33] Yup, let's [18:56:54] stephanebisson: Are you writing / going to write a wmf-config patch for that or shall I? [18:57:03] be my guest [18:57:21] $wgEnableRcFiltersBetaFeature [18:58:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist: [regression betalabs] When adding/removing a page from watchlist the popup displays some code - https://phabricator.wikimedia.org/T158273#3071608 (10Umherirrender) >>! In T158273#3065557, @Etonkovidova wrote: > Checked (just in... [18:59:57] https://gerrit.wikimedia.org/r/341024 [19:05:36] sorry, I don't have +2 [19:05:55] haven't unlocked that achievement yet [19:11:08] It's the same as deployer access. [19:12:41] I'll +2 after lunch since I have to deploy it to prod (even though it's Beta, otherwise it triggers warnings) [19:15:49] Thanks [19:28:39] phlogiston will go bananas today [19:29:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - reloading RC page shows the old layout - https://phabricator.wikimedia.org/T159265#3071704 (10Etonkovidova) Yes, it's gone - thx! [19:29:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - reloading RC page shows the old layout - https://phabricator.wikimedia.org/T159265#3071705 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Normal [19:32:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): RCFilters UI: Split ResourceLoader modules - https://phabricator.wikimedia.org/T156532#3071715 (10Etonkovidova) 05Open>03... [19:32:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 07Tracking: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3071716 (10Etonkovidova) [19:32:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters UI ViewModel: Create group models in the ViewModel and attach to FilterGroupWidgets - https://phabricator.wikimedia.org/T156533#3071721 (10Etonkovidova) 05Open>03Resolved [19:34:16] haha [19:34:33] * RoanKattouw goes and generates the Deployment planning page a few days early [19:34:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3071728 (10jmatazzoni) >>! In... [19:35:03] RoanKattouw, can I abandon this? It seems the consensus is not changing it: https://gerrit.wikimedia.org/r/#/c/317860/ [19:35:37] RoanKattouw, also, I fixed https://gerrit.wikimedia.org/r/#/c/340543/ [19:36:01] Yes [19:36:30] (03Abandoned) 10Mooeypoo: Correctly write the mention tooltip message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/317860 (https://phabricator.wikimedia.org/T149061) (owner: 10Mooeypoo) [19:42:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#3071773 (10Catrope) >>! In T149435#3069280, @Mooeypoo wrote: >> When search... [19:44:19] mooeypoo: So you commented on https://gerrit.wikimedia.org/r/#/c/340494/ , but was that meant as a -1 comment, or are you going to merge it, or are you still looking at i? [19:47:49] RoanKattouw, sorry, stephanebisson and I were discussing it in hangouts [19:47:55] there's a small bug stephanebisson's fixing [19:48:06] OK cool [19:48:07] I'll -1 to make sure no one continues [19:48:54] RoanKattouw, also, I'm about to submit a patch for the AJAXifying thing [19:49:01] basically rewriting it (not that bad) to replace the entire thing [19:49:05] because it doesn't work with stephane's patch [19:49:09] (03PS4) 10Jforrester: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:49:17] OK [19:49:27] I was trying to avoid it, but it beat me [19:49:32] * mooeypoo sighs [19:49:40] On a good note, the HACK is moving out of init [19:49:46] (03CR) 10Jforrester: "PS4: Switched from .super to .parent; jsduck fix eludes me, however." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:49:46] ... and into FormWrapperWidget [19:50:48] * James_F grins. [19:51:32] I'll hopefully be on my bike by then so ask Stephane to review it [19:51:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3071824 (10jmatazzoni) @Trize... [19:52:03] (03CR) 10Catrope: "Re jsduck: you can't refer to classes from another repo unless you declare them in the jsduck config file." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:52:19] RoanKattouw, stephanebisson: Remember that the new Beta Feature will appear in Beta Cluster without anything more than the feature flag, but when it comes time for production you'll need to add it to the manual whitelist. [19:52:41] RoanKattouw: I know. What I can't work out is why five different ways of changing jsduck's config all got ignored, so I gave up after 10 minutes. [19:52:48] Yes, thanks for the reminder [19:56:58] (03CR) 10jerkins-bot: [V: 04-1] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [19:58:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3065802 (10Jdforrester-WMF) Did https://gerrit.wikimedia.org/r/#/c/340493/ fix this? [19:58:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10VisualEditor: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3071832 (10Jdforrester-WMF) [20:00:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 06Community-Liaisons: Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#3071836 (10Quiddity) [20:01:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 06Community-Liaisons: Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2546213 (10Quiddity) 05Open>03Resolved I've done all the reading I can, and... [20:06:15] RoanKattouw, did you leave already? [20:06:21] Not yet [20:06:22] But soon [20:16:39] RoanKattouw, I have an issue, do you have a second for hangout? [20:18:27] Sure but give me a minute [20:18:32] * mooeypoo nods [20:32:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3071911 (10jmatazzoni) [20:34:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3071918 (10jmatazzoni) [20:37:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3071923 (10jmatazzoni) I moved all the Conflict Display S... [20:38:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3071925 (10jmatazzoni) I moved all the Conflict Display State functionality and messaging to this t... [20:38:40] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3071928 (10Mattflaschen-WMF) >>! In T159482#3070127, @Vriullop wrote: > It is expected that beta feature "Flow on user talk" will continue availab... [20:38:46] 06Collaboration-Team-Triage, 10Flow: Decide on any changes to how preferences should work for Flow user talk - https://phabricator.wikimedia.org/T149897#2768162 (10Mattflaschen-WMF) [20:38:48] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3071941 (10Mattflaschen-WMF) [20:39:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3071945 (10jmatazzoni) [20:44:12] I find it hilarious that jslint's way of complaining about me leaving in a "debugger;" statement is to point out [20:44:15] "173:1 error Expected indentation of 5 tabs but found 0 indent" [20:44:38] (no-debugger was right after, but still, interesting priorities there, jslint) [20:47:29] stephanebisson, RoanKattouw (PS1) Mooeypoo: RCFilters UI, Followup I97a45208: Replace the entire fieldset [core] - https://gerrit.wikimedia.org/r/341040 [20:47:43] * RoanKattouw passes the buck to stephanebisson [20:47:47] I'm about to head to James_F's [20:50:11] James_F, since you own Beta Features, you might also want to take a look at T149897 . Now relevant since cawiki has specifically requested this (Beta Feature still works, all new user talk is Flow): T159482 [20:50:12] T149897: Decide on any changes to how preferences should work for Flow user talk - https://phabricator.wikimedia.org/T149897 [20:50:12] T159482: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482 [20:50:46] matt_flaschen: Looking. [20:50:48] RoanKattouw, I still can't believe that if you go this.$element.replaceWith( $foo ); then this.$element is now DETACHED and is not now $foo [20:50:55] that makes no sense, does it!? [20:51:15] No it makes perfect sense [20:51:19] $x.replaceWith( $y ); [20:51:22] this.$element.replaceWith( $foo ); this.$element.find( '...' ) <--I should expect that we look inside this.$element, which is really $foo [20:51:25] detaches $x and attaches $y in the place where it was [20:51:36] ... eh, I guess so [20:51:38] No, this.$element still exists, it has just been replaced [20:52:00] so if I wanted to go that route, I should've done this.$element.replaceWith( $fieldset); this.$element = $fieldset; (and then add all the classes) [20:52:08] Technically it could work, but then it would be super-confusing if you wanted to insert this.$element somewhere else afterwards. [20:52:09] It would've been terrible, but just checking my logic here [20:52:20] matt_flaschen, yeah, good point [20:52:21] Could if they did the library differently. [20:52:28] I guess I just found it confusing [20:53:43] 06Collaboration-Team-Triage, 10Flow: Decide on any changes to how preferences should work for Flow user talk - https://phabricator.wikimedia.org/T149897#3071978 (10Jdforrester-WMF) In general, if a feature is going to be on-by-default for any class of user then Beta Features isn't quite right (for that wiki).... [20:58:11] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3071994 (10Mattflaschen-WMF) [20:58:17] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069005 (10Mattflaschen-WMF) [21:30:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/341066 (owner: 10L10n-bot) [22:29:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - Clicking on "Show new changes starting from..." does not display resulting message "Below are the changes since... " - https://phabricator.wikimedia.org/T159582#3072231 (10Etonkovidova) [22:33:55] So, is T158118 meant to be in QA review? [22:33:56] T158118: Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118 [22:34:08] Maybe I don't understand it enough [22:35:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Highlight Tools and implement highlighting in... - https://phabricator.wikimedia.org/T149467#3072255 [22:38:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Highlight Tools and implement highlighting in... - https://phabricator.wikimedia.org/T149467#3072258 [22:39:40] James_F, no, but there was a related fix so I think it got there to check that ? [22:40:13] James_F, the "make the popup smaller height" will make it SLIGHTLY less jarring so it was attached to it -- and then it probably went through the process when it was in review / done review /etc [22:40:20] it'll have to go back [22:42:09] It's not in QA at all, but there's a merged patchset on it, hence my query. [22:51:17] oh no yeah we didn't fix it yet [22:51:26] We corrected something that will *help* this [22:51:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: "Days" and "limit" links on RC page need AJAX - https://phabricator.wikimedia.org/T156697#3072294 (10Etonkovidova) Checked for the specific links "days" and "limits" (as per the title) - works as expected: users sele... [22:51:45] James_F, this is mostly ooui change; the popup disappears abruptly when the input is out of the viewport [22:51:59] 06Collaboration-Team-Triage, 10Flow: Flow should either notify me or give live-updates, about new posts made in the topic I'm currently typing a reply in - https://phabricator.wikimedia.org/T94918#3072295 (10Framawiki) [[ https://fr.wikipedia.org/w/index.php?title=Sujet:Tm3ie2azeg7jwzi5&action=history&topic_po... [22:52:17] James_F, and when you scroll the popup when it's already towards the end, that might happen unexpectedly, which is why joe wrote "jarring" [22:52:58] Oh, right. Eh. [22:53:29] Yeah but we made the popup slightly shorter, so it helps with this bug [22:53:36] But it definitely doesn't solve it [22:58:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3072308 (10Jdforrester-WMF) [23:01:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3072336 (10Catrope) a:05Mattflaschen-WMF>03None [23:02:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072342 (10Jdforrester-WMF) Needs text to be shown, blocked by T159369. [23:02:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369#3065531 (10Jdforrester-WMF) [23:02:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072347 (10Jdforrester-WMF) [23:03:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters -should 'Restore default filters' return 'Highlight results' button to inactive state? - https://phabricator.wikimedia.org/T159503#3072350 (10Catrope) @Pginer-WMF @jmatazzoni You guys should deci... [23:04:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10VisualEditor, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3072352 (10Jdforrester-WMF) [23:06:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist: [regression betalabs] When adding/removing a page from watchlist the popup displays some code - https://phabricator.wikimedia.org/T158273#3072355 (10Catrope) I've edited the messages on beta labs to be the same as the ones on en... [23:09:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Bot' and Experience level /Page Edits filters selection - https://phabricator.wikimedia.org/T159184#3059491 (10Catrope) I don't understand what this is asking for or complaining about exactly, and I do... [23:12:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3027068 (10matmarex) This is a FloatableElement feature. It's intended to prevent weird "disconnected" menus fro... [23:14:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - Clicking on "Show new changes starting from..." does not display resulting message "Below are the changes since... " - https://phabricator.wikimedia.org/T159582#3072371 (10Mooeypoo)... [23:17:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#3072379 (10Etonkovidova) @jmatazz... [23:21:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10VisualEditor, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3072382 (10matmarex) Yeah, that looks like it should fix this. [23:21:34] (03CR) 10Bartosz Dziewoński: "This fixed T159380." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340493 (owner: 10Esanders) [23:23:44] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3072383 (10matmarex) Looks like T159380 was fixed, and this should be fixed too. See T159231 about the silly interface that preformatted text now has. [23:24:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10MZMcBride) >>! In... [23:29:14] RoanKattouw, James_F (PS1) Mooeypoo: RCFilters UI: Prevent the popup from disappearing when input is out of view [core] - https://gerrit.wikimedia.org/r/341101 [23:29:31] RoanKattouw, James_F the OOUI patch: https://gerrit.wikimedia.org/r/#/c/341100/ [23:29:44] Not sure if the naming of this config is fine, but it works. we can quibble on how to name it. [23:31:10] RoanKattouw, OOPS thank you [23:31:11] mooeypoo: I love that Gerrit let me do https://gerrit.wikimedia.org/r/#/c/341101/1..2 from the web UI [23:31:24] I had that as a test and forgot when I did git commit --all :P [23:31:27] Didn't need to do git reset HEAD^ [23:31:35] oh wow really? [23:31:39] Yes :) [23:31:54] nice! [23:31:56] Next to "Diff against: [ 1 (hash) ]" there's an "Edit" button [23:32:05] Yeah I know but I thought it was just text edit [23:32:08] When you click it an undo arrow and a red X appear next to each file [23:32:11] oh there's an X! [23:32:13] ha [23:32:16] The undo arrow undoes all changes to the file [23:32:22] The red X seems to delete the file AFIACT [23:32:22] nice [23:32:55] RoanKattouw, I love how this was a "mutter mutter oojs ui change mutter mutter" that took me 2 minutes [23:33:03] I wasn't entirely sure if it would be that quick [23:33:05] haha yeah [23:33:21] I saw the commit title, went "oh dear what has she done", and found you'd done exactly what I would have [23:47:22] Doesn't mean it's a good change. [23:47:30] Just means that you're both as bad as each other. ;-) [23:49:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072423 (10Mattflaschen-WMF) [23:49:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3072424 (10Mattflaschen-WMF) [23:49:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369#3072421 (10Mattflaschen-WMF) 05Open>03Invalid a:05Mattflaschen-WMF>03None [23:50:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#2974309 (10Mattflaschen-WMF) >>! In T156427#3072342, @Jdforrester-WMF wrote: > Needs text to be shown, blocked by T159369... [23:50:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369#3065531 (10Mattflaschen-WMF) [23:50:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072426 (10Mattflaschen-WMF) [23:51:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369#3072430 (10Mattflaschen-WMF) Last I talked to Moriel/monitored the channel, this doesn't seem to be nee... [23:51:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072431 (10Jdforrester-WMF) OK, I won't listen to @Catrope in future. :-) [23:52:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3072438 (10Catrope) [23:52:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072437 (10Catrope) [23:52:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#2974309 (10Catrope) @Mattflaschen-WMF So then it depends on T152754, right? Or at least on work that's happening in the s... [23:53:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3072443 (10Mattflaschen-WMF) Yes [23:59:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3072448 (10Jdforrester-WMF) >...