[00:23:23] (03CR) 10Catrope: [C: 032] Use different technique for sidebar full height background [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558 (owner: 10Esanders) [00:23:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [regression betalabs] The colored circles for highlighting become stretched vertically when selected - https://phabricator.wikimedia.org/T159391#3066282 (10Etonkovidova) [00:25:11] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14), and 2 others: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3066294 (10Catrope) p:05Unbreak!>03Normal [00:27:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3066305 (10Etonkovidova) @jmatazzoni - RC filters are present onl... [00:28:07] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: Insert a reference from the VE References tooltip on Flow is not possible on Beta labs - https://phabricator.wikimedia.org/T159364#3066307 (10Catrope) Could this possibly be a duplicate of {T159278} ? [00:34:02] (03Merged) 10jenkins-bot: Use different technique for sidebar full height background [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558 (owner: 10Esanders) [00:34:18] (03CR) 10jenkins-bot: Use different technique for sidebar full height background [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558 (owner: 10Esanders) [00:42:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10UI-Standardization, 03UI-Standardization-Kanban: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#3066345 (10Catrope) [00:42:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10Thanks: Move Thanks icons to Thanks repo - https://phabricator.wikimedia.org/T151768#3066344 (10Catrope) 05Open>03Resolved [00:47:46] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10UI-Standardization, 03UI-Standardization-Kanban: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#3066350 (10Catrope) [00:47:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10Thanks: Move Thanks icons to Thanks repo - https://phabricator.wikimedia.org/T151768#3066348 (10Catrope) 05Resolved>03Open Sorry, forgot about the "impossible part" from above. This task isn't done until we move `thanks-{ltr,rt... [00:54:50] 06Collaboration-Team-Triage, 10Notifications: Use ResourceLoaderImageModule for secondary link icons - https://phabricator.wikimedia.org/T159394#3066361 (10Catrope) [01:17:43] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3066455 (10Esanders) @catrope I have a local... [01:48:22] RoanKattouw, I'm getting a weird result for $( $.parseHTML( obj.responseText ) ) [01:48:30] Yes, it's an array, not a jQuery object [01:48:36] And the array may contain text nodes [01:48:39] ... how do I make it an object I can search in? [01:48:44] I thought $( ... ) does that [01:48:49] Oh wait you did $( $.parseHTML [01:48:49] Yeah [01:48:52] So what do you get back? [01:48:55] an array [01:49:18] Oh, are you trying to use .find() to locate a top-level element in that set? [01:49:24] yes... :\ [01:49:36] Yeah... [01:49:39] What I don't understand is that it works for the *response* we're getting [01:49:42] If you know that that is the case, you can use .filter() [01:49:52] Stephane did that for $parsed = $( $.parseHTML( html ) ); [01:50:02] when the ajax is successful [01:50:11] Yeah [01:50:14] So why does it not work for you [01:50:15] but it seems to not work when I put the responseText in [01:50:17] no idea [01:50:33] What is the selector you are trying to .find()? [01:51:51] .rcfilters [01:52:05] But I don't even get $parsed.find( 'body' ) [01:52:10] and that definitely exists [01:53:03] Yeah for some reason it drops the body [01:53:06] But everything else is there [01:53:12] .rcoptions is there [01:53:22] .rcfilters-container is there [01:53:43] ok this is weird [01:53:50] in stephane's success method, it appears to be the same [01:53:59] and then $parsed.find('.mw-changeslist').first().contents() works [01:54:24] but $parsed.find('.rcfilters').first() doesn't [01:54:26] it's empty [01:54:33] the hell [01:54:44] I don't see .rcfilters anywhere [01:55:14] Not even on a normal page [01:55:15] .... omg, I'm using the wrong class [01:55:19] Are you sure that is the correct selector? [01:55:20] ..... shuttup. [01:55:33] ..... [01:55:35] omg. [01:55:39] OMG SERIOUSLY [01:55:44] * mooeypoo bashes head into laptop [01:55:56] it's .rclinks [01:55:58] not rcfilters [01:56:00] AAAAAA [01:56:12] * mooeypoo sobs [01:56:43] * mooeypoo waits for RoanKattouw to quack [01:56:53] Although to be fair, that was more you ducking than me ducking [01:56:55] but still [01:57:04] I quacked pretty loudly I thought :P [01:58:32] * mooeypoo sobs [01:58:49] RoanKattouw, at least I reorganized the ajax method [01:59:05] it no longer returns inconsistent reject/resolve-with-'no results'-or-with-null [01:59:18] It always resolves -- either with "no results" or with results [01:59:32] and the only time it rejects is if there was another request that overrides it [01:59:39] so at least now we can be more consistent [02:00:02] This whole "no results is a 404 failure" was insanely confusing [02:03:22] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: Insert a reference from the VE References tooltip on Flow is not possible on Beta labs - https://phabricator.wikimedia.org/T159364#3066530 (10Jdforrester-WMF) [02:09:51] mrrrr [02:10:21] RoanKattouw, another hurdle in "just" replacing current show/hide links with the one from the ajax response -- we go over those and **remove them** [02:10:31] remove the ones we're already using [02:11:34] Oh, heh [02:11:40] Yeah you'd have to factor that code out and run it again [02:13:20] OR [02:13:23] I can be creative. [02:13:46] I think what I have in mind might be slightly "cheaper" too, rather than taking the content and running that "hide" thing again [02:13:48] let's see though [02:21:36] Remember if you need metadata on the old show/hide links, post at T159369 [02:21:36] T159369: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369 [02:21:42] ^ mooeypoo [02:22:32] matt_flaschen, aye, I remember [02:22:34] for now i'm good [02:22:35] I think [02:23:26] errr RoanKattouw meh, I forgot live binding; that should work if I replace links (and then still catch the clicks on the new links) right? [02:23:43] Yeah [02:24:00] As long as you bind on an ancestor that doesn't get destroyed [02:24:36] actually, instead of -- this.$element.find( 'a[data-params]' ).on( 'click', this.onLinkClick.bind( this ) ); I should do this.$element.on( 'click', 'a[data-params]', this.onLinkClick.bind( this ) ); [02:24:51] The $element should always be there. I'm just replacing parts in it [02:25:28] bd808, do you know where the PHP error logs go? It used to be /vagrant/logs/apache2.log , but not anymore. I'm currently on Zend using the ugly orange boxes, but open to switching to HHVM. [02:31:36] mooeypoo: Yes [02:32:23] RoanKattouw, ok this works, I don't seem to need anything from the server, and it's less convoluted than I expected [02:32:27] pushing a ps in a minute [02:33:01] btw, I keep getting "resources/src/mediawiki.special/mediawiki.special.preferences.styles.css" stylelint error when I run grunt [02:33:04] meh [02:35:59] RoanKattouw, https://gerrit.wikimedia.org/r/340270 [02:40:20] mooeypoo: Yes, we upgraded stylelint recently. [02:40:32] James_F, so I should run npm install? [02:40:36] mooeypoo: I fixed at least one thing in stylelint itself. [02:40:49] mooeypoo: That would likely help identify the thing to fix. [02:40:50] Err. [02:41:02] mooeypoo: I fixed at least one thing in RC Filters to fix. [02:41:07] ooh [02:41:11] what was it [02:41:44] No idea. I fixed a few hundred failures. :-) [02:42:01] Something about using !important without a waiver, probably. [02:42:46] Ah, string quotes is 768654ac814dcbd2e5d8ed63a4553079c4d0d406 [02:44:05] But declaration-no-important is fdf499f2ffca1b170cc5acf48ea523bf915304d8 if you want to merge it. ;-) [02:46:21] (03CR) 10Catrope: [C: 032] Make dropdown button links full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340546 (owner: 10Esanders) [02:46:36] James_F, +2'ed. I would rather we identified *why* important was used at all and fix that, but seeing the nmber of times it's used, that's unrealistic. [02:47:25] Yeah, at least this will give people pause for thought before over-riding, and we can revisit/remove later. [02:57:06] (03Merged) 10jenkins-bot: Make dropdown button links full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340546 (owner: 10Esanders) [02:57:24] (03CR) 10jenkins-bot: Make dropdown button links full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340546 (owner: 10Esanders) [03:06:53] (03CR) 10Catrope: [C: 032] Fix padding of large inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339947 (owner: 10Esanders) [03:08:27] (03CR) 10Catrope: [C: 032] Remove toolbar border (shadow) in monobook as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339948 (owner: 10Esanders) [03:17:31] (03Merged) 10jenkins-bot: Fix padding of large inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339947 (owner: 10Esanders) [03:17:33] (03Merged) 10jenkins-bot: Remove toolbar border (shadow) in monobook as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339948 (owner: 10Esanders) [03:17:48] (03CR) 10jenkins-bot: Fix padding of large inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339947 (owner: 10Esanders) [03:18:11] (03CR) 10jenkins-bot: Remove toolbar border (shadow) in monobook as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339948 (owner: 10Esanders) [05:26:13] (03PS1) 10MtDu: Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) [05:29:02] (03PS2) 10MtDu: Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) [05:42:24] (03CR) 10Catrope: [C: 04-1] Support loading of secondary icons in RLEIM module (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) (owner: 10MtDu) [05:45:19] (03PS3) 10MtDu: Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) [05:50:00] (03CR) 10Catrope: [C: 032] Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) (owner: 10MtDu) [05:55:00] (03PS1) 10Catrope: NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 [06:00:56] (03Merged) 10jenkins-bot: Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) (owner: 10MtDu) [06:01:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10Thanks: Move Thanks icons to Thanks repo - https://phabricator.wikimedia.org/T151768#3066761 (10Catrope) [06:01:19] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Use ResourceLoaderImageModule for secondary link icons - https://phabricator.wikimedia.org/T159394#3066760 (10Catrope) 05Open>03Resolved [06:02:11] (03CR) 10jenkins-bot: Support loading of secondary icons in RLEIM module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340689 (https://phabricator.wikimedia.org/T159394) (owner: 10MtDu) [06:05:10] (03PS2) 10Jforrester: NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 (owner: 10Catrope) [06:08:50] 06Collaboration-Team-Triage, 10Notifications, 07I18n, 07RTL: RTL for Notification Tool: ? should be ؟ icon - https://phabricator.wikimedia.org/T56276#3066764 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF I believe that this is now long-since fixed, since we moved to OOjs UI. [06:08:58] (03CR) 10Catrope: [C: 031] NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 (owner: 10Catrope) [06:09:24] (03CR) 10Jforrester: [C: 032] NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 (owner: 10Catrope) [06:19:45] (03CR) 10Jforrester: [C: 032] Remove FloatableElement hack, no longer needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [06:19:49] (03Merged) 10jenkins-bot: NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 (owner: 10Catrope) [06:21:34] (03CR) 10jenkins-bot: NotificationBadgeWidget: Fix appearance of bottom buttons for OOUI changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340691 (owner: 10Catrope) [06:28:39] (03CR) 10jerkins-bot: [V: 04-1] Remove FloatableElement hack, no longer needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [06:35:34] (03CR) 10Catrope: [C: 032] "Let's try that again" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [06:38:56] (03CR) 10Jforrester: [C: 032] Align the cross-wiki icon with the other notification icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315313 (https://phabricator.wikimedia.org/T147221) (owner: 10Catrope) [06:39:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Vertical alignment of logos and text in Notifications popup - https://phabricator.wikimedia.org/T147221#3066774 (10Jdforrester-WMF) | Before | {F5998245,size=full} | | After | {F5998244,size=full} | Merged. [06:42:25] 06Collaboration-Team-Triage, 10Notifications: RTL version for feedback.svg icon - https://phabricator.wikimedia.org/T146218#2653975 (10Jdforrester-WMF) I created the RTL version of this icon when Roan put it into OOUI for this in RCFilters; someone needs to delete it from the Notifications repo and change the... [06:46:13] (03Merged) 10jenkins-bot: Remove FloatableElement hack, no longer needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [06:47:44] (03CR) 10jenkins-bot: Remove FloatableElement hack, no longer needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [06:47:49] (03Merged) 10jenkins-bot: Align the cross-wiki icon with the other notification icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315313 (https://phabricator.wikimedia.org/T147221) (owner: 10Catrope) [06:49:13] (03CR) 10jenkins-bot: Align the cross-wiki icon with the other notification icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315313 (https://phabricator.wikimedia.org/T147221) (owner: 10Catrope) [07:13:20] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Provide an easy to use HTML mail system - https://phabricator.wikimedia.org/T156231#3066799 (10Osnard) @Mattflaschen-WMF: I think MediaWiki core should feature such a system for all outgoing mails. Echo could then... [07:18:16] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3066801 (10MZMcBride) @Dereckson: I missed the discussion in `#wikimedia-operations`. I'm trying to better understand the status... [07:48:55] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Provide an easy to use HTML mail system - https://phabricator.wikimedia.org/T156231#2968154 (10Legoktm) I think this task has been way overblown in the past and can be implemented without too much difficulty. Firs... [08:01:26] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New pages feed/ page curation Wishlist changes - https://phabricator.wikimedia.org/T159188#3066845 (10Kudpung) Can you please clarify what you mean by 'I agree the task should either be closed, or at least mad... [08:11:18] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3066851 (10Pginer-WMF) Sounds good to go wit... [08:23:42] Hi, I and my teammate want to work on this task. https://phabricator.wikimedia.org/T96061 [08:24:17] Will it be assigned to both of us or only one ? [09:33:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 07Easy, 06Stewards-and-global-tools (Temporary-UserRights): Update Flow for expiring user groups - https://phabricator.wikimedia.org/T157017#3067016 (10TTO) p:05Triage>03Low It's just excluding bots from a list of new users. [09:44:28] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Tracking: [DO NOT USE] Page Curation (tracking) [superseded by #MediaWiki-extensions-PageCuration] - https://phabricator.wikimedia.org/T55504#3067039 (10Liuxinyu970226) [11:05:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3067378 (10Trizek-WMF) [11:06:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 05MW-1.29-release-notes, and 2 others: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10Trizek-WMF) The fe... [11:06:50] 06Collaboration-Team-Triage, 10Flow, 06WMF-Design, 07Design: Make source/wikitext icon consistent - https://phabricator.wikimedia.org/T97451#3067381 (10Pginer-WMF) I think this ticket can be closed. The current discussion included other topics that expanded a bit the scope of the initial description, but t... [11:08:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Make it so the Help link on the RC page links to beta feature help for beta users - https://phabricator.wikimedia.org/T158819#3067394 (10Trizek-WMF) [11:08:20] 06Collaboration-Team-Triage, 10Flow, 07Design: Flow entry fields should not look terrible - https://phabricator.wikimedia.org/T95512#3067397 (10Pginer-WMF) [11:09:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Make it so the Help link on the RC page links to beta feature help for beta users - https://phabricator.wikimedia.org/T158819#3048337 (10Trizek-WMF) The documentation page has been moved to have... [11:23:48] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New pages feed/ page curation Wishlist changes - https://phabricator.wikimedia.org/T159188#3067444 (10Aklapper) @Kudpung: This statement can apply to any task because it is about //formal requirements// and no... [11:40:00] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Easy: Add a "Mark all as read" button at Special:Notifications for no-JS users - https://phabricator.wikimedia.org/T96061#3067493 (10charul97) a:03charul97 [12:00:57] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Easy: Add a "Mark all as read" button at Special:Notifications for no-JS users - https://phabricator.wikimedia.org/T96061#3067605 (1097arushisharma) a:05charul97>0397arushisharma [12:21:52] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Easy: Add a "Mark all as read" button at Special:Notifications for no-JS users - https://phabricator.wikimedia.org/T96061#3067635 (1097arushisharma) a:0597arushisharma>03charul97 [12:22:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Evaluate the differences of Recent Changes, Watchlist and User Contribution filters - https://phabricator.wikimedia.org/T159444#3067636 (10Pginer-WMF) [12:25:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#3067654 (10Pginer-WMF) I made a comparison of Watchlist and User Contributions (w... [12:41:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Evaluate the differences of Recent Changes, Watchlist and User Contribution filters - https://phabricator.wikimedia.org/T159444#3067695 (10Pginer-WMF) [13:33:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Make it so the Help link on the RC page links to beta feature help for beta users - https://phabricator.wikimedia.org/T158819#3067785 (10SBisson) >>! In T158819#3067394, @Trizek-WMF wrote: > The... [13:34:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Make it so the Help link on the RC page links to beta feature help for beta users - https://phabricator.wikimedia.org/T158819#3067786 (10Trizek-WMF) >>! In T158819#3067785, @SBisson wrote: > Got... [13:39:28] (03PS1) 10Esanders: Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 [13:39:30] (03PS1) 10Esanders: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 [13:39:38] (03CR) 10jerkins-bot: [V: 04-1] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [13:48:20] (03CR) 10jerkins-bot: [V: 04-1] Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [17:20:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Vertical alignment of logos and text in Notifications popup - https://phabricator.wikimedia.org/T147221#3068237 (10Etonkovidova) Checked in betalabs - the alignment seems... [17:25:31] RoanKattouw, I'm pretty sure this needs to be urgently deployed to fix the "missing classes" issue https://gerrit.wikimedia.org/r/#/c/340349/ [17:38:06] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3068342 (10demon) >>! In T63729#3066801, @MZMcBride wrote: > @Dereckson: I missed the discussion in `#wikimedia-operations`. I'm... [17:41:20] 06Collaboration-Team-Triage, 10Flow, 07TestMe: Flow email bundle for new topics is broken - https://phabricator.wikimedia.org/T96177#3068347 (10matej_suchanek) [17:59:17] mooeypoo: Good catch [17:59:23] So it was merged, but missed the train by a couple hours [18:00:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist: Change in Watchlist behaviour causing breakages in gadgets - https://phabricator.wikimedia.org/T159466#3068415 (10Jdforrester-WMF) [18:00:43] Heya. [18:01:40] RoanKattouw, so this solves the class issue, but not the diff link issue [18:01:45] I can't figure that one out so far [18:01:54] What is the diff link issue? [18:02:08] I'm going to ask ikhitron to post all the concerns in a task, maybe. He says there are "other" bugs [18:02:17] "Grouping view group members syntax was changed, the link to diff was [18:02:18] replaced by a link to cur." [18:02:25] T159466 [18:02:25] T159466: Change in Watchlist behaviour causing breakages in gadgets - https://phabricator.wikimedia.org/T159466 [18:02:30] oh! [18:02:38] James created it juts now [18:03:14] "* Grouping view group members syntax was changed, the link to diff was replaced by a link to cur." [18:03:15] I see [18:11:33] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3068479 (10Dereckson) @demon @MZMcBride The Flow team have some reserves about the logs integrity: it will be difficult to see th... [18:14:44] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3068503 (10demon) >>! In T63729#3068479, @Dereckson wrote: > @demon @MZMcBride The collaboration team have some reserves about th... [18:15:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Vertical alignment of logos and text in Notifications popup - https://phabricator.wikimedia.org/T147221#3068522 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [18:18:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3068530 (10Mattflaschen-WMF) > URLs (when copied/pasted or clicked f... [18:19:15] (03PS2) 10Esanders: Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 [18:19:17] (03PS2) 10Esanders: New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 [18:19:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, 13Patch-For-Review: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3068531 (10DannyH) [18:24:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 13Patch-For-Review: Change in Watchlist behaviour causing breakages in gadgets - https://phabricator.wikimedia.org/T159466#3068563 (10Catrope) >>! In T159466#3068541, @Stashbot wrote: > {nav icon=file, name=Mentioned in SAL (#w... [18:26:49] (03CR) 10Catrope: [C: 032] Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [18:27:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 13Patch-For-Review: Change in Watchlist behaviour causing breakages in gadgets - https://phabricator.wikimedia.org/T159466#3068568 (10IKhitron) Thank you, @Catrope. It works! And it seems that all the issues were fixed. If ther... [18:28:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Evaluate the differences of Recent Changes, Watchlist and User Contribution filters - https://phabricator.wikimedia.org/T159444#3068571 (10Pginer-WMF) [18:29:55] (03CR) 10jerkins-bot: [V: 04-1] Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [18:30:53] (03CR) 10jerkins-bot: [V: 04-1] New editor switching widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340741 (owner: 10Esanders) [18:34:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 13Patch-For-Review: Change in Watchlist behaviour causing breakages in gadgets - https://phabricator.wikimedia.org/T159466#3068591 (10Catrope) 05Open>03Resolved >>! In T159466#3068568, @IKhitron wrote: > Thank you, @Catrope... [18:35:08] (03CR) 10jerkins-bot: [V: 04-1] Fix switching widget when VE is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340740 (owner: 10Esanders) [18:37:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3068601 (10Etonkovidova) Returning to ready for pick - UI for RC fil... [18:47:06] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3068633 (10BethNaught) There were two flow boards: the ORES talk page has been moved to mw.org and the contributions can be seen... [19:06:31] aaaaaaa there was a fix for button icons height! [19:06:37] James_F, ??? [19:06:49] .oo-ui-buttonElement-framed.oo-ui-iconElement > .oo-ui-buttonElement-button > .oo-ui-iconElement-icon { ... height: 100% } [19:07:02] all my lovely highlight circles are squished now [19:07:12] Ho-hum. Maybe. [19:07:18] They're *squished*. [19:07:25] * mooeypoo stares at ooui [19:07:27] I blame RoanKattouw though. [19:07:31] Always. [19:07:36] It's a good strategy. [19:08:37] meh, the nested "forced" classes on ooui icons inside buttons are annoying [19:08:50] I'll have to either do the entire structure or use !important to override [19:14:05] RoanKattouw, aaaaaaaa it's not just overriding that, there are other rules in there [19:14:07] * mooeypoo sobs [19:14:12] my perfect circle [19:17:39] mooeypoo and I were discussing earlier, so I tested "* Grouping view group members syntax was changed, the link to diff was replaced by a link to cur." [19:17:42] Can not reproduce any difference. [19:18:01] Both enwiki and hewiki watchlist show both cur and prev for the individual members of the groups. [19:18:12] RoanKattouw, James_F https://gerrit.wikimedia.org/r/#/c/340803/ [19:18:17] ^ RoanKattouw [19:18:23] matt_flaschen, yeah, ok, good, I thought I was missing something [19:18:34] also, if ikhitron said it works now, then it probably was only the class name [19:18:52] he may have had something in the gadget attaching to class name and doing something with the diff links, and once that was broken that part failed? [19:18:57] Yeah, I just wanted to check in case there was a change, even if he doesn't really care that much others might (or it might just be wrong) [19:19:10] Yeah, quite possible. [19:19:11] Yeah no thank you for that, I couldn't see anything and was concerned [19:20:40] bah great now the capsule circle is messed up [19:20:43] * mooeypoo grunts [19:22:16] RoanKattouw, mooeypoo, semi-relatedly, one of the changes James mentioned (turns out not related) was T157178, which is properly tagged for RC and Watchlist, but not with ERI. [19:22:16] T157178: Add class to diff and history links in changes lists for easier selecting in CSS/javascript - https://phabricator.wikimedia.org/T157178 [19:22:27] Do you think we should have those go to the channel? [19:22:39] Hm [19:22:42] maybe we should [19:22:43] It would also be good to have the Gerrit changes too, but I don't think that is supported currently. [19:22:54] I mean, w'ere actively working on those sections, we should keep track of bugs related to it [19:23:05] yeah, that too [19:27:18] https://gerrit.wikimedia.org/r/340806 [19:28:21] When I submit another patchset, my own -2 vanishes, right? Or do I need to un-2 myself? [19:28:37] hm it stayed, ok [19:29:14] stephanebisson, how are you doing? [19:29:33] mooeypoo: i'm fine. you? [19:29:53] All -2's stay. [19:30:12] stephanebisson, Better now that your fix is properly deployed :D [19:30:24] apparently my [] error (oops) broke gadgets on hewiki [19:30:25] mooeypoo: yeah, I saw that... oups [19:30:27] ... of all places [19:31:01] Well, I mean, I guess if anyone questioned whether I deserved the "I broke Wikipedia" tshirt, I do now. [19:32:36] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for HTML email - https://phabricator.wikimedia.org/T156231#3068728 (10Mattflaschen-WMF) [19:33:17] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for HTML email - https://phabricator.wikimedia.org/T156231#2968154 (10Mattflaschen-WMF) I've rescoped to be about customizable core HTML templates, per above, and will make it a subtask of T... [19:33:32] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for HTML email - https://phabricator.wikimedia.org/T156231#3068732 (10Mattflaschen-WMF) [19:34:26] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for HTML email - https://phabricator.wikimedia.org/T156231#2968154 (10Mattflaschen-WMF) [19:34:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Customizable templates for core HTML email - https://phabricator.wikimedia.org/T156231#2968154 (10Mattflaschen-WMF) [19:36:17] RoanKattouw, stephanebisson https://gerrit.wikimedia.org/r/#/c/340803/2 <-- my highlight circles are eggs, please review/merge [19:36:29] Don't let my circles be eggs anymore... save them.... sssssaaaaaaaaaave them.... [19:38:22] Getting lunch [19:52:56] mooeypoo: And you took part in fixing it too, by identifying the patch that fixes it [19:53:28] It was nice to step off my bike and see that everything was figured out already [20:07:51] haha [20:10:42] (Going out for lunch) [20:22:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3068877 (10Etonkovidova) [20:26:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3068885 (10Etonkovidova) @Moo... [20:28:40] RoanKattouw, answered your code review in https://gerrit.wikimedia.org/r/#/c/340270/9 [20:28:57] RoanKattouw, I'm actually pretty proud of the $similarElements = $element.parent().find( '[data-keys="' + keys + '"]' ); trick [20:28:58] :D [20:29:06] (but I can take it out if you think we should replace the entire fieldset) [21:07:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3068999 (10jmatazzoni) [21:08:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3068998 (10jmatazzoni) [21:10:52] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069005 (10Toniher) [21:12:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3069034 (10jmatazzoni) [21:14:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#2753115 (10jmatazzoni) [21:14:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3059541 (10jmatazzoni) [21:45:43] I'm back! [21:45:44] (for now) [21:53:11] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#663569 (10Catrope) >>! In T63729#3068503, @demon wrote: >>>! In T63729#3068479, @Dereckson wrote: >> @demon @MZMcBride The collab... [21:54:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3069157 (10Mooeypoo) >>! In T149391#3063136, @jmatazzoni... [22:05:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340854 (owner: 10L10n-bot) [22:05:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340859 (owner: 10L10n-bot) [22:10:26] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069205 (10demon) I'm not sure we need `deleteBatch.php` in this case since it's already down to just one page, but otherwise tha... [22:13:09] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069212 (10Catrope) >>! In T63729#3069205, @demon wrote: > I'm not sure we need `deleteBatch.php` in this case since it's already... [22:14:25] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069218 (10demon) >>! In T63729#3069212, @Catrope wrote: >>>! In T63729#3069205, @demon wrote: >> I'm not sure we need `deleteBat... [22:15:38] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069224 (10Catrope) >>! In T63729#3069218, @demon wrote: >>> , but otherwise that plan sounds good. Let's get this on Wikitech. >... [22:19:00] mooey|food: Could you review https://gerrit.wikimedia.org/r/#/c/340494/ ? It's a bit over my head [22:20:01] (03PS1) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 [22:22:27] (03CR) 10jerkins-bot: [V: 04-1] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:23:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: "Days" and "limit" links on RC page need AJAX - https://phabricator.wikimedia.org/T156697#3069245 (10Jdforrester-WMF) Roan says this was done as part of T157594. [22:24:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Add a "live" option to the "days" feature that AJAX refreshes the page every N seconds (30?) - https://phabricator.wikimedia.org/T159489#3069250 (10Jdforrester-WMF) [22:27:46] RoanKattouw, on it [22:28:01] I think it's an older version though [22:28:11] (03PS2) 10Catrope: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:30:13] (03CR) 10jerkins-bot: [V: 04-1] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:30:31] (03CR) 10Paladox: Fix Flow autoload data and gen-autoload.php (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:31:28] (03PS3) 10Paladox: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:32:18] (03PS4) 10Catrope: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:34:39] (03CR) 10jerkins-bot: [V: 04-1] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:38:53] (03PS5) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 [22:40:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#3069280 (10Mooeypoo) > When search finds matches, the first result is highl... [22:41:16] (03CR) 10jerkins-bot: [V: 04-1] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [22:42:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3069295 (10Mooeypoo) >>! In T... [22:45:29] etonkovidova, meh, I once again lost the task where the highlight icon is [22:45:34] ... the highlight task in general, I think [22:45:35] I can't find it [22:46:06] also etonkovidova this should be fixed hopefully https://phabricator.wikimedia.org/T159391 [22:46:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [regression betalabs] The colored circles for highlighting become stretched vertically when selected - https://phabricator.wikimedia.org/T159391#3066282 (10Mooeypoo) Was caused due to a change in OOUI -- Fixed earlie... [22:46:52] mooeypoo: ok, do not panic :) This one? https://phabricator.wikimedia.org/T149452 [22:47:39] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069005 (10Vriullop) For clarification, it is enabling Flow by default on user talk namespace, for pages which does not exist, without moving exis... [22:48:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - reloading RC page shows the old layout - https://phabricator.wikimedia.org/T159265#3062205 (10Mooeypoo) Actually, it should be gone now. We've added a "loader" animation in a patch that was merged late yesterday. [22:48:47] hm etonkovidova I don't think so? I'm looking for where Pau uploaded the highlight icon [22:49:09] The irony is that I asked him once, and he ANSWERED and I can't find it again [22:49:10] mooeypoo: oops - I think it's this one: https://phabricator.wikimedia.org/T149435 -- highlighting in blue blue for search maatch [22:49:28] No, not that one [22:49:29] meh [22:49:45] mooeypoo: well, for which highlighting you're looking for? [22:50:16] etonkovidova, Pau added the custom icon that he wants us to use [22:50:19] .... somewhere [22:50:36] mooeypoo: ah - that one I do not know :( [22:50:38] And I already ASKED him and he ANSWERED and now I don't remember where he answered [22:50:41] * mooeypoo sighs [22:51:23] It's like writing a reminder and then forgetting where you put it [22:51:28] counter productive, brain [22:55:11] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069320 (10Catrope) 05Open>03Resolved a:03Catrope This is now done [22:55:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - Selecting 'full coverage' and 'conflict' filters makes any additionally selected filter(s) be displayed as active without affecting the result set - https://phabricator.wikimedia.org/T159199#3069323 (10... [22:58:10] (03PS6) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 [22:59:23] (03PS7) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 [23:06:38] (03CR) 10jerkins-bot: [V: 04-1] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [23:06:46] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069346 (10Mattflaschen-WMF) [23:06:59] etonkovidova, https://phabricator.wikimedia.org/T149467 !!!!! [23:07:00] FOUND IT [23:07:02] yeesh [23:07:21] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3069347 (10Catrope) >>! In T63729#3069224, @Catrope wrote: >>>! In T63729#3069218, @demon wrote: >>>> , but otherwise that plan s... [23:08:45] mooeypoo: Great :)) wow, the title mentions 'highlight' twice! [23:09:12] I know, and yet it took me forever to find it [23:11:41] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#2296045 (10Keegan) I would like to thank all participants in this and related tasks here on Phabricator for their communication a... [23:15:02] etonkovidova, ok there's a patch for that icon -- should I leave the task in QA or should I pull it to 'needs review' until the patch is merged? [23:15:27] (03PS8) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 [23:15:33] mooeypoo: does it need code review? [23:15:42] well, I mean.. I can't merge it [23:15:52] I can. [23:15:52] mooeypoo: if it only waits for merging, then move it to QA [23:15:54] RoanKattouw might do it quickly if he likes my trick [23:16:00] It's alreayd in QA [23:16:05] I'm wondering if I should leave it there or not [23:16:18] ok [23:16:29] James_F, feel free-- the only potential weirdness is that the icon seems slightly bigger to me, but that's likely an issue of not having the same whitespace inside the other icons [23:16:38] which is good, but might mean we want to make it slightly smaller [23:16:42] but also pau can tell us after we have it in [23:16:51] mooeypoo: Needs crushing. [23:17:01] … which Roan is doing. [23:17:01] needs what? [23:17:11] You're crushing? [23:17:33] Also, this should go up to ooui [23:17:36] I am not sure what the process is [23:20:13] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow in cawiki User talk namespace of new users - https://phabricator.wikimedia.org/T159482#3069479 (10Toniher) @Mattflaschen-WMF since I think most (if not all) new users were receiving a welcome message in their talk pages, I imagine th... [23:31:37] (03CR) 10Catrope: [C: 032] Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [23:38:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3069535 (10Etonkovidova) [23:42:18] (03Merged) 10jenkins-bot: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [23:42:32] (03CR) 10jenkins-bot: Fix Flow autoload data and gen-autoload.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340873 (owner: 10Mattflaschen) [23:46:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3069582 (10Etonkovidova) [23:47:32] (03PS1) 10Mattflaschen: Fix Flow autoload data and gen-autoload.php [extensions/Flow] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340901 [23:48:02] (03CR) 10Mattflaschen: [C: 032] Fix Flow autoload data and gen-autoload.php [extensions/Flow] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340901 (owner: 10Mattflaschen) [23:59:17] (03Merged) 10jenkins-bot: Fix Flow autoload data and gen-autoload.php [extensions/Flow] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340901 (owner: 10Mattflaschen)