[00:42:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta from displaying on mobile (including the desktop version of mobile) - https://phabricator.wikimedia.org/T158923#3063237 (10jmatazzoni) Responding to @Pginer-WMF's comments above: James was askin... [00:48:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3063245 (10jmatazzoni) [00:50:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3063254 (10SBisson) >>! In T149391#3063136, @jmatazzoni w... [00:56:14] RoanKattouw, can you remind me, how do I check if a user has an option enabled in the special page? [00:56:17] I can't find it [00:56:28] $this->getUser()->getOption( 'foo' ) [00:56:30] ? [00:56:40] Assuming that $this is a SpecialPage subclass [00:56:57] yeah, SpecialRecentChanges [01:24:04] RoanKattouw, (PS1) Mooeypoo: RCFilters: Add loading animation [core] - https://gerrit.wikimedia.org/r/340451 [01:24:10] ^ a bit crude, but works [01:25:00] (03PS1) 10MaxSem: Get rid of global state [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/340452 (https://phabricator.wikimedia.org/T159299) [01:25:36] Hmm [01:25:57] I don't like duplicating pending.gif, but there's also no easy way to reuse it from OOUI without applying an ooui-specific classs [01:26:12] yeah [01:26:18] Plus OOUI isn't loaded then [01:26:23] Right [01:26:30] I am doing the same thing Echo does [01:26:38] Not entirely sure I like how it's only showing it on the bottom half, though. [01:26:42] Maybe I should put it on both [01:26:44] Also how does rcfilters-container { min-height: 100px; } help if that container is never removed, never hidden, and nothing is ever added to it? [01:26:52] Oh, nm [01:26:56] The filters widget is added to it [01:27:23] yeah [01:27:37] It's also better because then we can move this wrapper if we want to [01:28:32] RoanKattouw, hang on, I made it better [01:28:36] see ps2 [01:28:41] In my ideal world, that wrapper would contain all the things whose height could possibly change [01:28:56] Meh, I didn't want to put the fieldset in it [01:28:56] including everything that's hidden later [01:29:02] eh [01:29:18] Well, it basically does that [01:29:29] The only thing whose height changes is the filter wrapper [01:29:37] the fieldset gets a couple of filters removed but the spacing remains [01:29:47] But its style changes too, right? [01:31:06] barely [01:31:14] but yeah that's why it's invisible [01:31:16] check out ps2 [01:31:17] better? [01:31:21] it's less jumpy for me [01:32:06] I haven't tried it yet, hold on [01:32:27] I was busy uploading https://gerrit.wikimedia.org/r/340454 :D [01:32:39] (Now I need to rewrite the multi-directional popup commit on top of that) [01:32:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3063384 (10Mattflaschen-WMF) This is already how it works (hidehuman... [01:33:54] I love how you wrote "TODO: Write commit message" *in* the commit message [01:35:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3063387 (10jmatazzoni) [01:35:20] mooeypoo can you reply at T158923 about the highlighting URL parameters? IIUC, you could do just the display-highlighting part (not the part about selecting highlights) on mobile by extracting out that part of the JS. [01:35:20] T158923: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923 [01:36:42] matt_flaschen, answer what? I thought the final comment from Joe says it's too much effort? [01:36:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3063387 (10jmatazzoni) a:03Mattflaschen-WMF [01:37:26] mooeypoo, the description still says, "If we make sure that all the URL query parameters created on the desktop system effect the same results on mobile, then mobile users can basically bookmark their RC page settings. @Catrope, is there any reason we can't do that? Can that include highlighting as well?" [01:37:38] mooeypoo, the only one that doesn't Just Work currently is displaying highlighting, AFAICT. [01:37:41] eh [01:37:44] yeah [01:37:55] I guess we could extract the highlight logic [01:38:11] Either way, I just wanted to let you know since I replied about the other parts. [01:39:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3063405 (10Mooeypoo) > However, there is one thing we can do to prov... [01:39:29] * mooeypoo nods [01:40:33] mooeypoo: Looks good but I've amended to fix a PHP warning [01:40:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3063407 (10jmatazzoni) OK. Thanks @Mooeypoo, Changing the descriptio... [01:40:43] I have it configured so it draws a giant red box for every warning/error [01:41:02] And drawing that box then triggers a bunch of "Headers already sent" warnings which draw more boxes over top the first box :/ [01:41:10] RoanKattouw, err did you just fix the patch? [01:41:14] i just fixed the patch too [01:41:15] >.< [01:41:18] oops [01:41:34] Oh, I'll redo [01:41:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Block RC Filters beta interface from displaying on mobile, but make sure that URL query parameters work - https://phabricator.wikimedia.org/T158923#3063410 (10jmatazzoni) [01:41:41] I just added spaces [01:41:50] that's what jenkins seems to be complaining about [01:43:04] Looks like 100px is not quite enough but it's close [01:43:27] If I hover the first result while it loads, then after loading I end up hovering the title with the date right above that result [01:44:01] RoanKattouw, I was worried going too high [01:44:17] making it jump worse -- also, it kinda depends whether you have more in the fieldset [01:44:22] Well worst case it makes the page slightly spacier [01:44:27] It won't make it jump worse though [01:44:36] I recommended *max*-height for a reason [01:44:40] no because that min height is only before load I think? [01:44:48] Sorry min, yes [01:44:57] No, the idea is you keep applying it after load [01:45:11] That way that div might be a bit taller than it needs to be, but that's OK jumpiness-wise [01:45:12] 06Collaboration-Team-Triage: User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3063415 (10Etonkovidova) [01:45:17] It's just that if it's excessive, it looks weird [01:45:22] yea but we can't trust it anyways [01:45:25] the content is per wiki [01:45:33] some wikis will have more filters to fill it up and make it taller [01:46:36] 06Collaboration-Team-Triage, 10Notifications: User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3063428 (10Catrope) Regression from {T12493} [01:47:09] But the part we're removing isn't per-wiki, is it? [01:47:10] RoanKattouw, also, I do have the icon and the conflict-color thing still to do [01:47:15] Oh, wait, you're right, it is [01:47:20] OK yeah go ahead [01:47:24] but... remember how we said "oh this will keep me busy for the next couple of days!" ? [01:47:25] about that. [01:47:31] haha [01:47:54] If you run out of work before I finish the popup code, I'll make you do the menu thing :) [01:48:06] Yeah I'll do the icon and stuff tomorrow, then go over the rest of the bugs and see [01:48:37] but yeah, the min height is tricky -- we're removing filters we're using. If a wiki has wikidata and translatewiki the box can be taller [01:48:41] my vagrant has neither [01:48:54] so it's shorter... so i didn't know where to compromise [01:49:21] And I definitely didn't want to keep the min height too big *after* load or we'd get potentially a big margin from the form/header to the list of results. [01:49:32] Hmm, but thinking about it -- does it matter? [01:49:43] Because all the stuff we're removing is already display: none; in the loading state, right? [01:50:05] hm I still have a gap there though [01:50:10] So we only need to estimate the height of the filter capsule widget, plus the links, plus the form [01:50:28] Well, that's what I did [01:50:35] and for me currently it doesn't jump at all [01:50:47] For you it does, though - so I'm worried this is a bit more per-wiki than we like? [01:50:58] If those three are all wrapped in one container, and that container has a min-height, then we can ensure zero jump [01:51:02] It jumps for me but <10px [01:51:15] It's not perceptible unless you hover a link in the result set while loading [01:53:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3063442 (10Etonkovidova) @Mooeypoo - any comments on the following? >(2... [01:54:12] I think it may have something to do with the fact that the post-load height of rcfilters-container is ~104px [01:54:33] But I'd prefer it if we could put the rcoptions fieldset inside that container too [01:56:59] (Going to go home and eat, and then poke at popups some more) [02:03:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3063455 (10Mooeypoo) >>! In T149452#3063442, @Etonkovidova wrote: > @Moo... [02:04:30] hm [02:04:37] ok I'll check into that tomorrow. [02:04:40] night everyone [02:07:30] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3063461 (10Mattflaschen-WMF) [02:11:15] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3063463 (10Mattflaschen-WMF) It is now re-scheduled slightly for Thursday at 22:00 UTC. [02:36:29] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3063478 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [02:40:57] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New pages feed/ page curation Wishlist changes - https://phabricator.wikimedia.org/T159188#3063483 (10Mattflaschen-WMF) [02:46:19] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New pages feed/ page curation Wishlist changes - https://phabricator.wikimedia.org/T159188#3059587 (10Mattflaschen-WMF) >>! In T159188#3060721, @Aklapper wrote: > If this was something to work on in an Outreac... [02:47:28] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New pages feed/ page curation Wishlist changes - https://phabricator.wikimedia.org/T159188#3063488 (10Mattflaschen-WMF) [03:08:08] 06Collaboration-Team-Triage, 10Thanks: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063495 (10Mattflaschen-WMF) [03:09:45] 06Collaboration-Team-Triage, 10Thanks: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063513 (10Mattflaschen-WMF) [03:12:15] 06Collaboration-Team-Triage, 10Thanks: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063516 (10Mattflaschen-WMF) [03:30:14] 06Collaboration-Team-Triage: RC page: Properly truncate comments for new pages creation - https://phabricator.wikimedia.org/T158725#3063534 (10Mattflaschen-WMF) Per triage and follow-up, for the "Cut in the middle of the word without any indication to the user", the RecentChanges page is not doing anything. It... [03:32:18] 06Collaboration-Team-Triage: RC page: Properly truncate comments for new pages creation - https://phabricator.wikimedia.org/T158725#3063536 (10Mattflaschen-WMF) [03:37:59] 06Collaboration-Team-Triage: RC page: Very long words cause horizontal scrolling - https://phabricator.wikimedia.org/T158725#3063538 (10Mattflaschen-WMF) [03:39:32] 06Collaboration-Team-Triage: RC page: Very long words cause horizontal scrolling - https://phabricator.wikimedia.org/T158725#3045328 (10Mattflaschen-WMF) Also, I verified there is two-line limit. [03:39:55] 06Collaboration-Team-Triage, 10MediaWiki-Recent-changes: RC page: Very long words cause horizontal scrolling - https://phabricator.wikimedia.org/T158725#3063544 (10Mattflaschen-WMF) [04:10:53] 06Collaboration-Team-Triage, 10Thanks: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063495 (10Legoktm) I was a bit scared when I saw the bug title but the proposed change seems reasonable to me. [04:25:17] 06Collaboration-Team-Triage, 10WikiLove, 10Possible-Tech-Projects, 10UI-Standardization: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#3063572 (10Sumit) If this is still not done, can we have this as one of the microtasks for current GSoC, Outreachy, RGSoC internship... [04:28:02] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3063575 (10dchen) Assuming that for option A... [06:19:58] 06Collaboration-Team-Triage, 10Thanks: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063679 (10jmatazzoni) I think that wording is less open to misinterpretation than what exists now, but not bulletproof. What if the confirmation said: All thanks are public. Send thank... [08:22:59] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3063759 (10Pginer-WMF) >>! In T116417#306300... [08:37:52] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3063772 (10Trizek-WMF) Message left on ca.wp. [08:43:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: The Filter Search Bar - adjustments to RC page layout - https://phabricator.wikimedia.org/T158018#3023629 (10Pginer-WMF) #2 does not seem to work well in beta: - If you are at the very top of the page it scrolls down... [08:44:54] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3063776 (10Toniher) Dear all, if still possible I would also request Flow to be activated in newcomers user talk pages,... [09:18:49] 06Collaboration-Team-Triage, 10Notifications, 07Regression: User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3063878 (10Aklapper) [10:40:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3064033 (10Trizek-WMF) Following T... [11:54:15] (03PS2) 10Esanders: Fix padding of large inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339947 [11:58:02] (03PS1) 10Esanders: Load mw core extensions through new module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340493 [11:58:09] (03PS3) 10WMDE-Fisch: Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) [13:31:00] 06Collaboration-Team-Triage, 10Notifications, 10ArticlePlaceholder, 10Wikidata, 07TestMe: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#3064332 (10Aklapper) 05Open>03Resolved a:03Aklapper All patches merged; no reply to last comment. Assuming thi... [13:53:55] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Browser-Support-Apple-Safari, 13Patch-For-Review: The messages panel cannot be closed anymore on iOS - https://phabricator.wikimedia.org/T113881#3064387 (10Aklapper) Looks like this task... [14:35:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3054091 (10SBisson) The highlighting of the group was not caused... [14:41:34] 06Collaboration-Team-Triage, 10WikiLove, 10Possible-Tech-Projects, 10UI-Standardization: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#3064506 (10TheDJ) @Sumit the task is too small for GSoC, but suitable for smaller programs. [14:55:38] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3064545 (10Trizek-WMF) >>! In T159047#3063776, @Toniher wrote: > Dear all, if still possible I would also request Flow... [15:05:56] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3064566 (10Toniher) Thanks @Trizek-WMF . I'll open another task. So far the discussion was for new users... [15:18:36] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enabling Flow in cawiki 'Viquiprojecte Discussió' namespace - https://phabricator.wikimedia.org/T159047#3064585 (10Trizek-WMF) >>! In T159047#3064566, @Toniher wrote: > Thanks @Trizek-WMF . I'll open another task. Thanks... [15:52:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3064660 (10SBisson) a:03SBisson [16:00:21] (03CR) 10Etonkovidova: [C: 031] Update tests to Selenium 3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340123 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [16:18:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3064722 (10SBisson) > Existing ORES beta users will automatically be opted in to the "New filters" beta. What ab... [16:29:30] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Dots in the Highlight menu are oval - https://phabricator.wikimedia.org/T159341#3064770 (10Trizek-WMF) [16:31:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Dots in the Highlight menu are oval - https://phabricator.wikimedia.org/T159341#3064770 (10jmatazzoni) I'm not seeing this. What system /browser etc. was this screenshot taken on? [16:39:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: label the RC Filter area - https://phabricator.wikimedia.org/T159345#3064846 (10jmatazzoni) [16:42:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Dots in the Highlight menu are oval - https://phabricator.wikimedia.org/T159341#3064871 (10Trizek-WMF) Chromium 55.0.2883.87, running on Ubuntu 16.04 (64-bit). [16:55:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: label the RC Filter area - https://phabricator.wikimedia.org/T159345#3064898 (10Pginer-WMF) Would it be possible to detail a bit more in the ticket description the problem to solve and what we know about it,... [17:03:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Wikimedia-Site-requests: Maintenance script run to convert Flow boards to Wikitext prior to remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T156113#3064933 (10MarcoAurelio) 05Open>03Resolved All Flow boards (2) were conve... [17:03:40] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3064935 (10MarcoAurelio) [17:15:21] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3064955 (10MarcoAurelio) As @MZMcBride said, I don't think there are technical reasons for not doing this. The English Wikipedia... [17:26:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#3064990 (10Etonkovidova) @jmatazzoni Thx! Especially when a phab task is big... [17:31:43] mooeypoo: thx for comments on https://phabricator.wikimedia.org/T149452! [17:32:22] mooeypoo:Now, in https://phabricator.wikimedia.org/T149435 only one spec is not done - marked in the ticket text itself with exclamation point [17:38:08] etonkovidova, gotcha, adding that to my list [17:38:35] mooeypoo: many many thanks :) [17:38:48] etonkovidova, I can add that, but it won't really do anything (won't add on enter) until we fix to menu [17:38:55] so it'll be half the behavior [17:40:31] mooeypoo: fine with me - in fact, even if we put it entirely on hold is fine. as long as everybody agrees with it:)) [17:40:51] * mooeypoo nods [17:41:07] I actually have an idea on how to implement adding-on-enter without the menu yet, but I'm not sure RoanKattouw would like it [17:41:42] Well you do already have selection tracking... so it might not be as much additional work? [17:41:44] eh I'm getting "unknown class Wikimedia\Timestamp\ConvertibleTimestamp" [17:41:49] after pulling master [17:41:51] the hell? [17:42:13] RoanKattouw, it's not at all - it will just semi-bypass the menu behavior [17:42:17] but yeah i can do that for now at least [17:42:24] Then we'll only be missing arrow behavior in the menu [17:42:28] mooeypoo: composer update [17:42:34] I did that.... [17:42:48] oh, bah, I did 'composer install' instad of update [17:42:50] pff [17:48:01] etonkovidova, font-size for filter names is up for review. [17:48:41] mooeypoo: hurray! [17:48:55] I lowered it 0.05em [17:48:56] :P [17:49:07] (but now it's 16.1px rather than 16.8px [17:49:21] if I decreased by a full 0.1em, it was 15.8px [18:04:06] npm install but composer update :) [18:10:19] (03CR) 10Catrope: [C: 032] Load mw core extensions through new module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340493 (owner: 10Esanders) [18:20:18] (03Merged) 10jenkins-bot: Load mw core extensions through new module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340493 (owner: 10Esanders) [18:20:32] (03CR) 10jenkins-bot: Load mw core extensions through new module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340493 (owner: 10Esanders) [18:33:12] (03PS1) 10Esanders: Load VE plugin modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340541 [18:35:40] (03CR) 10Addshore: [C: 032] Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) (owner: 10WMDE-Fisch) [18:35:56] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/340543/ [18:36:58] (03CR) 10Catrope: [C: 032] Load VE plugin modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340541 (owner: 10Esanders) [18:41:43] RoanKattouw, I just realized something... what was the other page you said rcfilters works in out of the box ? [18:41:50] RecentChangesLinked [18:41:57] AKA Related Changes [18:42:30] because https://gerrit.wikimedia.org/r/#/c/340451/ may change that [18:42:34] we'll need to add the container there [18:42:59] Ah yes [18:43:12] Unless RelatedChanges is a subclass of RecentChanges, which it might well be [18:44:04] * mooeypoo didn't check [18:44:06] just thought of it [18:44:17] I'm working on fixing the ajaxifying patch but I can try and test it later [18:45:51] (03PS1) 10Esanders: Make dropdown button links full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340546 [18:48:50] (03Merged) 10jenkins-bot: Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) (owner: 10WMDE-Fisch) [18:48:52] (03Merged) 10jenkins-bot: Load VE plugin modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340541 (owner: 10Esanders) [18:49:12] (03CR) 10jenkins-bot: Load VE plugin modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340541 (owner: 10Esanders) [18:53:46] (03CR) 10jenkins-bot: Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) (owner: 10WMDE-Fisch) [18:56:48] RoanKattouw, it is. [19:02:02] 06Collaboration-Team-Triage, 10Notifications, 07Regression, 06Stewards-and-global-tools (Temporary-UserRights): User group membership notification about changed expiration date should be more specific - https://phabricator.wikimedia.org/T159301#3065364 (10Mattflaschen-WMF) [19:04:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Wikimedia-Site-requests: Maintenance script run to convert Flow boards to Wikitext prior to remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T156113#3065373 (10Mattflaschen-WMF) One was converted, the other was moved to MediaW... [19:09:50] meh. Roan, how do I unwrap a node? If I have foo and I took the entire span into $element ... how do I get rid of in there? I can't seem to find a method to safely get rid of that without assuming it's the only thing in there [19:10:16] (though in my case i guess it is a safe assumption, so I can just clear that $element and re-append .text() [19:10:21] ) [19:10:27] $strong.replaceWith( $strong.contents() ); [19:10:40] ah! replaceWith! of course [19:10:41] Also where are you doing this and why? [19:11:02] because when you ajaxify the "show me 10 | 20 | 50 days" then whatever you click is bold [19:11:15] and while *I* will do it with a class, the *back end* sends it wrapped with [19:11:34] so I need to first get rid of the and then toggle the class [19:16:06] Ah, I see [19:19:53] I would change that in the back end, but that seems to be a bit dangerous [19:19:59] so I'll just work on that in the front end instead [19:25:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Dots in the Highlight menu are oval - https://phabricator.wikimedia.org/T159341#3065435 (10Aklapper) (if I wanted to reproduce, where could I try? I failed to find a link to some test instance looking at https://www.mediawiki.org/wiki/Edit_Review... [19:26:44] 06Collaboration-Team-Triage, 10Flow: Insert a reference from the VE References tooltip on Flow is not possible on Beta labs - https://phabricator.wikimedia.org/T159364#3065440 (10Trizek-WMF) [19:28:03] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: Insert a reference from the VE References tooltip on Flow is not possible on Beta labs - https://phabricator.wikimedia.org/T159364#3065455 (10Catrope) [19:30:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: label the RC Filter area - https://phabricator.wikimedia.org/T159345#3064846 (10jmatazzoni) @Pginer-WMF asks: >Would it be possible to detail a bit more in the ticket description the problem to solve Absol... [19:34:44] stephanebisson, RoanKattouw the plot thickens with ajaxification. There are "show/hide" links that we haven't implemented yet -- those would need to *toggle* both the message and their data value. [19:34:56] And the problem is that i don't just have a standard "show" message [19:35:02] I have a message *per* each of those [19:35:15] Ahm, surely the show/hide message is the same for all of them? [19:35:18] (ores-damaging-filter-hide)) [19:35:23] (rcshowhidepatr-hide) [19:35:27] Really? [19:35:28] ^ different damn messages [19:35:29] yes [19:35:30] really [19:35:33] * mooeypoo grunts [19:35:43] I'll have to pass those ALSO in the data-* attributes [19:35:47] the prefixes, at least [19:35:50] Hah, you're right, wtf [19:35:53] they're all xxxxxx-show and xxxxx-hide [19:36:12] The prefixes are not enough, you can't load arbitrary i18n messages on the client [19:36:18] You could pass in the alternate link label though [19:36:36] ah, crap. Right, I'll have to pass data-label={ show: TEXT, hide: TEXT } [19:36:39] or something like that [19:36:40] mooeypoo: there's also the idea of challenge the state of that form on popstate. That's the main reason why I didn't want to ajaxify this form in the first place. [19:36:53] the challenge of restoring* [19:37:00] restoring? [19:37:04] why would we res---oh [19:37:06] OH [19:37:11] ...goddamnit. [19:37:20] ok, well [19:37:27] RoanKattouw, how far do we go, then, with this? [19:37:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 07Regression: [regression wmf.12] Edit area in wikitext has extra blue line when focused - https://phabricator.wikimedia.org/T158238#3065476 (10Etonkovidova) Re-checked in .wmf14 - the issue is gone. Closing the bug as fixed. [19:37:38] Maybe don't bother with the show/hide links? [19:37:42] I mean, not ajaxifying it at all means you lose all your filters when you click eithre of those [19:37:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3065477 (10jmatazzoni) [19:38:03] I'll hvae to exclude them on purpose [19:38:03] Yeah but we're going to pull them into the dropdown, right? [19:38:09] Hopefully? [19:38:16] I mean, not all of them [19:38:23] You're talking about the Wikidata and ORES ones, right? Which other ones are there? [19:38:23] not immediately, for sure [19:38:29] RoanKattouw, mooeypoo, I can pass those and the messages in my backend refactoring. [19:38:30] Patrol thingie [19:38:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 07Regression: [regression wmf.12] Edit area in wikitext has extra blue line when focused - https://phabricator.wikimedia.org/T158238#3065494 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Low [19:38:40] Patrol is part of Matt's patch already [19:38:46] The root is already part of the unified structure. [19:38:51] showHidePrefix [19:38:55] Right [19:38:57] matt_flaschen: That would work [19:38:58] RoanKattouw, well, I mean, theoretically we can't anticipate these because they come from extensions [19:39:05] so what do we do when we have something we don't recognize [19:39:12] But in that case I suggest we wait with AJAXifying show/hide links until after the backend lands, if at all [19:39:31] this ajaxification method solves fo rthat -- but it is starting to get elaborate. I'm actually less concerned about the show/hide toggle and more concerned with stephanebisson's point about popstate [19:39:46] when we change the URL, we need to propagate that change to the form [19:39:55] For actual form fields that's not so hard [19:39:56] that would be a huge deal [19:39:59] For the links it's harder [19:40:24] Even just to recognize what out of the parameters from the URL are relevant [19:40:33] If we made the links into dropdowns it might be easier, Pau suggested that but Joe didn't want to do it [19:40:39] go over all params, if you find them in the form, fix their state. We can do that, but it's meh. [19:40:41] Stupid question. Since you are getting the result set from the normal HTTP response (just extracting the relevant elevant), why can't you also extract the chrome? [19:40:46] relevant element [19:40:55] Ha not a bad idea [19:41:05] what do you mean? [19:41:19] We currently AJAX by refetching an entire Special:RC page [19:41:20] also, what do yo umean dropdown? The issue isn't the clickable option links [19:41:23] And only using the changeslist part of it [19:41:23] mooeypoo, just like you're extracting the big result set from the AJAX GET request, also extract the UI elements. [19:41:26] the issue is the toggled show/hide [19:41:29] But we could extract the fieldset as well [19:41:38] meh, I guess [19:41:41] but... ew [19:41:49] Yes, ew [19:42:01] I would actually go with what we are doing now [19:42:09] You're already downloading it anyway, I don't really see the ew. [19:42:09] the toggle isn't that horrible, I'll just add the messages through the back end [19:42:11] But once the backend lands 1) we'll have fewer if any show/hide links, and 2) Matt will be able to ship you the exact messages you need [19:42:29] as data attributes. And the popstate is just an annoying process, but we can get it to work fairly seamlessly [19:42:33] it'll just all be hacky [19:42:51] but I think less hacky than pulling the entire fieldset with the ajax request? [19:43:07] eh, I guess [19:43:16] I don't know, it feels super ew'ish. [19:43:24] Not that I'm against ews. [19:43:35] For the record. I have ew'ish friends and all. [19:44:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - filter search area (FF only): lower border is missing when the filter drop down is displayed - https://phabricator.wikimedia.org/T158931#3065528 (10Etonkovidova) Re-checked in betalabs - the drop-down are has been moved down, so the lower bo... [19:44:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - filter search area (FF only): lower border is missing when the filter drop down is displayed - https://phabricator.wikimedia.org/T158931#3065529 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Lowest [19:44:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369#3065531 (10Mattflaschen-WMF) [19:44:57] Anyways. So.. stephanebisson matt_flaschen RoanKattouw what do you want to do... [19:45:18] Should I abandon this patch, and instead refill the form when we do the content results? [19:45:35] That doesn't mean you abandon this patch, right? [19:45:35] RoanKattouw, ok, potential issue with that: [19:45:36] mooeypoo, add any more info about the old-style UI filters you need to T159369. [19:45:36] T159369: Send data structure and messages for filters used in unstructured UI - https://phabricator.wikimedia.org/T159369 [19:45:43] You still need to know how to change the URL when a link is clickde [19:45:46] Close that if you decide to do it the ew way and don't need anything. [19:45:49] Which is most of what your patch does [19:46:06] say the user wrote something in the namespace but didn't click "show" yet... first, they click "500 items" ---> their text in the namespace input will be gone [19:46:35] Good point [19:46:45] Yeah if you wanna do it manually, do it manually' [19:46:47] I dunno, this is ewish. [19:46:55] mooeypoo: I think replacing the form is easy in the short term. We should be focusing on a solution we like (modernizing all those elements) instead of patching the old stuff. [19:46:56] Or crib the links from the AJAX response but not the form fields? [19:46:58] I am worried about replacing the whole fieldset node like that [19:47:00] Form fields are easy to do anyway [19:47:29] stephanebisson, good point, but I don't know if what's missing for this patch is going to take that much effort [19:47:40] I mean... we have the toggle-show/hide thing and the popstate thing [19:47:48] both are annoying, for sure,but not THAT horrendous...? [19:47:58] Don't forget days/limit which bold the active one [19:48:04] I just finished the bolding [19:48:11] I noticed show/hide because of it [19:48:18] I think it's probably easier to get the links out of the AJAX result than to manually update them [19:48:19] bolding works [19:48:25] But manually updating form fields should be easier [19:48:52] Anyway in the spirit of what stephanebisson said, let's do the easiest thing that makes it work [19:49:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist: [regression betalabs] When adding/removing a page from watchlist the popup displays some code - https://phabricator.wikimedia.org/T158273#3065557 (10Etonkovidova) Checked (just in case) in .wmf14 testwiki - the issue is not pres... [19:49:59] RoanKattouw, stephanebisson matt_flaschen I just pushed this: https://gerrit.wikimedia.org/r/#/c/340270/4 [19:50:04] ^ this works for 90% of things [19:50:33] The remaining 10% is crappy stuff, but yeah [19:50:43] so... abandon this? get the form from ajax? [19:52:12] also, do we update the fieldset every time results are changed, or separately? [19:52:17] because it seems like it would be separate [19:52:27] My suggestion would be to get the links from AJAX but not the form [19:52:37] there's no need to update the fieldset if we juts changed filters that are implemented in the filter list [19:52:44] Because form fields are stateful and replacing them is annoying, but links don't have that issue and are much more annoying to update [19:52:49] so we'll only ask for that page again when we literally interact with that form [19:53:13] Yeah you can do it that way too, only update the links in response to a link click [19:53:40] eh. [19:54:27] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 4 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2848049 (10Janezdrilc) Adding a new link to an archived proposal: [[ https://en.wikipedia.org/wiki... [19:54:39] ok so RoanKattouw do I only do this to show/hide links? [19:54:51] because the current thing is already implemented and works, the list of limit/days [19:54:59] and groupings etc. The issue is the show/hide links. [19:55:22] I want to try and minimize how much we depend on async calls for updating this view [19:56:04] Hmm maybe [19:56:07] I have no strong opinions there [19:56:23] What you're saying sounds sensible, unless stephanebisson / matt_flaschen object [19:57:42] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065583 (10jmatazzoni) Re. the options above... [19:57:50] * mooeypoo is implementing this way [19:57:55] if it starts getting convoluted, I'll stop [19:58:05] I think this might be the most straight forward way *while* taking advantage of what we already have [19:59:59] btw stephanebisson I think we should use the promise prioritizer from echo here [20:00:05] (03PS1) 10Esanders: Use different technique for sidebar full height background [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558 [20:00:38] especially since we're using $.ajax, I think that's abortable [20:00:44] RoanKattouw, isn't it? [20:02:23] Yes, $.ajax is abortable [20:02:41] Stephane put in some code to ensure that old requests' responses are ignored [20:07:25] 06Collaboration-Team-Triage, 10Flow: flow bad sql - https://phabricator.wikimedia.org/T159371#3065606 (10Matanya) [20:07:47] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: flow bad sql - https://phabricator.wikimedia.org/T159371#3065619 (10Matanya) [20:07:50] RoanKattouw / mooeypoo ^ [20:08:11] Yeah, that's a dupe of an old bug [20:08:54] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: flow bad sql - https://phabricator.wikimedia.org/T159371#3065621 (10Catrope) [20:08:56] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3065624 (10Catrope) [20:09:06] We don't know why it happens :( because the code around that is quite mysterious [20:09:29] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065627 (10Matanya) [20:10:09] RoanKattouw: this one too ^ ? [20:14:03] Yes, that one's also old [20:14:14] and not known to be related [20:14:19] sorry for wasting your time [20:14:32] Oh but wait [20:14:36] That one was believed to be fixed: https://phabricator.wikimedia.org/T73489 [20:14:40] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Provide an easy to use HTML mail system - https://phabricator.wikimedia.org/T156231#3065699 (10srishakatux) @jmatazzoni would you or someone from #collaboration-team-triage be willing to mentor this project for [[... [20:14:45] Clearly it isn't [20:15:30] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065627 (10Catrope) We thought we had fixed this over at {T73489}, but clearly we haven't. [20:25:10] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065627 (10demon) >>! In T159372#3065704, @Catrope wrote: > We thought we had fixed this over at {T73489}, but clearly we haven't. It s... [20:27:30] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065763 (10demon) [20:28:40] matt_flaschen, RoanKattouw: any idea why 'rcenhancedfilters' doesn't work as the name of a beta preference (the beta feature doesn't show up) but literally everything else works? I even removed all traces of it in `user_property` but it doesn't change anything. [20:30:48] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065766 (10demon) p:05Triage>03Unbreak! [20:33:48] nevermind, $wgHiddenPrefs [20:38:12] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065769 (10Jdforrester-WMF) OK, so, to sum u... [20:38:30] ha [20:40:15] 06Collaboration-Team-Triage, 10Flow, 06WMF-Design, 07Design: Make source/wikitext icon consistent - https://phabricator.wikimedia.org/T97451#1242676 (10Jdforrester-WMF) This task as written in the title has been Resolved since September 2015; could it be re-worded to focus on… I'm not actually sure what's... [20:43:32] Why did we make [20:43:32] rcenhancedfilters [20:43:41] a hidden preference again? [20:44:27] cause if we don't, we can configure the beta feature with it and boom! [20:47:43] 06Collaboration-Team-Triage, 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3065802 (10matmarex) [20:48:54] 06Collaboration-Team-Triage, 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3065818 (10matmarex) The reason for this seems to be simply because Flow doesn't load ve.dm.MWExtensionNode. I don't know if that's a bug, or intentional to save bandwidth or... [20:50:34] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor - https://phabricator.wikimedia.org/T159230#3065822 (10matmarex) [20:50:38] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki: Can't edit preformatted text using visual editor - https://phabricator.wikimedia.org/T159230#3065827 (10matmarex) After fixing T159231 in VE, I found out that it's affected by this problem too. So this is not Flow-specific. The... [20:55:42] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065853 (10Dvorapa) @Jdforrester-WMF One lit... [20:57:25] matt_flaschen, RoanKattouw: where does wgHiddenPrefs hide preferences? The only thing I can see is that it returns the default value... unless to tell it not to. [20:57:42] Not sure, maybe in SpecialPreferences.php somewhere? [20:57:54] stephanebisson: The hidden pref is only temporary so that we could dark-deploy the code [20:58:15] wgHiddenPrefs are more like 'disabled', really [20:58:21] I can't see it shown anywhere (wgHiddenPrefs or not) [20:58:35] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065859 (10Jdforrester-WMF) >>! In T116417#3... [20:58:47] you can change the default value for everyone (with wgDefaultUserOptions), but users can't change their preference. [20:59:46] RoanKattouw: are we ok with 1 preference, linked to the beta feature, and removed from wgHiddenPrefs when the time is right? [20:59:54] (if you want a preference that is editable by users, but hidden, register it with the GetPreferences hook with 'type' => 'api') [21:00:18] stephanebisson: If that Magically works with BetaFeatures, then yes, that would be ideal [21:03:36] (03PS1) 10Catrope: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340575 (https://phabricator.wikimedia.org/T159372) [21:04:35] (03CR) 10Chad: [C: 032] Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340575 (https://phabricator.wikimedia.org/T159372) (owner: 10Catrope) [21:09:19] (03CR) 10Catrope: [C: 04-1] "This breaks the display when the sidebar is collapsed, see http://imgur.com/a/5gTQ6" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558 (owner: 10Esanders) [21:13:16] stephanebisson, it also hides it from Special:Preferences. But probably it's not showing in Special:Preferences regardless because I didn't add it. [21:13:34] But wgHiddenPrefs can also be used for any preference (including those that display in Special:Preferences by default), e.g. in LocalSettings.php. [21:15:02] matt_flaschen: since it's not configured to be shown on Special:Preferences, can we remove it from wgHiddenPrefs? If so, we can deploy the beta feature to betalab soon. [21:17:04] RoanKattouw, so I ran into a kink in fetching the fieldset [21:17:09] you're going to LOVE this [21:17:10] LOVE IT. [21:17:12] Ready? [21:17:15] Sure [21:17:40] Say I click "show XXX". It sends a request to the server. I should replace it to "hide XXX" regardless of my results. Right? [21:17:47] .... guess what happens when there are no results, though. [21:17:48] (03Merged) 10jenkins-bot: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340575 (https://phabricator.wikimedia.org/T159372) (owner: 10Catrope) [21:17:49] I GET 404 [21:17:53] PROMISE FAILS [21:18:00] "NO_RESULTS" IS RETURNED [21:18:05] I HATE RECENTCHANGES.PHP [21:18:14] (I can fix it by non-failing the request, but seriously, wtf) [21:18:40] "NO_RESULTS" is stephanebisson's invention [21:19:06] yes but I don't have the content of the page in the error anyways [21:19:10] No reason you can't extract the body still, is there? [21:19:17] I am trying to see where I get it [21:19:20] there's no result [21:19:21] Or does jQuery not provide error bodies? [21:19:34] * mooeypoo checks [21:21:19] yup, I'm getting nothin [21:21:19] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 10Developer-Wishlist (2017): Provide an easy to use HTML mail system - https://phabricator.wikimedia.org/T156231#3065930 (10Mattflaschen-WMF) The scope for this is unclear. See my above comment. [21:21:20] the content of the page is discarded in the controller [21:21:36] I'm editing the controller [21:21:44] the $.ajax() failure gives me no body [21:21:51] wait, you're saying the fail handler doesn't give you access to the body? [21:21:53] (03CR) 10jenkins-bot: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340575 (https://phabricator.wikimedia.org/T159372) (owner: 10Catrope) [21:21:56] (03PS1) 10Chad: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340588 (https://phabricator.wikimedia.org/T159372) [21:21:57] not that I can see, no [21:22:01] (03CR) 10Chad: [C: 032] Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340588 (https://phabricator.wikimedia.org/T159372) (owner: 10Chad) [21:22:18] I added this to the $.ajax( uri.toString(), { contentType: 'html' } ) failure -- console.log( Array.prototype.slice.call(arguments) ); [21:22:38] Hmm, there is a responseText [21:22:39] and I get an array [ Promise Object, 'error', 'not found' ] [21:22:48] property on the first arg [21:22:53] 06Collaboration-Team-Triage, 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3065802 (10Mattflaschen-WMF) Bug [21:22:58] I outputted all args [21:23:01] But jQuery doesn't seem to parse the result when the code is 2xx [21:23:02] ^ that's what I get [21:23:23] p.error(function(obj) { console.log(obj.responseText); }); [21:23:28] (where p = $.ajax(...); ) [21:23:31] That gives me the HTML [21:23:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3065934 (10Mattflaschen-WMF) [21:24:47] oh responseText inside the object [21:24:48] hm [21:24:59] This is annoying though [21:25:08] Looking at the docs to see if there's a better way [21:26:09] I'm working on a workaround on this [21:26:13] but it's not pretty [21:26:14] I'm close [21:26:25] edited some of stephanebisson's beautiful controller methods, though [21:26:44] stephanebisson, I apologize in advance for defiling your ajax with ew. [21:27:00] stephanebisson, yes, I think so. I'm not sure if it will then be editable by API (MatmaRex?) , but probably not a big deal either way. [21:27:24] Hmm it seems like there isn't really a better way other than $.parseHTML( obj.responseText ); [21:29:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340598 (owner: 10L10n-bot) [21:29:14] Yes, it will be editable by API in that case, which is why I didn't want to do it that way, at least not for now [21:31:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/340592 (owner: 10L10n-bot) [21:36:30] matt_flaschen: stephanebisson: it won't be editable via API until you register it with the GetPreferences hook [21:36:47] (i think) [21:37:33] (03Merged) 10jenkins-bot: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340588 (https://phabricator.wikimedia.org/T159372) (owner: 10Chad) [21:40:24] (03CR) 10jenkins-bot: Log more info for unserialize failures, and don't treat them as errors [extensions/Echo] (wmf/1.29.0-wmf.14) - 10https://gerrit.wikimedia.org/r/340588 (https://phabricator.wikimedia.org/T159372) (owner: 10Chad) [21:45:41] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065992 (10Dvorapa) @Jdforrester-WMF Fine:-) [22:12:46] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3066058 (10Catrope) >>! In T116417#3065769,... [22:23:36] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki: Can't edit preformatted text using visual editor - https://phabricator.wikimedia.org/T159230#3066067 (10matmarex) OK, actually, this is quite a mess. Let's handle it on T159231, I'll copy the relevant parts there. For Flow: thi... [22:23:48] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3066068 (10matmarex) [22:24:06] 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor in Flow posts - https://phabricator.wikimedia.org/T159230#3061184 (10matmarex) [22:24:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3066074 (10matmarex) [22:29:37] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3066087 (10Nicholas.tsg) Testing on Samsung Galaxy Tab 4 SM‑T230NU (Android 4.4.2) and Maxt... [22:40:53] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3066110 (10Dvorapa) 05Open>03Resolved a:03Dvorapa I tested it today too and found it... [22:41:17] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3066113 (10Dvorapa) a:05Dvorapa>03None [22:49:31] RoanKattouw: who disabled RC filters on beta? Did I miss something again? [22:53:19] huh? [22:53:58] mooey|lunch: I think one of your recently merged commits may have broken something [22:55:09] etonkovidova: Good catch, rcfilters is broken, the filter widget disappeared [22:55:32] RoanKattouw: ha! [22:56:10] Ha! I see it [22:56:16] She forgot to ignore hiddenPrefs [22:56:51] I'll fix it [23:00:59] mooey|lunch: etonkovidova: https://gerrit.wikimedia.org/r/#/c/340654/ [23:01:24] RoanKattouw: thx [23:03:10] OK and with that heart attack behind me, I'm going to head over to James's house [23:09:15] (03PS2) 10Esanders: Use different technique for sidebar full height background [extensions/Flow] - 10https://gerrit.wikimedia.org/r/340558