[00:21:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3051817 (10jmatazzoni) [00:22:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2761043 (10jmatazzoni) I updated the Tooltip and Results Area Messages above to put Wikidata Edits back in as somethi... [00:28:39] matt_flaschen: Yes [00:30:28] Currently all wikis that have ORES at all have both the damaging and goodfaith models. I rewrote the config a few months ago with that assumption in mind in order to shorten it, thinking that if it ever changes we'll deal with it hten [00:30:43] Realistically we're quite a ways away from having any other setting, I think [00:32:46] I didn't read it closely enough, I assumed some wikis had it with just reverted or something. [00:33:21] In terms of them actually having supported models, that is true, but the reverted model is not populated into the DB anywhere because there's no UI code that exposes it [00:33:46] As you expected, some queries are super-slow, e.g. https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&goodfaith=bad&hidelog=1 [00:34:44] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3051858 (10MZMcBride) I strongly agree with MarcoAurelio. Installing Flow on Meta-Wiki never had consensus and there's now a stro... [00:41:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3051864 (10jmatazzoni) [00:43:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2750783 (10jmatazzoni) I updated the Conflict Display States section to... [00:43:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog, 13Patch-For-Review: Include goodfaith model information in ORES review tool - https://phabricator.wikimedia.org/T137966#3051868 (10Catrope) 05Open>03Resolved Closing this sin... [00:43:56] RoanKattouw: Also https://gerrit.wikimedia.org/r/#/c/339102/ whilst you're at it. :-) [00:46:19] mooeypoo: Could you answer my question on https://gerrit.wikimedia.org/r/339479 ? [00:47:26] RoanKattouw: [00:47:31] https://www.irccloud.com/pastebin/CKyKAAJX/ [00:51:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RC filters - filter search area (FF only): lower border is missing when the filter drop down is displayed - https://phabricator.wikimedia.org/T158931#3051873 (10Etonkovidova) [00:58:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Turn on ORES good faith test model in production for all supported wikis targeted for RC Page release - https://phabricator.wikimedia.org/T158441#3051902 (10jmatazz... [01:02:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Turn on ORES good faith test model in production for all supported wikis targeted for RC Page release - https://phabricator.wikimedia.org/T158441#3051916 (10Catrope... [01:04:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Turn on ORES good faith test model in production for all supported wikis targeted for RC Page release - https://phabricator.wikimedia.org/T158441#3051921 (10Catrope... [01:07:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: RC filters: filter selector drop down is misplaced in RTL - https://phabricator.wikimedia.org/T157189#3051923 (10Catrope) With the most recent OOUI release, this is now fixed in master. [01:07:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters UI: Use mixins and variables in Less files - https://phabricator.wikimedia.org/T156164#3051925 (10Mooeypoo) @Catrope so, this is half done as in we now have mixins and variables -- the... [01:18:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC search filter bar double click - suggestions are not displayed - https://phabricator.wikimedia.org/T156214#3051929 (10Catrope) I found out that we were passing `$autoCloseIgnore` incorrectly and Moriel cleaned tha... [01:44:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3052022 (10Volker_... [04:51:50] 06Collaboration-Team-Triage, 10Notifications, 07Technical-Debt: EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3052246 (10Krinkle) [04:51:53] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 2 others: Don't use wfDiff() - https://phabricator.wikimedia.org/T93625#3052245 (10Krinkle) 05Open>03Resolved [04:56:28] 06Collaboration-Team-Triage, 10Notifications, 07Technical-Debt: EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3052248 (10Krinkle) {a1cb603bb34a52637a3996576f133f8d2719e99f} landed 2 weeks ago. {T93625} is closed. However, it seems EchoDiscussionParserTest run time has not chan... [09:31:42] (03PS7) 10WMDE-Fisch: DiscussionParserTest only create users when needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333673 (https://phabricator.wikimedia.org/T158120) (owner: 10Addshore) [09:36:48] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Technical-Debt: EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3052532 (10WMDE-Fisch) A while ago @Addshore slightly improved the test setup there to speed them up. Just needs reviews. [10:10:46] (03PS8) 10WMDE-Fisch: DiscussionParserTest only create users when needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333673 (https://phabricator.wikimedia.org/T158120) (owner: 10Addshore) [10:32:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3052612 (10Pginer-... [10:51:55] 06Collaboration-Team-Triage, 10Thanks, 10MediaWiki-History-or-Diffs, 10MediaWiki-Interface: Changing alignment during thanking process and interplay of rollback link - https://phabricator.wikimedia.org/T158918#3052650 (10Aklapper) [10:57:30] (03PS1) 10WMDE-Fisch: Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 [10:58:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3052663 (10Pginer-... [11:11:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3052686 (10Pginer-... [11:15:36] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 2 others: Don't use wfDiff() - https://phabricator.wikimedia.org/T93625#3052691 (10Legoktm) [11:15:47] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 2 others: Don't use wfDiff() in Echo - https://phabricator.wikimedia.org/T93625#1142240 (10Legoktm) [11:17:54] (03PS2) 10WMDE-Fisch: Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 (https://phabricator.wikimedia.org/T93625) [11:19:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3052711 (10Pginer-... [11:32:41] (03PS3) 10Legoktm: Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 (https://phabricator.wikimedia.org/T93625) (owner: 10WMDE-Fisch) [11:32:50] (03CR) 10Legoktm: [C: 032] Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 (https://phabricator.wikimedia.org/T93625) (owner: 10WMDE-Fisch) [11:40:22] (03CR) 10Esanders: "This patch should be uncontroversial. The debate on the bug is about Ieefb2fe5666f." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338794 (https://phabricator.wikimedia.org/T116573) (owner: 10Esanders) [11:45:43] (03Merged) 10jenkins-bot: Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 (https://phabricator.wikimedia.org/T93625) (owner: 10WMDE-Fisch) [11:49:48] (03CR) 10jenkins-bot: Remove test for internal diff engine acceptance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339622 (https://phabricator.wikimedia.org/T93625) (owner: 10WMDE-Fisch) [11:50:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes: The filter panel for Recent changes does not adapt well to narrow windows - https://phabricator.wikimedia.org/T158956#3052740 (10Pginer-WMF) [12:04:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3052800 (10Pginer-WMF) >>! In T147054#3051459, @jmatazzoni wrote: > Make sens... [12:31:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3052822 (10Pginer-WMF) >>! In T150959#3051057, @jmatazzoni wrote: >Wo... [12:34:00] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 2 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3052823 (10Esanders) I think we should go wi... [13:03:37] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DiscussionParserTest only create users when needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333673 (https://phabricator.wikimedia.org/T158120) (owner: 10Addshore) [13:05:18] 06Collaboration-Team-Triage, 10Notifications, 10Thanks: Stop bots notification thanks on there edits - https://phabricator.wikimedia.org/T158959#3052885 (10IKhitron) [13:05:43] 06Collaboration-Team-Triage, 10Notifications, 10Thanks: Stop bots notification thanks on their edits - https://phabricator.wikimedia.org/T158959#3052898 (10IKhitron) [13:06:13] 06Collaboration-Team-Triage, 10Notifications, 10Thanks: Stop bots notification thanks on their edits - https://phabricator.wikimedia.org/T158959#3052885 (10IKhitron) [13:17:04] (03Merged) 10jenkins-bot: DiscussionParserTest only create users when needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333673 (https://phabricator.wikimedia.org/T158120) (owner: 10Addshore) [13:18:47] (03CR) 10jenkins-bot: DiscussionParserTest only create users when needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333673 (https://phabricator.wikimedia.org/T158120) (owner: 10Addshore) [13:24:01] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3052921 (10Dvorapa) [13:38:18] 06Collaboration-Team-Triage, 10Notifications: Stop bots notification thanks on their edits - https://phabricator.wikimedia.org/T158959#3052928 (10matej_suchanek) [13:50:02] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 2 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3052963 (10Dvorapa) @Esanders The dropdown c... [13:58:52] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: Page language variants should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T156578#3052990 (10bmansurov) Let's try testing again when logged in. [16:51:56] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 2 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3053323 (10jmatazzoni) @Esanders, sorry, I m... [16:56:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes: The filter panel for Recent changes does not adapt well to narrow windows - https://phabricator.wikimedia.org/T158956#3053330 (10jmatazzoni) @Pginer, what is your purpose here? How narrow... [17:21:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure filter settings for RC Page are bookmarkable - https://phabricator.wikimedia.org/T146076#2649902 (10Etonkovidova) Checked in betalabs - combination of "old filters" settings and new filters can be bookmarke... [17:22:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure filter settings for RC Page are bookmarkable - https://phabricator.wikimedia.org/T146076#3053407 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [19:06:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3053676 (10jmatazzoni) a:05Pginer-WMF>03None [19:08:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3053680 (10jmatazzoni) [19:09:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10jmatazzoni) Thanks Paul. That design works for me. Relievi... [19:43:05] Getting lunch [20:00:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3053755 (10jmatazzoni) @Pginer-WMF wrote: > In terms of attracting users, in... [20:19:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make it so the Help link on the RC page links to beta feature help for beta users - https://phabricator.wikimedia.org/T158819#3053812 (10jmatazzoni) [20:26:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3053816 (10Etonkovidova) (to check later if some other fixes will fix the issue below) An interesting ramificati... [20:31:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Create a delay when opening the RCFilters CapsuleItemWidget "description/conflict" popups - https://phabricator.wikimedia.org/T158993#3053825 (10Mooeypoo) [20:33:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Create a delay when opening the RCFilters CapsuleItemWidget "description/conflict" popups - https://phabricator.wikimedia.org/T158993#3053844 (10Mooeypoo) [20:36:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3053852 (10Mooeypo... [20:54:18] etonk_lunch, when you get back -- do you remember where pau said he put the highlight icon? I can't find it to download it and add it instead of the pencil icon [21:06:18] mooeypoo: https://phabricator.wikimedia.org/T11119 [21:13:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): The Active Filter Display Area - adjustments to RC page layout - https://phabricator.wikimedia.org/T158006#3053999 (10Mooeypo... [21:20:48] (03CR) 10Catrope: [C: 032] Fix adjacent input widget border radii [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338794 (https://phabricator.wikimedia.org/T116573) (owner: 10Esanders) [21:27:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339722 (owner: 10L10n-bot) [21:28:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339725 (owner: 10L10n-bot) [21:29:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters UI: Use mixins and variables in Less files - https://phabricator.wikimedia.org/T156164#3054052 (10Volker_E) @Mooeypoo The most recent update of WikimediaUI Base files is captured in ht... [21:30:00] (03Merged) 10jenkins-bot: Fix adjacent input widget border radii [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338794 (https://phabricator.wikimedia.org/T116573) (owner: 10Esanders) [21:30:19] (03CR) 10jenkins-bot: Fix adjacent input widget border radii [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338794 (https://phabricator.wikimedia.org/T116573) (owner: 10Esanders) [21:34:21] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Technical-Debt, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3054066 (10Krinkle) @WMDE-Fisch @Addshore Very nice :) I'll mark this as resolved! If you want to expl... [21:34:50] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Technical-Debt, and 2 others: EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3054067 (10Krinkle) 05Open>03Resolved p:05Triage>03Normal a:03Addshore [21:41:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): [minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted - https://phabricator.wikimedia.org/T159001#3054091 (10Etonkovidova) [22:38:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3054204 (10jmatazzoni) [22:40:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3054205 (10jmatazzoni) [22:51:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054261 (10jmatazzoni) [22:59:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 13Patch-For-Review: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#3054275 (10Catrope) a:03Catrope [23:01:14] matt_flaschen, meh, help - I was altready on a branch (that I sent to review earlier) and I worked on more fixes... but then I realized it shouldn't be dependent, so I stashed changes (didn't commit of course) and then switched to master, and went 'git stash pop' [23:01:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 13Patch-For-Review: Integrate a feedback page link in Recent Changes Beta filters - https://phabricator.wikimedia.org/T150959#2802634 (10Catrope) {F5825668} [23:01:22] I got collisions -- and I fixed them [23:01:36] matt_flaschen, but how do I resolve the state now? It won't let me commit anything [23:01:48] It won't let me switch branch names, that is [23:01:49] mooeypoo: git add the fixed files [23:01:55] That's it? [23:02:00] Yeah [23:02:15] woot [23:02:29] ok my actual changes are now staged [23:02:30] The universal signal for "I am done resolving conflicts in this file" is "git add " [23:02:32] but i want to change branch name [23:02:37] That's OK, just change it [23:02:37] still git checkout -b branchname ? [23:02:40] Yup [23:02:50] That doesn't care that you have staged changes [23:03:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054296 (10jmatazzoni) a:03Pginer-WMF [23:03:31] * mooeypoo nods [23:03:50] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/339794/ [23:04:00] I wasn't sure what bug this was for [23:04:34] RoanKattouw, also, I could get away with $( window ) but I figured going with "getClosestScrollableContainer" is safer [23:04:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#2753548 (10Etonkovidova) @jmatazzoni Are we ok with t... [23:07:35] Yeah that works [23:07:41] And I verified that that returns window instead of body, as well [23:07:48] mooeypoo: Could you check that my rewording here makes sense: https://gerrit.wikimedia.org/r/#/c/339794/1..2/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js [23:07:49] It should, yeah [23:08:04] RoanKattouw, perfect [23:08:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3054303 (10Etonkovidova) @Mooeypoo, @Pginer-WMF There... [23:08:11] I wasn't sure how to explain it, and "offset" was in my brain [23:10:25] mooeypoo: Well my first response was "document the default", the second "label your units", but then I realized the whole sentence didn't make sense to me :) [23:12:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3054307 (10Catrope) >>! In T149467#3054301, @Etonkovi... [23:12:21] haha [23:12:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054309 (10jmatazzoni) [23:13:03] RoanKattouw, just making sure here, if I go this.aggregate( { click: 'capsuleItemClick' } ); <-- that already emits 'capsuleItemClick' event and I don't need to then go this.connect(this,{capsuleItemClick: [ 'emit', '...' ] } ); [23:13:04] right? [23:13:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC search filter bar double click - suggestions are not displayed - https://phabricator.wikimedia.org/T156214#3054310 (10Etonkovidova) @Catrope - yes, the issue is not present anymore. **QA recommendation: Resolve.** [23:13:22] sanity check [23:16:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054315 (10jmatazzoni) [23:16:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3054331 (10jmatazzoni) [23:16:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#3054332 (10jmatazzoni) [23:16:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) [23:20:05] RoanKattouw: if you're still around: i posted some comments on your popup-related changes [23:20:23] mooeypoo: Correct [23:20:39] MatmaRex: Thanks, will look [23:21:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): RC filters: filter selector drop down is misplaced in RTL - https://phabricator.wikimedia.org/T157189#3054340 (10Etonkovidova) Checked in betalabs - the drop-down... [23:23:13] MatmaRex: OK what you're saying seems reasonable, I'll look on Monday [23:23:31] I can definitely work on the anchor placement margin thing [23:23:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3054347 (10jmatazzoni) [23:25:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement the beta preference option for RC Filters project - https://phabricator.wikimedia.org/T159007#3054360 (10jmatazzoni) [23:25:42] Good point re the 35 alignments, we probably don't need most of those [23:25:49] Not sure which ones to cut yet, but I can look at that on Monday too [23:26:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3054363 (10Catrope) >>! In T149467#3054338, @gerritbo... [23:28:14] Another challenge there is coming up with a sensible naming/config scheme while also retaining back compat [23:28:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): RC filters - filters discarded via trash bin icon still displayed greyed i... - https://phabricator.wikimedia.org/T158135#3054364 [23:36:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054372 (10jmatazzoni) I rewrote this task to spread some of the things... [23:42:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054385 (10jmatazzoni) [23:44:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3054387 (10jmatazzoni) @Pginer-WMF, I put this in the Design column and...