[01:36:26] 06Collaboration-Team-Triage, 10Flow, 10MobileFrontend: Mobile web Special:Contributions doesn't include Flow contributions - https://phabricator.wikimedia.org/T158612#3041849 (10Mattflaschen-WMF) [05:37:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#2752532 (10Krinkle) >>! In T149435#2920854, @gerritbot wrote: > Change 32585... [06:11:52] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3042022 (10Alsee) >>! In T63729#3038137, @jeblad wrote: > Sometimes I would really want a more firm standpoint from WMF aga... [09:45:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 06Community-Liaisons: Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#3042306 (10Trizek-WMF) I'm contacting Polish Wikipedia now. They are not on the... [09:46:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3042309 (10Trizek-... [10:25:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3042433 (10tarloce... [10:46:23] (03PS4) 10Esanders: Separate message boxes from round-corner input widget group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338795 (https://phabricator.wikimedia.org/T116573) [11:15:02] 06Collaboration-Team-Triage, 10Flow, 07Design, 13Patch-For-Review: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#3042517 (10Esanders) The separation looks deliberate. The glitch looks wrong. Unless you have any better solutions... [11:41:53] (03PS1) 10Esanders: Don't hide/show editors, just detach/attach [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338954 [13:13:39] 06Collaboration-Team-Triage, 10Flow, 07Design, 13Patch-For-Review: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#3042680 (10Pginer-WMF) >>! In T116573#3042517, @Esanders wrote: > The separation looks deliberate. The glitch looks wrong. Unless you have any better solutions... [13:14:35] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#3042681 (10Nemo_bis) Added to the latest window available for Europeans: https://wikitech.wikimedia.org/w/index.php?title=Deploym... [13:38:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Wikimedia-Site-requests: Maintenance script run to convert Flow boards to Wikitext prior to remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T156113#3042711 (10Nemo_bis) [17:48:15] RoanKattouw: matt_flaschen Can you look at https://gerrit.wikimedia.org/r/336947 and the vendor dependant patch too (I can rebase the vendor patch if you're going to merge :)) [17:58:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 06Community-Liaisons (Jan-Mar 2017): Enable the ORES review tool by-default on wikis that have it as a Beta feature - https://phabricator.wikimedia.org/T158225#3043733 (1... [17:59:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 06Community-Liaisons (Jan-Mar 2017): Enable the ORES review tool by-default on wikis that have it as a Beta feature - https://phabricator.wikimedia.org/T158225#3030378 (1... [17:59:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Turn on ORES good faith test model in production for all supported wikis targeted for RC Page release - https://phabricator.wikimedia.org/T158441#3043740 (10jmatazz... [18:12:11] Reedy: I'll test that real quick and then merge it, but after today's cut [18:12:30] That's fine by me :) [18:12:35] Gives it a week to soak on beta [18:12:39] I'll get the vendor patch rebased [18:15:49] Cool, thnaks [18:16:52] (03PS2) 10Reedy: Update pimple/pimple to 3.0.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/336947 [18:17:09] Rebase to force it to check it against vendor too [18:31:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline - https://phabricator.wikimedia.org/T158458#3043942 (10Mattflaschen-WMF) @Catrope, are you proposing to use EventLogging clic... [18:38:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline - https://phabricator.wikimedia.org/T158458#3043960 (10Mattflaschen-WMF) > I don't think Mark as Patrolled should count. If a... [18:40:06] 06Collaboration-Team-Triage, 10Flow: PHP Fatal error running update.php: "Class 'Pimple\Container' not found" - https://phabricator.wikimedia.org/T158157#3043964 (10Catrope) 05Open>03Resolved a:03Catrope Closing this task because the remainder of it is filed as T158354 already. [18:43:50] 06Collaboration-Team-Triage, 10Notifications, 07Technical-Debt: EchoDiscussionParserTest is slow - https://phabricator.wikimedia.org/T158120#3027130 (10Catrope) Hmm this probably points to the underlying code being slow, not just the tests themselves. I suspect this is because it uses `wfDiff()` a lot. [18:45:18] matt_flaschen: Do you know if https://phabricator.wikimedia.org/T158239 is expected to be worked on by us, or by the perf team? [18:49:44] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Filter edits unreviewed within X hours - https://phabricator.wikimedia.org/T158363#3043977 (10Catrope) [19:05:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Improve Special:RecentChangesLinked to filter categories and sub-categories - https://phabricator.wikimedia.org/T158572#3040777 (10Catrope) I'm afraid this is not very feasible, because categories can be very deeply... [19:19:06] (03CR) 10Catrope: [C: 032] Update pimple/pimple to 3.0.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/336947 (owner: 10Reedy) [19:24:16] (03CR) 10Catrope: [C: 04-1] "You missed a few places where flow-cancel appears:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/338704 (https://phabricator.wikimedia.org/T158526) (owner: 10SamanthaNguyen) [19:32:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make the old parts of the new RC form work in the same, dynamic fashion as the new filters controls - https://phabricator.wikimedia.org/T157594#3044132 (10jmatazzoni) I'm going to wait and look at this on beta, then... [19:36:46] (03Merged) 10jenkins-bot: Update pimple/pimple to 3.0.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/336947 (owner: 10Reedy) [19:37:04] (03CR) 10jenkins-bot: Update pimple/pimple to 3.0.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/336947 (owner: 10Reedy) [19:54:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline - https://phabricator.wikimedia.org/T158458#3044224 (10jmatazzoni) [19:56:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876#62106 (10Quiddity) Fresh request for this feature from a Slovenian-language editor, at https://www.mediawiki.org/wiki/Topic:Tlgxli72jrmajwpw and... [19:57:19] matt_flaschen: Hey, I added you as a reviewer of https://gerrit.wikimedia.org/r/336963 but Roan said I should explicitly point out that you may want to -2 as (?) it conflicts with work you're doing. Unless it doesn't. :-) [20:03:35] 06Collaboration-Team-Triage, 10Flow, 10MobileFrontend: Mobile web Special:Contributions doesn't include Flow contributions - https://phabricator.wikimedia.org/T158612#3041849 (10Etonkovidova) It's interesting that https://en.m.wikipedia.org/wiki/Special:Contributions gives: No such page Cannot look at hist... [21:14:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Improve Special:RecentChangesLinked to filter categories and sub-categories - https://phabricator.wikimedia.org/T158572#3040777 (10Mattflaschen-WMF) Probably the only ways we could do this performantly are: * Maintai... [21:20:42] RoanKattouw, I got the impression the perf team would work on the GettingStarted task, but they never explicitly said. [21:21:53] OK, cool [21:29:40] James_F, it conflicts in the sense that they're both touching the same area of code (certainly causing merge conflicts) and similar concepts, but I don't think either is really redundant to the other. [21:29:51] I'll comment and ask them to be careful and consider rebasing. [21:38:43] 06Collaboration-Team-Triage, 10Flow, 10MobileFrontend: Mobile web Special:Contributions doesn't include Flow contributions - https://phabricator.wikimedia.org/T158612#3044697 (10Mattflaschen-WMF) Yes, that is tracked at {T122949}. See also {T122305} [21:39:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/339039 (owner: 10L10n-bot) [21:40:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/339037 (owner: 10L10n-bot) [21:46:06] It's more connected to the highlighting patch than my patch. [21:46:35] Please tell me there's not yet ANOTHER change to the structure of the lines [21:46:49] I'm having a lot of trouble trying to to add the circles to the "enhanced" recent changes list [21:47:03] (the highlights work, btw... the circles are going to require ... creativity) [22:07:49] RoanKattouw, matt_flaschen I think I solved for the advanced recent changes [22:07:58] It doesn't look *great* but it works and looks consistent [22:09:41] RoanKattouw, [22:09:43] .... [22:09:48] why [22:09:53] in the name of all that is javascripty [22:10:02] is mw.user.options.get( 'usenewrc' ) returning 1 (integer) when it is true [22:10:07] but "0" (string) when it is false [22:10:10] EXPLAIN. [22:10:16] * mooeypoo bashes head on desk [22:10:36] So I can't do !!mw.user.options.get( 'usenewrc' ) because 1 would be true but also "0" would be true [22:10:43] but I can't do mw.user.options.get( 'usenewrc' ) === '1' because it's not '1' it's 1 [22:10:46] * mooeypoo stares [22:11:53] mooeypoo: i usually use == for this. i think Number(mw.user.options......) would also work [22:12:00] meh. [22:12:12] Good point about Number [22:12:14] mooeypoo, it just adds data attributes, it shouldn't break anything. [22:12:29] https://gerrit.wikimedia.org/r/#/c/336963/4 I mean [22:12:53] we're going to have some changes in the recent changes list too [22:13:22] mooeypoo: by the way, i discovered that .scrollLeft can behave in three different ways in RTL yesterday. great fun. https://github.com/othree/jquery.rtl-scroll-type has a nice writeup in README about it [22:13:37] Yep [22:13:58] scrollLeft -- as most times you define "left" instead of "towards start" or stuff like that -- is weird in RTL [22:14:16] mooeypoo, did you know '0' is falsy in PHP but truthy in JS? [22:14:16] oooh [22:14:18] it's not just weird, it's weird in three different ways! D: [22:14:42] matt_flaschen, !!! [22:15:02] MatmaRex, oh are browser treating it differently? [22:15:06] * mooeypoo is not surprised [22:15:21] yeah [22:15:27] MatmaRex, thanks for the link, though, this looks interesting [22:15:37] in IE, it goes from 0 to 100 as you scroll [22:15:42] in Firefox, it goes from 0 to -100 [22:15:46] I'm in the middle of writing a blog post about double-quotes and the adventure of assuming "pretty / curly" quotations [22:15:49] in Chrome, it goes from 100 to 0 [22:15:51] insanity [22:15:56] but after that, I may write something up about scrolling and RTL [22:18:37] ok! we now support enhanced RC view thing [22:18:42] highlights work in it [22:18:47] * mooeypoo grumble-grumble [22:19:01] brb [22:56:51] RoanKattouw, ok, I'm fairly content with the highlights patch. I think we can remove WIP. [22:57:36] I also ended up faking the opacity -- opacity: 2; didn't work as a counter to opacity: 0.5; on the parent. I ended up using rgba( ..., @muted-state ); and then applying opacity: @muted-state; to the [X] and label of the widget, instead.