[00:03:20] matt_flaschen: I am looking into https://phabricator.wikimedia.org/T156864 and there is a reference to "Must store a list of “subsets”, which it will get from the backend definition (see T152754: Configure filters in a single extensible place" [00:03:20] T152754: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754 [00:04:24] matt_flaschen: my question: as fas as I can see the subset stuff is exclusively about ORES filters [00:09:12] mooeypoo: can you take a look at my comment about Uncaught TypeError in https://phabricator.wikimedia.org/T157852 ? If there is no concerns, I am ready to close the ticket [00:09:58] mooeypoo: I could file a different ticket for TypeError if it's important to fix it [00:15:35] etonkovidova, yes, IIRC that is right (regarding subset) [00:15:47] matt_flaschen: ok - thx [00:16:57] etonkovidova, yes, that should be fixed. I'll leave it to mooeypoo about whether it needs to be a separate task. [00:17:17] matt_flaschen: ah, ok then [00:17:18] Any error or exception needs to be fixed (and filed until it is), just a question of priority. [00:17:49] matt_flaschen: another question - why I am seeing RC filters on Special:RecentChangesLinked/Wikipedia:Featured_articles ? [00:17:55] etonkovidova, also, JS errors (even if they don't show an error to the user) have a tendency to sometimes block all further interactivity. [00:18:11] matt_flaschen: yes, right [00:18:55] matt_flaschen: about Special:RecentChangesLinked/Wikipedia:Featured_articles -- looks really weird. [00:19:11] etonkovidova, RecentChangesLinked == Related Changes. It Just Worked beacuse RecentChangesLinked is a subclass of RecentChanges. [00:19:50] matt_flaschen: hmm... so RC filters are supposed to work there? [00:20:23] etonkovidova, originally, not in the MVP. We started discussing it (including in standup today I think). I think jmatazzoni_ is leaning towards allowing it in the MVP, but I forget exactly where we ended up. [00:20:31] etonkovidova, but I think it is planned for later regardless. [00:20:44] So in my opinion, unless there are major issues, we should just put it in the MVP. [00:20:51] matt_flaschen: exactly [00:21:12] etonkovidova, what issues do you see? [00:21:20] It looks right to me, though I have to expand the time range to get any results. [00:21:44] https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChangesLinked&days=30&from=&target=Wikipedia%3AFeatured_articles [00:22:03] matt_flaschen: yes, I did expand the date range too - looks fine [00:24:09] matt_flaschen: interesting that we do not have new filters on Special:NewPages [00:27:46] etonkovidova, they're different internally. ChangesListSpecialPage (internal only), RecentChanges, RecentChangesLinked, and Watchlist are all one family. [00:28:13] etonkovidova, NewPage, NewPagesFeed, Contributions, etc. are all mostly unrelated (other than being special pages) [00:29:46] matt_flaschen: since we are specifically aiming to help newbies and help with monitoring vandalism would be great to prioritize New pages and Contirburions/Newbies .... [00:30:44] etonkovidova, agreed about NewPages and/or NewPagesFeed. Special:Contributions/newbies is obselete (and probably doesn't need to be fixed since we have Special:RecentChanges with new filters instead) [00:31:54] etonkovidova, if you're curious, you can see the diagram at https://doc.wikimedia.org/mediawiki-core/master/php/classChangesListSpecialPage.html . [00:32:27] matt_flaschen: ok :) [00:32:30] It's also clickable. There's not that much reuse between the special pages, though. [00:33:10] matt_flaschen: I ran (again!) into the problem that some links on RC page are, in fact filters. Like 'IPs contribs' gives Special:RecentChanges&hideliu=1&hideanons=0 [00:33:37] matt_flaschen: but RC default filters are duly displayed - unchanged, arrrrrrrgh [00:35:58] etonkovidova, can't reproduce. [00:36:16] etonkovidova, when I click that I go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&hideliu=1&hideanons=0 and the right filters are displayed and AFAICT function correctly. [00:36:42] matt_flaschen: in betalabs - RC page with default filters - click on the link 'IP's contrib' [00:36:58] The only difference is that 'Unregistered' is added, which seems right. [00:37:01] etonkovidova, I did. [00:37:08] On https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges [00:37:10] Click that link [00:37:30] etonkovidova, what capsules do you see before and after clicking the link? [00:37:50] For me, before: Human (not bot), Page edits, Page creations, Logged actions [00:38:08] After: Unregistered, Human (not bot), Page edits, Page creations, Logged actions [00:38:18] matt_flaschen: right and then when you click on 'IPs contribs'? what do you see? [00:39:35] etonkovidova, do you see the same for After? [00:39:42] matt_flaschen: yeah - sigh [00:41:16] matt_flaschen: and the new filters will work for Mobile link in enwiki too? and for whatever links-filters other wikis have ? [00:43:04] etonkovidova, yes. That goes to equivalent of https://en.wikipedia.beta.wmflabs.org/w/index.php?namespace=&tagfilter=mobile+edit&title=Special%3ARecentChanges . The tag filter box is properly updated, and it works. There is no UI change currently to that part of the form. [00:43:16] All links are planned to keep working. [00:43:54] There is one broken part of my patch currently due to a weird edge case where URLs are handled strangely. That will be solved with redirects before that is merged. [00:44:09] the hideanons=1&hideliu=1 thing. [00:44:51] matt_flaschen: ok then. All is good :) [00:55:41] matt_flaschen, can you remind me the link to the ticket where we are discussing the conflict messages technically? [00:55:46] I can't find it for some reason [00:56:45] mooeypoo, T156427 . We can talk now instead/first if you want. [00:56:46] T156427: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427 [00:57:02] I was going to read your conflict code then ping you. I haven't got to that, but we may still be able to do the i18n part. [00:57:11] can you chat now with me and joe? [00:57:21] mooeypoo, sure, collab-team video? [00:57:29] hang on [00:58:10] matt_flaschen, hangouts [00:58:14] (sent you the link) [00:59:54] matt_flaschen, did you get the invite? [01:00:15] mooeypoo, yeah, I had to go to a phone room, now checking Gmail. I don't keep gmail.com open (I use Thunderbird), so it only rings on my phone. [01:00:39] Gotcha, i sent the invite anyways(even tho its time passed) we're in the video in it [01:00:49] but I can invite you again [01:36:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: "Days" and "limit" links on RC page need AJAX - https://phabricator.wikimedia.org/T156697#3028125 (10Etonkovidova) There is a 'mismatch" in URL when the same UI action (the same filters selection) and clicking on 'I... [02:01:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3028185 (10Mattflaschen-WMF) Joe, Moriel, and I had a meeting about this, and agreed that all the message... [02:08:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Update RC page results without reloading the page (AJAX) when filters are ... - https://phabricator.wikimedia.org/T153949#2896180 [02:43:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RCFilters UI: Implement 'full coverage' status for groups - https://phabricator.wikimedia.org/T156860#2988087 (10Etonkovidova... [05:02:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#2753548 (10Mattflaschen-WMF) @Pginer-WMF You might ha... [07:33:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3028424 (10Pginer-WMF) >>! In T149467#3028365, @Mattf... [07:40:17] 06Collaboration-Team-Triage, 10Flow: PHP Fatal error running update.php - https://phabricator.wikimedia.org/T158157#3028429 (10Innosflew) [07:42:01] 06Collaboration-Team-Triage, 10Flow: PHP Fatal error running update.php - https://phabricator.wikimedia.org/T158157#3028443 (10Innosflew) [07:42:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3028445 (10Pginer-WMF) >>! In T156427#3028185, @Mattflaschen-WMF wrote: > Joe, Moriel, and I had a meetin... [08:30:49] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#3028544 (10Marostegui) x1 is done too, so I believe this ticket can be closed. I am not going to paste all... [08:30:57] 06Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963#3028546 (10Marostegui) [08:31:00] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#3028545 (10Marostegui) 05Open>03Resolved [08:31:05] 06Collaboration-Team-Triage, 10Notifications, 07Epic, 13Patch-For-Review: Provide access to Notifications for anonymous users - https://phabricator.wikimedia.org/T58828#3028547 (10Marostegui) [09:47:11] 06Collaboration-Team-Triage, 10Flow: PHP Fatal error running update.php: "Class 'Pimple\Container' not found" - https://phabricator.wikimedia.org/T158157#3028628 (10Aklapper) [10:18:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Jarring scrolling bug in dropdown panel for RC Page filters - https://phabricator.wikimedia.org/T158118#3028729 (10Pginer-WMF) > @Pginer-WMF, what is the desired behavior? The desired behaviour is for the panel not... [11:11:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Portuguese Wikipedia about testing ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T156157#3028823 (10Trizek-W... [11:49:31] (03PS1) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337817 [11:49:37] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated suppress warning methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337817 (owner: 10WMDE-Fisch) [11:52:00] (03PS1) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 [11:53:43] (03PS2) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 [11:53:49] (03PS3) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 [12:14:50] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 (owner: 10WMDE-Fisch) [12:41:47] (03Abandoned) 10Prtksxna: Use OO.ui.Confirm instead of jQuery.confirmable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/337421 (owner: 10Prtksxna) [13:09:33] (03PS4) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 [13:13:31] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 (owner: 10WMDE-Fisch) [13:31:42] (03Abandoned) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337817 (owner: 10WMDE-Fisch) [13:55:19] (03PS5) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 [15:35:56] (03CR) 10Jforrester: [C: 032] Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 (owner: 10WMDE-Fisch) [16:13:09] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build all front-end elements for the new RC Page user interface - https://phabricator.wikimedia.org/T144448#3029753 (10Pginer-WMF) >>! In T144448#3023150, @Etonkovidova wrote: > @Pgin... [16:44:10] (03Merged) 10jenkins-bot: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 (owner: 10WMDE-Fisch) [16:48:09] (03CR) 10jenkins-bot: Replace deprecated suppress warning methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337818 (owner: 10WMDE-Fisch) [17:59:02] (03PS1) 10WMDE-Fisch: Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) [17:59:49] (03PS2) 10WMDE-Fisch: Avoid unintended mentions when changing content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337883 (https://phabricator.wikimedia.org/T154406) [18:03:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#3030096 (10Mooeypoo) This raises a related code-quest... [18:17:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Discussion: release RC Page filtering to non-ORES wikis AND make ORES default - https://phabricator.wikimedia.org/T158004#3030202 (10Trizek-WMF) If I understand correctly, users who have ORES on their wiki will have... [18:21:12] (03CR) 10WMDE-Fisch: [C: 031] Fix method name in LoadExtensionSchemaUpdates [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337211 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [18:43:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Discussion: release RC Page filtering to non-ORES wikis AND make ORES default - https://phabricator.wikimedia.org/T158004#3030280 (10Trizek-WMF) [18:45:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Discussion: release RC Page filtering to non-ORES wikis AND make ORES default - https://phabricator.wikimedia.org/T158004#3030297 (10Trizek-WMF) I've edited the description according to my meeting with @jmatazzoni. P... [18:57:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RCFilters UI: Implement 'full coverage' status for groups - https://phabricator.wikimedia.org/T156860#3030350 (10Etonkovidova... [18:59:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RCFilters UI: When removing a capsule item, its popup remains visible - https://phabricator.wikimedia.org/T157852#3030374 (10... [19:00:29] mooeypoo: please take a look at my comments about TypeError in https://phabricator.wikimedia.org/T157852 [19:04:50] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-LoginNotify, 03Community-Tech-Sprint, 13Patch-For-Review: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#2995628 (10kaldari) [19:15:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Discussion: release RC Page filtering to non-ORES wikis AND make ORES default - https://phabricator.wikimedia.org/T158004#3030433 (10Trizek-WMF) I've created a task concerning turning ORES by default: {T158225} [19:15:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Discussion: release RC Page filtering to non-ORES wikis AND make ORES default - https://phabricator.wikimedia.org/T158004#3030435 (10Trizek-WMF) [19:20:06] (03PS1) 10Sbisson: Import dump: support importing a board that exist in the farm [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337895 (https://phabricator.wikimedia.org/T154830) [19:29:02] (03CR) 10jerkins-bot: [V: 04-1] Import dump: support importing a board that exist in the farm [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337895 (https://phabricator.wikimedia.org/T154830) (owner: 10Sbisson) [20:04:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3030719 (10jmatazzoni) [20:08:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3030735 (10jmatazzoni) I updated the approved texts above as discussed in this [[ https://docs.google.com/document/d/... [20:17:08] etonkovidova, I did the deployment planning page for this week: https://www.mediawiki.org/wiki/Collaboration/Deployment_planning [20:17:21] matt_flaschen: great - thx [20:25:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3030768 (10jmatazzoni) Regarding the "Edit authorship" filters, @Etonkovidova points out that these filters cover man... [20:36:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 07Regression: [regression wmf.12] Edit area in wikitext has extra blue line when focused - https://phabricator.wikimedia.org/T158238#3030788 (10Etonkovidova) [20:43:18] 06Collaboration-Team-Triage: Improve GettingStarted data storage strategy - https://phabricator.wikimedia.org/T158239#3030809 (10aaron) [21:23:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337948 (owner: 10L10n-bot) [21:25:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337956 (owner: 10L10n-bot) [21:42:07] 06Collaboration-Team-Triage, 10MediaWiki-extensions-GettingStarted: Improve GettingStarted data storage strategy - https://phabricator.wikimedia.org/T158239#3030990 (10Mattflaschen-WMF) [21:47:49] (03PS2) 10Sbisson: Import dump: support importing a board that exist in the farm [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337895 (https://phabricator.wikimedia.org/T154830) [21:48:30] stephanebisson, any objections if I change (at least in the front-end model) "class" to "identifier" and just use that identifier to discover classes in the UI? [21:48:40] I think it's confusing otherwise, but I want to make sure i am not missing something [21:50:34] mooey|lunch: css classes that identify lines to highlight will be coming from the filter definitions from the server and can come from extensions and be arbitrary. You can change the word 'class' to 'identifier' but you shouldn't construct them based on the filter name or something. [21:51:12] no no, not constructing anything -- just changing the word "class" in the DM itself (not even changing the init file coming from the server, that one may make sense) to "identifier" [21:51:21] It was just confusing to see a call "this.getClass()" [21:51:33] but that means something different than the usual thing you'd think about "what class is this" in JS [21:51:35] yeah, such an overloaded word [21:51:44] identifier is fone [21:51:46] fine [21:51:48] * mooey|lunch nods [21:56:29] 06Collaboration-Team-Triage, 10Flow: PHP Fatal error running update.php: "Class 'Pimple\Container' not found" - https://phabricator.wikimedia.org/T158157#3028429 (10Mattflaschen-WMF) You have to run: composer update in the Flow directory. If you use the release branch downloads rather than git master, it wi... [21:57:28] (03CR) 10jerkins-bot: [V: 04-1] Import dump: support importing a board that exist in the farm [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337895 (https://phabricator.wikimedia.org/T154830) (owner: 10Sbisson) [22:01:26] (03Restored) 10Mattflaschen: Replace deprecated suppress warning methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337817 (owner: 10WMDE-Fisch) [22:02:33] (03Abandoned) 10Mattflaschen: Replace deprecated suppress warning methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337817 (owner: 10WMDE-Fisch) [22:45:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3031389 (10Mattflaschen-WMF) >>! In T156427#3028445, @Pginer-WMF wrote: > I'm not sure I understand this.... [22:50:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3031396 (10Mattflaschen-WMF) @jmatazzoni @Mooeypoo The only place I think there is an issue is the ORES f... [22:55:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3031409 (10Mattflaschen-WMF) The same applies to the results area messages, only if we can show more than... [22:59:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3031410 (10Mattflaschen-WMF) There is one issue with the conflict messages still, I explained and proposed a solutio... [23:19:03] stephanebisson, my brain is melting trying to remember the order of priority for math operations with this: [23:19:09] var selectedColor = this.model.isHighlightEnabled() ? this.model.getHighlightColor() || '' : '' [23:19:26] is this var Y = A ? ( b || '' ) : '' ? [23:19:27] right? [23:19:31] * mooey|lunch is double-checking [23:19:54] I get empty in both cases, which makes sense, but I am confused, want to make sure [23:20:08] I wasn't sure if the || or overrides the : or [23:21:05] * mooeypoo is testing this out in the console [23:32:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3031477 (10jmatazzoni) The latest v >>! In T156427#3031409, @Mattflaschen-WMF wrote: > The same applies...