[00:09:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most commonly used - https://phabricator.wikimedia.org/T152037#2836179 (10jmatazzoni) Based on @Neil_P._Quinn_WMF's numbers above (thanks Neil, I know... [00:29:33] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, and 2 others: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3018683 (10Ricordisamoa) >>! In T157105#3014326, @Bawolff wrote: > I have no objections for what its worth, although I'm not... [00:40:00] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: Ask new users to disclose paid editing - https://phabricator.wikimedia.org/T157848#3018708 (10srishakatux) [00:46:09] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, and 2 others: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3018737 (10kaldari) [01:27:45] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3018786 (10srishakatux) [01:29:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters UI: Split ResourceLoader modules - https://phabricator.wikimedia.org/T156532#3018803 (10Mooeypoo) a:03Mooeypoo [01:31:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): RCFilters UI: When removing a capsule item, its popup remains visible - https://phabricator.wikimedia.org/T157852#3018806 (10Mooeypoo) [01:32:48] matt_flaschen, you still around? just a quick note - I'm waiting for the implementation of the *text* of the popups (the representation of conflicts, etc) for the backend patch... I didn't want to assume about the issue you described regarding the messages. That ok, or do you want me to go by what you have? [01:42:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most commonly used - https://phabricator.wikimedia.org/T152037#3018881 (10Neil_P._Quinn_WMF) >>! In T152037#3018666, @jmatazzoni wrote: > **RTRC** @Kr... [01:46:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: RCFilters UI: When removing a capsule item, its popup remains visible - https://phabricator.wikimedia.org/T157852#3018885 (10Mooeypoo) a:03Mooeypoo [01:46:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters UI: When removing a capsule item, its popup remains visible - https://phabricator.wikimedia.org/T157852#3018806 (10Mooeypoo) [02:35:35] mooeypoo, back now. [02:36:25] mooeypoo, I haven't done the conflict popups yet. [02:36:30] The back-end of them I mean. [02:37:09] * mooeypoo nods [02:37:16] I don't know if I should start or not [02:37:35] I've been fixing the smaller issues (found a BUNCH of bugs in popup widget, bartosz will be excited... ) [02:42:16] mooeypoo, what patch should I look at for the conflicts, or is it merged? [02:42:30] mooeypoo, maybe we can agree where to put it now so you're not blocked. [02:44:53] (03PS1) 10Gergő Tisza: Fix method name in LoadExtensionSchemaUpdates [extensions/Echo] - 10https://gerrit.wikimedia.org/r/337211 (https://phabricator.wikimedia.org/T157651) [02:46:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: RC filters: filter selector drop down is misplaced in RTL - https://phabricator.wikimedia.org/T157189#3018952 (10Mooeypoo) a:03Mooeypoo This is a bit of a hack until we figure out the positioning overrides that happen in PopupWidg... [02:46:39] matt_flaschen, the conflict behavior is merged [02:46:55] but the popup text is waiting. I don't think it's urgent, btw [02:47:15] but yeah, I don't want to start assuming before you set it up [02:50:33] mooeypoo, my understanding from T156427 is there's only one message, right? [02:50:33] T156427: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427 [02:51:18] geez, *another* task talking about conflicts? I think that makes three. Though to its credit, it's quoting the other one. [02:51:52] matt_flaschen, anyways according to Pau's comment, it seems there should be a message explaining things [02:52:09] mooeypoo, yeah, that's what it says on the task. [02:52:25] "No results displayed because the search criteria are in conflict." (general message for all conflics AFAICT), plus: [02:52:29] " The "New User" filter finds only registered users, so the “Unregistered” filter is canceling its effect." [02:52:34] Per-conflict message. [02:53:05] mooeypoo, what about P4923 ? [02:53:31] It also specifies whether it's a filter or group, which should make the client a little easier (if not you can collapse it pretty easily) [02:54:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#3018957 (10Mooeypoo) We should really be careful messages that use pieces of other messages inside them i... [02:54:45] matt_flaschen, ^ just answered that one btw [02:55:10] P4923? [02:55:25] Sorry, I thought stashbot would auto-link it: https://phabricator.wikimedia.org/P4923 [02:55:39] mooeypoo, my understanding was that would be a custom message written out, not lego. [02:55:41] I.E.: [02:55:55] O.o [02:56:03] meh? [02:56:05] userExpLevel-conflict-unregistered: 'The "New User" filter finds only registered users, so the “Unregistered” filter is canceling its effect.' [02:56:09] Ignore my lame key, but you get the idea. [02:56:32] That would mean we need to make sure ew know ALL combinations that are conflicting and write a specific message for each. We really want to do that? [02:56:54] mooeypoo, we have to know them all explicitly on the backend anyway. [02:57:08] As we've discussed, it's not enough to just know there's no results, you have to know it's a logical conflict and separately mark each one. [02:57:09] But also, even if we do that, "New user" is its own message -- we shouldn't duplicate it in another message because it might change [02:57:30] mooeypoo, I think there is a see also-ish template. [02:57:32] One sec [02:57:34] Just like "experienced" / "newbie"(whatever it was) changed suddenly. [02:58:10] matt_flaschen, I thought we'd have a general message + params for what's conflicting with this specific filter [02:59:00] "This filter is currently in conflict, meaning no results are available, [read more about conflicts here]. Filters in conflict: {{$1}}" [02:59:29] mooeypoo, okay. As stated in retro, I was already thinking of not including this in the WIP, so I can keep it out. But in my opinion this is the user-friendly way to do it. [02:59:36] https://phabricator.wikimedia.org/source/mediawiki/browse/master/languages/i18n/qqq.json;71803987d322ea60b3ba3d765375849adfe11776$208 [03:00:35] matt_flaschen, I have no preference; if we want each message on its own, we cna do that (there aren't THAT many conflicts) I am just slightly concerned we may be shooting ourselves in the foot here in case there are combinations in the future we miss [03:00:44] mooeypoo, although it may have to refer to "User experience level", not the individual filters, which are customizable (though I'm not sure if the group set up/how many filters is customizable, or just the thresholds). [03:00:49] but I don't think that'll happen logically... if we define those messages in the same place we define the conflicts, it should be fine [03:00:59] Exactly, it just wouldn't recognize it as a conflict at all. [03:01:09] Even if it is, it has to be defined as one. [03:01:18] Right, and then it's clear you need a message. [03:01:37] I guess. I'm a little meh about having to write out (and translate) so many individual messages, but that's a product decision - and there's no doubt it'll *look* nicer [03:01:38] I'll ask on the task to clarify it. [03:01:40] and feel nicer [03:02:40] I don't have a preference, just concerns on the amountof messages and puzzle messages... other than that, I think both versions have good merits - I'll defer to your instinct and opinion, and Joe/Pau's product decisions [03:03:08] I agree we can't do lego, but I think it's acceptable to spell it out and properly mark it with msg-mw in qqq. [03:03:54] The one thing we should verify is that if we use "The group 'User experience' conflicts with.." or "The filter 'Experienced' conflicts with..." then we have to make sure the *word* 'experienced' is written in, not puzzled-in, *but* is also referenced (there's a 'related to' or something in messages, right?) and we remember to change it if we rename the filter. [03:04:36] As in -- I think that your solution is great for user interface, but it *will* create a need to make sure we're on top of all the naming. We can't directly control the translations, and whether translators will properly translate the filter name inside that message [03:04:43] so I pessimistically predict issues :P [03:04:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: More forcefully communicate "Conflict" filter settings to the user - https://phabricator.wikimedia.org/T156427#2974309 (10Mattflaschen-WMF) Per above, @mooeypoo and I interpreted it differently. I interpreted that t... [03:05:02] Then again, it's not *that* many messages. [03:05:24] mooeypoo, agree, see my link above. [03:05:28] To qqq.json [03:06:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3018963 (10Mattflaschen-WMF) [03:07:30] Yeah, I see [03:07:39] Yeah it's a good idea, I didn't think about it like that [03:07:52] What do we do if there are multiple conflicts, though? [03:07:59] Do we display them all? [03:08:34] (brb) [03:09:42] mooeypoo, I actually remembered that Pau said only one, then I had to find it. [03:10:01] https://phabricator.wikimedia.org/T156427#2981771 [03:21:03] mooeypoo, I'm heading out soon, but I will check scrollback/Hangouts. [03:21:59] * mooeypoo nods [03:22:06] yeah I'm heading off to the weekend too [03:22:28] I'll wait to see the conclusion on that -- it's not urgent UI-side, so we can wait at least to talk about this Monday if we need to [03:22:35] matt_flaschen, have a great weekend :) [03:23:06] mooeypoo, you too. :) [14:08:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Portuguese Wikipedia about testing ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T156157#3019270 (10Chicocve... [21:30:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/337240 (owner: 10L10n-bot)