[00:02:14] RoanKattouw: https://phabricator.wikimedia.org/T7560 should be listed as a task being completed by RCFilters. [00:04:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build all front-end elements for the new RC Page user interface - https://phabricator.wikimedia.org/T144448#3011677 (10Catrope) [00:04:30] James_F: Thanks for spotting that, I've marked it as a subtask of T144448 [00:04:31] T144448: Build all front-end elements for the new RC Page user interface - https://phabricator.wikimedia.org/T144448 [00:04:36] Nice. Thank you. [00:04:39] Not sure if that was the right way around [00:04:45] So if I did it wrong, please fix it :) [00:04:55] (Found it whilst looking for tasks for annual planning.) [00:05:49] RoanKattouw: T7560 feels like it's meant to include time-based updates. Is that in scope (not MVP)? [00:05:49] T7560: Make Special:RecentChanges auto-updating - https://phabricator.wikimedia.org/T7560 [00:06:07] Yes [00:06:15] OK, will re-work. [00:06:19] Pau definitely included that in his design but we're not doing that for phase 1 [00:06:47] That said once everything is working an already AJAXy, it's probably like a day of additional work [00:06:55] *working and [00:07:01] Plus a year of Ops shouting at you for melting the servers. [00:08:34] RoanKattouw: Also, it's past midnight, start modelling good behaviours for your staff. ;-) [00:08:46] Yeah I just yawned a lot, time for bed [00:08:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Build all front-end elements for the new RC Page user interface - https://phabricator.wikimedia.org/T144448#3011682 (10Jdforrester-WMF) [00:09:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#3011686 (10Jdforrester-WMF) 05Resolved>03Open Re-opening. :-) [00:10:17] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic: Provide RC Filters to all users - https://phabricator.wikimedia.org/T157642#3011690 (10Jdforrester-WMF) [00:10:30] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic: Provide RC Filters to all users - https://phabricator.wikimedia.org/T157642#3011703 (10Jdforrester-WMF) [00:10:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic: Provide RC Filters to all users - https://phabricator.wikimedia.org/T157642#3011690 (10Jdforrester-WMF) [00:10:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#3011707 (10Jdforrester-WMF) [00:11:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#2600352 (10Jdforrester-WMF) [00:12:04] RoanKattouw: Also is https://phabricator.wikimedia.org/T144451 closable? [00:12:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Jdforrester-WMF) Is thi... [00:13:32] Probably. All its children are closed except https://phabricator.wikimedia.org/T150059 [00:14:07] * James_F nods. [00:14:12] * James_F is impatient. ;-) [00:14:30] But that's a bit of a weird task anyway [00:14:38] Yeah [00:14:42] Which we can probably make a subtask of another one instead, let me find that one [00:15:32] It could be a subtask of T152754 , not a great fit task-wise but in practice I think that's where most of actually doing that ensuring would end up [00:15:33] T152754: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754 [00:15:49] Cause the way Matt is doing that one is to resolve prefs on the server side and just export the resolved default value to the client [00:15:54] * James_F nods. [00:16:02] So everything about respecting preferences will end up happening there [00:16:24] It'd be a bit of a weird reparent but then again 150009 is a weird task anyway, so I would be fine with it [00:16:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#3011725 (10Jdforrester-WMF) [00:16:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3011724 (10Jdforrester-WMF) [00:17:01] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3011733 (10Jdforrester-WMF) [00:17:04] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#3011730 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF Per Roan. [00:17:09] Anyway. I will stop mucking about with your work. [00:17:11] Whoops. [00:17:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#3011734 (10Jdforrester-WMF) a:05Jdforrester-WMF>03jmatazzoni [00:17:48] I think T150059 is a no-op except "ORES sensitivity", and checking for default variations. [00:17:48] T150059: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059 [00:17:58] Everything else should just work. [00:18:01] * James_F nods. [00:18:05] Should™ :-) [00:18:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3011738 (10Mattflaschen-WMF) [00:18:44] Yeah I suppose the no-op-iness is why I said it was a weird task [00:18:49] Anyway, actually time for bed now [00:18:52] See you all tomorrow [00:19:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#2772942 (10Mattflaschen-WMF) I thi... [00:26:33] night RoanKattouw [03:01:44] I'm heading out too. Have a good night, all. [08:06:27] (03PS2) 10Fomafix: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/323684 (https://phabricator.wikimedia.org/T117845) [08:07:52] (03CR) 10Fomafix: "Rebased after merge conflict." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/323684 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [08:57:48] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#3012358 (10Marostegui) I am going to start with S7 now (slave by slave). I said I would start on Monday bu... [09:14:42] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#2334714 (10jcrespo) Some context for echo: T119154 and T153638 <- this, in the future, will solve many conf... [09:45:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact communities for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146972#3012445 (10Trizek-WMF) [09:45:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3012444 (10Trizek-WMF) [09:55:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3012467 (10Trizek-WMF) [09:56:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) >>! In T146... [10:03:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Release strategy for RC page improvements: what wikis get the new features when? - https://phabricator.wikimedia.org/T150715#3012486 (10Trizek-WMF) As discussed with @jmatazzoni in our 1:1, the release would follow t... [10:39:06] (03CR) 10Addshore: Replace deprecated wfGetLBFactory() and wfGetLB() call (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 (owner: 10WMDE-Fisch) [11:44:23] 06Collaboration-Team-Triage, 10Flow: Adjust the indentation level for direct mentions - https://phabricator.wikimedia.org/T94381#3012640 (10Pginer-WMF) Another possible approach is to always provide options to do both, continue the conversation and create new tangents, but encourage the former by default to av... [12:04:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RC - filters group names and descriptions should be searchable - https://phabricator.wikimedia.org/T156215#3012655 (10SBisson) >>! In T156215#3011231, @Etonkovido... [12:09:42] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#3012659 (10Marostegui) hosts done in s7 so far (I decided to alter also kowiki, for consistency, as it was... [12:09:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RC - filters group names and descriptions should be searchable - https://phabricator.wikimedia.org/T156215#2967636 (10Catrope) https://gerrit.wikimedia.org/r/#/c/... [13:13:22] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, and 2 others: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3012842 (10Reedy) >>! In T157105#3010928, @kaldari wrote: > Hey @Reedy, can you +1 the config change so that I have sign off... [14:22:10] 06Collaboration-Team-Triage, 10Flow: Cross wiki URLs for Flow - https://phabricator.wikimedia.org/T157686#3013048 (10Trizek-WMF) [14:27:51] 06Collaboration-Team-Triage, 10Flow: Cross wiki URLs for Flow - https://phabricator.wikimedia.org/T157686#3013048 (10Catrope) Related: {T113311} [15:02:39] (03PS35) 10Zfilipin: [WIP] RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:04:20] (03CR) 10Zfilipin: "#35" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:04:37] (03CR) 10Zfilipin: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:13:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): RC - filters group names and descriptions should be searchable - https://phabricator.wikimedia.org/T156215#3013167 (10Etonkovidova) Checked in betalabs - RC filte... [15:21:14] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10ORES, 06Revision-Scoring-As-A-Service, 10rsaas-draftquality: Display ORES draftquality model prediction in PageCuration feed - https://phabricator.wikimedia.org/T157130#3013191 (10Halfak) [15:43:21] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#3013297 (10Marostegui) s7 is all done: ``` root@neodymium:/home/marostegui/git/software/dbtools# for i in... [16:02:07] 06Collaboration-Team-Triage, 10Flow: Cross wiki URLs for Flow - https://phabricator.wikimedia.org/T157686#3013382 (10Trizek-WMF) >>! In T157686#3013083, @Catrope wrote: > Related: {T113311} Yes, with a decision not to redirect and display a message. Should I close this one as a duplicate and comment the oth... [16:39:14] 06Collaboration-Team-Triage, 10Developer-Wishlist, 06Editing-Department, 10MediaWiki-Interface, and 5 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#3013517 (10Halfak) See also https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(idea_lab)#New_label_... [16:41:28] (03PS2) 10WMDE-Fisch: Replace deprecated wfGetLBFactory() and wfGetLB() call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 [16:41:46] (03CR) 10WMDE-Fisch: Replace deprecated wfGetLBFactory() and wfGetLB() call (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 (owner: 10WMDE-Fisch) [16:43:45] (03PS3) 10WMDE-Fisch: Replace deprecated wfGetLBFactory() and wfGetLB() call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 [16:51:09] (03CR) 10Catrope: [C: 032] Replace deprecated wfGetLBFactory() and wfGetLB() call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 (owner: 10WMDE-Fisch) [16:56:54] (03PS5) 10Cenarium: Notify users of multiple-revisions undos and assorted fixes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [17:07:12] (03Merged) 10jenkins-bot: Replace deprecated wfGetLBFactory() and wfGetLB() call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 (owner: 10WMDE-Fisch) [17:12:42] (03CR) 10Jforrester: "OOjs UI v0.19.0 (and up) included this…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [17:13:23] (03CR) 10Catrope: Remove FloatableElement hack, no longer needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/333816 (owner: 10Catrope) [17:24:38] (03CR) 10jerkins-bot: [V: 04-1] Notify users of multiple-revisions undos and assorted fixes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [17:31:10] Since today, I can't login locally (mw-vagrant). I always get: "There seems to be a problem with your login session; this action has been canceled as a precaution against session hijacking. Go back to the previous page, reload that page and then try again." [17:32:12] Any idea what may be causing that? [17:35:01] Strange [17:35:09] (03CR) 10jenkins-bot: Replace deprecated wfGetLBFactory() and wfGetLB() call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/336406 (owner: 10WMDE-Fisch) [17:35:16] I haven't seen that (yet?) [17:35:37] It's often related to a cache being unwriteable or cookies not sticking [17:36:48] RoanKattouw: same thing with a different browser with no pre-existing cookies [17:37:53] RoanKattouw: trying to create a new account fails differently: the captcha can't be fetched (400: bad request: Requested bogus captcha image) [17:38:16] WTF [17:38:24] exactly [17:38:43] And you're on master, not on a downloaded Gerrit change that might be based on something old? [17:39:07] no, master latest everywhere, afaict [17:39:12] hah [17:39:19] Very odd [17:40:26] I was in the zone, making good progress on highlighting, when this happened. It's karma for being disrespectful towards oo-ui ;) [17:42:27] lol [17:42:32] Thankfully RC works without login [17:42:36] It's so annoying that Echo doesn't [17:42:51] (I mean, it's inherent in its functionality etc etc, but it makes testing a pain sometimes) [17:43:12] OK cool so you are working on highlighting, that's great [17:43:18] wait... [17:43:20] I just merged the AJAX patch [17:43:28] how do you enable RC without login? [17:43:33] Oh, lol [17:43:35] Good point [17:43:38] yeah, saw that, thanks [17:43:40] Well you can make it enabled by default [17:43:56] how? [17:44:14] $ cat vagrant/settings.d/07-rcfilters.php [17:44:15] $wgDefaultUserOptions['rcenhancedfilters'] = 1; [17:44:40] I did that and then forgot, I had just gotten used to the fact that I can test rcfilters without logging in [17:45:37] oh well, good to know, I lost a lot of time on this. Should have asked before. [17:48:52] So, speaking of the AJAX patch [17:49:08] I changed the commit message to no longer say that it makes the Show button behave differently [17:49:56] But I think I might work on getting the Show button (form submission, really) and the limit links and stuff hooked up to AJAX [18:03:35] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, and 2 others: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3013951 (10kaldari) p:05Triage>03Normal [18:23:10] stephanebisson: You may not be alone, login is broken in beta labs too [18:23:57] RoanKattouw: I am the canary in the coal mine, and I keep dying [18:24:10] [WJyzWQpEE4AAAHWfcdkAAAAE] 2017-02-09 18:22:17: Fatal exception of type "DBQueryError" [18:54:18] (03CR) 10Cenarium: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [19:01:54] (03CR) 10jerkins-bot: [V: 04-1] Notify users of multiple-revisions undos and assorted fixes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [19:08:54] (03PS6) 10Cenarium: Notify users of multiple-revisions undos and assorted fixes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [19:18:53] Getting lunch and may take a break after that [19:30:28] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3014279 (10happy5214) It's a shame this project wasn't completed last year. I found out over the winter break that I was privately advise... [19:39:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Release strategy for RC page improvements: what wikis get the new features when? - https://phabricator.wikimedia.org/T150715#3014314 (10Halfak) Not that we're just about to finish {T151611} so that'll add a wiki to t... [19:44:54] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 10MediaWiki-extensions-LoginNotify, and 2 others: Enable Echo on loginwiki - https://phabricator.wikimedia.org/T157105#3014326 (10Bawolff) I have no objections for what its worth, although I'm not sure what the details are behind it not being... [20:33:49] 06Collaboration-Team-Triage, 10Flow: Flow: Indentation model is unclear - https://phabricator.wikimedia.org/T94924#1176106 (10jmatazzoni) =[I copied this thread over from emails sent around 2/8/17]= **** ==Pau writes== The threaded vs. flat model is a recurring topic about discussion systems in general, and... [21:22:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-extensions-PageCuration: Remove the 250 character limit from messages sent through the Page Curation Tool - https://phabricator.wikimedia.org/T157056#3014793 (10Mattflaschen-WMF) There is a DB field that looks relevant, but luckily it is un... [21:39:05] (03PS1) 10Mattflaschen: Drop unused ptrl_comment field [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/336903 (https://phabricator.wikimedia.org/T157056) [21:43:58] (03CR) 10Catrope: [C: 032] Drop unused ptrl_comment field [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/336903 (https://phabricator.wikimedia.org/T157056) (owner: 10Mattflaschen) [21:54:21] (03Merged) 10jenkins-bot: Drop unused ptrl_comment field [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/336903 (https://phabricator.wikimedia.org/T157056) (owner: 10Mattflaschen) [22:30:14] Taking a break. [22:42:59] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: ?action=info incorrectly states that a new page is indexed when not - https://phabricator.wikimedia.org/T157747#3015151 (10Cenarium) [22:48:07] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Editing-Department, 10MediaWiki-Recent-changes, 07JavaScript: Make Special:RecentChanges auto-updating - https://phabricator.wikimedia.org/T7560#3015194 (10jmatazzoni)