[00:00:12] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), and 2 others: Workflow ID null for some user talk pages on gomwiki - https://phabricator.wikimedia.org/T154623#2918096 (10Mattflaschen-WMF) [00:02:27] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), and 2 others: Workflow ID null for some user talk pages on gomwiki - https://phabricator.wikimedia.org/T154623#2921821 (10Mattflaschen-WMF) [00:04:22] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), and 2 others: Workflow ID null for some user talk pages on gomwiki - https://phabricator.wikimedia.org/T154623#2918096 (10Mattflaschen-WMF) [00:04:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 3 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2921833 (10Mattflaschen-WMF) [00:15:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2921892 (10Mattflaschen-WMF) [00:18:05] RoanKattouw: https://phabricator.wikimedia.org/T72595 [00:18:33] RoanKattouw: https://phabricator.wikimedia.org/T150060 [00:29:57] etonkovidova: Create a file called 02-ores.php in your vagrant/settings.d directory and put this in it: [00:30:01] https://www.irccloud.com/pastebin/5PGEa7bZ/ [00:30:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2921968 (10Mattflaschen-WMF) [00:42:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2922062 (10Mattflaschen-WMF) [00:45:12] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, and 2 others: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2922068 (10jmatazzoni) In the scheme we've defined, Flow... [00:53:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2922102 (10jmatazzoni) [00:53:30] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 07Schema-change: Delete notifications that are disabled in preferences and maybe uninstalled/non-existent ones. - https://phabricator.wikimedia.org/T129727#2922103 (10jma... [00:53:39] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Preferentially purge read notifications before unread - https://phabricator.wikimedia.org/T124687#2922104 (10jmatazzoni) [00:53:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2922105 (10jmatazzoni) [00:53:59] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review, 07Performance: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#2922106 (10jmatazzoni) [00:54:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2922107 (10jmatazzoni) [00:58:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2922120 (10jmatazzoni) [00:59:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2922135 (10jmatazzoni) [01:09:42] 06Collaboration-Team-Triage, 10Notifications: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2901417 (10jmatazzoni) @Catrope, where do you want to put this? I have a note from our last Triage meeting that "Roan is attempting to reproduce-- will close if can’t. We’ll fix if he can." [01:14:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Adjust ORES levels for applications that use all of them simultaneously - https://phabricator.wikimedia.org/T153724#2922152 (10jmatazzoni) @Halfak, do you have an opinion about this? What do you think? [01:14:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Adjust ORES levels for applications that use all of them simultaneously - https://phabricator.wikimedia.org/T153724#2922153 (10jmatazzoni) a:03jmatazzoni [01:15:42] 06Collaboration-Team-Triage, 10Notifications: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2922157 (10Catrope) WFM locally, and not failing on Jenkins. Closing as invalid unless and until we can confirm that this problem exists outside of Reedy's laptop. [01:15:51] 06Collaboration-Team-Triage, 10Notifications: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2922158 (10Catrope) 05Open>03Invalid [01:16:53] 06Collaboration-Team-Triage, 10Notifications: Problem with marking mention notifications as read when visiting the originating page - https://phabricator.wikimedia.org/T154057#2922159 (10jmatazzoni) [01:17:41] 06Collaboration-Team-Triage: [minor-regression] Notification counter '99+' overlaps mw-echo-notifications-badge - https://phabricator.wikimedia.org/T153976#2922161 (10jmatazzoni) [01:18:45] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Editing-UX-Research: Editing-Collab Recent Changes phase 1 features findings deck - https://phabricator.wikimedia.org/T153778#2922163 (10jmatazzoni) 05Open>03Resolved [01:19:11] 06Collaboration-Team-Triage, 10Flow: Flow: usability of flow-timestamp-user-formatted label - https://phabricator.wikimedia.org/T153015#2922164 (10jmatazzoni) [01:20:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2922166 (10jmatazzoni) [01:21:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2922168 (10jmatazzoni) [01:22:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2922170 (10jmatazzoni) [01:23:49] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2922171 (10jmatazzoni) [01:25:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Wikimedia-Extension-setup: Add NewUserMessage to kabwiki, for Flow, if community agrees - https://phabricator.wikimedia.org/T145230#2922173 (10jmatazzoni) [01:25:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-ReviewStream: Instrument ReviewStream feed to monitor usage - https://phabricator.wikimedia.org/T143721#2922188 (10jmatazzoni) [01:26:31] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2922190 (10jmatazzoni) [01:27:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact communities for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146972#2922205 (10jmatazzoni) [01:28:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2922208 (10jmatazzoni) [01:29:17] 06Collaboration-Team-Triage, 10Notifications: [mobile-minor] Special:Notifications: Improve date format display - https://phabricator.wikimedia.org/T146288#2922211 (10jmatazzoni) [01:30:12] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Evaluate need to productize ERI model-training software - https://phabricator.wikimedia.org/T145568#2922213 (10jmatazzoni) 05Open>03Invalid [01:30:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Measure survival rate of new users who go through the constructive review process - https://phabricator.wikimedia.org/T143754#2922218 (10jmatazzoni) [01:31:39] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream: Graph usage of ReviewStream Feed - https://phabricator.wikimedia.org/T143729#2922222 (10jmatazzoni) [01:32:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Design: Explore ideas for Contribution review - https://phabricator.wikimedia.org/T138939#2922224 (10jmatazzoni) [01:39:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Adjust ORES levels for applications that use all of them simultaneously - https://phabricator.wikimedia.org/T153724#2922246 (10Halfak) Huggle has one purpose: Finding damage. I'd suggest we just drop the "very likely good"... [02:04:47] RoanKattouw, can you remind me how to rebase a commit on top of master? git rebase --onto master HEAD^ ? [02:05:30] mooeypoo: just "git rebase master" should do it [02:05:41] legoktm, but it's on top of another commit already [02:05:48] aren't I supposed to take it out of the "chain" first ? [02:05:49] and you don't want that commit in the stack? [02:06:03] no the stack is merged, I need to rebase now to fit whatever's in master [02:06:14] you could probably just cherry-pick it [02:06:19] O.o [02:06:21] git checkout master; git cherry-pick $sha1 [02:06:28] * mooeypoo looks at this suspiciously [02:06:37] I distinctly remember RoanKattouw having a 'git rebase' solution [02:06:38] which means "pick this individual patch and try to stick it on top of master" [02:06:58] probably! there are a billion ways to do git things. [02:07:01] legoktm, wait, would that affect the commits above too? [02:07:09] Yeah that's about equivalent to --onto [02:07:15] no, cherry-pick is just a single patch. [02:07:34] mooeypoo: If it's based on things that are merged, but they were merged without modifications, then git rebase master is safe. If they were merged with modifications, then you need --onto [02:07:36] right, I'll have to rebase the top ones anyways [02:07:52] RoanKattouw, you modified stuff, I believe, before merging [02:07:58] so I don't think that's safe [02:07:58] Oh that's right I did [02:08:13] So if you only have one unmerged commit in your stack, then git rebase --onto master HEAD^ [02:08:20] * mooeypoo nods [02:08:24] there we go, conflict in init [02:08:35] oh, it's probably the append/before() change [02:08:57] oh, no, it's the "learner" / experienced" fix [02:09:42] * mooeypoo ducks and cover [02:09:48] (PS8) Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [02:10:00] RoanKattouw, this is WIP bcause I'm faking the defaults for now [02:10:21] If you have more that one unmerged commit, it's git rebase --onto master HEAD~N where N is the number of unmerged commits [02:10:23] But since unit tests pass, if you're happy with the unit tests, I can just take off the "default: true" in the init and we can merge it [02:10:30] Cool [02:10:33] I'll look in a minute [02:10:37] * mooeypoo nods [02:10:50] not urgent, it's one of the stack. I htink I have the other "side" of the stack (the other stack, really) to fix up too [02:11:03] but holy crap that was more annoying than I anticipated [02:11:12] especially to define the unit tests from filters to parameters [02:11:15] not-nots. [02:11:55] I think I'm going to rename RC filters to "My Little Filter NotNots." [02:12:25] We can have superfans that keep track of new notnots, like for "my little pony" [02:13:32] My Little Pony's Bronies will be My Little Filter Notnot's "Naughties" [02:13:36] * mooeypoo has a solid plan here [02:14:28] Before you know it, we'll have international conferences where the main theme is !confetti [02:18:14] haha [02:18:22] Surely you mean !!!confetti [02:18:33] Yes, yes, casting. [02:18:45] The characters will just be little animated ! going around flipping things [02:19:07] Seriously, we have the new craze right here [02:19:07] Someone call Hollywood [02:20:10] And everyone else chasing after them yelling No Notnots! and having everyone get super confused about whether that actuall means yes or no. [02:20:52] AND EVERY SENTENCE REQUIRE DeMORGANING [02:29:45] hm, why did Jenkins fail the moo? because it doesn't like default being used in a JS object. [02:29:52] RoanKattouw, ^^ crap... :\ [02:30:14] No !!! was just a not-not joke [02:30:28] haha yup [02:30:45] You can't do default: because it looks too much like what you use in a switch statement [02:30:50] meh [02:30:51] You have to use 'default': [02:30:54] oh [02:30:58] ok [02:31:01] I do think you can use .default instead of ['default'] nowadays though? [02:31:27] yeah jshint is only complaining about my use of default: true in the JS object in init [02:31:44] I think I'll remove those anyways, since the unit tests actually test the behavior and the default:true in the init is just faking it so I can test it in the interface [02:31:59] since the interface I have there doesn't actually have config options yet [02:32:16] When it's generated JSON it'll be "default": true anyway [02:32:24] yeah [02:32:38] But I might as well take it off .. I can then take off the WIP [02:33:04] we just need to make sure the unit tests cover all cases we think of [02:33:07] With getFiltersFromParameters since that one uses defaults [02:34:30] hm, I should probably add some explicit default unit tests [02:34:33] and tests for reverting to defaults [02:44:53] OK, I'll do these tests tomorrow. [02:45:00] Off for the evening. See you tomorrow [02:51:02] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-TranslationNotifications: Use server-side MessagePoster in TranslationNotifications - https://phabricator.wikimedia.org/T154736#2922333 (10Mattflaschen-WMF) [02:52:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#1931581 (10Mattflaschen-WMF) [02:54:06] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-TranslationNotifications: Use server-side MessagePoster in TranslationNotifications to fix Flow - https://phabricator.wikimedia.org/T154736#2922350 (10Mattflaschen-WMF) [02:56:01] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-TranslationNotifications: Use server-side MessagePoster in TranslationNotifications to fix Flow - https://phabricator.wikimedia.org/T154736#2922333 (10Mattflaschen-WMF) [02:57:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2922357 (10Mattflaschen-WMF) They are all corrupt empty pages, with the same symptoms as {T154623}, just a different extension doing the post... [02:58:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2922361 (10Mattflaschen-WMF) 05Open>03Resolved [02:58:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922362 (10Mattflaschen-WMF) [02:58:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Workflow ID null for some user talk pages on mediawikiwiki - https://phabricator.wikimedia.org/T154724#2921892 (10Mattflaschen-WMF) 05Resolved>03Open [02:58:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2713647 (10Mattflaschen-WMF) [03:15:11] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2922368 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None Unassigning myself until this is reproducible via a UI click. [03:19:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922370 (10Mattflaschen-WMF) [03:29:31] RoanKattouw et al, so I fixed mediawikiwiki (and tracked it down to verify it won't happen again, it won't, and would also have been fixed by my content handler fix), and tracked down gomwiki (too many to do without a script (which I'm not planning to write until I hear otherwise), which is messy, but no user impact AFAICT). [03:29:47] RoanKattouw, dry run on all wikis just finished. [03:30:13] I'll review that, let the script fix a couple cases just in case, then run it everywhere. [04:09:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922445 (10Mattflaschen-WMF) Last pro... [04:10:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922448 (10Mattflaschen-WMF) [04:19:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922474 (10Mattflaschen-WMF) [04:23:13] Non-dry run in production running now. [04:23:35] (FlowFixInconsistentBoards.php) [04:54:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2922532 (10Mattflaschen-WMF) Producti... [05:08:19] 06Collaboration-Team-Triage, 10Flow: Two missing workflows - https://phabricator.wikimedia.org/T154741#2922547 (10Mattflaschen-WMF) [05:08:33] 06Collaboration-Team-Triage, 10Flow: Two missing workflows - https://phabricator.wikimedia.org/T154741#2922561 (10Mattflaschen-WMF) [05:41:11] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10UI-Standardization: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2922685 (10Volker_E) 05Open>03Resolved a:03Pginer-WMF I think we can resolve this… bold stays bold. [06:47:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Publication of the Flow Satisfaction Survey results including an analysis and raw da... - https://phabricator.wikimedia.org/T144730#2922696 [09:09:09] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922888 (10phuedx) [09:12:56] 06Collaboration-Team-Triage, 10Notifications, 07Design: Reduce usage of red icon in Echo (use other colors) - https://phabricator.wikimedia.org/T57359#2922900 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF >>! In T57359#2920893, @Volker_E wrote: > @Pginer-WMF Still an issue…? Thanks for catching this... [09:13:34] 06Collaboration-Team-Triage, 10Notifications, 07Design: Reduce usage of red icon in Echo (use other colors) - https://phabricator.wikimedia.org/T57359#2922907 (10Pginer-WMF) [09:28:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add an help icon and link to Special:RecentChanges dedicated to ERI's changes - https://phabricator.wikimedia.org/T147054#2922934 (10Pginer-WMF) >>! In T147054#2921042, @jmatazzoni wrote: > The problem as I see it is... [09:35:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Editing-Analysis: [REQUEST] Which features of RecentChanges are most often used? - https://phabricator.wikimedia.org/T141319#2922937 (10Pginer-WMF) If we have the results for this, it would be great to add them to the ti... [10:03:34] 06Collaboration-Team-Triage, 10Flow, 07Regression: Flow anonymous warning should be connected to the text area - https://phabricator.wikimedia.org/T154762#2923028 (10Pginer-WMF) [13:08:21] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 [13:16:48] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 [13:17:53] (03PS2) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 [13:27:14] 06Collaboration-Team-Triage, 10Notifications: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923332 (10Reedy) ```lines=10 $ php phpunit.php structure/ApiDocumentationTest.php #!/usr/bin/env php Using PHP 7.0.8-3ubuntu3 PHPUnit 4.8.31 by Sebastian Bergmann and contributors. .............. [13:28:06] RoanKattouw: ^ [13:28:07] lol [13:28:08] It is a bug [13:28:14] Patch incoming [13:28:15] 06Collaboration-Team-Triage, 10Notifications: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923337 (10Reedy) 05Invalid>03Open Aha. No. Reopening It's fine if you use the extension.json entry point. It's NOT if you use the php entry point, as you didn't update that...! [13:29:05] RoanKattouw: So that's broken on prod too [13:29:13] (03PS1) 10Reedy: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) [13:30:01] (03PS1) 10Reedy: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) [13:35:12] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923349 (10Reedy) Issue can be seen in prod on https://en.wikipedia.org/w/api.php?action=help&modules=echomarkread :) ``` list (no description) Separate values with |. Maxi... [13:35:22] (03CR) 10Reedy: [C: 032] Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [13:36:51] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923350 (10Reedy) p:05Triage>03High [13:47:38] (03Merged) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [13:50:40] (03CR) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:10:14] (03CR) 10Jforrester: [C: 032] Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:16:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Flow: Special:RC - have Flow respect 'hidenewpages' and 'hidepageedits' - https://phabricator.wikimedia.org/T154486#2923396 (10SBisson) [14:19:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2923411 (10SBisson) >>! In T150060#2922068, @jma... [14:22:07] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking: Build all front-end elements for the new RC Page user interface - https://phabricator.wikimedia.org/T144448#2923416 (10SBisson) [14:22:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#2923413 (10SBisson) 05Resolved>03Open a:05jmatazzoni>03SB... [14:24:53] (03Merged) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:26:03] (03CR) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:32:51] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [14:32:54] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [14:43:23] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [14:44:35] (03CR) 10jerkins-bot: [V: 04-1] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [14:54:40] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923491 (10Reedy) 05Open>03Resolved a:03Reedy Really we should also be doing T139800 and T139801 to fix this for WMF producti... [14:55:59] (03CR) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [16:27:08] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [16:37:31] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [16:50:21] 06Collaboration-Team-Triage, 10Notifications, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7), 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Echo Api Messages missing - https://phabricator.wikimedia.org/T154110#2923700 (10Jdforrester-WMF) [17:39:24] stephanebisson: for goodfaith enabling in vagrant - 'damaging' => true, 'goodfaith' => true, but then I create only oresm_name: goodfaith. Should I add 'damaging' also? [17:40:15] etonkovi_: 'damaging' should already be there. Is it not? [17:40:48] stephanebisson: nope! That's why I do not see goddfaith working? [17:42:14] etonkovidova: One thing at a time. Let's make sure 'damaging' works. 1) enable 'damaging' in config. 2) vagrant provision [17:42:56] etonkovidova: 3) create some revs and check that they are being scored (with fake data but using the proper mechanism) [17:44:36] stephanebisson: ok... [18:04:01] Reedy: Hah well that was stupid, thanks for fixing [18:07:26] (03CR) 10Catrope: [C: 032] "PS11 is a rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [18:08:25] (03CR) 10Catrope: [C: 032] Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:16:28] (03Merged) 10jenkins-bot: Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:16:46] (03CR) 10jenkins-bot: Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:23:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2924017 (10Miriya52) [18:23:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2773431 (10Miriya52) [18:37:10] Bug about namespace dropdown: https://phabricator.wikimedia.org/T72595 [18:39:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Flow: Special:RC - have 'hidepageedits' filter out all Flow changes - https://phabricator.wikimedia.org/T154486#2924065 (10SBisson) [18:44:23] Breaking for lunch/Spanish. [18:46:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#2924076 (10Stevietheman) Pardon my ignorance, but what does 'Blocked' mean? [18:51:28] (03PS1) 10Sbisson: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) [18:53:48] (03CR) 10Catrope: [C: 032] Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [19:01:26] (03Merged) 10jenkins-bot: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [19:01:46] (03CR) 10jenkins-bot: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [19:05:04] Going to take a break to get ready and go into the office, I should be there in about an hour [19:07:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2924115 (10jmatazzoni) The team met about this t... [19:07:46] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-CheckUser: Flow links formatting fail on Special:CheckUser - https://phabricator.wikimedia.org/T154796#2924116 (10SBisson) [19:09:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2924130 (10jmatazzoni) So, given the above, can... [19:13:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2924148 (10SBisson) >>! In T150060#2924130, @jma... [19:14:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2924151 (10jmatazzoni) [19:15:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'Type of change' filters - https://phabricator.wikimedia.org/T150060#2924150 (10jmatazzoni) 05Open>03Resolved [19:53:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add an help icon and link to Special:RecentChanges dedicated to ERI's changes - https://phabricator.wikimedia.org/T147054#2924279 (10jmatazzoni) @Pginer-WMF wrote: > When a user is in the Recent Changes page, they... [20:42:33] 06Collaboration-Team-Triage, 10Flow, 07Regression: Flow anonymous warning should be connected to the text area - https://phabricator.wikimedia.org/T154762#2923028 (10Catrope) Hmm, this is because the canNotEditWidget (for the message saying you cannot edit what you're trying to edit because you're blocked or... [20:54:32] (03PS1) 10Catrope: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) [21:00:29] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 07Regression: Flow anonymous warning should be connected to the text area - https://phabricator.wikimedia.org/T154762#2923028 (10Volker_E) There was related task T116573 closed, as I thought the message was not intended to be connected as that's not... [21:01:43] 06Collaboration-Team-Triage, 10Flow, 07Design: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#2924424 (10Catrope) 05Resolved>03declined Per T154762 the lack of a gap was deliberate, and has been restored. [21:03:42] 06Collaboration-Team-Triage, 10Flow, 07Design: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#2924431 (10Catrope) 05declined>03Open Hmm, I see the concern here was not just about the gap but also about the fact that there are touching boxes that have rounded corners. I'l... [21:45:06] hey folks. I'm wondering if there's a way to export/import a flow board. [21:45:20] Specifically, I'm looking at exporting a flow board from meta and importing it to mediawiki.org. [22:05:24] (03CR) 10VolkerE: [C: 032] CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:13:50] (03Merged) 10jenkins-bot: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:14:04] (03CR) 10jenkins-bot: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:15:49] 06Collaboration-Team-Triage, 10Flow: Make permalink more easily accessible for linking - https://phabricator.wikimedia.org/T154812#2924677 (10Halfak) [22:18:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/331038 (owner: 10L10n-bot) [22:51:06] Hmm Special:Export doesn't really work [22:51:38] matt_flaschen: Do you know if we have export/import for Flow boards per halfak's question above? [22:51:48] \o/ [22:52:29] * halfak waits with bated breath [22:53:13] He just left to go somewhere with non-crappy internet so it'll probably be a while [22:58:04] halfak, RoanKattouw, yes and maybe. [22:58:10] (The internet went back up right after I sent that. I'm still going home since it's off and on, but I'll reply here first). [22:58:22] The issue here is that a. I don't think we've ever tested importing Flow to a WMF wiki b. All the WMF workflows (except private wikis) are in one database, so I think we'd get key collisions. [22:58:48] Isn't mw.org separate? [22:58:50] So, it'll be a good test? [22:58:53] halfak, please file a task so we can follow up. [22:59:00] matt_flaschen, OK will do. [22:59:00] RoanKattouw, for Echo, not Flow (I keep forgetting, so I had to check). [22:59:06] hah [22:59:25] I was also going to say that magically solves the PK collision issue, but it doesn't. [22:59:37] Since it's not really separate. [22:59:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2924828 (10Halfak) FYI: PR is here: https://github.com/wik... [23:00:22] Also if all the workflows are in the same DB, then yes that would totally explode a normal import process, but could that be abused to do some sort of Frankenstein import where we just change which wiki a workflow is associated with? I know that's ugly and terrible, but I'm wondering what impediments there are to that in practice [23:05:57] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Export-or-Import: Migrate ORES_paper flow board from Meta to Mediawiki.org - https://phabricator.wikimedia.org/T154816#2924843 (10Halfak) [23:06:18] matt_flaschen, https://phabricator.wikimedia.org/T154816 [23:07:28] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Export-or-Import: Migrate ORES_paper flow board from Meta to Mediawiki.org - https://phabricator.wikimedia.org/T154816#2924859 (10Halfak) [23:07:33] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#663384 (10Halfak) [23:08:14] Thanks to both of you for your help [23:08:29] RoanKattouw, yeah, I thought about that. It would work, but mess up the meta one. This is a limitation of how low-level the import is (though it works well) that I didn't think of (we were thinking about "backup the wiki for right to fork", not "trans-wiki within WMF". [23:10:10] Right, yeah I understand it would break the meta page but that should be OK, we could delete it [23:10:19] Since the whole point is to move this board off of meta [23:11:05] Hmm I guess user attribution in history could get weird? Although if it's user name based that should be OK since we have SULF now [23:13:32] RoanKattouw, it's not unfortunately. [23:13:43] i guess we didn't think of this either. [23:15:32] What if we export, nuke all traces from the DB, and then import in the other wiki? [23:20:02] RoanKattouw, it would mess up the username, I think. We thought of this for LQT (it has an option to use the IP, though it's a hack not intended for production). [23:21:09] I'll continue on the task. [23:22:07] OK [23:22:11] Sorry for sidetracking into this [23:23:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2924965 (10Etonkovidova) Re-checked in vagrant with goodfa... [23:43:05] RoanKattouw, yeah, what I recommend is that we do it properly (going to outline that), but not now. [23:43:25] OK [23:53:15] matt_flaschen: 15:52:59 (PS1) Catrope: mediawiki.rcfilters: Add the remaining MW core filters [core] - https://gerrit.wikimedia.org/r/331094 (https://phabricator.wikimedia.org/T149452) [23:53:25] Those are all the JSON definitions and i18n messages for the core filters [23:53:50] I omitted the extension ones for now, and I omitted patrolling because that one is only sometimes included so it was too hard for a quick patch [23:58:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review: Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2925077 (10jmatazzoni) No one expects to get ORES scores f...