[00:00:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2891630 (10jm... [00:20:25] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2891650 (10jmataz... [00:20:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2891651 (10jmatazzoni) [00:20:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2891649 (10jmatazzoni) 05Open>03Resolved [00:21:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2891652 (10jmatazzoni) 05Open>03Resolved [00:24:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2891659 (10jmatazzoni) @Neil_P._Quinn_WMF, we are moving forward to create desi... [01:03:01] jmatazzoni_, is "tis task" written in the spirit of Christmas? Like 'tis the night before Christmas..." ? [01:05:05] 'tis possible, but what task are we discussing, praytell? [01:05:17] 'tis this https://phabricator.wikimedia.org/T144331 [01:05:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2891702 (10Mooeypoo) >>! In T144331#2888927, @jmatazzoni... [01:06:24] 'Twasn't. [01:06:39] 'twas amusing nonetheless. [01:06:40] :D [01:07:05] I almost answered in kind, too, but my carol-speak is not that good. [01:07:12] Although according to code review, I rock yoda. [01:08:03] jmatazzoni_, seriously, though -- the *current* status you're looking at with filter usage... if I add a field "betaFeatureUsed" that is eithre "true" or "false" (so you would be able to separate the stats by "old" and "new" usages) -- that should answer your need, right? [01:08:09] or am I missing another case here? [01:08:54] I'd think that would do it. We just want to be able to sort by whether someone is old or new RC. [01:10:32] * mooeypoo nods [01:10:48] jmatazzoni_, ok, we'll start with that, and if you see you're missing more data, we can continue to add logging [01:21:21] jmatazzoni_, added a patch for the logging in T144331, but it depends on the previous patches for the RC filter UI [01:21:21] T144331: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331 [01:21:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2891712 (10jmatazzoni) I had an idea for a small improvement to the design of the Active Filter Di... [01:24:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2891721 (10Mooeypoo) What would this look like when the filters are empty, @jmatazzoni ? Right n... [02:10:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2891796 (10jmatazzoni) >>! In T149391#2891721, @Mooeypoo wrote: > What would this look like when t... [02:24:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2891802 (10Halfak) A couple of changes `recall_at_precisio... [05:09:17] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools: Notify users when their user group membership is about to expire - https://phabricator.wikimedia.org/T153817#2892002 (10TTO) [07:50:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2892284 (10Pginer-WMF) [08:52:21] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Type of flow_ext_ref.ref_target incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#2892504 (10Aklapper) 05Open>03stalled @Subfader: Can you please answer the last question? [08:52:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2892506 (10Pginer-WMF) >>! In T149391#2891712, @jmatazzoni wrote: > I like the visual rhythm bette... [09:46:43] 06Collaboration-Team-Triage, 10Notifications, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Hacking Session: Learn to make new notification types - https://phabricator.wikimedia.org/T149246#2892600 (10Qgil) This session is a tutorial, and therefore it will benefit from a video... [09:58:55] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Language-converter, 07Chinese-Sites: Flow: Automatic conversion between simplified and traditional Chinese of zhwiki that are not supported in Flow pages - https://phabricator.wikimedia.org/T95502#2892662 (10Aklapper) [10:18:44] (03CR) 10Catrope: [C: 032] Adjust unread counter position based on length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328404 (https://phabricator.wikimedia.org/T142454) (owner: 10Sbisson) [10:29:00] (03Merged) 10jenkins-bot: Adjust unread counter position based on length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328404 (https://phabricator.wikimedia.org/T142454) (owner: 10Sbisson) [11:55:25] (03PS5) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [12:30:03] (03CR) 10Amire80: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 (owner: 10Amire80) [13:10:07] (03CR) 10Nikerabbit: [C: 032] Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 (owner: 10Amire80) [13:21:15] (03Merged) 10jenkins-bot: Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 (owner: 10Amire80) [14:44:03] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire - https://phabricator.wikimedia.org/T153817#2893451 (10MarcoAurelio) [15:17:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2893563 (10SBisso... [15:48:01] (03CR) 10Catrope: [C: 032] FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [15:59:23] (03Merged) 10jenkins-bot: FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [16:44:14] mooeypoo: I know you have other rebase worries, but at some point you should rebase your RC stack onto master. Currently the ORES extension breaks in combination with your change because it's not based on https://gerrit.wikimedia.org/r/#/c/323327/ [16:44:33] (This took me a while to figure out, and I ended up just rolling back ORES to an older state so Special:RC would stop crashing) [17:10:29] (03PS31) 10Etonkovidova: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [17:32:47] (03PS1) 10Sbisson: Fix generation of sample 'reverted' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328544 [17:40:26] (03CR) 10Catrope: [C: 032] Fix generation of sample 'reverted' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328544 (owner: 10Sbisson) [17:48:46] (03Merged) 10jenkins-bot: Fix generation of sample 'reverted' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328544 (owner: 10Sbisson) [17:59:38] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2894027 (10Trizek-WMF) [18:31:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2894081 (10Halfak) a:05Halfak>03SBisson [18:31:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2833743 (10Halfak) @SBisson, I hope you don't mind me assi... [18:32:14] o/ stephanebisson [18:32:33] Just wanted to say thanks for pushing on https://phabricator.wikimedia.org/T151970 [18:32:33] :) [18:32:52] I'll be ready to give you a quick review when you submit :) [18:34:33] o/ mooeypoo :) [18:36:08] halfak: thanks for your assistance [18:37:28] halfak: I'm trying to figure out if we're handling the probability and it's false vs. the probabiity that it's true correctly. [18:37:39] (in the filtering code) [18:38:25] stephanebisson, one note -- the output of test stats will change slightly in an upcoming version of ORES. [18:38:47] See https://ores.wmflabs.org/v2/scores/enwiki/damaging/?model_info=test_stats [18:38:58] This is the labs instance of ORES and it is running the recent version. [18:39:04] halfak: For the editquality repo, is it just the Makefile or do we have "hook it up" with the models somehow? [18:39:05] Note that "true" and "false" have their own stats. [18:39:29] stephanebisson, not sure what you mean by "hook it up" [18:40:46] halfak: Is it enough to define `damaging_statistics` in the Makefile? [18:41:27] stephanebisson, oh! Gotcha. Yeah, you'll need to *use* the damaging statistics variable in all the model-building calls. [18:42:58] halfak: So everywhere that $(test_statistics) is used, I have to replace by the new variable (for the right model) [18:43:30] stephanebisson, right. And you'll want to do it for reverted_statistics too. [18:43:50] One Q though, I haven't seen a good justification for why we have slightly different thresholds for damaging and goodfaith. [18:44:08] It's cluttering and complicating to have different test stats. [18:44:18] halfak: Should we just keep the current stats for 'reverted', it's not a test we plan on using on the RC page? [18:44:27] I'd like to push back on the change on those grounds, which means, I think we need jmatazzoni_ to make a product decision [18:44:56] stephanebisson, sure, but then we'll need to fix the names in the code as "test_statistics" is no longer at the right level. [18:45:00] halfak: About the different thresholds: that's a jmatazzoni_ conversation [18:45:12] stephanebisson, I think we're blocked on that conversation. [18:45:20] I brought this up in phab before [18:45:21] * halfak digas [18:46:58] See https://phabricator.wikimedia.org/T151970#2843287 [18:47:21] "If this makes implementation and maintenance easier, it seems a reasonable compromise. [...] I don't see a problem." [18:47:26] Looks like we can make this easier [18:47:42] My suggested compromises are documented here: https://phabricator.wikimedia.org/T151970#2833839 [18:48:05] You could just implement those precision thresholds in "test_statistics" and not worry about having to update the rest of the file. [18:49:58] halfak: so you're suggesting 0.15, 0.45, 0.98 as the levels for both tests? [18:50:35] Right [18:50:50] Oh wait. We need a .90 threshold too. Hmm [18:51:04] .98 is ridiculous IMO [18:51:11] We're gonne get like 2% recall [18:51:24] (For damage) [18:51:45] So I think we should do 4 thresholds. [18:51:53] .15, .45, .90, .98 [18:52:22] Ahh yeah, that one didn't need compromise, so I didn't list it out. [18:52:23] Very Likely Have Problems recall_at_precision(.90) (True) [18:52:25] ^ "" [18:53:26] And the "true" at the end means were using the threshold from the "true" section of the test stats report, right? [18:55:31] halfak: What's the timeframe on the new stats format? Regardless of the stats configuration, I should probably implement the fetching of the thresholds using the new format. [18:56:01] stephanebisson, it's demand based. If you want the new format deployed right after the holidays, we can do that [18:56:11] In the meantime, you'll be able to test againsts wmflabs [18:59:34] halfak: Sounds good. Here's what I'm gonna do: 1) update 'test_statistics' with the thresholds we talked about just now. 2) fetch the thresholds using the new format in betalabs and 3) When that works, talk about deployement. We just have to make sure it's deployed before the new RC page on each wiki. [19:00:02] +1 [19:00:08] thanks again [19:00:22] no prob. Thank you :) [19:04:17] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow should respect uselang - https://phabricator.wikimedia.org/T128505#2894189 (10Aklapper) Duplicate of T95204 (though that one is explicitly about error message) or not? [19:06:10] halfak: https://github.com/wiki-ai/editquality/pull/54 [20:39:37] brb, going to the office [21:28:46] 06Collaboration-Team-Triage, 10MediaWiki-ContentHandler, 07ArchCom-Has-shepherd, 10ArchCom-RfC (ArchCom-Approved), and 2 others: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2894723 (10daniel) [23:00:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2894879 (10Etonkovidova) - After c... [23:04:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2894883 (10jmatazzoni) [23:24:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2894938 (10jmatazzoni) [23:49:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2895109 (10jmatazzoni) @Etonkovido... [23:50:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Automated contribution' filters - https://phabricator.wikimedia.org/T149862#2766767 (10Et... [23:51:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2895119 (10jmatazzoni) [23:51:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'Automated contribution' filters - https://phabricator.wikimedia.org/T149862#2895118 (10jm...