[00:29:52] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2888758 (10Kudpung) OK. So I can edit the texts in the js for less clutter? Is is posible to put Wikilinks... [01:50:49] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2888891 (10jmatazzoni) [01:51:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2773431 (10jmatazzoni) @srishakatux, FYI, this is reformatted as requested. [02:14:53] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2888927 (10jmatazzoni) @Catrope and @Mooeypoo, tis task,... [07:24:16] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2889215 (10matmarex) Huh, that's actually... [07:47:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2889253 (10Pginer-WMF) >>! In T153284#2888491, @jmatazzoni wrote: > So, @Pginer-w... [08:48:59] (03CR) 10jerkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [08:58:52] 06Collaboration-Team-Triage, 10Notifications: Cross-wiki echo notifications not marked as read on mobile - https://phabricator.wikimedia.org/T153629#2889339 (10Catrope) For completeness: the `?markasread=NNN` parameter only works when you are logged in as the correct user on the target wiki. Otherwise you'd be... [09:01:47] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2882776 (10Catrope) >>! In T153506#2889215... [09:21:04] (03CR) 10jerkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [11:48:49] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 05Goal: Help to define next steps concerning Flow development, based on the Flow Satisfaction Survey - https://phabricator.wikimedia.org/T137796#2379110 (10Trizek-WMF) [11:49:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact communities for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146972#2676532 (10Trizek-WMF) [11:49:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) [14:27:04] (03CR) 10Sbisson: "recheck" [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [14:41:26] (03CR) 10Sbisson: [C: 032] Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [14:41:39] (03CR) 10Catrope: "We no longer register the flow-thank notification when Flow is not installed: https://gerrit.wikimedia.org/r/#/c/319772/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 (owner: 10Catrope) [14:50:20] (03PS4) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [14:50:46] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [14:51:39] (03PS5) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [14:51:50] (03PS6) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [14:52:37] (03Merged) 10jenkins-bot: Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [14:56:25] 06Collaboration-Team-Triage, 10Thanks, 07Jenkins: Jenkins ends with an unrelated error - https://phabricator.wikimedia.org/T153755#2889972 (10Huji) [14:56:42] 06Collaboration-Team-Triage, 10Thanks, 07Jenkins: Jenkins ends with a Thanks related error - https://phabricator.wikimedia.org/T153755#2889985 (10Huji) [14:58:03] 06Collaboration-Team-Triage, 10Thanks, 07Jenkins: Jenkins ends with a Thanks related error - https://phabricator.wikimedia.org/T153755#2889989 (10Catrope) [14:58:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#2889992 (10Catrope) [14:58:08] 06Collaboration-Team-Triage, 10Thanks, 07Jenkins: Jenkins ends with a Thanks related error - https://phabricator.wikimedia.org/T153755#2889972 (10Catrope) [14:58:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#2830727 (10Catrope) [15:00:51] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [15:03:32] (03PS7) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [15:22:12] (03CR) 10Sbisson: [C: 032] ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [15:32:03] (03CR) 10jerkins-bot: [V: 04-1] ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [15:32:06] (03CR) 10jerkins-bot: [V: 04-1] ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [15:55:42] (03CR) 10Sbisson: [C: 032] Always use plaintextParams() with getContentSnippet() to prevent double-parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/328166 (https://phabricator.wikimedia.org/T153605) (owner: 10Catrope) [16:07:22] (03CR) 10jerkins-bot: [V: 04-1] Always use plaintextParams() with getContentSnippet() to prevent double-parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/328166 (https://phabricator.wikimedia.org/T153605) (owner: 10Catrope) [16:14:15] 06Collaboration-Team-Triage, 10Notifications, 10Social-Tools, 10SocialProfile, 13Patch-For-Review: Echo internal error - https://phabricator.wikimedia.org/T153555#2890192 (10Innosflew) Okay, after the change 328165 was merged I updated the SocialProfile extension to the latest version using git pull and... [16:28:54] 06Collaboration-Team-Triage, 10Notifications, 10Social-Tools, 10SocialProfile, 13Patch-For-Review: Echo internal error - https://phabricator.wikimedia.org/T153555#2890214 (10Catrope) 05Open>03Resolved a:03Catrope [16:39:50] (03CR) 10Catrope: [C: 032] Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 (owner: 10Amire80) [16:48:54] (03CR) 10Catrope: "(1 comment)" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [16:49:43] (03PS4) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [16:49:50] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [16:51:32] (03CR) 10Catrope: "I decided to skip both this removal and the event_timestamp if sqlite is used, because dropping columns doesn't affect functionality, and " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [16:52:47] (03CR) 10jerkins-bot: [V: 04-1] Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 (owner: 10Amire80) [16:53:25] (03PS5) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [16:54:05] 06Collaboration-Team-Triage, 10Notifications, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Hacking Session: Learn to make new notification types - https://phabricator.wikimedia.org/T149246#2890287 (10jmatazzoni) [16:54:07] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2890288 (10Volker_E) @Catrope @matmarex No... [16:54:28] (03PS6) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [16:54:33] 06Collaboration-Team-Triage, 10Notifications, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Hacking Session: Learn to make new notification types - https://phabricator.wikimedia.org/T149246#2746503 (10jmatazzoni) @srishakatux, formatting complete. [17:03:45] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2890313 (10jmatazzoni) [17:04:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10jmatazzoni) Icon and body text updated in Description form, above. [17:16:39] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2890376 (10Volker_E) In a side-note, I see... [17:17:17] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo's "You have new messages" fails WCAG AAA contrast guidelines and the colors are nasty - https://phabricator.wikimedia.org/T153506#2890379 (10Volker_E) [17:36:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2890398 (10SBisson) I'm looking at implementing the change... [17:57:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2890495 (10Catrope) [17:58:40] 06Collaboration-Team-Triage, 10Notifications, 10Social-Tools, 10SocialProfile: Echo internal error - https://phabricator.wikimedia.org/T153555#2890511 (10matej_suchanek) [18:43:34] (03PS1) 10Sbisson: Adjust unread counter position based on length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328404 (https://phabricator.wikimedia.org/T142454) [18:49:05] 06Collaboration-Team-Triage, 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2890619 (10SBisson) a:03SBisson [18:49:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2535636 (10SBisson) [19:03:23] (03Merged) 10jenkins-bot: Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [19:04:24] :O finally [19:05:43] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review: Reverts with the API don't notify users anymore - https://phabricator.wikimedia.org/T153567#2890676 (10jmatazzoni) [19:11:19] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Editing-UX-Research: Editing-Collab Recent Changes phase 1 features findings deck - https://phabricator.wikimedia.org/T153778#2890709 (10dchen) [19:27:47] RoanKattouw, sanity-brain-check --- not-"every" === "any" ... right? [19:28:10] so, not-every parameter is 1 is equivalent to "any" param is 0 [19:29:37] Not every = any not [19:29:39] So yes [19:30:03] thx [19:30:07] confusing as hell [19:30:07] (Assuming 0 and 1 are the only possible values) [19:30:24] In that type of group, yes [19:30:43] "send_unselected_if_any" assumes params with 0 or 1 values [19:31:02] the other group type has string values or "all" [19:33:59] RoanKattouw, meh, rebasing this will be a nightmare [19:34:07] I mean the other stuff above [19:36:50] Yeah that'll be annoying in places [19:38:34] RoanKattouw, what's the best way to document the structure of the return Object in getFilterGroups ? [19:38:45] @return {Object} Filter groups. The structure is ........ [19:38:47] or ...? [19:39:06] is there something like @return {string} group.name [19:39:07] etc [19:39:08] ? [19:39:34] What is the structure? [19:39:48] { groupname: { name: string, filters: array, etc } } ? [19:40:14] name, type, later also exclusion_rule [19:40:32] I'm starting to wonder if it deserves its own data structure.. but I think not yet [19:40:43] maybe in the future if we keep adding definitions to it [19:40:45] Right, but I mean it's { groupname1: { data }, groupname2: { data, ... } right? [19:41:09] yeah groupname: { type: xxx, name: yyy, filters: [] ... } [19:42:24] Hmm I don't know of a structured way to document that in jsduck :/ [19:42:34] ok I'll just put it up in the description, then [19:43:31] Yeah [19:43:34] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/328166 (https://phabricator.wikimedia.org/T153605) (owner: 10Catrope) [19:43:53] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [19:47:03] RoanKattouw, ha, you commented about my "anySelected=true" loop that it could actually be "some()" [19:47:07] ... shouldn't it be any() ? [19:47:07] :D [19:47:20] They mean the same [19:47:31] yeah but I called the variable "*any*Selected" [19:47:33] But because English is a weird language, one of them is only used in a negative sense [19:47:36] so I found the recommendation funny [19:47:58] actually that's a good point.. what's the difference? [19:48:10] some returns true if any is true... any returns the same. [19:48:12] what../ [19:48:42] The difference between some and any is only linguistic/grammatical [19:48:48] That's why there's a .some() but not an .any( [19:49:31] oh, crap, there is no any() [19:49:31] "Can I have some peanuts?" "No, we don't have any peanuts." "Do you have any other kinds of nuts?" [19:49:34] why did I remember any() [19:49:41] Because I often mistake that as well [19:49:49] I think there may be an any() in a promise library somewhere [19:49:55] oh! [19:50:13] So I may even have said that you should use any() when I meant some(), because I also keep forgetting which one exists and which one doesn't [19:50:30] Bluebird [19:50:33] npm... that's where [19:50:50] This would be easier if English hadn't decided that this was the right place to put a grammatical shibboleth [19:51:00] ha [19:51:20] I love how you used that word in a point about English grammar [19:53:02] RoanKattouw, btw... the whole thing about "fix parameters" and the "invalid" thing is a failsafe for the case where the system gets an invalid URL param [19:53:11] but if we talk about *always* fixing it in the back end, that might not be needed anymore [19:53:31] I am not against leaving it in as a failsafe until we know for sure that the backend correctly fixes everything, though [19:53:35] Stephane has a WIP patch that does... something [19:53:41] in the backend [19:53:59] yeah I'm a little concerned about making sure we cover all the bsaes, so I don't see a bad thing about keeping *some* defensive measure in the UI [19:54:21] but (a) We don't have to (we usually don't do defensive) and (b) if we do, we could take that part off later [19:58:57] RoanKattouw, also, is there a practical difference in LESS (or css) between stating #ffffff and #fff ? They're the same... is it just style issue or is there another reason? [19:59:06] I can't find any place that states they're different [19:59:10] No difference, just style [20:01:13] ok, RoanKattouw, also, can we leave the color-questions (what to use and which to put in less vars) to a later commit? I took the colors from the prototype, but some are *slightly* off our palette. Pau will have to state which to use where, and I don't want to hold off this commit for that. [20:01:26] Sure [20:01:36] Can you copy them to the/a task? [20:01:51] I am adding TODO comments [20:02:39] OK [20:14:21] (03CR) 10Sbisson: [C: 032] Always use plaintextParams() with getContentSnippet() to prevent double-parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/328166 (https://phabricator.wikimedia.org/T153605) (owner: 10Catrope) [20:14:39] (03CR) 10Sbisson: [C: 032] ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [20:19:31] ok, finished fixing things up, now running qunit tests [20:21:49] RoanKattouw, rofl "Uncaught TypeError: this.groups[groupName].filters.any is not a function" [20:26:07] (03Merged) 10jenkins-bot: Always use plaintextParams() with getContentSnippet() to prevent double-parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/328166 (https://phabricator.wikimedia.org/T153605) (owner: 10Catrope) [20:27:41] (03CR) 10jerkins-bot: [V: 04-1] ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [20:27:44] (03CR) 10jerkins-bot: [V: 04-1] ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [20:31:14] mooeypoo: Well that was waiting to happen [21:08:28] stephanebisson: mooeypoo: could please take a look at https://phabricator.wikimedia.org/T153792 ? I filed it for Parsoid team, not too sure. Everybody else seems to be out ... [21:09:06] etonkovidova: looking at it now [21:09:16] stephanebisson: thx! [21:09:57] stephanebisson: the issue does not affect Flow VE. And nothing is in the Console. [21:23:35] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 06Community-Tech: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2891126 (10DannyH) [21:53:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2766516 (10Etonko... [22:39:41] aaaaaaaaaaa, code. [22:39:43] That is all. [23:58:45] what the... model.parameters[ filterItem.getName() ] = 0; how is !model.parameters[ filterItem.getName() ] give me "false". It's *flipped*... [23:59:13] oh... it's a string [23:59:16] "0" [23:59:20] * mooeypoo curses