[00:00:31] It is SWAT time though so getting that done should be easy [00:03:27] RoanKattouw, wait, you could put the token in GET until now? [00:03:40] (03Merged) 10jenkins-bot: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) (owner: 1020after4) [00:03:40] RoanKattouw, I thought if a module required POSTing everything required POSTing... [00:03:51] Though I can see how that wouldn't be true in reality, thinking about the WebRequest class. [00:04:23] Until a few months ago yes [00:04:27] The core patch is from Sept/Oct or something [00:04:34] You could do POST /w/api.php?token=foobar [00:05:10] And presumably all the parameters, but that's particularly problematic. [00:05:31] Also I should complain to Brad that that check doesn't turn off if $wgDebugAPI = true; , which makes the "you can GET when you should POST" feature of $wgDebugAPI a bit useless since most POST-only modules require a token [00:07:12] BTW also see the patch on top of it ( https://gerrit.wikimedia.org/r/327302 ) , Aaron's +2ed it already but you might wanna glance at it for context [00:07:33] That'll hopefully knock out all the "Expectation not met in ApiMain" log noise that Flow is producing [00:10:58] 06Collaboration-Team-Triage, 10Flow, 10Pywikibot-Flow, 13Patch-For-Review: Investigate write mode flag cleanup for Flow API modules - https://phabricator.wikimedia.org/T120543#2874930 (10Mattflaschen-WMF) https://gerrit.wikimedia.org/r/327302 should be helpful for Pywikibot-Flow. I think there was some di... [00:11:08] RoanKattouw, cool. I think that will make the pywikibot people happy, too. [00:11:17] How os? [00:11:53] action=help and action=paraminfo already reported mustBePosted-ness correctly for each submodule [00:12:06] s/mustBePosted/isWriteMode/ [00:12:17] Okay, then either I'm misremembering, or the issue was they weren't using that. [00:12:25] hmm OK [00:12:35] I don't see how this affects anything client-facing at all [00:12:56] Cause we were also already enforcing submodules' mustBePosted and that was always the same as write mode [00:13:21] But then again I didn't realize we had an API submodule system in core until today [00:14:27] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Investigate write mode flag cleanup for Flow API modules - https://phabricator.wikimedia.org/T120543#2874933 (10Mattflaschen-WMF) [00:20:00] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Icons in Echo emails broken - https://phabricator.wikimedia.org/T153261#2874958 (10mmodell) 05Open>03Resolved image loads now: https://www.mediawiki.org/w/load.php?mod... [00:31:12] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2874971 (10Mattflaschen-WMF) [00:38:07] (03PS1) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) [00:53:05] Ugh, airplane wifi blocks port 22 [00:53:24] So I guess I could never have deployed from the plane [00:53:36] But this also means I can't update the deferred-changes labs instance [00:58:18] 06Collaboration-Team-Triage, 10Notifications, 10Challenge, 10Social-Tools: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2875010 (10SamanthaNguyen) Sorry about that, I have actually but I haven't gotten to fully adding it yet (I wanted to create this task before I forgot). I... [01:08:17] RoanKattouw: VPN? [01:08:20] or mosh? [01:08:31] I guess you can't mosh unless there's a public IP [01:09:31] Hmm right mosh uses a different potr [01:09:36] Unfortunately I don't have a VPN set up [01:10:09] I do have an EC2 instance that I accidentally left running (it's still dutifully monitoring CentralNotice's RL module every 5 mins) but I don't have any ways into it that don't involve port 22 [01:10:21] And I don't have anywhere that I have mosh set up [01:10:23] WMF VPN? [01:10:31] tools-login.wmflabs.org accepts mosh [01:10:59] but you probably don't want to key forward from tools to get into a labs server... [01:11:26] I don't have that set up either [01:11:26] ha! nice [01:11:26] Thanks for the tip [01:12:09] also, you said you got gertty to work? [01:12:19] I tried it again today and ran into https://storyboard.openstack.org/#!/story/2000830 [01:12:21] Yeah but only for extensions, I gave up on MW core [01:12:25] hmm [01:12:28] But it was also 11pm [01:12:34] what version / where did you install it from? [01:12:40] APT [01:12:52] Version 1.3.1 [01:13:06] Oh yeah I got that same bug [01:13:13] meh, RoanKattouw, help... in my stack trace, I have "mw.rcfilters.dm.FilterItem.toggleSelected" that has this.emit( item, isSelected, isActive ); <-- where isSelected=true and isActive=true [01:13:14] You have to set the URL to https://gerrit.wikimedia.org/r/ [01:13:17] With /r/ at th end [01:13:17] ohhh [01:13:29] then I go (up) in the trace to see the emitter, and after that, the place where the event is intercepted [01:13:36] at "mw.rcfilters.ui.FilterItemWidget.onModelUpdate" [01:13:45] mw.rcfilters.ui.FilterItemWidget.prototype.onModelUpdate = function ( isSelected, isActive ) { ... } [01:13:52] except now isSelected = true, and isActive = false [01:13:53] WTF [01:14:00] Where did item go? [01:14:18] sorry, the emit doesn't emit item [01:14:25] this.emit( 'update', isSelected, isActive ) [01:14:32] Oh right [01:14:58] If you go to the stack frame of emit(), i.e. one above the emit() call, you'll be able to check which values actually made it to emit() [01:14:59] the hell happened to isActive? :((( [01:15:11] As opposed to the current values of the local vars in the function that called emit() [01:15:20] oo.EventEmitter.emit (oojs.jquery.js?d40c1:775) <-- this is the item in the stack trace between the two above [01:15:27] Yeah [01:15:37] the "args" have 'true, false' [01:15:41] HOW [01:15:44] RoanKattouw: hmm, not working for me. I have https://paste.fedoraproject.org/506590/64535148/raw/ [01:16:34] RoanKattouw, could it be that what I see intercepted is a different event from a different item? No, right? The stack trace should be the same event propogating/intercepted [01:17:35] mooeypoo: Yes it should be the same, unless there is an (async) in between [01:17:39] I don't understand [01:17:44] there isn't [01:17:45] it's all sync [01:17:46] legoktm: I have the same URL but I have the path set to ~/vagrant [01:17:52] how the hell is it turning from true to false [01:18:16] Because the repo names are mediawiki/extensions/Foo.git [01:18:18] mooeypoo: And if you go to the stack level right below emit() and you inspect the values being fed to emit(), you see true and true? [01:18:31] hmm. I'm also using 1.4.0 [01:18:42] Then again that should just cause it to clone stuff in the wrong place [01:18:45] hmm, maybe downgrading to 1.3.1 will fix it [01:19:19] Also... was gertty presented at this past LCA that we went to, or was it the year before that? [01:19:20] RoanKattouw, yes [01:19:45] mooeypoo: That is very weird. If you select the emit() frame and type [].slice.apply( arguments ); , what do you see? [01:19:57] (into the console I mean) [01:20:50] VM11067:1 Uncaught SyntaxError: Invalid or unexpected token [01:20:50] at MwRcfiltersUiFilterItemWidget.mw.rcfilters.ui.FilterItemWidget.onModelUpdate [01:20:51] ... [01:21:22] but if I type 'arguments' I get [01:21:23] arguments [01:21:23] ["update", true, false] [01:21:28] ^^ AAAAA [01:21:32] how is it false! [01:22:14] WTF [01:22:14] Is the caller doing something weird with the variable that it's passing into emit() [01:22:14] Is it passing an expression into emit() [01:22:22] wait, I'm an idiot, I typed something else for that uncaught syntax error [01:22:23] sorry [01:22:27] Is there a = where there should be a ===, or is there a ++, or something crazy like that? [01:22:33] [].slice.apply( arguments ); results in [ "update", true, false ] [01:23:04] I had the copy/paste of the stack trace in the console text input ready to copy slices of it, I forgot when I added the [].slice thing [01:23:16] anyways, it's clearly true,false instead of true,true [01:23:18] how the hell [01:23:25] am I missing something in between the stack trace pieces?! [01:23:49] I'm putting a breakpoint on the this.emit( ) piece [01:23:53] i'll have to go through it [01:24:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2875046 (10Mattflaschen-WMF) Beta is done. I've scheduled a SWAT... [01:25:09] RoanKattouw: my username is "legoktm" not "Legoktm". -.- [01:25:20] So, unfortunately, as you may recall from that JS quiz, we can't rule out that emit dirties the third param, because function ( x, y, z ) { arguments[2] = 'foo'; return z; } returns 'foo' , and conversely function( x, y, z ) { z = 'foo'; return arguments[2]; } returns 'foo' as well [01:25:26] legoktm: Right, of coures [01:27:11] So we can't answer the question of "what parameters were passed to this function call originally" other than by putting a breakpoint at the function call [01:31:39] RoanKattouw: I tried subscribing to core...git is now using 100% of my CPU doing...something. [01:31:52] RoanKattouw, I think I know what's going on [01:31:58] Probably cloning core into ~/vagrant/mediawiki/core or something [01:32:02] though it would be crappy but maybe [01:32:11] ps ajxf | less /gerrit will tell you what's going on [01:32:29] I have two methods that emit the same event... this.toggleSelected() and this.toggleActive() and they are both emitting this.emit( 'update', this.selected, this.active ) [01:32:52] but if one doesn't change, it doesn't emit the event properly, so I think it may dirty up the values [01:33:16] I'm creating a replacement method, "updateState" that checks whethr to toggle the values and emits in a centralized place where both values are, for sure, updated. [01:33:19] Hmm, also, are you doing something like foo.setActive( true ); foo.setSelected( true ); ? [01:33:20] see if this works [01:33:23] yes [01:33:31] well, the other way around, but yes [01:33:37] Cause that'll emit the event twice, once with [ true, false ] and then the second time with [ true, true ] [01:33:38] RoanKattouw: sigh. [01:33:47] ~/projects/vagrant/mediawiki/mediawiki/core [01:33:54] lol [01:33:57] foo.setSelected( true ) -> leads to 'updateItem' event which leads to checking active states, so it leads to foo.setActive( true ) [01:34:15] When that happened I had to kill the git clone process and then its children got adopted so I had to kill those too [01:34:17] RoanKattouw, sure, but the SECOND time should be correct [01:34:21] And in some cases gertty hung and I had to kill it [01:34:25] the first emit should be --- wait [01:34:30] crap, no [01:34:33] Does the setter set? [01:34:39] the second time will run first and then go "back" to the first one [01:34:41] omg [01:34:44] * mooeypoo grunts [01:34:54] Oh, wait, they're nested inside each other? What? [01:35:02] they're not nested, exactly [01:35:07] but a little bit nested [01:35:08] nestish [01:35:18] one leads to the other [01:35:20] You have an object listening to its own events it sounds like? [01:35:26] no [01:35:41] clicking the checkbox leads to itemModel.setSelected( true ) [01:35:47] Or some external object listening to your object's update event for one property that then sets the other? [01:35:58] that emits itemModel.emit( 'update', this.selected, this.active ) [01:36:02] the viewmodel listens to that [01:36:18] OK, you know what [01:36:19] then it goes "ooh, I need to check if the status of the other filters in this group changed." [01:36:22] Why pass those values in at all [01:36:34] You probably have this.isActive() and this.isSelected() methods [01:36:40] so it does that... and if it does, then it goes "hey, anotherFilterModel.setActive( false )" or something [01:36:45] Just have the listener call those if it wants to know things about the state [01:36:50] which emits this.emit( 'update', this.selected, this.active ); [01:36:55] and we are back to that loop [01:36:59] That way you also don't have to extend the signature of the update event as you add more properties [01:37:01] hm, true [01:37:19] yeah it's not like an input where getValue may be different than the value emitted [01:37:24] Passing data into events sounds like a great idea at first but I've begun to believe that it's almost always a bad idea [01:37:40] Right, that's a good example of where it's useful [01:37:44] Event aggregation is another one [01:38:56] * mooeypoo nods [01:39:11] you need it if you care about the state at the moment the event was emitted [01:39:22] if all you care about is telling the widgets/whatever that their state changed, you should just pull the data [01:39:30] or you care if the data is expensive to pull, I guess [01:39:38] which isn't the case here at all, they're all booleans [01:50:31] WWOOOOO [01:50:32] it works [01:51:28] yay [01:52:56] (03PS1) 10Mattflaschen: FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) [01:53:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2875105 (10Mattflaschen-WMF) I made a mistake before with making... [01:56:55] (03CR) 10Legoktm: [] "Ping?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [02:01:51] (03CR) 10Catrope: [C: 032] Make 'flow-skip-summary' clearer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [02:02:06] thanks [02:02:32] RoanKattouw, ok, this is the WIP for the *simple* case https://gerrit.wikimedia.org/r/327419 [02:02:40] I'll work on the ores-type group case tomorrow [02:03:00] so far it seems to follow between the filter list and filter capsule display [02:03:01] legoktm: Sorry, things got a bit crazy post-Seattle [02:04:32] no worries [02:10:18] (03Merged) 10jenkins-bot: Make 'flow-skip-summary' clearer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [02:34:30] (03CR) 10Mattflaschen: [C: 04-1] FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [02:38:26] (03PS2) 10Mattflaschen: FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) [02:39:53] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2875142 (10Mattflaschen-WMF) https://gerrit.wikimedia.org/r/#/c/3... [02:41:48] Have a good night, everyone. [04:21:18] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled - https://phabricator.wikimedia.org/T54510#2875256 (10Catrope) This is what the notificati... [04:41:10] 06Collaboration-Team-Triage, 10Flow, 06Discovery, 06Maps (Kartographer): is not visible in Flow (blank frame) - https://phabricator.wikimedia.org/T140920#2875431 (10Yurik) [04:51:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875501 (10Catrope) [04:56:25] 06Collaboration-Team-Triage, 10Notifications, 07Tracking: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2875504 (10Catrope) [04:56:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875503 (10Catrope) [07:47:50] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Blocked-on-schema-change, and 2 others: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2875623 (10Marostegui) a:03Marostegui [07:59:43] 06Collaboration-Team-Triage, 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2875633 (10Pginer-WMF) @jmatazzoni, @Catrope, @SBisson, In case it was lost in the comments above, I'll mention it again: I'd prefer to fix th... [09:26:32] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2875732 (10Samwilson) a:03Samwilson @kaldari Okay, that makes sense. The deletion reasons that are currently... [11:42:34] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:51:09] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:02:18] (03PS24) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:05:00] (03CR) 10Zfilipin: [] "Elena, looks like you have forgot to commit tests/rspec/README.md." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:06:04] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled - https://phabricator.wikimedia.org/T54510#2876091 (10Pginer-WMF) >>! In T54510#2875256, @... [12:08:42] (03PS25) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:31:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876130 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > The generic "info" icon in the screens... [12:47:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876159 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > The first secondary link icon for auto... [12:57:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876195 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > Finally, I worry the wording might be... [12:59:11] (03CR) 10Hashar: [C: 031] "Already included in .6 ( wmf/1.29.0-wmf.6 )." [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [13:18:11] (03PS26) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:20:57] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:24:40] (03PS27) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:25:26] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:38:50] (03CR) 10Hashar: [C: 032] "In preparation of SWAT in 20 minutes." [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [13:57:13] (03Merged) 10jenkins-bot: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [14:40:14] (03PS28) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [14:41:19] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [14:43:08] 06Collaboration-Team-Triage, 10Flow, 07Easy: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#2876444 (10Aklapper) @pginer-wmf: This issue has been assigned to you more than a year ago. Could you please share a status update? Are you still working (or still... [14:43:21] 06Collaboration-Team-Triage, 10Flow, 07Easy, 07I18n: Flow error messages appear in a language different from the one set by uselang parameter - https://phabricator.wikimedia.org/T95204#2876446 (10Aklapper) @devirk: This issue has been assigned to you more than a year ago. Could you please share a status up... [14:48:29] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team, 07German-Community-Wishlist: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#826226 (10Sadads) Hi, I saw that this was supported as part of the 2016 Community Wishlist. I wanted to note that there are other applications o... [15:02:26] (03PS29) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:03:04] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:08:18] 06Collaboration-Team-Triage, 10Flow: Workflow ID apparently null for one page in officewiki - https://phabricator.wikimedia.org/T153320#2876532 (10Mattflaschen-WMF) [15:15:40] (03PS30) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:16:15] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:18:39] 06Collaboration-Team-Triage, 10Flow: Workflow ID apparently null for one page in officewiki - https://phabricator.wikimedia.org/T153320#2876580 (10Mattflaschen-WMF) ``` NOT ID: Archive talk:Restructure GD all team meetings NOT ID: Talk:Operations ``` Script I wrote to find this (based on FlowFixInconsistentBo... [15:25:57] 06Collaboration-Team-Triage, 10Flow: Workflow ID apparently null for one page in officewiki - https://phabricator.wikimedia.org/T153320#2876617 (10Mattflaschen-WMF) [15:28:25] 06Collaboration-Team-Triage, 10Flow: Workflow ID apparently null for one page in officewiki - https://phabricator.wikimedia.org/T153320#2876626 (10Mattflaschen-WMF) [15:38:52] 06Collaboration-Team-Triage, 10Flow: Workflow ID apparently null for two pages in officewiki - https://phabricator.wikimedia.org/T153320#2876653 (10Mattflaschen-WMF) [15:44:35] 06Collaboration-Team-Triage, 10Flow, 07Easy: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#2876666 (10Pginer-WMF) a:05Pginer-WMF>03None >>! In T103866#2876444, @Aklapper wrote: > @pginer-wmf: This issue has been assigned to you more than a year ago. C... [15:47:26] 06Collaboration-Team-Triage, 10Flow: Explore ideas for workflow support - https://phabricator.wikimedia.org/T103082#2876672 (10Pginer-WMF) a:05Pginer-WMF>03None [15:47:52] 06Collaboration-Team-Triage, 10Flow: Change the location of Flow's timestamps within posts - https://phabricator.wikimedia.org/T108096#2876675 (10Pginer-WMF) a:05Pginer-WMF>03None [15:49:27] 06Collaboration-Team-Triage, 10Flow, 07Design: Wikitext editing toolbar for Flow - https://phabricator.wikimedia.org/T78346#2876678 (10Pginer-WMF) a:05Pginer-WMF>03None [15:57:57] 06Collaboration-Team-Triage, 10Flow: Table of Contents/Search on phones - https://phabricator.wikimedia.org/T97375#2876696 (10Pginer-WMF) a:05Pginer-WMF>03None [16:10:10] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-CentralAuth, 13Patch-For-Review, 07Wikimedia-log-errors: Centralauth last deployment creating database contention on CentralAuthUser::saveSettings (Lock wait timeout exceeded; try restar... - https://phabricator.wikimedia.org/T139970#2876773 [16:29:35] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876964 (10jmatazzoni) i see a number of issues here: - First, we need to follow our own guidelines... [16:47:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877062 (10jmatazzoni) [17:56:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877382 (10Catrope) >>! In T153284#2876195, @Pginer-WMF wrote: >>>! In T153284#2875499, @Catrope wrote:... [18:54:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877718 (10Catrope) >>! In T153284#2876130, @Pginer-WMF wrote: > Regarding the icon, I think the centra... [19:45:30] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2877923 (10DannyH) 05Open>03Resolved a:03DannyH We're closing this ticket, because there won't be any more Community Tech work on this project. [19:52:18] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2877965 (10Halfak) @DannyH, is this "resolved" or "declined"? [19:59:00] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2877986 (10DannyH) Resolved, because the work was done by Max as {T128697} [20:02:51] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Security-Team: Send echo notification to user of how many failed logins there was since last successful login - https://phabricator.wikimedia.org/T122123#2878000 (10DannyH) [20:07:34] 06Collaboration-Team-Triage, 10Notifications, 06Security-Team: Send echo notification to user of how many failed logins there was since last successful login - https://phabricator.wikimedia.org/T122123#2878027 (10DannyH) [20:42:09] Breaking. Will get lunch and go into coworking space. [21:14:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878166 (10jmatazzoni) [21:14:22] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2878167 (10Halfak) Great! Thanks for the clarification. [21:15:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10jmatazzoni) [21:23:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878185 (10jmatazzoni) [21:25:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878187 (10jmatazzoni) [21:26:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10jmatazzoni) [21:44:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878281 (10Cenarium) >>! In T153284#2876964, @jmatazzoni wrote: > - Secondly, while a notification is... [21:50:53] 06Collaboration-Team-Triage, 10Notifications: New Notification Request Form (for use in requesting new notification types) - https://phabricator.wikimedia.org/T153364#2878326 (10jmatazzoni) [21:56:13] 06Collaboration-Team-Triage, 10Notifications: 'New Notification Request Form' (for use in requesting new notification types) - https://phabricator.wikimedia.org/T153364#2878358 (10jmatazzoni) [21:56:40] 06Collaboration-Team-Triage, 10Notifications: Copy of a blank 'New Notification Request Form' (for use in requesting new notification types) - https://phabricator.wikimedia.org/T153364#2878326 (10jmatazzoni) [21:59:18] 06Collaboration-Team-Triage, 10Notifications: Copy of a blank 'New Notification Request Form' (for use in requesting new notification types) - https://phabricator.wikimedia.org/T153364#2878365 (10jmatazzoni) [21:59:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878366 (10Cenarium) [22:02:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878375 (10Cenarium) >>! In T153284#2877718, @Catrope wrote: >>>! In T153284#2876130, @Pginer-WMF wrote... [22:14:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878452 (10jmatazzoni) Thanks for filling in the form @Cenarium! Very helpful. @Catrope, do you need mo... [22:41:54] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2773431 (10srishakatux) @jmatazzoni Hey! As developer summit is less than four weeks fr... [22:49:43] bd808, you around by any chance? [22:50:04] Two people trying to install vagrant sent me the *exact same failure screenshot* in the past couple of hours [22:50:28] I can't tell what it is, but I'm worried something happened to mw vagrant maybe? [22:50:55] bd808, "setup.sh" works well, ends with "You're all set! Simply run 'vagrant up' to boot your new environment." [22:51:36] but then "vagrant up" results in loading a few things and then "default: Error: Could not run: Could not find file /vagrant/puppet/manifests/site.pp" [22:51:45] matt_flaschen, bd808 ^ any help appreciated [22:51:59] kmuthu and another person both sent me the same error trying to install vagrant [22:52:02] mooeypoo: hmmm [22:52:22] that error sounds like their mounts aren't working [22:52:33] Yeah that's what I was thinking, but both the same exact thing? [22:52:41] the first thing I'd have them try is turning off NFS mounts [22:52:59] is there a documentation to how to do that? [22:53:05] vagrant config nfs_shares off [22:53:12] before vagrant up ? [22:53:15] I think it's documented on the mw.o page [22:53:17] yeah [22:53:20] yeah I'm looking [22:53:46] nfs is a pain in the ass in retrospect :/ [22:54:07] I turned it off for my vms months and months ago [22:56:30] ok I sent her an email, I'll see if that helps [22:56:37] kmuthu, you happen to be on IRC? [22:56:41] (save me an email! :P ) [22:59:07] I sent the email anyways [22:59:16] bd808, I'll let you know if/when I get answers about whether that worked [22:59:36] I know kmuthu uses mac, I'm not sure about the other, but probably... [23:00:05] mooeypoo: cool. One of the things that breaks NFS commonly is Linux with encrypted $HOME [23:00:18] os x usually works though [23:00:36] bd808, hm the "vagrant config nfs_shares off" should work for either OS, right? [23:00:42] yeah [23:00:56] I sent them both the command and the link to the nfs shut off, but that one in the docs seems to talk about Mac specifically [23:01:04] that makes things fall back to the built-in sharing that VirtualBox does [23:01:14] oh, wait, no, there's a debian/ubuntu right under it [23:01:41] ... I'm.... hoping.... the other doesn't use windows. Not sure how well vagrant works there? [23:01:58] We have a lot of Windows users actually [23:02:04] very common at hackathons [23:02:51] bd808, I still haven't managed to get it to work on my home PC... though, granted, I didn't really try that hard, but I keep getting bogged down with random stuff every time I tyr. [23:02:52] try* [23:03:03] I should just do it at some point and see where I get stuck [23:13:34] hm RoanKattouw how much of a weird thing is it to explicitly change the return value of a method (that had no return value before, and has no useful use for it) **just** for the sake of making unit tests easier? [23:13:58] as in, the method doesn't need a return value, but having a return value summarizing what it did helps with tests, instead of me then going "check each item separately" [23:13:59] ? [23:14:07] I mean, I could also do that [23:14:36] wait... hm, that actually might not be a good idea, it's recursive. [23:14:53] RoanKattouw, well, it's recursive because of events (which I think you're going to HATE, too, but that's a different issue) [23:29:44] OK that sounds to complicated for this late at night [23:30:14] mooeypoo: Maybe we can talk/hangout about it tomorrow [23:30:36] RoanKattouw, yes. Or I can wait for you to review it. [23:30:41] * mooeypoo muahas. [23:41:40] RoanKattouw, basically, it's doing the final tests: https://gerrit.wikimedia.org/r/#/c/327419/3/tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js [23:41:46] recursively <3 [23:51:55] ok I'm leaving to get to the office for the event [23:51:59] see you all tomorrow