[00:11:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2871328 (10jmatazzoni) [00:53:25] 06Collaboration-Team-Triage, 10Flow, 06Front-end-Standards-Group, 10MediaWiki-General-or-Unknown, and 5 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#2871484 (10Jdlrobson) [01:00:25] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2871503 (10jmatazzoni) [01:46:09] 06Collaboration-Team-Triage, 10Notifications: Cross-wiki Echo notification not shown on Meta - https://phabricator.wikimedia.org/T152916#2871550 (10Tgr) Uh, sorry, I should have checked that :( [02:08:43] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2871593 (10jmatazzoni) a:05jmatazzoni>03None [02:10:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2871598 (10jmatazzoni) [02:12:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) [07:01:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2871774 (10Pginer-WMF) >>! In T149385#2870310, @jmatazzoni wrote: > @Pginer-WMF @Trizek-WMF or anyone else, opinions?... [07:43:00] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2791502 (10Samwilson) I've attempted to write some documentation for the structure of the on-wiki configuration... [09:48:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2871978 (10Trizek-WMF) I was suggesting "Learner", because that's a term for a person (like Newcomer), more than "lea... [10:37:52] (03PS19) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:38:29] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:43:31] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:56:03] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:57:39] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872167 (10Pginer-WMF) [11:03:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872179 (10Pginer-WMF) [11:23:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872227 (10Pginer-WMF) [11:23:46] (03PS20) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:24:04] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:29:36] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:34:26] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:02:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872252 (10Pginer-WMF) [12:04:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2600312 (10Pginer-WMF) [12:08:46] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872272 (10Pginer-WMF) I added some details to the description, including the animated g... [12:51:08] (03PS21) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:51:26] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:58:19] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:01:36] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [14:29:50] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Blocked-on-schema-change, and 2 others: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2764089 (10Marostegui) I will take this ticket as I am about to finish another schema change tomorrow. However due to the xmas times, t... [14:36:25] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Blocked-on-schema-change, and 2 others: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2872571 (10Marostegui) Jaime pointed out that the tables normally quite small and he's totally right: ``` root@db1031:/srv/sqldata/flo... [15:43:24] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:50:06] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:56:26] (03PS22) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:57:08] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:03:30] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:13:59] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:14:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt-in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2872808 (10jmatazzoni) [16:15:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC page/ORES beta and educate them about its features - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) [16:42:38] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2872941 (10jmatazzoni) >>! In T149385#2871978, @Trizek-WMF wrote: > I was suggesting "Learner", because that's a term... [16:46:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2872948 (10Trizek-WMF) >>! In T149385#2872941, @jmatazzoni wrote: >>>! In T149385#2871978, @Trizek-WMF wrote: >> I wa... [17:01:05] (03PS23) 10Etonkovidova: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [17:10:29] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [17:29:19] 06Collaboration-Team-Triage, 10Flow: Improve how transactions work for board moves - https://phabricator.wikimedia.org/T128228#2873108 (10aaron) [17:29:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Availability, 13Patch-For-Review, 07Wikimedia-Multiple-active-datacenters: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2873106 (10aaron) 05Open>03Resolved >>! In T1... [17:44:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki not... - https://phabricator.wikimedia.org/T151389#2873136 [17:53:40] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2873154 (10kaldari) @Samwilson: Unlike Twinkle, PageTriage is only designed to facilitate new page patrolling, w... [18:11:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2873205 (10Mattflaschen-WMF) [19:23:53] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#2873531 (10jmatazzoni) 05Open>03Resolved [19:34:07] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2873578 (10jmatazzoni) I wrote: > If we think the terms are pretty standard, I'd be happy to include the technical u... [19:34:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki not... - https://phabricator.wikimedia.org/T151389#2873608 [19:36:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-PageCuration, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Special:NewPagesFeed incorrectly states "No Categories" when categories exist - https://phabricator.wikimedia.org/T147721#2873612 (10jmatazzoni) 05Open>03Resolved a:03j... [19:36:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review: double-check icon for "Mark group as read" button does not appear on mobile site - https://phabricator.wikimedia.org/T146706#2873614 (10jmatazzoni) 05Open>03Resolved [19:38:00] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2873660 (10jmatazzoni) 05Open>03Resolved [19:38:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2873665 (10jmatazzoni) 05Open>03Resolved [19:39:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07Wikimedia-log-errors: Flow fatal: Default format of 'topic-title-html' or 'topic-title-wikitext' can only be used to format topic titles. - https://phabricator.wikimedia.org/T149827#2873668 (10jmatazzoni) 05Open>03R... [19:40:00] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Array to string conversion from Flow when using scripts against officewiki - https://phabricator.wikimedia.org/T149579#2873685 (10jmatazzoni) 05Open>03Resolved [19:45:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2873717 (10Mattflaschen-WMF) >>! In T153011#2870149, @Catrope wrote: > @Mattflaschen-WMF didn't you tell me about this error at some point? Yeah, @k... [19:47:32] mooeypoo, let me know when you want to discuss the filter subset thing you raised (i.e. "very likely have problems" being a subset of "likely have problems", etc.) [19:48:26] matt_flaschen, there are actually 3 cases, I think, I'm trying to wrap my head around this behavior [19:52:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Design, 13Patch-For-Review: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2873752 (10jmatazzoni) 05Open>03Resolved [19:55:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter::format - https://phabricator.wikimedia.org/T148979#2873770 (10jmatazzoni) 05Open>03Resolved [19:56:59] stephanebisson, matt_flaschen so, I am going back and forth about where to decide about the "excluded" property. On one hand, it's strictly UI behavior, so I wanted to put it in the UI -- but the logic is potentially robust **and** it affects more than just one UI element - it affects the filter list/dropdown *and* the filter "capsule" bubbles at the top - each of those slightly differently... so then I think maybe put the [19:56:59] property "excluded" in dm.FilterItem, and have the view model toggle it. I am not 100% happy with the model doing something view-only, but then again, it *is* a viewmodel. [19:57:19] Any insight? Do you guys think it's okay to put this in the view model? It will make things easier in terms of centralizing the behavior [19:58:08] the widget will just need to ask the FilterItem if it's excluded or not (or listen to the 'update' event on the item to update itself) rather than implementing the logic either in 3 different widgets *or* in the wrapper widget that then grabs the "lower" 3 widgets [19:59:36] stephanebisson, matt_flaschen My instinct is to put this in the view model and let that handle the excluded logic, since it also goes by type of group and filters within the group... I just want to make sure I'm not messing up the MVC logic too much here, though. [20:00:31] o/ [20:00:34] Hey folks! [20:00:44] I saw some "fixes to ORES" reported in SoS. [20:00:50] stephanebisson, matt_flaschen also, sidenote, I am wondering if it should be called something else, like "muted" or something, but that's less important [20:00:51] What did ya'll fix? [20:02:31] mooeypoo: not sure what you are referring to by "excluded" [20:03:24] stephanebisson, https://phabricator.wikimedia.org/T149452 <-- see "Excluded Display States" [20:03:36] the "dimmed" items when you pick 2 complementary filters [20:03:47] halfak, stephanebisson did the last three at https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/ORES+status:merged . Sorry for not being precise with "fix", I just wanted to mention it quickly. [20:03:59] Looks like https://gerrit.wikimedia.org/r/325302 is a fix though. [20:04:15] Ahh! They are to the ORES review tool! [20:04:35] I was wondering why I didn't see any pull requests at https://github.com/wiki-ai/ores [20:04:48] halfak, right, sorry, the ORES client extension, not the backend logic. [20:05:06] Thanks for clarifying and thanks for the work and the reporting :) [20:06:48] mooeypoo: makes sense to live in a 'view model' [20:08:01] mooeypoo, no opinion on the frontend representation. I will have to figure out how to represent it in the backend though. [20:10:47] This behavior is confusing. [20:11:20] mooeypoo, you said there were three cases. Would it help to go over them? [20:11:42] 1. Implication. If I ask for "likely have problems", it implies I also want "very likely have problems". [20:12:12] mooeypoo, also I don't know the other cases, and I will need to soon. :) [20:14:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2873845 (10Mattflaschen-WMF) [20:14:48] Yeah I am trying to make sense of the prototype and explanation in that ticket [20:16:08] Oh, I see. I didn't realize the three cases were already listed. [20:17:54] matt_flaschen, I think that a direct "map" is best, imho? So, having default behavior being the "pair" thing (if the entire group is selected, all items are moot) but then for ores filters, etc, we define specific override. Ex, we can state group_exclusion_type: 'per_filter' for the gorup, and then per each filter, we do 'exclusion_list': [ 'a', 'b' ] [20:18:00] I think this is the most straight-forward way [20:18:13] we won't need to start using structured filters or something that the system then needs to deconstruct [20:18:22] we let the filter-definer give us the conditions [20:18:52] mooeypoo, yeah, actual nested filters (really nested in the data structure) doesn't seem necessary. [20:18:56] filterA: { exclusion_list: [ filterB, filterD ] }, filterB: { exclusion_list: [ filterC ] } [20:18:56] etc [20:19:29] mooeypoo, and maybe the ability to exclude/disable a whole group, which it asks for. [20:19:49] mooeypoo, stephanebisson, this should also affect https://gerrit.wikimedia.org/r/#/c/325567/5 . [20:20:02] Currently, those are listed explicitly, but they also apply here too so it should be pulled out. [20:20:03] I am calling the state in FilterItem 'moot'. The filter becomes moot if it is either canceled out by selecting whole groups (or another that excludes it) **or** it is moot when we don't have it selected BUT it has highlight [20:20:06] that sounds ok? [20:20:53] matt_flaschen, no, it shouldn't actually... the canceled out/ moot/whatever filters *should* go away when you reload [20:20:57] **unless** they have highlights [20:21:05] which the backend should treat differently anyways [20:21:06] mooeypoo, that's what I mean. [20:21:21] but that's what the fix does, no? [20:21:22] E.g. hidehumans & hidebots would hide everything, so it should be dropped. [20:21:32] oh oh [20:21:33] mooeypoo, yeah, but it's inlining it. See https://gerrit.wikimedia.org/r/#/c/325567/5/includes/specialpage/ChangesListSpecialPage.php . [20:21:36] It should be centralized. [20:21:39] right [20:21:45] yeesh [20:21:45] Because it's the same thing. [20:21:52] yeah [20:22:45] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#2830589 (10Mattflaschen-WMF) The data for this is the same as fo... [20:23:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2859076 (10Mattflaschen-WMF) [20:24:16] mooeypoo, I like moot when it really is actually moot, e.g. 'very likely have problems' is moot since we're including anything that even 'may have problems'. [20:24:55] matt_flaschen, yes [20:24:56] mooeypoo, I don't think 'show humans' is moot if you selected 'show bots', and definitely not the weird "Conflicts between Unregistered and the Experience filters" [20:24:56] tjat [20:25:08] that's a different issue, though [20:25:11] Those aren't moot, they're just not supported combinations. [20:26:07] mooeypoo, so I think I agree with 'moot' describing "selecting whole groups" or "don't have it selected BUT it has highlight" (which means nothing in that group is selected, right). [20:26:18] But not sure about "another that excludes it" [20:26:31] ok, look at the prototype itself... when you pick something from the group, the other items in the group become grey, to indicate they're not selected yet. Then, if you pick another from the group, if it's a dual-filter one, then the filters up top (the bubbles) are BOTH gray [20:26:33] they're both moot [20:26:47] same with highlighting without selecting [20:27:24] this is the moot state. The rest - the idea that the state isn't supported - is something we should figure out regardless. If we dont support a state, we should either *disable* the combination, or let the user do it and display no results [20:28:04] mooeypoo, I know what you mean about checking everything in a dual-filter, or highlighting something when nothing is checked. [20:28:20] what's the other state? [20:28:51] mooeypoo, I thought by "or another that excludes it" you were referring to (in part) "Conflicts between Unregistered and the Experience filters". [20:29:20] oh, I don't know that we're dealing with that in the UI [20:29:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow: Remove in-process Memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#2873918 (10jmatazzoni) 05Open>03Resolved [20:29:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Availability, 13Patch-For-Review, 07Wikimedia-Multiple-active-datacenters: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2873919 (10jmatazzoni) [20:29:24] or that we should, honestly. [20:29:47] mooeypoo, the spec says to. But at any rate, I was just saying I'm not sure the word 'moot' fits that case. [20:29:51] if a user explicitly chooses a set of illogical filters, we (a) don't always have a way to know this if filters also come from extensions and (b) aren't necessarily in a position to stop the user [20:29:51] T149452 [20:29:51] T149452: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452 [20:30:18] It's the 3rd case. [20:30:23] oh you're saying about #3 [20:30:25] meh [20:30:33] Yes, meh. [20:30:40] holy crap [20:30:53] how do we generalize this? We could have these cases also from extensions [20:31:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2873924 (10kaldari) I fixed the markblocked gadget on December 2nd, so that shouldn't be the cause. [20:31:35] mooeypoo, once we come up with a representation, it should work for all. [20:32:06] E.g. 'disablesGroup' => 'something'. [20:32:17] yeah, we need to figure out the generalization of these [20:32:20] It doesn't really matter whether something is defined in core alongside you, in an extension, or whatever. [20:32:28] #3 is messy though both from a user point of view and internally. [20:32:37] matt_flaschen, oh sure, but we need to come up with how to represent all the cases [20:32:58] we could theoretically stick to filters, just have one filter reference another [20:33:26] so filter1group1: { excluded_list: [ filter3group2, filter2group2, filter1group2 ] } [20:33:36] mooeypoo, except I think userExpLevel is supposed to vary per-wiki, so we may want the ability to disable a whole group. [20:33:38] we do this for Echo sometimes [20:34:09] if the number of levels vary. stephanebisson, do you remember what was decided on how userExpLevel is configurable? [20:34:16] so, also, it doesn't **disable** it, right? It just greys it out and ignores it [20:34:22] which, btw, is a weird UI on its own, but ok [20:34:30] What's the difference? [20:34:38] gray out + ignore vs. disable [20:34:41] the difference is between allowing the user to click the "x" and not allowing it? [20:34:59] it greys out but we're still allowing the user to click it, according to the prototype [20:35:11] Okay. From a backend point of view it's disabled, though. [20:35:12] it just then appears as grey in the bubble list [20:35:30] that's my problem though... it's not disabled, it's "" moot "" or... whatever [20:35:39] muted, moot, ineffective... [20:35:41] mooeypoo, inactive? [20:35:54] That word works for all the cases, I think. [20:36:00] it might be active... as in, it's selected... it's just,.. not... effective.... [20:36:20] also, it might **become** ineffective by combination or by user choice [20:36:26] this is confusing :\ [20:37:14] 10Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Triage, 10Notifications: Allow disabling a notification category from within the notifications popup - https://phabricator.wikimedia.org/T132977#2873931 (10jmatazzoni) [20:37:16] 06Collaboration-Team-Triage, 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2873933 (10jmatazzoni) [20:37:19] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice, 07User-notice-collaboration: Sort out Notification categories to make them more logical for Preferences - https://phabricator.wikimedia.org/T133220#2873930 (10jmatazzoni) 05Open>03Resolved [20:37:22] mooeypoo, I'm also fine with 'ineffective', or 'futile' if you want to be more poetic. [20:37:26] matt_flaschen, also, in-anything (ineffective, inactive, etc) is not ideal for item states; isInactive() toggleInactive() etc.. you end up wishing you just used the positive term [20:37:35] which I can also do, I guess [20:37:45] omg futile is so good [20:37:52] Can I add the borg to my code? [20:38:11] If you pick 2 contradictory filters, you get RESISTANCE IS FUTILE [20:38:29] "Can I add the borg to my code? [20:38:42] There's no point in me saying 'no', right? [20:38:52] haha [20:39:24] ok I'm going to get lunch. Let's continue mulling this over... I need to also re-read the spec again, I think. [20:39:28] it's so confusing [20:39:35] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2873935 (10kaldari) BTW, the issue with that gadget was that mw.util.$content was null at document.ready. This was fixed by adding mediawiki.util as... [20:39:52] bbiab [20:41:29] Okay. Honestly, I'm not sure I like 'futile'. [20:47:47] applicable? [20:47:56] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2873962 (10jmatazzoni) Based on @Etonkovidova's screenshots above, it looks like changes were made but this issue... [20:48:03] If you have 'show humans', 'show bots' is not applicable. You can not apply it (it will drop the pair). [20:48:11] 06Collaboration-Team-Triage, 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2873964 (10jmatazzoni) [20:48:45] mooey|lunch, if you have nothing in a group checked, but you have 'show minor edits' highlighted, it is not applicable, because the filter does not actually apply to the results (only the highlight is applicable, not the filter). [21:04:57] (03CR) 10Catrope: [C: 032] Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [21:05:00] (03CR) 10Catrope: [C: 032] Fix check for content text [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 (owner: 10Mattflaschen) [21:05:03] (03CR) 10Catrope: [C: 032] speedy deletion-previously deleted takes a page name, not a URL [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/312108 (https://phabricator.wikimedia.org/T118264) (owner: 10Mattflaschen) [21:06:33] (03Merged) 10jenkins-bot: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [21:07:30] (03Merged) 10jenkins-bot: Fix check for content text [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 (owner: 10Mattflaschen) [21:08:25] (03PS1) 10Catrope: ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 [21:08:28] (03PS1) 10Catrope: ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) [21:08:50] (03Merged) 10jenkins-bot: speedy deletion-previously deleted takes a page name, not a URL [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/312108 (https://phabricator.wikimedia.org/T118264) (owner: 10Mattflaschen) [21:28:06] Thanks for the reviews, RoanKattouw. [21:29:43] I used gertty to do CR on the plane [21:29:46] 06Collaboration-Team-Triage, 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2874284 (10SBisson) >>! In T142454#2873962, @jmatazzoni wrote: > Based on @Etonkovidova's screenshots above, it looks like changes were made bu... [21:41:55] Works well, but it's not quite up to dealing with our scale, so I aborted my attempt to load MW core into it [21:42:30] And that meant that I couldn't review the big RC filters UI patch off line [21:42:47] I'll pay for the wifi on this next flight though [21:52:21] RoanKattouw, gertty looks pretty cool, I'll have to check that out. [21:53:25] Yeah I saw one of the OpenStack Infra guys (authors of various Gerrit-adjacent tools) demo it a year ago, and I forgot about it until last night [22:00:59] 06Collaboration-Team-Triage, 10Notifications, 07Design, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2874400 (10Catrope) I wrote down what this would look like (it's a few simple CSS changes but I don't remember what they are), but not in a ver... [22:03:10] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2848049 (10Halfak) See also http://pythonhosted.org/mwreverts/ This is how I do it for #revision-... [22:05:21] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874422 (10Jdlrobson) This is what I mean.. I see lots of evidence of working around this problem... [22:24:18] RoanKattouw: {"id":"WFHEvgpAIC0AACWm5pcAAABU","type":"MWException","file":"/srv/mediawiki/php-1.29.0-wmf.6/includes/resourceloader/ResourceLoaderImage.php","line":225,"message":"File '/Echo/modules/icons/edit-user-talk.svg' does not exist","code":0,"url":"/w/load.php? [22:25:02] 06Collaboration-Team-Triage, 10Notifications: file missing in echo - https://phabricator.wikimedia.org/T153261#2874508 (10Matanya) [22:25:10] hi mooeypoo [22:25:52] hey matanya [22:28:41] RoanKattouw: same for https://www.mediawiki.org/w/load.php?modules=ext.echo.emailicons&image=thanks&lang=en&format=rasterized [22:38:16] 06Collaboration-Team-Triage, 10Notifications: icons missing in flow and echo - https://phabricator.wikimedia.org/T153261#2874587 (10Matanya) [22:41:55] 06Collaboration-Team-Triage, 10Notifications: icons missing in flow and echo - https://phabricator.wikimedia.org/T153261#2874592 (10mmodell) [22:48:39] Oops, looks like an issue with the extension.json change [22:48:43] Lemme grab my layout [22:48:46] *laptop [22:48:50] 06Collaboration-Team-Triage, 10Notifications: icons missing in flow and echo - https://phabricator.wikimedia.org/T153261#2874508 (10mmodell) so should I now revert again because of this or is this a tolerable bug for now as long as it blocks group2? [23:00:48] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874725 (10Halfak) Agreed. I'd like to have a log item that captures what my `Revert` objects do.... [23:01:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Icons in Echo emails broken - https://phabricator.wikimedia.org/T153261#2874731 (10Catrope) [23:02:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Icons in Echo emails broken - https://phabricator.wikimedia.org/T153261#2874508 (10Catrope) a:03Catrope No need to revert, all it breaks is icons in emails, but I will get right on this. This is almost certainly fallout from convert... [23:03:46] Aha: [23:03:52] 'localBasePath' => $wgExtensionDirectory, // Extension path [23:03:57] That turned into "localBasePath": null [23:10:29] O,o [23:10:32] thta's unhelpful [23:10:59] (03PS1) 10Catrope: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) [23:11:13] mooeypoo: CR plz? --^^ [23:11:34] (03CR) 10Aaron Schulz: [C: 032] ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [23:12:27] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874797 (10Tgr) Except for rollback, the user can arbitrarily edit the text. Should pressing undo... [23:15:50] matt_flaschen: Or you, if you're around? https://gerrit.wikimedia.org/r/327387 [23:16:36] RoanKattouw, reviewing. [23:17:53] mooeypoo: BTW, this means I broke Wikipedia and then fixed it from an airplane. That sticker on our desks that we've sort of been reverse-fighting over ("no you should take it" "no you should take it") is now officially mine :P [23:20:57] (03CR) 10Mattflaschen: [C: 032] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:21:05] 15:18:49 <+RoanKattouw> (It would be cooler if I also deployed the fix from the plane, but that seems impractical and unwise so Mukunda's going to do that) [23:21:15] And as if to underscore that point, the wifi died for 2 minutes right then [23:23:57] RoanKattouw, hey, live a little. That's what 'screen' is for. ;) [23:24:07] And didn't Reedy once deploy from a ferry without an internet at all? [23:24:09] #Legends [23:24:31] matt_flaschen: I've done security fixes from a train [23:24:41] I've done a full train deploy from a car park tethered to my phone [23:27:13] (03CR) 1020after4: [C: 031] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:29:00] for a moment there i was confused how you could simultaneously be on a train and in a car park [23:32:29] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2848049 (10Mattflaschen-WMF) >>! In T152434#2874797, @Tgr wrote: > Should pressing undo + editing... [23:32:30] This calls for a "trains, planes and automobiles" deploy [23:32:52] I use my airplane wifi to VPN through Reedy's phone as he drives down the M62 to do the deployment train [23:32:52] M62: T101533 issues (PS4) - https://phabricator.wikimedia.org/M62 [23:33:48] (03Merged) 10jenkins-bot: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:35:41] (03PS1) 1020after4: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) [23:35:55] (03CR) 1020after4: [C: 032] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) (owner: 1020after4) [23:42:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, and 2 others: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2874871 (10Mattflaschen-WMF) [23:42:59] Could use a review on https://gerrit.wikimedia.org/r/#/c/327377/ if someone has a chance. [23:43:21] Just making it simpler to run scripts on Beta Cluster without a bunch of errors thrown in your face (which makes it annoying to see what really happened) [23:43:55] etonkovidova, if you ever want to shake things up, I noticed there are a bunch of Flow wikis on Beta Cluster that have never been used (for Flow). :) [23:44:27] matt_flaschen: nice :) [23:46:11] matt_flaschen: sometime, not often, I use some obscure wikis in betalabs - esp when I need to have more than three wikis for cross-wiki notifications [23:56:31] I forgot we had en_rtlwiki [23:58:45] matt_flaschen: At your leisure, please review https://gerrit.wikimedia.org/r/327301 [23:59:25] matt_flaschen: I +1ed your patch, happy to +2 except that it needs to be pulled on prod AIUI and my connection isn't good enough for ssh