[00:11:18] You have James_F to thank for that [00:11:35] And also legoktm and stephane[TAB] for debugging this "very simple" feature for months :) [00:13:35] Ha. [00:26:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): If error messages in English, they should not be displayed in RTL even in RTL context - https://phabricator.wikimedia.org/T153027#2866854 (10Etonkovidova) [00:27:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): If error messages are in English, they should not be displayed in RTL even in RTL context - https://phabricator.wikimedia.org/T153027#2866866 (10Etonkovidova) [01:27:16] * legoktm throws a parade for MatmaRex [01:56:38] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, and 2 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2867058 (10Reedy) [01:58:00] * mooeypoo comes back sparkly [01:59:00] RoanKattouw, bawss. I'm semi taskless. I implemented what we talked about in the series of dependent commits - and now there seems to not be anything else to do unless we want to start implementing the "advanced" UI stuff [01:59:08] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, and 2 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2867062 (10Reedy) 05Open>03Resolved a:03Reedy It's gone [01:59:16] mooeypoo: What is the advanced UI stuff? [01:59:26] Waiting for matt_flaschen for the back-end hook and for stephane, then, to implement the rest of the ORES filters [01:59:28] oh [01:59:29] well [01:59:48] I don't know, but i find it hard to believe we're really done, there was so much to do in the prototype [02:00:01] there must be more things I can implement... most things are result-dependent though [02:00:16] RoanKattouw, I could implement the fake-ajax thing [02:00:24] without highlights [02:00:44] Yeah I think that'd be a logical next step [02:00:59] Also ask matt_flaschen and stephane[TAB] tomorrow what they're working on and what they think is next [02:01:40] * mooeypoo nods [02:01:55] RoanKattouw, I am also slightly worried to keep on going on the stack of commits [02:02:02] it's annoying to rebase right now as it is [02:02:07] I know, I have to do code review :( [02:02:11] I didn't have any time for that today, sorry [02:02:12] oh, also, we need to re-evaluate the defaults thing [02:02:23] I think the defaults should be in the data blob that Matt is working on [02:02:27] They should be a property of the setting [02:02:38] I guess we can *start* with taking defaults from settings and defaults like we said - but we are now saying defaults can be *user* dependent [02:02:39] (Except if there's an associated preference, then they could be the default value of the pref instead) [02:02:58] yeah, hence, re-evaluate [02:05:54] RoanKattouw, the settings commit is WIP because of the test I have in it [02:06:04] but it's far enough up the chain to not hold anything up anyways [02:06:20] there's a mw.user.config.set( '...', 1 ) thing [02:06:23] You could add a filter type that does have a real pref? [02:07:22] i think there's only one [02:07:26] hideminor? [02:07:27] I think? [02:07:30] but yes, I guess I can [02:11:45] (03PS1) 10MaxSem: Archive extension [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/326879 [02:11:56] IIRC there are two but I forget what the other one is [02:12:11] (03CR) 10jenkins-bot: [V: 04-1] Archive extension [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/326879 (owner: 10MaxSem) [02:19:20] (03CR) 10MaxSem: [V: 032 C: 032] Archive extension [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/326879 (owner: 10MaxSem) [02:23:31] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar: Moodbar logs doesn't show usernames - https://phabricator.wikimedia.org/T132875#2867109 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:24:35] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, and 2 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2867112 (10Peachey88) [02:24:38] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 07I18n: Untranslatable timestamps in moodbar-feedback-response-helpful-summary, moodbar-feedback-response-summary - https://phabricator.wikimedia.org/T69965#2867115 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, c... [02:24:47] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, and 2 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2166405 (10Peachey88) [02:25:11] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 07I18n: E-mail ("responded to your feedback") is not in the user language - https://phabricator.wikimedia.org/T37143#2867121 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:25:30] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 13Patch-For-Review: Feedback dashboard doesn't understand wikitext - https://phabricator.wikimedia.org/T34018#2867124 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:25:48] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 07I18n: Feedback implies subordinate clause - https://phabricator.wikimedia.org/T34419#2867127 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:26:11] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar: Automatic headline when answering feedback should be editable - https://phabricator.wikimedia.org/T36498#2867130 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:26:42] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar, 07Design: Feedback text overlaps with personal bar on Tamil Wikipedia - https://phabricator.wikimedia.org/T36681#2867133 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:27:07] 06Collaboration-Team-Triage, 10MediaWiki-extensions-MoodBar: Brief flash of unknown content on page - https://phabricator.wikimedia.org/T86638#2867137 (10MaxSem) 05Open>03declined This extension has been undeployed and archived, closing. [02:47:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2867156 (10leila) @jmatazzoni I don't have stats specific to vandalism tools. T... [03:39:35] mooeypoo, I still have stuff to catch up on (after deploying GuidedTour to metawiki, I found a couple bugs, which I've almost fixed, still the Inconsistent board script, catching up on code review and email including of RC, etc.) [03:40:10] mooeypoo, my next feature after GuidedTour and T152379 is still T152754. [03:40:11] T152379: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379 [03:40:11] T152754: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754 [03:41:20] As RoanKattouw said, the default value can be user-specific (but is not always). I'll take that into account. [03:42:16] matt_flaschen: IMO if there is a pref, you don't need a default value because the pref has a default already [03:48:27] RoanKattouw, my interpretation was the default value is either a constant or a user preference, but either way I was calling it the default. [03:48:41] Makes sense [03:48:52] Just saying, you don't need to specify the default in the config blob if there's a preference [03:49:47] RoanKattouw, but if I don't, I would probably have to specific at least the preference string key (and maybe an additional key to indicate the string *is* a preference key), so mooeypoo's init knows where to get the value. [03:50:03] Yeah [03:50:14] Ooh, I see, if you're generating the blob server-side you can just resolve the value there [03:50:20] Yeah [03:52:33] Have a good night, all. [07:52:38] 06Collaboration-Team-Triage: Moodbar logs doesn't show usernames - https://phabricator.wikimedia.org/T132875#2867328 (10Sjoerddebruin) >>! In T132875#2867109, @MaxSem wrote: > This extension has been undeployed and archived, closing. When will the communities be notified about this? Last time nlwiki objected re... [08:56:43] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons: Plan to disable Flow on Enwiki - https://phabricator.wikimedia.org/T148611#2727741 (10Qgil) Is there anything left here? https://en.wikipedia.org/wiki/Special:Version shows no Flow. [11:17:53] 06Collaboration-Team-Triage: Moodbar logs doesn't show usernames - https://phabricator.wikimedia.org/T132875#2868242 (10Aklapper) >>! In T132875#2867328, @Sjoerddebruin wrote: > When will the communities be notified about this? Last time nlwiki objected removal somehow. -> T131340 please :) [16:49:59] 06Collaboration-Team-Triage, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 13Patch-For-Review, and 2 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2869379 (10Trizek-WMF) [17:02:53] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2869403 (10Etonkovidova) C... [18:07:03] quiddity, matt_flaschen: Meeting? [18:07:43] RoanKattouw, sorry, conflicting meeting [18:15:04] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons: Plan to disable Flow on Enwiki - https://phabricator.wikimedia.org/T148611#2869724 (10Catrope) 05Open>03Resolved a:03Catrope Yeah, this was done on Nov 7, we forgot to close it. [18:16:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow: Create a lockdown configuration for Flow on Enwiki to prevent anyone at all from creating new Flow boards - https://phabricator.wikimedia.org/T146727#2869728 (10Catrope) 05Open>03Invalid Flow has been disabled on enwiki [18:42:35] (03PS1) 10Catrope: Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) [18:43:01] (03CR) 10Catrope: [C: 032] Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [18:43:12] (03Abandoned) 10Catrope: Fix PHP notice while running cli. [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/325822 (https://phabricator.wikimedia.org/T152625) (owner: 10MarkAHershberger) [18:43:45] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Error from during upgrade.php - https://phabricator.wikimedia.org/T152625#2869841 (10Catrope) [18:43:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Array to string conversion from Flow when using scripts against officewiki - https://phabricator.wikimedia.org/T149579#2869844 (10Catrope) [18:53:15] (03CR) 10jenkins-bot: [V: 04-1] Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [18:53:51] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Special:notifications not loading styles in UC mini browser on some wikis - https://phabricator.wikimedia.org/T152799#2860491 (10Catrope) Do you have any user JS/CSS on those wikis? There could also be site JS/CSS on those wikis that's breaking this. D... [18:54:44] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Special:notifications not loading styles in UC mini browser on some wikis - https://phabricator.wikimedia.org/T152799#2869942 (10Catrope) (Also note that UC Mini is not an [[https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix|officially... [18:54:49] (03CR) 10jenkins-bot: [V: 04-1] Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/327019 (https://phabricator.wikimedia.org/T149579) (owner: 10Catrope) [18:59:47] 06Collaboration-Team-Triage, 10Notifications, 10Challenge, 10Social-Tools: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2862660 (10Trizek-WMF) Have you read [[ https://www.mediawiki.org/wiki/Help:Notifications/Document_a_new_notification_type | the documentation concerning new... [19:04:36] 06Collaboration-Team-Triage, 10Notifications: Cross-wiki Echo notification not shown on Meta - https://phabricator.wikimedia.org/T152916#2869979 (10Catrope) 05Open>03Invalid You appear to have turned off cross-wiki notifications in your preferences on meta: ``` mysql:research@s3-analytics-slave [metawiki]... [19:07:31] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2866360 (10Catrope) @Whatamidoing-WMF Can you still reproduce this with some reliability? I'm especially interested in the case where the notifications never appear. [19:30:04] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870082 (10Mooeypoo) >>! In T153011#2866552, @Legoktm wrote: > Sometimes I'll encounter the notifications never showing up (just endless progressbars), and it's always because som... [19:31:29] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870085 (10Legoktm) I think it was the markblocked one, but I hacked around it: https://meta.wikimedia.org/w/index.php?title=User%3ALegoktm%2Fglobal.js&type=revision&diff=15960205... [19:40:16] 06Collaboration-Team-Triage, 10Flow, 10Tool-Labs-tools-Xtools: Add Flow contributions to Xtools - https://phabricator.wikimedia.org/T136950#2870123 (10MusikAnimal) [19:40:38] 06Collaboration-Team-Triage, 10Flow, 10Tool-Labs-tools-Xtools, 10Tools-Global-user-contributions: Add Flow contributions to GUC and Xtools - https://phabricator.wikimedia.org/T114777#2870125 (10MusikAnimal) [19:47:23] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870146 (10Catrope) @Whatamidoing-WMF thanks for emailing me your console log. The relevant bit is `TypeError: mw.util.$content is null[Learn More] index.php:176:1`, I think I've... [19:47:47] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870149 (10Catrope) @Mattflaschen-WMF didn't you tell me about this error at some point? [19:48:31] 06Collaboration-Team-Triage, 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870157 (10Whatamidoing-WMF) I believe that error can break ContentTranslation. I don't know how to find out which script is doing it. [19:50:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2870177 (10jmatazzoni) [19:51:38] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Attribute RC lines to their sources - https://phabricator.wikimedia.org/T152797#2870181 (10jmatazzoni) [19:53:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870201 (10jmatazzoni) [19:54:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2870222 (10jmatazzoni) 05Open>03Resolved [19:54:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#2870224 (10Catrope) >>! In T153011#2870157, @Whatamidoing-WMF wrote: > I believe that error can break ContentTranslation. I don't know how to find o... [20:12:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2870310 (10jmatazzoni) @Halfak points out that new users are most vulnerable in their first few days of activity. Bu... [21:34:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2870686 (10Halfak) I agree with @Trizek-WMF re wording changes and I think "learning" is an improvement. I wonder th... [22:30:14] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 10Reading-Community-Engagement, 06Reading-Web-Backlog: Change how the notification count is displayed - https://phabricator.wikimedia.org/T152457#2870936 (10Jdlrobson)