[00:09:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2858938 (10jmatazzoni) @Samwalton9, I kn... [01:08:05] matt_flaschen, fyi, I finished the rcfilters patch, it's up and ready for review -- and same with the overlaying patch for userExpLevel filter [01:08:44] I also added another that you may like -- we talked about this -- a WIP for now, but proof of concept on reading user preferences as a "base" state that the URL params go on top of: https://gerrit.wikimedia.org/r/#/c/326064/1 [01:09:24] I have a mw.user.options.set( 'hidemyself', 1 ); in there just to simulate a preference in one of the already-used filters (rather than depending this on implementing one of the filters with an existing pref) [01:09:57] But it follows what we discussed regarding the controller doing the work; we could also do it in stages like you recommended, but since it was done alongside analyzing the URL, I figured I can just combined the two and send them at once to the model [01:10:37] so with that patch, if you load the page without any url params, you'll see "Show edit by others" as default [01:10:52] and if you override it by using ?hidemyself=0 you'll see it gets overridden [01:13:41] mooeypoo, makes sense. All of this does need to be framework-ized, so existing options work (and extensions can add them using old or new hooks). [01:13:52] We've talked about it. [01:14:41] I will try to re-review rcfilters soon. [01:15:02] matt_flaschen, yeah that's why the preference name is also a config in the group/filters [01:15:31] so I don't assume that the "editsbyself" filter is necessarily using "editsbyself" config option - it may have a different config name or something. [01:16:28] mooeypoo, yeah, but also the whole thing in general. I.E. https://gerrit.wikimedia.org/r/#/c/326064/1/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js (not that change, just that area of the file). [01:16:40] mooeypoo, it should be configured on the server. There are a few things which should be centralized: [01:16:46] oh yeah [01:16:47] * What filters there are [01:16:55] No I wanted to simulate reading a wgVariableThingie [01:16:57] * Whether they are available on old, new, or both (don't think any are only old). [01:17:08] * The default value [01:17:13] (Default value can be from prefs). [01:17:28] The idea was that any extension can give it out to the system just like it does now, either with the current hook or a wgVar thing [01:17:38] and then either you add to an existing group or you create your own group [01:17:39] And all of those should be add-able/configurable by hooks. [01:17:54] mooeypoo, what do you mean about a wgVar? [01:17:54] Hooks or wgVariable like we do with Echo, but yeah [01:18:08] like in echo we let extensions add notifications wtih wgEchoSomethingSomething [01:18:24] it's not a hook, it's a definition [01:18:56] mooeypoo, I guess. Remember thought that extension actually needs to implement the back-end filtering too (by modifying the RC page DB query). [01:18:58] We can do it either way. Since there's already a hook for RecentChanges filters, we should probably continue using it (though with new structure for the new UI) but we can also decide to change it to use a global variable that extensions add to [01:19:01] So I would argue for hooks. [01:19:52] hm, but the hook for filtering is different than the hook for *defining* the filters, iirc [01:20:25] anyways, it's not that different, we can use either -- either way, the structure in the .init.js file was meant to simulate the overall resulting all-encompassing filter definition from everywhere [01:20:30] Yeah, that could be. [01:20:46] mooeypoo, right, I'm not saying anything is wrong with init, it just reminded me. Is there a task for this? [01:20:50] either by reading the hook and sending the resulting filter structure to the JS or by reading the wgVariableThingie to the JS [01:20:57] * mooeypoo nods [01:20:59] there is not [01:21:01] good point [01:21:07] mooeypoo, I'll file one. [01:21:15] We're going to have to do that with ORES filters anyways [01:21:19] because these come from outside core [01:21:25] the ones I've been working on are default core ones anyways [01:21:28] And Wikidata [01:21:33] Yeah [01:21:43] and we have another, I think translate [01:21:59] but yeah, we talked around this subject but I don't think there's an actual task for it [01:22:22] The entire structue that I have in the init file should probably go in the backend - wherever we build the filter structure (and allow other extensions to add to it) [01:22:32] also we will have to figure out how to "prioritize" filters in order [01:22:47] ORES, for instance... we want it to be on top [01:22:51] I agree (re "The entire structure") [01:23:44] I started thinking about prioritization thing. We may have to do something creative with it. [01:24:49] matt_flaschen, I also added unit tests to the new group (in the userExpLevel patch) [01:24:57] I've defined a group "string_options" [01:25:08] param=opt1,opt2 [01:25:11] or param=all [01:27:31] mooeypoo, 'all' breaks the principle you gave earlier that a URL always has an exact meaning (i.e. always specify everything so preferences are irrelevant) [01:27:37] 'all' causes it to change meaning over time. [01:27:51] IIRC what you said about URLs and prefs. [01:29:09] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2859076 (10Mattflaschen-WMF) [01:33:51] matt_flaschen, "all" is the same as hideXXX=0&hideYYY=0 [01:33:58] it overrides current preference states if you have them [01:36:07] matt_flaschen, and by saying "the same as" I mean the same principle [01:36:22] like, hideXXX=0&hideYYY=0 (of the same group) is the same as not having any of those up there [01:36:48] so you might have a case where your URL doesn't have these and shows trhe same results with a URL that *does* have these [01:37:11] but having them in the URL means that you can share it with me and I will see the same result you have *regardless of my preferences* [01:39:35] matt_flaschen, in the code I have a comment saying we should consider "cleaning up" the parameters (like removing unused ones or falsy ones or whatever) in case we want to, but that's a discussion on its own -- if we always include the parameters, both true and false and 'all' etc, we basically guarantee that you will see the same exact state/list/result even if you changed your preferences or if you send your list to another [01:39:35] person with different preferences [01:40:20] one can make the case that that's *not* the correct course of action, of course - that if you didn't touch a parameter then the list should switch up if you changed your preferences... we can decide we do that, but that would mean cleaning up parameters that weren't directly interacted with (when we output the parameter query) [01:40:25] matt_flaschen, in short, we should talk about this :P [01:40:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2859091 (10jmatazzoni) [01:43:08] matt_flaschen, ok, I have to go home, but we should discuss these things further [01:43:10] see you tomorrow [01:44:02] mooeypoo, agreed. Have a good night. I should also go to dinner for Realz. [01:44:26] mooeypoo, by "'all' breaks the principle", I was thinking of the case: [01:44:30] (for example) [01:45:27] (I wasn't thinking of this exact case, but the example works) [01:45:51] Currently, you can flag certain "interesting categories". E.g. the list is (Culture, Geography, Health, History), with a "More available link". [01:46:17] So 'all' would currently I guess mean Culture+Geography+Health+History, but if Science is later added to that list, 'all' should then include it. [01:46:19] So the meaning changes. [01:46:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2859105 (10jmatazzoni) [01:46:46] I realize saying this that it's only an issue for groups that aren't full-coverage. So it can be solved like that. [01:47:32] mooeypoo, it's safe for userExpLevel. Currently there are 3, but even if later there is super-experienced (More than 365 days, 5000 edits), 'all' still means the same thing (it's checking four now, but it's the same users, i.e. everyone). [01:47:45] I.E. full-coverage. [01:48:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2859107 (10jmatazzoni) > may I suggest that we use the alr... [02:52:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-FlaggedRevs: Add Vagrant role for FlaggedRevs - https://phabricator.wikimedia.org/T152584#2859149 (10Mattflaschen-WMF) [03:41:24] Have a good night, everyone. [09:24:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2859414 (10Samwalton9) @jmatazzoni No pr... [13:20:17] 06Collaboration-Team-Triage, 10Flow: Need tabs to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#2859645 (10Trizek-WMF) >>! In T90280#2851920, @Kghbln wrote: > Oh, so I reported this bug twice myself. That happen to me too. > Am I the only... [13:22:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review: Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2859646 (10SBisson) a:03SBisson [13:23:12] 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2859651 (10Trizek-WMF) We have noticed that on wikis where Flow boards have been created manually before the Beta feature appears. You just... [14:24:34] (03PS2) 10Sbisson: Fix unread notification count caching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326023 (https://phabricator.wikimedia.org/T151389) [14:24:45] (03CR) 10Sbisson: Fix unread notification count caching (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326023 (https://phabricator.wikimedia.org/T151389) (owner: 10Sbisson) [14:34:43] 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2859792 (10jeblad) Ok, I'll close this, the world will not go up in flames today. ;) [14:36:22] 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2859795 (10jeblad) 05Open>03Resolved a:03jeblad Implicit resolved by previous fixes.;) Hm, causality, messes up, it is clearly my bug... [15:49:29] 06Collaboration-Team-Triage, 10Flow: Oversighted revision on Flow history is not visible at all instead of being in grey - https://phabricator.wikimedia.org/T152784#2859978 (10Trizek-WMF) [17:12:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2860089 (10jmatazzoni) [17:13:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2750649 (10jmatazzoni) @Pginer-WMF, I added my take on the beta option opt-in text to the description above. Please h... [17:15:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2860103 (10jmatazzoni) [17:17:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2860117 (10jmatazzoni) [17:54:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2758602 (10tarlocesilion) Please rethink names used in this filter. "Newcomer"... [18:46:37] (03CR) 10Catrope: [C: 04-1] FlowFixInconsistentBoards: Don't output non-critical error info (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [18:54:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2860331 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [19:13:12] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2860400 (10Mattflaschen-WMF) [19:23:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Configure filters in a single extensible place - https://phabricator.wikimedia.org/T152754#2860426 (10Mattflaschen-WMF) [19:39:50] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Attribute RC lines to their sources - https://phabricator.wikimedia.org/T152797#2860458 (10Aklapper) [19:56:01] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Special:notifications not loading styles in UC mini browser on some wikis - https://phabricator.wikimedia.org/T152799#2860491 (10Quiddity) [19:56:30] (03CR) 10Catrope: [C: 032] Fix unread notification count caching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326023 (https://phabricator.wikimedia.org/T151389) (owner: 10Sbisson) [20:11:21] (03Merged) 10jenkins-bot: Fix unread notification count caching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326023 (https://phabricator.wikimedia.org/T151389) (owner: 10Sbisson) [20:28:40] I'm going to go drop my car off at the mechanic. [20:29:17] You have a car? [20:29:29] I keep forgetting people outside NYC and SF have those [20:34:12] 06Collaboration-Team-Triage, 10Notifications: Big problem Notices and Alerts in Wikipedia Arabic - https://phabricator.wikimedia.org/T152800#2860550 (10Reedy) [20:36:59] 06Collaboration-Team-Triage, 10Notifications: Notices and Alerts on Wikipedia Arabic cannot be opened (TypeError: transformTable is undefined) - https://phabricator.wikimedia.org/T152800#2860556 (10Aklapper) p:05Triage>03Unbreak! [20:38:16] 06Collaboration-Team-Triage, 10Notifications: Notices and Alerts on Wikipedia Arabic cannot be opened (TypeError: transformTable is undefined) - https://phabricator.wikimedia.org/T152800#2860559 (10Aklapper) Hi @Bachounda! Thanks for reporting this! Posting the output of the web browser's developer tools' 'co... [20:43:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: Notices and Alerts on Wikipedia Arabic cannot be opened (TypeError: transformTable is undefined) - https://phabricator.wikimedia.org/T152800#2860561 (10Aklapper) And now with `?debug=true` fo... [21:04:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2860620 (10jmatazzoni) I suggested text for the beta description, bas... [21:12:25] RoanKattouw / mooeypoo: You should be aware of https://phabricator.wikimedia.org/T152800 even if the breakage isn't your team's fault. [21:27:55] mooeypoo: I was surprised when I found out too, I mean I know he's not in NYC or SF, but he's still in a real city [21:29:33] That said I haven't lived in a place like that so what do I know [21:39:21] Yeah, I could definitely handle not having a car. I get to the coworking space by subway (very convenient, the train route literally turns 90 degrees, then drops me off a block from the coworking space), and everyday stuff I often do by transit or walking. [21:39:30] Of course, having it is convenient sometimes too. [21:46:51] Yeah being mobile is nice [21:46:58] I just dislike driving in a city in general [21:47:10] There seem to be way too many other people driving [21:47:16] ... sometimes not very well [22:22:03] I don't mind driving and part of me would like to own a car [22:22:13] But I also live in a place where it's hilariously impractical to have one [22:22:21] So I have a Zipcar membership instead [22:34:52] 06Collaboration-Team-Triage, 10Notifications, 10VisualEditor: Problem with visual editor, and notifications - https://phabricator.wikimedia.org/T152810#2860800 (10ASammour) [22:36:23] RoanKattouw: solution: move to a better part of the bay ;) [22:36:46] 06Collaboration-Team-Triage, 10Notifications, 10VisualEditor: Problem with visual editor, and notifications - https://phabricator.wikimedia.org/T152810#2860815 (10Catrope) [22:41:21] "better" [22:41:53] I don't think I'd use a car often enough to justify owning one anyway [22:42:48] Although next summer I want to drive from SF to Bend to Seattle to Edmonton which will probably require a relatively elaborate car rental setup [22:43:10] But at least I won't have to spend thousands of dollars on buying a car and I won't have to drive it all the way back home from Edmonton [22:54:29] Gah. [22:54:49] Re-cloning GuidedTours every time to fix this patch is getting tedious. :-) [22:55:03] Why do you need to re-clone it every time? [22:55:15] Do you keep removing it because you don't think you'll need it any more? [22:55:20] RoanKattouw: Why would I keep it around? It's just in my scratch space. [22:55:23] Yeah [23:03:59] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2860881 (10jmatazzoni) [23:05:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2750649 (10jmatazzoni) [23:06:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2860884 (10jmatazzoni) [23:14:52] James_F, sorry. Thanks for going the extra mile. It's +2'ed now. [23:15:09] Do you find just having it in the extensions directory is annoying clutter? I keep them all there now, but not all are enabled of course. [23:15:11] matt_flaschen: Yay. :-) [23:15:15] Though I also have an archive directory for other stuff. [23:15:30] matt_flaschen: My main extensions directory is under vagrant so… [23:15:42] James_F, so? That is actually stored on the host. [23:15:56] It's shared with Vagrant over NFS, but Vagrant will never even do a NFS hit if it's not enabled. [23:16:00] Yeah, but I really don't want to be fighting against vagrant git-update for repos I'm not thinking about. [23:16:29] James_F, that's a good point I should consider. [23:16:35] vagrant git-update does take forever. [23:16:38] But maybe I'm just too cautious? [23:16:46] Yeah, especially with Flow. [23:16:57] I don't think it's a runtime hit, but you raise a good point about git-update. [23:29:21] (03PS1) 10Catrope: Follow-up eed48aa7: remove unnecessary z-index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326196 [23:29:50] kmuthu: ---^^ [23:40:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2860962 (10Mattflaschen-WMF) Re "Type of change", don't forget about Flow. Flow posts are technically not page edits...