[00:36:39] RoanKattouw, is this the next to be reviewed/merged? https://gerrit.wikimedia.org/r/#/c/321744/ [00:40:11] RoanKattouw, I'm trying to think if I should rebase this on top of my fix so I can continue or if it's about to be merged, and I hsould just wait [00:41:22] I'm currently working on his ORES patches for damaging/goodfaith, but once those are merged (I finished review, just need to test, got interrupted by a chocolate cake emergency) I can do those next [00:41:36] * mooeypoo nods [00:41:45] I want to try and get those as the next special group type [00:42:26] I can start "blind" (just make sure that the front end handles the params regardless of the back end) and then put that new commit on top of my current one and then continue as we go [00:50:44] mooeypoo: You can certainly start that way, just by writing unit tests and developing against those [00:52:12] * mooeypoo nods [00:53:13] mooeypoo: Actually the ORES patches I'm reviewing now should help too [00:53:17] /w/index.php?title=Special:RecentChanges&days=30&damaging=likelygood,maybebad [01:03:19] https://gerrit.wikimedia.org/r/#/c/324507 [01:03:37] It's -1ed because it throws exceptions on bad input, but that shouldn't hold you back [01:22:23] RoanKattouw, do you know if Array.map() has a "skip" option? return false or something? [01:23:05] I am trying to take the array of filters and produce an array of filterNames but only for filters who are .isSelected() [01:23:30] I thought of something like filters.map( function ( filter ) { return filter.isSelected() ? filter.getName() : null; } ); [01:23:44] but that can produce something like [ null, 'foo', null, null ] [01:24:14] so either I need to clean up the array afterwards, or I am missing something [01:28:52] No, you need to map+filter [01:29:00] mooeypoo: Also, how demo-able is that RC code? [01:29:11] (James is trying to nudge us into demoing something at CREDIT tomorrow) [01:38:07] hm [01:38:19] I dunno... it's demoable, but very stripped [01:38:23] I mean, there are only 2 filters. [01:38:36] What am I going to demo? "Look... I select one.." [01:38:43] also, we stopped auto-updating the URL [01:38:56] I don't think it's that impressive anymore? Maube we should wait to have 2-3 filters? [01:48:03] Hmm yeah maybe [01:48:23] Hmm damaging and goodfaith are the wrong type, right? [01:48:27] The one you haven't written yet [01:48:30] And we don't have AJAX yet [01:48:39] and my local wiki is almost empty [01:48:45] so the results don't really look that impressive [01:49:09] I say we wait a little bit longer. We will have even 2-3 types of filters very soon [01:49:13] Sure [01:49:26] when's the next credit? [01:49:30] is it monthly? [01:49:31] It's monthly [01:49:38] Ish. [01:49:41] Not sure when in Jan it will be though because of all-hands etc [01:49:43] oh you're here [01:49:45] Not sure if the January one will go ahead. [01:49:57] It is I, James. [01:49:58] Oh there is one scheduled for Jan 4 [01:50:00] I am… everywhere. [01:50:07] I suppose that's a question for Adam [01:50:12] mooeypoo: Want to demo it 1 day after everyone gets back? ;-) [01:50:27] ...sssure? [01:50:33] James_F: What product is going to be pitched 1 day after we get back? :P [01:50:36] I mean, I'm not going anywhere [01:50:43] RoanKattouw: Visual diffs. [01:50:48] RoanKattouw: :-P [01:50:49] * RoanKattouw taunts James_F into canceling another one of his 9am meetings [01:50:51] hehe fair enough [01:50:56] ha [01:51:02] Also you should present that at the Jan CREDIT [01:51:19] That too. If Thalia's here in-person it might be fun too. [01:51:23] There now I have an excuse to make you make Adam not cancel it [01:51:50] I am confused [01:52:01] it is so hard to judge whether you guys are joking or not over IRC [01:52:28] Indeed. [02:13:04] (03PS10) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) [02:13:30] It's always great when you get insta-minus-oned by Jenkins because the amended patchset you just uploaded conflicts with the two other changes that you +2ed 10 mins ago and have now merged [02:15:22] (03CR) 10Mattflaschen: "Done. I also fixed a bug I introduced (in an earlier patch set) in mark." (035 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [02:15:42] ...and even better when that happens twice [02:19:49] (03CR) 10Mattflaschen: "> It turns out FlowFixInconsistentBoards outputs a lot of errors and takes a long time to run in beta, causing the jobs to time out." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325538 (https://phabricator.wikimedia.org/T152379) (owner: 10Sbisson) [02:33:06] RoanKattouw, ran FlowFixInconsistentBoards on all the Flow Beta Cluster wikis that exist, except enwiki and en_rtlwiki. That didn't take long. enwiki is running now. That probably will. [02:34:17] It's running in screen though. [02:48:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2853230 (10Mattflaschen-WMF) [02:48:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2713647 (10Mattflaschen-WMF) [02:58:18] (03PS1) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) [03:00:06] (03PS2) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) [03:01:44] (03CR) 10Mattflaschen: "I did think of an optimization here: https://gerrit.wikimedia.org/r/#/c/325730/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325538 (https://phabricator.wikimedia.org/T152379) (owner: 10Sbisson) [03:03:07] (03CR) 10Mattflaschen: "I'll run this for Beta Cluster enwiki and en_rtlwiki after this fix is merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [03:04:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2853238 (10Mattflaschen-WMF) Added @Catrope. [03:15:27] matt_flaschen: When you get around to it, you should add a web proxy at https://horizon.wikimedia.org/project/proxy/ so that http://deferred-changes.wmflabs.org works [03:15:47] (It looks like I don't have admin rights in the editor-engagement project so I can't do it) [03:16:41] RoanKattouw, yeah, I will. It's in progress. The instruction to use m1.medium or m1.large was buried at the bottom of the howto (out of sequence), so I have to recreate it. [03:16:45] I'll also make you an admin. [03:16:53] hah oh that explains [03:17:03] I went to the instance list and it was suddenly gone, that would be why :) [03:17:13] Heading home now but I appreciate the adminship [03:17:41] RoanKattouw, no problem. Have a good night. [03:54:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2853274 (10Mattflaschen-WMF) I'm up to #11 of https://wikitech.wikimedia.org/wiki/Help:MediaWiki-Vagrant_in_Labs#Setting_up_your_instance_with_MediaWiki-Vagrant . It's... [04:02:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Add Vagrant role for FlaggedRevs - https://phabricator.wikimedia.org/T152584#2853276 (10Mattflaschen-WMF) [04:03:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2848333 (10Mattflaschen-WMF) All done, except checking out the code. [04:04:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2853303 (10Mattflaschen-WMF) People can use https://www.mediawiki.org/wiki/Manual:CreateAndPromote.php to create users for themselves (I did change the password, since... [08:00:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2853501 (10Pginer-WMF) I illustrated [[ https://commons.wikimedia.org/wiki/File:Rece... [08:11:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2853509 (10Pginer-WMF) [08:12:54] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2600312 (10Pginer-WMF) [08:29:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2853520 (10Pginer-WMF) [09:33:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2853638 (10Pginer-WMF) Good points, @Etonkovidova. I think that the links at the top of the page that point to... [10:03:02] (03PS1) 10Amire80: Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 [10:04:27] (03PS2) 10Amire80: Split API messages to a separate file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325753 [17:55:58] (I'll be late for meeting again) [19:57:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2855185 (10Quiddity) Thanks Matt! I've registered as Quiddity, please [[http://deferred-changes.wmflabs.org/wiki/Special:UserRights/Quiddity |give]] that account bcrat... [19:58:56] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2836179 (10jmatazzoni) @leila, someone said you might have done some work in th... [20:01:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2855192 (10jmatazzoni) done _____________________ Joe Matazzoni Product Ma... [20:06:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2855199 (10Catrope) >>! In T152443#2855185, @Quiddity wrote: > Thanks Matt! I've registered as Quiddity, please [[http://deferred-changes.wmflabs.org/wiki/Special:User... [20:07:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2855202 (10Etonkovidova) Adding the comment from {T138310} Checked in frwiki, kabwiki, mediawiki - for enab... [20:32:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2855250 (10jmatazzoni) Re Aaron's suggestion: > may I su... [20:52:39] 06Collaboration-Team-Triage, 10Flow: Error from during upgrade.php - https://phabricator.wikimedia.org/T152625#2855322 (10MarkAHershberger) [20:56:53] (03PS1) 10MarkAHershberger: Fix PHP notice while running cli. [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/325822 (https://phabricator.wikimedia.org/T152625) [21:04:38] (03CR) 10jenkins-bot: [V: 04-1 C: 040] Fix PHP notice while running cli. [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/325822 (https://phabricator.wikimedia.org/T152625) (owner: 10MarkAHershberger) [21:09:43] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Error from during upgrade.php - https://phabricator.wikimedia.org/T152625#2855425 (10Aklapper) Out of curiosity, which PHP version is used? [21:09:50] Urrrgh [21:10:04] Why does the vagrant role for Echo depend on CentralAuth and pull in all the multi-wiki stuff [21:23:32] RoanKattouw: corss-wiki notifs... [21:23:35] cross-wiki* even [21:24:10] RoanKattouw: also, I assume the Flow-extension.json-ification went well in production? [21:27:18] Yeah... but having it be non-optional is me [21:27:18] h [21:27:24] Ahm, I guess so [21:27:35] mw.org is group0 and it seems to be working [21:30:29] (I'm out for a bit. Going to get supplies in case it snows again tonight/tomorrow) [21:33:16] Going to check logstash later [21:42:31] logstash looks fine, nothing out of the ordinary for Flow or group0 AFAICT [22:00:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2855636 (10Cenarium) This looks great, I've made an account there too (Cenarium). For the configuration, we may add this to local settings: ``` $wgFlaggedRevsDeferral... [22:13:04] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 06translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#2855680 (10Arlolra) [22:21:12] RoanKattouw, fyi, since the bot doesn't announce these here: [22:21:13] (PS1) Mooeypoo: Add userExpLevel filter in the RCFilters UI [core] - https://gerrit.wikimedia.org/r/325851 (https://phabricator.wikimedia.org/T149435) [22:21:23] (I have something to fix in the underlying commit, willdo that after I get back) [22:33:24] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Internal links pointing to interwikis are not encoded at all - https://phabricator.wikimedia.org/T150112#2855738 (10Arlolra) > Note also that the link is rendered as class="external" instead of class="extiw" as it would otherwise on normal wiki pages. Normal wi... [22:39:13] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Internal links pointing to interwikis are not encoded at all - https://phabricator.wikimedia.org/T150112#2855743 (10Arlolra) a:05Arlolra>03None > Another interesting case ``` echo "[[w:Wikipedia:Sandbox?action=edit]]" | node bin/parse --prefix frwiki --wt2... [22:58:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new precision-based test stats for editquality models - https://phabricator.wikimedia.org/T151970#2855805 (10Halfak) @jmatazzoni, I understand that you want... [23:13:08] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2855836 (10Catrope) 05Open>03Resolved All done. I enabled both protection and deferral in the FlaggedRevs config, and I created four example pages: * [[http://defe... [23:20:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2855867 (10Cenarium) @Catrope: There is no need to patch AbuseFilter, this is handled from FlaggedRevs. You can create an abuse filter and you will notice two new actio... [23:21:01] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Internal links pointing to interwikis are not encoded at all - https://phabricator.wikimedia.org/T150112#2774296 (10Catrope) >>! In T150112#2855738, @Arlolra wrote: >> Note also that the link is rendered as class="external" instead of class="extiw" as it would... [23:35:13] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Internal links pointing to interwikis are not encoded at all - https://phabricator.wikimedia.org/T150112#2855931 (10Arlolra) @Catrope Thanks for the pointer. I guess this is a dupe of T97093 then. [23:57:07] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Internal links pointing to interwikis are not encoded at all - https://phabricator.wikimedia.org/T150112#2855996 (10Catrope) >>! In T150112#2855931, @Arlolra wrote: > @Catrope Thanks for the pointer. I guess this is a dupe of T97093 then. Is it? I mean this ta...