[00:01:02] matt_flaschen, can we talk about the two tests you've added and why they fail? [00:01:08] matt_flaschen, because they're actually correctly failing [00:01:49] mooeypoo, yeah, video okay? [00:02:12] yup, hang on I'm testing something [00:03:36] ok I think this is a misunderstanding of what I *thought* is the way things should work, how I explained it, and how you think they should work [00:04:07] (03Abandoned) 10Catrope: Add extension.json from conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252852 (owner: 10MarkAHershberger) [00:04:35] matt_flaschen, we can do video [00:06:06] hangouts.google.com has been weird for me lately. Sometimes the left bar is all blank. [00:06:26] I use the chrome extension [00:06:45] haven't checked hangouts.google.com for a while [00:07:00] but it should also call you through gmail I thought? like, the chat boxes there [00:07:39] mooeypoo, one second, I'll call you. [00:09:31] * mooeypoo nods [00:55:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2849527 (10Etonkovidova) Checked in frwiki, kabwiki, mediawiki... [01:00:35] RoanKattouw, due to matt_flaschen 's help, the RCFilters patch has been upgraded from "super atomic WIP" to "mildly atomic WIP". [01:00:46] Cool [01:35:21] Just noticed the Gerrit is the latest patch, rather than the patch you're actually looking at. [01:44:32] <mooeypoo> matt_flaschen, ok, the tests are failing again because I took out the $.extend( base, params) thing [01:44:36] <mooeypoo> and that fixed the FIRST test [01:44:52] <mooeypoo> should I bring it back (but then it's half-fixed) or should I take out the test and reproduce that one in the controller too? [01:46:56] <mooeypoo> Also, this whole deal bugs me. It works according to what it *should* do, but I don't like the problem you discovered with it ignoring 0s. [01:47:01] * mooeypoo will have to think about this [01:47:18] <matt_flaschen> mooeypoo, probably move it to the controller. If they follow the instructions to call it once, there shouldn't be anything relying on that functionality. So it makes more sense as a controller test. [01:47:55] * mooeypoo nods [01:47:58] <matt_flaschen> mooeypoo, yeah, in a theoretical sense, it bugs me too. But it's not something I consider critical. [01:48:05] <matt_flaschen> As long as it works in a reasonable way, it's okay. [01:48:19] <matt_flaschen> It doesn't have to work in that particular way. [01:48:39] <mooeypoo> It still bugs me, though... it basically means that what we give the method data and it may return the wrong state [01:48:43] <mooeypoo> And that's not good [01:49:09] <mooeypoo> I mean, it wasn't designed to work through the *particular* case you suggested, but the fact it's not consistent in getting the correct data out worries me [01:49:59] <matt_flaschen> mooeypoo, well if it really bothers you, then do it the other way. And to avoid being dead code (only used in tests), you could actually *use* it that way, rather than making the controller responsible. [01:50:56] <matt_flaschen> mooeypoo, that's also a quite reasonable approach (models are responsible for similar things (like list models where you can call addItems multiple times)) [01:51:18] <mooeypoo> well I think it's correct to let the controller do it [01:51:45] <mooeypoo> but the fact that the method ignores 0s means it has a potential for other bugs [01:52:09] <matt_flaschen> mooeypoo, if there were any other bugs, I would have added a test for them. ;) [01:52:18] <mooeypoo> matt_flaschen, so I am thinking of making the model **be able** to do it, but I don't think it should do it? [01:52:23] <mooeypoo> haha [01:52:49] <matt_flaschen> mooeypoo, but in seriousness, you could have the controller responsible for what *order* to call it (e.g. defaults then URL), but the model responsible for actually applying in that order. [01:52:55] <matt_flaschen> And I think that is consistent with precedent. [01:52:57] <mooeypoo> actually, I think I figured it out [01:53:08] * mooeypoo nods [01:53:12] <mooeypoo> yeah, we could do it that way too [01:54:00] <matt_flaschen> mooeypoo, what solution did you figure out? [01:55:02] <mooeypoo> Well... you're right in your observation that I'm basically ignoring anything inside a group that's in a group that hasSelected [01:55:14] <mooeypoo> I am trying to not ignore it [01:55:27] <mooeypoo> So that I always output the *entire* correct state [01:55:58] <mooeypoo> and not just change the ones that were changed -- that's also wrong to do, btw. If I started with xxx:1,yyy:1 and then have xxx:0,yyy:0 they'll be ignored [01:56:00] <mooeypoo> that's not good [01:56:05] <mooeypoo> \o/ [01:56:06] <mooeypoo> I DID IT [01:56:30] <mooeypoo> ok [01:56:32] <mooeypoo> the real test [01:56:39] <mooeypoo> I'm UNCOMMENTING THE FAILING TEST! [01:56:42] * mooeypoo crosses fingers [01:57:09] <mooeypoo> OMG [01:57:19] <mooeypoo> matt_flaschen, !!! [01:57:21] <mooeypoo> guess what [01:57:32] <matt_flaschen> mooeypoo, waht? [01:57:35] <matt_flaschen> what [01:57:42] <mooeypoo> it fails, but because it showed filter1:false,filter2:false,filter3:false instead of true,true,true [01:57:42] <matt_flaschen> Sorry, was PageTriage-ing. [01:57:45] <mooeypoo> WHICH IS EVEN BETTER!! [01:57:50] * mooeypoo jumps [01:57:52] <mooeypoo> you were right [01:58:17] <mooeypoo> the problem was ignoring the things that weren't in hasSelected [01:59:37] <matt_flaschen> mooeypoo, cool, so are you going to rely on it being right called twice, or still make the controller do it for real? [01:59:55] <mooeypoo> matt_flaschen, https://gerrit.wikimedia.org/r/#/c/320332/24..25/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js [02:00:01] <mooeypoo> I think we can do either now [02:00:15] <mooeypoo> I am not sure which one's better, but I am also not sure I see a difference now [02:00:40] <mooeypoo> I mean, the controller can go and say "I'll fetch all the things I need, build it for the model and give it to it" or "I'll fetch all the things and give them one by one to the model" [02:00:47] <mooeypoo> either one of those sound like a decent approach to me [02:01:03] <mooeypoo> matt_flaschen, see the diff, though -- I literally just stopped ignoring hasSelected, like you suggested. [02:01:25] <mooeypoo> (cleaning it up now) [02:02:47] <matt_flaschen> mooeypoo, and special logic so if it's all unselected, it's all unchecked, rather than all checked. I see. [02:03:20] <RoanKattouw> Hmm, vagrant is great until you have to run vagrant provision or vagrant git-update [02:03:39] <RoanKattouw> Once you do that, you better have plans to make a big pot of coffee [02:04:05] <RoanKattouw> I think I'll take the train to the bike store, pick up my bike and ride it back here, that should leave enough time for git-update to finish <_< [02:04:11] <mooeypoo> matt_flaschen, yeah, we may have issues later with that in the UI [02:04:31] <mooeypoo> It's a little confusing if you literally check all items in the group, but then when you refresh the page with the same URL, all the items are *unselected* [02:04:34] <mooeypoo> it makes sense, it's just weird [02:04:43] <matt_flaschen> RoanKattouw, yeah. I don't often run vagrant git-update for that reason, though occasionally that does lead to issues. (and I run vagrant provision more often when actually doing Vagrant dev) [02:04:52] <mooeypoo> but all=selected is the same as all=unselected [02:05:00] <RoanKattouw> mklove/modules/configure.base: fork: Cannot allocate memory [02:05:01] <RoanKattouw> Sigh [02:05:08] <RoanKattouw> My vagrant is super slow and then this kind of stuff happens [02:05:26] <matt_flaschen> RoanKattouw, probably both for the same reason. Can you give the guest more RAM? [02:05:30] <matt_flaschen> What does: [02:05:33] <matt_flaschen> vagrant config vagrant_ram [02:05:33] <RoanKattouw> Even more? [02:05:34] <matt_flaschen> show? [02:05:49] <matt_flaschen> vagrant config --get vagrant_ram [02:05:53] <matt_flaschen> I give it 3000 [02:05:57] <RoanKattouw> 3072 [02:06:24] <matt_flaschen> RoanKattouw, what is mklove? [02:06:26] <RoanKattouw> But ahm, small problem [02:06:28] <RoanKattouw> ps aux | grep apache2 | wc -l [02:06:30] <RoanKattouw> 152 [02:06:34] * RoanKattouw restarts apache [02:06:42] <RoanKattouw> matt_flaschen: Some build step in some NPM module in some Makefile somewhere [02:06:49] <mooeypoo> matt_flaschen, same code, just cleaned up a bit (and I removed the "you should only use this method once" comment) https://gerrit.wikimedia.org/r/#/c/320332/24..26/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js [02:06:57] <mooeypoo> This was awesome, thanks for this [02:07:03] <RoanKattouw> WTF why are there 150 Apache worker processes [02:07:04] <matt_flaschen> mooeypoo, we should just gamify it. If you check all the boxes, it should drop candies from the top of the screen then uncheck the boxes. [02:07:11] <mooeypoo> rofl [02:07:13] <matt_flaschen> mooeypoo, no problem. [02:07:23] <RoanKattouw> /usr/sbin/apache2 -D ELDevServer -D ZEND -k start [02:07:34] <RoanKattouw> Are you kidding me, 150 processes for the damn EventLogging dev server? [02:07:34] <matt_flaschen> mooeypoo, and then says (with actual audio): "New Level!" and scrolls you to a new filter group with more check boxes. [02:07:42] <mooeypoo> \o/ [02:08:04] <RoanKattouw> OK now I'm at 7, that should help [02:08:20] <mooeypoo> RoanKattouw, what the hell are you eventlogging?! [02:08:36] <matt_flaschen> There is something symbolic about the modern world that 1-pixel invisible gifs can crash a virtual machine. [02:08:44] <RoanKattouw> haha [02:08:54] <RoanKattouw> OK now I only have 6 Apache procs [02:09:07] <RoanKattouw> So I'll try git-update again [02:30:30] <grrrit-wm> (03PS9) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) [02:31:35] <grrrit-wm> (03CR) 10Mattflaschen: "Patches this depends on have been merged (thanks :))" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [02:31:47] <matt_flaschen> ^ mooeypoo, RoanKattouw [02:32:36] <RoanKattouw> Whee [02:33:04] <RoanKattouw> I'll look tomorrow [02:33:38] <RoanKattouw> Now on my way to the bike shop, then if Vagrant is done when I get back I'll test some of the FlaggedRevs patches [02:47:00] <mooeypoo> O.O matt_flaschen mw.Map ? [02:47:03] <mooeypoo> que? [02:50:45] <mooeypoo> ... matt_flaschen $.pageTriageDeletionTagsOptions is ... a .... variable.... O.O [02:50:48] * mooeypoo cringes [02:50:59] <mooeypoo> I know it has nothing to do with *your* fix, but I can't help the cringe [03:10:49] <matt_flaschen> ¿mooeypoo, que is tu pregunta sobre mw.Map? [03:11:22] <mooeypoo> I can't find it and I don't understand what it does? [03:11:34] <mooeypoo> mediawiki.Map no es un file [03:11:52] <matt_flaschen> mooeypoo, re pageTriageDeletionTagsOptions, to be fair, it's intended to be overriden on-wiki, so there's a reason it's global. [03:12:08] <grrrit-wm> (03CR) 10Mooeypoo: [C: 04-1] "Petty comments. Looks good otherwise, and works well." (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [03:12:11] <mooeypoo> matt_flaschen, I'm being super petty [03:12:13] <matt_flaschen> That way, to customize enwiki, you can either modify PageTriage (since it's only deployed there), or customize it in MedaiWiki namespace on enwiki... [03:12:17] <mooeypoo> Code looks good to me otherwise [03:12:38] <matt_flaschen> mooeypoo, mw.Map is an associative array, like a built-in object, but it has some special features. [03:12:39] <mooeypoo> We usually use mw.blah to do global [03:12:45] <mooeypoo> $.something is a jQuery extension [03:12:50] <matt_flaschen> mooeypoo, ah, yeah, that part is questionable. [03:13:00] <mooeypoo> yeah i just cringed for that :\ [03:13:13] <mooeypoo> hmm... okay, I didn't really understand what you did with the wrapping of the mw.message bit [03:13:26] <matt_flaschen> mooeypoo, https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Map [03:13:30] <mooeypoo> but I guess you have to? I just didn't understand what was going on there, it seemed just straight forward duplicating to me [03:13:42] <mooeypoo> ah! thanks [03:14:09] <matt_flaschen> mooeypoo, the difference is that standard mw.message()/mw.msg() is user-interface language, mine is content language. [03:14:30] <matt_flaschen> mooeypoo, hence what I asked you to test regarding Hebrew UI language on an English wiki (though I should have said Spanish on English...) [03:14:43] <matt_flaschen> You're probably thinking, "But why did you implement that in PageTriage, it's a general feature?..." [03:15:00] <matt_flaschen> I considered implementing it in core, but we were worried it was too rabbit-holey. [03:15:16] <mooeypoo> oh [03:15:32] <mooeypoo> wow I didn't think about that [03:16:05] <mooeypoo> wait, where's the content language passing? [03:16:27] <matt_flaschen> mooeypoo, I made a Resource Loader module. :) [03:16:32] <mooeypoo> https://gerrit.wikimedia.org/r/#/c/311856/9/modules/ext.pageTriage.util/ext.pageTriage.messageUtil.js <-- that's where I was confused, you basically have a map, and then key and params [03:16:34] <mooeypoo> oh [03:16:39] <mooeypoo> rofl [03:16:43] <matt_flaschen> includes/PageTriageMessagesModule.php [03:17:03] <mooeypoo> I saw it and wasn't 100% sure I understood what it was for [03:17:05] <mooeypoo> that explains it [03:18:00] <matt_flaschen> mooeypoo, you're right, though, if I did it right, the client-side should behave the same. Except you get content language, and to get a mw.Message object, you call mw.pageTriage.contentLanguageMessage instead of mw.message. [03:18:15] <mooeypoo> matt_flaschen, maybe you should specify in the main documentation that it's sending the content language, since that seems to be its primary function [03:18:35] * mooeypoo nods [03:18:50] <mooeypoo> yeah no it makes sense now, I completely forgot that mw.msg is interface [03:19:05] <mooeypoo> We should add a flag or something [03:19:13] <mooeypoo> hm [03:19:19] <mooeypoo> mw.msg( true, key, params...) [03:19:21] <mooeypoo> ^ content [03:19:34] <mooeypoo> mw.msg( key, params... ) [03:19:36] <mooeypoo> ^ interface [03:19:37] <mooeypoo> there. [03:19:44] <mooeypoo> Do we need an RfC for this? [03:19:45] <mooeypoo> :D [03:19:47] <matt_flaschen> mooeypoo, there's a bug about it, T27349 . [03:19:48] <stashbot> T27349: ResourceLoader: Support loading of messages in parsed formats (e.g. parsed, incontentlanguage, ..) - https://phabricator.wikimedia.org/T27349 [03:20:08] <matt_flaschen> I prefer inContentLanguage (same as server-side). [03:21:55] <mooeypoo> yeah but there's something to be said about using the same api [03:22:18] <grrrit-wm> (03CR) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [03:22:32] <mooeypoo> so, uhm, I have not spent a lot in the php side of mw, so what are the conventions regarding documentation? [03:22:45] <mooeypoo> because in JS RoanKattouw is on my case when I don't document a method [03:22:58] <mooeypoo> but entire PHP files are undocumented in mw-core as a whole [03:23:38] <mooeypoo> matt_flaschen, in other words, there's no documentation in -- https://gerrit.wikimedia.org/r/#/c/311856/9/includes/PageTriageMessagesModule.php [03:23:46] <mooeypoo> is that because it's just @inheritdoc ? [03:24:06] <RoanKattouw> Documentation discipline in our PHP code is not great to say the least [03:24:20] <RoanKattouw> The average age of our PHP code is also higher, because there was very little JS code in MW before 2009-2010 [03:25:51] <matt_flaschen> mooeypoo, yes, I believe so. I did check this a while ago: http://www.stack.nl/~dimitri/doxygen/manual/config.html#cfg_inherit_docs [03:26:02] <RoanKattouw> Also note the task number of the content language bug [03:26:09] <matt_flaschen> mooeypoo, inheritdoc is the default if you put absolutely nothing. [03:26:15] <mooeypoo> I mean, as someone who's fairly illiterate in our PHP side, I hate that methods are so undocumented [03:26:28] <mooeypoo> but putting nothing is pretty much the same as @inheritdoc [03:26:32] <mooeypoo> so it doesn't matter in this case [03:26:39] <RoanKattouw> Low 5 digits means it's pretty old [03:26:50] <mooeypoo> there ARE cases in our code where it's maddeningly undocumented [03:27:04] <matt_flaschen> mooeypoo, yeah, agree, especially on PHP side. [03:27:13] <matt_flaschen> And if I am missing docs, do let me know and I'll fix it. [03:27:18] * mooeypoo nods [03:27:29] <mooeypoo> I just saw it there, but that's just the way to say "inherit" then it's fine [03:35:28] <matt_flaschen> mooeypoo, of course, now that I look for an example, it doesn't work: https://doc.wikimedia.org/mediawiki-core/master/php/classDatabasePostgres.html#ab9c7500aeb9bd91f0526c137d66446af [03:35:53] <mooeypoo> meh [03:35:58] <mooeypoo> well, half our files are like that :\ [03:36:04] <mooeypoo> at this point we need to fix the documentation engine [03:40:48] <mooeypoo> ok I'm going to make dinner and retire for the evening [03:40:51] <mooeypoo> see you tomorrow! [03:42:56] <matt_flaschen> mooey|away, have a good night. [03:42:58] <matt_flaschen> Also, T152478 [03:42:58] <stashbot> T152478: Doxygen method docs are not inherited (only when abstract classes are involved?) - https://phabricator.wikimedia.org/T152478 [04:27:03] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script for causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849716 (10demon) [04:27:22] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849729 (10demon) [07:24:07] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849716 (10Catrope) This is a semi-duplicate of {T152379}, except that bug describes an earlier issue where Flow was... [08:30:08] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849944 (10Paladox) This problem could have been caused by extension.j... [08:38:01] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849946 (10Reedy) >>! In T152379#2849944, @Paladox wrote: > This probl... [08:45:48] <wikibugs> 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2849948 (10Qgil) In that case, this session is appropriate for the Unconference. [08:46:05] <wikibugs_> 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2849950 (10Qgil) [08:52:06] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849955 (10Paladox) Are these configs meant to be in the config sectio... [08:58:28] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849962 (10Reedy) >>! In T152379#2849955, @Paladox wrote: > Are these... [09:03:13] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849966 (10Paladox) It seems to now be aborting on 07:20:19 ...rev_user_ip in table flow_revision already modified... [09:07:44] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849967 (10Paladox) It looks like that config isent in there instead i... [09:11:13] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849987 (10Paladox) It last passed on https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/13275/ so... [09:13:45] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849716 (10Reedy) The problem seems to be many unapplied schema patches, and jobs that take a long time I'm running... [09:19:07] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849991 (10Paladox) I guess you've found the problem. Probably need to add all those sql files to the updated hook s... [09:24:35] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2849993 (10Reedy) Lots of these on enwiki... ``` enwiki: Checked a t... [10:02:42] <grrrit-wm> (03PS1) 10Legoktm: Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 [10:12:29] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 (owner: 10Legoktm) [10:13:12] <grrrit-wm> (03PS2) 10Legoktm: Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 [12:12:47] <grrrit-wm> (03PS1) 10Sbisson: Remove FlowFixInconsistentBoards maintenance script from update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325538 (https://phabricator.wikimedia.org/T152379) [12:14:23] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible, 13Patch-For-Review: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2850208 (10SBisson) This is caused by https://ge... [12:20:08] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Remove FlowFixInconsistentBoards maintenance script from update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325538 (https://phabricator.wikimedia.org/T152379) (owner: 10Sbisson) [12:32:40] <grrrit-wm> (03Merged) 10jenkins-bot: Remove FlowFixInconsistentBoards maintenance script from update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325538 (https://phabricator.wikimedia.org/T152379) (owner: 10Sbisson) [13:21:46] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2850319 (10Paladox) It seems to be fixed now https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/1... [13:22:34] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible, and 2 others: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2850323 (10Paladox) It is now fixed, see https://integra... [13:22:51] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2850324 (10Paladox) Fixed with https://gerrit.wikimedia.org/r/#/c/325538/ [13:50:29] <grrrit-wm> (03PS3) 10Reedy: Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 (owner: 10Legoktm) [13:50:32] <grrrit-wm> (03CR) 10Reedy: [C: 032] Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 (owner: 10Legoktm) [14:04:32] <grrrit-wm> (03Merged) 10jenkins-bot: Properly define namespace in extension.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325522 (owner: 10Legoktm) [14:40:49] <wikibugs_> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2850568 (10Pginer-WMF) >>! In T149385#2843073, @jmatazzoni wrote: > I think options #2 or #3 could work. I did a spot... [15:46:03] <wikibugs_> 06Collaboration-Team-Triage, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2850762 (10SBisson) a:05SBisson>03None I wish I had time to work on this but I don't. When I did work on it during the Jerusalem hackathon, I found that where log entries are create... [16:24:16] <wikibugs_> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2850892 (10SBisson) [17:55:05] <quiddity> I'll be 10 min late. [18:04:38] <wikibugs_> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-PageCuration, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Special:NewPagesFeed incorrectly states "No Categories" when categories exist - https://phabricator.wikimedia.org/T147721#2851203 (10Etonkovidova) Checked in betalabs - whe... [18:11:08] <wikibugs_> 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2851222 (10kaldari) We'll probably want to make some of these conditional based on namespace (and more closely m... [18:17:18] <wikibugs_> 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07ArchCom-Has-shepherd, and 2 others: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2851241 (10daniel) [18:17:28] <wikibugs> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2851242 (10SBisson) For future reference, notifications can be generated in 6 foreign wiki... [18:21:03] <James_F> Is installing GuidedTours on a multi-lingual wiki (Meta) going to cause any issues? Anything special need to be done before adding it? [18:31:39] <mooeypoo> James_F, I don't think so, but matt_flaschen would know ^^ [18:36:16] <matt_flaschen> James_F, no. It is $wgLanguageCode 'en' (all the wikis are single-language at that level). The multi-lingual stuff is mostly conventions AFAIK. GuidedTour has good multi-lingual support. Let me know if you run into issues, though. [18:36:19] <matt_flaschen> It should be fine. [18:36:44] * James_F nods. [18:36:52] <James_F> Awesome, thank you. I'll file a Task. [18:41:22] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 07NewPHP: PHP Fatal error: Cannot use 'Null' as class name as it is reserved - https://phabricator.wikimedia.org/T152278#2843705 (10Catrope) This appears to be specific to PHP 7: https://3v4l.org/giYc4 [18:41:30] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 07NewPHP: PHP Fatal error: Cannot use 'Null' as class name as it is reserved - https://phabricator.wikimedia.org/T152278#2851361 (10Catrope) a:03Catrope [18:45:46] <wikibugs_> 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Special-pages: "What links here" and "Page information" should not appear on Special:NewPagesFeed - https://phabricator.wikimedia.org/T152319#2844610 (10Catrope) It's not clear to me why this happens; maybe it's because SpecialNewP... [18:46:21] <wikibugs> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible, and 2 others: Beta update.php fails:The content model 'CONTENT_MODEL_FLOW_BOARD' is not registered on this wiki. - https://phabricator.wikimedia.org/T152379#2851374 (10Catrope) 05Open>03Resolved a:03Catrope [18:48:03] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2851401 (10Catrope) 05Open>03Resolved a:03Catrope [18:48:34] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 06Release-Engineering-Team, 07Beta-Cluster-reproducible: Maintenance script causing failed DB updates on Beta - https://phabricator.wikimedia.org/T152479#2849716 (10Catrope) a:05Catrope>03SBisson [18:50:50] <wikibugs_> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#2851408 (10Catrope) [19:09:11] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Split up $wgEchoConfig [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [19:09:26] <James_F> RoanKattouw: https://gerrit.wikimedia.org/r/#/c/211298/ too? [19:09:43] <RoanKattouw> Yes please [19:09:48] <RoanKattouw> Pull the trigger on that whole stack [19:09:53] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [19:10:16] <James_F> And https://gerrit.wikimedia.org/r/#/c/287836/ ? :-) [19:11:42] <RoanKattouw> Yes, that one too [19:11:51] <RoanKattouw> There are some outstanding patches but they're all small and/or dormant [19:13:06] <grrrit-wm> (03CR) 10Jforrester: [C: 032] build: Update mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287836 (owner: 10Legoktm) [19:21:08] <grrrit-wm> (03PS1) 10Catrope: Rename Flow\Import\SourceStore\Null to NullImportSourceStore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325608 (https://phabricator.wikimedia.org/T152278) [19:21:31] <grrrit-wm> (03Merged) 10jenkins-bot: Split up $wgEchoConfig [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [19:21:31] <wikibugs> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07NewPHP, 13Patch-For-Review: PHP Fatal error: Cannot use 'Null' as class name as it is reserved - https://phabricator.wikimedia.org/T152278#2851528 (10Catrope) [19:21:34] <grrrit-wm> (03Merged) 10jenkins-bot: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [19:22:46] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: Need tabs to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#2851535 (10Quiddity) [19:22:58] <wikibugs> 06Collaboration-Team-Triage, 10Flow: Content page is always two clicks away - https://phabricator.wikimedia.org/T152192#2851539 (10Quiddity) [19:23:00] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: Need tabs to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#1055310 (10Quiddity) [19:25:18] <grrrit-wm> (03PS1) 10Catrope: Call setHeaders() in SpecialNewPagesFeed::execute() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/325611 (https://phabricator.wikimedia.org/T152319) [19:25:36] <wikibugs> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-PageCuration, 10MediaWiki-Special-pages, 13Patch-For-Review: "What links here" and "Page information" should not appear on Special:NewPagesFeed - https://phabricator.wikimedia.org/T152319#2851552 (10Catrope) a:03Catrope [19:25:49] <mooeypoo> RoanKattouw, outstanding as in waiting or as in awesome [19:25:54] <mooeypoo> English... [19:25:59] <RoanKattouw> haha [19:26:00] <RoanKattouw> waiting [19:26:37] * mooeypoo is waiting for her patch in the queue to pass jenkins tests [19:28:17] <grrrit-wm> (03Merged) 10jenkins-bot: Update Maintenance scripts to use $this->requireExtension() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [19:29:44] <mooeypoo> everything is queued forever [19:34:39] <grrrit-wm> (03Merged) 10jenkins-bot: build: Update mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287836 (owner: 10Legoktm) [19:43:25] <mooeypoo> \o/ it paaaaaaaased https://gerrit.wikimedia.org/r/#/c/320332 [19:55:17] <wikibugs_> 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Opening help dialog in Flow VE (CTRL+?) throws an exception - https://phabricator.wikimedia.org/T151096#2851813 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF [19:57:50] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/321465 (owner: 10Anomie) [19:57:52] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/321437 (owner: 10Anomie) [19:58:53] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 (owner: 10Anomie) [20:01:17] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/321426 (owner: 10Anomie) [20:01:28] <RoanKattouw> whee [20:03:33] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/321421 (owner: 10Anomie) [20:05:23] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: Adding Categories to Flow post and topic Summary usability issues - https://phabricator.wikimedia.org/T152533#2851903 (10Etonkovidova) [20:06:38] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: Need tabs to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#2851920 (10Kghbln) Oh, so I reported this bug twice myself. Am I the only one using Flow heavily? [20:14:08] <RoanKattouw> LOL [20:14:17] <quiddity> >.> [20:16:02] <quiddity> It would have driven me insane, if I didn't have navpopups. [20:29:16] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update for API error i18n [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/321445 (owner: 10Anomie) [20:31:22] <wikibugs> 06Collaboration-Team-Triage, 10Flow: [minor] Re-opening resolved topic from History does display a topic title - https://phabricator.wikimedia.org/T152541#2852093 (10Etonkovidova) [20:32:12] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: [minor] Re-opening resolved topic from History does not display a topic title - https://phabricator.wikimedia.org/T152541#2852105 (10Etonkovidova) [20:33:36] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Rename Flow\Import\SourceStore\Null to NullImportSourceStore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325608 (https://phabricator.wikimedia.org/T152278) (owner: 10Catrope) [20:34:21] <legoktm> \o/ [20:43:07] <grrrit-wm> (03Merged) 10jenkins-bot: Update for API error i18n [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/321445 (owner: 10Anomie) [20:44:10] <grrrit-wm> (03Merged) 10jenkins-bot: Rename Flow\Import\SourceStore\Null to NullImportSourceStore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325608 (https://phabricator.wikimedia.org/T152278) (owner: 10Catrope) [20:48:36] <wikibugs_> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2852190 (10Samwalton9) Just wanted to ch... [21:04:51] <wikibugs> 06Collaboration-Team-Triage, 10Flow: WhatLinks Here displays cryptic topic titles - https://phabricator.wikimedia.org/T152548#2852253 (10Etonkovidova) [21:09:32] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: WhatLinksHere displays cryptic topic titles - https://phabricator.wikimedia.org/T152548#2852272 (10Etonkovidova) [21:26:33] <wikibugs> 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07NewPHP, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): PHP Fatal error: Cannot use 'Null' as class name as it is reserved - https://phabricator.wikimedia.org/T152278#2852377 (10Legoktm) 05Open>03Resolved [22:20:52] <wikibugs> 06Collaboration-Team-Triage, 10Flow: Special:Preference how an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2852560 (10jeblad) [22:21:33] <wikibugs_> 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2852573 (10jeblad) [22:22:36] <wikibugs> 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2852560 (10jeblad) [22:45:10] <wikibugs> 06Collaboration-Team-Triage, 10Flow: Special:Preference has an unticked preference for Flow, even if the subsystem is activated - https://phabricator.wikimedia.org/T152560#2852560 (10Catrope) This may well be fallout from when the Flow beta feature was temporarily disabled. [23:34:05] <mooeypoo> RoanKattouw, guess what [23:34:44] <mooeypoo> RoanKattouw, https://gerrit.wikimedia.org/r/#/c/320332/28/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js [23:35:34] <RoanKattouw> Nice [23:35:39] <mooeypoo> RoanKattouw, also, https://gerrit.wikimedia.org/r/#/c/320332 [23:35:40] <RoanKattouw> So it does work? [23:35:43] <mooeypoo> ^ You can look now [23:35:49] <mooeypoo> no, I just thought the code looks nice [23:35:52] <mooeypoo> ... of course it works! [23:35:53] <mooeypoo> :P [23:36:16] <RoanKattouw> lol [23:36:29] <mooeypoo> I just had to add the "check if the input already exists" check, because I forgot that if you already load the page with parameter values, it already adds the hidden <input> [23:37:34] <mooeypoo> RoanKattouw, this necessarily creates bigger URLS, though. [23:37:47] <mooeypoo> but that will happen in this system anyways, to make sure we are overriding user defaults/settings [23:38:13] <mooeypoo> so if I take a URL with results and give it to you, you should see as close to my results as possible, regardless of your different settings [23:38:24] <mooeypoo> so all filter states -- selected or not -- are added in. [23:38:34] <mooeypoo> We might want to make this more efficient later [23:39:12] <mooeypoo> RoanKattouw, but yeah, it's ready for proper review. If it does get merged, though, please also merge the commit above it -- Matt's hidden preference commit