[00:08:20] Taking a break. [00:11:53] (03CR) 10Mooeypoo: [C: 031] "I should have +1'ed before, sorry -- I tested the code and it works great (added a small unrelated rtl fix afterwards) It works great!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [00:12:00] matt_flaschen, sorry, I should've +1'ed bck then, I forgot. [00:12:09] * mooeypoo goes back to making another batch of chicken soup [00:12:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2840371 (10jmatazzoni) I want to reverse direction on "Page edits." I think that name works reasonably well in contex... [00:47:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#2840415 (10jmatazzoni) [00:48:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#2840415 (10jmatazzoni) [00:48:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#2840415 (10jmatazzoni) a:03SBisson [00:49:48] Hmm. [00:49:59] I'm getting "ext.pageTriage.toolbarView.js?48d79:42 Uncaught TypeError: mw.pageTriage.WikiLoveView is not a constructor" [00:50:12] (In debug mode on Beta Cluster enwiki.) [00:50:27] Is this a known bug? Something I should ignore? [00:51:38] (Nothing recently merged in either PageTriage or WikiLove… [00:58:43] Not aware of that [01:30:11] (03CR) 10Jforrester: [C: 031] Split up $wgEchoConfig [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [01:30:41] (03CR) 10Jforrester: [C: 032] Split up $wgEchoConfig [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [01:30:53] (03CR) 10Jforrester: [C: 031] "Bah. Shouldn't really be merged until I6343e469c9 is." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [01:33:28] (03CR) 10Catrope: "Wrong config change?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [01:34:27] James_F: Your comment reminds me that I totally missed my SWAT window [01:34:27] Argh [01:34:55] RoanKattouw: Yeah, I was going to SWAT it for you but… [01:35:30] (03CR) 10Jforrester: "Quite so, ahem: I544f37dd5" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 (owner: 10Catrope) [01:36:38] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2840566 (10Catrope) I scheduled this for deployment at 4pm PST... [01:37:03] RoanKattouw: Will have to wait for Monday, and then I'd recommend not doing the extension.json change until after the Tuesday train. [01:37:11] Trizek: Argh, belay that, I forgot to attend the 4pm SWAT and so my change never went live. Flow beta feature re-enable now rescheduled for 11am Monday [01:37:21] James_F: Yes that makes sense regardless [01:39:20] RoanKattouw: Want me to make some reminder appointments? :-) [01:39:29] Yes please [02:43:22] James_F, 'recently' is a strong word, but I may have broken that in https://gerrit.wikimedia.org/r/#/c/310956/ . Checking now. [02:43:55] The PageTriage thing [02:44:06] Whoops. [02:48:09] James_F, indeed. In my defense it works fine in production mode. Trying to figure out the fix now. [02:48:52] Debug mode is pretty harsh in its judgements. [03:01:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2840747 (10Krinkle) >>! In T152037#2838152, @Trizek-WMF wrote: > https://meta.w... [03:06:24] (03PS1) 10Mattflaschen: Correctly register WikiLove before toolbarView [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/324857 [03:06:43] ^ James_F, fixed. :) It's a race, and even works in debug mode locally (at least the times I tried). [03:08:07] That's going to make the conversion to extension.json even easier. ;-) [03:08:10] But yay. [03:08:54] 06Collaboration-Team-Triage, 10Notifications, 10Refreshed, 07Design, 07Mobile: When not using MobileFrontend, Echo does not appear well on small screens, because it does not use responsive design - https://phabricator.wikimedia.org/T126106#2840765 (10Mattflaschen-WMF) p:05High>03Low [07:28:37] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, and 2 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#2840911 (10Marostegui) Thanks! We will take it from here! [09:24:06] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-History-or-Diffs, 10Wikimedia-Developer-Summit (2017): Next steps for edit review - https://phabricator.wikimedia.org/T149664#2841094 (10Qgil) In terms of room capacity and configuration, what would be your pre... [09:25:05] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2841096 (10Qgil) In terms of room capacity and configuration, what would be your preference? * The biggest room in theater configuration (u... [09:25:40] 06Collaboration-Team-Triage, 10Flow, 10Editing-UX-Research, 10MediaWiki-Patrolling, and 3 others: UX to create safe spaces - https://phabricator.wikimedia.org/T149665#2841097 (10Qgil) In terms of room capacity and configuration, what would be your preference? * The biggest room in theater configuration (u... [09:26:03] 06Collaboration-Team-Triage, 06Editing-Department, 10Editing-UX-Research, 10MediaWiki-General-or-Unknown, and 4 others: Next Steps for Real Time Collaboration - https://phabricator.wikimedia.org/T149663#2841098 (10Qgil) In terms of room capacity and configuration, what would be your preference? * The bigg... [09:26:44] 06Collaboration-Team-Triage, 10Flow: Content page always two ckicks away - https://phabricator.wikimedia.org/T152192#2841099 (10Kghbln) [09:29:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2841112 (10Qgil) In terms of room capacity and configuration, what would be your prefer... [09:48:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2841120 (10Pginer-WMF) >>! In T149385#2839984, @jmatazzoni wrote: >> I'm ok in being consistent on what each wiki use... [10:03:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2841132 (10Pginer-WMF) >>! In T149385#2840249, @jmatazzoni wrote: > The user tests--particularly the last one--left m... [10:33:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Follow up with communities about Flow Beta feature break - https://phabricator.wikimedia.org/T147562#2841153 (10Trizek-WMF) p:05High>03Normal >>! In T138310#2840... [10:55:01] 06Collaboration-Team-Triage, 10Flow: Content page is always two clicks away - https://phabricator.wikimedia.org/T152192#2841200 (10Aklapper) [13:34:36] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 13Patch-For-Review: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#2841491 (10Pginer-WMF) >>! In T139525#2835728, @KMuthu wrote: > Please let me know if it looks fine. Thanks @KMuthu. It lo... [14:31:05] (03CR) 10Sbisson: "'page' is a rather large table with no index on 'page_content_model'. Do you think it's going to be problematic in production?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [16:06:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2841826 (10Halfak) Please raise this on the on-wiki discussion too. https:/... [16:54:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2841973 (10jmatazzoni) I don't think we need to record the session. And I'd expect no m... [17:20:31] 06Collaboration-Team-Triage, 10Thanks: Allow thanking for log actions - https://phabricator.wikimedia.org/T152218#2842046 (10Guycn2) [17:35:55] 06Collaboration-Team-Triage, 10Thanks: Allow thanking for log actions - https://phabricator.wikimedia.org/T152218#2842118 (10Legoktm) [17:35:58] 06Collaboration-Team-Triage, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2842116 (10Legoktm) [18:31:13] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#2842217 (10Mattflaschen-WMF) [18:34:43] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Ask communities which have allowed Flow trials with manual enabling to switch to Bet... - https://phabricator.wikimedia.org/T143470#2842254 [18:37:51] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#2842263 (10Mattflaschen-WMF) [18:37:53] 06Collaboration-Team-Triage, 10Flow: Flow: Test whether Flow works with dynamic-user-language templates - https://phabricator.wikimedia.org/T60762#2842265 (10Mattflaschen-WMF) [18:46:01] RoanKattouw, if you convert PageTriage to extension registration, can you start from https://gerrit.wikimedia.org/r/#/c/324857/ . Just did a fix for WikiLove conditional registration. [18:47:55] Breaking for lunch then Spanish group. [18:55:07] 06Collaboration-Team-Triage, 10Flow, 10Wikidata: Templates calling Wikidata elements don't display the result in the user language on Flow - https://phabricator.wikimedia.org/T134158#2842314 (10Trizek-WMF) [18:55:09] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#2842317 (10Trizek-WMF) [18:56:56] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#1475109 (10Trizek-WMF) That issue may be a blocker for communities that use variation of interface language and... [18:58:15] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#2842335 (10Trizek-WMF) [19:07:04] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842367 (10jmatazzoni) [19:49:33] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 13Patch-For-Review: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#2842464 (10KMuthu) >>! In T139525#2841491, @Pginer-WMF wrote: >>>! In T139525#2835728, @KMuthu wrote: >> Please let me know... [19:56:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842473 (10jmatazzoni) [20:02:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842494 (10jmatazzoni) [20:06:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842506 (10jmatazzoni) @Pginer-WMF, I updated the text in two sections: - Changed the Review Status section as dis... [20:07:54] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842507 (10jmatazzoni) [20:09:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2750649 (10jmatazzoni) [20:16:26] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842519 (10jmatazzoni) [20:19:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842539 (10jmatazzoni) [20:24:56] (03CR) 10Catrope: [C: 032] Correctly register WikiLove before toolbarView [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/324857 (owner: 10Mattflaschen) [20:25:11] matt_flaschen: Thanks for pointing that out, I just merged it instead so I can work off master [20:26:12] (03Merged) 10jenkins-bot: Correctly register WikiLove before toolbarView [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/324857 (owner: 10Mattflaschen) [20:27:03] (03CR) 10Catrope: "It'll be a slow query, but not terribly slow. I've run it before and it takes a couple minutes at most. It'll only be run once and in a no" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [20:33:35] RoanKattouw, thanks. [20:35:14] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Review status' filters - https://phabricator.wikimedia.org/T152061#2842588 (10jmatazzoni) [20:35:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Review status' filters - https://phabricator.wikimedia.org/T152061#2836936 (10jmatazzoni) [20:36:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Review status' filters - https://phabricator.wikimedia.org/T152061#2836936 (10jmatazzoni) [20:57:16] 06Collaboration-Team-Triage, 10Flow, 07I18n: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}) - https://phabricator.wikimedia.org/T106687#1475109 (10Sylvain_WMFr) [21:00:45] RoanKattouw, if you could review https://gerrit.wikimedia.org/r/#/c/311178/ and https://gerrit.wikimedia.org/r/#/c/311866/ too, that would be helpful. Those are pre-requisities for my main PageTriage Flow fix. [21:01:06] Both fairly simple, the Flow one is a little more elaborate. [21:50:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Regression: [regression 1.29.0-wmf.3] Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2842832 (10Etonkovidova) 05Resolved>03Open [21:50:47] 06Collaboration-Team-Triage, 10Flow: See which Flow posts contain the latest updates, via the 'cur' in history pages - https://phabricator.wikimedia.org/T114302#2842835 (10Mattflaschen-WMF) [21:55:07] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#2842842 (10Mattflaschen-WMF) [21:55:56] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1645088 (10Mattflaschen-WMF) [22:24:04] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 13Patch-For-Review: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#2434810 (10Catrope) >>! In T139525#2841491, @Pginer-WMF wrote: >>>! In T139525#2835728, @KMuthu wrote: >> Please let me kno... [23:05:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2843073 (10jmatazzoni) @Pginer-WMF, regarding your suggestion to put the recall part of the ORES filter formulation f...