[00:01:07] Err. [00:01:32] Yes, I suppose. Most extensions don't have much confit. [00:14:51] Alright, I have a core patch coming in, with that I was finally able to test the extension.json patch for Echo, and it works [00:18:35] Woo [00:18:51] thanks James_F for getting that pushed through... Even if it broke somethings ;) [00:20:35] RoanKattouw: I was going to say you probably wouldn't believe the shit we've encountered [00:20:46] Then I remembered you've been around a long time, so of course you would :) [00:21:41] Reedy: :-) [00:21:49] Reedy: Feel like merging https://gerrit.wikimedia.org/r/#/c/324628/ ? [00:22:24] Will have a look in a few [00:23:59] heh yeah maybe [00:24:14] I imagine there would be a lot of random crap dealing with so many extensions [00:24:20] and such a freeform config "system" [00:24:38] RoanKattouw: Yeah. [00:24:41] I think the idea is: [00:24:51] 1) Convert to a registration system with static JSON files. [00:24:54] (03PS38) 10Catrope: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [00:24:57] (patches uploading, plane descending) [00:25:08] 2) Evolve the system to be consistent and narrower. [00:25:22] 3) Implement in-DB and on-wiki (not necessarily for WMF cluster). [00:25:30] Nice. Land safely. ;-) [00:26:15] Yeah [00:26:29] It's definitely a multi stage process [00:26:35] Indeed. [00:26:45] Just "1)" is actually several hundred steps long. [00:26:51] So much "dynamic" config... [00:26:58] So many oddities and "this should work!" [00:27:04] Essentially, all work on MediaWiki is infinite and fractal. [00:27:05] ;-) [00:27:06] (03CR) 10Paladox: Add extension.json, empty PHP entry point (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [00:27:55] And some people just don't help themselves. Or others [00:28:14] * James_F sighs. [00:35:04] ? [00:45:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Implement functionality for RC page 'Review status' filters - https://phabricator.wikimedia.org/T152061#2836936 (10jmatazzoni) [00:48:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2836953 (10jmatazzoni) @Pginer-WMF, assuming my understanding of how this is meant to work is correct (see T152061 ),... [00:49:53] James_F: MediaWiki is also all edge cases. there is no "80% solution" to most of our problems [00:50:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2836956 (10jmatazzoni) [00:50:53] bd808: Indeed. The length of the outline of the Mandelbrot design comes to mind. ;-) [00:51:12] or the fjords in Norway [00:51:30] all those nice crinkly bits [00:51:39] I recall that there are six different official lengths of the UK coastline, dependent on sampling resolution. [00:51:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Implement functionality for RC page 'Review status' filters - https://phabricator.wikimedia.org/T152061#2836936 (10jmatazzoni) [00:52:00] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2600193 (10jmatazzoni) [01:02:28] (03PS39) 10Paladox: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) [01:06:03] (03CR) 10Reedy: "Shouldn't the merge_strategy not be under value, but at the same level as in manifest_version 2?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [01:10:07] (03PS40) 10Paladox: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) [01:10:23] (03CR) 10Paladox: "> Shouldn't the merge_strategy not be under value, but at the same" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [01:15:50] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [01:19:07] RoanKattouw: hi [01:19:32] Hey [01:19:54] Sorry about that rant, I was quite confused and tired [01:20:35] no that's totally okay [01:20:41] I'm looking at $wgEchoConfig right now [01:21:01] I think we should refactor and simplify that [01:21:25] Sure [01:21:31] That makes sense [01:21:58] A few other config vars have similar issues though [01:22:03] in general if we've been through 300+ extensions and some basic feature seems to be missing it's usually the extension doing something weird :P [01:22:23] Although they're not as likely to be overridden / added to in LocalSettings [01:22:34] Heh yeah good point [01:23:07] so like $wgEchoConfig['version'] is used for both eventlogging schema version, and cache invalidation in a memcache key?? [01:23:54] and then we shold get rid of the 'eventlogging' key, so just have $wgEchoEventLogging['Echo']['enabled'] = true; which can use array_plus_2d [01:24:14] (03PS41) 10Paladox: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) [01:25:41] does that sound reasonable? [01:42:11] Yup sounds good [01:42:14] I'll poke at that tomorrow [05:10:24] 06Collaboration-Team-Triage, 10Notifications, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog: Echo notifications on Wikipedia mobile apps (Android & iOS) - https://phabricator.wikimedia.org/T123155#1922509 (10czar) [07:30:07] (03PS2) 10VolkerE: Align echo alert colors to WikimediaUI color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324161 (owner: 10Ladsgroup) [07:30:22] (03CR) 10VolkerE: [C: 032] Align echo alert colors to WikimediaUI color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324161 (owner: 10Ladsgroup) [07:39:14] (03Merged) 10jenkins-bot: Align echo alert colors to WikimediaUI color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324161 (owner: 10Ladsgroup) [08:43:20] 06Collaboration-Team-Triage, 10Notifications, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Hacking Session: Learn to make new notification types - https://phabricator.wikimedia.org/T149246#2837607 (10Qgil) [09:10:10] (03PS12) 10Zfilipin: WIP RSpec tests for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:11:38] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review: RSpec tests for Echo Mention notificationon - https://phabricator.wikimedia.org/T146916#2837687 (10zeljkofilipin) p:05Triage>03Normal [09:11:54] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 15User-zeljkofilipin: RSpec tests for Echo Mention notificationon - https://phabricator.wikimedia.org/T146916#2674646 (10zeljkofilipin) [09:15:44] (03CR) 10Zfilipin: "Patch set 12 is just a minor update to the commit message." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:19:23] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:23:30] (03PS13) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:25:46] (03CR) 10Zfilipin: "Patch set 13 is just a minor white-space cleanup" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:31:03] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:33:27] (03PS14) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:35:38] (03CR) 10Zfilipin: "Patch set 14 moves all tests into one file." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:36:25] (03PS15) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:36:53] (03CR) 10Zfilipin: "Patch set 15 renames the test file." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:39:02] (03PS16) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:40:56] (03CR) 10Zfilipin: "Patch set 16 gives tests better names." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [09:47:28] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:00:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2837881 (10Trizek-WMF) https://www... [11:34:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2837921 (10Pginer-WMF) >>! In T149385#2836953, @jmatazzoni wrote: > ===Patrol status=== > **Unpatrolled** > Edits tha... [12:16:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2837942 (10Pginer-WMF) I also think we should keep the scope of the changes... [13:44:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2838152 (10Trizek-WMF) https://meta.wikimedia.org/wiki/Gadgets/wikipedia may gi... [16:14:37] (03CR) 10Anomie: [C: 032] "Catrope +2ed but Jenkins apparently dropped the ball. Let's resubmit." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 (owner: 10Anomie) [16:15:19] (03CR) 10Anomie: "(oh, never mind. It's waiting for a Depends-On)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 (owner: 10Anomie) [16:31:29] (03CR) 10Catrope: [C: 031] Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [16:32:13] (03CR) 10Catrope: [C: 04-1] "I'm going to redo this so we don't need array_plus_recursive" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [16:51:48] (03PS1) 10Catrope: Split up $wgEchoConfig [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324749 [17:28:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2838772 (10jmatazzoni) [18:52:12] kmuthu: https://www.mediawiki.org/wiki/Git/New_repositories/Requests [19:34:52] Getting lunch [19:50:02] (03PS42) 10Catrope: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [19:51:52] (03PS43) 10Catrope: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [19:53:51] (03PS44) 10Catrope: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [20:07:53] (03CR) 10Catrope: [C: 032] Update for API error i18n [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/321437 (owner: 10Anomie) [20:08:34] (03CR) 10Catrope: [C: 032] Update for API error i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/321465 (owner: 10Anomie) [20:09:46] 06Collaboration-Team-Triage, 10Flow: Preferences 'Restore all default settings' option does not apply to 'Flow on user talk' Beta feature - https://phabricator.wikimedia.org/T150073#2839486 (10Etonkovidova) Re-checked with `i 1.29.0-wmf.4 ` - no errors in the case >when a user attempts to disable Flow by un... [20:14:06] 20:08:56 Chrome 53.0.2785 (Linux 0.0.0) ext.echo.dm - mw.echo.dm.NotificationItem Constructing items FAILED [20:14:06] 20:08:56 Empty data (getTimestamp) [20:14:06] 20:08:56 Expected: "2016-12-01T20:08:55Z" [20:14:06] 20:08:56 Actual: "2016-12-01T20:08:56Z" [20:14:29] (qunit failure) [20:18:54] (03PS45) 10Catrope: Add extension.json, empty PHP entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/211298 (https://phabricator.wikimedia.org/T87910) (owner: 10Paladox) [20:24:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2839588 (10Etonkovidova) Checked with ` 1.29.0-wmf.4` - enable... [20:25:11] legoktm: Does https://gerrit.wikimedia.org/r/324792 look sane? [20:25:38] legoktm: Yeah I think Matt was telling her she should use the facilities that MW provides for using a fake clock [20:25:50] Or is this in master? [20:26:01] If it's in master please file a bug and assign to mooeypoo [20:26:03] isset( $wgEchoConfig ) will always be false post-extension.json, but that should be fine right? [20:26:14] Yeah, I originally wrote it the other way around but then realized I can't [20:26:20] The extension.json patch depends on the rename patch [20:26:42] Which means that this should be fine, but also it has to be that way because of the merge strategy thing [20:26:49] RoanKattouw: master I think, it showed up when extension qunit tests ran against a core patch I was reviewing [20:26:53] RoanKattouw: so yes, lgtm then [20:26:55] If we convert first, then rename, the merge strategy breaks config in between [20:27:11] Cool, thanks [20:27:14] * RoanKattouw schedules for SWAT [20:29:21] Trizek: etonkovidova and I have decided to go ahead with re-enabling the Flow beta feature. Today at 4pm Pacific / 1am your time as discussed (midnight UTC) [20:29:37] * RoanKattouw goes away for lunch [20:39:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2839644 (10jmatazzoni) So we have consensus. Functionality on Watchlist and... [20:50:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream, 06Editing-Analysis: Research what anti-vandalism tools are most used/most productive? - https://phabricator.wikimedia.org/T152037#2839686 (10jmatazzoni) [20:59:26] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4), 07Wikimedia-log-errors: Flow fatal: Default format of 'topic-title-html' or 'topic-title-wikitext' can only be used to format to... - https://phabricator.wikimedia.org/T149827#2839730 [20:59:43] ^ etonkovidova [20:59:49] Replied re edit title. [21:00:00] matt_flaschen: thanks [21:00:35] matt_flaschen: just as I thought :) [21:17:29] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, and 2 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#2839814 (10Catrope) [21:17:52] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, and 2 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#2769308 (10Catrope) >>! In T149936#2775616, @jcrespo wrote: > Looks good, waiting on code deployment for production deploy The code is deployed now. > - t... [21:20:17] 06Collaboration-Team-Triage, 10Notifications, 07Blocked-on-schema-change, 13Patch-For-Review, and 2 others: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#2839834 (10Catrope) The code is now deployed, and this is ready to go. [21:21:32] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Blocked-on-schema-change, and 3 others: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2839836 (10Catrope) The code is now deployed, and this is ready to go. [21:27:24] stephanebisson: https://phabricator.wikimedia.org/T151389 I see it again in production enwiki :( [21:29:01] I saw it happen over her shoulder [21:29:33] She had 3 cross-wiki messages from 3 distinct wikis, marked the cross-wiki bundle as read, and her messages flyout ended up being empty but her message count was still 2 [21:29:39] This persisted after reloads as well [21:29:49] Now I'm wondering if there's a race condition in recomputing the counts [21:29:59] Which ... I guess it's obvious isn't it [21:30:12] Send parallel markasread requests to wikis A, B and C [21:30:44] They mark notifs as read in that order, but A takes a little bit longer between counting and writing to cache than B and C do [21:31:16] So when counting A sees 2 unread notifs (B's and C's haven't been marked as read yet) but when writing it overwrites what B and C already write [21:31:17] *wrote [21:31:29] stephanebisson: Does that sound like a plausible theory? [21:34:21] RoanKattouw: the count is re-queried after all markasread are done [21:35:16] they should all update their count in echo_unread_wiki and invalidate the cache [21:35:47] while I don't picture it atm, I'm sure a race condition is possible [21:37:54] but if it doesn't fix itself on reload, then it's cache corruption [21:38:21] we could implement some form of ?purge to troubleshoot this [21:38:53] Yeah my first instinct was to have markasread do an invalidation rather than a recomputation [21:39:12] Yeah it doesn't fix itself on reload, it looks like cache poisoning [21:39:34] Elena is now going to try this with a larger number of wikis (say 10-15) to validate my theory [21:39:37] it has to recompute its own echo_unread_count entries because other wikis can't do that [21:39:51] Yeah and I think those are probably correct [21:40:53] She's already done more things so I can't look at that any more, but I've asked her to tell me the next time she hits this bug so I can inspect the state [21:41:05] I would expect the euw table to be correct but the cached count to be wrong [21:41:18] Oh, good point, I see what you're saying [21:41:30] We can't just do an invalidation, we have to recompute at least the local count because we need to do the euw update [21:44:52] I'm looking at MWEchoNotifUser::resetNotificationCount, it should update its entries in euw and invalidate the cache (with tombstoning). Further get requests will re-cache bor the user based on everything in euw. [21:45:11] s/bor/for [21:46:52] From the look of it, this problem should happen pretty often when you mark the foreign bundle as read. [21:49:05] (03PS1) 10MtDu: Update Maintenance scripts to use $this->requireExtension() * Also added $this->mDescription to removeInvalidNotification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) [21:49:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2839973 (10Mattflaschen-WMF) [21:53:50] (03PS2) 10Legoktm: Update Maintenance scripts to use $this->requireExtension() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [21:53:55] (03PS2) 10Mattflaschen: Add script to fix inconsistent state for board name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) [21:54:29] (03CR) 10Legoktm: [C: 032] "This won't merge until the extension.json conversion is merged, but it looks good." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [21:54:35] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2839984 (10jmatazzoni) > I'm ok in being consistent on what each wiki uses. Agreed. Translators will presumably do t... [22:16:50] (03CR) 10Mattflaschen: "> [4a9fc0bd608ce6d71b50a388] [no req] Flow\Exception\FlowException from line 77 of /vagrant/mediawiki/extensions/Flow/includes/BoardMover." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [22:17:21] ^ stephanebisson, replied and updated my FlowFixInconsistentBoards.php patch re the page ID issue [22:17:49] matt_flaschen: thanks, I'll try it again [22:50:47] (03PS3) 10Catrope: Update Maintenance scripts to use $this->requireExtension() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [22:51:31] (03CR) 10Catrope: "PS3: Remove Depends-On, and rebase instead" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [22:51:57] (03CR) 10Catrope: [C: 032] "Per Legoktm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324807 (https://phabricator.wikimedia.org/T152139) (owner: 10MtDu) [22:52:40] oh, I was stupid. You don't need Depends-On for dependencies in the same repo -.- [22:55:12] legoktm: Oh was it you that did that? [23:25:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2840249 (10jmatazzoni) The user tests--particularly the last one--left me with a desire to take one more crack at the... [23:30:19] RoanKattouw or legoktm, could use a review of https://gerrit.wikimedia.org/r/#/c/307426/19 if you have a chance. Stephane +1'ed a while ago, and I just manually rebased it and answered his question. Or I can ping him again sometime. [23:30:24] "Add server-side MessagePoster" [23:45:45] Also "Import templates from English Wikipedia" (https://gerrit.wikimedia.org/r/#/c/311178/). It doesn't do anything user-facing, but it's a pre-requisite for https://gerrit.wikimedia.org/r/#/c/311856/8 . [23:51:33] (03CR) 10Mattflaschen: "I know Mooeypoo tested this pretty thoroughly (see November 18, 2016 on IRC). She was also going to review the code, but not sure if she " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [23:57:41] (03CR) 10Mattflaschen: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [23:57:50] (03CR) 10jenkins-bot: [V: 04-1] Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen)