[00:05:18] RoanKattouw: Yeah, it possibly shouldn't be on for testwiki. [00:05:36] Anyway, no-one should use that wiki so… ;-) [00:11:54] OMG [00:12:11] stylelint:src is complaining about its own code [00:12:25] Running "stylelint:src" (stylelint) task [00:12:25] Warning: /home/moriel/code/vagrant/mediawiki/node_modules/grunt-stylelint/node_modules/stylelint/node_modules/table/dist/table.js:112 [00:12:25] let userConfig = arguments.length > 1 && arguments[1] !== undefined ? argume [00:12:25] ^^^ [00:12:25] Unexpected strict mode reserved word Use --force to continue. [00:12:29] O.O [00:12:46] also, ew for the recursing node_modules folder [00:13:21] but anyways... anyone knows how to ignore these ? I think if I --force it still quits on that test but runs whatever other tests are in, so I might be missing actual stylelint things [00:13:23] mooeypoo: Bump your npm and grunt versions. [00:13:43] ah [00:13:46] hm, how? [00:13:53] npm install not enough? [00:14:11] For grunt, `npm install -g grunt`. [00:14:23] For npm, `apt-get upgrade npm` or whatever. [00:15:26] ... where is the horrified-emoji? "npm install -g npm" according to stackoverflow [00:16:50] Err. OK. Not on my machine, but… [00:17:36] James_F, what's your node version? [00:17:47] 7.1. [00:17:56] npm 3.10.9 [00:18:04] wait... hm [00:18:14] so I'm on npm@4.0.2 now [00:18:23] updating grunt. That should be okay, then. I think. [00:18:25] Maybe that's it? But I'd be surprised. [00:18:47] let's see... running 'grunt' again [00:18:54] let's see if stylelint is complaining about itself again [00:19:10] mooeypoo: Anomie had this issue as well last week. [00:19:15] I can't remember how he fixed it. [00:19:21] That's useful. [00:19:26] <3 [00:19:43] still complainning. Meh. [00:20:04] ok, Im going to push at least the current fixes so hopefully jenkins is either happy or more helpful [00:20:08] mooeypoo: Oh, right. We changed MW's config. Rebase. [00:20:16] .... nooooooo [00:20:23] That word is forbidden in this patch [00:20:40] ... actually, it might just work automatically. Let me see [00:21:37] wait, crap, it's dependent on another fix [00:22:11] This is so confusing. Where is the dependent commit written? I think it's merged [00:22:15] GERRIT [00:22:24] New UI is super annoying [00:22:56] Also, why am I both mooeypoo and Moriel Schottlender? is my identity in flux or something? [00:23:03] sup gerrit... [00:23:16] mooeypoo: It's gerrit lovely? [00:23:33] mrr [00:23:42] mooeypoo: (Add a line to the .mailmap file in MW core if you want to fix your name.) [00:24:50] James_F, I am already there with both my emails [00:24:58] And I appear -- under the same email -- as either Moriel or mooeypoo [00:25:08] look at "author" vs "committer" https://gerrit.wikimedia.org/r/#/c/320332/ [00:25:13] Same email.... [00:25:15] O.o [00:25:20] That's your user config inside gerrit. [00:25:21] Not that I mind that much, but wtf [00:25:32] what? it wasn't like that before... [00:25:36] or maybe it just didn't expose it [00:26:09] It changed when we upgraded to gerrit 2.13 from 2.7 or something. [00:26:15] ah [00:26:36] okay, I'll look into that later. First... where is the underlying patch. I see matt_flaschen's patch on top of mine, but where's the other one [00:27:13] It doesn't think there is one. [00:27:22] but gerrit locally does [00:27:26] Did you rebase automatically onto master or via the CLI? [00:27:33] no..................? [00:27:49] Which was the underlying patch? [00:27:56] let me see [00:27:59] If it's already merged into master it'll just silently ignore it. [00:28:48] James_F, https://gerrit.wikimedia.org/r/#/c/321372/ [00:28:51] so yes, it's merged [00:29:04] Ah, yeah. Because it's merged, it's just silently skipping it. [00:29:09] ok, so "rebase" in the gerrit UI should get it to automatically rebase onto master HEAD [00:29:10] right? [00:29:25] so I don't need to do that in the CLI manually, is my point [00:29:34] I think. [00:29:48] 320332 is shown as depending on 323909 (merged) which in turn has 321372 in its antecedents. [00:29:57] James_F, where do yo usee that [00:30:01] Yeah, locally you can do `git remote update`. [00:30:11] See what? That "323909 (merged) which in turn has 321372 in its antecedents"? [00:30:35] I'm confused. [00:30:45] In `git log` (or in https://phabricator.wikimedia.org/diffusion/MW/history/master/) [00:31:03] In the previous gerrit, it was super easy to see that commit XXX is actually in a chain, and commit BBB is the underlying one, and commit ZZZZ is the one above [00:31:08] ... where the hell do I see it in this UI ? [00:31:15] Yes, gerrit really broke this bit of the interface. [00:31:17] oh oh okay, in git log. I guess that is easier [00:31:32] You don't. Use git log and don't try to use the UI. [00:31:33] Easier to *see* not easier to do... it's really crappy [00:31:37] meh [00:31:42] Yup. [00:38:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2829498 (10jmatazzoni) @Halfak, we're programming this filter now. If you can please provide the info re... [00:40:06] jmatazzoni_, https://phabricator.wikimedia.org/T149761#2829498 is a substantial amount of work. [00:40:19] Can you file a task for me that states exactly what you want and what it will be used for? [00:40:27] I'd like to prioritize this against my current work. [00:41:43] I was hoping you had a program that spat those out. We can probably find a way to shortcut it.... [00:41:55] I'm going to need to write code to get it. [00:42:25] Or rather dig into some tables buried within the evaluations I currently do and then do some math to make sure that it's measuring what's expected. [00:43:29] I've got to run ASAP, but I'll work from whatever you can put together for me :) [00:43:33] Have a good night! [00:43:35] o/ [00:43:44] I'll try to state the goal as succinctly as I can in the task and see if that helps you narrow down the search. [01:02:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10VisualEditor, 07Regression, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): [betalabs-regression] Flow board - switching to VE produces "TypeError: this.parseHtml is not a function" - https://phabricator.wikimedia.org/T151233#2829549 (10Jdforres... [01:03:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2829550 (10jmatazzoni) @Halfak reports that these numbers are laborious to calculate, so I'll try to be... [01:14:55] 06Collaboration-Team-Triage, 10Flow: Rename or delete 'suppress' user group on Wikimedia wikis - https://phabricator.wikimedia.org/T151688#2824662 (10Quiddity) This appears to be regarding: (for example) https://www.mediawiki.org/wiki/Special:ListGroupRights (please always add examples/links!) which currentl... [02:15:20] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: [mobile-regression] Special:Notifications in Desktop mode does not display Notifications properly - https://phabricator.wikimedia.org/T151827#2829615 (10Catrope) 05Open>03Invalid This turned out to be due to the experimental "responsive Vector" feat... [02:27:27] (03PS1) 10Catrope: Stop assigning rights to the nonexistent 'suppress' group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/324012 (https://phabricator.wikimedia.org/T151688) [02:31:58] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Rename or delete 'suppress' user group on Wikimedia wikis - https://phabricator.wikimedia.org/T151688#2824662 (10Krinkle) +1 The `suppress` doesn't exist by default indeed, but core does pretend that it is (or once was, or intended to be) a "common" g... [02:34:30] (03CR) 10Krinkle: [C: 032] Stop assigning rights to the nonexistent 'suppress' group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/324012 (https://phabricator.wikimedia.org/T151688) (owner: 10Catrope) [02:43:12] (03Merged) 10jenkins-bot: Stop assigning rights to the nonexistent 'suppress' group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/324012 (https://phabricator.wikimedia.org/T151688) (owner: 10Catrope) [02:58:03] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Rename or delete 'suppress' user group on Wikimedia wikis - https://phabricator.wikimedia.org/T151688#2824662 (10Catrope) It turns out this group existed //only because// Flow assigned rights to it. Thanks @Krinkle for merging this so quickly. [09:50:38] 06Collaboration-Team-Triage, 10Notifications, 10ArticlePlaceholder, 10Wikidata, 07TestMe: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2242704 (10Lydia_Pintscher) Is this fixed now? [10:42:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): ReviewStream: improving edit-review tools through a better data feed - https://phabricator.wikimedia.org/T149060#2830196 (10Qgil) "A unified vision for editorial collaboration" was cancelled as main top... [11:09:49] 06Collaboration-Team-Triage, 06Editing-Department, 10Editing-UX-Research, 10MediaWiki-General-or-Unknown, and 4 others: Next Steps for Real Time Collaboration - https://phabricator.wikimedia.org/T149663#2830279 (10Qgil) This proposal seems to have enough interests, but there is no discussion so far. I am m... [11:10:26] 06Collaboration-Team-Triage, 10Flow, 10Editing-UX-Research, 10MediaWiki-Patrolling, and 3 others: UX to create safe spaces - https://phabricator.wikimedia.org/T149665#2830283 (10Qgil) This proposal seems to have enough interests, but there is no discussion so far. I am moving it to "on track" for now, but... [11:12:56] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-History-or-Diffs, 10Wikimedia-Developer-Summit (2017): Next steps for edit review - https://phabricator.wikimedia.org/T149664#2830291 (10Qgil) This proposal seems to have enough interests, but there is no discu... [12:40:14] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-History-or-Diffs, 10Wikimedia-Developer-Summit (2017): Next steps for edit review - https://phabricator.wikimedia.org/T149664#2830456 (10Qgil) ... on the other hand, since this session is not part of any main t... [12:43:13] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2830457 (10Qgil) Since this proposal doesn't fit in any main topic and there are other proposals that have received more support, maybe it w... [12:45:31] 06Collaboration-Team-Triage, 10Flow, 10Editing-UX-Research, 10MediaWiki-Patrolling, and 3 others: UX to create safe spaces - https://phabricator.wikimedia.org/T149665#2830461 (10Qgil) Since this proposal doesn't fit in any main topic and there isn't much active discussion here, maybe we should move it unde... [12:57:42] (03PS1) 10Ladsgroup: Align echo alert colors with Wikimedia color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324161 [13:22:53] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Figure out what to do with the 'Mobile contribs' filter - https://phabricator.wikimedia.org/T151801#2830556 (10Trizek-WMF) @jmatazzoni, the case you have found is a local shortcut, using a tag. Tags are defined on ea... [13:41:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#2830589 (10Pginer-WMF) [13:46:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement functionality for RC page 'User registration' filters - https://phabricator.wikimedia.org/T149640#2830630 (10Pginer-WMF) Related to this, I created a ticket about communicating contradicting f... [14:15:36] 06Collaboration-Team-Triage, 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#2830727 (10Reedy) [14:25:35] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#2830589 (10SBisson) A few things I'd like to clarify. The title of this ticket sounds like some URLs worked in wit... [14:33:46] 06Collaboration-Team-Triage, 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#2830832 (10Reedy) Looks intermittant... [16:24:25] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#2831292 (10Pginer-WMF) >>! In T151873#2830824, @SBisson wrote: > A few things I'd like to clarify. Thanks for the... [17:51:43] (03CR) 10Catrope: [C: 031] "Looks good, waiting for Volker to approve" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324161 (owner: 10Ladsgroup) [18:38:07] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Rename or delete 'suppress' user group on Wikimedia wikis - https://phabricator.wikimedia.org/T151688#2824662 (10Mattflaschen-WMF) >>! In T151688#2829641, @Catrope wrote: > It turns out this group existed //onl... [18:39:41] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Flow\ReferenceClarifier::getObjectLink: Unknown $objectType: post-summary - https://phabricator.wikimedia.org/T151391#2831978 (10Catrope) [18:40:46] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Rename or delete 'suppress' user group on Wikimedia wikis - https://phabricator.wikimedia.org/T151688#2831982 (10Catrope) 05Open>03Resolved a:03Catrope [18:42:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10UI-Standardization, 13Patch-For-Review, 03UI-Standardization-Kanban: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2831985 (10Catrope) [18:43:20] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2831991 (10Trizek-WMF) I've explained that here T151801#2830556 too. >>! In T151799#2828998, @Catrope wrote:... [19:15:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Regression: [regression 1.29.0-wmf.3] Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2832157 (10Etonkovidova) Re-checked all reported... [19:15:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Regression: [regression 1.29.0-wmf.3] Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2832160 (10Etonkovidova) 05Open>03Resolved [19:35:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2832254 (10Catrope) >>! In T151799#2831991, @Trizek-WMF wrote: > I've explained that here T151801#2830556 too.... [19:37:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2832258 (10Trizek-WMF) >>! In T151799#2832254, @Catrope wrote: > Yeah, we can add things there instead of / as... [20:06:55] (03CR) 10Aaron Schulz: [C: 032] Use ParserOutput instead of DB to check for categories [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) (owner: 10Catrope) [20:10:22] (03Merged) 10jenkins-bot: Use ParserOutput instead of DB to check for categories [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) (owner: 10Catrope) [21:38:33] I have to go into the coworking space to take care of something. I'll be back on soon.