[10:26:11] 06Collaboration-Team-Triage, 10Wikimedia-Developer-Summit (2017): Tools for curating and organizing editing work: what has been done and where to go next - https://phabricator.wikimedia.org/T148088#2826550 (10Qgil) Today is the [[ https://www.mediawiki.org/wiki/Wikimedia_Developer_Summit/2017/Call_for_particip... [10:33:38] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 06Community-Tech, 13Patch-For-Review, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Noindex template feature should be restricted to new articles - https://phabricator.wikimedia.org/T149538#2826596 (10Niharika) [13:13:08] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Filter Search Bar - https://phabricator.wikimedia.org/T149435#2827031 (10Pginer-WMF) >>! In T149435#2823960, @Volker_E wrote: > @Pginer-WMF This is a good point. > F... [13:48:03] (03CR) 10Sbisson: [C: 032] Fix missing doublecheck icon on Special:Notifications on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323350 (https://phabricator.wikimedia.org/T146706) (owner: 10Catrope) [13:48:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review: double-check icon for "Mark group as read" button does not appear on mobile site - https://phabricator.wikimedia.org/T146706#2827089 (10SBisson) a:03Catrope [14:13:06] (03CR) 10Ladsgroup: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323554 (owner: 10Ladsgroup) [14:19:19] (03Merged) 10jenkins-bot: Fix missing doublecheck icon on Special:Notifications on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323350 (https://phabricator.wikimedia.org/T146706) (owner: 10Catrope) [14:29:53] (03CR) 10VolkerE: [C: 031] Align Email format with Wikimedia color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323554 (owner: 10Ladsgroup) [14:53:23] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 07Mobile, 13Patch-For-Review, and 2 others: [mobile] Special:Notifications the counter does not display the count - https://phabricator.wikimedia.org/T150999#2827249 (10Trizek-WMF) [15:54:04] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2827360 (10Halfak) Some relevant links: * https://www.mediawiki.org/wiki/Live_Chat_System * https://www.mediawiki.org/wiki/Live_Chat_System/... [15:56:47] (03CR) 10Catrope: [C: 032] Align Email format with Wikimedia color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323554 (owner: 10Ladsgroup) [15:57:13] (03CR) 10Catrope: "This icon I'm adding here is the main icon for Thanks notifications. thanks-{ltr,rtl}.svg is the secondary link icon. I could move the mai" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [16:11:23] (03Merged) 10jenkins-bot: Align Email format with Wikimedia color palette [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323554 (owner: 10Ladsgroup) [16:14:56] (03CR) 10Sbisson: "I think that would be better." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [16:15:00] (03CR) 10MtDu: "@Catrope," [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [16:22:49] 06Collaboration-Team-Triage, 10Notifications, 10Thanks: Move Thanks icons to Thanks repo - https://phabricator.wikimedia.org/T151768#2827399 (10Catrope) [16:25:16] (03CR) 10Catrope: "@MtDu Sure, go for it. https://phabricator.wikimedia.org/T151768" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [16:47:13] (03PS3) 10Catrope: Update for API error i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/321426 (owner: 10Anomie) [16:49:54] (03CR) 10Catrope: [C: 032] Update for API error i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/321426 (owner: 10Anomie) [16:57:04] (03CR) 10Catrope: [C: 032] Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323677 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [17:26:19] (03CR) 10Catrope: [C: 032] Update for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 (owner: 10Anomie) [17:26:41] (03CR) 10Catrope: [C: 032] Prepare for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321593 (owner: 10Anomie) [17:36:15] (03Merged) 10jenkins-bot: Prepare for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321593 (owner: 10Anomie) [17:48:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'User Intent' filters (ORES) - https://phabricator.wikimedia.org/T149853#2827777 (10SBisson) a:03SBisson [17:50:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Implement functionality for RC page 'Contribution Quality' filters (ORES) - https://phabricator.wikimedia.org/T149734#2827781 (10SBisson) a:03SBisson [17:58:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement enhanced Recent Changes filters (and make them work with the new UI) - https://phabricator.wikimedia.org/T144451#2827801 (10SBisson) [17:58:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 07Tracking: Implement functionality for RC page 'User registration' filters - https://phabricator.wikimedia.org/T149640#2827799 (10SBisson) 05Open>03Invalid For most filters, we've decided to continue using the... [18:13:37] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Opening help dialog in Flow VE (CTRL+?) throws an exception - https://phabricator.wikimedia.org/T151096#2827864 (10Etonkovidova) Checked the fix in betalabs. [18:32:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream: Instrument ReviewStream feed to monitor usage - https://phabricator.wikimedia.org/T143721#2827939 (10SBisson) @Ottomata Is there plans for kasocki to log usage so we know if our new feed is being used and with w... [18:38:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream: Instrument ReviewStream feed to monitor usage - https://phabricator.wikimedia.org/T143721#2827974 (10Ottomata) Hm, good question. EventStreams (which uses KafkaSSE, not Kasocki; Kasocki will not be used) is bui... [18:44:16] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream: Instrument ReviewStream feed to monitor usage - https://phabricator.wikimedia.org/T143721#2828018 (10SBisson) That will become relevant when our feed is live (during the next quarter?). Let's discuss the options... [19:18:54] (03Draft2) 10Aftab: Flow.namespaces.php translation for বাংলা (bn) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323876 [19:30:21] (03Draft2) 10Aftab: Flow.alias.php translations for bengali [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323882 [19:54:31] (03Abandoned) 10Aaron Schulz: WIP: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [20:06:27] (03CR) 10Catrope: [C: 032] Flow.alias.php translations for bengali [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323882 (owner: 10Aftab) [20:06:34] (03CR) 10Catrope: [C: 032] Flow.namespaces.php translation for বাংলা (bn) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323876 (owner: 10Aftab) [20:10:12] RoanKattouw, stephanebisson matt_flaschen any of you know (I can't find this) if there's an equivalent for "continue;" or "break;" for inside $.each() ? [20:10:32] I'm just flipping the condition for now, instead of if( xxx ) { break; } I do if (!xxx) {... code here...} [20:10:35] Does return false work? [20:10:39] I don't know [20:10:46] which works, of course, but I am curious to see if there's something [20:10:57] hm return false might 'continue', but not break [20:11:00] * mooeypoo tests [20:11:57] return; would "continue", for sure [20:12:05] yeah [20:12:10] I wonder if there's a way to "break" [20:12:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2828476 (10jmatazzoni) [20:14:31] mooeypoo, yeah, it's return false. [20:14:37] "We can break the $.each() loop at a particular iteration by making the callback function return false. Returning non-false is the same as a continue statement in a for loop; it will skip immediately to the next iteration." [20:14:45] mooeypoo: if you need to break, maybe what you need is a higher level operation (find, filter, ...) [20:22:43] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2828476 (10Catrope) Where do you see this "IP contribs" link? I don't see it. Does it perhaps come from a Gadg... [20:23:02] Breaking for lunch [20:24:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Figure out what to do with the 'Mobile contribs' filter - https://phabricator.wikimedia.org/T151801#2828521 (10jmatazzoni) [20:27:16] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2828573 (10SBisson) {F4878032} [20:27:37] (03Merged) 10jenkins-bot: Flow.alias.php translations for bengali [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323882 (owner: 10Aftab) [20:27:40] (03Merged) 10jenkins-bot: Flow.namespaces.php translation for বাংলা (bn) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323876 (owner: 10Aftab) [20:32:36] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2828604 (10jmatazzoni) >>! In T151799#2828513, @Catrope wrote: >Does it perhaps come from a Gadget or somethin... [20:42:49] RoanKattouw, re your TitledElement comments -- it's TitledElement, but LabelElement (not labeled, god knows why) and titled element only adds a title **attribute** not the label. [20:42:54] so.. foo. [20:43:05] I'm changing wherever I can to simplify but it's a little annoying [20:43:29] Oh, sorry [20:43:36] I did not realize that [20:43:53] It used to be that they all had names with "ed" [20:44:03] LabeledElement, IconedElement, etc [20:44:21] I think it got awkward at one point and that that was why they were renamed [20:46:01] * mooeypoo nods [20:46:04] Aye [20:46:13] I think we got rid of that a while ago, but some remained [20:46:35] yeah "IconedElement" started to be a bit off [20:47:10] RoanKattouw, and GroupedElement sounds different than GroupElement [20:47:22] Though we could make the case of hasa vs isa anyways [20:47:26] I don't think it was GroupedElement [20:47:38] Because that one isn't grouped, it manages a group [20:50:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): double-check icon for "Mark group as read" button does not appear on mobile site - https://phabricator.wikimedia.org/T146706#2669030 (10Etonkovidova) Checked the fix in be... [20:50:52] RoanKattouw, I think that's the point, though... which elements are 'ed' and which aren't became a real confusion [20:51:39] I think this was one of those changes that came about because Kirsten made Trevor explain everything [20:53:01] hehe [20:53:06] Yes [20:53:08] That would do it [20:53:31] Within the first couple weeks of her being hired, she wasn't producing a lot of documentation yet but Trevor was cranking out breaking changes like there was no tomorrow [20:54:23] I remember [20:54:41] And James_F also made some points about mixins that end with "ed" [20:54:55] ... I am surprise Ed didn't make points about widgets ending with "ed" [21:04:40] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 07Mobile, 13Patch-For-Review, and 2 others: [mobile] Special:Notifications the counter does not display the count - https://phabricator.wikimedia.org/T150999#2828844 (10Etonkovidova) Checked in betalabs - the bell icon... [21:06:42] * James_F grins. [21:09:35] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2828855 (10Capt_Swing) @Halfak what about a chatbot? @MelodyKramer helped build one for new employee onboarding at at previous employer: htt... [21:12:33] I'm going to be delayed. I have to run to the store. [21:20:04] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2828911 (10Halfak) https://www.mattermost.org/ has been around for a while. In the work I did around Live Chat, I looked into XMPP (protoco... [21:40:01] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Explain how the 'IP contribs' filter works (so we can fix it) - https://phabricator.wikimedia.org/T151799#2828998 (10Catrope) Oh, I see it. That looks like an enwiki-specific customization. You're right that it dupli... [22:04:50] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: [mobile-regression] Special:Notifications in Desktop mode does not display Notifications properly - https://phabricator.wikimedia.org/T151827#2829135 (10Etonkovidova) [22:07:43] RoanKattouw: sorry, but can you take a quick look at https://phabricator.wikimedia.org/T151827 ? Mobile Special:Notifications page when switched to Desktop mode is quite different in betalabs vs production [22:07:52] I just finished reading [22:07:52] it [22:07:54] What the hell [22:08:11] RoanKattouw: hopefully it's not important ... [22:08:22] jdlrobson: Did you guys do something in MobileFrontend that would cause the mobile-to-desktop switch link at the bottom to attempt to switch without reloading the page? [22:10:43] Ooooh no this is different [22:10:55] It's some sort of responsive thing when the screen is narrow on desktop [22:11:49] Yup [22:12:06] jdlrobson: Sorry, forget that question. New question: do you know anything about a new stylesheet for width<960px on desktop? [22:12:44] etonkovidova: I can also reproduce by just going to Special:Notifications in desktop mode in a normal browser (no emulator), and reducing the width of the window to <960px [22:13:15] RoanKattouw: well, it is interesting :) [22:13:46] And of course the width threshold for the special page itself to switch to narrow mode is 980px [22:13:50] RoanKattouw: and another question - does it tell you something? TypeError: moment.locale is not a function TypeError: moment.locale is not a function(…) [22:13:52] Standardization :/ [22:14:01] Yeah that sounds concerning [22:14:07] How do you get that? [22:14:31] RoanKattouw: when I logged as a user with recently changed password to https://test.wikipedia.org/wiki/Special:Notifications [22:14:50] RoanKattouw: and Special:Notifications page never loads [22:14:58] Interesting [22:15:02] I can't reproduce that [22:15:04] Can you still? [22:15:21] RoanKattouw: sadly it happens only to one user [22:15:51] Hmm maybe something about your notifs or your prefs is weird [22:16:02] Is this your real user or a test user? [22:16:27] RoanKattouw: maybe. Oh I got another one for the same user: Uncaught TypeError: echoMoment.locale is not a function(…) [22:17:07] RoanKattouw: only for one user on testwiki - and all is fine for the same user on other wikis [22:17:42] And is that user a test user like ET63 or something? [22:17:46] or is it a real account [22:18:04] RoanKattouw: well, it's Etonkovidova account [22:18:27] RoanKattouw: I was just thinking that it might relate somehow to recently changed password ... [22:19:15] Hmm [22:19:22] I should hope not [22:19:33] Are there any other errors in the console, or just those? [22:19:59] RoanKattouw: only those [22:20:04] Hmm strange [22:20:13] RoanKattouw: ok - since it's very narrow case and it does not happen to the same users on testwiki other pages - just let put it aside [22:20:18] Yeah [22:20:23] When I'm back let's look at it [22:20:24] RoanKattouw: I'll keep an eye on it [22:20:54] In order to investigate I need to roll my chair over to your desk and play around with it on your laptop [22:21:08] But I'm a bit too far away for that today [22:22:05] RoanKattouw: :)) I'll try to see what may cause it [22:26:46] hi RoanKattouw, @media (max-width: 981px) .mw-echo-ui-notificationsInboxWidget-toolbarWrapper [22:26:59] Yeah that's ours [22:27:06] The thing that's new and breaks kicks in at 960 [22:28:56] RoanKattouw, matt_flaschen https://gerrit.wikimedia.org/r/320332 <-- answered comments + fixed up problems, but not all [22:29:00] some require further discussion [22:29:27] I'm not sure i understand your question then RoanKattouw .. i dont know of any desktop media queries being run [22:31:15] jdlrobson: Open a Chrome window, resize it to be 900px wide (give or take a few), and then open https://en.wikipedia.org/wiki/Main_Page in one tab and https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page in another [22:31:23] You'll see some pretty significant differences [22:32:36] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#2685514 (10kaldari) >This appears to either not be fully understood, or shelved because it's not understood. @Kudpung: I'm not sure... [22:33:09] Aha I found it [22:33:11] RoanKattouw: that's because of responsive vector no? [22:33:20] Yeah, a change to responsive Vector landed recently [22:33:38] oh dear. [22:33:44] that's going to cause lots of testing headaches [22:33:59] Yeeaah [22:34:07] why was it enabled on beta cluster? [22:34:07] Look at #p-personal for example [22:34:21] it's nowhere near production ready [22:34:24] Oh, I see [22:34:32] Didn't realize responsive Vector was feature flagged [22:34:39] So I guess this won't hit prod this week then [22:34:41] RoanKattouw: no worries about Uncaught TypeError: echoMoment.locale is not a function(…) -- enabled Twinkle is doing it [22:34:53] ha! [22:34:58] it's controlled by wgVectorResponsive - but beta cluster should reflect production [22:35:54] Looks like it was enabled July last year. Not sure how useful it is having it on the beta cluster for this reason. [22:41:19] Oh it's enabled on testwiki too [22:41:20] I see [22:41:26] Thanks for helping me track this down jdlrobson [22:41:29] jdlrobson, agree. Feature-flagging something true on Beta for a little while can be useful (until we have two Beta Clusters, one "just like production will soon be" and another "for experiments"). But four months is too long. [22:41:54] Don't we have a testwiki on beta? [23:08:08] matt_flaschen: it's 16 months :) [23:08:41] so definitely too long imo given it's not actively being developed. [23:13:18] jdlrobson: Shall we kill it? [23:16:45] Patch up: https://gerrit.wikimedia.org/r/#/c/323986/ /cc RoanKattouw matt_flaschen. [23:49:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): ReviewStream: improving edit-review tools through a better data feed - https://phabricator.wikimedia.org/T149060#2829402 (10Halfak) Any cool outcomes of the Nov. 9th meeting? I'm still not sure where t... [23:52:48] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Convert PageTriage to use extension registration - https://phabricator.wikimedia.org/T87954#2829408 (10Jdforrester-WMF) 05Resolved>03Open Reverted in https://gerrit.wikimedia.org/r/#/c/316718/ [23:57:49] I think that means it'd still be enabled on http://test.wikimedia.beta.wmflabs.org/ [23:58:03] Unfortunately that domain also seems to have HSTS enabled with a bad cert