[00:02:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 06Community-Liaisons: Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2816698 (10jmatazzoni) Great. Thanks. [00:39:20] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 07Regression: [regression 1.29.0-wmf.3] The Notificaitons counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2816774 (10Etonkovidova) Checked in beta - the issue is reprodu... [00:53:58] * halfak is starting to wonder if all he collab people are busy today [01:29:55] Got jmatazzoni_ on hangouts and got my question answered. So I made my post: https://meta.wikimedia.org/wiki/Wikimedia_Forum#Enabling_flow_on_one_page_.28Research:ORES_paper.29 [02:22:36] yay :D [08:30:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2817132 (10Pginer-WMF) It makes sense to focus on the filtering part.... [12:59:23] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2817613 (10Pginer-WMF) I created a prototype to illustrate different... [13:40:48] (03PS1) 10Sbisson: Remove mention of EchoBasicFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323152 (https://phabricator.wikimedia.org/T151413) [14:01:16] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Documentation, 07Documentation, 13Patch-For-Review: Echo docs still mentions EchoBasicFormatter but class is gone - https://phabricator.wikimedia.org/T151413#2816464 (10SBisson) I updated the doc: https://www.mediawiki.org/w/index.php?title=Extens... [14:10:59] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 07Regression: [regression 1.29.0-wmf.3] Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2817782 (10Aklapper) [14:11:43] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 07Regression: [regression 1.29.0-wmf.3] Notifications counter is incorrect after 'Mark all as read' was clicked for cross-wiki notifications - https://phabricator.wikimedia.org/T151389#2815813 (10Aklapper) Adding actual code project... [17:25:57] (03CR) 10Catrope: [C: 032] Remove mention of EchoBasicFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323152 (https://phabricator.wikimedia.org/T151413) (owner: 10Sbisson) [17:26:12] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Documentation, 07Documentation, 13Patch-For-Review: Echo docs still mentions EchoBasicFormatter but class is gone - https://phabricator.wikimedia.org/T151413#2818298 (10Catrope) 05Open>03Resolved a:03Catrope [17:41:22] (03Merged) 10jenkins-bot: Remove mention of EchoBasicFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323152 (https://phabricator.wikimedia.org/T151413) (owner: 10Sbisson) [17:47:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2818360 (10Trizek-WMF) Beta features popup have my voice (and Inline... [18:23:40] (03CR) 10Sbisson: [C: 032] Add a primary key to the echo_notification table [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) (owner: 10Catrope) [18:25:06] mooeypoo, just a preview of what I was thinking about: Maybe every filter in a group false should really be "all disabled" (the illegal state you're working on), and the default (nothing hidden) should be everything true. But if everything is true, the rendering would be all empty checkboxes, unless the checkboxes had been touched by the user (highlighting included). [18:25:17] mooeypoo, I'm just thinking out loud for now, not sure this is right. [18:26:52] (03CR) 10Sbisson: [C: 032] Add primary keys to the remaining Flow tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [18:28:34] (03CR) 10Sbisson: [C: 032] Delete unused flow_subscription table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) (owner: 10Catrope) [18:30:05] (03CR) 10Sbisson: [C: 04-1] "Any reason you want to put this icon in Echo rather than in Thanks?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [18:35:55] (03Merged) 10jenkins-bot: Add a primary key to the echo_notification table [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) (owner: 10Catrope) [18:37:58] (03CR) 10Catrope: "I started out trying to use the existing thanks-{ltr,rtl}.svg in Echo, but those are a bit different (smaller, and black, because they're " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [18:38:42] (03Merged) 10jenkins-bot: Add primary keys to the remaining Flow tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [18:38:45] (03CR) 10jenkins-bot: [V: 04-1] Delete unused flow_subscription table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) (owner: 10Catrope) [18:48:11] (03PS2) 10Catrope: Delete unused flow_subscription table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) [18:48:49] (03CR) 10Catrope: [C: 032] "Per Stephane" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) (owner: 10Catrope) [18:56:11] https://www.mediawiki.org/wiki/Topic:Tfw5yq61a4susnus is going to be fun to answer. [18:59:44] James_F, seriously wondering what they expect. They uninstalled Flow, and now Flow doesn't work... [18:59:58] (03Merged) 10jenkins-bot: Delete unused flow_subscription table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) (owner: 10Catrope) [19:00:34] Indeed. [19:09:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2818614 (10Capt_Swing) I think this proposal addresses a very important and timely subj... [19:13:34] 06Collaboration-Team-Triage, 10Wikimedia-Developer-Summit (2017): Tools for curating and organizing editing work: what has been done and where to go next - https://phabricator.wikimedia.org/T148088#2818620 (10Capt_Swing) I'm always interested in these kinds of discussions, and in the work of the WikiProject X... [19:14:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Documentation: Improce Filters for Special:Recent Changes page on mediawiki.org - https://phabricator.wikimedia.org/T151477#2818624 (10Trizek-WMF) [19:15:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Documentation: Improve Filters for Special:Recent Changes page on mediawiki.org - https://phabricator.wikimedia.org/T151477#2818638 (10Trizek-WMF) [19:15:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Documentation: Improve Filters for Special:Recent Changes page on mediawiki.org - https://phabricator.wikimedia.org/T151477#2818624 (10Trizek-WMF) [19:15:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2818639 (10Trizek-WMF) [19:15:35] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2818645 (10Trizek-WMF) [19:15:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) 05stalled... [19:15:47] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) Work has st... [19:16:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Documentation: Improve Filters for Special:Recent Changes page on mediawiki.org - https://phabricator.wikimedia.org/T151477#2818624 (10Trizek-WMF) [19:16:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2818648 (10Trizek-WMF) [19:50:13] Going to get lunch then go into the coworking space. [20:02:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Wikimedia-Developer-Summit (2017): Newcomer-friendly edit-review tools: help imagine what that looks like - https://phabricator.wikimedia.org/T150078#2818715 (10Halfak) +1 to @Capt_Swing's comment. Maybe we can use the session to lay ou... [21:33:25] (03CR) 10Catrope: [C: 032] Remove wgResourceLoaderLESSImportPaths [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322387 (https://phabricator.wikimedia.org/T140806) (owner: 10Mattflaschen) [21:44:20] (03Merged) 10jenkins-bot: Remove wgResourceLoaderLESSImportPaths [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322387 (https://phabricator.wikimedia.org/T140806) (owner: 10Mattflaschen) [22:02:40] mooeypoo, I amended your patch just to add a couple unit tests to illustrate some issues to resolve. [22:02:46] mooeypoo, let me know if you want to discuss. [22:04:02] matt_flaschen, I'm redoing my fix for the groups, so I'm hoping there's no collision [22:04:10] you just touched the unit test files or the model too? [22:05:17] matt_flaschen, You gave me an idea today about how to resolve a recurring issue I've been having with validating the groups, which is to store a constant state of the parameters (and update when they're invalid) so I've been changing the model and widgets, but not yet added to the tests.. if you only touched the tests, I'll push/merge first and then see if the issues still exist? [22:07:34] also, what the hell Javascript. Number( null ) === 0; but Number( undefined ) === NaN; [22:07:46] mooeypoo, yeah, only the tests. [22:08:28] * mooeypoo nods [22:08:30] awesome, thanks! [22:09:02] if undefined is not a number, so is null. The hell, JavaScript [22:09:41] I had another idea about a way to handle the "everything unchecked means everything shown" (in addition to the one above... ), but it's probably unnecessary. [22:09:44] Yay, ternary logic! [22:16:12] My tests (and I think one of the existing ones) will need to be updated for the new state model you come up with (distinguishing between "all hidden" and "all unchecked but all shown") [23:04:48] (03PS3) 10Catrope: build: Replace jshint/jscs with eslint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 (owner: 10Esanders) [23:05:20] (03CR) 10Catrope: [C: 032] build: Replace jshint/jscs with eslint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 (owner: 10Esanders) [23:14:26] (03Merged) 10jenkins-bot: build: Replace jshint/jscs with eslint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 (owner: 10Esanders) [23:14:32] (03PS1) 10Catrope: Stop passing config parameter to dm.List [extensions/Flow] - 10https://gerrit.wikimedia.org/r/323331 [23:19:28] RoanKattouw: Also https://gerrit.wikimedia.org/r/#/c/322339/1 [23:19:52] Already working on that one [23:20:02] Kk. [23:20:04] Not finished reviewing it yet but I have amendments [23:21:40] Tut. [23:22:52] James_F: BTW why all the valid-jsdoc disables? Is @fires not recognized? [23:23:00] RoanKattouw: @chainable. [23:23:07] RoanKattouw: We're working with upstream to fix that. [23:23:12] RoanKattouw: Soon. Soon. [23:23:15] Huh, but the Flow patch *adds* chainable in places [23:23:15] Hmm OK [23:23:47] Yeah, Ed's not just blindly doing things, he's also reading the code too. [23:25:32] Yeah I noticed [23:25:40] My amendments are minor [23:25:54] And mainly to do with "if you're removing this unused config param, also remove it from callers" [23:26:13] (03PS2) 10Catrope: build: Replace jscs/jshint with eslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/322339 (owner: 10Esanders) [23:28:28] Ha, so I see. [23:28:34] LGTM. [23:28:48] (Aka Ed has seen your code and judged you for it. ;-))