[00:40:39] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow: [minor] Blue border appears on side rail toggle after clicking - https://phabricator.wikimedia.org/T150385#2804583 (10jmatazzoni) [00:42:56] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Simultaneous edits to posts can cause an exception for the losing party - https://phabricator.wikimedia.org/T150430#2804604 (10jmatazzoni) [00:44:57] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page Curation edit summaries should be in the wiki's language - https://phabricator.wikimedia.org/T150552#2804608 (10jmatazzoni) @Mattflaschen-WMF, in the triage meeting we made a note that you were going to determine whether this had been fixed. [00:58:32] (03PS1) 10Mattflaschen: Add script to fix inconsistent state for board name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) [01:47:12] (03PS8) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) [01:47:22] (03CR) 10jenkins-bot: [V: 04-1] Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [01:53:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10MediaWiki-extensions-PageCuration, 13Patch-For-Review: Add Flow support to PageTriage using MessagePoster - https://phabricator.wikimedia.org/T85030#2804713 (10Mattflaschen-WMF) [01:53:44] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page Curation edit summaries should be in the wiki's language - https://phabricator.wikimedia.org/T150552#2804715 (10Mattflaschen-WMF) [01:54:27] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page Curation edit summaries should be in the wiki's language - https://phabricator.wikimedia.org/T150552#2789378 (10Mattflaschen-WMF) Yeah, this is definitely fixed. The patch needs review, though. I'll raise it in standup. [01:58:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2804752 (10Mattflaschen-WMF) @Matanya Did you assemble that URL yourself, or did the UI link you to it (doesn't seem so)? [01:59:50] ^ matanya, I'm looking at https://phabricator.wikimedia.org/T149251 now. See my question at https://phabricator.wikimedia.org/T149251#2804752 . If the UI linked you to it, we either need to have it stop doing that, or fix it to accept the URL. [02:00:09] If you assembled the URL yourself, it's probably a lower priority. [02:31:49] matt_flaschen, ... help :(((( [02:31:51] https://gerrit.wikimedia.org/r/#/c/322222/1 [02:31:53] ^^ what did i doooo [02:32:07] It's supposed to be part of this https://gerrit.wikimedia.org/r/#/c/320332/ [02:32:11] aaa :( [03:15:23] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-History-or-Diffs, 10Wikimedia-Developer-Summit (2017): Next steps for edit review - https://phabricator.wikimedia.org/T149664#2804844 (10Arlolra) [05:39:13] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10VisualEditor, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2804957 (10jayvdb) See also {T150732}, for a specific area where our lack of modern communication system is hurting out outreach efforts, an... [07:43:13] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2805022 (10Matanya) The UI did it, you can see other hit that too, by looking in the logs on flourine/logstash. [10:27:56] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement: Special:Notifications doesn't load on mediawiki.org - https://phabricator.wikimedia.org/T151038#2805370 (10Trizek-WMF) [10:29:14] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement: Special:Notifications doesn't load on mediawiki.org - https://phabricator.wikimedia.org/T151038#2805387 (10Trizek-WMF) [10:35:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#2805445 (10Pginer-WMF) >>! In T151006#2804469, @jmatazzoni wrote: > @Pginer-WMF, in writing this up fo... [10:39:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to educate on the option to highlight results on the Recent Changes designs - https://phabricator.wikimedia.org/T147838#2805472 (10Pginer-WMF) [10:54:12] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement: Special:Notifications doesn't load on mediawiki.org - https://phabricator.wikimedia.org/T151038#2805525 (10Trizek-WMF) [10:54:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2805529 (10Pginer-WMF) >>! In T149637#2804020, @jmatazzoni wrote: > - Once t... [11:00:01] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2805561 (10Aklapper) [11:00:24] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2805564 (10Aklapper) 05Resolved>03Invalid [11:00:40] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2805512 (10Krenair) Am on my phone but there's something on mw.o project:request... [11:01:22] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2805567 (10Krenair) Oh, everyone else beat me to it. Okay [11:17:54] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2805589 (10jcrespo) >>! In T149637#2799749, @SBisson wrote: > Pinging @jcrespo... [11:27:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2805622 (10jcrespo) > If so, could you help us find a better strategy? Use `... [11:36:44] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2805673 (10Pginer-WMF) >>! In T149637#2804020, @jmatazzoni wrote: > I also wro... [11:50:03] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#2805745 (10Pginer-WMF) >>! In T149467#2802989, @SBisson wrote: > Pinging @j... [13:46:50] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2805512 (10TheDJ) It seems to me like some caching layer missed the signal that... [14:01:03] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Can't load VE or Flow, no toolbar displayed on wikitext editor and no content displayed on Special:Notification on mediawiki.org - https://phabricator.wikimedia.org/T151042#2806002 (10TheDJ) Re-added the gadget, then removed it again. This seems to have... [15:00:56] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2806165 (10SBisson) >>! In T149637#2805622, @jcrespo wrote: >> If so, could y... [15:06:10] (03CR) 10Sbisson: [C: 04-1] "The dry-run mode worked fine but when I tried to run it for real I got this error: https://phabricator.wikimedia.org/P4473" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [15:11:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2806197 (10Halfak) For what it's worth, I've requested that an index be made o... [16:46:49] matt_flaschen: just out of curiosity - can it be possible related to new Flow cache? https://phabricator.wikimedia.org/T151042 [17:05:12] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2806547 (10Samwalton9) >>! In T132084#27... [18:39:33] Breaking for lunch and Spanish group [19:10:44] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Availability, 13Patch-For-Review, 07Wikimedia-Multiple-active-datacenters: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2806888 (10Etonkovidova) @Catrope: there ERRORs i... [20:25:15] mooeypoo, I could use a review on the patches in the https://gerrit.wikimedia.org/r/#/c/311856/ stack when you have a chance. [20:25:21] Let me know what you need review on. [20:36:53] matt_flaschen, ok looking now (and aftr lunch) -- I think my rcfilters patch -- though it's not ready to be merged yet, is also ready for at least preliminary review https://gerrit.wikimedia.org/r/#/c/320332 [20:51:46] mooey|lunch, thanks, will review today or this weekend. [21:05:50] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2807211 (10Halfak) Just made the primary post here: https://www.mediawiki.org/wiki/Topic:Tflhj... [21:07:27] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Availability, 13Patch-For-Review, 07Wikimedia-Multiple-active-datacenters: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2807216 (10SBisson) >>! In T120009#2806888, @Eton... [21:17:10] (03PS1) 10Esanders: build: Replace jscs/jshint with eslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/322339 [21:45:00] 06Collaboration-Team-Triage, 10Notifications: Disable notification about links to created pages when links are added by reverting an edit - https://phabricator.wikimedia.org/T148949#2807285 (10Sjoerddebruin) Please fix this. Reverting [[https://www.wikidata.org/w/index.php?title=Wikidata%3AContact_the_developm... [22:12:54] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2807318 (10jmatazzoni) @Samwalton9 wrote... [22:15:01] mooeypoo, did you solve your git issue? [22:16:33] matt_flaschen, yeah I ended up abandoning and just redoing the change :\ [22:16:44] matt_flaschen, I tried at first to rebase --onto but that didn't work [22:17:11] I think that commit was a weird one, it was a rebase-thing that wasn't really rebasing (I think I did 'git pull' while I was in the commit rather than in master or something?) [22:17:23] anyways, I just redid it, since it was only one file that I still had + minor changes. But it was annoying :( [22:17:28] thanks [22:19:37] matt_flaschen, I never used pageTriage, can you give me a little background so I can test/code review your patches? [22:21:43] Yeah, I think you pulled master into your branch. Maybe from git pull, though I think on some settings it prompts you (one of the things git has too many options for). [22:22:07] mooeypoo, basically it is a toolbar on the right of the page that gives you options to take actions (e.g. tag a page as needing more sources, mark it for deletion, etc.). [22:22:33] matt_flaschen, I have it in vagrant, I don't see anything though? Do I need to enable anything? [22:22:34] You need to have 'patrol' to use it (Admin should be fine), then the entry point is Special:NewPagesFeed. [22:22:41] * mooeypoo nods [22:23:33] mooeypoo, if you choose an option with a note (e.g. 'review' I think lets you write one), it will post on the user's talk page. You can test to make sure it posts on a Flow talk page correctly (and wikitext if you want) [22:23:59] There are a few that post on their talk, that's one of them. [22:24:11] ok Sso I need to make sure I test this on a user that has Flow in their talk page and one who doesn't [22:26:21] matt_flaschen, when I click "Review" it just takes me to the page [22:26:30] Hmm, one sec. [22:29:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2807370 (10jmatazzoni) [22:29:32] mooeypoo, after you get to the page, you'll see the toolbar on the right. Then, the checkmark is the review button. [22:30:08] matt_flaschen, hovering over the checkmark says "This page was autopatrolled" and gives me no option [22:30:14] what do I do to add a page I can test with? [22:30:44] also, this isn't a really clear ui :\ [22:31:35] mooeypoo, create a page as an IP, then visit it as an admin. [22:31:40] matt_flaschen, ha! I found one that has "this page is still unreviewed" [22:31:43] If it's already reviewed, you won't have the same options. [22:31:49] Cool [22:31:51] but I can't click it or do aynthing [22:32:02] mooeypoo, there's no review? [22:32:18] There is a "Review >" Button but it just takes me to that page [22:32:28] oh! There's a toolbar on the right... wow, I'm blind [22:32:55] ok which button in there will write a message to the user, though? [22:33:21] mooeypoo, one of them is the check mark, which just patrols it, but lets you leave a note. If you choose to leave a note, it will go on the creator's talk page. [22:33:40] Got it [22:33:46] I can do it on existing pages, too, it seems [22:33:49] great [22:34:03] mooeypoo, also, all the deletion (trash can) trigger a talk page notification. [22:34:46] mooeypoo, for bonus points, do it on the default wiki, but with Hebrew UI. I fixed https://phabricator.wikimedia.org/T150552 . [22:34:49] matt_flaschen, k, so, it works but I get the content to be: {{subst:Unreviewednote-NPF|H4pUclx9ST|Admin|Test message Foo link somewhere.}} [22:35:00] Foo was a [[Foo]] link, so I seem to have lost that [22:35:06] and I don't have whatever this is substituting [22:35:33] mooeypoo, I don't know about the http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Foo. But I did consider the template thing. [22:35:48] mooeypoo, you can import the XML file included. [22:35:58] The patch even shows which templates change as a result of the refactoring. [22:36:09] ok, but I lost the link [22:36:14] I mean the wikitext link [22:36:44] mooeypoo, okay, let me test that. [22:37:53] Also (this has nothing to do with your patch, but just saying) "I have unreviewed a page you curated" is so confusing. [22:38:11] I have no idea what that means, and I can see how new editors will be completely baffled by this. [22:39:10] matt_flaschen, ok the wikitext actually works. SORRY. I seemed to have had a fluke here and misread. I tested again with [[Foo]] and ''wikitext'' and they both work [22:41:26] mooeypoo, okay, good, I was going to say (wouldn't be impossible, look at EchoDiscussion parser but I didn't remember it). [22:41:34] mooeypoo, that message is not sent to new users. [22:41:58] Yeah my anonymous user got "A page you started has been reviewed" [22:42:03] better message, for sure [22:42:09] mooeypoo, it's sent to reviewers, saying "I am another reviewer and disagree with your earlier reviewing decision". Not sure if it's enabled or used, whatever, but it's targeted for power users. [22:42:17] Paraphrasing. [22:42:24] Got it [22:42:39] so far it works perfectly [22:42:50] minus the template, but I am not really bothering with that atm. Checking RTL [22:43:20] mooeypoo, yeah, you can import the XML file, but you can basically tell from the source that it *would* do the right thing if it existed. [22:43:24] ew the translation doesn't sound right to me... [22:43:32] (Nothing to do with your patch obviously) [22:43:43] yeah I'm not worried about that [22:44:00] ha, the arrow is backwards [22:44:41] matt_flaschen, the popup to write a message doesn't appear in RTL for me [22:45:03] mooeypoo, I wonder if the vertical toolbar is more or less weird in Mongolian. [22:45:15] The sidebar is on the right again (should be on the left, really, btw) but then when I click the checkmark, no popup [22:45:46] mooeypoo, ahg, it's probably off-screen. [22:45:55] matt_flaschen, yeah, the popup is on the right of the toolbar (off screen) [22:46:07] mooeypoo, although I could make the case that the toolbar should be on the right for RTL, and it's actually wrong for LTR (isn't it sort of weird to have a toolbar at the end of the page...) [22:46:10] (03PS1) 10Esanders: build: Replace jshint/jscs with eslint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 [22:46:47] You didn't see it, probably because of that. [22:46:54] mwe-pt-toolbar should have right:auto;left:0; for RTL it seems like [22:47:09] matt_flaschen, it's slightly beyond the scope of your fix, though [22:47:10] (03PS1) 10Esanders: Simplify 'vendor' in .gitignore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 [22:47:15] but i can't check in RTL [22:47:16] mooeypoo, slightly. :) [22:47:19] :P [22:47:26] mooeypoo, yeah, you can check Spanish if you want. [22:47:29] I only checked like that because you *said* you fixed it :D [22:47:34] mooeypoo, I did! [22:47:38] I just didn't test Hebrew. :) [22:47:42] haha [22:47:53] be careful what you wish for in CR [22:47:53] :P [22:48:19] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2807388 (10jmatazzoni) @Pginer-WMF writes: > We may want to also capture the g... [22:48:26] mooeypoo, anyway, file please unless you want me to, or you're going to Just Fix It TM. [22:49:05] (03CR) 10Krinkle: "vendor/ exists in Git and contains some JS files." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 (owner: 10Esanders) [22:51:58] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 (owner: 10Esanders) [22:53:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2807393 (10jmatazzoni) Thanks Aaron. I'll be watching that space. Did you decide that the prot... [22:53:57] etonkovidova, belated response: I don't think that's related to the Flow caching changes, it seems like a very different kind of caching. [22:54:04] Re https://phabricator.wikimedia.org/T151042 [22:54:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2807394 (10Halfak) Actually, no. I think that we should respond with a link to the prototype!... [22:54:38] matt_flaschen: yes, agree - thx [22:54:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2807395 (10jmatazzoni) Sure. Will do. [22:55:34] (03CR) 10Esanders: "This won't ignore existing tracked files though." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 (owner: 10Esanders) [22:58:02] * mooeypoo fixed it [22:58:20] matt_flaschen, a little hackily, but the only other way to really fix it is to do a bit of rewriting, so I'm not going to do that [22:58:37] (03PS2) 10Esanders: Simplify 'vendor' in .gitignore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 [22:59:17] (03CR) 10Mattflaschen: [C: 04-1] "Yeah, it's fine. It's just a couple JS libraries. We're unlikely to add more now that we're using OOjs UI. It's possible we might do so" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 (owner: 10Esanders) [23:00:08] (03CR) 10Mattflaschen: [C: 032] "Sorry, jinx. :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 (owner: 10Esanders) [23:05:51] matt_flaschen, I can't believe there were no complaints about PageTriage not showing the popups in RTL [23:06:05] no rtl wiki is using the tool? Or do they just think there's no message option... [23:06:25] Funny thing -- if I fix this and suddenly all RTL users are all "omg we can add a message when we approve -- is that new?!" [23:06:45] LOL [23:07:04] mooeypoo, it's only deployed on enwiki and test wikis. I would have told you that before you started submitting fixes to the BiDi spec... [23:07:41] mooeypoo, I actually should have mentioned that before, but I didn't think of it. [23:07:59] rofl [23:08:05] well, I already have a fix [23:08:36] (03Merged) 10jenkins-bot: Simplify 'vendor' in .gitignore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322360 (owner: 10Esanders) [23:08:51] mooeypoo, in my defense, there are actually people using it in French (T150552). I don't know about RTL languages, though. [23:08:52] T150552: Page Curation edit summaries should be in the wiki's language - https://phabricator.wikimedia.org/T150552 [23:09:29] * matt_flaschen notes to only use RTL languages as examples for multi-lingual issues if we know for certain at least one RTL user is using the product. [23:09:34] Note to self [23:09:48] :D [23:10:07] (03PS1) 10Mooeypoo: Display sidebar in RTL/LTR correctly [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/322361 [23:10:09] matt_flaschen, ^^ [23:10:20] It's far from being a comprehensive fix, but it makes the popup work [23:10:47] so now if anyone **wants** to use it in RTL interface, they **can** [23:10:49] ... [23:11:52] matt_flaschen, also, work-wise ,your fix is checked by me. It seems to work great. [23:12:10] I'm going to try and go over the code, but I don't know the codebase very well - Roan should probably double check the code behavior [23:12:59] mooeypoo, neither did I before I wrote that patch. :) [23:13:20] mooeypoo, also, "If the toolbar has been dragged to the other side of the screen". I don't even think I knew you *could* drag it... [23:14:05] matt_flaschen, yeah, I was suspicious about the lack of RTL support when I saw the class "-flipped" and "-not-flipped" [23:14:22] ... I was all "wait, doesn't that supposed to mean it's supporting it?" Then I saw the comment and realized what it's MEANT to do [23:14:49] ironically, this means that what's -flipped in LTR is -not-flipped in RTL and vise versa [23:14:53] hee [23:15:47] That seems right, in a double-flipped way... [23:16:02] So, that seems left? [23:16:11] No, because it's double-flipped. ;) [23:16:17] Also, I still insist that it's supposed to be on the left side of the screen in LTR, and that's the real bug. [23:16:18] ^ Good point [23:16:22] ;) [23:16:26] haha [23:19:16] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Edit Authorship' filters - https://phabricator.wikimedia.org/T149859#2807420 (10jmatazzoni) @SBisson, I just wanted to confirm. Are we able to meet this requ... [23:23:06] (03CR) 10Mattflaschen: [C: 032] "Checked all permutations (LTR, RTL, left side screen, right side screen)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/322361 (owner: 10Mooeypoo) [23:29:02] (03CR) 10Jforrester: [C: 031] "LGTM. Leaving to the Collaboration team to merge." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/322339 (owner: 10Esanders) [23:29:31] (03Merged) 10jenkins-bot: Display sidebar in RTL/LTR correctly [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/322361 (owner: 10Mooeypoo) [23:31:03] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage, 10Flow: Abuse filter on Polish WP not working for Flow - https://phabricator.wikimedia.org/T107614#2807471 (10He7d3r) Hm... Indeed. @FcoLeonSaudanha suggested¹ that it should be possible to add a filter to more than a group. Does that se... [23:31:55] mooeypoo, it would be nice to indicate that you can drag the toolbar, but I'm not sure a straightforward way to do that. I thought about marking it with cursor: hand, but then the whole thing is one huge click zone. [23:34:12] (03CR) 10Jforrester: build: Replace jshint/jscs with eslint (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322359 (owner: 10Esanders) [23:36:16] mooeypoo, can you take a look at https://phabricator.wikimedia.org/T149251 and see if you can find the link he is talking about? [23:36:23] I don't see it on either board history or topic history. [23:36:35] My theory is that it's generated by a gadget, but I want to be sure I'm not missing something obvious. [23:40:35] Checking [23:42:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#2807505 (10jmatazzoni) [23:42:36] matt_flaschen, I do see the workflowId in the history when I search the source [23:44:08] mooeypoo, I only see offset=workflowid , not offset=timestamp (the latter is in the task). I think you're confirming, if I understand right. [23:44:23] I am not sure I understand [23:45:06] matt_flaschen, The error message is "Unable to load history for skt7uo1dwlujk8w5" so I was looking for that workflow ID [23:45:27] I found it in the big blob in the source, but I'm not sure what I'm looking for other than that [23:46:06] Oh yeah, that's not what I meant. [23:46:08] The bug reports that the URL https://www.mediawiki.org/w/index.php?action=history&offset=20160126191716&title=Talk%3AMediaWiki causes an exception. I agree it does, but matanya said that broken URL is linked from the UI and I don't see where. [23:46:19] (Or any URLs of similar form, containing a timestamp) [23:46:23] hm [23:47:10] Confirmed, yeah I see no links with &offset= at all [23:47:42] wait, no, I do see &offset= but not with timestamp [23:48:12] matt_flaschen, these are the ones I have: https://www.mediawiki.org/w/index.php?title=Talk:MediaWiki&offset=t612hdgvlqxbggci&action=history [23:48:17] offset with UUID [23:48:39] mooeypoo, yeah, same. [23:48:45] That exception really just means the history query failed AFAICT. [23:48:56] yeah. I wonder where he's getting that link [23:49:05] It is not saying, "I can't find revision with this ID" or something, just that the query failed, probably because it's trying to construct a UUID from the timestamp. [23:49:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#2807515 (10jmatazzoni) [23:49:16] hm [23:49:33] Want me to confirm in the task, or are you posting? [23:49:38] mooeypoo, I'll follow up on the task. [23:49:42] * mooeypoo nods [23:49:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2807516 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [23:52:33] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: [bug] flow fatal in 1.28.0-wmf.23 - - https://phabricator.wikimedia.org/T149251#2807524 (10Mattflaschen-WMF) @matanya Could you post a URL (where the broken link itself is), and a screenshot, and circle (or otherwise c... [23:53:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#2807525 (10jmatazzoni) [23:56:33] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: Opening help dialog in Flow VE (CTRL+?) throws an exception - https://phabricator.wikimedia.org/T151096#2807528 (10Esanders)