[00:16:51] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Flow: [minor] Images links in Flow topic/replies get odd truncation - https://phabricator.wikimedia.org/T150818#2797705 (10Etonkovidova) [00:22:12] matt_flaschen, sure [00:25:55] mooeypoo, have you used useFakeTimers? [00:27:25] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: [minor] Flow: if Reply has only an image, the text excerpts will display a dot if the notification gets bundled - https://phabricator.wikimedia.org/T150819#2797728 (10Etonkovidova) [00:27:29] matt_flaschen, no? [00:28:00] mooeypoo, it basically creates a simulated clock that only moves forward when you explicitly tell it to. [00:28:13] So the two now objects should be the same, and it should work. [00:28:24] it works on moment() ? [00:28:43] mooeypoo, it should, I'll check. [00:28:48] * mooeypoo nods [00:29:20] matt_flaschen, I am having problems testing this, because for me, the test always passes -- the timing isn't enough to fail it. But James_F pointed out it occasionally fails in jenkins tests [00:30:27] Yeah, makes sense, timing varies, but if we get it working with sinon it won't depend on actual runtime timings. [00:30:37] * mooeypoo nods [00:32:24] James_F: do you want to know that Twinkle on betalabs incapacitates VE? [00:33:40] etonkovidova: I'm unsurprised. It probably does the same in production. [00:34:06] James_F: in production?! wow [00:34:55] etonkovidova: It's Twinkle. It breaks most of the things it touches. :-( [00:35:45] James_F: sigh It drove me nuts when I saw that some users cannot use VE with no apparent reason. I was happy to find out that it [00:35:59] James_F: is Twinkle! [00:36:08] * James_F nods. [00:53:53] mooeypoo, confirmed, it works. You can confirm for yourself with: [00:54:02] for ( var i = 0; i < 10000000; i++ ) { if ( i % 1000000 === 0 ) { console.log ( moment.utc().format( 'YYYY-MM-DD[T]HH:mm:ssSSS[Z]' ) ); } } [00:54:03] } ); [00:54:26] For me, that is enough to show different times consistently, but once you enable useFakeTimers, it will always be 1970. [00:55:57] (You can instead pass an arbitrary timestamp into useFakeTimers, though) [00:59:47] ha [01:18:58] (03CR) 10Jforrester: "> Should those icons live in the Thank extension?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [03:05:27] (03PS1) 10Mattflaschen: Fix editing the titles of topics with summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/321835 (https://phabricator.wikimedia.org/T149827) [03:08:16] Have a good night, everyone. [09:54:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798295 (10Pginer-WMF) [09:56:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798312 (10Pginer-WMF) [10:16:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2798387 (10Pginer-WMF) [10:18:17] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a user option for the beta page describing the new RC page filters and enabling users to opt in - https://phabricator.wikimedia.org/T144457#2600312 (10Pginer-WMF) I added some design proposals for the onboardi... [10:44:38] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to spotlight the new filters on the RC page interface - https://phabricator.wikimedia.org/T150312#2798459 (10Pginer-WMF) [10:47:59] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to spotlight the new filters on the RC page interface - https://phabricator.wikimedia.org/T150312#2798467 (10Pginer-WMF) I added details in the description with a proposed design. Note that I proposed to... [11:03:04] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to educate on the option to highlight results on the Recent Changes designs - https://phabricator.wikimedia.org/T147838#2798528 (10Pginer-WMF) [11:04:16] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to educate on the option to highlight results on the Recent Changes designs - https://phabricator.wikimedia.org/T147838#2705223 (10Pginer-WMF) I added details for a proposed solution in the ticket descri... [11:05:17] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798295 (10Pginer-WMF) [11:05:20] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2798554 (10Pginer-WMF) [11:05:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to educate on the option to highlight results on the Recent Changes designs - https://phabricator.wikimedia.org/T147838#2798552 (10Pginer-WMF) [11:05:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798295 (10Pginer-WMF) [11:05:40] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to spotlight the new filters on the RC page interface - https://phabricator.wikimedia.org/T150312#2798562 (10Pginer-WMF) [11:13:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798605 (10Pginer-WMF) [11:13:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Design onboarding and education process for the new Recent Changes filters - https://phabricator.wikimedia.org/T150836#2798295 (10Pginer-WMF) [11:22:09] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage, 10Flow: Abuse filter on Polish WP not working for Flow - https://phabricator.wikimedia.org/T107614#1499341 (10He7d3r) >>! In T107614#1507123, @Legoktm wrote: > The AbuseFilter rules need to be in the "Flow" group. See for example https://ww... [11:46:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Collaboration-Community-Engagement, 07WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#2798684 (10He7d3r) Any estimates on when this will be done? [14:03:26] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2799119 (10Pginer-WMF) >>! In T149637#2787327, @jmatazzoni wrote: > @Pginer-WMF, we sho... [14:39:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Gather assets for post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150855#2799196 (10Halfak) [14:40:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Gather assets for post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150855#2799229 (10Halfak) [14:53:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2799252 (10Halfak) [14:53:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2799270 (10Halfak) [14:54:01] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Gather assets for post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150855#2799269 (10Halfak) [17:24:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10DBA, 13Patch-For-Review: Implement functionality for RC page 'Experience level' filters - https://phabricator.wikimedia.org/T149637#2799749 (10SBisson) Pinging @jcrespo and @Marostegui For this ticket, we join... [18:47:05] stephanebisson, I see 'hidemajor' and 'userExpLevel' -- is there anything for mine/others filter? [18:47:37] found it [18:47:42] mooeypoo: there's 'hidemyself' already in and a patch for 'hidebyothers' [18:48:05] got it. I'm going to rebase my patch on top of that one, then? [18:48:21] It's dependent on it [18:48:27] well, I mean, it can't work without it [18:49:44] stephanebisson, also, ha, I need to change the "logic" of the filter I assumed. I temporarily called it "editsbyself" / "editsbyothers" (positive) instead of the "hidemyself"/"hideothers" (negative) [18:50:30] mooeypoo: nobody said it would not be unintuitive ;) [18:51:00] "underintuitive" ... ? [18:51:41] ... wait, crap, this also means I need to rethink the defaults and the way I build the URL query [18:51:50] if none is selected, both are true [18:51:53] * mooeypoo sighs [18:52:09] wait, no, both are still false.. [18:52:10] .... [18:52:13] ok I'm so confused. [18:53:13] ... ok, ok, I'm going to flip their values. "Show edits by me" is actually "hideothers" and "show edits by others" is actually "hidemyself" [18:53:35] This is going to be a really confusing quarter. :\ [19:36:22] Per unmeeting, I suggested the way to do this is to have marker that a group is hide-based/legacy, then if anything is checked in that group, loop through and hide the unchecked ones. [19:37:35] Since if they check both "Show edits by me" and "Show edits by others", that doesn't mean create a URL with both hideothers and hidemyself. That would do the opposite. [19:38:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to educate on the option to highlight results on the Recent Changes designs - https://phabricator.wikimedia.org/T147838#2800337 (10jmatazzoni) [20:53:36] Taking a break. Will be back in ~half hour. [22:05:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2799252 (10jmatazzoni) - Here's a video I made to demo the new interface specifically for OR... [22:06:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Gather assets for post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150855#2799196 (10jmatazzoni) - Here's a video I made to demo the new interface s... [22:42:48] matt_flaschen: not important, but I keep seeing on test2wiki that on initial extending of the cross-wiki bundle, empty placeholder is displayed [22:43:22] matt_flaschen: I remember that RoanKattouw was saying that test2 is on a different cluster of smth [22:44:16] No idea, I don't think it's on a different cluster, not sure what he was referring to. [23:22:08] 06Collaboration-Team-Triage, 10Notifications: Archiving threads pings users - https://phabricator.wikimedia.org/T150913#2801038 (10Pppery) [23:47:30] 06Collaboration-Team-Triage, 10Flow, 07Mobile, 07Wikimedia-log-errors: Diff not implemented for Flow\Content\BoardContent - https://phabricator.wikimedia.org/T150383#2784157 (10Etonkovidova) For future testing (after the fix): - wikitext pages do not produce errors for Special:MobileDiff (at least I canno...