[00:04:06] (03PS2) 10Kmuthu: Hides orange alert for notifications read in the edit-user-category [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [00:34:07] (03PS2) 10Kmuthu: Hide orange alert when the user is viewing the topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) [00:45:16] (03PS3) 10Kmuthu: Show orange alert and provide hook to enable other extensions to prevent the orange alert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [01:38:03] (03CR) 10Catrope: [C: 04-1] "Looks good, two very minor things" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [01:40:17] (03CR) 10Catrope: [C: 04-1] "Looks good, minor comments" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [01:41:01] (03CR) 10Catrope: [C: 032] Move some flow notifications to other categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314801 (https://phabricator.wikimedia.org/T133220) (owner: 10Kmuthu) [01:48:00] (03Merged) 10jenkins-bot: Move some flow notifications to other categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314801 (https://phabricator.wikimedia.org/T133220) (owner: 10Kmuthu) [01:49:19] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice, 07User-notice-collaboration: Sort out Notification categories to make them more logical for Preferences - https://phabricator.wikimedia.org/T133220#2715221 (10Catrope) >>! In T133220#2703854, @T... [01:51:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice, 07User-notice-collaboration: Sort out Notification categories to make them more logical for Preferences - https://phabricator.wikimedia.org/T133220#2715223 (10Catrope) >>! In T133220#2715220, @g... [03:23:27] 06Collaboration-Team-Triage, 10Flow: Move a Flow board is not possible - https://phabricator.wikimedia.org/T147942#2715291 (10Mattflaschen-WMF) I tried to test this on Beta, but ran into serious unrelated problems ({T148111} which I can't track down due to { T146723}). [03:26:42] 06Collaboration-Team-Triage, 10Flow: Move a Flow board is not possible - https://phabricator.wikimedia.org/T147942#2715306 (10Mattflaschen-WMF) However, that account should indeed be able to move boards, so I can test it with https://wikitech.wikimedia.org/wiki/Debugging_in_production#Debugging_action_API_requ... [03:30:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2715308 (10Mattflaschen-WMF) [03:30:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2666304 (10Mattflaschen-WMF) [03:31:26] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2668321 (10Mattflaschen-WMF) [03:31:34] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2669919 (10Mattflaschen-WMF) [03:37:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2715326 (10Mattflaschen-WMF) [06:27:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2715456 (10Raspberrypy) I am sorry about removing subscribers..i did not do it intentionally , as i thought tho... [08:17:13] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2715541 (10Raspberrypy) [08:32:35] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2715561 (10Sumit) @Raspberrypy thanks for your application! Make sure a copy of this is also submitted to ht... [08:49:39] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2715579 (10Raspberrypy) [08:51:10] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2715579 (10Raspberrypy) [09:01:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Prototype an improved version of Recent Change designs - https://phabricator.wikimedia.org/T147632#2715598 (10Pginer-WMF) Thanks for the input @Trizek-WMF There is still an open question about how much prominent sho... [09:03:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2715601 (10Framawiki) [09:55:05] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2715760 (10Aklapper) Thanks! > There has been a long felt need by Wikime... [09:57:31] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2715765 (10Aklapper) @raspberrypy: I'm afraid [[ https://www.mediawiki.org/wiki/Phabricator/Help#Formatting... [12:34:19] (03CR) 10Sbisson: "It looks good. I'm tempted to +2 but as of today I cannot reproduce the issue in production and I can reproduce it locally with or without" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314480 (https://phabricator.wikimedia.org/T138310) (owner: 10Mattflaschen) [12:34:27] 06Collaboration-Team-Triage, 10Notifications: Develop a properly-designed way to tag groups of users - https://phabricator.wikimedia.org/T148154#2716221 (10Amire80) [12:35:03] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech: Develop a properly-designed way to tag groups of users - https://phabricator.wikimedia.org/T148154#2716247 (10Amire80) [12:49:46] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 10Outreachy (Round-13), and 2 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2716350 (10Nemo_bis) [12:57:29] (03PS3) 10Sbisson: [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 [13:02:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 (owner: 10Sbisson) [13:17:08] (03PS4) 10Sbisson: [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 [13:21:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 (owner: 10Sbisson) [14:55:17] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 10Outreachy (Round-13), and 2 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2716911 (10Raspberrypy) @Aklapper thanks.. I will change that. [15:37:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Notifications, 13Patch-For-Review: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2716950 (10Trizek-WMF) A few questions to reassure me: do you take the actual OBO... [15:38:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Notifications, 13Patch-For-Review, 07User-notice-collaboration: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2716951 (10Trizek-WMF) [15:59:25] (03CR) 10Krinkle: [C: 032] Switching to simpler "new MWTimestamp" and adding comment [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315584 (owner: 10Kaldari) [16:05:32] (03Merged) 10jenkins-bot: Switching to simpler "new MWTimestamp" and adding comment [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315584 (owner: 10Kaldari) [16:10:38] (03CR) 10Mooeypoo: Hide orange alert when the user is viewing the topic page related to their user talk page (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [16:24:51] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Sort out Notification categories to make them more logical for Preferences - https://phabricator.wikimedia.org/T133220#2717178 (10Trizek-WMF) >>! In T133220#2715221, @Catrope wrote:... [16:33:54] (03PS4) 10Kmuthu: Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [16:36:49] 06Collaboration-Team-Triage, 10Flow: Move a Flow board is not possible - https://phabricator.wikimedia.org/T147942#2717230 (10Trizek-WMF) Thanks @Ibrahim.ID! >>! In T147942#2713684, @Mattflaschen-WMF wrote: > The destination should be completely non-existent before you do the move. Please have the blank dest... [16:56:33] kmuthu, RoanKattouw I know I'm being a pain here, but since you are *creating* this hook, I propose to consider an alternative non-mind-melting double-negatory name. [16:57:00] "onDisplayingOrangeAlert" or even onBeforeDisplayOrangeAlert [16:57:14] when we do "onAbort" and then we don't abort on true and abort on false it's really confusing [16:57:53] I have been thinking about how best to convey the idea behind. [16:58:09] kmuthu, it's really not your fault here -- MediaWiki is **full** of these types of confusing hooks [16:58:19] so you're going with the flow (pun intended) [16:58:43] but maybe we can break the mold a little bit... RoanKattouw should be the judge on that, he's the MW hook master, but I have to at lesat raise this as an issue [16:58:45] It's alright. It is better to be clear about code and comments [16:59:53] I believe I am going with the "Flow" [17:00:11] ^ Best flow to go with! [17:05:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Design a way to better orient users when combining multiple highlights - https://phabricator.wikimedia.org/T147295#2717329 (10Trizek-WMF) >>! In T147295#2691791, @Pginer-WMF wrote: >> - The bullets are a little sma... [17:08:59] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016), and 2 others: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2717331 (10Trizek-WMF) First issue will be sent on Monday. [17:16:16] (03CR) 10Catrope: Hide orange alert when the user is viewing the topic page related to their user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:16:33] matt_flaschen: this is the patch: https://gerrit.wikimedia.org/r/#/c/315702 It doesn't seem to clear the data between tests. [17:17:54] (03CR) 10Catrope: [C: 04-1] "-1ing for now because the name of the hook is being discussed at https://gerrit.wikimedia.org/r/#/c/315740 ; this commit is fine otherwise" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:23:31] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-PageCuration: Special:NewPagesFeed incorrectly states "No Categories" when categories exist - https://phabricator.wikimedia.org/T147721#2717359 (10DatGuy) I believe that the patch didn't work. See {F4603627} And [[ https://en.wi... [17:24:29] stephanebisson, did you try putting it after the parent::setUp() ? I ran into a weird thing where setUp didn't seen to work on https://gerrit.wikimedia.org/r/#/c/307426/ (see older patches and comments), but then it ended up working in the end (and it was after there). [17:27:07] matt_flaschen: I think I did, but let me try it again in CI. It works locally either way. [17:27:27] (03PS5) 10Sbisson: [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 [17:28:19] (03PS3) 10Kmuthu: Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) [17:30:55] (03PS5) 10Kmuthu: Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [17:31:01] (03CR) 10jenkins-bot: [V: 04-1] Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:31:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] phpunit API tests for get notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315702 (owner: 10Sbisson) [17:32:15] matt_flaschen: ^ Negative sir. [17:34:05] (03CR) 10Sbisson: "I haven't tested but it looks reasonable. 2 minor comments (about comments) inline." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314299 (owner: 10Sbisson) [17:37:35] stephanebisson, got it, I'll look again later. [17:38:02] stephanebisson, do you mind if I amend your patch? [17:38:10] I might try the constructor thing. [17:38:14] matt_flaschen: not at all [17:39:15] (03CR) 10Catrope: [C: 04-1] "The tiniest of nitpicks" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:40:01] (03CR) 10Catrope: [C: 04-1] Show orange alert and provide hook (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:41:20] RoanKattouw, stephanebisson, mooeypoo, BTW, https://gerrit.wikimedia.org/r/#/c/307426 still needs a re-review when you can. [17:41:40] ^ legoktm [17:41:53] hey [17:42:23] I'm at an offsite right now, but i'll keep it in an open tab [17:46:26] Thanks [17:46:50] Speaking of reviews, this is also waiting https://gerrit.wikimedia.org/r/#/c/312940/ [17:46:56] matt_flaschen, I'll take a look too soon [17:47:05] wrestling with phpstorm [17:47:10] and xdebug [17:50:31] (03PS4) 10Kmuthu: Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) [17:52:18] (03CR) 10Catrope: [C: 04-1] (re)Add JavaScript hooks to Notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312940 (https://phabricator.wikimedia.org/T146296) (owner: 10Mooeypoo) [17:52:31] (03PS6) 10Kmuthu: Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [17:52:42] mooeypoo: Your hooks patch looks OK except that there's still a types vs type thing that I'm convinced breaks something [17:54:59] (03PS7) 10Kmuthu: Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) [17:55:14] (03CR) 10Catrope: "PS7: Line-wrapped commit message" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:55:17] (03CR) 10Catrope: [C: 032] Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [17:59:31] (03PS5) 10Kmuthu: Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) [17:59:42] (03CR) 10Catrope: [C: 032] Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [18:00:46] RoanKattouw, I thought I fixed them all [18:00:50] I'll go over it agian [18:00:59] RoanKattouw, kmuthu also, meeting? [18:01:49] (03Merged) 10jenkins-bot: Show orange alert and provide hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315730 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [18:02:06] Getting lunch [18:09:40] Going to the library. Will be on hangout but not here. [18:25:59] (03CR) 10Catrope: "Cool story Jenkins... going to re-+2 this" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [18:26:02] (03CR) 10Catrope: [C: 032] Hide orange alert when the user is viewing a topic page related to their user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/315740 (https://phabricator.wikimedia.org/T137954) (owner: 10Kmuthu) [18:29:06] matt_flaschen: I still see the Database error for T148111 [18:29:08] T148111: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111 [18:29:16] matt_flaschen: logstash shows "A database query error has occurred. Did you forget to run your application's database schema update" [19:09:45] etonkovidova, yeah, I haven't tracked it down yet, but the logs should be there now. [19:10:00] matt_flaschen: ok [19:12:54] 06Collaboration-Team-Triage, 10Notifications: New notifs sometimes doesn't appear correctly - progress bar appears but nothing happens - https://phabricator.wikimedia.org/T148066#2713919 (10Mattflaschen-WMF) Can you ask them to blank their personal JS and turn off gadgets temporarily, and see if that fixes it?... [19:13:33] 06Collaboration-Team-Triage, 10Notifications: New notifs sometimes doesn't appear correctly - progress bar appears but nothing happens - https://phabricator.wikimedia.org/T148066#2717910 (10Mattflaschen-WMF) If that does fix it, they can turn things on one by one, until the issue is identified. [19:17:36] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Vertical alignment of logos and text in Notifications popup - https://phabricator.wikimedia.org/T147221#2717934 (10Volker_E) [19:19:05] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Vertical alignment of logos and text in Notifications popup - https://phabricator.wikimedia.org/T147221#2685548 (10Volker_E) @Pginer-WMF Have you set the reference layout also in correlation with the top of the popup anywhere? Is there a layou... [19:20:01] (03CR) 10VolkerE: [C: 04-1] "The globe icon would be on line with the notifications tray, but the whitespace isn't the same any more left and right. It would also just" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315313 (https://phabricator.wikimedia.org/T147221) (owner: 10Catrope) [19:21:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2717946 (10Mattflaschen-WMF) [19:41:14] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2717961 (10Mattflaschen-WMF) [19:42:12] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07User-notice-collaboration: Fix user talk pages already in inconsistent state due to to T138310 - https://phabricator.wikimedia.org/T148057#2713647 (10Mattflaschen-WMF) @Doror @Robor15 Your pages are fixed. Sorry for the inconvenience. The... [19:42:46] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech: Develop a properly-designed way to tag groups of users - https://phabricator.wikimedia.org/T148154#2717963 (10Aklapper) Could someone clarify the intention behind adding #Community-Tech to this task? [20:04:22] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111#2718019 (10Mattflaschen-WMF) [20:06:01] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111#2718020 (10bd808) The `lu_local_id` stuff is new code Ce... [20:08:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111#2715246 (10Mattflaschen-WMF) >>! In T148111#2718020, @bd... [20:09:45] matt_flaschen: It wasn't done, but it is now [20:10:44] bd808, did you do it? Thanks. [20:11:45] yeah. The migration file didn't have any indexes though. I'll look for them too [20:12:18] bd808, it says they're going to add indices after it's populated (it starts null). [20:12:24] I'll file bugs. [20:12:26] ah. [20:21:55] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111#2718120 (10Mattflaschen-WMF) [20:22:57] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: DBQueryError when creating account on Beta, or logging into newly-created accounts - https://phabricator.wikimedia.org/T148111#2715246 (10Mattflaschen-WMF) [20:24:05] (03CR) 10Catrope: "I don't understand what you're getting at here. Are you talking about the whitespace inside the icons?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/315313 (https://phabricator.wikimedia.org/T147221) (owner: 10Catrope) [20:28:48] etonk_lunch, I tracked down the login issue and bd808 fixed it. You should be able to create accounts and login normally on Beta. [20:30:55] bd808, it's not working. [20:31:32] is there a new error or the same one? [20:32:28] the centralauth.localuser table has the lu_local_id and lu_global_id columns now [20:33:14] hmm I wonder if we use the "auth" db instead? [20:33:20] E_TOOMANYDBS [20:34:02] bd808, it looks like you did it only on the slave. [20:34:06] Did you use sql centralauth ? [20:34:14] That is slave now, you have to do sql --write to get master. [20:34:16] oh... yeah [20:34:25] I'll do it now. [20:34:40] thanks [20:35:22] half-assed or not at all! That's my motto [20:35:23] :) [20:36:10] Done [20:36:42] 06Collaboration-Team-Triage, 10Notifications, 10BlueSky, 13Patch-For-Review: Update BlueSky to use current Echo api - https://phabricator.wikimedia.org/T106737#2718183 (10Isarra) [20:46:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2718219 (10Catrope) a:03KMuthu [20:50:19] bd808, now I can't login because of "The database has been automatically locked while the replica database servers catch up to the master.". Hopefully it is really just slave lag (but it has already been 13 minutes), not something wrong. [20:50:53] ugh. I bet it didn't like the columns already existing on the slave [20:51:31] want me to try dropping them? [20:54:20] bd808, yeah, go ahead. I didn't think of that. [20:55:20] matt_flaschen: ugh. doesn't seem to have magically fixed it. Still seeing "Warning: The database has been locked for maintenance, so you will not be able to save your edits right now. " [21:02:34] matt_flaschen: thx! Will check after "read-only mode" is gone :) [21:04:51] etonkovidova, yeah, it's broken. We're brainstorming now in #wikimedia-releng. [21:05:55] matt_flaschen: sigh ... [21:11:58] Does Flow enable CentralAuth in vagrant? [21:12:05] I have CentralAuth installed for some reason and it's causing me issues. [21:14:10] Actually it seems my install is totally messed up. I've got a bunch of stuff in here that really shouldn't be here. [21:15:29] Deskana, Flow depends on Echo, which does. [21:15:55] matt_flaschen: Thanks. I think I'm just going to go for the tried and true method of destroying everything and starting from scratch. :-p [21:16:31] Deskana, sorry about that. Also, it won't solve this, but if you're using wikimediaflow consider using flow depending on how precise you want your testing to be. [21:16:34] It's simpler. [21:16:37] T139203 [21:16:37] T139203: Separate cross-wiki infrastructure in Echo MediaWiki-Vagrant into separate crosswikiecho role - https://phabricator.wikimedia.org/T139203 [21:16:44] ^ That would solve your current issue. [21:17:24] matt_flaschen: Thanks. :-) [21:18:39] etonkovidova, okay, I restarted replication. Now Beta login really works. [21:19:23] (03PS1) 10Kaldari: Much simpler and more performant way to handle noindexing templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 [21:27:04] (03CR) 10Catrope: [C: 032] Much simpler and more performant way to handle noindexing templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 (owner: 10Kaldari) [21:29:06] (03Merged) 10jenkins-bot: Much simpler and more performant way to handle noindexing templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 (owner: 10Kaldari) [21:30:39] (03PS7) 10Catrope: Use ParserOutput instead of DB to check for categories [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) [21:31:38] (03CR) 10jenkins-bot: [V: 04-1] Use ParserOutput instead of DB to check for categories [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) (owner: 10Catrope) [21:32:25] (03CR) 10Catrope: "Per IRC convo I changed this to use LinksUpdateComplete instead of PageSaveComplete, but I'm not sure I'm all that happy with the result. " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) (owner: 10Catrope) [21:33:00] (03PS8) 10Catrope: Use ParserOutput instead of DB to check for categories [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315454 (https://phabricator.wikimedia.org/T147721) [21:38:03] 06Collaboration-Team-Triage, 10WikiLove, 06Brickimedia, 10Refreshed: WikiLove doesn't work with Refreshed - https://phabricator.wikimedia.org/T142534#2718319 (10SamanthaNguyen) [21:39:37] kmuthu, checking in - all good? [21:39:51] Or is your brain melted from Echo yet? [21:40:09] yes, all good [21:40:20] ha ha, not yet I guess [21:40:24] 06Collaboration-Team-Triage, 10WikiLove, 06Brickimedia, 10Refreshed: WikiLove doesn't work with Refreshed - https://phabricator.wikimedia.org/T142534#2718338 (10SamanthaNguyen) @lcf119 We can always make a pull request to WikiLove and have the commit code-reviewed :) [21:40:24] Wait for it... [21:40:26] ;) [21:40:31] thank you :) [21:40:58] SRSLY though, let me know if there's anything missing or not understandable or confusing in the tutorial. You're the first to actually use it to create the notification type [21:42:29] Sure, thanks. The tutorial is really helping me to get started. [21:45:26] 06Collaboration-Team-Triage, 10Flow: Move a Flow board is not possible - https://phabricator.wikimedia.org/T147942#2718346 (10Mattflaschen-WMF) >>! In T147942#2714142, @Etonkovidova wrote: > Moving Flow enabled page will give > ``` > "flow-board" content is not allowed on [destination page title] Confirmed o... [21:46:17] matt_flaschen: yes, betalabs looks good for new account creation and for logging those users that were created during database error turmoil [21:49:09] (03CR) 10Catrope: "It actually IS already set on the cluster, because it has a default value in PageTriage.php and that default value isn't overridden in wmf" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 (owner: 10Kaldari) [21:52:33] (03CR) 10Kaldari: "@Catrope: Yeah, but that's fine because the default config in PageTriage.php and the code that uses it will be changing at the same time. " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 (owner: 10Kaldari) [21:54:58] I'll be back in a few minutes. [21:55:30] (03CR) 10Catrope: "OK, I see what you're saying. BTW, there is also some discussion on-wiki at https://en.wikipedia.org/wiki/Wikipedia:Page_Curation/Suggeste" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/316003 (owner: 10Kaldari) [22:25:34] (03PS5) 10Mooeypoo: (re)Add JavaScript hooks to Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312940 (https://phabricator.wikimedia.org/T146296) [22:26:37] (03CR) 10Catrope: [C: 032] (re)Add JavaScript hooks to Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312940 (https://phabricator.wikimedia.org/T146296) (owner: 10Mooeypoo) [22:27:08] wow that was fast [22:35:29] Oh come on it was more than a minute [22:35:41] Most of us have done better than that :P [22:36:39] (03Merged) 10jenkins-bot: (re)Add JavaScript hooks to Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312940 (https://phabricator.wikimedia.org/T146296) (owner: 10Mooeypoo) [22:38:05] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2718449 (10Mattflaschen-WMF) [22:38:08] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2715541 (10Mattflaschen-WMF) [22:38:10] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 10Outreachy (Round-13), and 2 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2718451 (10Mattflaschen-WMF) [22:38:12] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 10Outreachy (Round-13), and 2 others: Create a notification based reminder system for improved user experience - https://phabricator.wikimedia.org/T148124#2715579 (10Mattflaschen-WMF) [22:52:45] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Notifications, 10MediaWiki-Internationalization, and 3 others: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2718487 (10Liuxinyu970226) [23:01:21] (03CR) 10Jforrester: [C: 032] Remove executable flags from PageTriage.hooks.php and Gemfile [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315724 (owner: 10Catrope) [23:01:28] (03CR) 10jenkins-bot: [V: 04-1] Remove executable flags from PageTriage.hooks.php and Gemfile [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315724 (owner: 10Catrope) [23:07:21] (03PS2) 10Catrope: Remove executable flags from PageTriage.hooks.php and Gemfile [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315724 [23:07:29] (03CR) 10Catrope: [C: 032] "Per James" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315724 (owner: 10Catrope) [23:08:21] (03Merged) 10jenkins-bot: Remove executable flags from PageTriage.hooks.php and Gemfile [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/315724 (owner: 10Catrope) [23:19:44] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2718534 (10Mattflaschen-WMF) [23:29:06] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2718546 (10Mattflaschen-WMF) We are considering this application. We encourage other interested applicants to... [23:36:18] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2718562 (10Mattflaschen-WMF) Thanks again for applying. I've merged {T148124} into here. Please make any f... [23:49:10] 06Collaboration-Team-Triage, 10Flow: Move a Flow board is not possible - https://phabricator.wikimedia.org/T147942#2718580 (10Mattflaschen-WMF) This is introduced by {f9b54ea8434a8c57f3db9fcb921b167ae85dbf1b}. Thinking about it now.