[00:00:04] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: "This topic has now been added to your watchlist" does not appear in Chrome - https://phabricator.wikimedia.org/T147038#2679028 (10Catrope) [00:05:10] RoanKattouw, any idea why I'm not seeing the error from https://ca.wikipedia.org/wiki/Usuari_Discussi%C3%B3:Zilant17 on fluorine. [00:05:24] I grepped through exception.log fatal.log hhvm.log, and apache2.log [00:05:29] I would expect to see it in exception.log [00:06:27] I tried to find it too [00:06:31] But it's an InvalidInputExceptoin [00:06:34] Those aren't loggable [00:06:47] Because they are usually thrown in response to invalid user input, and then caught and replaced with an error page [00:06:54] Oh, yeah, I remember that from before. [00:07:14] But apparently there is a code path somewhere where an InvalidInputException can occur due to something that's not user input [00:07:29] (Also Flow is the only thing that uses exceptions this way, nothing else in the MW ecosystem does AFAIK) [00:07:38] T134545 [00:07:40] T134545: Separate user input errors from other InvalidInputException, then make re-loggable - https://phabricator.wikimedia.org/T134545 [00:07:45] Right [00:07:52] Did not know about that task, but +1 to the headline [00:18:34] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2679050 (10Neil_P._Quinn_WMF) 05Open>03stalled [00:19:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2387098 (10Neil_P._Quinn_WMF) @dchen says she doesn't need this right now, so it goes on ice for the time being. [00:28:14] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2679069 (10Mattflaschen-WMF) @Sbisson's fix should prevent future cases.... [00:46:37] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2679102 (10jmatazzoni) @Samwalton9, we've now perfected our form for requests like this. See below. I started filli... [01:58:21] RoanKattouw, can I add https://gerrit.wikimedia.org/r/#/c/309226/2 and https://gerrit.wikimedia.org/r/#/c/309225/3 to your SWAT (pre-reqs for the Flow wikitech change). [01:58:24] ? [02:03:32] matt_flaschen: Sure [02:10:12] Thanks [02:11:34] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2679212 (10Mattflaschen-WMF) [02:12:07] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2054159 (10Mattflaschen-WMF) [02:17:27] Have a good night, see you tomorrow. [08:57:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2679391 (10Trizek-WMF) p:05Triage... [08:57:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Contact communities for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146972#2679393 (10Trizek-WMF) p:05Triage>... [09:44:58] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2679461 (10Trizek-WMF) >>! In T146333#26... [09:56:37] 06Collaboration-Team-Triage, 10Flow, 10Thanks: "Thank action failed (error code: invalidrecipient). Please try again." when trying to thank a bot - https://phabricator.wikimedia.org/T146883#2679472 (10Trizek-WMF) @SBisson, MassMessage has been think for classical talk pages. At that time, the important is to... [10:08:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Contact communities for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146972#2679473 (10Trizek-WMF) >>! In T146972... [10:12:08] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Flow: [betalabs-Regression] monospace font when wikitext option is selected - https://phabricator.wikimedia.org/T147032#2678561 (10Trizek-WMF) It is not a bug but a requested feature: {T116567}? [10:13:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2679482 (10Trizek-WMF) [10:14:00] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2679481 (10Trizek-WMF) [10:22:30] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Add an help icon and link to Special:RecentChanges dedicated to ERI's changes - https://phabricator.wikimedia.org/T147054#2679509 (10Trizek-WMF) [10:22:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Add an help icon and link to Special:RecentChanges dedicated to ERI's changes - https://phabricator.wikimedia.org/T147054#2679527 (10Trizek-WMF) [10:22:59] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) [10:25:36] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2679528 (10Trizek-WMF) [10:25:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2499199 (10Trizek-WMF) Added terms from {T145157} [10:53:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow: Remove in-process Memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#2679558 (10SBisson) Yes, we hope that is gong to be fixed at the same time as {T120009}, which is the one I'm wor... [12:05:08] (03CR) 10Aaron Schulz: "Maybe the data can be sent over AJAX using POST? Then it would go to the master DC, and merge() would be fast." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313148 (https://phabricator.wikimedia.org/T114841) (owner: 10Mooeypoo) [12:18:22] 06Collaboration-Team-Triage, 10Flow, 07Technical-Debt: Remove Flow index layer - https://phabricator.wikimedia.org/T147058#2679632 (10SBisson) [12:19:32] 03Collab-Team-Q1-July-Sep-2016, 10Flow: ToC only loads a total of 100 topics - https://phabricator.wikimedia.org/T118055#2679646 (10SBisson) a:05SBisson>03None Unfortunately, it's not the case. But it would be fixed by {T147058} [12:20:24] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Main topic list pagination can only paginate at most 500 topics (less sometimes, apparently due to moderation) - https://phabricator.wikimedia.org/T114456#2679651 (10SBisson) a:05SBisson>03None Unfortunately, it's not the case. But it would be fixed by {T147058} [12:55:20] (03CR) 10Sbisson: [C: 032] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [13:01:27] (03Merged) 10jenkins-bot: Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [14:05:14] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review, 07Regression, and 2 others: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2679943 (10Trizek-WMF) [14:06:51] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016), 07User-notice-collaboration: Publication of the Flow Satisfaction Survey results including an analysis and raw data - https://phabricator.wikimedia.org/T144730#2679945 (10Trizek-WMF) [14:07:11] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016), and 2 others: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2679946 (10Trizek-WMF) [14:10:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2679965 (10Trizek-WMF) [14:18:43] (03PS7) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [15:45:55] 06Collaboration-Team-Triage, 10Flow: ToC only loads a total of 100 topics - https://phabricator.wikimedia.org/T118055#2680235 (10jmatazzoni) [15:58:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2680251 (10jmatazzoni) [15:59:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2499199 (10jmatazzoni) [15:59:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2499199 (10jmatazzoni) [16:11:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2680269 (10jmatazzoni) @Trizek-WMF asks: > @jmatazzoni, have you defined terms or drafted... [16:34:31] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2680313 (10Trizek-WMF) Watching these daily changes, I understand it perfectly. I just want... [16:43:36] 06Collaboration-Team-Triage, 10Notifications: Echo doesn't link to the correct section if there are duplicate section headings - https://phabricator.wikimedia.org/T62396#2680317 (10matej_suchanek) [16:49:19] 06Collaboration-Team-Triage, 10Flow: Have a way to prevent edit conflits on flow - https://phabricator.wikimedia.org/T147080#2680324 (10Framawiki) [16:55:09] ^ Reviewing Aaron's doConversion patch (https://gerrit.wikimedia.org/r/308216) [16:59:21] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Flow: [betalabs-Regression] monospace font when wikitext option is selected - https://phabricator.wikimedia.org/T147032#2680356 (10Etonkovidova) Thx, @Trizek-WMF Two very small notes - on OSX the font for Edit Source defaults to OS specific fon... [16:59:54] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Flow: [betalabs-Regression] monospace font when wikitext option is selected - https://phabricator.wikimedia.org/T147032#2680360 (10Etonkovidova) 05Open>03Resolved [17:35:05] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2680437 (10Mattflaschen-WMF) >>! In T127792#2618122, @Catrope wrote: > For consistency I... [18:25:05] RoanKattouw, is there an equivalent to mw.language.convertNumber in PHP ? [18:25:40] mooeypoo: Do you need it for a message parameter? If so, use ->numParams() [18:25:52] gotcha [18:25:57] I'm reviewing a patch, just making sure [18:26:04] it *is* using numParams [18:26:07] Good [18:26:12] Then the conversion is handled automatically [18:26:46] +1 thanks [18:26:53] * mooeypoo shall +2, then [18:44:29] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: "This topic has now been added to your watchlist" does not appear in Chrome - https://phabricator.wikimedia.org/T147038#2680564 (10Catrope) [19:04:54] 06Collaboration-Team-Triage, 10Flow: Following a diff link to a post you don't have access to triggers fatal error - https://phabricator.wikimedia.org/T94863#2680614 (10Aklapper) @EBernhardson: Does this still happen or is this obsolete and this task should be closed? [19:18:37] 06Collaboration-Team-Triage, 10Flow: Following a diff link to a post you don't have access to triggers fatal error - https://phabricator.wikimedia.org/T94863#1174691 (10Etonkovidova) @Mattflaschen-WMF I just tried as anon user: with the link https://pt.wikipedia.org/w/index.php?title=T%C3%B3pico:Sb8y9cbwx18n... [19:22:36] 06Collaboration-Team-Triage, 10Flow: Have a way to prevent edit conflits on flow - https://phabricator.wikimedia.org/T147080#2680324 (10Etonkovidova) The similar issue was field {T139219}. [19:27:07] (03PS1) 10Kmuthu: [WIP] Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) [19:31:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [19:49:20] mooeypoo: kmuthu is here [19:50:34] mooeypoo: There is a bug in her patch, we figured out it's because of row/cell misnesting, she's got a fix for that locally but she hasn't pushed it yet [19:51:02] kmuthu, awesome work! I'm about to -1, but it's really small comments + a small visual adjustment that you should ask Roan and Joe to look at and see if I'm right or not (it's mostly opinion, so they're the authority on that) [19:51:08] (03CR) 10Mooeypoo: [C: 04-1] "Looks good! A couple of minor code comments." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [19:51:25] I commented on some minor code stuff too [19:51:43] What's the bug? I tested and nothing major stuck out? [19:51:52] You need to have a narrow window for it to break [19:51:54] oh... hovering [19:51:58] oooh [19:52:13] ok another issue... when it's affixed, hover over it (to click one of the buttons, for example) [19:52:17] it's jumping a bit for me [19:52:27] The text is not centered (this is because of the row/cell thing), and I think we need a rule that makes the fixed height greater when stuff goes below each other [19:52:30] Thanks mooeypoo [19:52:31] I think it is probably an issue of the ooui button adding some padding when hovered? [19:52:37] Hah, why would it do that... [19:52:55] RoanKattouw, only happens for the settings and pagination buttons [19:52:58] not for the filter buttons [19:53:11] I don't see it [19:53:17] But I don't have pagination buttons because I don't have enough notifications [19:53:18] RoanKattouw, chrome? [19:53:22] Yes Chrome [19:53:26] RoanKattouw, try the settings button [19:53:30] want me to share screens? [19:53:34] Things jumping on hover sounds very much like a Chrome browser bug [19:53:47] Lemme generate some more notifs so I get a pagination thing [19:53:49] hm [19:53:55] But it only happens on some of the buttons [19:54:00] mooeypoo: I shall take a look at your comments and make corrections accordingly. Thanks ! [19:54:02] And it doesn't happen to Flow bar [19:54:18] kmuthu, no problems! good job with it, I know it was a little mind bendy :) [19:54:37] RoanKattouw, kmuthu want me to share screens for a sec to show you the twitching/jumping bug? [19:55:21] also, RoanKattouw, chip in to my add-top/bottom-padding advice? It looks better to me, but it's completely a visual decision [19:55:43] Yeah it's a bit too far to the top now I think [19:55:51] mooeypoo: No problem, It was a good exercise. [19:56:01] a bit packed for me [19:56:01] I'll look in a second, first trying to repro the hover thing you mentioned [19:56:08] I'd add padding-top/bottom about 0.5em [19:56:31] RoanKattouw, ALSO, that fixes the jumping/twitching bug for me [19:56:35] so it must be a padding issue [19:56:52] kmuthu, ^ [19:57:21] pfft [19:57:33] Let's be honest, it's probably a Chrome bug [19:57:35] adding padding solves it. Weird, though [19:57:36] yeah [19:57:41] i'm verifying in firefox [19:57:50] still, if it solves it *and* looks better, we have a good solution [19:58:00] yeah it doesn't happen in firefox [19:58:07] Sure [19:58:22] weird, though [19:58:38] Also weird you can't reproduce [19:58:50] maybe it only happens if you have both pagination and settings button [19:59:56] RoanKattouw, YES. That's it. So... if you have only the settinsg button, things behave fine. If oyu have both settings AND pagination, (but no padding top/bottom) then you get a twitching behavior when you hover [20:00:11] I just set my pagination to display: none; and it stopped twitching [20:01:55] Also, yeah, I just saw the narrow-screen bug [20:02:19] RoanKattouw, I just thought of something... test this in mobile, please. We might have to undo the class for mobile? [20:02:29] I mean kmuthu, ^ [20:04:04] what the ... mobile frontend crashes for me in Special:Notifications now for unknown dependency "site" [20:04:09] Sure, will test it on mobile [20:04:51] kmuthu, it acts a bit weird on mobile frontend. You might need to adjust a little for small screens -- or, depending on what RoanKattouw and joe think, maybe not have it affixed in mobile at all. [20:05:40] what the hell mobile frontend... [20:06:36] jdlrobson, mobileFrontend crashes for me on Special:Notifications for dependency "site" -- but I can't figure out where that dependency is coming from... any idea? Has anything changed recently in mobile frontend? [20:06:42] I can't think of anything we changed, but... maybe? [20:07:20] mooeypoo: Have you updated everything properly? I think Timo was going to remove/rename that module or something [20:07:28] Lemme see what the mobile behavior is [20:07:33] RoanKattouw, yes... [20:07:35] I think [20:07:40] I'm on master in Echo and MobileFrontend [20:07:52] mooeypoo, kmuthu: In any case, I think the fixed height probably needs to be higher in the narrow-screen case because the two rows go below each other in that case [20:08:11] Yeah [20:08:31] That too. We need to think if we *want* it to be affixed at all in mobile, btw, since it's grabbing a large portion of the screen [20:08:44] we can make the event conditional on config variable and have mobile frontend set it to false or something [20:09:09] RoanKattouw, is mobile frontend not crashing for you? :\ [20:09:20] I can't repro the wiggle thing [20:09:22] Checking mobile now [20:09:31] RoanKattouw, even with both pagination and settings there? [20:09:42] Yup [20:09:46] Weird O.o [20:09:52] I can share screens later if you want to see it [20:09:56] pretty noticeable for me [20:10:25] In mobile it's all messed up but I think that's because of the fixed height problem that I mentioned [20:10:31] mooeypoo: Which version of Chrome? [20:10:35] so "site" dependency comes from "implicitDependencies" [20:10:42] I'm on 53 [20:10:45] RoanKattouw, mobile frontend is not crashing?! nothing in the console? [20:11:00] Version 53.0.2785.113 (64-bit) [20:11:09] what the hell [20:12:08] RoanKattouw, ok, now mobilefrontend is crashing for me for this dependency **everywhere** [20:12:11] not just special notifications [20:12:28] I either have a really temperamental devwiki, or something's wrong [20:12:38] ... I can believe the former [20:14:07] RoanKattouw, I just verified (and pulled again) mw-core. Still running into the 'site' module [20:14:31] Found it. [20:14:54] RoanKattouw, do you have any idea what timo renamed that module to? [20:14:59] I can't find a patch for that [20:15:22] and mobilefrontend has $modules['site'] = 'mobile.site'; in its getDefaultModules() for the Minerva skin [20:16:47] I don't see that error but let me update [20:17:17] hm. Weird, 'site' module appears everywhere. doesn't look like it was renamed. [20:17:36] OutputPage.php has it in $coreModules = [ ... 'site' ] [20:18:05] Right [20:18:09] But I know he did *something* [20:18:24] hm [20:18:39] Let's first see if you can reproduce this or if it's just me [20:44:39] (03CR) 10Mattflaschen: Fix import Converter::doConversion commit/lag check logic (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [20:46:46] (03PS8) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [21:04:58] (03CR) 10Mattflaschen: [C: 04-1] "I got P4140 in the browser (visiting the page) after converting a LQT page:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [21:43:19] (03PS2) 10Kmuthu: Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) [21:47:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2681220 (10Mattflaschen-WMF) Looks like a straightforward fix, if it's what I think. isNo... [21:48:15] (03CR) 10jenkins-bot: [V: 04-1] Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [21:53:33] (03PS3) 10Kmuthu: Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) [21:56:00] RoanKattouw, any luck reproducing mobile frontend bug? [21:56:28] Haven't tried yet. eating lunch now [21:56:45] RoanKattouw, also -- it's still jumping for me [21:56:49] :\ [21:56:55] super super weird [21:58:06] RoanKattouw, okay, I can't fully test kmuthu's fix in mobile, but I'm slightly concerned it may need adjustments there (or that we might want to not affix it, if it's taking too much space on a small screen) [21:58:07] (03CR) 10jenkins-bot: [V: 04-1] Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [22:01:53] She showed me and it looks fine [22:02:07] But possibly not affixing it is a good question [22:04:44] (03PS4) 10Kmuthu: Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) [22:04:53] (03CR) 10Mooeypoo: [C: 04-1] "Small comments inline." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [22:05:15] RoanKattouw, ok, good, I can't test because mobile frontend is crashing for me [22:05:20] RoanKattouw, the flickering is baffling. [22:05:29] It still flickers for me :\ and noticeably [22:09:20] (03CR) 10jenkins-bot: [V: 04-1] Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) (owner: 10Kmuthu) [22:17:42] kmuthu, btw, you can locally run (most) of the tests that jenkins is running [22:17:55] will save you sending the patch and waiting for jenkins to -1 [22:18:06] (mostly.. there are some tests that are hard to run locally) [22:19:04] kmuthu, install npm -> http://blog.teamtreehouse.com/install-node-js-npm-mac [22:19:51] Ah great !. Thank you ! [22:19:54] then in Echo folder, run "npm install" to get things set up, and then you could run "grunt" in the terminal, and it will run most of the tests jenkins runs so you can see if there are any style stuff jenkins complains about [22:21:04] Got it !. thanks ! [22:22:23] no problems! [22:29:35] 06Collaboration-Team-Triage, 10Flow: Adding/updating a topic summary does not add a topic to 'Recently active topics' - https://phabricator.wikimedia.org/T147106#2681268 (10Etonkovidova) [22:29:54] RoanKattouw, I could use a hand when you have a chance. [22:30:02] matt_flaschen: Sure, what's up? [22:30:17] I figured out T146437 and why Aaron's deferred update patch for Converter doesn't work. Same issue, there is a hack for bad before by the LQT API on certain normal 'not found' (e.g. end of the list) cases. [22:30:17] T146437: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437 [22:30:40] I can fix the hack easily, but we want to handle exceptions anyway, and this showed that with the deferred, it's not rolling back properly, causing corruption. [22:31:11] "bad before" = "bad behavior"? [22:31:30] Correct, sorry. [22:31:33] OK [22:32:02] Looking at Aaron's patch now [22:32:15] retrieveThreadData is throwing an exception, but for some reason it's not getting caught https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/includes/Import/Importer.php;85e6664caa9336b0fa3b243dd593f681caca43fe$622 where I'd expect. [22:32:41] Instead it bubbles up to DeferredUpdates::runUpdate and that triggers a partial rollback causing inconsistent state. [22:33:24] Where is retrieveThreadData called from? [22:33:40] (In the context of doConversion()) [22:34:10] Inside $this->importer->import [22:34:56] OK, so from within the deferred update [22:35:18] Yes, but it should get caught by us so not bubble up to the generic handling in runUpdate. [22:35:28] Right [22:35:39] Yeah it won't bubble up the way others will, because it gets executed much later [22:35:55] Why is the rollback botched? [22:36:04] Is it a bug in DeferredUpdate, or do we need to do additional handling? [22:37:52] RoanKattouw, I don't follow "it won't bubble up the way others will, because it gets executed much later" [22:38:06] It is executed later, but the exception-handling should still be inside what it's calling. [22:38:15] Oh, I see what you mean [22:38:24] You mean the exception should never bubble outside of import()? [22:39:25] RoanKattouw, right, we are catching Exception. See link above. [22:39:41] Hah , right [22:39:57] Except that ImportSourceStoreException is rethrown [22:40:05] line 595 [22:41:48] RoanKattouw, it's throwing ImportException, not that, will debug through again to confirm. [22:42:04] RoanKattouw, I'm not totally sure about the corruption, but I have a hypothesis. [22:42:21] From line 578 maybe? [22:42:41] 06Collaboration-Team-Triage, 10Flow: Have a way to prevent edit conflicts on flow - https://phabricator.wikimedia.org/T147080#2681295 (10Quiddity) [22:43:03] Re the corruption, even though Vagrant uses the same DB for both Flow and core, it is a separate connection, so we may need to explicitly commit the wiki DB. [22:44:00] ...OK [22:44:10] But wouldn't that also be an issue in the production setup where they're different DBS? [22:44:21] Or is something getting confused by the same DB / different conn situation? [22:44:34] No, I think you're right. That's also a bug. [22:44:43] RoanKattouw, do you want to do a screen share. I'll show you exactly what's happening AFAICT. [22:44:58] In prod as well [22:45:00] Sure, give me a minute [22:47:25] 06Collaboration-Team-Triage, 10Flow: Flow should either notify me or give live-updates, about new posts made in the topic I'm currently typing a reply in - https://phabricator.wikimedia.org/T94918#2681301 (10Quiddity) [22:47:27] 06Collaboration-Team-Triage, 10Flow: Have a way to prevent edit conflicts on flow - https://phabricator.wikimedia.org/T147080#2681303 (10Quiddity) [22:48:05] 06Collaboration-Team-Triage, 10Flow: Flow should either notify me or give live-updates, about new posts made in the topic I'm currently typing a reply in - https://phabricator.wikimedia.org/T94918#1175940 (10Quiddity) [22:56:57] RoanKattouw, okay, ping me when you're ready. [23:03:21] (03PS5) 10Kmuthu: Make notifications top toolbar controls sticky [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313613 (https://phabricator.wikimedia.org/T14096) [23:08:20] RoanKattouw, I see. It's because it's thrown by the getTopics iterator itself, not inside the try. [23:09:07] Whoa OK [23:09:12] That's not what I expected [23:09:49] Me neither. :) [23:10:45] I knew that was dynamic, but it didn't connect that it wasn't covered by the try. [23:27:32] 06Collaboration-Team-Triage, 10Flow, 10Thanks: "Thank action failed (error code: invalidrecipient). Please try again." when trying to thank a bot - https://phabricator.wikimedia.org/T146883#2681332 (10Quiddity) >>! In T146883#2677016, @SBisson wrote: > I've never used MassMessage but I found it strange that...