[00:09:18] (03PS1) 10Kmuthu: UsersLinkedToSpecificGroup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) [00:14:07] (03CR) 10jenkins-bot: [V: 04-1] UsersLinkedToSpecificGroup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) (owner: 10Kmuthu) [00:14:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add ORES good-faith scores to the ReviewStream feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144463#2661036 (10jmatazzoni) [00:14:37] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add ORES damaging scores to the ReviewStream feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2661037 (10jmatazzoni) [00:15:45] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add Experience Level calculations and flags, including for Newcomer, to the ReviewStream feed - https://phabricator.wikimedia.org/T145159#2661038 (10jmatazzoni) [00:16:50] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up the foundation for the ReviewStream feed - https://phabricator.wikimedia.org/T143743#2661051 (10jmatazzoni) [00:17:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Instrument ReviewStream feed to monitor usage - https://phabricator.wikimedia.org/T143721#2661052 (10jmatazzoni) [00:18:35] (03CR) 10Catrope: [C: 04-1] UsersLinkedToSpecificGroup (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) (owner: 10Kmuthu) [00:50:14] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: [mobile] Add cross-wiki notificaitons to Special:Notifications page - https://phabricator.wikimedia.org/T146409#2660048 (10Catrope) Probably a duplicate (ish?) of {T135877} ? [00:52:57] (03PS2) 10Kmuthu: UsersLinkedToSpecificGroup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) [00:57:43] (03CR) 10jenkins-bot: [V: 04-1] UsersLinkedToSpecificGroup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) (owner: 10Kmuthu) [01:00:29] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2661098 (10Mattflaschen-WMF) [01:00:49] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2661116 (10Mattflaschen-WMF) [01:00:53] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2661115 (10Mattflaschen-WMF) [01:01:15] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2661098 (10Mattflaschen-WMF) [01:01:18] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2321533 (10Mattflaschen-WMF) [01:01:45] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-LiquidThreads, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2661098 (10Mattflaschen-WMF) [01:01:47] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 07WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#2661119 (10Mattflaschen-WMF) [01:11:38] (03CR) 10Catrope: [C: 04-1] "Looks good, some minor nitpicks to the code, as well as to the commit message. Jenkins also has a few more complaints about coding style. " (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312436 (https://phabricator.wikimedia.org/T55860) (owner: 10Kmuthu) [01:55:43] 06Collaboration-Team-Triage, 10Notifications: Mention when corrected do not trigger notifications - https://phabricator.wikimedia.org/T146441#2661184 (10Etonkovidova) [01:56:46] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team: mention anomalies with certain diffs - https://phabricator.wikimedia.org/T143313#2563954 (10Etonkovidova) Checked in betalabs - for the second case >Edit the same talk page again and add a new section with almost identical content >but mention a diff... [02:02:32] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Mention when corrected do not trigger notifications - https://phabricator.wikimedia.org/T146441#2661206 (10Mattflaschen-WMF) [02:09:56] Heading out, have a good night. [08:26:58] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Mobile: [mobile] Add cross-wiki notificaitons to Special:Notifications page - https://phabricator.wikimedia.org/T146409#2661537 (10Aklapper) [08:27:11] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Mobile: [mobile] Add cross-wiki notifications to Special:Notifications page - https://phabricator.wikimedia.org/T146409#2660048 (10Aklapper) [14:12:00] 06Collaboration-Team-Triage, 10Flow, 07Regression: Flow: Interlanguage links are losing the :colon prefix when saved - https://phabricator.wikimedia.org/T63725#2662330 (10Aklapper) a:05Spage>03None [16:08:20] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 3 others: [regression-wmf.20] Flow: Topic/posts drop down menu options displayed in different colors - https://phabricator.wikimedia.org/T146401#2662652 (10Etonkovidova) Checked in 1.28.0-wmf.20 - testwiki, cawiki - f... [16:45:50] matt_flaschen: a question - why I see "Do not use this server!" upon ssh deployment-tin.eqiad.wmflabs. Smth was changed again? Or for my testing purposes it's ok to use it? [16:58:05] etonkovidova, no idea, will look after standup. [16:58:20] matt_flaschen: thx [17:40:28] 06Collaboration-Team-Triage, 10Notifications, 07Regression: [regression-betalabs] Notifications from deleted topic displayed on Special:Notifications page and in the notification panel - https://phabricator.wikimedia.org/T146328#2657555 (10SBisson) I just retested all the scenarios: (topic, post) x (delete,... [17:45:25] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow as a Beta feature in Greek Wikipedia (elwiki) - https://phabricator.wikimedia.org/T144384#2662865 (10Catrope) Scheduled for Monday October 3 18:00-19:00 UTC. Apologies... [18:27:36] 06Collaboration-Team-Triage, 10Notifications: Echo master query spam on HTTP GET - https://phabricator.wikimedia.org/T146492#2663066 (10aaron) [18:40:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Echo master query spam on HTTP GET - https://phabricator.wikimedia.org/T146492#2663136 (10Catrope) a:03Catrope Hmm yeah that probably needs a DeferredUpdate. On it. [18:53:27] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Echo master query spam on HTTP GET - https://phabricator.wikimedia.org/T146492#2663168 (10Catrope) Hmm, hold on, this should not be happening in master because we switched from db-replicated to mainstash. Is it OK to write to MainStash from a GET, or should that... [18:54:22] (03PS1) 10Catrope: Remove unused $flags parameter for EchoSeenTime::getTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312545 [18:57:23] (03CR) 10Aaron Schulz: [C: 032] Remove unused $flags parameter for EchoSeenTime::getTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312545 (owner: 10Catrope) [19:03:48] (03Merged) 10jenkins-bot: Remove unused $flags parameter for EchoSeenTime::getTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312545 (owner: 10Catrope) [19:06:57] 06Collaboration-Team-Triage, 10QuickSurveys: Should be possible to run page specific quicksurveys - https://phabricator.wikimedia.org/T146495#2663203 (10Jdlrobson) [19:07:58] 06Collaboration-Team-Triage, 10QuickSurveys: Should be possible to run page specific quicksurveys - https://phabricator.wikimedia.org/T146495#2663191 (10Jdlrobson) [19:12:52] (03PS1) 10Catrope: Defer cache write in EchoSeenTime::setTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312549 (https://phabricator.wikimedia.org/T146492) [19:14:11] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Echo master query spam on HTTP GET - https://phabricator.wikimedia.org/T146492#2663211 (10Catrope) >>! In T146492#2663168, @Catrope wrote: > Hmm, hold on, this should not be happening in master because we switched from db-replicated to main... [19:17:20] (03CR) 10Aaron Schulz: [C: 032] Defer cache write in EchoSeenTime::setTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312549 (https://phabricator.wikimedia.org/T146492) (owner: 10Catrope) [19:24:53] (03Merged) 10jenkins-bot: Defer cache write in EchoSeenTime::setTime() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312549 (https://phabricator.wikimedia.org/T146492) (owner: 10Catrope) [19:43:22] (03PS1) 10Mooeypoo: UnreadNotificationCounter should always normalize the count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 [20:24:00] (03CR) 10Sbisson: [C: 04-1] Add proper QUnit tests (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [20:25:17] (03CR) 10Catrope: [C: 04-1] "So how does this deal with:" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 (owner: 10Mooeypoo) [20:25:20] (03CR) 10Sbisson: [C: 04-1] UnreadNotificationCounter should always normalize the count (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 (owner: 10Mooeypoo) [20:28:14] (03PS2) 10Mooeypoo: UnreadNotificationCounter should always normalize the count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 [20:28:47] err git review didn't send the patch a couple of minutes ago when I asked it to.. I have to run for a little bit, I'll be back and work on this again ^ [20:31:07] (03CR) 10Catrope: [C: 04-1] "Per comments on PS1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 (owner: 10Mooeypoo) [20:51:21] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10QuickSurveys: Should be possible to run page specific quicksurveys - https://phabricator.wikimedia.org/T146495#2663351 (10jmatazzoni) [20:52:31] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10QuickSurveys: Retool quicksurveys so we can do a survey on one page only - https://phabricator.wikimedia.org/T146495#2663191 (10jmatazzoni) [20:53:31] ^ etonk_lunch, checked with hashar, use deployment-mira.eqiad.wmflabs . [20:54:21] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10QuickSurveys: Retool quicksurveys so we can do a survey on one page only - https://phabricator.wikimedia.org/T146495#2663191 (10jmatazzoni) @Catrope, please see @Jdlrobson's suggestion for how to rework Quicksurveys. It currently works on all pag... [20:59:22] matt_flaschen: thx! such a nice name - mira :) [21:02:10] etonkovidova, yeah, it's a good name, since you should look at code before deploying it. ^ mooey|away [21:04:28] (03CR) 10jenkins-bot: [V: 04-1] UnreadNotificationCounter should always normalize the count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 (owner: 10Mooeypoo) [22:26:28] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Echo master query spam on HTTP GET - https://phabricator.wikimedia.org/T146492#2663563 (10Catrope) This patch won't stop the warnings in production until wmf.21 is deployed, but hopefully it did st... [22:39:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2663591 (10Catrope) Updated table: T1462... [23:02:00] (03PS18) 10Mooeypoo: Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [23:03:33] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10QuickSurveys: Retool quicksurveys so we can do a survey on one page only - https://phabricator.wikimedia.org/T146495#2663647 (10Catrope) This looks easy to do. Let's first figure out what QuickSurveys looks like and whether we want to use it. [23:06:01] (03CR) 10jenkins-bot: [V: 04-1] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [23:13:07] (03PS3) 10Mooeypoo: UnreadNotificationCounter should always normalize the count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 [23:17:15] hm, RoanKattouw, at this point, the counter underlying test makes no sense, we're fixing it anyways. How do I delete that file from that commit again? [23:17:24] I'll rebase the upper commit onto master so it's standalone [23:17:37] RoanKattouw, with the entire test file... [23:23:05] (03PS4) 10Mooeypoo: UnreadNotificationCounter should always normalize the count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312552 [23:26:48] (03PS19) 10Mooeypoo: Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [23:26:52] There we go. [23:30:00] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2663704 (10jmatazzoni) [[https://docs.go...