[00:05:46] (03Merged) 10jenkins-bot: jsduck: Remove custom @source tag [extensions/Flow] - 10https://gerrit.wikimedia.org/r/311876 (owner: 10Krinkle) [00:10:51] (03Merged) 10jenkins-bot: jsduck: Remove custom @source tag [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311875 (owner: 10Krinkle) [00:15:02] (03PS2) 10Mattflaschen: Improve JSDuck [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311866 [00:15:42] (03CR) 10Mattflaschen: Improve JSDuck (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311866 (owner: 10Mattflaschen) [00:15:58] (03PS6) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) [00:17:21] (03CR) 10jenkins-bot: [V: 04-1] Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [00:23:03] (03PS1) 10Mattflaschen: Fix check for content text, so falsy values (e.g. the string '0') do not prevent metadata generation. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 [00:25:19] (03PS2) 10Mattflaschen: Fix check for content text [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 [00:26:06] (03CR) 10Mattflaschen: "Related: T145833" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [00:27:29] (03CR) 10Mattflaschen: Drop calls to WikiPage->getText (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [00:30:43] (03PS7) 10Mattflaschen: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) [00:55:30] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, and 2 others: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596519 (10Jdforrester-WMF) I've added {T146233} to fix the root issue... [01:41:17] Going to break for dinner. [01:42:40] Actually, defer that for 15 minutes. [04:34:30] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: Notification icons are not ready for high-density displays (use SVG instead of PNG where supported) - https://phabricator.wikimedia.org/T55875#2654980 (10Mattflaschen-WMF) 05Open>03Resolved [04:34:48] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: Notification icons are not ready for high-density displays (use SVG instead of PNG where supported) - https://phabricator.wikimedia.org/T55875#565249 (10Mattflaschen-WMF) This was done, piece by piece. [04:41:56] 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Learn more" link for right change notifications should point to a page about the group - https://phabricator.wikimedia.org/T57339#2655005 (10Mattflaschen-WMF) @jmatazzoni Is this a change we want to make? It makes sense to me. An example of such a page... [04:42:39] 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Learn more" link for right change notifications should point to a page about the group - https://phabricator.wikimedia.org/T57339#2655008 (10Mattflaschen-WMF) [04:44:47] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Mobile: When not using MobileFrontend, Echo does not appear well on small screens, because it does not use responsive design - https://phabricator.wikimedia.org/T126106#2655009 (10SamanthaNguyen) Wrote an ugly hack to fix it, but surely's there anot... [04:45:17] 06Collaboration-Team-Triage, 10Notifications, 10Refreshed, 07Design, 07Mobile: When not using MobileFrontend, Echo does not appear well on small screens, because it does not use responsive design - https://phabricator.wikimedia.org/T126106#2655011 (10SamanthaNguyen) [04:48:20] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2655018 (10Mattflaschen-WMF) @jmatazzoni We need to decide whether to do this, {T57339}, or something else. [04:48:35] 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Learn more" link for right change notifications should point to a page about the group - https://phabricator.wikimedia.org/T57339#635597 (10Mattflaschen-WMF) Conflicts with {T55860}. [04:56:46] 06Collaboration-Team-Triage, 10Notifications, 10DBA, 07Schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2655039 (10Mattflaschen-WMF) 05Open>03declined [05:38:01] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface: Update zordius/lightncandy v0.89 - https://phabricator.wikimedia.org/T121947#2655082 (10Legoktm) [07:37:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2655237 (10Trizek-WMF) [07:37:42] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Research current "new user" definitions and consider whether we need a different name for the ERI “new user” flag - https://phabricator.wikimedia.org/T145157#2655236 (10Trizek-WMF) [10:51:16] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2655587 (10SBisson) Was the problem with page-linked specifically or do we want all local bundles to have... [11:14:30] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2655644 (10Pginer-WMF) I think there are two separate issues here: **Expand or provide a main action for... [11:35:02] hmm, seems linebreaking on https://en.wikipedia.org/wiki/Special:Notifications is broken [11:35:59] https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#No_line_wrap [12:58:47] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2655793 (10SBisson) [13:42:12] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2655893 (10SBisson) [13:48:18] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2655925 (10mobrovac) [PR #108](https://github.com/wikimedia/change-propagation/pull/108) for #changeprop separates the O... [13:50:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2655936 (10mobrovac) Next step would be to create the topic in question. Is the idea to have all new revisions in there... [13:50:41] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2655937 (10SBisson) [13:54:01] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2621800 (10SBisson) I propose to add the missing data to `mediawiki.revision-create` to make it available to `ReviewStream`. The alternative... [13:55:04] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2655940 (10SBisson) [14:30:23] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2656018 (10Halfak) Such a field wouldn't really make sense. Flagging is use-case dependent. Generally, we recommend... [14:33:55] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2656027 (10egalvezwmf) @Trizek-WMF Sorry - I'm not sure why... [14:36:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2656045 (10Trizek-WMF) OK, good. With 583 answers recorded,... [14:39:03] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016), 05Goal: Help to define next steps concerning Flow development, based on the Flow Satisfaction Survey - https://phabricator.wikimedia.org/T137796#2656051 (10Trizek-WMF) [14:39:06] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2656049 (10Trizek-WMF) 05Open>03Resolved [14:39:09] ^ Done! [14:42:10] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2656052 (10Trizek-WMF) a:03Trizek-WMF [14:46:45] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2656055 (10Trizek-WMF) p:05Triage>03High [14:47:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2656056 (10Trizek-WMF) [15:24:58] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2656156 (10jmatazzoni) @SBisson edited the task. Thanks. Just so everyone is clear, there is a [[ https://docs.google.co... [15:41:51] 06Collaboration-Team-Triage, 10Notifications: [mobile-minor] Special:Notifications: Improve date format display - https://phabricator.wikimedia.org/T146288#2656218 (10Etonkovidova) [16:00:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10ORES: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#2656314 (10Etonkovidova) [16:05:16] matt_flaschen: I cannot remember - are we ok with the case when I have a link to a deleted topic like https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:T3em7a1nvzeo0yl4&action=history [16:05:50] matt_flaschen: I still can see that topic and its history if I have certain user rights. Is it fine? [16:15:10] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2656347 (10SBisson) [16:50:44] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2656487 (10Trizek-WMF) >>! In T143743#2656156, @jmatazzoni wrote: > Just so everyone is clear, there is a [[ https://doc... [16:51:03] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2656488 (10He7d3r) Just to confirm: is it supposed to be in this state right now? https://pt.wikibooks.org/w/index.php?titl... [16:52:34] 06Collaboration-Team-Triage, 10Notifications: Make a way for editors to have notifications automatically marked as read, when a flyout is opened - https://phabricator.wikimedia.org/T146294#2656491 (10Quiddity) [16:57:20] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2656530 (10Quiddity) >>! In T55860#2655018, @Mattflaschen-WMF wrote: > @jmatazzoni We need to decide whether to do this, {T57339}, or so... [16:57:57] 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Learn more" link for right change notifications should point to a page about the group - https://phabricator.wikimedia.org/T57339#2656532 (10Quiddity) >>! In T57339#2655021, @Mattflaschen-WMF wrote: > Conflicts with {T55860}. I think we should do the ot... [17:02:21] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Overlapping messages in the notifications flyout in non-English languages - https://phabricator.wikimedia.org/T108270#2656539 (10Quiddity) 05Open>03Invalid No longer reproducible, as far as i can tell. [17:14:52] legoktm, can you remind me what the gadget was called that added popups with diffs to links? [17:16:24] mooeypoo, https://en.wikipedia.org/wiki/Wikipedia:Tools/Navigation_popups [17:16:26] 06Collaboration-Team-Triage, 10Notifications: Add hooks (back) to Echo - https://phabricator.wikimedia.org/T146296#2656603 (10Mattflaschen-WMF) [17:16:32] quiddity, +1 thanks [17:16:50] 06Collaboration-Team-Triage, 10Notifications: Add hooks (back) to Echo - https://phabricator.wikimedia.org/T146296#2656616 (10Mattflaschen-WMF) [17:16:51] mooeypoo, and it doesn't seem to be working with Echo panel, at the moment. [17:16:56] quiddity, just found it too, looking at its code, the hook wouldn't have helped anyways, we'd need to edit the script itself [17:17:01] nod [17:17:02] yeah it's looking for old structure [17:17:12] mw.hook( 'ext.echo.overlay.beforeShowingOverlay' ).add( function($overlay){ [17:17:12] dynamicContentHandler( $overlay.find(".mw-echo-state") ); [17:17:12] }); [17:17:32] ^^ the above hook used to be emitted (not anymore for some reason) but regardless, mw-echo-state is no longer what it should look for [17:18:09] 06Collaboration-Team-Triage, 10Notifications: Add hooks (back) to Echo - https://phabricator.wikimedia.org/T146296#2656630 (10Quiddity) [17:19:15] quiddity, can you add a quick task to add a hook to echo popup/flyout ? I think part of it, at least, is simple enough for me to do it in a few minutes after I help kmuthu with vagrant -- and we can kill two birds with one stone by getting the gaget to work again *and* have a hook users can use [17:19:47] sure thin [17:19:48] g [17:19:52] much obliged [17:20:22] mooeypoo, oh, is that not covered by matt's task? (maybe you have wikibugs muted?) https://phabricator.wikimedia.org/T146296 [17:36:24] 06Collaboration-Team-Triage, 10Notifications: Add hooks (back) to Echo - https://phabricator.wikimedia.org/T146296#2656705 (10Mooeypoo) Is beforeShowingOverlay supposed to be just before we render the notifications? Looking at a gadget that expects it (https://en.wikipedia.org/wiki/MediaWiki:Gadget-popups.js)... [17:37:27] quiddity, https://quarry.wmflabs.org/query/12679 . You could request that someone loop through and check all the wikis. [17:38:22] I've got a half-written phab task. Will add that link. Thanks. :) [17:45:11] stephanebisson, update from Scrum of Scrums. Kasocki prototype is finalized, but Andrew Otto is looking into alternatives to WebSockets. [17:45:37] "Considering using server side events / streaming instead of web-sockets" [17:46:53] matt_flaschen: interesting... do you know if there's a task I can follow? [17:51:15] stephanebisson, Petr didn't have it handy, so pointed me to the general task: https://phabricator.wikimedia.org/T145095 . [17:56:08] etonkovidova, re "link to a deleted topic", if you have the appropriate rights (e.g. deletedtext), generally if you're an admin. If not, you should be able to see the title of deleted topic, but not the content. [18:00:38] matt_flaschen: thx! yes, something like that ... I was trying to see if there is a way for non-admin to get to the history of a deleted topic. But it seems safe enough [18:09:03] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2656854 (10dr0ptp4kt) > @dr0ptp4kt would someone from the reading team be willing to be a primary mentor for th... [18:55:19] matt_flaschen stephanebisson , re: disambiguator - in case you wanted to CC: https://phabricator.wikimedia.org/T146310 [19:03:22] thedj: Yes, we identified that too, but deployments are on hold for the next few days, so even though I know what fixes it I can't deploy it [19:03:31] It's fixed in wmf.19 but we were held back at wmf.18 [19:11:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 07Documentation, 05Goal: Create and maintain Edit Review Improvements documentation - https://phabricator.wikimedia.org/T145875#2657088 (10jmatazzoni) [19:13:17] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-PageCuration, 10WikiLove, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Fix PageTriage->WikiLove dependencies - https://phabricator.wikimedia.org/T145798#2657091 (10jmatazzoni) [19:16:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 06TCB-Team, 03WMDE-QWERTY-Team-Experimental-Sprint, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2657097 (10jmatazzoni) [19:17:41] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Easy: PageCuration toolbar asks for a URL when an internal wikilink is needed instead - https://phabricator.wikimedia.org/T118264#2657104 (10Swpb) p:05Triage>03Normal [19:18:01] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2657108 (10Catrope) a:03KMuthu [19:27:41] (03CR) 10Jforrester: [C: 032] Remove deprecated API help methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/311836 (owner: 10Anomie) [19:28:23] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2657129 (10matej_suchanek) [19:38:09] (03Merged) 10jenkins-bot: Remove deprecated API help methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/311836 (owner: 10Anomie) [19:44:13] matt_flaschen: thx! yes, something like that ... I was trying to see if there is a way for non-admin to get to the history of a deleted topic. But it seems safe enough [20:26:10] hey mooeypoo notifications overlay broken on mobile sit [20:26:26] it's preventing anything from merging right now. Are you aware of this problem ? Do you need me to raise a bug? [20:26:41] It's a TypeError: Cannot read property 'bind' of undefined [20:28:29] 06Collaboration-Team-Triage, 10Notifications: Notifications for user rights changes - tweaks needed - https://phabricator.wikimedia.org/T146321#2657349 (10Quiddity) [20:29:43] 06Collaboration-Team-Triage, 10Notifications: Wikilinks in rights change message (HTML) doesn't get proper links - https://phabricator.wikimedia.org/T141521#2657366 (10Quiddity) [20:29:45] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Watchlist: Misleading email notification on user rights change - https://phabricator.wikimedia.org/T106739#2657367 (10Quiddity) [20:29:47] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Easy: User rights change notification email does not specify in body which account was affected - https://phabricator.wikimedia.org/T71981#2657368 (10Quiddity) [20:29:49] 06Collaboration-Team-Triage, 10Notifications: Echo: User rights change notifications aren't particularly clear - https://phabricator.wikimedia.org/T67659#2657369 (10Quiddity) [20:29:51] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2657371 (10Quiddity) [20:29:53] 06Collaboration-Team-Triage, 10Notifications: Notifications for user rights changes - tweaks needed - https://phabricator.wikimedia.org/T146321#2657365 (10Quiddity) [20:29:55] 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Learn more" link for right change notifications should point to a page about the group - https://phabricator.wikimedia.org/T57339#2657370 (10Quiddity) [20:32:03] (03PS1) 10Jdlrobson: Revert "Convert 'seenTime' to a global property" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312105 [20:32:38] ^ cc RoanKattouw [20:36:57] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657417 (10Jdlrobson) [20:37:17] (03PS2) 10Jdlrobson: Revert "Convert 'seenTime' to a global property" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312105 (https://phabricator.wikimedia.org/T146324) [20:37:28] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657435 (10Jdlrobson) p:05Triage>03Unbreak! [20:37:36] ^ raised here [20:43:07] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657417 (10MBinder_WMF) @Jdlrobson Should this be in the sprint? #mobilefrontend + #patch-for-review + your patch :) [20:46:24] (03PS13) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [20:48:20] jdlrobson, I'm testing now [20:48:24] jdlrobson, I think I got it [20:50:08] (03PS1) 10Mattflaschen: speedy deletion-previously deleted takes a page name, not a URL [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/312108 (https://phabricator.wikimedia.org/T118264) [20:50:17] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Easy, 13Patch-For-Review: PageCuration toolbar asks for a URL when an internal wikilink is needed instead - https://phabricator.wikimedia.org/T118264#2657481 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [20:51:35] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [20:51:35] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657417 (10Mooeypoo) Dealing with this right now. There's a small change we forgot to make when fixing global seen time - I'm submitting now.... [20:52:25] jdlrobson, sincere apologies about this :\ https://gerrit.wikimedia.org/r/#/c/312112/ <-- this fixes the bug [20:52:59] I grepped for 'updateLocalSeenTime' but I think I missed the MobileFrontend instance ... [20:53:01] mooeypoo: no problem! Just glad our browser tests caught it again. What do you think about running some MobileFrontend tests in Echo to avoid this in future? [20:53:16] jdlrobson, sounds good with me... not sure how to do that, though? [20:53:55] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657499 (10Mooeypoo) a:03Mooeypoo [20:53:57] I can have a chat with release engineering and see what's possible. I'll ping you at some point :) [20:54:19] jdlrobson, yeah, that will be good [20:54:22] and thanks for the quick fix ... just waiting on Jenkins to be happy again :) [20:54:26] he's always grumpy ;-) [20:54:26] jdlrobson, yeah, I think there is some big group of extension tests certain extensions are part of. So even though Echo shouldn't depend on MF (the other way around), they can run together. Don't remember the details, though. Thanks. [20:54:58] jdlrobson, Jenkins has a right to be grumpy with me right now :P [20:55:00] mooeypoo, I generall use GitHub for that, like https://github.com/search?q=user%3Awikimedia+make-all-blobs&ref=searchresults&type=Code&utf8=%E2%9C%93 . [20:55:21] but yeah, I just tested and it works .. this was a very silly oversight on my part [20:55:33] matt_flaschen, ha! awesome, this will also catch extensions I don't have installed [20:56:35] Yeah, it's nice. I think I got it from Krinkle originally. [20:58:48] Krinkle should be a book. [20:59:44] jdlrobson, selenium passed! [21:03:11] stephanebisson: RoanKattouw I see notifications from deleted topics displayed in the Notification panel and on Special:Notifications page [21:03:37] stephanebisson: RoanKattouw but with topic titles masked with ******* [21:04:02] RoanKattouw: is it the fix that you did? Or it's another genuine regression? [21:05:58] 06Collaboration-Team-Triage, 10Notifications: Determine if multi-reverted edits still send notifications to all non-IP users who were reverted - https://phabricator.wikimedia.org/T146326#2657517 (10Quiddity) [21:14:08] 06Collaboration-Team-Triage, 10Notifications, 07Regression: [regression-betalabs] Notifications from deleted topic displayed on Special:Notifications page and in the notification panel - https://phabricator.wikimedia.org/T146328#2657555 (10Etonkovidova) [21:19:40] 06Collaboration-Team-Triage, 10Notifications, 07Regression: [regression-betalabs] Notifications from deleted topic displayed on Special:Notifications page and in the notification panel - https://phabricator.wikimedia.org/T146328#2657577 (10Etonkovidova) [21:33:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657619 (10Mooeypoo) Fixed for me locally and seems to be passing tests. Can you confirm this is fixed, @Jdlrobson ? Can we abandon the rev... [21:41:06] mooeypoo: I do not see right now any problems with Notification overlay on mobile - not in beta and not on production [21:41:38] mooeypoo: do they run their selenium tests in production or in betalabs? [21:43:56] mooeypoo: or everything was just fixed and already deployed? :) [21:44:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream: Research current "new user" definitions and consider whether we need a different name for the ERI “new user” flag - https://phabricator.wikimedia.org/T145157#2657649 (10jmatazzoni) @Pginer-WMF, wanted to make sure you saw my suggestion ab... [21:44:18] etonkovidova, you don't see it in beta because I fixed it \o/ [21:44:35] etonkovidova, it wasn't in production - we merged seenTime (whcih broke MobileFrontend) yesterday, after the cut [21:44:38] the problem was in master [21:44:47] mooeypoo: ok then - good [21:44:57] so the issue was in master + beta, and we fixed it [21:45:11] Just wanted to make 100% sure it's fixed, but it seems to be [21:52:55] mooeypoo: yeah, their Selenium tests failed for another reason now - User link, but it's a false alarm. [22:07:45] " stephanebisson: RoanKattouw but with topic titles masked with *******" [22:07:52] Really? That seems weird to me. [22:08:09] matt_flaschen: to me too :) [22:16:06] 06Collaboration-Team-Triage, 10Notifications: Add hooks (back) to Echo - https://phabricator.wikimedia.org/T146296#2657684 (10Mattflaschen-WMF) >>! In T146296#2656705, @Mooeypoo wrote: > Is beforeShowingOverlay supposed to be just before we render the notifications? Looking at a gadget that expects it (https:/... [22:27:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146280#2657711 (10jmatazzoni) [22:28:36] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146280#2657716 (10jmatazzoni) I hope it's OK that... [22:29:16] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146280#2657717 (10jmatazzoni) [22:29:48] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2657719 (10Mattflaschen-WMF) This is a special case, because the user created the section directly on the page: https://pt.... [22:31:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream: Set a flag for “good-faith edits by new users” in ReviewStream - https://phabricator.wikimedia.org/T146331#2657722 (10jmatazzoni) [22:31:50] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-ReviewStream: Set a flag for “good-faith edits by new users” in ReviewStream - https://phabricator.wikimedia.org/T146331#2657754 (10jmatazzoni) [22:31:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146280#2657755 (10Halfak) I'd like to mark this ta... [22:34:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146280#2657760 (10Halfak) [22:34:55] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2655963 (10Halfak) [22:35:12] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657764 (10jmatazzoni) [22:35:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146334#2657779 (10Halfak) [22:36:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657764 (10jmatazzoni) @Halfak created thes... [22:37:50] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657810 (10jmatazzoni) [22:38:07] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657812 (10Halfak) [22:38:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146334#2657779 (10Halfak) [22:38:31] o/ jmatazzoni___ [22:38:38] Looks like we're stepping on eachother's toes. [22:38:46] I just merged into your re-created card. [22:38:56] hello. I created the other task if you want to close T146280 [22:38:56] T146280: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280 [22:39:28] We have a process for closing tasks like T146280 once per week. that'll happen soon./ [22:40:25] Wait, did you close the one I just created? The second one? I copied all my verbiage in there. I don't have the number. Can you please reopen i? [22:40:40] No. I didn't close it. [22:40:45] https://phabricator.wikimedia.org/T146333 [22:40:57] I merged my copy (https://phabricator.wikimedia.org/T146334) into it [22:41:19] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657830 (10jmatazzoni) [22:41:20] Generally, I think it's bad practice to take a task from the "done" column and re-scope it bigger. [22:42:34] T146333 is assigned to you. Do you want me to take it? Or do you want to keep it? [22:42:35] T146333: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333 [22:42:53] jmatazzoni___, not sure when I can pick this up. [22:43:10] I meant to take it anyway. No problem. [22:43:12] My usual process is to leave things in the backlog until I (or someone on my team) is ready to focus on it. [22:43:16] OK [22:43:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657833 (10jmatazzoni) a:05Halfak>03j... [22:45:24] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657764 (10jmatazzoni) [22:46:30] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2657843 (10jmatazzoni) [22:46:32] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2657842 (10jmatazzoni) [22:48:37] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Notifications, 10MassMessage, and 2 others: MassMessage notifies you when posting specifically to Flow boards - https://phabricator.wikimedia.org/T86812#2657846 (10Etonkovidova) Checked in betalabs - no extra notificaitons (self-mention notifications as described i... [22:49:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page: Add ORES good-faith and damaging scoring display and new user flag to RC Page - https://phabricator.wikimedia.org/T144451#2657848 (10jmatazzoni) [23:07:16] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Unable to view notifications in Echo - https://phabricator.wikimedia.org/T146324#2657417 (10Etonkovidova) Checked in betalabs mobile - the Notification overlay has no problem w... [23:09:02] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#2657882 (10Mooeypoo) [23:23:52] (03CR) 10Mooeypoo: [C: 04-2] "There's no need to revert anymore; the problem was fixed in Ib941af5c6964cdf300b22" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/312105 (https://phabricator.wikimedia.org/T146324) (owner: 10Jdlrobson) [23:24:39] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2657896 (10jmatazzoni) The spec for this feed is that it would include everything that was in RCStream. @SBisson changed... [23:29:43] 06Collaboration-Team-Triage: [production] On the first sign-up, cross-wiki notificaitons expands to blank placeholder - https://phabricator.wikimedia.org/T137476#2369321 (10Catrope) Does this still happen? [23:33:45] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-ReviewStream, 10ChangeProp, 10EventBus, and 2 others: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2577484 (10Pchelolo) Since we're going to base it on the `revision-create` event, here's the schema of the event: https:... [23:38:36] 06Collaboration-Team-Triage, 10Notifications, 07WorkType-NewFunctionality: Notification state in output HTML is cached excessively - https://phabricator.wikimedia.org/T109997#2657912 (10Catrope) 05Open>03Resolved a:03Catrope This should be fixed by {e1a276fe} [23:43:17] 06Collaboration-Team-Triage: [production] On the first sign-up, cross-wiki notificaitons expands to blank placeholder - https://phabricator.wikimedia.org/T137476#2657916 (10Etonkovidova) Checked in `1.28.0-wmf.18` (and wmf.20 in test) - the issue is not present anymore. Closed as Resolved. [23:43:32] 06Collaboration-Team-Triage: [production] On the first sign-up, cross-wiki notificaitons expands to blank placeholder - https://phabricator.wikimedia.org/T137476#2657923 (10Etonkovidova) 05Open>03Resolved [23:43:37] 06Collaboration-Team-Triage, 10Flow, 07WorkType-Maintenance: Not possible to moderate a resolved topic without reopening - https://phabricator.wikimedia.org/T115209#2657928 (10Catrope) [23:43:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Resolved topics should be able to be deleted or suppressed without reopening them first - https://phabricator.wikimedia.org/T142779#2657926 (10Catrope) [23:53:44] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2657944 (10Catrope) [23:53:46] 06Collaboration-Team-Triage, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2657945 (10Catrope) [23:53:51] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2604569 (10Catrope) [23:53:53] 06Collaboration-Team-Triage, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1993582 (10Catrope) [23:54:09] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OATHAuth: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788#2657948 (10Catrope) [23:54:11] 06Collaboration-Team-Triage, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1993582 (10Catrope) [23:55:20] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07User-notice, and 3 others: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2657951 (10Etonkovidova) Checked in betalabs the following steps - a user has new notifications in wiki A (... [23:55:50] (03PS14) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [23:59:26] 06Collaboration-Team-Triage, 10Notifications: PHP Strict Standards: Declaration of ApiEchoUnreadNotificationPages::getFromForeign should be compatible - https://phabricator.wikimedia.org/T139720#2657957 (10Catrope) 05Open>03Resolved a:03Catrope [23:59:57] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo)