[01:58:56] (03PS1) 10Tjlsangria: Specify which revision was thanked in Special:Log/thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/311364 (https://phabricator.wikimedia.org/T51087) [04:56:41] (03CR) 10Catrope: [C: 04-1] Remove primary link from the bundle of page linked notification (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) (owner: 10Mooeypoo) [04:58:55] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2644666 (10Catrope) @Mooeypoo Can you describe the product decision that needs to be made (that you -2ed the patch for) and ping jmatazzoni in your r... [05:02:38] (03CR) 10Catrope: [C: 032] Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [05:09:14] (03Merged) 10jenkins-bot: Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [07:25:19] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642269 (10Catrope) I think you need `array_values( array_filter( $arr ) )`. If you have, say, `$a = array( 0 => 'foo', 1 => null, 2 => 'bar... [07:26:50] (03CR) 10Catrope: "We can use mw.log.warm(), that'll write to the console but not to the server. Sending this to the server is probably overkill." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) (owner: 10Mooeypoo) [07:44:22] (03CR) 10Catrope: [C: 04-1] "Looks good, minor nitpicks all around." (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [08:03:18] (03CR) 10Catrope: [C: 032] Count the number of success & failure notifs sent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310524 (owner: 10Addshore) [08:14:34] (03Merged) 10jenkins-bot: Count the number of success & failure notifs sent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310524 (owner: 10Addshore) [08:37:47] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2647563 (10Addshore) 05Open>03Resolved a:03Addshore Closing due to the large explanations of things above. If anyone has any other queries fee... [08:58:32] (03CR) 10Tobias Gritschacher: [C: 031] Move BetaFeatures class check to isBetaFeatureAvailable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309839 (owner: 10Addshore) [09:20:45] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Help to define next steps concerning Flow development, based on the Flow Satisfaction Survey - https://phabricator.wikimedia.org/T137796#2647716 (10Qgil) [09:24:53] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016), 05Goal: Help to define next steps concerning Flow development, based on the Flow Satisfaction Survey - https://phabricator.wikimedia.org/T137796#2647721 (10Qgil) [13:01:47] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2648006 (10Mvolz) [13:02:40] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#31795 (10Mvolz) Is two co-mentors sufficient? :D Can this be put in featured column? [13:54:16] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2648262 (10Sumit) >>! In T2582#2648006, @Mvolz wrote: > Is two co-mentors sufficient? :D Can this be put in fea... [14:04:00] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2648298 (10Mvolz) Haha, not me, no idea how notifications work :D [16:03:39] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2648798 (10Qgil) [16:04:00] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1932012 (10Qgil) [16:05:09] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1932012 (10Qgil) [16:05:11] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2648809 (10Qgil) [16:05:26] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1648523 (10Qgil) [16:05:28] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1932012 (10Qgil) [16:14:21] I'm getting "More notices from another wiki" "MediaWiki" on the English Wikipedia [16:14:32] When I expand the list there, it shows no notifications [16:48:01] (03Abandoned) 10WMDE-leszek: Re-add actions to Thanks links when a diff on the diff page changes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/307317 (https://phabricator.wikimedia.org/T142636) (owner: 10WMDE-leszek) [17:13:41] reposting for a dev to answer later (ping matt_flaschen): quiddity: Hey, sorry for bothering you! I was wondering if PageTriage had any API functionality? I'm looking to get the stats (number of pages to review etc) [17:23:58] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2649248 (10Trizek-WMF) [17:27:54] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18), 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2649279 (10Jdlrobson) [17:59:30] (03CR) 10Kaldari: "@ori, @Krinkle: This change broke at least 2 images:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/272142 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [18:02:55] (03CR) 10Kaldari: "Here are some more images it broke:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/272142 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [18:04:25] (03PS1) 10Kaldari: Revert "Compress PNGs with zopflipng" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311475 [18:04:32] (03CR) 10jenkins-bot: [V: 04-1] Revert "Compress PNGs with zopflipng" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311475 (owner: 10Kaldari) [18:09:52] (03PS2) 10Kaldari: Revert "Compress PNGs with zopflipng" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311475 [18:11:28] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2649567 (10Mooeypoo) >>! In T2582#2648262, @Sumit wrote: >>>! In T2582#2648006, @Mvolz wrote: >> Is two co-ment... [18:14:42] (03CR) 10Catrope: [C: 032] Revert "Compress PNGs with zopflipng" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311475 (owner: 10Kaldari) [18:17:39] (03Merged) 10jenkins-bot: Revert "Compress PNGs with zopflipng" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311475 (owner: 10Kaldari) [18:39:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2649786 (10Sumit) @Mooeypoo thanks a bunch! Moving to featured. It'd be great if you could add one or two relev... [18:40:28] matt_flaschen: https://gerrit.wikimedia.org/r/#/c/311162/1 [18:52:03] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2649879 (10Trizek-WMF) >>! In T125632#2643759, @egalvezwmf... [18:52:12] (03CR) 10Catrope: [C: 04-1] "I'm highly skeptical of this whole "automagic discovery of test files based on test_ prefix and module name" thing. Why don't we just list" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [18:54:09] RoanKattouw: can you think of any other test framework that requires manually listing out every individual test? manual listing is error prone and people tend to forget to update the registry. Ideally we'd move the autodiscovery stuff into core so everything could use it (like we did with phpunit) [18:56:53] Hmm, fair enough [18:57:06] I guess automagic discovery of test files based on a directory or something is OK [18:57:23] But requiring that they be shaped like test_foo.js where foo must be an existing module name is confusing [18:57:41] It means we end up with tests that silently don't run [18:58:00] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2649888 (10Keegan) [19:01:08] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Make sure filter settings for RC Page are bookmarkable - https://phabricator.wikimedia.org/T146076#2649902 (10jmatazzoni) [19:01:32] (03CR) 10Catrope: "legoktm set me straight a bit and pointed out that automatic discovery of test files is good. However, I think that if we do that, we shou" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [19:03:14] yeah, I agree with that :) [19:09:58] (03CR) 10Catrope: [C: 04-1] "Looks good! A few small things inline" (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/311364 (https://phabricator.wikimedia.org/T51087) (owner: 10Tjlsangria) [19:23:18] stephanebisson: Could you review https://gerrit.wikimedia.org/r/#/c/311162/1 ? [19:23:30] sure [19:59:00] myrcx, https://en.wikipedia.org/w/api.php?action=help&modules=pagetriagestats should have what you need. Example: https://en.wikipedia.org/w/api.php?action=pagetriagestats&namespace=0 . If you want the actual pages, you can use https://en.wikipedia.org/w/api.php?action=help&modules=pagetriagelist . [20:01:54] matt_flaschen: I am looking into Special:MassMessage on betalabs - it doesn't seem to actually send messages. [20:02:23] matt_flaschen: do you recall how exactly it should work? [20:03:37] etonkovidova, user documentation is at https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:MassMessage . Which wiki and user are you testing with? [20:03:52] matt_flaschen: I tried several things - to list just one page, to have a page that has a list (links) of pages. I tried with wikitext, flow boards, and topic pages (permalink) [20:03:57] There is a log which helps track down failures, e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Special:Log/massmessage for enwiki Beta. [20:04:27] etonkovidova, which wiki and user. Do you get an error message, or does it claim the messages were sent, but they're not? [20:04:32] matt_flaschen: yes, on beta that logs lists duly that the messages were sent [20:04:42] https://en.wikipedia.beta.wmflabs.org/ ? [20:04:47] Or test wiki beta? [20:05:13] For Flow, it is supposed to be the board page. [20:05:22] ^ etonkovidova [20:05:36] matt_flaschen: well, I have contradicting info - enwiki betalabs informs me that the message was sent to 0 pages; Special:Log/massmessage lists the action was done [20:06:14] matt_flaschen: hmm... I will cautiously try it on testwiki [20:08:32] etonkovidova, okay, that means something is wrong with your target list. [20:08:44] matt_flaschen: and I am reading now Help:Extension:MassMessage which I should've done before asking, of course :) [20:09:15] etonkovidova, OK. The target list is the only slightly tricky part. If it still doesn't work after reading the docs and fixing that, let me know. [20:11:59] matt_flaschen: sure [20:32:03] matt_flaschen: ok, tested on enwiki in betalabs - MassMessage does not work for pages such as Topic:Tbg396osufys517v stating that: Delivery of "testing MassMessage4" to Topic:Tbg396osufys517v was skipped because target was in a namespace that cannot be posted in [20:32:40] etonkovidova, yeah, you should use the board page. [20:32:52] etonkovidova, does it work on board pages (and normal talk pages if you tested that)? [20:33:14] matt_flaschen: but it perfectly works on Flow boards - creating a new topic and posting a post - naturally, the notifications are sent. Which is what I was trying to prove. [20:34:03] Yeah, I think there is a bug about mentioning the sender in some cases, but other than that the notifications should be sent. Glad to hear it. [20:34:42] matt_flaschen: will try wikitext pages - mentioning a user via MassMessage should not send out notifications - will prove whether it's true or not [20:35:49] etonkovidova, mentioning the sender. Don't know about other users. [20:36:10] matt_flaschen: will see :) [20:37:10] etonkovidova, I mean I don't know what should happen for non-sender users. [20:37:33] Maybe they should get mentioned once or something, probably not on every page. [20:37:38] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Plan, write and submit a satisfaction survey concerning Flow to communities - https://phabricator.wikimedia.org/T125632#2650180 (10egalvezwmf) Do you have a way to send reminders?... [20:39:44] matt_flaschen: for wikitext pages the same log entry as for Flow topic pages - Delivery of "testing MassMessage6" to Mavetuna was skipped because target was in a namespace that cannot be posted in [20:40:21] matt_flaschen: no I wonder if it's a deliberate limitation for betalabs only... [20:42:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, and 2 others: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2650204 (10Neil_P._Quinn_WMF) @Mooeypoo, the strategy Analytics uses t... [20:43:34] etonkovidova, no, for this setting Beta is the same as production. It allows you to post in any talk page (User talk, Wikipedia talk, etc. etc.), and the projet namespace (e.g. Wikipedia:). Except Meta also allows the main namespace. [20:43:46] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 07Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#2650214 (10Volker_E) [20:43:55] etonkovidova, it wouldn't make sense to allow posting to the main namespace, since those are supposed to be more encyclopedia articles, not messages. [20:43:59] At least on enwiki where you're testing. [20:44:18] to be for [20:45:49] matt_flaschen: ok -then it's something that I need to sort out [20:47:05] etonkovidova, you can just post to any talk page when testing. [20:48:32] matt_flaschen: now I see - thx! [20:51:01] Hmm I think we have a performance problem with the ORES extension [20:51:08] https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&hidenondamaging=1 just took 41 seconds to load for me [20:51:17] That is to say, "wgBackendResponseTime":41541 [20:51:38] o/ RoanKattouw [20:51:44] That does seem extreme [20:51:54] I was going to poke at the SQL query anyway to make it suitable for goodfaith filtering [20:52:09] I would appreciate your assessment [20:53:36] Right now I'm wrestling with vagrant to get login to even work locally [20:54:45] 06Collaboration-Team-Triage, 10Flow, 10MassMessage: MassMessage sends notifications to message sender when that message is signed and posted on a Flow board - https://phabricator.wikimedia.org/T144754#2609132 (10Etonkovidova) Tested in betalabs: when a message via Special:MassMessage is posted on a Flow boar... [20:54:58] So I'm having trouble determining what the query is [20:55:43] $wgDebugToolbar = true;! [20:57:14] legoktm: Yes, but login needs to work in my vagrant first [20:57:20] I can't enable the ORES beta feature otherwise [20:57:35] heh [20:57:47] Exception handler threw an object exception: exception 'InvalidArgumentException' with message 'LBFactorySimple::newExternalLB: Unknown cluster "extension1"' in /vagrant/mediawiki/includes/libs/rdbms/lbfactory/LBFactorySimple.php:90 [20:57:52] ....WTF [20:59:36] matt_flaschen: Help? [21:00:33] Looking [21:01:18] RoanKattouw, that's weird, that cluster should exist. [21:02:27] I agree :) [21:03:37] I also do have $wgExternalServers['extension1'] = array( ... in my CommonSettings.php [21:04:54] RoanKattouw, what happens when you run: [21:04:57] mysql wikishared [21:05:42] I get to a database that has one table, which is echo_unread_wiks [21:06:01] Yeah, that's right. [21:06:39] RoanKattouw, looks like I need to git pull MW to break mine. [21:06:45] Then I can fix it. :) [21:07:02] MW core? [21:07:11] Yeah, I haven't pulled yet, so I don't have includes/libs/rdbms/lbfactory/LBFactorySimple.php . [21:07:21] OK, can you tell me which hash you're on? [21:07:28] Cause then I can roll back to it and have a working install [21:08:15] RoanKattouw, 00a79a4 . [21:09:39] matt_flaschen: OK that fixes it [21:09:43] I'll bisect [21:09:59] Okay, thanks, back to PageTriage. [21:11:40] matt_flaschen: Are you working on https://phabricator.wikimedia.org/T145891 ? [21:12:17] Hmm I guess it has a patch already, so it should be in Needs Review [21:13:42] RoanKattouw, no, I wasn't planning on doing T145891 now. I just did that commit so then my followup commit can show how the on-wiki templates change with my PageTriage factoring (I need a baseline) . And I tagged it since it's part of that task. [21:13:43] T145891: Import PageTriage dumps into MediaWiki-Vagrant - https://phabricator.wikimedia.org/T145891 [21:13:53] OK [21:16:50] (03PS3) 10Mooeypoo: Remove primary link from the bundle of page linked notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) [21:19:42] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2650421 (10Mooeypoo) @Catrope yes, the original task said to get rid of the primary link for bundled notification, and while that seemed to be the ge... [21:23:00] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2650437 (10Catrope) [21:23:03] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-WikimediaMaintenance, 13Patch-For-Review: Add Flow tables to createExtensionTables maintenance script - https://phabricator.wikimedia.org/T145160#2650435 (10Catrope) 05Open>03Resolved a:03Catrope [21:24:52] 06Collaboration-Team-Triage, 10Flow: When converting a page into a Flow board, take the whole section 0 instead of just the templates included into that section - https://phabricator.wikimedia.org/T145764#2640099 (10Quiddity) This would be the reverse of {T97733}. IIRC we decided on that, because having the t... [21:26:29] (03PS7) 10Mooeypoo: Convert 'seenTime' to a global property [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) [21:26:32] (03CR) 10Mooeypoo: Convert 'seenTime' to a global property (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [21:28:28] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MassMessage: MassMessage notifies you when posting specifically to Flow boards - https://phabricator.wikimedia.org/T86812#2650463 (10Quiddity) [21:28:30] 06Collaboration-Team-Triage, 10Flow, 10MassMessage: MassMessage sends notifications to message sender when that message is signed and posted on a Flow board - https://phabricator.wikimedia.org/T144754#2650465 (10Quiddity) [21:31:49] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Marking notifications about Flow topics/boards as read should also unbold them on Special:Watchlist - https://phabricator.wikimedia.org/T144179#2650476 (10Catrope) [21:32:27] (03CR) 10Mooeypoo: "> legoktm set me straight a bit and pointed out that automatic" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [21:33:00] (03PS7) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [21:33:56] (03CR) 10jenkins-bot: [V: 04-1] Convert 'seenTime' to a global property [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [21:36:16] matt_flaschen: Hmm WTF now that I'm doing this in incognito with master it doesn't break any more [21:36:35] nm I got it [21:36:49] Saving prefs fails [21:37:12] Or anything that hits echo_unread_wikis I assume. [21:37:25] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [21:37:38] (03PS8) 10Mooeypoo: Convert 'seenTime' to a global property [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) [21:37:47] matt_flaschen: Yeah but that's all behind cache [21:37:57] It looks like saveSettings() fails [21:37:59] Yeah [21:39:50] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 13Patch-For-Review: Update https://edit-analysis.wmflabs.org/beta-enables for Flow - https://phabricator.wikimedia.org/T144515#2650491 (10Catrope) 05Open>03Resolved [21:41:30] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2650501 (10Catrope) We should investigate if this still happens, and if so, why. I think it's very likely that @Addshore and fri... [21:42:43] meh, jshint [21:44:51] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MassMessage: MassMessage notifies you when posting specifically to Flow boards - https://phabricator.wikimedia.org/T86812#977084 (10Quiddity) Comments from merged task: >>! In T144754#2614164, @Trizek-WMF wrote: > On my way to distribute the survey ab... [21:47:21] (03PS8) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [21:51:35] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [21:58:17] 06Collaboration-Team-Triage, 10Notifications: Notify user when username mentioned on article text (Main namespace) - https://phabricator.wikimedia.org/T143665#2650624 (10Quiddity) @Rbirmann There's a new draft documentation page explaining how to create your own notification types, currently located at https:/... [22:15:12] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2549825 (10Quiddity) I'll put a detailed explanation in the description. [22:16:31] matt_flaschen: FYI Aaron ended up fixing the bug based on my bisect results https://gerrit.wikimedia.org/r/#/c/311612 [22:16:58] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2650667 (10Quiddity) [22:19:22] Good to hear [22:21:26] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2650689 (10Legoktm) How do we know if the user clicked thank from a history or diff view? We would need to basically encode the current URL in every... [22:27:59] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2650724 (10Addshore) [22:28:13] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team, 03WMDE-QWERTY-Team-Experimental-Sprint, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2589727 (10Addshore) [22:30:10] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Mention-Notification, 06TCB-Team, and 2 others: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2605228 (10Addshore) So I think this task can be closed. > usernames must have letters and cannot have dots A separate... [22:37:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2650743 (10Mooeypoo) Talking to @jmatazzoni and team - the consensus is to cancel the primary link (make the bundle just open on click) Removing th... [22:37:44] (03CR) 10Mooeypoo: "Product decision to continue with this patch as-is" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) (owner: 10Mooeypoo) [22:50:02] (03CR) 10Catrope: [C: 032] Remove primary link from the bundle of page linked notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) (owner: 10Mooeypoo) [22:52:14] (03CR) 10Catrope: [C: 031] "OK to merge once wmf.20 has been cut tomorrow" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [22:52:38] etonkovidova, I can't reproduce your statement at T144613 that "usernames must have letters and cannot have dots". Do you have an example of a a real user with dots that can't be mentioned? [22:52:39] T144613: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613 [22:53:01] matt_flaschen: just a sec - looking [22:54:43] (03PS2) 10Mooeypoo: Make sure bundledNotifications is an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) [22:57:22] matt_flaschen: sorry, I re-read it and it's confusing: what I meant - there are no usernames that resemble IP addresses [22:58:22] etonkovidova, yeah, I know that is a restriction. Can you just reply on the task to clarify? [22:58:32] matt_flaschen: I was trying to be extra cautious and make that no users were prevented from FlowMentioning just because their username is constructed as IP address [22:58:50] etonkovidova, numbers are also allowed, but it may not be allowed to be *only* numbers, and definitely isn't allowed if it looks like an IP.' [22:59:16] matt_flaschen: yes, yes -I will add clarification to my comment [22:59:17] (03Merged) 10jenkins-bot: Remove primary link from the bundle of page linked notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) (owner: 10Mooeypoo) [22:59:49] Thanks etonkovidova [23:08:21] (03PS3) 10Mooeypoo: Make sure bundledNotifications is an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) [23:08:58] (03PS9) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [23:09:08] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Mention-Notification, 06TCB-Team, and 2 others: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2650856 (10Etonkovidova) To clarify my comment >usernames must have letters and cannot have dots I was just checking the... [23:39:52] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [23:41:35] etonkovidova: I found it [23:41:37] etonkovidova: https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessage.hooks.php#L138 [23:41:47] etonkovidova: It checks for 'mention' but not 'flow-mention'; easy fix [23:45:39] flention. [23:47:10] RoanKattouw: thx [23:47:37] Now waiting on Vagrant to enable MassMessage on my laptop so I can test [23:48:25] wfLoadExtension('MassMessage') ;) [23:51:10] legoktm: vagrant enable-role massmessage; vagrant provision; wait an eternity [23:51:26] dunno, I stopped using vagrant a few months ago [23:51:59] include ::role::echo [23:51:59] include ::role::liquidthreads [23:52:19] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Notifications, 10MassMessage: MassMessage notifies you when posting specifically to Flow boards - https://phabricator.wikimedia.org/T86812#2651015 (10Catrope) [23:52:33] Echo is the giant one, LQT just pulls in WikiEditor and creates new db tables [23:53:12] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Notifications, 10MassMessage: MassMessage notifies you when posting specifically to Flow boards - https://phabricator.wikimedia.org/T86812#977084 (10Catrope) a:03Catrope >>! In T86812#2650538, @Quiddity wrote: >>>! In T144754#2630954, @Catrope wrote: >> Idea: per... [23:53:18] Yeah I have Echo + multi-wiki [23:53:26] I was lazy and didn't want to set up Apache etc [23:53:31] But OMG Vagrant is so incredibly slow [23:53:57] Also I have to manually stop the changeprop service, because it just hogs CPU constantly for no reason [23:54:09] (and I didn't even install it, it comes with restbase which is a requirement for visualeditor) [23:54:25] (But of course installing the visualeditor role doesn't install the restbase role, it just leaves your wiki in a broken state instead)