[00:02:09] mooeypoo, it was probably an empty array. Just wondering, could an expandable bundle have no bundledNotifications? Maybe due to moderation? [00:02:36] I have seen bugs where empty arrays are wrongly considered {} [00:02:55] Since PHP uses arrays for both dictionaries and arrays, the empty case is ambigous for JSON/JS> [00:03:22] hmmm [00:03:35] Maybe due to moderation, yeah [00:03:40] though that should be fixed if that's the case [00:03:57] and you're right, that fix should be checking things better; if we have no bundled info, it should skip that item [00:04:15] mooeypoo, I am going to try to fix it on the server-side so at least it will always be an array. [00:05:18] (03PS1) 10Mooeypoo: Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [00:05:31] (03PS2) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [00:05:32] I need to go, but I'll go over it tomorrow [00:06:04] matt_flaschen, perfect, that sounds good! regardless, it's probably a wise idea to double-check that it's an array in the front-end before running an array-specific method on it [00:06:09] so both fixes are probably a good idea [00:06:34] ok I gtg, I'll see you tomorrow! have a good night [00:06:35] mooeypoo, well, maybe. But we probably don't want to double-check everything is the right type. [00:06:40] mooeypoo, have a good night. [00:06:48] Can't reproduce yet. [00:07:06] matt_flaschen, no, but we don't usually run direct methods on them either [00:07:29] but yeah, we tend to not be that defensive, so you have a point [00:07:45] ok, gtg for real :) see ya! [00:10:08] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [00:18:23] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642488 (10Mattflaschen-WMF) I had a suspicion that it was something like {T12887}, which I've seen before (but I guess the reverse). But I... [02:36:38] Have a good night, see you tomorrow. [10:37:17] 10Collaboration-Team-Archive-2015-2016, 10Flow, 05MW-1.27-release-notes, 13Patch-For-Review: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#2643236 (10JenifferHomes) a:05Catrope>03None [11:17:21] 06Collaboration-Team-Triage, 10Flow: Reduce "Edit description" label visibility - https://phabricator.wikimedia.org/T145773#2643353 (10Trizek-WMF) [11:17:47] Is that task ^ a possible low-hanging fruit? [11:45:39] (03CR) 10Sbisson: "Yep, the local single notification path is the best option in this case." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) (owner: 10Mooeypoo) [11:48:03] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [11:48:51] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2643379 (10Trizek-WMF) There is not question more important that others, but the overall... [13:08:25] 06Collaboration-Team-Triage, 10Flow, 10SyntaxHighlight: Flow: syntax highlighting tags (GeSHi) don't get styled - https://phabricator.wikimedia.org/T59159#601816 (10PauloSincos) I'm having the same problema. All codes is not styled. In the log, nothing is printed. Any help? [14:23:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Documentation, 05Goal: Create and maintain Edit Review Improvements documentation - https://phabricator.wikimedia.org/T145875#2643710 (10Trizek-WMF) [14:24:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2643724 (10Trizek-WMF) [14:24:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Documentation, 05Goal: Create and maintain Edit Review Improvements documentation - https://phabricator.wikimedia.org/T145875#2643723 (10Trizek-WMF) [14:28:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2643731 (10Trizek-WMF) p:05Normal>03High I'm raising up the priority. We need that glossary before we start any discussion... [14:43:12] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2643759 (10egalvezwmf) If you want to do any cross tabs, You *may* need something closer... [16:36:57] (03PS2) 10Sbisson: Don't crash when a revision is not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) [17:21:35] (03Abandoned) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [17:27:17] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2644082 (10Catrope) This is producing res... [17:30:07] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2644110 (10Catrope) Random idea: what if... [17:34:42] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2644118 (10Mooeypoo) >>! In T144331#26441... [17:45:14] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2644152 (10Catrope) >>! In T144331#264411... [17:48:14] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2644156 (10Mooeypoo) >>! In T144331#26441... [17:52:56] 10Collaboration-Team-Archive-2015-2016, 10Flow, 05MW-1.27-release-notes, 13Patch-For-Review: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#2644183 (10Mattflaschen-WMF) a:03Catrope [17:53:23] 10Collaboration-Team-Archive-2015-2016, 10Flow, 05MW-1.27-release-notes, 13Patch-For-Review: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1755762 (10Mattflaschen-WMF) [18:00:17] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, except could you do ->error?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) (owner: 10Sbisson) [18:40:58] hmmm [18:41:53] I'm discovering a few small inconsistencies in our documentation by doing unit tests. I know... shocker. [18:42:19] Actually, I'm discovering logical inconsistencies, like "wait, what is this method *for* ??" [19:18:07] (03PS3) 10Sbisson: Don't crash when a revision is not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) [19:37:48] (03CR) 10Mattflaschen: [C: 032] Don't crash when a revision is not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) (owner: 10Sbisson) [19:41:35] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Vagrant: Import PageTriage dumps into MediaWiki-Vagrant - https://phabricator.wikimedia.org/T145891#2644379 (10Mattflaschen-WMF) [19:44:00] (03Merged) 10jenkins-bot: Don't crash when a revision is not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) (owner: 10Sbisson) [20:01:40] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016): Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2644418 (10Quiddity) p:05Triage>03High [20:06:04] yikes this.itemsPerPage = this.itemsPerPage || 25 [20:07:41] (03PS1) 10Mattflaschen: Import templates from English Wikipedia [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311178 (https://phabricator.wikimedia.org/T145891) [20:08:29] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Vagrant, 13Patch-For-Review: Import PageTriage dumps into MediaWiki-Vagrant - https://phabricator.wikimedia.org/T145891#2644428 (10Mattflaschen-WMF) [20:08:31] (03CR) 10jenkins-bot: [V: 04-1] Import templates from English Wikipedia [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311178 (https://phabricator.wikimedia.org/T145891) (owner: 10Mattflaschen) [20:08:55] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Vagrant, 13Patch-For-Review: Import PageTriage dumps into MediaWiki-Vagrant - https://phabricator.wikimedia.org/T145891#2644379 (10Mattflaschen-WMF) [20:09:35] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-PageCuration: Add Flow support to PageTriage using MessagePoster - https://phabricator.wikimedia.org/T85030#2644430 (10Mattflaschen-WMF) [20:11:38] mooeypoo, why is that yikes-y? [20:11:40] Also, could you review https://gerrit.wikimedia.org/r/#/c/310956/ when you have a chance. Without it, Jenkins fails on all PageTriage changes. [20:14:32] matt_flaschen, because it's suppposed to be this.itemsPerPage = config.itemsPerPage || 25 [20:14:48] it's in the constructor, didn't pass on config param... that's why :\ [20:16:17] matt_flaschen, logically speaking, shouldn't we register only if WikiLove exists, rather than unregistering if it doesn't? [20:16:26] I don't know how much of a mess it is to change it, but I'm just curious from the code [20:16:59] Ah, yeah [20:17:04] (about itemsPerPage) [20:17:31] if ( !ExtensionRegistry::getInstance()->isLoaded( 'WikiLove' ) ) { <-- talking about this here [20:18:02] matt_flaschen, also, I need to add PageTriage to vagrant to test; other than my question it looks good, though [20:18:48] mooeypoo, that's what I'm doing for the new one. The only thing I changed in the old one is the "is Wikilove installed" detection, since Reedy wanted isLoaded for the new one, and it would be weird if they didn't match. [20:18:50] mooeypoo, but I can change the old one if you want. [20:19:22] For onResourceLoaderRegisterModules I am just adding stuff if WL exists. [20:20:31] It's nto crucial, I saw you're doing "if it is installed" in the new one, but then the other one was "is it not installed" so it was just weird [20:20:44] but it seems it might be more complicated to do the other way on the old one, too [20:20:54] mooeypoo, not really, I just need to do a quick test. Fair enough. [20:21:33] (03Abandoned) 10Mattflaschen: Add notification_seen column to mark whether user saw that notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) (owner: 10Mattflaschen) [20:22:26] (03PS2) 10Mattflaschen: Import templates from English Wikipedia [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311178 (https://phabricator.wikimedia.org/T145891) [20:26:21] mooeypoo, the pre-existing code here is a bit silly anyway. Not only is this only enabled in one place in production (enwiki) where both are, it's even *hard-coded* to use an enwiki URL. Yet it's still conditional. [20:31:35] oy [20:31:39] yeah it's probably good to fix that, then [20:32:12] The "check if it isn't there" dependency logic makes me a bit twitchy in terms of logic of how optional dependencies should work [20:44:45] 06Collaboration-Team-Triage, 10Notifications: New link mail notification in Wikidata do not show link to item page - https://phabricator.wikimedia.org/T142332#2644510 (10Etonkovidova) Adding a screenshot of an email sample ( enabled "Daily summary of notificaitons" option) - the individual notificaitons do n... [20:45:56] (03PS3) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [20:50:06] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [21:04:45] (03PS1) 10Reedy: Convert PageTriage to extension registration [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311186 (https://phabricator.wikimedia.org/T87875) [21:05:52] (03CR) 10jenkins-bot: [V: 04-1] Convert PageTriage to extension registration [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311186 (https://phabricator.wikimedia.org/T87875) (owner: 10Reedy) [21:07:11] (03CR) 10Mattflaschen: "I'm in the middle of a few PageTriage changes right now (normally, no one is working on this extension). Can we hold off on this until T8" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311186 (https://phabricator.wikimedia.org/T87875) (owner: 10Reedy) [21:13:32] (03PS5) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) [21:15:23] (03PS2) 10Reedy: Convert PageTriage to extension registration [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311186 (https://phabricator.wikimedia.org/T87875) [21:15:26] (03PS1) 10Reedy: Move LoadExtensionSchemaUpdates to hooks file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311187 [21:16:19] (03CR) 10jenkins-bot: [V: 04-1] Move LoadExtensionSchemaUpdates to hooks file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311187 (owner: 10Reedy) [21:18:56] (03CR) 10Reedy: [C: 032] Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) (owner: 10Mattflaschen) [21:19:57] (03Merged) 10jenkins-bot: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) (owner: 10Mattflaschen) [21:22:09] (03PS2) 10Mattflaschen: Move LoadExtensionSchemaUpdates to hooks file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311187 (owner: 10Reedy) [21:37:30] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644625 (10Pine) @Lea_WMDE Thanks, that will certainly be better than having no ability for the user to test notifications. I s... [21:51:36] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644648 (10Addshore) Hi @Pine Mention notifications (regarding success and failures) are already deployed everywhere. Just take... [21:56:32] mooey|lunch, are you going to do the page-link one now, or should I file a bug? [22:00:34] matt_flaschen, can you file a bug? I am knee-deep in the current patch [22:00:45] I'll clean up and do it [22:01:17] (03PS4) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [22:02:09] Sure [22:03:25] feel free to assing me to it - I started running the notif script so I have a bunch of the linked page notifications for testing [22:03:28] takes forever, though [22:03:28] 06Collaboration-Team-Triage, 10Notifications: Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2644666 (10Mattflaschen-WMF) [22:03:38] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644680 (10Pine) @Addshore thanks. Unfortunately this feature isn't generating a failure notification when I attempt to ping my... [22:03:56] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Page link expandable bundle has a primary link - https://phabricator.wikimedia.org/T145902#2644681 (10Mattflaschen-WMF) [22:04:54] (03PS3) 10Mattflaschen: Import templates from English Wikipedia [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311178 (https://phabricator.wikimedia.org/T145891) [22:05:12] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [22:05:20] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2308308 (10Pine) Are the failure messages supposed to be working yet? None of these three diffs resulted in a failure message: https... [22:07:18] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644684 (10Addshore) @Pine these do not meet the criteria that is needed to class the edit as a 'failed mention'. In order to e... [22:07:57] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2308308 (10Addshore) I commented in T138080 but will cross post here... >>! In T138080#2644684, @Addshore wrote: > @Pine these do no... [22:09:08] (03CR) 10Mattflaschen: [C: 032] Move LoadExtensionSchemaUpdates to hooks file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311187 (owner: 10Reedy) [22:09:59] (03Merged) 10jenkins-bot: Move LoadExtensionSchemaUpdates to hooks file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311187 (owner: 10Reedy) [22:10:21] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644694 (10Pine) OK. Not notifying the user about the signature requirement seems like a significant omission to me, particular... [22:16:56] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2644726 (10Pine) Further thought for future feature development: 1. New users (emphasis on *new* users) could have these noti... [22:24:08] (03PS1) 10Mooeypoo: Remove primary link from the bundle of page linked notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) [22:25:30] (03PS4) 10Mattflaschen: Import templates from English Wikipedia [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311178 (https://phabricator.wikimedia.org/T145891) [22:26:56] matt_flaschen, I'm not getting *any* notifications for page linking in my local wiki... what am I missing [22:29:22] bah, it was untagged in the settings [22:29:25] unchecked [22:30:06] There goes all my effort into generating notifications :( [22:30:36] (03CR) 10Mooeypoo: [C: 04-2] "Holding off on this until product decision is made." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) (owner: 10Mooeypoo) [22:43:28] (03PS5) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [22:47:28] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [22:48:01] (03PS2) 10Mooeypoo: Remove primary link from the bundle of page linked notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311198 (https://phabricator.wikimedia.org/T145902) [22:48:22] matt_flaschen, you were right - the bundle didn't have "click anywhere triggers expand" - I think it's becuse we mostly don't have bundles that don't have a primary link [22:48:40] but this patch will do both - and if we decide not to do the page-link thing, I can just take that off [22:49:42] mooeypoo, cool. It *did* exist for the cross-wiki bundles, though. I checked that. [22:49:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review: Create a notification demo page - https://phabricator.wikimedia.org/T115551#2644864 (10Quiddity) 05Invalid>03Open Re-opening, I still think this would be useful to have. (Either a page which demo... [22:50:08] matt_flaschen, yes, cross-wiki always have that, since they never have a primary link [22:50:28] we didn't implement that for the bundles, though, since it was conditional, and I think we didn't consider ones that don't have primary links [22:50:29] And technically I was wrong. :) [22:51:01] Three's a problem with hierarchical stuff in the Echo UI btw... might want to fix that at some point [22:51:26] Well, you were the cause of finding out we didn't *have* it, so I define it as "right" even if you assumed incorrectly [22:51:27] :P [22:51:52] It was a known unknown. :) [22:56:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review: Create a notification demo page - https://phabricator.wikimedia.org/T115551#2644894 (10Mooeypoo) Hm. We could create a fake API response with a bunch of notifications - but it won't really reflect re... [23:01:40] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OATHAuth: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788#2644930 (10Reedy) [23:01:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OATHAuth: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788#2644932 (10Reedy) [23:25:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review: Create a notification demo page - https://phabricator.wikimedia.org/T115551#2644989 (10Quiddity) >>! In T115551#2644894, @Mooeypoo wrote: > And we can't really do a real API request, because that wou... [23:52:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OATHAuth: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788#2178564 (10Reedy) In OATHAuthKey.php... ``` // See if the user is using a scratch token if ( !$retval ) { $length =...