[00:07:34] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 2 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2638984 (10Mattflaschen-WMF) >>! In T2582#2638934, @jmatazzoni wrote: > This features seems more like a Reading... [00:16:23] mooeypoo, that makes sense. The only alternative thing I could think of is that something listens to the special page's model for seen time changes, then does this (rather than doing it explicitly). [00:16:47] But I'm not sure what would do that. [00:20:37] (03CR) 10Mattflaschen: [C: 032] "A couple alternatives would be:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [00:29:53] matt_flaschen, yeah, but the problem is that we can't be sure that the badges' JS loaded [00:31:41] So I thought maybe of having a global manager that stores references to the controllers of the badges and whatever else is related (special page or if we ever have anything else) and then it just listens and triggers... but that's relatively complex fix. We can do that, but seeing as this works, I figued it's suitable [00:32:23] ok, I'm off for the evening, see you tomorrow! [00:42:58] mooeypoo, have a good night. [00:43:14] mooeypoo, in my IRC message, I just meant doing the same as you're doing, but listening to the special page's model rather than doing it directly. [00:43:38] But you could also use mw.loader.using to wait for the badge JS to load. I don't see any advantage to that, really, though. [04:13:08] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-PageCuration: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030#2639159 (10Mattflaschen-WMF) [04:13:45] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-PageCuration: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030#937190 (10Mattflaschen-WMF) Actually, I think it only needs the client. Before, I may have misread ApiPageTriageTagging, and missed that appendtext was bei... [04:40:09] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: PageTriage should only include wikitext pages in Special:NewPagesFeed - https://phabricator.wikimedia.org/T145721#2639163 (10Mattflaschen-WMF) [08:05:23] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016): Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2546213 (10Qgil) What is the priority of this task, and is it expected to be started/comple... [08:16:10] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), and 2 others: Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2639452 (10Qgil) This task is marked as "Stalled/Waiting for something" in #collaboration-community-en... [08:27:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2639563 (10Qgil) [08:40:02] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 07Documentation: Make sure all Notification changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2639679 (10Qgil) [08:49:56] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Technical-Debt: PageTriage should not kill WikiPage::getText() - https://phabricator.wikimedia.org/T145751#2639768 (10Legoktm) [09:13:27] (03Merged) 10jenkins-bot: Stop listening to revslider.diffreload hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310232 (https://phabricator.wikimedia.org/T142636) (owner: 10Addshore) [09:28:13] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression: "TypeError: moment is undefined" when using Echo - https://phabricator.wikimedia.org/T145382#2639877 (10thiemowmde) 05Open>03Resolved [09:28:49] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#617033 (10Reedy) {F4470910} Is it me, or does the email just look/read/feel weird? Shou... [10:44:36] 06Collaboration-Team-Triage, 10Flow: When converting a page into a Flow board, take the whole section 0 instead of just the templates included into that section - https://phabricator.wikimedia.org/T145764#2640099 (10Trizek-WMF) [10:50:21] 06Collaboration-Team-Triage, 10Flow: When converting a page into a Flow board, take the whole section 0 instead of just the templates included into that section - https://phabricator.wikimedia.org/T145764#2640118 (10Trizek-WMF) [12:50:06] 06Collaboration-Team-Triage, 10Flow: Reduce "Edit description" label visibility - https://phabricator.wikimedia.org/T145773#2640360 (10Trizek-WMF) [13:30:00] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2640461 (10Trizek-WMF) [13:40:39] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), and 2 others: Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2640477 (10Trizek-WMF) It is a #goal. It is always waiting for something, and always on-going. I'm not... [13:43:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2640479 (10Trizek-WMF) @jmatazzoni, have you defined terms or drafted something? That glossary would be a good step forward fo... [14:06:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2640521 (10Trizek-WMF) >>! In T145159#2637550, @Halfak wrote: >> Communities are not considering [people come back after a substantial wikibreak] as exp... [14:13:23] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2640547 (10Halfak) IMO, "Experienced" doesn't mean knowing all of the rules, but rather knowing where the rules are and how to manage disagreements usin... [14:16:46] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2640548 (10Trizek-WMF) @Mooeypoo, which of the following explanations is the r... [14:21:21] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2640556 (10Qgil) [14:22:06] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Update Help:Notifications - https://phabricator.wikimedia.org/T119713#1833891 (10Qgil) Then let's remove this #Goal from the quarterly sprint, since at the end what counts is the activity... [16:04:55] RoanKattouw, for T85030 I ran into the issue that the talk page notification templates include the topic title in the template. To use MessagePoster properly, a separate topic title is required, and we don't want to show a topic title in the body (it works, but looks weird). [16:04:55] T85030: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030 [16:05:44] So part is extracting the topic titles from e.g. https://en.wikipedia.org/wiki/Template:ProdwarningBLP-NPF into separate messages (using a template would be a pain due to MessagePoster's/Flow's lack of support for that). [16:06:45] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2641047 (10Trizek-WMF) Correct. Plus, I think these cases are relatively rare. [16:06:50] But I also realized that these messages should really be in content language. PageTriage already does this wrong (e.g. edit summaries are in UI language), but it's not as blatant since most of the content is in templates. [16:07:14] So I think I need to either do: [16:07:24] 1. The content language part of T27349 [16:07:24] T27349: ResourceLoader: Support loading of messages in parsed formats (e.g. parsed, incontentlanguage, ..) - https://phabricator.wikimedia.org/T27349 [16:08:06] 2. Don't Do That Then (just do it as UI language and hope people don't change it while patrolling). [16:08:36] 3. Refactor these messages to be proxied via the server (with server-side MessagePoster) [16:08:40] 4. Other [16:10:30] #1 is probably the most generally useful, but wanted to check with you (I note you commented on it a little while back). [16:15:55] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Technical-Debt: PageTriage should not kill WikiPage::getText() - https://phabricator.wikimedia.org/T145751#2641117 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [16:23:48] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Technical-Debt: PageTriage should not call WikiPage::getText() - https://phabricator.wikimedia.org/T145751#2641170 (10Legoktm) [16:28:25] matt_flaschen: is Special:RecentChanges working for you in mw-vagrant? Mine is broken since yesterday with "Revision not found in revisionCache:". [16:34:48] stephanebisson, yeah, both enhanced and regular, with latest master for core, Flow, (and Echo). [16:35:07] ok, thanks, something's wrong with my setup [16:35:36] stephanebisson, not necessarily. etonkovidova hit something similar on Beta Cluster, T145125 . [16:35:37] T145125: [regression-betalabs] When 'Enhanced recent changes' option is used, Special:Watchlist displays Error page with 'Revision not found in revisionCache' for periods of time >3 days - https://phabricator.wikimedia.org/T145125 [16:36:27] based on the data then... [16:36:49] both etonkovidova and I have been messing with moderation [16:37:57] Yeah, seems quite possible, especially since it happens on Beta (so it's not caching changes) [16:54:48] (03PS1) 10Mattflaschen: Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) [16:55:47] (03PS2) 10Mattflaschen: Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) [16:55:49] (03CR) 10jenkins-bot: [V: 04-1] Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [16:56:47] (03CR) 10jenkins-bot: [V: 04-1] Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [16:59:37] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10WikiLove: Fix WikiLove message dependency - https://phabricator.wikimedia.org/T145798#2641364 (10Mattflaschen-WMF) [16:59:51] (03CR) 10Mattflaschen: "I'll fix the CI issue: T145798" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [17:41:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2641543 (10Trizek-WMF) Discussed with Moriel. The right one is "On Notificati... [17:50:48] ok I'm going to get to the office, be back online soon [18:53:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2641790 (10jmatazzoni) We discussed this in the ERI team discussion on 9/14. We decided to base the top two categories on the [[ https://en.wikipedia.or... [19:02:01] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2641799 (10Halfak) > autopatrolled and extendedconfirmed rights "[autoconfirmed](https://en.wikipedia.org/wiki/Wikipedia:User_access_levels#Autoconfirm... [20:06:22] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2642034 (10Halfak) Oh! Also, change "or" to "and". > 10 edits **and** 4 days of activity. > 30 days of activity **and** 500 edits [20:09:19] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19), 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2642037 (10Etonkovidova) (1) With '99+' implemented to be displayed as... [20:30:23] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10WikiLove: Fix PageTriage->WikiLove dependencies - https://phabricator.wikimedia.org/T145798#2642087 (10Mattflaschen-WMF) [20:30:35] (03PS1) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) [20:35:32] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2642094 (10jmatazzoni) I have made the following corrections (thanks @Halfak!) to the definitions, links and language above: > "**autoconfirmed**" (not... [20:36:08] (03PS2) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) [20:38:35] (03PS3) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) [20:40:45] (03CR) 10Reedy: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) (owner: 10Mattflaschen) [20:44:48] (03PS1) 10Sbisson: Don't crash when a revision is not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/310961 (https://phabricator.wikimedia.org/T145125) [20:50:26] stephanebisson, holy crap... Echo's qunit tests still use 'dm.NotificationsModel'... this is embarassing. Don't we have CI run this on every check?! if not, we should. I'm getting rid of current tests and writing new ones now, but we should really make this a CI job too [20:52:53] mooeypoo: there's a job (https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/10140/consoleFull) but it's hard to tell if it runs anything from Echo [20:53:16] there's also this one: https://integration.wikimedia.org/ci/job/mwext-qunit-jessie/4590/console [20:53:41] it can't be running anything from Echo because it would've exploded [20:53:55] not just failed... exploded. These objects don't exist anymore :\ [20:54:02] also, the "overlay test" tests for the wrong DOM stuff [20:54:04] [20:54:24] I'm going to rewrite so we at least have *basic* tests (we can expand later) and then I'll see how to add these to CI [20:54:39] good [20:56:25] ... ok this is why it didn't run EchoHooks::onResourceLoaderTestModules [20:56:52] It goes over the resource loader JS files and looks for a file in extensions/Echo/tests/test_[filename].js [20:57:16] so the test_mw.echo.dmNotificationModel wouldn't even be loaded. I think if I add proper files they probably will be [21:02:19] matt_flaschen, stephanebisson made a really good point advocating for setting seenTime in the PHP side of the special notifiations page (making php experience the same + the idea that the page loads later or may have api issues is an edge case + having the badges colored then turning grey is weird) -- anyways, since this means affecting the *badges* I need to put a test "am I on special notifications" in EchoHooks - but I can't [21:02:19] figure out how to get the name/title of the *current* page I'm in [21:02:31] wait [21:02:40] omg I am silly. We have it in the parameters [21:02:43] ... NEVERMIND. [21:02:52] * mooeypoo whistles innocently [21:07:08] mooeypoo, yeah, just watch out for the canonical name issue (Especial:Notificationes). Also, good point from Stephane regarding no-JS experience (I should have caught that). [21:07:48] Yeah I didn't think about that either [21:08:16] matt_flaschen, hm, so that's not good? I thought this is always true, the other canonical names are aliases? if ( $title->getPrefixedText() === 'Special:Notifications' ) { [21:08:33] How do I check if we're in special notifications otherwise? [21:09:46] I can also check if namespace === -1 [21:11:19] mooeypoo, I don't know, let me check real quick. You don't want to set it to grey on all special pages obviously. [21:11:41] no no I mean check namespace *with* another check, at least cover the namespace canonical names [21:11:42] but yeah [21:12:14] matt_flaschen, hm, 'getPrefixedDBKey' or 'getDBKey' maybe are the always-english one? [21:12:25] mooeypoo, not sure, checking. [21:13:08] !!! [21:13:10] mooeypoo, this is in PersonalUrls, right? [21:13:15] isSpecial( name ) [21:13:22] https://doc.wikimedia.org/mediawiki-core/1.25.5/php/classTitle.html#a9e06426da1d4af530e565123fdb3b895 [21:13:31] matt_flaschen, yep [21:13:47] mooeypoo, okay, good. I knew there was some way to do it, was going to check that next if the simple way didn't work. [21:14:00] Yeah I was going over the code + documentation [21:14:10] I assume "The special pag name" is "Notifications" [21:14:32] mooeypoo, which it doesn't. $title->getPrefixedText(): מיוחד:הודעות [21:14:38] ha [21:15:51] mooeypoo, yeah, isSpecial( 'Notifications' ) works. [21:16:55] (03PS2) 10Mooeypoo: Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) [21:16:57] ok, that's straight forward [21:17:09] I guess I don't have to do 'getTime' anymore,though, since I have that in that case [21:17:42] But I have them in the wrong format [21:18:32] mooeypoo, not sure exactly what you mean, but you can convert between timestamp formats with wfTimestamp. [21:18:35] (03CR) 10jenkins-bot: [V: 04-1] Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [21:19:05] what the [21:19:19] ... ah [21:19:41] (03PS3) 10Mooeypoo: Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) [21:23:44] (03CR) 10jenkins-bot: [V: 04-1] Update the badges' seen state when Special:Notifications is visited [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310698 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [21:24:33] (03PS4) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) [21:24:57] (03CR) 10Mattflaschen: Register WikiLove parts of 'ext.pageTriage.views.toolbar' conditionally (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310956 (https://phabricator.wikimedia.org/T145798) (owner: 10Mattflaschen) [21:26:50] (03PS3) 10Mattflaschen: Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) [21:53:30] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2642241 (10egalvezwmf) Hi @Trizek-WMF sorry for the late response on here - can you clari... [21:57:02] RoanKattouw, LOL at the random Dwimmerlaik reference in the VE data module. [22:07:12] mooeypoo, RoanKattouw, got a JS exception on MediaWiki.org, looking now. [22:10:17] 06Collaboration-Team-Triage, 10Notifications: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642269 (10Mattflaschen-WMF) [22:14:36] mooeypoo, well, that sucks. It's not reproducible, and it's really not clear what the error was. Evidently, something truthy, but not an array. [22:28:46] O.o [22:28:55] Was it related to something we merged/deployed recently? [22:29:06] in the exception itself, even? Or just a general exception [22:30:32] mooeypoo, the production mode stacktrace is in the task. I don't have the debug-mode stack trace since it went away when I tried to get it. [22:30:45] We really need to get source maps. [22:32:15] 06Collaboration-Team-Triage, 10Notifications: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642298 (10Mattflaschen-WMF) [22:32:47] O.o that makes no sense [22:33:05] mooeypoo, but it's easy to see where the error was, the question is what *was* newNotifData.bundledNotifications. [22:33:25] 06Collaboration-Team-Triage, 10Notifications: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642269 (10Mattflaschen-WMF) [22:33:26] oooh [22:33:48] I think I know how to defensively fix this [22:37:35] hmm could array_filter ever output something that is not an array? [22:38:20] (03PS1) 10Mooeypoo: Verify bundledNotifications data is an array before running .map() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) [22:38:32] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642269 (10Mooeypoo) So I can't immediately reproduce this, but I think it might be a good idea to add a defensive check to this operation anyw... [22:39:40] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642313 (10Mooeypoo) On the PHP side, we are outputting bundledNotifications in DataOutputFormatter->formatOutput on line #145. Could it have... [22:39:56] matt_flaschen, ^ this should fix things, but I am trying to check how it is even possible we got a non-array in there [22:53:03] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#2642339 (10Tgr) The ellipsis thing is done by `EchoEventPresentationModel::getUserLink()`... [23:14:07] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#2642417 (10Tgr) Consumer names work on the web interface. Maybe for email the presentation... [23:26:50] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: newNotifData.bundledNotifications.map is not a function - https://phabricator.wikimedia.org/T145825#2642431 (10Mooeypoo) a:03Mooeypoo [23:30:13] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#2642436 (10Tgr) I'll go out on a limb and assume that this was caused by master-slave lag... [23:32:00] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#2642441 (10Tgr) [23:58:21] (03CR) 10Mattflaschen: [C: 04-1] "This will send it to the local single notification path, if it's truthy, but not an array. Is this what we want?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311050 (https://phabricator.wikimedia.org/T145825) (owner: 10Mooeypoo) [23:59:59] mooeypoo, oh, I think I figured it out.