[00:08:19] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2631423 (10jmatazzoni) **Flag High Experience Editors as Well?** Newcomers are a particular interest of the ERI project. However, in considering how rev... [00:35:29] RoanKattouw: ooh, what kind of laptop? [01:38:31] The new ThinkPad Carbon [01:47:00] nice nice :D [07:52:17] 06Collaboration-Team-Triage, 10Thanks, 10Revision-Slider, 06TCB-Team, and 4 others: RevisionSlider fails to re-trigger the Thanks JS code when the diff changes - https://phabricator.wikimedia.org/T142636#2631886 (10Addshore) [07:52:31] 06Collaboration-Team-Triage, 10Thanks, 10Revision-Slider, 06TCB-Team, and 4 others: RevisionSlider fails to re-trigger the Thanks JS code when the diff changes - https://phabricator.wikimedia.org/T142636#2541631 (10Addshore) a:05WMDE-leszek>03Addshore [07:52:56] (03PS1) 10Addshore: Listen to the wikipage.diff hook for adding JS links [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310229 (https://phabricator.wikimedia.org/T142636) [07:55:09] (03PS1) 10Addshore: Stop listening to revslider.diffreload hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310232 (https://phabricator.wikimedia.org/T142636) [08:18:52] 06Collaboration-Team-Triage, 10Flow, 15User-zeljkofilipin: Talk page of an article redirects to another article - https://phabricator.wikimedia.org/T145374#2628002 (10zeljkofilipin) Thanks! [09:06:59] 06Collaboration-Team-Triage, 10Notifications: Link in notification points to unexpected destination due to magic linking ("RFC #") - https://phabricator.wikimedia.org/T70217#2632060 (10Legoktm) [09:07:40] 06Collaboration-Team-Triage, 10Notifications: Link in notification points to unexpected destination due to magic linking ("RFC #") - https://phabricator.wikimedia.org/T70217#717496 (10Legoktm) [13:22:35] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2632782 (10Trizek-WMF) I'm still wondering if a notification is needed for that new database entry. If available ressour... [13:54:29] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow on Windows 10 (Chrome or Edge) collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2632823 (10Trizek-WMF) >>! In T144587#2630974, @Catrope wrote: > This doesn't seem to be browser- or OS-sp... [13:54:40] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2632824 (10Trizek-WMF) [13:56:50] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2632827 (10Trizek-WMF) [14:09:49] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow as a Beta feature in Greek Wikipedia (elwiki) - https://phabricator.wikimedia.org/T144384#2632856 (10Trizek-WMF) Translations are done. That's ready for pickup. [14:25:02] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2632959 (10Trizek-WMF) Some experienced users may do bad faith edits sometimes, on purpose or by accident. For instance, I've removed categories in an a... [15:01:22] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2633098 (10Trizek-WMF) The survey will be stopped if we have +1,000 answers or if we don'... [15:24:40] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant: Error message when trying to open Special:Login on mediawiki-vagrant machine after enabling echo role - https://phabricator.wikimedia.org/T145523#2633172 (10zeljkofilipin) [15:24:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Error message when trying to open Special:Login on mediawiki-vagrant machine after enabling echo role - https://phabricator.wikimedia.org/T145523#2633188 (10zeljkofilipin) [15:33:07] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2633254 (10jmatazzoni) > The survey will be stopped if we have +1,000 answers Do we have... [15:59:59] (03CR) 10Catrope: [C: 032] Generalize getCappedNotificationCount and move to counter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310129 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [16:01:18] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Error message when trying to open Special:Login on mediawiki-vagrant machine after enabling echo role - https://phabricator.wikimedia.org/T145523#2633172 (10mobrovac) This sounds like an issue `vagrant git-update` migh... [16:02:00] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2633398 (10Pginer-WMF) >>! In T145159#2632959, @Trizek-WMF wrote: > Some experienced users may do bad faith edits sometimes, on purpose or by accident.... [16:07:20] (03Merged) 10jenkins-bot: Generalize getCappedNotificationCount and move to counter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310129 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [16:12:17] matt_flaschen: RoanKattouw: I see scary - internal_api_error_DBUnexpectedError and Exception Caught: Flow\\SubmissionHandler::commit: Expected mass rollback of all peer databases [16:12:24] matt_flaschen: RoanKattouw ??? [16:12:32] NFI [16:12:46] steph[TAB] aaro[TAB] [16:21:28] (03PS2) 10Sbisson: Browser tests: wait for notifications to be loaded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309296 [16:21:51] (03Abandoned) 10Sbisson: Browser tests: wait for notifications to be loaded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309296 (owner: 10Sbisson) [16:30:20] stephanebisson: 09:12:18 matt_flaschen: RoanKattouw: I see scary - internal_api_error_DBUnexpectedError and Exception Caught: Flow\\SubmissionHandler::commit: Expected mass rollback of all peer databases [16:30:30] Any idea what that's about? [16:30:37] etonkovidova, RoanKattouw, no. This is in Beta, right? [16:30:47] right [16:31:25] RoanKattouw, etonkovidova, OK, I will go into the coworking space then do this after standup. [16:32:30] no idea. there's an inner exception that we would need to see [16:33:58] matt_flaschen: RoanKattouw - I cannot reach fluorine to see logs and logstash-beta.wmflabs.org with that Kibana stuff does not make much sense to me [16:34:23] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2633479 (10Trizek-WMF) As I've mentioned on the Collaboration team hangout chat, I've jus... [16:40:51] We call 'rollback()' and it breaks, hiding the reason why we tried to rollback in the first place. [16:40:52] https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2016.09.13/mediawiki?id=AVckTwIV-4P7VPp_mHJS&_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-24h,mode:quick,to:now)) [16:42:46] There is actually a pop-up (only in VE mode) saying "the wikipedia database is temporarily in read-only mode." [16:43:52] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Error message when trying to open Special:Login on mediawiki-vagrant machine after enabling echo role - https://phabricator.wikimedia.org/T145523#2633508 (10zeljkofilipin) Thanks @mobrovac, I have forgot that! I did re... [16:51:39] matt_flaschen, RoanKattouw do you guys happen to know where {{GENDER}} thing is defined in the MW code? I've been grepping around and I can't find it [16:52:17] There's a GenderCache but that doesn't seem to be it [16:52:26] CoreParserFunctions.php ? [16:52:54] ooh ok [16:53:13] RoanKattouw, I'm trying to understand why {{GENDER:|foo|bar}} works in JS (recognizes current interface user) but not in PHP [16:53:32] I assume we have different implementations for these; any idea where the JS one is defined? [16:53:40] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2633530 (10Trizek-WMF) [16:53:42] I can't find the functions for i18n JS [16:53:43] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Track Flow activation - https://phabricator.wikimedia.org/T115110#2633529 (10Trizek-WMF) [16:54:09] Ahm, jqueryMsg maybe? [16:54:15] RoanKattouw, CoreParserFunctions #325 is the php side, it seems [16:54:48] mooeypoo: resources/src/mediawiki.language is the js I thik [16:55:10] bd808, bingo! thank you! [16:55:53] found via `cd resources/src; git grep GENDER` [16:56:19] oh you were searching directly in there... I was trying to grep "GENDER" and got swamped a bit with stuff [16:56:42] my next strategy was to try 'gender =' and 'function gender' and 'gender:' [16:57:15] yeah. manual filtering by going into likely sub-trees of the source can be helpful [16:57:40] and staying away from the i18n files entirely which will hit on all kinds of random words [16:57:52] Yeah, I filtered for .js [17:02:28] RoanKattouw, hangouts is being a pain, i'm trying to connect [17:03:36] matt_flaschen: Standup? [17:18:59] (03CR) 10Catrope: [C: 032] Allow for count cap display in Special:Notifications sidebar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310171 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [17:19:22] (03CR) 10Catrope: [C: 032] Add {{GENDER}} support to dynamic action messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310152 (https://phabricator.wikimedia.org/T144538) (owner: 10Mooeypoo) [17:25:18] (03CR) 10Mattflaschen: Fix seen time for new users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309688 (owner: 10Mattflaschen) [17:25:29] (03CR) 10Catrope: [C: 032] Fix seen time for new users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309688 (owner: 10Mattflaschen) [17:26:38] (03Merged) 10jenkins-bot: Allow for count cap display in Special:Notifications sidebar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310171 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [17:26:47] (03Merged) 10jenkins-bot: Add {{GENDER}} support to dynamic action messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310152 (https://phabricator.wikimedia.org/T144538) (owner: 10Mooeypoo) [17:28:54] matt_flaschen: Quick sanity-check: instead of using global user IDs for the seentime cache, we could just use the user name, right? [17:29:19] RoanKattouw, aren't the IDs better? You can do global renames. [17:29:25] Hmm right [17:29:26] Good point [17:29:47] Also users can be unattached [17:30:27] Ah, yeah, also a good point. The central lookup is a good opportunity to check for that. [17:30:41] ok RoanKattouw so just to verify, this means that $this->user->getId() needs to change to globalID lookup [17:30:55] I should keep the wfForeignMemcKey etc [17:30:58] Yes [17:31:01] However! [17:31:05] 'cause in NotifUser we're using wfGlobalCacheKey [17:31:05] Note that the central ID lookup may fail [17:31:24] If that happens, forget all about trying to access foreign wikis' seen times [17:31:27] Yeah I saw that, but it seems to return false if that's the case and not store?! [17:31:38] hmm [17:31:39] ok [17:32:00] I mean, it should(TM) be impossible for you to have cross-wiki notifs in that scenario anyways [17:32:01] (03Merged) 10jenkins-bot: Fix seen time for new users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309688 (owner: 10Mattflaschen) [17:32:06] Because the euw table uses global IDs [17:32:53] right [17:32:59] Should... [17:33:36] mooeypoo: https://phabricator.wikimedia.org/T134855#2631070 is the bug BTW [17:33:49] Well what I mean is, if we can't look up the global ID, weird things are happening and XWN is not going to work [17:33:56] This should only happen for unattached accounts which are rare [17:36:20] And on wikis that are not SULed, which are not rare. That's the main reason we need to check [17:36:23] (e.g. officewiki) [17:37:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Error message when trying to open Special:Login on mediawiki-vagrant machine after enabling echo role - https://phabricator.wikimedia.org/T145523#2633761 (10zeljkofilipin) 05Open>03Resolved a:03zeljkofilipin `vag... [17:44:40] RoanKattouw / mooeypoo: When you have a sec can I chat about OOUI for https://www.mediawiki.org/w/index.php?title=Edit_Review_Improvements&diff=0&oldid=2237809#/media/File:Recent-changes-step1-open.png ? :-) [17:45:13] RoanKattouw, it's also turned off ($wgEchoCrossWikiNotifications) in config for the non-SUL wikis. [17:45:32] James_F: Maybe this afternoon or something but not now or in the next few hours [17:46:21] matt_flaschen: Oh right, partially because CentralIdLookup does NOT return false in the one-wiki scenario, it just returns the local wiki ID [17:46:48] I keep forgetting that about CentralIdLookup. :( [17:46:52] Come to think of it, you probably get all sorts of fun bugs if you turn a non-SUL wiki into an SUL wiki or vice versa [17:47:02] s/local wiki ID/local user ID/ [17:47:33] Of course. [17:53:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2633819 (10jmatazzoni) @Pginer-WMF and @Trizek-WMF, thanks for your comments. I was assuming this was a kind of "Trusted user" category—similar to how A... [17:54:37] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): [regression-wmf.18] Notifications from deleted Flow topics are not purged - https://phabricator.wikimedia.org/T145232#2633826 (10Etonkovidova) Checked in betalabs - loos good: all n... [17:56:53] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2633850 (10jmatazzoni) I'm sure Edward knows more about it than me. I was just wondering... [18:02:41] (03CR) 10Catrope: [C: 032] Listen to the wikipage.diff hook for adding JS links [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310229 (https://phabricator.wikimedia.org/T142636) (owner: 10Addshore) [18:02:50] (03CR) 10Catrope: [C: 032] Stop listening to revslider.diffreload hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310232 (https://phabricator.wikimedia.org/T142636) (owner: 10Addshore) [18:04:00] matt_flaschen: Could you merge https://gerrit.wikimedia.org/r/#/c/310060/ please? Timo +1ed it but dragged his feet on merging it [18:10:22] (03Merged) 10jenkins-bot: Listen to the wikipage.diff hook for adding JS links [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/310229 (https://phabricator.wikimedia.org/T142636) (owner: 10Addshore) [18:24:46] mooeypoo: Any luck with the ID stuff? [18:24:55] Do you need help or are you OK? [18:25:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add ORES good-faith and damaging scoring display and new user flag to RC Page - https://phabricator.wikimedia.org/T144451#2634028 (10jmatazzoni) [18:29:15] RoanKattouw: Version bump of moment.js is https://gerrit.wikimedia.org/r/#/c/310367 but un-tested yet. [18:29:37] Thanks [18:30:30] Loads of MW languages will get Moment support for the first time with that, which is nice. [18:40:12] (03PS1) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) [18:40:24] (03CR) 10jenkins-bot: [V: 04-1] Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:40:58] (03PS4) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [18:41:04] (03CR) 10Sbisson: [WIP] Update Flow caching strategy for multi DC (0314 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [18:41:31] (03PS5) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [18:41:37] (03PS2) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) [18:41:49] (03CR) 10jenkins-bot: [V: 04-1] Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:45:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [18:45:48] (03PS3) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) [18:48:54] (03CR) 10jenkins-bot: [V: 04-1] Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:49:20] (03CR) 10Catrope: [C: 04-1] Store global seenTime with global Ids rather than local IDs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:51:29] (03PS6) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [18:51:59] (03CR) 10Catrope: Store global seenTime with global Ids rather than local IDs (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:54:54] (03CR) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [18:57:50] (03CR) 10Catrope: Store global seenTime with global Ids rather than local IDs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:03:05] RoanKattouw, I will after the meeting, sorry. [19:09:13] (03CR) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:10:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression: "TypeError: moment is undefined" when using Echo - https://phabricator.wikimedia.org/T145382#2628211 (10SBisson) a:03Catrope [19:15:12] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Notifications, 10MediaWiki-Internationalization, and 4 others: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2634339 (10Guycn2) Thank you for fixing it [19:16:30] (03PS4) 10Mooeypoo: Store global seenTime with global Ids rather than local IDs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) [19:40:23] (03CR) 10Catrope: Store global seenTime with global Ids rather than local IDs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310370 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:45:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Documentation: Document how to create a new notification type - https://phabricator.wikimedia.org/T136372#2332510 (10SBisson) >>! In T136372#2630769, @Mooeypoo wrote: > I created a tutorial as a draft: https://www.mediawiki.org/wiki/User:MSchottlender-WMF/Cr... [19:47:05] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2634467 (10egalvezwmf) @jmatazzoni - This depends on what kind of sub analysis you want t... [20:00:37] (03PS1) 10Catrope: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 [20:00:49] (03CR) 10jenkins-bot: [V: 04-1] Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [20:03:36] (03PS1) 10Catrope: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/310385 [20:14:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Evaluate need to productize ERI model-training software - https://phabricator.wikimedia.org/T145568#2634540 (10jmatazzoni) [20:23:37] matt_flaschen: I've updated the caching patch. Still have some problems with opt-in when trying to restore previous Flow board (exception: Update not allowed on: rev_content_url, rev_flags). [20:34:15] (03Abandoned) 10Catrope: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [20:36:00] stephanebisson, that means it's trying to update an existing revision. It should never do that, it should create new revisions. Will re-review in a bit. [20:38:08] (03CR) 10Chad: [C: 032] Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/310385 (owner: 10Catrope) [20:44:08] (03Merged) 10jenkins-bot: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/310385 (owner: 10Catrope) [20:54:52] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19), 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2607902 (10Etonkovidova) Checked in betalabs - '99+' is correctly disp... [21:13:47] (03Restored) 10Catrope: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [21:21:38] (03PS2) 10Mooeypoo: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [21:34:15] (03CR) 10Catrope: [C: 032] Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [21:41:00] (03Merged) 10jenkins-bot: Revert "Make seen/unseen badge more consistent across wikis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310384 (owner: 10Catrope) [21:52:05] Merged the moment patch: https://gerrit.wikimedia.org/r/#/c/310060/1 [21:53:58] ^ RoanKattouw Should I add that to your SWAT? [21:54:49] Yes please [21:59:47] meh, I need demorgan's law help [22:00:23] RoanKattouw, matt_flaschen demorgan me... I am adding a check to "toggleSeen" in notifications to verify that we're not marking a notification as "unseen" (notice the negative) if it is *read* [22:00:36] so only change the state if *NOT* !seen && this.isRead() [22:01:06] by the law, it seems it should be if ( seen || this.isRead() ) { ... } but that looks so wrong [22:01:13] mooeypoo [22:01:17] Yeah, you missed one. [22:01:18] err if ( seen || !this.isRead() ) [22:01:38] Wait, one sec. [22:01:47] but.. meh this seems like it won't change the state for unread ever [22:01:59] which I guess is practically true because we don't *set* unseen for unread [22:02:00] but [22:02:02] mooeypoo, shouldn't it be: [22:02:03] my brain is flipping [22:02:12] err unseen for read [22:02:19] omg those double negatives are killing me [22:03:04] it seems to also skip it if it's marking seen [22:03:09] i am so confused, sigh [22:03:14] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Possible-Tech-Projects, and 2 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2634933 (10Quiddity) Per discussion in T88781 I'm adding this task to Outreachy 13. Still needs Mentors, and de... [22:03:55] mooeypoo, in the item or the widget? [22:03:59] matt_flaschen, sanity check, then... does this mae sense: [22:04:01] if ( [22:04:01] this.seen !== seen && [22:04:01] // Do not change the state of a read item, as it is [22:04:01] // never unseen [22:04:01] ( !this.isRead() ) [22:04:02] ) { [22:04:04] ... [22:04:08] in the dm.NotificationItem [22:04:10] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2634952 (10Quiddity) Per Matt's advice, I've added the other slightly simpler task to Outreachy-13. [22:04:15] toggleSeen [22:04:56] only change state + emit event if the state *changed* **and** if the notification is unread [22:05:13] this means I trust the controller to never mark a notification as 'unseen' if it is read (which it checks for, so it is a safe assumption) [22:05:19] should be at least [22:05:28] mooeypoo, yeah, that looks right. [22:05:33] * mooeypoo nods [22:05:33] thanks [22:05:41] Only change the seen flag if they requested a change and it's unread. [22:05:45] those double-negatives with "not" conditions are insanely confusing [22:05:50] * mooeypoo nods [22:06:52] matt_flaschen, great, this means I can "blindly" tell the model manager to go over and toggle all items as seen when global seentime changes without worrying about emitting redundant events. [22:07:00] it will just emit events for an item that actually changed state [22:19:57] 06Collaboration-Team-Triage, 10Notifications: Prevent double-click on 'Email this user' form to avoid sending duplicate emails - https://phabricator.wikimedia.org/T145585#2635028 (10Etonkovidova) [22:23:10] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2635061 (10Quiddity) >>! In T131210#2632782, @Trizek-WMF wrote: > I'm still wondering if a notification is needed for th... [22:24:17] Going to take a break to go home and get dinner. Talk to you later. [22:26:11] bon apetit, matt_flaschen [22:35:11] 06Collaboration-Team-Triage, 10Notifications: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications) - https://phabricator.wikimedia.org/T113125#1655559 (10Jdlrobson) If anyone is interested I believe I have a good grasp of the requirements for this. I've... [22:44:12] matt_flaschen: do you think it's possible to track down in production logs if an email sent via Special:Emailuser was not sent? I have timestapms of email notifications. [22:44:31] matt_flaschen: and the user_id [22:51:47] RoanKattouw: if in production db, select distinct(notification_seen) from echo_notification; returns only 0 -- is it ok? [22:57:45] etonkovidova: Yes, in fact we're going to ask for that field to be removed [22:57:52] It was created but we never used it for anything [22:58:10] etonkovidova: Yes, emails not being sent can happen, there's a bug about that somewhere [22:58:34] It's because of issues with pretending that the email came from the other usrer [22:58:46] RoanKattouw: thanks for both answers! :) [22:58:49] Depending on which provider their email address is from, that can fail [22:59:29] RoanKattouw: any logs about it or something? just out of curiousity ... [23:01:11] Yes actually [23:01:27] There is a table that tracks bounces [23:01:45] RoanKattouw: oh - good [23:02:56] Lemme find it [23:04:59] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2635302 (10Halfak) > Some experienced users may do bad faith edits sometimes, on purpose or by accident. I don't think that "bad faith" is the right wo... [23:05:22] etonkovidova: You have stat1003 access, right? [23:05:35] RoanKattouw: yup [23:05:49] mysql -h s3-analytics-slave [23:05:51] use wikishared [23:05:59] select * from bounce_records order by br_id desc limit 5; [23:06:28] RoanKattouw: ok - will look. thx again! [23:14:37] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2635311 (10jmatazzoni) @Halfak wrote: > just report the user group memberships in raw form like Special:ListUsers. If I understand you here, you're su... [23:20:10] (03PS1) 10Mooeypoo: [wip] Convert 'seenTime' to a global property [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) [23:21:11] 06Collaboration-Team-Triage, 10Notifications, 10Mail: Got a notification for an e-mail I didn't received - https://phabricator.wikimedia.org/T143981#2585182 (10Etonkovidova) There is a record in bounce_records table of failed mail delivery: "Mail delivery failed: returning message to sender". [23:24:06] (03CR) 10jenkins-bot: [V: 04-1] [wip] Convert 'seenTime' to a global property [extensions/Echo] - 10https://gerrit.wikimedia.org/r/310460 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [23:28:44] etonkovidova: That bug is a duplicate of... something [23:28:48] Lemme see if I can find it [23:29:25] matt_flaschen: thanks for correcting project tag for https://phabricator.wikimedia.org/T145585. I realized that I tagged it incorrectly, returned but you already re-tagged it! :) [23:30:01] etonkovidova: T134886 [23:30:02] T134886: Special:EmailUser emails sometimes not delivered due to bounce - https://phabricator.wikimedia.org/T134886 [23:30:27] RoanKattouw: hm... ok -let's consolidate them [23:31:19] RoanKattouw: the reasons for undelivered mails can be totally out of our control .... [23:31:28] Yes [23:31:36] I think someone is trying to work on fixing it somewhere [23:32:42] RoanKattouw: ok - yes, on https://phabricator.wikimedia.org/T134886 there is a list of related bugs. I will just add https://phabricator.wikimedia.org/T143981 to it [23:34:28] Hmm I thought there was a patch for this but I must have hallucinated that [23:38:29] 06Collaboration-Team-Triage, 10Notifications, 10Mail: Got a notification for an e-mail I didn't received - https://phabricator.wikimedia.org/T143981#2635384 (10Etonkovidova)