[00:01:20] RoanKattouw, I'm confused [00:01:21] https://gerrit.wikimedia.org/r/#/c/309699/5/includes/ForeignNotifications.php@166 [00:01:29] WHY is this updating itself for every wiki [00:01:44] it's not even checking if it "should" ... there's no condition about replacing the values [00:02:12] ok wait, right, sorry, bah, the line was cut out [00:02:17] I didn't notice it was *adding* to it [00:02:24] Yes, it needs to add everything up [00:02:57] So I was suggesting capping the 2 sums at the end, rather than capping the 2*N intermediate values at every step [00:03:20] But also, I think you can just remove that capping entirely because every place that $this->counts is used the result is already being capped [00:04:28] (03CR) 10Catrope: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [00:04:55] (03PS7) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [00:05:01] (03CR) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [00:05:26] (03CR) 10Catrope: [C: 04-1] Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [00:05:29] RoanKattouw, I removed it entirely, but i'm ont 100% convinced that's wise [00:05:49] The class calls them directly... although I do cap the results everywhere else, so it shouldn't matter [00:05:53] I guess it's possible that someone might try to use $this->counts in the future and forget to cap it [00:06:10] But it's really only ever used for getCounts(), nothing else uses it [00:06:17] So I'm not too worried [00:06:29] (03PS8) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [00:08:07] mooeypoo: Also due to a race condition I think you missed https://gerrit.wikimedia.org/r/#/c/309699/6/includes/ForeignNotifications.php@75 [00:08:21] I submitted it 30 seconds before you submitted PS7 [00:08:49] I cap it [00:09:28] bah [00:09:28] ok [00:10:47] (03PS9) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [00:11:54] OK [00:12:00] mooeypoo: One More Thing (TM): bump the cache version [00:12:08] It's $wgEchoSomething in Echo.php [00:13:03] hm, i can't find anything 'cache' in Echo.php [00:13:10] except for the comment for $wgEchoCrossWikiNotifications = false; [00:13:14] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Allow users to create custom notifications onwiki - https://phabricator.wikimedia.org/T58362#2624863 (10Catrope) [00:13:16] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2624862 (10Catrope) [00:14:15] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2159346 (10Catrope) Removing association with T58362 because that's not actually required: the request is not for manual... [00:14:20] RoanKattouw, and the only thing I can see with "version" is $wgEchoConfig version [00:14:22] Version? [00:14:24] which I assume is not what we mean? [00:14:25] I think that's it [00:14:29] Let me verify [00:14:31] we're bumping echo version? [00:14:48] Yup [00:14:49] return wfMemcKey( $key, $this->mUser->getId(), $wgEchoConfig['version'] ); [00:15:01] ok... so 1.12 now? [00:15:07] it's 1.11 currently [00:15:12] It's only used for cache keys and EventLogging apparently [00:15:15] Yes, just increment it [00:15:36] (03PS10) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [00:16:43] * mooeypoo awaits another comment [00:44:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2624959 (10Daniel_Mietchen) >>! In T144707#2621758, @Catrope wrote: > As Stephane said, this appears to be becaus... [01:17:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2625020 (10Catrope) >>! In T144707#2624959, @Daniel_Mietchen wrote: >>>! In T144707#2621758, @Catrope wrote: >> A... [01:21:03] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2625022 (10Quiddity) @Catrope Hmm, it would need to be triggerable "when a new database becomes available to everyone" t... [01:29:46] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2625035 (10Catrope) @Quiddity Oh, sorry, I'm confusing this with {T132084}, my bad. [01:30:06] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Allow users to create custom notifications onwiki - https://phabricator.wikimedia.org/T58362#2625037 (10Catrope) [01:30:08] 06Collaboration-Team-Triage, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2625036 (10Catrope) [01:33:09] (03CR) 10Catrope: [C: 032] Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [01:39:25] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2625042 (10Quiddity) [01:39:44] (03Merged) 10jenkins-bot: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [02:42:58] (03CR) 10Catrope: [C: 032] Remove js-truncation of descriptions in Special:Notifications desktop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309201 (owner: 10Mooeypoo) [02:49:05] (03Merged) 10jenkins-bot: Remove js-truncation of descriptions in Special:Notifications desktop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309201 (owner: 10Mooeypoo) [02:52:26] RoanKattouw: what kind of projects are you looking for? one that'll take the whole time period kinda like gsoc? full time or part? [03:13:21] legoktm: Sorry, I should have specified. Ideally ~6 weeks (so half of the 12), and it's 20hrs/wk [05:12:22] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2625087 (10Tjlsangria) What do you want to call the $wg setting? [06:36:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Design, 07Persona-Active-Editor: Explore ideas for Contribution Filtering - https://phabricator.wikimedia.org/T138935#2625112 (10Pginer-WMF) [[ http://pauginer.github.io/prototypes/edit-review/recent-changes/index.html | This prototype illustrates... [06:36:54] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2625113 (10Pginer-WMF) [[ http://pauginer.github.io/prototypes/edit-review/recent-changes/index.htm... [11:19:00] 06Collaboration-Team-Triage, 10Notifications, 10GoogleLogin: "MediaWiki:Notification-header-change-googlelogin" has a grammar mistake - https://phabricator.wikimedia.org/T145275#2625351 (10Guycn2) [12:35:36] 06Collaboration-Team-Triage, 10Notifications, 10GoogleLogin: "MediaWiki:Notification-header-change-googlelogin" has a grammar mistake - https://phabricator.wikimedia.org/T145275#2625395 (10Florian) It would be nice, if you could explain, what mistake you mean :) [15:26:40] 06Collaboration-Team-Triage, 10Notifications, 10GoogleLogin: "MediaWiki:Notification-header-change-googlelogin" has a grammar mistake - https://phabricator.wikimedia.org/T145275#2625549 (10Guycn2) @Florian, "Your connected Google** accounts has** been changed". "has" should be replaced by "have". Another po... [16:04:19] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2625597 (10Tjlsangria) I created this nifty maintenance script to retroactively populate the thanks log with revision IDs. (I haven't... [17:30:18] 03Collab-Team-Q1-July-Sep-2016, 10Wikimedia-Extension-setup: Add NewUserMessage to kabwiki, for Flow, if community agrees - https://phabricator.wikimedia.org/T145230#2625760 (10Dereckson)