[00:10:19] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2621619 (10Dereckson) [00:11:04] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2054159 (10Dereckson) [00:12:26] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2621627 (10Dereckson) [00:14:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#2621630 (10jmatazzoni) [00:15:26] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#2621644 (10jmatazzoni) [00:29:25] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Research current "new user" definitions and consider whether we need a different name for the ERI “new user” flag - https://phabricator.wikimedia.org/T145157#2621668 (10jmatazzoni) [00:30:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Research current "new user" definitions and consider whether we need a different name for the ERI “new user” flag - https://phabricator.wikimedia.org/T145157#2621668 (10jmatazzoni) Here are @Quiddity's comments from the team discusion on this:... [00:31:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2621697 (10jmatazzoni) [00:33:53] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Research current "new user" definitions and consider whether we need a different name for the ERI “new user” flag - https://phabricator.wikimedia.org/T145157#2621710 (10jmatazzoni) [00:33:55] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2621709 (10jmatazzoni) [00:39:04] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-WikimediaMaintenance: Add Flow tables to createExtensionTables maintenance script - https://phabricator.wikimedia.org/T145160#2621722 (10Dereckson) [00:39:46] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Add New User calculation and flag to the ERI feed - https://phabricator.wikimedia.org/T145159#2621737 (10jmatazzoni) [00:44:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES decision data to improve accuracy of models - https://phabricator.wikimedia.org/T145161#2621740 (10jmatazzoni) [00:44:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES decision data to improve accuracy of models - https://phabricator.wikimedia.org/T145161#2621753 (10Catrope) What is "ORES decision data"? [00:46:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES-guided edit-review decision data to improve accuracy of ORES models - https://phabricator.wikimedia.org/T145161#2621756 (10jmatazzoni) [00:46:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES-guided edit-review decision data to improve accuracy of ORES models - https://phabricator.wikimedia.org/T145161#2621740 (10jmatazzoni) @catrolpe, I edited the task title. Does that help? [00:50:15] (03CR) 10Catrope: [C: 04-1] Remove etp_user (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [00:51:19] 06Collaboration-Team-Triage, 10Notifications: Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2607902 (10Catrope) As Stephane said, this appears to be because we use capped notification counts inconsistently, and also don't use messages that understand that "100" means "99+"... [00:53:51] 06Collaboration-Team-Triage, 10Notifications: Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2621777 (10Catrope) Also note that 2000 is a magic number: it's the maximum number of notifications you can have. This may be why the number of notifications for Q229883 is going do... [00:59:46] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2621800 (10jmatazzoni) [01:00:59] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2621800 (10jmatazzoni) [01:05:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES-guided edit-review decision data to improve accuracy of ORES models - https://phabricator.wikimedia.org/T145161#2621840 (10Catrope) Yes, that helps, thanks. IIRC @Halfak said something about this data not being directly suitable for training... [01:11:21] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2621846 (10jmatazzoni) [01:13:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add metadata not currently in RCStream to ERI feed. - https://phabricator.wikimedia.org/T145164#2621866 (10jmatazzoni) [01:22:54] Have a good night, see you tomorrow [03:06:08] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2622071 (10Dereckson) 05Open>03Resolved [03:08:44] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2622076 (10Dereckson) 05Resolved>03Open [ Reopened, asthis needs further namespaces deployment. ] [07:57:35] (03PS1) 10Addshore: Fix case of setCookie method in Hooks file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309532 [07:58:16] (03CR) 10Legoktm: [C: 032] Fix case of setCookie method in Hooks file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309532 (owner: 10Addshore) [07:59:14] (03PS1) 10Addshore: Only try to enable feature if BetaFeatures is loaded [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309533 [07:59:23] legoktm: ^^ thats the main one :p [08:00:41] (03CR) 10Legoktm: [C: 032] Only try to enable feature if BetaFeatures is loaded [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309533 (owner: 10Addshore) [08:01:30] tyvm! [08:05:40] (03Merged) 10jenkins-bot: Fix case of setCookie method in Hooks file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309532 (owner: 10Addshore) [08:09:00] (03Merged) 10jenkins-bot: Only try to enable feature if BetaFeatures is loaded [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309533 (owner: 10Addshore) [08:46:25] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2622505 (10phuedx) 05Open>03Resolved Thanks for picking this up so quickly... [10:13:32] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2622658 (10Addshore) [10:13:34] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Unclear "fail to mention" in echo-pref-tooltip-mention-failure - https://phabricator.wikimedia.org/T143084#2622656 (10Addshore) 05Open>03Resolved a:03Addshore [10:13:47] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 2 others: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2622660 (10Addshore) 05Open>03Resolved [10:15:00] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2308308 (10Addshore) [10:15:03] 06Collaboration-Team-Triage, 10Flow, 10Mention-Notification, 06TCB-Team, and 2 others: Inform users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#2622661 (10Addshore) [10:15:36] 06Collaboration-Team-Triage, 10Flow, 10Mention-Notification, 06TCB-Team, and 2 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#2605253 (10Addshore) [10:15:48] (03PS3) 10Addshore: Add mention failure notifications to Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308555 (https://phabricator.wikimedia.org/T144614) [12:55:07] (03CR) 10Sbisson: "It is very likely that this problem was the cause of T93673#2607119" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309465 (owner: 10Catrope) [12:56:18] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2622915 (10SBisson) >>! In T93673#2607119, @Quiddity wrote: > Two fresh reports of edito... [13:33:25] (03PS10) 10Sbisson: Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [14:03:00] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES-guided edit-review decision data to improve accuracy of ORES models - https://phabricator.wikimedia.org/T145161#2623038 (10Halfak) Indeed. Storing false positives helps us notice trends and prioritize new work to make the models more effectiv... [14:03:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Save ORES-guided edit-review decision data to improve accuracy of ORES models - https://phabricator.wikimedia.org/T145161#2623041 (10Halfak) See https://www.wikidata.org/wiki/Wikidata:ORES/Report_mistakes for an example of how we usually work with miscl... [14:10:18] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2623043 (10Trizek-WMF) [14:12:40] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Work on Flow satisfaction survey's results and publish them - https://phabricator.wikimedia.org/T144730#2623057 (10Trizek-WMF) [14:12:42] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2623056 (10Trizek-WMF) [14:12:57] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2623043 (10Trizek-WMF) [14:12:59] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Work on Flow satisfaction survey's results and publish them - https://phabricator.wikimedia.org/T144730#2608487 (10Trizek-WMF) [14:13:05] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow satisfaction survey result: translate free forms - https://phabricator.wikimedia.org/T145198#2623043 (10Trizek-WMF) [14:13:07] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Work on Flow satisfaction survey's results and publish them - https://phabricator.wikimedia.org/T144730#2608487 (10Trizek-WMF) [14:13:09] Raah. [14:13:44] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2623063 (10Trizek-WMF) [14:13:46] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#2623062 (10Trizek-WMF) [14:23:18] (03CR) 10Sbisson: Remove etp_user (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [16:07:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2623326 (10Neil_P._Quinn_WMF) This looks really g... [16:17:38] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2623398 (10Catrope) >>! In T144331#2623326, @Neil... [16:25:49] (03CR) 10Catrope: [C: 032] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [16:26:56] 06Collaboration-Team-Triage, 10Notifications, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2623435 (10Quiddity) [16:34:50] (03Merged) 10jenkins-bot: Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [16:43:05] (03PS1) 10Fomafix: Add missing dependency to module 'mediawiki.api.options' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309606 [16:48:52] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Watchlist, 07Regression: [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' - https://phabricator.wikimedia.org/T145125#2623498 (10Etonkovidova) [16:49:51] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Watchlist, 07Regression: [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' - https://phabricator.wikimedia.org/T145125#2620690 (10Etonkovidova) @Mattflaschen-WMF betalabs enwiki - I added it to the issue d... [17:42:49] (03PS2) 10Fomafix: Add missing dependency to module 'mediawiki.api.options' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309606 [17:43:01] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-Watchlist, 07Regression: [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' - https://phabricator.wikimedia.org/T145125#2623690 (10Mattflaschen-WMF) [17:43:17] (03CR) 10Catrope: [C: 032] "Good catch! I've moved this dependency to the module that contains the file that actually calls saveOptions (NotificationBadgeWidget.js)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309606 (owner: 10Fomafix) [17:43:59] Getting lunch [17:49:44] (03Merged) 10jenkins-bot: Add missing dependency to module 'mediawiki.api.options' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309606 (owner: 10Fomafix) [17:56:46] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 13Patch-For-Review, and 2 others: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts with Wikibase enabled - https://phabricator.wikimedia.org/T144727#2623788 (10Lydia_Pintscher) 05Open>03Resolved a... [18:54:05] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2623988 (10Quiddity) [19:11:43] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2624055 (10Mooeypoo) >>! In T144331#2623398, @Cat... [19:31:40] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEma... - https://phabricator.wikimedia.org/T137771#2624101 [19:32:00] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Unexpected type issue in an EchoEventPresentationModel::jsonSerialize - https://phabricator.wikimedia.org/T145229#2624105 (10Dereckson) [19:32:29] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-NewUserMessage: Add NewUserMessage to kabwiki, for Flow, if community agrees - https://phabricator.wikimedia.org/T145230#2624121 (10Mattflaschen-WMF) [19:32:47] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-NewUserMessage: Add NewUserMessage to kabwiki, for Flow, if community agrees - https://phabricator.wikimedia.org/T145230#2624135 (10Mattflaschen-WMF) [19:32:50] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-NewUserMessage, 13Patch-For-Review: NewUserMessage should handle Flow properly; affects gomwiki/Konkani Wikipedia - https://phabricator.wikimedia.org/T131957#2624136 (10Mattflaschen-WMF) [19:33:09] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-NewUserMessage, 13Patch-For-Review: NewUserMessage should handle Flow properly; affects gomwiki/Konkani Wikipedia and kabwiki - https://phabricator.wikimedia.org/T131957#2184191 (10Mattflaschen-WMF) [19:35:51] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-NewUserMessage: Add NewUserMessage to kabwiki, for Flow, if community agrees - https://phabricator.wikimedia.org/T145230#2624139 (10Mattflaschen-WMF) [19:35:54] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2624138 (10Mattflaschen-WMF) [19:36:29] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2469667 (10Mattflaschen-WMF) Also {T145230} (I think this is the best way to resolve it, but if the commu... [19:39:07] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Unexpected type issue in an EchoEventPresentationModel::jsonSerialize - https://phabricator.wikimedia.org/T145229#2624146 (10Dereckson) a:03Dereckson MentionStatusPresentationModel::getSecondaryLinks() could return `false`. Fixing that. [19:44:28] 06Collaboration-Team-Triage, 10Notifications, 07Regression: [regression-wmf.18] Notifications from deleted Flow topics are not purged - https://phabricator.wikimedia.org/T145232#2624171 (10Etonkovidova) [19:44:39] (03PS2) 10Mooeypoo: Remove js-truncation of descriptions in Special:Notifications desktop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309201 [19:46:10] Hi. Do you know is some extensions implement EventPresentationModel abstract class (outside Echo itself)? [19:46:29] Dereckson, Flow does, it extends it for FlowPresentationModel [19:46:40] There's also Thanks, I think [19:46:57] EchoThanksPresentationModel extends EchoEventPresentationModel [19:47:14] Despite having "Echo" prefix, it's actually in the Thanks extension [19:48:00] and FlowPresentationModel also extends EchoEventPresentationModel in Flow/includes/Notifications/ [19:48:14] Dereckson, what do you need? You want to create a new notifications in another extension? [19:48:36] We have a task somewhere to document how to do that better but there are several examples out there, and we can definitely help [19:49:47] It's to check method return type, we've some getSecondaryLinks method returning another thing than an array - https://phabricator.wikimedia.org/T145229 [19:50:06] Aha, looks like you found it [19:50:08] I checked the ones in Flow, they are all returning array. [19:50:14] Yeah a bunch of extensions extend this class [19:50:20] Every extension that provides notification types [19:51:22] hmm, primary link can return false, but I think secondary links should always return an array (?) [19:51:47] oh, you found it [19:52:01] I found *one*, there is no warranty there is only one. [19:52:06] Dereckson: https://github.com/search?utf8=%E2%9C%93&q=org%3Awikimedia+getSecondaryLinks+extension%3Aphp&type=Code&ref=advsearch&l=&l= [19:52:07] yeah [19:52:08] Thanks checked too, it's fine. [19:52:26] I have a convoluted idea now [19:52:50] Whoa I did not know about the GoogleLogin extension, or that it had notifications [19:52:53] Ah thanks RoanKattouw, I can check all of them like that. [19:53:15] (03CR) 10Mattflaschen: "I don't understand this change. $wgFlowEnableOptInBetaFeature defaults false. isBetaFeatureAvailable should have already returned false, " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309533 (owner: 10Addshore) [19:53:21] Yup, and as mooeypoo said, return false is OK for getPrimaryLink but not getSecondaryLinks [19:53:28] RoanKattouw, since we're allowing (and somewhat encouraging) other extension developers to extend and use EventPresentationModel.... uhm... how about we make a little "validate" script they can run (or, better yet, **we** can run) that points out issues, somewhat like a unit test but more generalized? [19:53:54] I don't think that what Dereckson just found can be found programatically [19:54:04] The documentation for getSecondaryLinks clearly states you must return an array [19:54:20] I suppose it could more clearly state that false is not OK, because of the potential confusion with getPrimaryLink [19:54:27] Hm [19:54:41] Hmm or are you thinking about things like "what if $this->event->getTitle() is null"? [19:55:07] We should at least have a "Pitfalls" section in the docs that lists these things [19:55:08] Unit testing works: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/bfafe78e709148ccd4a866b3cde60cb876b2518d/client/tests/phpunit/includes/Notifications/PageConnectionPresentationModelTest.php#L125 [19:55:43] RoanKattouw, yeah [19:55:49] Well yes, but that wouldn't have caught the MentionStatus one [19:55:51] I was thinking something a-la linters [19:55:55] EchoLinter :P [19:55:58] Because that returned false only if isBundled() was true [19:56:09] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2624280 (10Mattflaschen-WMF) >>! In T144331#26240... [19:56:14] it won't catch 'em all [19:56:25] but it might help developers ... okay, let's see if I can write proper documentation first [19:56:43] if we think it's beneficial, we can add some generalized unit testing devs can run to validate their new presentation model [19:56:55] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Unexpected type issue in an EchoEventPresentationModel::jsonSerialize - https://phabricator.wikimedia.org/T145229#2624281 (10Dereckson) Furthermore, I've checked Thanks and Flow (thanks Moriel), then [[ https://github.com/search?utf8=%E2%... [19:58:04] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2624302 (10Catrope) What I mean is: we aren't tra... [19:58:06] (03CR) 10Addshore: "I'm guessing in the configuration that this happened in $wgFlowEnableOptInBetaFeature was true however betafeaturs was only loaded in some" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309533 (owner: 10Addshore) [19:59:21] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2624306 (10Mattflaschen-WMF) I think {T2582} (possibly with the article name optional) is closer to the scope of an Out... [19:59:29] 06Collaboration-Team-Triage, 10Notifications, 07Regression, 07Wikimedia-log-errors: Unexpected type issue in an EchoEventPresentationModel::jsonSerialize - https://phabricator.wikimedia.org/T145229#2624307 (10Dereckson) Bug introduced in b4b59ee4. [20:09:50] (03PS1) 10Mooeypoo: Use echo-badge-count message for cross-wiki counts in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309620 (https://phabricator.wikimedia.org/T144707) [20:11:39] (03PS2) 10Mooeypoo: Use echo-badge-count message for cross-wiki counts in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309620 (https://phabricator.wikimedia.org/T144707) [20:13:09] (03CR) 10Catrope: [C: 032] Use echo-badge-count message for cross-wiki counts in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309620 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [20:13:24] (03PS1) 10Catrope: ModerationController: Update count from master, not slave [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309623 [20:14:25] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Display correct number of notifications - https://phabricator.wikimedia.org/T144707#2624390 (10Mooeypoo) a:03Mooeypoo [20:20:22] (03Merged) 10jenkins-bot: Use echo-badge-count message for cross-wiki counts in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309620 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [20:28:30] stephanebisson: Hmm, would you be available to be the contact for SWATting that DB_MASTER moderation patch on Monday at 9am Eastern? [20:28:37] (03PS1) 10Dereckson: Fix MentionStatusPresentationModel::getSecondaryLinks return value [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309630 (https://phabricator.wikimedia.org/T145229) [20:28:43] RoanKattouw: sure [20:28:49] Thanks [20:40:27] (03CR) 10Catrope: [C: 032] Fix MentionStatusPresentationModel::getSecondaryLinks return value [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309630 (https://phabricator.wikimedia.org/T145229) (owner: 10Dereckson) [20:40:46] Dereckson: Whoops, looks like I'm the one that merged the commit introducing return false; there. Thanks for catching it! [20:46:54] (03PS1) 10Mattflaschen: Fix error-handling for handleSubmit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309636 [20:49:25] (03CR) 10Dereckson: "Follow-up: Ic66ca03b6979472495c9b748093d01f8f097d56a" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 (owner: 10WMDE-Fisch) [20:50:16] (03Merged) 10jenkins-bot: Fix MentionStatusPresentationModel::getSecondaryLinks return value [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309630 (https://phabricator.wikimedia.org/T145229) (owner: 10Dereckson) [20:57:26] (03PS1) 10Mooeypoo: "Flatten" wiki notif number in the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309677 (https://phabricator.wikimedia.org/T144707) [21:23:16] mooey|lunch, RoanKattouw, for new signups, I'm seeing the welcome seen (i.e. grey). Same for the NewUserMessage user talk message. [21:24:26] hmmm [21:24:46] I think it might have to do with the fallback in case no seenTime exists [21:24:58] matt_flaschen, if no seenTime exists, we fall back to "now" which makes anything before now "seen" [21:25:15] Which, yes, uhm... causes brand new users to have their initial messages as "seen" [21:25:31] not sure how to fix this, though. If there's no seen time at all, what do I fall back to? [21:25:43] mooeypoo, can I just put it at 0? [21:25:44] Can we set "seen time" for new users as their registration date? [21:25:49] Everything is then unseen until they open it. [21:25:58] Well, wfTimestamp( 0 ) is now, iirc [21:25:59] I.E. the UNIX epoch, ie 1970-ish, i.e. the good old days. [21:26:05] j/k [21:26:36] We were actually considering that, but that also would mean that if something happened in the cache and a user doesn't have a seenTime, they'd fall back to everything is basically unseen [21:27:02] matt_flaschen, I wonder if there's a way to recognize if the user has never actually opened their notifs in the past... because then we could fall back on the user registration date [21:27:16] Wait [21:27:23] matt_flaschen, is there a hook we can use for new user registration? [21:27:27] Yes [21:27:34] But the problem with doing it at registration date is it might be a little racy with signup-time notifications (i.e. NewUserMessage, welcome) [21:27:37] casn we use that to add the seen time preference ..... ? [21:27:50] we fall back on that preference as a ... well... fallback, but we don't use it anymore [21:27:56] this can actually be a decent fix [21:28:01] oh [21:28:03] good point [21:28:26] mooeypoo, I could just do it like an hour before signup, so if another extension registers an earlier LocalUserCreated it's fine. [21:28:46] One sec [21:29:02] hm we should store in the cache directly and not use that preference if possible [21:29:06] we were trying to get rid of it [21:29:14] but if we do use it, we will have to update it, too [21:29:30] Or remove it the first time we set seenTime [21:30:22] mooeypoo, yeah, seen time is at second level granularity, so I'm concerned about notifications in the first second (i.e. triggered by signup themselves). [21:30:31] yeah [21:30:34] mooeypoo, how about initializing seen time to the UNIX epoch, but only at signup time. [21:30:41] setting seentime to an hour earlier sounds like a decent compromise [21:30:54] matt_flaschen, that's basically what we are doing [21:31:11] but that means that until the user SETS the seen time everything is seen [21:31:19] which is what you saw -- the initial messages are all marked as "seen" [21:31:39] mooeypoo, if we set the seen time to UNIX epoch (0) at signup time, nothing is seen, since all notifications received since 1970 are unseen. [21:32:07] oh [21:32:09] RoanKattouw, jmatazzoni___, mooeypoo, also it's not clear to me whether it's better to have nothing seen or everything seen if the cache malfunctions. That's a product question. [21:32:14] ha! I was thinking about this backwards [21:32:32] That's **one** of the product questions about seenTime <3 [21:32:56] mooeypoo, you also confused me because wfTimestamp( 0 ) is not using 0 as a time (i.e. was wondering why that is now) [21:33:26] 0 is just TS_UNIX in that case, and it defaults to now. [21:34:19] matt_flaschen, yeah, instead of wfTimestamp( 0 ) we just need to return 0 [21:34:31] or 0, $format, really [21:34:46] mooeypoo, yeah, patch coming. [21:34:55] matt_flaschen, or rather, $data = wfTimestampNow(); should be $data = 0 [21:35:09] you se it? SeenTime.php #87 is the fallback [21:35:21] mooeypoo, yeah, I saw that, but you said it was intentional. [21:35:31] " [21:35:39] "that also would mean that if something happened in the cache and a user doesn't have a seenTime, they'd fall back to everything is basically unseen" [21:36:10] Like I said, that is a product question (I would think everything unseen is actually better). Do you want to change that? I was suggesting to only do UNIX epoch at signup time, but we could do it both. [21:37:39] oh [21:37:48] mooeypoo, actually you're right, 0 is also current time, even if you pass it in the second position. [21:37:55] 1 is fine though [21:37:57] ha [21:38:02] 1 second after Epoch! [21:38:08] yeah I don't know what to say [21:38:19] jmatazzoni___, RoanKattouw and pau should make a decision on this one [21:38:24] which is the worst/best [21:38:54] HOPEFULLY we're only talking about edge cases where cache is malfunctioning *and* the user has unread notifs (read notifs are always seen) [21:38:56] mooeypoo, I'll put up a patch that does both, but -1 in pending product input. [21:39:01] but I am not sure it's that much of an edge case [21:39:06] * mooeypoo nods [21:39:10] Sounds good [21:46:55] (03PS1) 10Mattflaschen: Fix seen time for new users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309688 [21:48:06] (03CR) 10Mattflaschen: [C: 04-1] "Pending product input on whether "everything seen" or "everything unseen" is better if we "forget" (due to cache getting messed up) their " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309688 (owner: 10Mattflaschen) [21:50:18] OK I agree that the seentime should be initialized to 1970 for new users, but why set it to 1970 when we forget? [21:50:45] (03CR) 10Catrope: [C: 032] "Flatten" wiki notif number in the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309677 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [21:51:06] OK nm I see Matt's commentnow [21:52:07] (03CR) 10Catrope: [C: 04-2] "I changed my mind, this should be unnecessary once we fix the underlying summation-of-capped-counts issue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309677 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [21:52:35] Okay, have a good weekend everyone, see you Monday. [22:08:26] wow I managed to crash Sublime [22:17:01] (03CR) 10Krinkle: [C: 04-1] "Per core patch, the 'wikipage.diff' hook should work fine as-is." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/307317 (https://phabricator.wikimedia.org/T142636) (owner: 10WMDE-leszek) [22:17:44] (03CR) 10Krinkle: "(Reset Roan's +2)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/307317 (https://phabricator.wikimedia.org/T142636) (owner: 10WMDE-leszek) [22:27:58] 06Collaboration-Team-Triage, 10Notifications: Consider requesting more notifications if the popup only has bundles - https://phabricator.wikimedia.org/T145250#2624676 (10Mooeypoo) [22:45:33] (03PS1) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [22:45:39] RoanKattouw, I think those are all instances ^ [22:45:49] Is there anything outside of NotifUser ?? [22:45:59] if so, I might want to make the helper static/public [22:46:02] Probably not? [22:46:05] I couldn't immediately see any [22:46:10] mooeypoo: "wow I managed to crash Sublime" -- Now I have to listen to ska music. [22:46:17] rofl [22:47:21] mooeypoo: Although you should probably cap the summed foreign counts being used in ApiEchoNotifications::makeForeignNotification() [22:47:31] (The summing happens internally in ForeignNotifications I believe) [22:51:29] ... $this->counts[$section] += $data['count']; [22:52:07] meh, but that requires I go over the loop again to cap [22:53:00] bd808: BTW, you should probably know about https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant&type=revision&diff=2234882&oldid=2224256 which I encountered yesterday. I dug down the rabbit hole and it sounds like Vagrant's web site distribution avoids the problem by shipping with an old version of rubygems or something [22:54:23] Details: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818237#21 [22:54:33] mooeypoo: array_map is your friend [22:55:46] RoanKattouw, hang on, I'm still fixing the cap business [22:55:53] found more [22:58:09] (03PS2) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [22:58:34] what the hell [22:58:42] it's still not fixing the page wiki count [22:58:44] how is that possible [22:59:52] GOTCHA! [23:00:06] getNotificationCount has [23:00:08] $count += $this->getForeignCount( $section ); [23:00:09] tsk tsk [23:07:54] (03PS3) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [23:11:39] (03PS4) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [23:14:50] (03PS5) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [23:14:50] ok this works ^ [23:26:50] (03CR) 10Catrope: [C: 04-1] Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [23:27:36] RoanKattouw, -1 is outside the capping range. [23:27:43] I do not recognize this count. [23:39:14] RoanKattouw, some of these comments are a cap out [23:39:23] Cap that. [23:39:27] .... I can keep going. [23:39:41] Why don't you submit some actual comments / code to cap that up [23:40:07] I am capping out of my mind with this commit [23:40:43] Okay, seriously, I just read your gerrit nickname as Caprope [23:40:55] * mooeypoo needs coffee [23:49:34] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 07Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#2624815 (10Jdforrester-WMF) [23:54:14] (03PS6) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) [23:54:20] (03CR) 10Mooeypoo: Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo) [23:57:01] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/309703/ [23:57:06] ^ mobile frontend fix [23:58:44] (03CR) 10Catrope: [C: 04-1] Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309699 (https://phabricator.wikimedia.org/T144707) (owner: 10Mooeypoo)