[00:06:49] (03Merged) 10jenkins-bot: Hide separator when bundled item is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309205 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo) [00:06:52] (03Merged) 10jenkins-bot: Break more rules in break-word so long words can wrap in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309204 (owner: 10Mooeypoo) [01:35:45] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 06Labs, and 3 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2618106 (10Dereckson) @Mattflaschen-WMF So I confirm `$wgDefaultExternalStore` is false... [01:51:15] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2618119 (10Dereckson) @jcrespo Do you prefer to create a new labswiki_flow database for... [01:53:50] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2054159 (10Catrope) >>! In T127792#2618119, @Dereckson wrote: > @jcrespo Do you prefer t... [01:57:00] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2618125 (10Dereckson) [01:57:55] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2054159 (10Dereckson) [02:12:36] (03CR) 10Mattflaschen: [C: 04-1] "Looks great so far." (0316 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [02:23:53] Have a good night, see you tomorrow. [02:35:56] (03CR) 10Catrope: [C: 04-1] Make seen/unseen badge more consistent across wikis (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [03:01:20] (03CR) 10Catrope: Make seen/unseen badge more consistent across wikis (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [03:02:47] (03CR) 10Catrope: [C: 04-1] "AFAICT this would also removetruncation in the popup, where we do want it" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309201 (owner: 10Mooeypoo) [04:49:17] (03PS2) 10Catrope: Add a primary key to the echo_notification table [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) [04:52:04] (03PS3) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [04:58:08] (03PS2) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [04:59:51] (03CR) 10jenkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [05:04:36] (03PS3) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [05:05:44] (03CR) 10Catrope: [C: 04-1] "Still needs SQLite support" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [05:07:49] (03CR) 10jenkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [05:09:05] (03PS4) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [05:24:37] 06Collaboration-Team-Triage, 10Flow: Flow wikitext area doesn't respect text formatting option (monospace, sans-serif, etc.) - https://phabricator.wikimedia.org/T95831#2618296 (10Catrope) Thanks to {274bcd2fb4ee3475d6a4912b2447c4d59e78d763}, this will be fixed once {T145015} is fixed. [06:31:43] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 10DBA, and 5 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2618336 (10jcrespo) >>! In T127792#2618122, @Catrope wrote: >>>! In T127792#2618119, @De... [07:45:13] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey and distribute it - https://phabricator.wikimedia.org/T144547#2618375 (10Trizek-WMF) [08:55:08] (03CR) 10Addshore: "Merge date still pending (either this week or next week)" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [08:56:58] (03CR) 10Addshore: "Per the discussion we just had in the meeting:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [12:18:32] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 13Patch-For-Review: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts with Wikibase enabled - https://phabricator.wikimedia.org/T144727#2618913 (10Addshore) See also on GitHub: https://github.com/wmde... [12:18:43] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 13Patch-For-Review, 15User-Addshore: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts with Wikibase enabled - https://phabricator.wikimedia.org/T144727#2618914 (10Addshore) [12:18:57] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 13Patch-For-Review, 15User-Addshore: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts with Wikibase enabled - https://phabricator.wikimedia.org/T144727#2608392 (10Addshore) p:05Triage>03Low [12:36:46] 06Collaboration-Team-Triage, 10Flow: Flow wikitext area doesn't respect text formatting option (monospace, sans-serif, etc.) - https://phabricator.wikimedia.org/T95831#2619015 (10Trizek-WMF) ...and would it be possible to fix that? :) [12:45:13] (03PS7) 10WMDE-Fisch: Send mentions when editing multiple sections in between sections. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) [12:47:21] (03PS1) 10WMDE-Fisch: Fix missing doc part for mention status global [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309300 [13:15:29] (03PS8) 10WMDE-Fisch: Send mentions when editing multiple sections in between sections. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) [13:18:11] (03PS6) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [13:18:27] (03CR) 10Sbisson: [WIP] Remove etp_user (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [13:19:05] (03PS2) 10Jakob: Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) [13:20:18] (03CR) 10Jakob: Send notification for mentions on changes (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [13:24:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [14:15:58] (03PS7) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [14:20:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [14:34:39] (03PS8) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [14:44:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Include goodfaith model information in ORES review tool - https://phabricator.wikimedia.org/T137966#2385407 (10Halfak) [14:45:39] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2619335 (10SBisson) a:05Catrope>03SBisson [14:46:00] (03PS9) 10Sbisson: Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [14:46:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2619337 (10Halfak) [14:48:07] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2614690 (10Halfak) [14:48:27] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2614690 (10Halfak) [14:49:19] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2619346 (10Halfak) p:05Triage>03Low [14:50:31] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2614690 (10Halfak) I triaged this "low" for #revision-scoring-as-a-service because it'... [14:58:12] (03CR) 10Mattflaschen: [C: 032] Fix missing doc part for mention status global [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309300 (owner: 10WMDE-Fisch) [15:04:48] (03Merged) 10jenkins-bot: Fix missing doc part for mention status global [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309300 (owner: 10WMDE-Fisch) [15:28:21] (03CR) 10Jcrespo: [C: 031] "Looks good, remember to request it on a ticket for DBAs with #blocked-on-schema-change when it is ready to be deployed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) (owner: 10Catrope) [15:38:06] (03CR) 10WMDE-Fisch: [C: 04-1] "Merge date still pending (either this week or next week)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [15:51:28] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2619522 (10Mattflaschen-WMF) [15:54:24] (03PS4) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) [15:59:06] (03CR) 10jenkins-bot: [V: 04-1] Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [16:04:40] (03PS5) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) [16:05:05] (03CR) 10Mattflaschen: "Minor update for IMessagePoster signature change." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [17:56:50] (03CR) 10Catrope: "@Jcrespo: Yup, I'm lining up a bunch of things so I can hand them all off together." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) (owner: 10Catrope) [18:20:14] mooeypoo, GENDER works fine with MassMessage (https://www.mediawiki.org/wiki/User_talk:Mattflaschen-WMF/Sandbox , https://www.mediawiki.org/wiki/User_talk:Gender_test_2016-09-08_Female/Sandbox ), but not for Flow, due to a bug I forgot about, T109373 . [18:20:15] T109373: Flow's usage of the page name magic words is different from wikitext talk pages - https://phabricator.wikimedia.org/T109373 [18:21:42] mooeypoo, if it's a message to you on your user talk page, it should be written as to the female gender, regardless of who is reading it, right? [18:23:22] Getting lunch [18:38:59] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Mention-Notification, 06TCB-Team, and 2 others: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2605228 (10Etonkovidova) Checked in betalabs - FlowMention of anon users is not allowed ('Insert' button stays grey). No... [18:56:40] matt_flaschen, yeah if GENDER works in mass message, I'd expect it to display the message in female form for me (I set up my user as female) --- BUT I just realized I'm stupid. I didn't get this message to my user account, I got it in the Flow support page (Wikipedia:Flow) which I'm following. [18:57:16] matt_flaschen, in that case, I am mildly disappointed from the translators, who should've done a better job making the "default" male form a bit more general, but that's not the system's fault really [18:59:03] general question stephanebisson matt_flaschen RoanKattouw -- if we change a wg variable (getting rid of wgEchoSeenTime and instead using wgEchoSeenTimeSources that has a different structure, too) -- do we need to have a deprecation process for that with supporting backwards compatibility for a while, etc? [18:59:35] Or do we just change it in the front end and are done with it? I can see how *maybe* some gadgets may use it but I don't think there are any? [18:59:35] mooeypoo: In this case it's probably best to keep the old one around for one wmf/* cycle [19:00:00] RoanKattouw, okay, if that's the case, then I will just add a comment that we should remove it next cycle? [19:00:06] I don't see it as a public API or anything, but if we keep the old var around then the simultaneous server+client change won't break anything [19:00:13] (JS updates are not quite instantaneous) [19:00:27] And by "cycle" I mean "week" here :) [19:00:35] yeah [19:01:09] matt_flaschen: That bug was recently brought to my attention because Anna Koval (ex-WMF employee) pinged me on outreachwiki about one of their welcome templates not working in Flow [19:02:11] RoanKattouw, ok I added a comment to the old/new wg vars; just saying since you raised this in code review and I wasn't entirely sure what you mean in terms of how to actually handle it [19:02:15] a comment is enough? [19:15:34] (03CR) 10Mooeypoo: Make seen/unseen badge more consistent across wikis (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:15:46] (03PS7) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [19:17:45] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2620511 (10demon) >>! In T144534#2613087, @Catrope wrote: > I think {e1a276fe3dc9c4e8a68b744f6d8... [19:20:23] mooeypoo: A comment and then hopefully remembering to actually remove it next week [19:21:03] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2620529 (10Catrope) >>! In T144534#2620511, @demon wrote: >>>! In T144534#2613087, @Catrope wrot... [19:21:26] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2620534 (10Catrope) Or, wait, no we don't, we just need the CachedBagOStuff instance to be static. [19:24:55] (03PS1) 10Chad: Use static cache for times so it works across instances of SeenTime [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309378 (https://phabricator.wikimedia.org/T144534) [19:28:10] mooeypoo, yeah, it sounds like there should be two MassMessage delivery lists. This is a little bit more work for the translators, but the MassMessage part just requires splitting by whether it's user talk. [19:29:08] mooeypoo, one could be for general pages like Wikipedia:Flow (I don't know if you can target for the current reader for wikitext, but I know you can't for Flow due to another longstanding Flow issue). So those would use the general form tricks you mentioned ("Although this is written in the male voice..."). [19:29:27] And then the other would be for user talk, and that requires fixing the Flow bug. In the meantime, we could use the general voice for both. [19:29:38] (03PS8) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [19:29:55] matt_flaschen, yeah we usually try to, but in this case it seemed to have failed [19:31:04] mooeypoo, do you want to follow up and talk to the translators? [19:31:22] matt_flaschen, I'll make a note to ask amir about it [19:31:41] RoanKattouw, should I add T109373 to our quarter? [19:31:41] T109373: Flow's usage of the page name magic words is different from wikitext talk pages - https://phabricator.wikimedia.org/T109373 [19:34:01] (03PS9) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [19:34:05] (03CR) 10jenkins-bot: [V: 04-1] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:36:33] (03CR) 10Catrope: [C: 032] Use static cache for times so it works across instances of SeenTime [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309378 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [19:36:51] mooeypoo, re gadgets, you can ask RoanKattouw or I to grep for that in production (mwgrep). There are none in this case. [19:37:45] * mooeypoo nods [19:37:48] thanks matt_flaschen [19:37:58] (03CR) 10jenkins-bot: [V: 04-1] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:40:30] (03PS10) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [19:41:00] 06Collaboration-Team-Triage, 10Flow: Flow's usage of the page name magic words is different from wikitext talk pages - https://phabricator.wikimedia.org/T109373#2620648 (10Mattflaschen-WMF) [19:41:05] (03CR) 10Catrope: Make seen/unseen badge more consistent across wikis (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:41:22] (03CR) 10Catrope: [C: 032] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:43:22] (03Merged) 10jenkins-bot: Use static cache for times so it works across instances of SeenTime [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309378 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [19:44:52] (03CR) 10jenkins-bot: [V: 04-1] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:46:43] (03PS1) 10Chad: SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309380 (https://phabricator.wikimedia.org/T144534) [19:46:46] (03PS1) 10Chad: Use static cache for times so it works across instances of SeenTime [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309381 (https://phabricator.wikimedia.org/T144534) [19:47:13] 06Collaboration-Team-Triage, 10MediaWiki-Watchlist, 07Regression: [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' - https://phabricator.wikimedia.org/T145125#2620690 (10Etonkovidova) [19:48:22] (03Merged) 10jenkins-bot: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [19:49:08] 06Collaboration-Team-Triage, 10MediaWiki-Watchlist, 07Regression: [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' - https://phabricator.wikimedia.org/T145125#2620690 (10Mattflaschen-WMF) On what wiki? [19:50:08] bd808, is there a way to have a catch-all log file that includes messages from channels that aren't specifically configured? [19:50:11] Wondering for Vagrant. [19:50:44] (03CR) 10Chad: [C: 032] SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309380 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [19:50:51] matt_flaschen: yes, and vagrant already has it [19:51:06] check logs/mediawiki-loginwiki-debug.log [19:51:20] (03CR) 10Chad: [C: 032] Use static cache for times so it works across instances of SeenTime [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309381 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [19:51:22] I guess the default wiki is mediawiki-wiki-debug.log [19:52:00] Thanks, bd808 [19:56:36] (03Merged) 10jenkins-bot: SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309380 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [19:59:34] (03Merged) 10jenkins-bot: Use static cache for times so it works across instances of SeenTime [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309381 (https://phabricator.wikimedia.org/T144534) (owner: 10Chad) [20:07:22] legoktm, is T122113 related to T46787 ? [20:07:22] T46787: Allow excluding pages from the page links notifications - https://phabricator.wikimedia.org/T46787 [20:07:23] T122113: Get rid of LinksUpdate::setTriggeringUser() hacks - https://phabricator.wikimedia.org/T122113 [20:07:39] (just wondering if I should add a SeeAlso) [20:10:01] quiddity: no [20:10:08] ty [20:14:41] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 4 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2620817 (10demon) Already deployed with wmf.18. Fixed the problem. [20:31:49] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10VisualEditor, 13Patch-For-Review, and 2 others: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2448561 (10Jdforrester-WMF) Seems fixed from my testing too? [20:46:19] hey RoanKattouw! got time for a quick pm? :) [20:47:17] addshore: sure [20:58:39] (03CR) 10Addshore: "To be merged on the 14th of Sept or after." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [20:58:49] (03CR) 10Addshore: [C: 04-2] "To be merged on the 14th of Sept or after." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [21:34:31] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15), 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2279822 (10Mooeypoo) a:05Catrope>03Mooeypoo [21:37:25] matt_flaschen, how do I run the update script from vagrant? Just mwscript update.php inside the shell? [21:41:39] * mooeypoo found a bug in production :\ [21:41:48] RoanKattouw, are you around? [21:44:46] mooeypoo, there are multiple wikis, so: [21:44:53] foreachwiki update.php --quick [21:45:09] mooeypoo, sorry, I was deep in PHPUnit mode, didn't see the IRC indicator earlier. [21:45:14] whats foreachwiki ? [21:45:23] oh that's the command [21:45:25] mooeypoo, it runs it for all wikis Vagrant as set up. [21:45:28] has set up [21:45:29] I thought you say I should do this for each wiki :P [21:45:36] mooeypoo, well, that too. :) [21:45:39] +1 awesome. thanks :) [21:46:36] mooeypoo, and let me know if you need a second set of eyes for the prod bug. [21:48:13] matt_flaschen, RoanKattouw just saw it and is going to check the db info for my user [21:48:19] it's weird, but i think it's known(?) [21:48:33] In Mediawiki.org I see I have 2 unreads from xwiki - hewiki and metawiki [21:48:45] except, consistently I open my xwiki bundle and only see stuff from hewiki. The metawiki one is empty [21:48:54] and when I go to metawiki itself I have no notifications [21:49:02] not just no **unread** notifications -- no notifications at all [21:49:05] Noted, sounds like canRender/moderation. [21:49:10] yep [21:49:30] Except I can't "fix" it with the hack of marking something unread/read in the wiki it happened in (metawiki) because I have 0 notifications there [21:49:46] so RoanKattouw is going to check into the values of the table to see what notifs I had [22:11:54] Hmm I think I found it [22:12:00] Looks like her 10th edit was to a page that I deleted [22:12:19] So her thank-you-edit notification for her 10th edit was marked as deleted [22:13:57] One thing we're now doing is make thank-you-edit renderable without a title, which seems like a good idea [22:14:13] But it looks like echo_unread_wiki wasn't updated when this event was marked as deleeted [22:15:43] (03PS1) 10Mooeypoo: Make 'Edit threshhold' notif appear regardless of title existence [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 [22:15:47] RoanKattouw, matt_flaschen ^ [22:21:10] (03PS1) 10Esanders: Remove unused dependency on ext.visualEditor.standalone [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309463 [22:21:36] (03CR) 10jenkins-bot: [V: 04-1] Make 'Edit threshhold' notif appear regardless of title existence [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 (owner: 10Mooeypoo) [22:24:12] Reviewing [22:26:21] According to RoanKattouw this should also prevent that type of notif from being moderated [22:26:50] I'm mildly worried about the targetpage being another path to moderation/deletion but it seems it wasn't in this case [22:27:53] mooeypoo, yeah, targetpage is not used here. Testing now. [22:28:02] (03PS1) 10Catrope: ModerationController: Update count from master, not slave [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309465 [22:28:09] So this is embarassing ---^^ [22:28:22] matt_flaschen, can you do me a favor and post something on my talk page? I want a notification on meta so I can get that pesky no-notification to disappear by faking a refresh of that table [22:28:27] All those reports of wrong notif counts were onto something [22:28:30] https://meta.wikimedia.org/wiki/User_talk:MSchottlender-WMF <-- just put 'foo' or something [22:28:45] just want to force the system to recalculate the counters [22:30:05] Done [22:30:10] thanks! [22:30:16] let's see if I still have ghost xwiki notifs [22:30:40] nope! Solved! \o/ thanks matt_flaschen [22:30:53] haha nice message :D [22:32:18] What happened to the +2 button on Gerrit" [22:32:20] ? [22:32:31] (03CR) 10jenkins-bot: [V: 04-1] ModerationController: Update count from master, not slave [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309465 (owner: 10Catrope) [22:32:46] matt_flaschen, it only appears after jenkins +1s and if you're on the latest patchset [22:33:08] eh are these fake selenium fails again :\ [22:33:21] (03CR) 10Mattflaschen: [C: 032] "I wish core had the Flow feature that all future DB connections would be master after you accessed a master connection." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309465 (owner: 10Catrope) [22:33:27] (03CR) 10Catrope: [C: 032] Remove unused dependency on ext.visualEditor.standalone [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309463 (owner: 10Esanders) [22:33:30] (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 (owner: 10Mooeypoo) [22:34:08] matt_flaschen: It only appears once Jenkins votes Verified I think [22:34:17] So if you view the commit too early, it won't be there yet [22:34:20] Which it didn't on both changes [22:34:24] selenium fails [22:34:33] look like they're unrelated to the actual commit [22:39:25] mooeypoo, after deleting it Special:Notifications is being weird, and I think it's not rendering. Maybe you have to override canRender to true. Give me a second to confirm. [22:39:40] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests - https://phabricator.wikimedia.org/T145144#2621272 (10Jdlrobson) [22:40:00] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests - https://phabricator.wikimedia.org/T145144#2621285 (10Jdlrobson) p:05Triage>03Unbreak! [22:40:15] (03Merged) 10jenkins-bot: ModerationController: Update count from master, not slave [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309465 (owner: 10Catrope) [22:41:03] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621290 (10Jdlrobson) [22:41:55] ^ RoanKattouw, apparently Beta cluster is completely broken, looking now. [22:44:36] mooeypoo, never mind, I didn't have your branch checked out. Will test properly after the Beta cluster thing. [22:46:07] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621311 (10Jdlrobson) [22:46:13] (03Merged) 10jenkins-bot: Remove unused dependency on ext.visualEditor.standalone [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309463 (owner: 10Esanders) [22:46:41] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621272 (10Jdlrobson) I can't replicate this locally only on beta cluster. Might be config/user specific? [22:47:33] Hmm we might have just broken Echo completely [22:47:33] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621314 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [22:47:34] ? [22:47:52] matt_flaschen: I got it [22:48:18] RoanKattouw, great. Also, do you have your ssh keys back yet? I can't ssh to deployment-fluorine. [22:48:29] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621272 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Catrope [22:48:46] Yes I do [22:48:52] (03PS1) 10Catrope: Follow-up 00e0b9f45d8: fix typo in method name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309474 [22:48:57] RoanKattouw, are you able to ssh into it? [22:48:58] Oh, bug # [22:49:19] (03PS2) 10Catrope: Follow-up 00e0b9f45d8: fix typo in method name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309474 (https://phabricator.wikimedia.org/T145144) [22:49:50] I don't have my .ssh/config set up for labs yet, hold on [22:50:03] (03CR) 10Mattflaschen: [C: 032] Follow-up 00e0b9f45d8: fix typo in method name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309474 (https://phabricator.wikimedia.org/T145144) (owner: 10Catrope) [22:50:14] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 13Patch-For-Review: Echo breaking MobileFrontend unit tests / causing fatals - https://phabricator.wikimedia.org/T145144#2621343 (10Catrope) Sorry, this was because we only just merged a patch in Echo that had a typo in a method name. [22:50:19] Crap, I have to be at the dentist in 10 mins [22:50:21] Totally forgot [22:50:24] matt_flaschen: Sorry I gotta go [22:50:35] RoanKattouw, that's alright, I'll follow up. [22:55:56] (03Merged) 10jenkins-bot: Follow-up 00e0b9f45d8: fix typo in method name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309474 (https://phabricator.wikimedia.org/T145144) (owner: 10Catrope) [23:01:50] (03PS2) 10Mattflaschen: Make 'Edit threshhold' notif appear regardless of title existence [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 (owner: 10Mooeypoo) [23:02:11] what tha [23:02:36] ? [23:03:00] ok, https://gerrit.wikimedia.org/r/#/c/308782/10/Hooks.php was merged, and yet line 149 shows getGlobalMaxSeenTime which is A TYPO (OOPS!!!) and is why my master is crashing [23:03:07] but locally (I'm on master, pulled) I don't see it! [23:03:14] I see getGlobalSeenTime which is CORRECT [23:03:26] but my master is **failing** with Call to undefined method MWEchoNotifUser::getGlobalMaxSeenTime() [23:04:17] mooeypoo, did you grep for getGlobalMaxSeenTime ? Are you on the right branch? I don't think this needs a hard refresh, but not sure. [23:04:28] My local EchoHooks::onOutputPageCheckLastModified line #1050 I have $modifiedTimes[ 'notifications-seen' ] = $notifUser->getGlobalSeenTime(); [23:04:33] which is correct [23:04:37] I did, no results [23:04:47] but master **is** failing [23:04:55] the merged patch **does** have an error in it [23:04:57] what the hell [23:05:04] matt_flaschen, can you check if your master is failing!? [23:05:11] mooeypoo, yeah, one sec. [23:05:25] It was a second ago before the fix (or maybe just on the threshold patch, on top of before-the-fix). [23:05:41] O.o [23:05:53] How do I fix it if I can't find the offending code O.o [23:06:41] This is ridiculous [23:06:46] mooeypoo, latest master works for me. [23:06:51] what.. [23:07:03] mooeypoo, 48ca4ae fails, latest master (6d0583a) succeeds. [23:07:06] mooeypoo, can you do git status? [23:07:23] okay, (1) How the hell does it not work for me, (2) How the hell do we have a merged fix with A TYPO IN IT that doesn't exist in master [23:07:25] did someone fix this [23:07:44] wait, yes! RoanKattouw fixed it [23:07:48] https://gerrit.wikimedia.org/r/#/c/309474/2/Hooks.php [23:07:58] ok, first off -- **oops**. [23:08:02] Second, wtf. [23:08:13] mooeypoo, I know he fixed it, I just merged it, but you said you had latest master. [23:08:17] I do [23:08:20] git status says latest [23:08:42] git log has 'Merge "Follow-up 00e0b9f45d8: fix typo in method name"' [23:08:45] as top commit [23:08:54] mooeypoo, yeah, and no dirty files? [23:08:56] Let me clear all cache [23:08:57] no [23:09:09] I hard-refreshed a bunch of times, too [23:09:15] let me purge cache again [23:09:31] mooeypoo, do you want to do a screen share? [23:09:50] let me see if a cache purge helps [23:09:56] I'm convincing chrome to cooperate [23:10:01] THERE! [23:10:08] stupid browser... [23:10:09] it works now [23:10:50] That was so confusing - especially since I didn't notice RoanKattouw already fixed that typo [23:10:56] I was ready to quickly fix it out of sheer shame [23:10:57] :P [23:11:15] Chrome is too aggressive about caching sometimes. mooeypoo, do you know 'Empty cache and hard reload'? [23:11:25] I know hard reload [23:11:34] which one is the one where you also empty cache? [23:11:58] mooeypoo, if you open the dev console, then right-click refresh, it will show it. [23:15:36] I don't have refresh on right-click? [23:15:51] ok here it is [23:15:57] my computer got stuck there for a moment :\ [23:16:05] ooh! that only appears if dev console is open?? [23:16:20] mooeypoo, yep. [23:16:27] ha! [23:16:28] thanks! [23:16:34] No problem. [23:16:37] I knew of the hard refresh, but didn't know of the cache one [23:16:38] that's awesome [23:18:55] (03CR) 10Mattflaschen: [C: 032] "Works locally" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 (owner: 10Mooeypoo) [23:26:58] (03Merged) 10jenkins-bot: Make 'Edit threshhold' notif appear regardless of title existence [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309462 (owner: 10Mooeypoo) [23:35:41] I have my own WTF with PHPUnit now, but I'll track it down. [23:45:55] matt_flaschen, to test the bidi isolation of usernames I wanted to create a Moo (WMF) on my local wiki but WMF is blacklisted so instead of thinking of a smart alternative,like, say, *anything inside parenths*, I went with Moo (WTF) [23:46:08] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-RC-Page, 10Editing-UX-Research: Usability and concept testing for ORES filters and improved overall filtering on Recent Changes page - https://phabricator.wikimedia.org/T145153#2621560 (10jmatazzoni) [23:46:09] which then presented a problem with screenshotting that and putting it as an example in tickets