[00:08:38] ok I'm also off... see you guys tomorrow [00:23:26] (03PS1) 10MarkAHershberger: Drop and re-create the index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308912 (https://phabricator.wikimedia.org/T110446) [01:11:53] (03CR) 10Catrope: [C: 032] Drop and re-create the index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308912 (https://phabricator.wikimedia.org/T110446) (owner: 10MarkAHershberger) [01:16:02] 06Collaboration-Team-Triage, 10Thanks, 10MediaWiki-Logging: Add revision ID as a thank log parameter - https://phabricator.wikimedia.org/T144882#2613457 (10Tjlsangria) [01:16:41] 06Collaboration-Team-Triage, 10Thanks, 10MediaWiki-Logging: Add revision ID as a thank log parameter - https://phabricator.wikimedia.org/T144882#2613470 (10Tjlsangria) [01:19:03] (03Merged) 10jenkins-bot: Drop and re-create the index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308912 (https://phabricator.wikimedia.org/T110446) (owner: 10MarkAHershberger) [01:37:19] quiddity: Wasn't there some sort of privacy concern raised over https://phabricator.wikimedia.org/T144882 in the past? Is that bug a duplicate? [01:38:22] RoanKattouw, yup https://phabricator.wikimedia.org/T51087 [01:40:34] RoanKattouw: they did say configurable though, so I think that's reasonable [01:41:52] Yeah, although the way they suggest it it's only configurable by omitting/including a message param [01:42:06] Which non-admins can trivially circumvent using qqx [01:42:29] we could put it behind a config setting [01:42:33] So it might need a $wg depending on what the concerns were [02:30:55] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596519 (10Mattflaschen-WMF) As discussed in the... [02:37:01] (03PS1) 10Catrope: Add method to get local unread notifications in the manager [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/308923 (https://phabricator.wikimedia.org/T141404) [02:52:33] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2613595 (10Mattflaschen-WMF) [02:52:36] 06Collaboration-Team-Triage, 10Thanks, 10MediaWiki-Logging: Add revision ID as a thank log parameter - https://phabricator.wikimedia.org/T144882#2613597 (10Mattflaschen-WMF) [02:52:39] 06Collaboration-Team-Triage, 10Thanks, 10MediaWiki-Logging: Add revision ID as a thank log parameter - https://phabricator.wikimedia.org/T144882#2613457 (10Mattflaschen-WMF) [02:52:41] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#539465 (10Mattflaschen-WMF) [02:54:02] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#539465 (10Mattflaschen-WMF) There was some discussion on IRC that this could perhaps be allowed if a certain $wg was set (WMF product... [03:32:35] Have a good night. See you tomorrow. [09:30:15] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2614026 (10Trizek-WMF) [09:35:12] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2614050 (10Trizek-WMF) [10:38:13] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2614161 (10Tjlsangria) I've written a hack that doesn't require you to set a $wg; it would just be a 5::revid parameter that you coul... [10:40:27] 06Collaboration-Team-Triage, 10Flow, 10MassMessage: MassMessage sends notifications to message sender when that message is signed and posted on a Flow board - https://phabricator.wikimedia.org/T144754#2614164 (10Trizek-WMF) On my way to distribute the survey about Flow, I'm receiving notifications and emails... [11:16:18] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2614211 (10Trizek-WMF) [11:56:05] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2614240 (10Trizek-WMF) [12:10:43] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2614253 (10Lea_WMDE) @Pine We are also currently developing {T139962}, which creates two new opt-in features in your notificati... [12:31:02] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2614330 (10Trizek-WMF) [14:30:01] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Notify users when a page on their watchlist has been damaged - https://phabricator.wikimedia.org/T144926#2614690 (10Halfak) [15:27:34] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2615010 (10Trizek-WMF) [15:31:31] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey and distribute it - https://phabricator.wikimedia.org/T144547#2615052 (10Trizek-WMF) [15:31:51] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2615053 (10Trizek-WMF) [16:07:58] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey and distribute it - https://phabricator.wikimedia.org/T144547#2615277 (10Trizek-WMF) [16:46:30] RoanKattouw: mooeypoo Special:Notifications page does not have fixed width in testwiki wmf.18 :( [16:50:09] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2615441 (10Mattflaschen-WMF) >>! In T51087#2614161, @Tjlsangria wrote: > I've written a hack that doesn't require you to set a $wg; i... [16:56:37] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Special:EnableFlow fails for an existing page - https://phabricator.wikimedia.org/T144618#2615462 (10aaron) 05Open>03Resolved [17:09:57] (03PS2) 10Mooeypoo: [wip] Check if there are unseen notifs in any wiki for the badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 [17:10:09] (03CR) 10jenkins-bot: [V: 04-1] [wip] Check if there are unseen notifs in any wiki for the badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (owner: 10Mooeypoo) [17:15:34] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey and distribute it - https://phabricator.wikimedia.org/T144547#2615543 (10Trizek-WMF) [17:33:31] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review, and 2 others: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2615768 (10Etonkovidova) Checked in betalabs for - the screenshots show the icon "Mark as read" and... [17:46:28] (03PS1) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [17:48:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [17:50:25] (03PS2) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [17:52:41] RoanKattouw: ^ this is the patch. I'll investigate a few more things and ping you later with my questions. [17:57:06] CREDIT showcase in 3 minutes in #wikimedia-office. This will include the Public Event Streams thing RoanKattouw mentioned. [17:57:32] https://www.youtube.com/watch?v=rfBQ6H14_SM [18:03:57] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/308923 (https://phabricator.wikimedia.org/T141404) (owner: 10Catrope) [18:13:56] (03Merged) 10jenkins-bot: Add method to get local unread notifications in the manager [extensions/Echo] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/308923 (https://phabricator.wikimedia.org/T141404) (owner: 10Catrope) [18:29:56] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10VisualEditor, 13Patch-For-Review, and 2 others: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2616178 (10Etonkovidova) Checked in betalabs - no such err... [18:46:05] (03PS3) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [18:49:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [19:01:53] 06Collaboration-Team-Triage, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#2616294 (10Catrope) >>! In T51087#2615441, @Mattflaschen-WMF wrote: >>>! In T51087#2614161, @Tjlsangria wrote: >> I've written a hack... [19:12:26] RoanKattouw: matt_flaschen a funny thing happened to betalbs - the content of the pages is not displayed; Flow pages do not have topics (but they are still Flow board pages) [19:13:02] and 'View history' is not displayed hmm... [19:14:09] RoanKattouw: some db issues? [19:38:26] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Mobile, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): [mobile] Special:Notification page has horizontal scrolling - https://phabricator.wikimedia.org/T141949#2616412 (10Etonkovidova) Checked in betalabs iPhone 6s iOS 9.3.2) - t... [19:38:29] etonkovidova: Never mind, Stephane's patch can't be responsible for that [19:38:41] etonkovidova: Can you link to an example of where this is broken? [19:42:59] https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow looks right. [19:43:25] Until I post to it. [19:43:27] That's not good. [19:45:13] RoanKattouw: go to any Flow page or, in fact, go to any page - the content is gone [19:46:53] Wow [19:47:03] I posted a new topic but upon refresh it just disappears [19:47:30] https://en.wikipedia.beta.wmflabs.org/wiki/Newdisappeartest [19:47:34] This is bigger than just Flow [19:47:45] matt_flaschen: Have you guys done something weird with external store or something? [19:48:13] Viewing any page that has been edited recently shows a missing revision error [19:48:24] I'd bisect this but I don't have a local install right now [19:48:29] But this is BAD [19:48:49] RoanKattouw, no, I haven't done anything with ExternalStore recently. Thanks for checking the non-Flow, that should simplify tracking it down. [19:49:13] They could have broken it on Beta, though. [19:49:25] I don't think there's a relationship with creation date [19:49:25] https://en.wikipedia.beta.wmflabs.org/wiki/Echo_test_page_42780310767534588525041558209509132827 [19:49:29] was created on the 2nd of Sept [19:49:34] And it's also a rev not found [19:49:39] So I think it's just failing to find all revision data [19:50:48] Most recent MW core commit: aa0f6ea Revision: Simplify loadText() with nested getWithSetCallback [19:51:01] If that doesn't sound suspicious I don't know what does [19:53:01] RoanKattouw, yeah, and ES itself is fine: [19:53:03] echo Revision::decompressRevisionText( ExternalStore::fetchFromURL( 'DB://cluster1/23260' ), [ 'gzip' ] ); [19:53:08] That's from Newdisappeartest. [19:54:15] RoanKattouw, bisecting to confirm, sounds plausible. [19:54:28] I've told Aaron in -dev [19:54:52] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2529364 (10Etonkovidova) Checked in betalabs - "mw-echo-ui-crossWikiNotificationItemWidget-separator" is g... [19:57:10] (03PS4) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [20:01:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [20:04:00] (03PS5) 10Sbisson: [WIP] Remove etp_user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) [20:11:03] RoanKattouw: A few questions inline: https://gerrit.wikimedia.org/r/#/c/309051/ when you have some time. Thanks! [21:17:33] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Clean up HTML output and CSS for Special:Notifications - https://phabricator.wikimedia.org/T129172#2097139 (10Etonkovidova) Checked Special:Notifications (js and no-js) for regression i... [22:04:38] seen and unseen will be the unend of unme [22:05:28] originallyUnseen = apiData.hasUnseen; but xwikiBundle.seen = !originallyUnseen [22:05:40] Negative of negative is positive...ly confusing. [22:20:16] (03PS3) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [22:20:27] (03CR) 10jenkins-bot: [V: 04-1] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [22:23:23] (03PS4) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [22:25:55] (03PS1) 10Esanders: Fix font family and size for wikitext input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309192 [22:28:52] (03CR) 10jenkins-bot: [V: 04-1] Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [22:33:57] (03PS5) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [22:41:15] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596519 (10Etonkovidova) > It intentionally does... [22:43:40] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2617524 (10Catrope) >>! In T144331#2617504, @Eton... [22:44:12] (03CR) 10Catrope: [C: 032] Fix font family and size for wikitext input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309192 (owner: 10Esanders) [22:47:17] (03CR) 10Esanders: "There's another textarea on the no-JS form, but I'm not touching handlebars..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309192 (owner: 10Esanders) [22:47:45] (03PS1) 10Esanders: Match new topic font size to heading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309195 [22:48:48] matt_flaschen: Could you restart Parsoid in beta? I think that might fix the transclusion preview problems we're seeing, which I suspect to be holdovers from the revision text fetching bug [22:50:19] (03CR) 10Catrope: "Yeah don't worry about it, the handlebars version is theoretically mostly unused except maybe for no-JS." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309192 (owner: 10Esanders) [22:50:53] (03CR) 10Catrope: [C: 032] Match new topic font size to heading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309195 (owner: 10Esanders) [22:51:17] (03Merged) 10jenkins-bot: Fix font family and size for wikitext input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309192 (owner: 10Esanders) [22:58:33] (03Merged) 10jenkins-bot: Match new topic font size to heading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/309195 (owner: 10Esanders) [22:59:24] (03PS6) 10Mooeypoo: Make seen/unseen badge more consistent across wikis [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (https://phabricator.wikimedia.org/T134855) [23:01:15] RoanKattouw, re Parsoid, yeah, but do you know how? [23:01:28] Not offhand, sorry :| [23:03:31] No problem, I'll track it down. [23:18:44] (03PS1) 10Mooeypoo: Remove js-truncation of descriptions in desktop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309201 [23:31:54] (03PS1) 10Mooeypoo: Break more rules in break-word so long words can wrap in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309204 [23:32:42] (03PS2) 10Mooeypoo: Break more rules in break-word so long words can wrap in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309204 [23:43:46] (03CR) 10Catrope: [C: 04-1] [WIP] Remove etp_user (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309051 (https://phabricator.wikimedia.org/T143959) (owner: 10Sbisson) [23:44:21] (03PS1) 10Mooeypoo: Hide separator when bundled item is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309205 (https://phabricator.wikimedia.org/T142260) [23:44:32] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2617875 (10Mooeypoo) Whoops, my bad. Fix on the way. [23:55:07] uhm, oops. RoanKattouw / matt_flaschen, can you review this one? https://gerrit.wikimedia.org/r/#/c/309205/ [23:57:56] (03CR) 10Catrope: [C: 032] Hide separator when bundled item is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309205 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo) [23:58:20] (03CR) 10Catrope: [C: 032] Break more rules in break-word so long words can wrap in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/309204 (owner: 10Mooeypoo)