[00:23:40] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts - https://phabricator.wikimedia.org/T144727#2608392 (10Paladox) I think you may get that error if you doint have mediawiki core installed too. [00:23:49] (03CR) 10Paladox: [C: 031] Make sure $wgResourceModules exists in Resouces.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308541 (https://phabricator.wikimedia.org/T144727) (owner: 10Addshore) [00:31:49] (03CR) 10Paladox: "I belive he may have used this without mediawiki/core." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308541 (https://phabricator.wikimedia.org/T144727) (owner: 10Addshore) [01:49:09] 06Collaboration-Team-Triage, 10Notifications: Page links notifications sent without apparent cause - https://phabricator.wikimedia.org/T144785#2610094 (10Quiddity) [01:51:13] Reminder to self. Ask about this tomorrow ^. [07:30:18] (03CR) 10WMDE-Fisch: [C: 031] Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [07:50:37] 06Collaboration-Team-Triage, 10Notifications: Page links notifications sent without apparent cause - https://phabricator.wikimedia.org/T144785#2610094 (10Sjoerddebruin) It is the template, I can remember receiving these during edit wars on templates. :( Maybe it should be mentioned in the notification message... [09:29:26] (03CR) 10Addshore: [C: 04-2] "Looks good, but not to be merged until mention failures / success have been deployed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308562 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [10:00:22] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2610506 (10Trizek-WMF) Advice taken from the CLs, I'm removing accounts that have been renamed after the SUL finalization (they look li... [14:52:10] (03CR) 10Sbisson: [C: 032] Make flushDeferredQueue() not try to commit the transaction round [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308331 (https://phabricator.wikimedia.org/T144618) (owner: 10Aaron Schulz) [14:52:57] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: Special:EnableFlow fails for an existing page - https://phabricator.wikimedia.org/T144618#2611205 (10SBisson) a:03aaron [14:58:47] (03Merged) 10jenkins-bot: Make flushDeferredQueue() not try to commit the transaction round [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308331 (https://phabricator.wikimedia.org/T144618) (owner: 10Aaron Schulz) [15:32:02] (03PS1) 10Sbisson: Show board description content only at the end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308752 [16:28:56] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2611441 (10Catrope) This isn't actionable now, but for posterity: once a beta feature changi... [16:35:32] (03CR) 10Catrope: [C: 032] Show board description content only at the end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308752 (owner: 10Sbisson) [16:38:57] stephanebisson: Could you respond to https://phabricator.wikimedia.org/T143122#2593110 ? [16:39:11] yep [16:42:31] (03Merged) 10jenkins-bot: Show board description content only at the end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308752 (owner: 10Sbisson) [16:55:17] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2611592 (10SBisson) There are two ways clicking a link can mark a notification as read. # The link leads to a page that is considered a "target page" in the database. Ta... [17:02:04] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2611642 (10Trizek-WMF) pt.wb and gom.wp have been drastically reduced to the most active editors, based on recent changes. Flow is the... [17:16:29] RoanKattouw, I can't readily find this in mw files.. where is wfForeignMemcKey() method defined? Do you know? [17:17:24] RoanKattouw, I have a feeling I may know what (one of?) my issue is ... list( $db, $prefix ) = wfSplitWikiID( $sourceWiki ); gives me $db = 'wiki' (correct) and $prefix = ''... and since both are used as cache placements, I suspect the '' is throwing things off? is that possible? [17:30:17] mooeypoo: Maybe? [17:30:40] They're defined in includes/GlobalFunctions.php [17:31:24] With some indirection, the actual implementations are in ObjectCache land somewhere [17:33:43] mooeypoo: What are the bugs you're seeing? [17:34:59] Does anyone has an idea to reduce Flow boards on ns3 on Mediawikiwiki to Flow boards that are used for conversations, not as a warning page for a vandal? [17:36:21] RoanKattouw, the 'getTime' from SeenTime is giving me current time, as if time( 0 ) [17:36:28] so I suspect the response from the cache is 0 ? [17:36:43] maybe the keys are not configured properly or something. [17:36:53] RoanKattouw, let me clean a bit and I'll push the code, you might spot something [17:39:20] (03PS1) 10Mooeypoo: Check if there are unseen notifs in any wiki for the badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 [17:39:22] RoanKattouw, ^ [17:39:29] also, I can't find the bug we were both looking at on Friday [17:43:14] (03CR) 10Catrope: [C: 04-2] "When is this ever needed? Even maintenance scripts should run DefaultSettings.php before Echo/Resources.php unless they're doing something" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308541 (https://phabricator.wikimedia.org/T144727) (owner: 10Addshore) [17:43:50] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2611841 (10Trizek-WMF) Number of targeted pages per wiki. That table: * excludes duplicates * includes community pages (VPS, help des... [17:44:19] Trizek: Perhaps limit to boards that the owner has posted on themselves? But I don't know how to do that SQL-wise [17:44:48] (03CR) 10jenkins-bot: [V: 04-1] Check if there are unseen notifs in any wiki for the badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (owner: 10Mooeypoo) [17:50:16] mooeypoo: I think https://phabricator.wikimedia.org/T134855 is the bug you're referring to [17:50:46] mooeypoo: I don't see anything wrong with your code offhand. Could you use eval.php to check what $wgMainStash is set to? [17:51:23] RoanKattouw, yep one sec [17:51:34] Also, you could do some var_dump()s inside of EchoSeenTime::getTime() to see what it's doing exactly; it looks at the cache and also at the user preference so who knows what it's getting from either [17:53:31] RoanKattouw, I did, yeah [17:53:38] I just took it off for pushing the code [17:55:00] hmmm RoanKattouw I just checked that thing again, and it seems to depend on where I run the maint script from.... [17:56:17] RoanKattouw, the key I get is "wiki:echo:seen:alert:time:1" -- which seems to mean that $prefix is ignored [17:56:34] If I have wikibase enabled I get the issue RoanKattouw , but not without.... I will investigate some more.... [17:58:59] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts - https://phabricator.wikimedia.org/T144727#2611913 (10Addshore) It looks like this issue is actually to do with some sort of interaction with Wi... [17:59:07] 06Collaboration-Team-Triage, 10Notifications, 07Performance, 07Wikimedia-log-errors: Redis constantly doing duplicate redis fetches - https://phabricator.wikimedia.org/T144836#2611914 (10demon) [17:59:22] 06Collaboration-Team-Triage, 10Flow, 10Wikidata, 13Patch-For-Review: Notice: Undefined variable: wgResourceModules in Flow\Resources.php on line 637 when running maint scripts with Wikibase enabled - https://phabricator.wikimedia.org/T144727#2611927 (10Addshore) [17:59:37] 06Collaboration-Team-Triage, 10Notifications, 07Performance, 07Wikimedia-log-errors: Echo constantly doing duplicate redis fetches - https://phabricator.wikimedia.org/T144836#2611929 (10demon) [18:01:24] mooeypoo: Or it detected that $prefix==='' and decided to not do wiki::echo:seen:alert:time:1 [18:02:01] addshore: So if you enable more software, less code runs?! :D [18:02:20] RoanKattouw: something like that ;) [18:03:43] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2611962 (10Trizek-WMF) [18:07:04] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2611979 (10Catrope) [18:07:06] 06Collaboration-Team-Triage, 10Notifications, 07Performance, 07Wikimedia-log-errors: Echo constantly doing duplicate redis fetches - https://phabricator.wikimedia.org/T144836#2611981 (10Catrope) [18:17:12] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2612001 (10Trizek-WMF) [18:20:16] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2612012 (10Trizek-WMF) [18:20:32] Survey announcement sent to wikimedia-l. [18:25:00] RoanKattouw, the cache result returns "false" :\ [18:25:03] mehhhhh [18:25:31] even after the correction... we have a if ( $data === false ) { $this->user->getOption( 'echo-seen-time', false ); } [18:25:34] and it's still false [18:27:34] * mooeypoo has an idea [18:30:05] idea failed. [18:30:07] meh. [18:45:37] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2557561 (10matej_suchanek) >>! In T143122#2611592, @SBisson wrote: > I'm not really familiar with the `page-connection` wikidata notification. How could this type of no... [18:48:51] RoanKattouw: hmm... Add 'mark all read' button to the notification overlay https://gerrit.wikimedia.org/r/306288 -- it's buggy, at least on iPhone [18:49:19] RoanKattouw: do we have to have it in out deployment list? [18:49:38] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2612112 (10SBisson) >>! In T143122#2612084, @matej_suchanek wrote: >>>! In T143122#2611592, @SBisson wrote: >> I'm not really familiar with the `page-connection` wikidat... [19:00:33] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2584732 (10Mattflaschen-WMF) No it hasn't. Database changes are not deployed automatically to production. ``` mysql:research... [19:22:32] etonkovidova: We can back it out if you think we should [19:23:23] RoanKattouw: yeah, maybe - not 100% sure... [19:23:28] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2612212 (10SBisson) >>! In T143122#2593110, @Quiddity wrote: > @SBisson has your recent work on target_page, for page-linked notifications, perhaps already fixed this?... [19:27:29] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2612225 (10Sjoerddebruin) >>! In T143122#2612112, @SBisson wrote: >>>! In T143122#2612084, @matej_suchanek wrote: >>>>! In T143122#2611592, @SBisson wrote: >>> I'm not r... [19:27:32] mooeypoo: So etonkovidova and I found a bug in your "mark all as read on mobile" thing [19:28:28] mooeypoo: The "Marked N notifications as read" message seems to use the total number of notifications displayed in the popup, not just the number of notifs it just marked as read [19:29:35] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2612246 (10SBisson) Ok, they are indeed page-linked notifications. I didn't know they were happening with wikidata items. As I said before: it should be fixed. Let us k... [19:39:23] eh [19:39:38] RoanKattouw, can you add a bug (or bring the old one to dev) -- I'll try to check into it after meetings [19:40:26] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10Tgr) This is happening at a [[https://logstash.wikimedia.org/app/kibana#/dashb... [19:40:36] Will do [19:43:25] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2612309 (10Catrope) @Mooeypoo The confirmation message counts the numb... [19:46:49] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10Legoktm) There's no in process cache, and we look up the seen time for each us... [20:00:08] RoanKattouw, ok, I am **baffled** by the seen time business. Both the read and write keys are correct, and yet I keep getting "false" for the value, which means the time is given as now which is unhelpful (since nothing is ever unseen) [20:00:43] RoanKattouw, I tried with a brand new user that I set the seenTime to (with the new keys, so to make sure I have a fresh cache value) and I still get falses [20:00:46] I don't understand why [20:04:33] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10aaron) Maybe used the CachedBagOStuff class? [20:07:45] (03PS1) 10Legoktm: SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308814 (https://phabricator.wikimedia.org/T144534) [20:09:43] (03PS1) 10Mooeypoo: Add method to get local unread notifications in the manager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308815 (https://phabricator.wikimedia.org/T141404) [20:11:28] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2612522 (10Mooeypoo) >>! In T141404#2612309, @Catrope wrote: > @Mooeyp... [20:11:47] RoanKattouw, https://phabricator.wikimedia.org/T141404 <-- should fix the bug [20:22:24] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2612571 (10SBisson) >>! In T93673#2607119, @Quiddity wrote: > Two fresh reports of edito... [20:33:16] James_F: should https://wikimediafoundation.org/wiki/Survey_Privacy_Statement_for_Spring_2016_Flow_Survey be Fall 2016? [20:34:41] (03CR) 10Aaron Schulz: "Note that negatives are not cached. Also the warnings come from the base class, so they will still happen. I'll make a patch to the cached" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308814 (https://phabricator.wikimedia.org/T144534) (owner: 10Legoktm) [20:35:04] 06Collaboration-Team-Triage, 10Notifications: Not bundled multiple edits are counted as separated notices in badge counter - https://phabricator.wikimedia.org/T144860#2612601 (10Etonkovidova) [20:37:09] (03CR) 10Aaron Schulz: [C: 032] SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308814 (https://phabricator.wikimedia.org/T144534) (owner: 10Legoktm) [20:38:36] 06Collaboration-Team-Triage, 10Notifications: Page links notifications sent without apparent cause - https://phabricator.wikimedia.org/T144785#2610094 (10Mattflaschen-WMF) >>! In T144785#2610301, @Sjoerddebruin wrote: > It is the template, I can remember receiving these during edit wars on templates. :( Maybe... [20:39:47] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2612630 (10Etonkovidova) @SBisson - looking at the snapshot https://snag.gy/M9s0AI.jpg... [20:42:48] legoktm: It's Summer until 21 September, so no. :-) [20:43:40] (03Merged) 10jenkins-bot: SeenTime: Wrap cache with CachedBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308814 (https://phabricator.wikimedia.org/T144534) (owner: 10Legoktm) [20:48:24] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2388978 (10Pine) I was looking forward to this functionality for test notification, although I understand the reasons for disab... [20:51:47] RoanKattouw: my browser crashed, be back shortly [20:57:26] stephanebisson: regarding "Remove Notifications about posts/topics that have been Moderated" https://phabricator.wikimedia.org/T93673 [20:58:16] stephanebisson: I do not see any problem with purging (and counting) moderated notifications if a user re-login hmm... [20:58:49] James_F: Summer then? :P [20:59:14] stephanebisson: maybe I should've emphasized more the need to refresh/re-login [21:03:58] etonkovidova: do you have a reproduceable issue that involves re-login? [21:04:44] stephanebisson: you mean when *only* re-login helps to display correct count? [21:04:53] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2612705 (10Quiddity) >>! In T138080#2612652, @Pine wrote: > I was looking forward to this functionality for test notifications,... [21:05:16] etonkovidova: well, any issue related to moderation that I could reproduce and fix [21:06:22] legoktm: Eh. I don't care, but it's Benoît's work and his call. [21:07:55] stephanebisson: the problem is, I do not see it as an issue exactly :( 1) Login to two different wikis 2) make sure that you see notifications from some topic 3) from a different browser, as a different user -delete that topic [21:12:24] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2612719 (10Legoktm) 05Open>03Resolved a:03Legoktm Will be deployed in wmf.19. If someone w... [21:22:10] (03CR) 10Catrope: [C: 032] Add method to get local unread notifications in the manager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308815 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [21:22:53] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 4 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2612755 (10Pine) Thanks for the suggestion. Unfortunately that's more complicated than the arrangement I would like to see. My... [21:26:30] RoanKattouw, do you have a few minutes to help me with the seen time cache business? [21:26:34] i'm stumped :( [21:26:37] I have 3 [21:27:07] Maybe we can hangout+screenshare at 3pm? [21:27:38] * mooeypoo nods [21:27:40] wfm [21:28:30] RoanKattouw, there's no room on 3rd [21:28:44] If you book something on 5 or 6 I'll go there [21:28:51] (03Merged) 10jenkins-bot: Add method to get local unread notifications in the manager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308815 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [21:28:53] RoanKattouw, but R51 is the only one available... :D [21:28:59] lol, not my problem [21:29:14] mooeypoo: who broke Special:Notifications page - againg - with BadMethodCallException Call to a member function getNamespace() on a non-object (null) [21:29:29] O.O [21:29:39] I'll see if I can spot an unused room that I can take instead [21:30:00] RoanKattouw, invite sent anyways [21:30:40] etonkovidova, works for me in master... and https://en.wikipedia.beta.wmflabs.org/wiki/Special:Notifications works for me too [21:32:19] mooeypoo: wow - it's broken only for one user Interesting - checking db now [21:32:29] O.O [21:32:34] how the hell do you FIND those things [21:34:07] Probably because they have a particular type of notification, possibly with a missing page [21:34:33] Flow? [21:36:04] RoanKattouw: looking exactly in that direction - especially there is other signaling stuff - red Alerts that say "Failed to fetch" [21:36:49] RoanKattouw, all instances of $title->getNamespace() **should** also have a canRender() that checks that $title exists :\ [21:38:20] RoanKattouw, I take it back, I found a few who don't [21:38:26] ? [21:38:33] Well, that $title is not null [21:39:06] $title not existing can be OK [21:39:13] But won't happen in general [21:39:25] RoanKattouw, EchoMentionStatusPresentationModel asks for getPageLink() which has $this->title->getNamespace() but it doesn't have canRender() check [21:39:28] is this not a problem? [21:40:07] Yes [21:40:11] it actually has $title->getNamespace() but seem to be the same [21:40:18] That is bad [21:40:36] ( $this->event->getTitle() hopefully) [21:40:43] yeah eventually [21:40:53] it asks for $this->getTitleWithSection() [21:41:01] which then has $title = $this->event->getTitle(); [21:41:04] etc etc. [21:41:29] RoanKattouw, should we add a "canRender" to this class, or should we add a sanity check to getPageLink ? [21:41:38] Add canRender [21:42:27] ok I'm also looking for more instances [21:43:51] ok I think that's the only one, but there's a bit of a pit of calls in Flow if we want to verify there too [21:44:12] getPageLink() is being called by getBoardLink and a few other methods, so looking for all of those is going to be a challenge [21:45:13] (03PS1) 10Mooeypoo: Add 'canRender' check to EchoMentionStatusPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308881 [21:45:20] RoanKattouw, ^ [21:46:50] (03CR) 10Catrope: [C: 032] Add 'canRender' check to EchoMentionStatusPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308881 (owner: 10Mooeypoo) [21:49:40] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2612860 (10Tgr) As long as you are not passing any parameters to CachedBagOStuff (which b3cdd56... [21:52:46] (03Merged) 10jenkins-bot: Add 'canRender' check to EchoMentionStatusPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308881 (owner: 10Mooeypoo) [22:02:17] RoanKattouw, meeting? [22:08:33] (03CR) 10Aaron Schulz: [WIP] Update Flow caching strategy for multi DC (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [22:10:07] 06Collaboration-Team-Triage, 10Notifications: Allow excluding pages from the page links notifications - https://phabricator.wikimedia.org/T46787#2612971 (10Quiddity) [22:11:04] 06Collaboration-Team-Triage, 10Notifications: Page links notifications sent without apparent cause - https://phabricator.wikimedia.org/T144785#2610094 (10Quiddity) Ah, I might have misunderstood how it worked. I thought that Echo would only send a notification, if the navbox was freshly added to a page. Perha... [22:20:57] (03CR) 10Catrope: [C: 04-1] Check if there are unseen notifs in any wiki for the badge (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308782 (owner: 10Mooeypoo) [22:22:34] 06Collaboration-Team-Triage, 10Flow: Change the indentation level in Flow - https://phabricator.wikimedia.org/T144869#2613028 (10tarlocesilion) [22:33:34] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 13Patch-For-Review, and 3 others: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10Catrope) I think {e1a276fe3dc9c4e8a68b744f6d8643807582694a} probably made this much w... [23:07:48] etonkovidova, can you double-check the error you got on that user in beta Special:Notifications before? [23:08:05] etonkovidova, I think the fix with canRender() may have fixed it, and it was merged a little while ago, should be enough to already be on beta [23:08:37] Going home. Will take a break, then be on later. [23:08:56] mooeypoo: yup, seems to be fixed. [23:10:01] \o/ [23:10:08] have a good evening, matt_flaschen [23:10:21] mooeypoo: and the fixed width seems to be there - nice! some miraculous fixes :) [23:10:31] ... really? I didn't touch that [23:10:49] I mean, yes. Yes. Of course. Fixed. That was... intentional.... [23:11:46] etonkovidova, seriously,though, I think that may have been the canary of a different bug... maybe the fixed width doesn't work with long descriptions or long headers? [23:12:36] mooeypoo: now all seems fine - long titles including hmm... Was it extremely well-cached content? [23:12:47] maybe? :\ [23:12:50] RoanKattouw, ? [23:12:56] 06Collaboration-Team-Triage, 10Flow: Type of flow_ext_ref.ref_target incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#1578196 (10MarkAHershberger) While upgrading to 1.27, I got the following from Flow (which may be the cause of the columns having the wrong type?): ``` Modif... [23:13:01] It would be really weird, but at this point, I don't know [23:13:03] mooeypoo: anyway, all looks good - hurray [23:13:07] yay! [23:13:21] Hmm not sure [23:13:36] Who knows [23:13:43] The Browser[TM] [23:13:43] Let's see if the fixed width bug comes back [23:13:50] If not, that's good enough for me [23:13:55] If it does, we will fix the fixed width. [23:14:08] Just like we word-break: break-word'ed the other bug. [23:14:18] We're semantic like that. [23:14:39] RoanKattouw: mooeypoo - I just love that zen -like approach [23:15:32] mooeypoo: and mobile 'Mark all as read' seems now fine too [23:16:00] yay [23:16:09] yea that one was a silly mistake on my par [23:16:11] part* [23:16:29] I counted all notifications rather than all unread ones [23:16:43] ... wait... that... hm. Do we have bundled notifications, excep for xwiki, in the mobile popup? [23:17:04] etonkovidova, oy, if we have bundled notifications in mobile, the "mark all as read" counter might be off again. [23:17:11] I don't remember if we do [23:17:18] mooeypoo: checking... [23:17:39] I don't remember if the 'get all local notifications' checks for bundled items [23:17:42] but it might not [23:17:55] it probably doesn't count them right [23:23:16] mooeypoo: Ha! it works perfectly [23:23:29] mooeypoo: and we do have bundled notifications on mobile [23:26:03] It counts them right? [23:26:09] okay, I think I know of a way to break this [23:26:14] mooeypoo: it just plain works [23:26:44] It would likely break in a completely convoluted case [23:26:55] ... if there are more than 25 items in the bundle [23:27:11] Feel free to skip this convoluted case, though. [23:27:37] That might be Going Too Far[tm] [23:29:33] mooeypoo: no problems with convoluted cases - I checked the following case: Total 50 (23 is foerein wiki) [23:30:01] mooeypoo: Mark all as read - displays 25 are marked as read [23:30:07] but 'mark all read' shouldn't affect xwiki [23:30:22] so it should mark 22, i think? [23:30:39] mark all read should leave xwiki unread [23:30:43] mooeypoo: no, 50 -23=27 [23:30:58] err 27, yes, ha, sorry [23:31:09] mooeypoo: 25 are marked, and it calmly displays 2 left to go with Mark all as read option [23:31:26] Why 2? [23:32:18] mooeypoo: 23 is cross wiki, 25 are marked as read, 50 -23 -25=2 [23:33:00] mooeypoo: Mark all as read applies only to 25 just like it's in non-mobile env [23:34:50] I am still confused; mark all read should mark everything local as read. If you have 25 notifications in your popup, one of which is xwiki (so 24 local?) and then 23 inside the xwiki, you should have 47 notifications total, and "mark all as read" should mark 24 of them read... and only leave 1 xwiki bundle unread...? [23:39:23] mooeypoo: well, it's kind of by design - notificaiton panel displays 25, so 'Mark all as read' on **the notification panel** refers only to 25 notificaitons [23:40:25] Right [23:40:44] So if you have more in the xwiki, they're not marked as read [23:46:07] mooeypoo: yup - xwiki notifications have their own 'mark all as read' blue button [23:50:00] ok I trust you that it works well [23:50:06] I'm still confused with the count, but that's always confusing [23:55:21] mooeypoo: count is always evil. If there is a counter, some trouble is bound to happen [23:57:01] yeah