[00:00:18] eek [00:00:33] What? [00:01:33] This event is fired in other places than the special recent changes page?? [00:01:49] ohhhh wow i missed that [00:02:01] mooeypoo, the one I'm recommending you use is. The one you used earlier is just RC. [00:02:38] MatmaRex unified watchlist and RC a while ago, which is why the hook you originally used is deprecated. [00:04:00] * mooeypoo nods [00:04:14] matt_flaschen, RoanKattouw just asked I add the name of the page to the logging schema [00:04:23] this way we can tell what filters are used in recent changes and watchlists etc [00:04:41] I figured if we have the data, we might as well [00:05:15] RoanKattouw, yeah, it makes sense. Then you can drop the getName check. I would also then rename it to Schema:ChangesListFilters. [00:05:16] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Browser-Support-Internet-Explorer, 13Patch-For-Review, and 2 others: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2603831 (10Paladox) This now works :) [00:07:28] matt_flaschen, oh, I named the schema after the purpose of it, not the event necessarily [00:07:35] but if you think the rename will make it clear, we can switch it [00:09:16] mooeypoo, I thought the name referred to it being the Special:RC page. But not a big deal. Also, you also need to then check SpecialWatchlist.php page for options. [00:09:29] Good point on the schema name [00:09:44] Because ChangesList is the name for the trinity of RC, watchlist and contribs [00:09:50] Or at least RC and watchlist? [00:10:02] RoanKattouw, not Contribs. [00:10:09] Hmm OK [00:10:19] alright, the page is here: https://meta.wikimedia.org/wiki/Schema:RecentChangesFilters how do I move it + its talk page? [00:10:24] Presumably since that one is not based on recentchanges table, and thus not as much potential for code reuse. [00:10:24] I guess that makes sense because contribs doesn't use the RC table [00:10:27] Jinx [00:10:39] mooeypoo: Using MediaWiki :P I'll show you [00:10:42] mooeypoo, it should just work TM [00:12:52] Wait, WTF? Schema pages aren't allowed to be moved?! [00:13:02] Do I really need to manually move it? :( [00:13:19] Really?! [00:13:29] She's copying it over [00:13:36] I'll see if I have the rights to delete the old one [00:14:05] https://meta.wikimedia.org/wiki/Schema:ChangesListFilters [00:14:10] I do [00:18:02] matt_flaschen, re your patch with flip RTL in GuidedTour -- I'm still not entirely happy about the 'flipRTL' thing, since it's thoroughly properly confusing - but I really don't think there's a good alternative without refactoring the way things currently flip [00:18:09] so I'm good +2ing as-is [00:18:18] Your explanation and examples should work [00:19:23] mooeypoo, yeah, the current system is built around explicit directionalities: https://phabricator.wikimedia.org/diffusion/EGTO/browse/master/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js;1554ed0deab987b37c4b2cc8f30c9bd418563aa3$111 (which I appreciate is not very RTL-friendly) [00:19:32] matt_flaschen, ... except... I can't... +2.... O.o [00:19:45] mooeypoo, do you not have mediawiki/* ? You should get that. [00:20:01] wat [00:20:07] Which repo can't you +2 in? [00:20:07] Apparently not? :\ [00:20:15] GuidedTour [00:20:16] WTF [00:20:23] I thought all WMF staff got +2 in all extensions [00:20:41] .... ooooookay then, gerrit [00:20:43] I'm pretty sure I have that, mooeypoo should as well. [00:20:44] She was on an old patchset, the new Gerrit UI shows this really badly [00:20:51] So considering GuidedTour is not being actively enhanced, I agree with you. [00:20:56] * mooeypoo +2'ed [00:20:57] Re above. [00:21:03] is the bot not showing GuidedTour here? [00:21:13] anyways, it's +2 [00:21:27] mooeypoo, I don't think GuidedTour is officially owned by any team, it's more of a 'ask Matt' thing. [00:21:43] We should have that on a tshirt [00:21:46] #AskMatt [00:22:03] There can then be a suit. Like a Hazmat suit, AskMatt suit... [00:22:08] .... I am so bad today [00:22:30] If we want to take over GT, fine by me though. :) Same for GettingStarted. But we do have quite a collection of extensions already. [00:23:24] ok, matt_flaschen's code reviewed, I think I added all filters to the schema, and I tested it (though whoever reviews, please double-check) [00:23:27] I think I'm good for now [00:24:45] (03PS3) 10Esanders: Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 [00:25:09] (03CR) 10Catrope: [C: 032] Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 (owner: 10Esanders) [00:30:46] (03Merged) 10jenkins-bot: Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 (owner: 10Esanders) [00:31:11] (03PS1) 10Esanders: Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 [00:35:39] (03CR) 10Catrope: [C: 032] Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 (owner: 10Esanders) [00:42:47] (03Merged) 10jenkins-bot: Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 (owner: 10Esanders) [00:54:03] (03PS1) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [00:57:05] (03PS2) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [01:03:35] (03PS3) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [01:26:30] (03PS1) 10Sbisson: Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) [01:26:37] (03PS1) 10Sbisson: Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) [01:35:40] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: Resolved topics should be able to be deleted or suppressed without reopening them first - https://phabricator.wikimedia.org/T142779#2604040 (10SBisson) a:03SBisson [01:36:03] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Notification: Dummy title used when section name is a magicword - https://phabricator.wikimedia.org/T141460#2604042 (10SBisson) a:03SBisson [01:40:46] (03CR) 10Catrope: [C: 032] Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) (owner: 10Sbisson) [01:41:51] (03CR) 10Catrope: [C: 032] Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) (owner: 10Sbisson) [01:48:35] (03Merged) 10jenkins-bot: Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) (owner: 10Sbisson) [01:48:55] (03Merged) 10jenkins-bot: Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) (owner: 10Sbisson) [02:42:58] Have a good night, see you tomorrow. [05:04:51] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Internationalization, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2604194 (10Guycn2) [06:55:54] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Internationalization, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2604270 (10Aklapper) [06:56:09] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Internationalization, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2602917 (10Aklapper) [ Edit Related Tasks > Edit Parent Tasks > Added {T32443} ] [07:57:41] (03Abandoned) 10Addshore: DiscussionParserTest also test the action that triggered events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302903 (owner: 10Addshore) [08:39:57] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2604400 (10Qgil) [11:21:34] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow on Windows 10 collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2604569 (10Trizek-WMF) [12:50:04] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2604715 (10Trizek-WMF) New run, removing some [[https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces | namespaces]] : *... [14:18:34] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Help to define next steps concerning Flow development, based on Flow satisfaction survey - https://phabricator.wikimedia.org/T137796#2604935 (10Trizek-WMF) [14:23:05] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2604940 (10Trizek-WMF) [14:23:53] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2604946 (10Trizek-WMF) 05Open>03Resolv... [14:24:12] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2604950 (10Trizek-WMF) [14:24:15] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1648523 (10Trizek-WMF) 05stalled>03Open [14:33:29] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2604988 (10Trizek-WMF) Will also be ignored: * IP adresses talk pages (~ 2,000 pages) * user sub-pages * user talk page sub-pages if a... [14:43:33] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2605009 (10Trizek-WMF) Some people may ask which are the "relevant wikis". Can you clarify? [15:18:44] (03PS1) 10Sbisson: Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 [15:31:22] (03CR) 10Aaron Schulz: [C: 032] Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 (owner: 10Sbisson) [15:39:17] (03Merged) 10jenkins-bot: Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 (owner: 10Sbisson) [16:20:26] 06Collaboration-Team-Triage, 10Flow, 10Mention-Notification, 06TCB-Team: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2605228 (10Lea_WMDE) [16:25:32] 06Collaboration-Team-Triage, 10Flow, 10Mention-Notification, 06TCB-Team: Inform users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#2605253 (10Lea_WMDE) [16:27:59] 06Collaboration-Team-Triage, 10Notifications: Read cross-wiki notifications removed from cross-wiki notification history - https://phabricator.wikimedia.org/T144525#2602662 (10Etonkovidova) @Pine, thank you and please confirm that the following steps describe the issue correctly: - a message has been placed o... [16:36:29] 06Collaboration-Team-Triage, 10Notifications: Read cross-wiki notifications removed from cross-wiki notification history - https://phabricator.wikimedia.org/T144525#2605297 (10Etonkovidova) Another interesting scenario: - Have one unread notification from Wiki A. - On Wiki B open Special:Notifications page a... [16:40:35] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 07Documentation: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2605319 (10Lea_WMDE) [16:44:57] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 2 others: Unclear "fail to mention" in echo-pref-tooltip-mention-failure - https://phabricator.wikimedia.org/T143084#2605326 (10Lea_WMDE) We cannot write "when my edit links a user, but is not considered a mention", since... [16:55:14] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Special:EnableFlow fails for an existing page - https://phabricator.wikimedia.org/T144618#2605351 (10SBisson) [17:15:46] (03CR) 10Mooeypoo: [C: 032] "This is awesome, thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 (owner: 10Esanders) [17:22:02] (03Merged) 10jenkins-bot: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 (owner: 10Esanders) [17:26:37] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Special:EnableFlow fails for an existing page - https://phabricator.wikimedia.org/T144618#2605454 (10aaron) Is there a backtrace for this? [17:39:43] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Special:EnableFlow fails for an existing page - https://phabricator.wikimedia.org/T144618#2605475 (10SBisson) Here's a backtrace, if still relevant. ``` #0 /vagrant/mediawiki/extensions/Flow/includes/Import/Converter.php(188): Flow\Import\Converter->createArchiveCleanup... [17:53:35] etonkovidova, I merged Ed's responsive commit before the standup, so it should be in beta now. Can you test that mobile Special:Notifications look ok? [17:53:51] mooeypoo: sure :) [17:53:59] it should also be responsive in desktop, you can test by changing the width of the window - it's pretty cool now [18:02:38] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Resolved topics should be able to be deleted or suppressed without reopening them first - https://phabricator.wikimedia.org/T142779#2605500 (10Etonkovidova) Checked in betalabs - resolved topics can be dele... [18:19:18] mooeypoo: messages on mobile Special:Notifications page does not have any width limit - they overflow horizontally [18:19:50] etonkovidova, what device? [18:20:10] mooeypoo: iPhone 6s [18:20:24] hold on a sec -it should be visible in the emulator [18:21:16] mooeypoo: well, it's visible on normal Special:Notifications page - without mobile mode [18:22:51] 06Collaboration-Team-Triage, 10Flow: Clicking on summary textfield while resolving a topic on Flow on Windows 10 (Chrome or Edge) collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2605560 (10Mattflaschen-WMF) [18:23:04] 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Google-Chrome, 07Browser-Support-Microsoft-Edge: Clicking on summary textfield while resolving a topic on Flow on Windows 10 (Chrome or Edge) collapses the whole discussion - https://phabricator.wikimedia.org/T144587#2604569 (10Mattflaschen-WMF) [18:27:27] etonkovidova, ed's got it, I'm submitting a patch .. thanks! [18:27:39] (03PS1) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:27:41] mooeypoo: good :) [18:28:53] 06Collaboration-Team-Triage, 10Flow, 10Mention-Notification, 06TCB-Team: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2605586 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [18:29:02] (03PS1) 10Mooeypoo: Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 [18:31:01] (03PS2) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:31:22] 06Collaboration-Team-Triage, 10Notifications: Read cross-wiki notifications removed from cross-wiki notification history - https://phabricator.wikimedia.org/T144525#2605591 (10Mattflaschen-WMF) p:05Triage>03Low This is by design, and would require re-architecting how cross-wiki notifications work. [18:35:39] mooeypoo, RoanKattouw, let me know when you're ready to discuss RC/watchlist logging. [18:35:59] matt_flaschen: mooeypoo created a hangout and we're waiting in it :) [18:36:29] Oh, I thought we were doing IRC. [18:36:31] (03CR) 10Catrope: [C: 032] Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 (owner: 10Mooeypoo) [18:36:49] I did too, and then I was taken to a meeting room :) [18:41:29] (03PS3) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:42:53] (03Merged) 10jenkins-bot: Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 (owner: 10Mooeypoo) [19:04:13] 06Collaboration-Team-Triage: Resolved topics with deleted comments display unclickable links 'comments' and 'Be the first to comment!" - https://phabricator.wikimedia.org/T144629#2605660 (10Etonkovidova) [19:09:40] (03CR) 10Catrope: [C: 032] Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [19:11:51] (03CR) 10Aaron Schulz: [C: 04-2] "Still not enough. Hold on." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [19:13:25] (03CR) 10Aaron Schulz: "No commit happens here, so the wait still won't work, duh :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz) [19:13:33] 06Collaboration-Team-Triage: [minor]'Comments' vs 'posts' terms discrepancy - when posts get deleted/suppressed - https://phabricator.wikimedia.org/T144630#2605692 (10Etonkovidova) [19:28:46] (03PS1) 10Esanders: Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 [19:30:44] (03CR) 10Esanders: "I grep'd the code for 'png' and it only appears in some test .txt files in references to files hosted on Commons. I also grepped for a few" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders) [19:35:15] (03PS1) 10Mattflaschen: Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) [19:35:52] (03CR) 10Catrope: [C: 032] Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders) [19:36:37] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Mention-Notification, 06TCB-Team, 13Patch-For-Review: Don't allow a FlowMention for anonymous users in UI - https://phabricator.wikimedia.org/T144613#2605724 (10Mattflaschen-WMF) [19:39:06] (03CR) 10Catrope: [C: 032] Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) (owner: 10Mattflaschen) [19:42:11] (03Merged) 10jenkins-bot: Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders) [19:43:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Notification: Dummy title used when section name is a magicword - https://phabricator.wikimedia.org/T141460#2605732 (10Etonkovidova) Checked the fix for Flow topic titles and wikitext section title... [19:44:16] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2605733 (10Mattflaschen-WMF) [19:44:27] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth: "Echo-pref-tooltip-oauth-owner" should have a period - https://phabricator.wikimedia.org/T144631#2605734 (10Guycn2) [19:48:16] (03Merged) 10jenkins-bot: Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) (owner: 10Mattflaschen) [19:48:27] RoanKattouw, re-review? https://gerrit.wikimedia.org/r/#/c/308001/ [19:48:47] (03CR) 10Catrope: [C: 032] Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo) [19:48:52] \o/ thanks [19:52:31] 06Collaboration-Team-Triage, 10Notifications, 07Technical-Debt: Use OOUI icons for the 'big' icons, not just the little ones, in Notifications - https://phabricator.wikimedia.org/T123996#1942825 (10Esanders) | Echo name | OOUI name | | --- | --- | | bell-* | bell-* | {F4426968,size=full} | changes | - | {F44... [19:55:48] stephanebisson, I haven't reviewed your caching patch yet (finishing up MessagePoster), but I plan to today or over the weekend. Is there anything you want to let me know/ask me/discuss before you break for the weekend? [19:56:23] (03Merged) 10jenkins-bot: Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo) [19:56:27] If not, when I'm done MessagePoster I'll look at your patch and get my brain back in the caching layer zone (it's been a while) [19:56:44] matt_flaschen: not really, we should talk after you've looked at it [19:57:09] Sounds good [19:58:40] (03PS2) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) [19:58:55] 06Collaboration-Team-Triage, 10Notifications, 07Technical-Debt: Use OOUI icons for the 'big' icons, not just the little ones, in Notifications - https://phabricator.wikimedia.org/T123996#2605804 (10Catrope) We already have all of the icons in our local emailicons module, so as a first step we can use RLIM to... [20:02:29] taking now my another half day off :) [20:10:51] matt_flaschen, RoanKattouw re our discussion, we should inform the ticket at T141319 with that. With what we're collecting, the data will be missing people who have default filters, like matt_flaschen said. [20:10:51] T141319: [REQUEST] Which features of RecentChanges are most often used? - https://phabricator.wikimedia.org/T141319 [20:18:42] Yeah [20:19:14] RoanKattouw, mooeypoo, legoktm, what do you think about https://gerrit.wikimedia.org/r/#/c/307426/7/includes/content/ContentHandler.php ? I considered the option legoktm mentioned earlier, but I think supports may be more consistent with the existing code. [20:19:34] what else uses supports? [20:20:04] all of those are to get booleans [20:20:10] but here we want an object [20:20:29] legoktm, yeah, so is this. But ultimately, you're taking an action, e.g. supportsDirectEditing. First you get a boolean but later you're taking an action, similar to this. [20:22:11] but those actions aren't on the ContentHandler object...? [20:25:18] legoktm, makeRedirectContent is. [20:25:30] legoktm, also true, createDifferenceEngine (which is also on CH) also behaves somewhat similar, except instead of throwing it returns a broken DifferenceEngine for non-wikitext. Then later generateContentDiffBody throws. I thought this was a little like that, but better. [20:27:16] supportsSections is also similar (there are methods on the Content object, not CH) [20:28:00] okay. makes sense I guess [20:31:25] legoktm, maybe I should return null like makeRedirectContent instead of throwing. But still keep the supports method too, like that. [20:32:02] Well, at that point there's not much use for supports is there? [20:37:44] legoktm, sold. :) I thought about it more, and I'll update it. The only reason you would need a supports is if you had to check but wouldn't actually use the MessagePoster, and construction was expensive. [20:37:54] I don't have a use case like that. [20:38:05] yeah :) [20:38:29] I just reviewed the Flow patch, and I think we need a consistent way of throwing exceptions [20:38:47] because the flow poster is throwing MWException [20:38:52] and wikitext is UsageException [20:40:07] legoktm, UsageException is a subclass of MWException. Is there a reason they should be the same level? [20:40:14] Also wondering in general. [20:40:24] hmm. [20:40:33] Technically, UsageException is used for a lot of things that have nothing to do with usage. [20:40:48] Which I can live with, but would rather not add more unless there's a reason to. [20:40:58] right. [20:42:15] the MassMessage use case is that we need to log some kind of error [20:43:13] legoktm, there's always MWExceptionHandler::logException, or $exception->getText() [20:45:06] legoktm, I am fixing the Result: Failure thing BTW. It's not super-pleasant, but it will at least work. [20:45:15] hmm [20:45:24] okay [20:45:38] legoktm, I wish you could attach arbitrary data to exceptions. [20:45:45] But I guess that could be annoying for the client too. [20:45:48] Status objects ;) [20:46:07] also, I'm going to try creating a shim contenthandler for LQT that just wraps wikitext so we can create a messageposter for it too [20:52:56] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-OAuth, 07Easy: "Echo-pref-tooltip-oauth-owner" should have a period - https://phabricator.wikimedia.org/T144631#2605918 (10Tgr) [21:02:18] 06Collaboration-Team-Triage, 10Flow: Resolved topics with deleted comments display unclickable links 'comments' and 'Be the first to comment!" - https://phabricator.wikimedia.org/T144629#2605941 (10Aklapper) [21:03:34] legoktm, the reason I don't use Status is I would have to transform from UsageException, and that just uses raw un-i18ned strings ( :( ), so I would have to use RawMessage, which seems ugly, so I decided to just keep the exceptions. [21:10:08] matt_flaschen: fwiw, aaron made me do something like that recently, so you wouldn't be the first. UploadBase::tryStashFile() [21:10:25] try { [21:10:25] } catch ( UploadStashException $e ) { [21:10:25] return Status::newFatal( 'uploadstash-exception', get_class( $e ), $e->getMessage() ); [21:10:25] } [21:11:11] matt_flaschen: if you ever end up devising a generic pretty way to turn Exceptions into Statuses… ;) [21:15:32] MatmaRex, how does MWException use i18n BTW? It has some kind of support, but I can't quite figure it out. [21:16:29] matt_flaschen: i don't think it does. some subclasses of it do [21:17:09] MWException is just the PHP Exception, with some weird stuff for MW-related logging [21:17:30] MatmaRex, looks like the base class only uses it for a few very select things, like internalerror-fatal-exception . [21:17:32] ErrorPageError extends it and actually uses localisation messages for the exception message [21:17:48] Thanks [21:18:17] (and also generates a pretty error page, e.g. a permissions error. but there seem to be more subclasses for that) [22:07:13] matt_flaschen, I just looked at Joe's computer now, where an xwiki bundle was marked 'unseen' even though it *was* seen. We double-checked by going to another wiki in the cluster and once again, it's unseen there. I am wondering if it might be a problem with the "global" seentime (the seen time we send in the API response from the foreign wiki) -- could it be that wikis aren't updated yet? No, right? It's been enough time [22:07:49] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2606079 (10Mattflaschen-WMF) [22:08:52] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "Seen" status not recognized across different wikis - https://phabricator.wikimedia.org/T144643#2606080 (10jmatazzoni) [22:11:32] I can't reproduce this on master, so it sounds like it might be something in production [22:11:46] mooeypoo, no, it's a known issue that was never fixed: https://phabricator.wikimedia.org/T134855#2497914 [22:12:27] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2606097 (10Mattflaschen-WMF) [22:12:29] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "Seen" status not recognized across different wikis - https://phabricator.wikimedia.org/T144643#2606099 (10Mattflaschen-WMF) [22:13:00] I agree with Stephane's proposed solution (right after the above link). [22:14:14] I'll be back in a few minutes. [22:30:05] matt_flaschen, by stephane's proposed solution, you mean 'sources.any {...}' [22:30:09] ? [22:35:59] * mooeypoo tosses poisoned pebbles at seenTime [22:53:00] mooeypoo, yes. [23:20:57] (03CR) 10Catrope: [C: 032] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [23:28:11] (03Merged) 10jenkins-bot: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [23:47:52] (03PS3) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) [23:58:07] Getting dinner. Might be back on later tonight.