[00:12:39] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016): Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2600518 (10Mattflaschen-WMF) 1. Say at 8 PM I make an edit to Earth. I don't have autopatro... [00:22:09] matt_flaschen, I can change the expected output for "User uploaded File:File.png" but I am actually worried that I should. This one doesn't come out with a link at all, why would it suddenly have a link?! :\ [00:22:39] same with the others "User moved page OldPage to NewPage over a redirect without leaving a redirect" etc [00:22:56] they're all plaintext, nonlinks. The fix I have adds to *links*.. why is it suddenly added here [00:24:22] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Add ORES good-faith scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144463#2600538 (10jmatazzoni) [00:25:13] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2600552 (10jmatazzoni) [00:25:14] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Add ORES good-faith scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144463#2600538 (10jmatazzoni) [00:26:46] This is weird. All cases of Linker::userLink() return a full link, none return plaintext, so I am really confused as to why those plaintext examples fail at all [00:26:52] why do they even call this method [00:27:19] RoanKattouw, legoktm matt_flaschen ^^ any ideas? :\ [00:27:34] mooeypoo, no, but I'll debug through in a minute. Did you make any more changes to Linker? [00:27:39] If not, I can just download your latest patch. [00:27:53] That was the same thing I was very confused about earlier. [00:27:56] no, the patch is updated [00:27:59] yeah [00:28:40] I thought maybe there are cases where if the link isn't there we only output a string, but I went over the methods in LinkRenderer and we seem to only output in all cases [00:28:46] I don't understand what changed :\ [00:29:11] The only thing I can think of is that something tries to strip the html from the but does it very badly [00:30:01] .... :((( removeSomeHtml() [00:30:14] LogFormatterTestCase::removeSomeHtml() [00:30:27] nooooooooooooooooooooooo [00:30:35] matt_flaschen, [00:30:35] $html = str_replace( '"', '"', $html ); [00:30:36] $html = preg_replace( '/\xE2\x80[\x8E\x8F]/', '', $html ); // Strip lrm/rlm [00:30:36] return trim( preg_replace( '/<(a|span)[^>]*>([^<]*)<\/\1>/', '$2', $html ) ); [00:30:40] * mooeypoo headdesks [00:31:18] mooeypoo, I pre-headdesked earlier: [00:31:20] That's crazy, though, right? Right? [00:31:30] mooeypoo, at least it's just in test code, and thus somewhat acceptable. [00:31:44] * mooeypoo nods [00:31:47] I missed your headdesk [00:31:50] Or at least understandable. Presumably to keep the expected strings readable. [00:31:56] also, uhm, correct me if I PHP wrong, but... strip_tags() ? [00:32:18] but it's a ridiculous test, though, because it will doesn't test reality! [00:32:18] mooeypoo, that's not enterprise-grade. [00:32:28] what? what do you mean [00:32:30] Kidding [00:32:37] * mooeypoo could believe anything about PHP [00:32:45] Or MW-Core's use of it [00:33:14] matt_flaschen, my answer should've been "is it voyager-grade?" but I was too busy headdesking [00:34:27] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Add ORES good-faith scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144463#2600555 (10jmatazzoni) [00:34:45] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Add ORES damaging scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2600559 (10jmatazzoni) [00:35:21] * matt_flaschen wonders how many projects I have to create before aklapper gets tired of my Herald bugs and just gives me Herald rights. [00:36:16] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2577484 (10jmatazzoni) [00:36:18] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Add ORES damaging scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2600559 (10jmatazzoni) [00:36:50] hehe [00:38:30] matt_flaschen, would it be safe to just replace this whole thing with strip_tags() ? I read the docs and there doesn't *seem* to be an obvious issue with it, and it's supported from PHP4 [00:38:38] so i'm just concerned why it wasn't used initially [00:40:20] mooeypoo, yeah, except you may need to keep the LRM/RLM strip (see comment). Ironic right? [00:40:34] hee yeah I just thought of that too [00:41:01] matt_flaschen, if we want to be thorough, we can use david's hard-character ltr/rtl regexp :P [00:42:36] matt_flaschen, I can't run those tests locally, I keep getting DB errors... so I'm going to push this in -- should I make this WIP until it's sorted? [00:42:50] oh! /logging tests just ran. Woo [00:45:34] matt_flaschen, updated. Waiting to see if it passes the tests. https://gerrit.wikimedia.org/r/#/c/307873 [00:53:02] yay! it passed! [00:53:19] ok now I can be off for the evening :P matt_flaschen RoanKattouw legoktm thanks for the help! [00:53:52] (And I want my objection on rectord about this horrible test, btw... we're testing non-realistic string in a non-realistic stripping way, which is not really testing anything) [00:55:44] mooeypoo, well, it's not testing the HTML markup, but it's testing the text construction. I would say it's decently reasonable (except the Grow Your Own strip_tags), though I probably would not have done it that way. [00:56:39] RoanKattouw, wikibugs patch: https://gerrit.wikimedia.org/r/#/c/307892/ [00:59:15] matt_flaschen: Yeah that naming scheme makes more sense, thanks. I've +2ed that patch, do I need to do anything else? [01:02:44] (03PS2) 10Catrope: Protect against target.getSurface() returning null [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) (owner: 10Paladox) [01:03:14] RoanKattouw, I don't think so. Normally I add legoktm but I thought he might be getting bored of YAML patches. :) [01:04:35] matt_flaschen: I mean, does Jenkins pick it up and automatically merge it, and do I or someone then need to do something to get it deployed? [01:06:01] jenkins merges it [01:06:11] I did the git pull in tools [01:06:31] theoretically it picks up the change automatically from there [01:06:35] Thanks! [01:06:56] try poking one of the tasks in the new project to test it? [01:07:33] Thanks, Krenair. [01:07:43] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add ORES damaging scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2600608 (10Catrope) [01:07:58] * RoanKattouw stared for a while but found an actual typo: "E.,g.," [01:08:05] people keep +2ing there without running git pull [01:08:37] It's funny you should mention that, just today I changed the VE-core ACLs so that non-deployers can no longer +2 in the wmf/* branches there [01:09:01] heh. [01:09:03] Because https://gerrit.wikimedia.org/r/#/c/307710/ happened last night [01:09:52] topic 'clear-and-destroy-wmf/1.28.0-wmf.17'? :o [01:10:16] oh, clear-and-destroy was the topic of the original commit [01:10:19] Non-deployers often don't even realize it's a cherry pick because they never deal with those, and they get auto-CCed, so it's easy to for such a commit to get +2ed blindly [01:10:21] Yeah :D [01:10:38] I hadn't thought of how that would interact with Gerrit's new branch naming pattern [01:10:43] yeah VE core is one of the more obscure cases [01:10:50] (03PS3) 10Krinkle: Escape message values where possible [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [01:10:54] there are some obvious problem areas like CentralNotice's branch [01:11:38] Yeah, I've been trying to talk them into using something more standard [01:12:06] But they have reasons for not wanting to deploy from master on a weekly cycle, and while the wmf/* branch system can deal with that it's not great [01:12:49] Krenair: Does CN's wmf_deploy branch have too loose of an ACL? Is this just an oversight, or is it actually part of their workflow? [01:12:53] (03CR) 10Krinkle: [C: 032] Escape message values where possible (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [01:12:58] I don't really understand why they're allowed to have a non-standard workflow [01:14:01] pretty sure non-deployers can merge to wmf_deploy, and deployers can't necessarily merge to it [01:14:18] Right [01:14:28] unless they are also a core dev [01:14:31] And I think Gerrit does actually do magic submodules for it so that's a problem [01:14:50] (03CR) 10jenkins-bot: [V: 04-1] Escape message values where possible [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [01:15:41] Because it would mean that random core devs could write to part of the wmf/* ecosystem [01:16:31] I suppose we could propose locking down CN's branch to the same level as the other wmf/* branches, but perhaps give fr-tech people rights on it? [01:16:47] no [01:16:57] it should be done the same as all wmf/* branches [01:17:00] That'd still be inconsistent (ideally it'd just be deployers) but it'd be a whole lot better [01:17:05] there is no need to give all fr-tech people without deployment rights access to it [01:17:26] Does fr-tech have >0 people with deployment rights? [01:17:50] Although, I guess it doesn't matter does it, whoever deploys their change can +2 stuff into the deploy branch [01:19:21] Yes [01:20:06] only like half of them have deployment rights [01:20:41] Right, and currently it's all mediawiki devs of which much fewer than half have deploy right [01:20:42] s [01:21:22] I've pinged Andrew in -releng to start a conversation about this (he and I have talked about this before), but it's late in his timezone so he may not respond until tomorrow [01:22:51] From a quick spot check it looks like they do keep to the "don't merge without deploying" rule [01:24:33] I've brought this up before [01:25:03] Don't remember what happened [01:27:00] RoanKattouw: look, there's documentation! https://www.mediawiki.org/wiki/Wikibugs#Deploying_changes [01:27:26] Krenair: it shouldn't need any manual git pull, it should auto-deploy.... [01:27:27] yeah if you want to use fabric [01:27:35] legoktm, I logged in and found it out of date [01:27:38] Nice [01:28:00] uhh, that means it's broken :S [01:28:21] https://integration.wikimedia.org/ci/job/labs-tools-wikibugs2-autopull/145/console should have done it [01:28:48] last commit was "Ignore @Phabricator_maintenance and clean up code" [01:28:55] km@km-tp ~> curl -I https://tools.wmflabs.org/wikibugs/pull.php [01:28:55] HTTP/2.0 429 [01:29:31] I had to look up that status code [01:29:34] "Too Many Requests" [01:30:15] it says that if you try to request more than once in 5 seconds [01:30:20] yeah [01:30:21] works fine now [01:30:25] idk why it didn't auto pull then [01:30:55] btw [01:31:09] Why do we have /data/project/wikibugs/wikibugs pointing to /data/project/wikibugs ? [01:31:36] no idea [01:38:25] me neither [01:38:32] maybe valhallasw knows [01:38:49] /data/project/wikibugs is a huge mess :( [03:05:11] Have a good night, all. [07:05:03] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2600759 (10Pginer-WMF) >>! In T142260#2599117, @Mooeypoo wrote: >>>! In T142260#2564336, @Pginer-WMF wrote: >> The visual metaphor used for bundles was about notifications... [07:17:39] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression: Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2600764 (10Pginer-WMF) I think that the changes work better in general except for the 99+ case, which I think can be fixed as... [07:19:51] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2600770 (10Pginer-WMF) Thanks for the clarification @Catrope. We definitely don't want the panel... [08:00:21] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2600875 (10Pginer-WMF) [08:14:24] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2600888 (10Pginer-WMF) >>! In T142785#2600021, @jmatazzoni wrote: > @Pginer-WMF, in meeting the ot... [08:26:04] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add ORES damaging scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2600893 (10Ladsgroup) In matter of data we can simply pull ores data around good faith contributions by ena... [10:20:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Adjust the styling of excerpts inside bundled notifications - https://phabricator.wikimedia.org/T139960#2601103 (10Pginer-WMF) >>! In T139960#2599501, @Catrope wrote: >>>! In T139960#2492033, @SBisson wrote: >> Should the same formatting be... [14:28:10] (03PS1) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [14:31:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [14:39:32] (03PS2) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [14:43:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) (owner: 10Sbisson) [14:51:40] (03PS3) 10Sbisson: [WIP] Update Flow caching strategy for multi DC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307951 (https://phabricator.wikimedia.org/T120009) [15:06:42] stephanebisson: joning meeting? :) [15:07:09] etonkovidova: Yes. In 25 minutes, right? [15:07:44] stephanebisson: oh, sorry :))) [15:08:06] or we can do it now [15:08:13] I can be there in 2 minutes [15:10:25] stephanebisson: I am ok to start to wait. Any time [15:11:32] etonkovidova: I am in the meeting [15:16:32] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2601657 (10jmatazzoni) [15:54:59] 06Collaboration-Team-Triage, 10Notifications: Notifications flyout is behind sitenotice - https://phabricator.wikimedia.org/T144500#2601787 (10MGChecker) [17:06:28] 06Collaboration-Team-Triage, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602019 (10Addshore) [17:15:43] 06Collaboration-Team-Triage, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602113 (10Catrope) [17:15:45] 06Collaboration-Team-Triage, 10Notifications: Notifications flyout is behind sitenotice - https://phabricator.wikimedia.org/T144500#2602115 (10Catrope) [17:16:10] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602118 (10Catrope) p:05Triage>03Unbreak! [17:19:29] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2602121 (10Catrope) Adjusting the left percentage won't cause this issue and should be doable. Fi... [18:06:17] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2602235 (10Addshore) After a quick look it looks like it has happened around 15 times in the past 10 hours accross all sites. [18:34:53] (03PS1) 10Mooeypoo: Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) [18:35:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2602310 (10Mooeypoo) Awesome, thank you! I added a class for the expanded widget and I'm using that to hide that separator when the widget is expanded... [18:35:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2602311 (10Mooeypoo) a:03Mooeypoo [18:42:32] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Update https://edit-analysis.wmflabs.org/beta-enables for Flow - https://phabricator.wikimedia.org/T144515#2602345 (10Trizek-WMF) [18:43:40] 06Collaboration-Team-Triage, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#2602361 (10Trizek-WMF) @Catrope Can run that query? I need all pages where Flow is enabled. Thanks! [18:46:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602019 (10Mooeypoo) Is this in enwiki or dewiki? I am confused with the title vs body. Also, anyone knows, mayb... [18:47:37] matt_flaschen, do you know anything about how banners work in wiki? We have this bug T144507 and my first step is to try and *get* the banner to show for me, but I think it might be location-based (?) or at least randomly or something? I can't see it. Any ideas? or... who do I ask? it's not fundraising tech that runs these, is it? [18:47:38] T144507: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507 [18:51:15] mooeypoo, I think it is CentralNotice. I know there's a way to preview it, trying to remember/figure it out. [18:52:06] (CentralNotice is an fundraising tech project) [18:53:48] matt_flaschen, RoanKattouw suggested I ask AndyRussG in -dev [18:54:12] mooeypoo, it's specific to that particular banner. [18:54:23] https://en.wikipedia.org/wiki/Main_Page?banner=wlm_2016_de vs. https://en.wikipedia.org/wiki/Main_Page?banner=wlm_2016 . [18:54:25] Second one is fine. [18:54:34] oh! thanks! [18:54:49] z-index: 99999; [18:54:50] It's what I suspected - it's animated/interactive [18:55:09] z-index: 100000; [18:55:11] Take that! [18:55:21] On the #wlm-de element (the 99999, for real() [18:55:28] ok the weird thing is that the top/sidebar of the interface is supposed to be a sibling of the content, which means no matter what z-index you put in anything in content, it should NEVER override the top [18:55:33] krinkle did that a while back [18:56:47] mooeypoo, well, the banner is in #content, but not #bodyContent. It works fine (both Echo being on top and the banner appearing fine) without the z-index: crazy. [18:57:23] why would it get that zindex at all [18:57:34] mooeypoo, it's explicitly in that particular banner. [18:57:35] I'm trying to see if there's any reason to keep a z-index in there [18:57:50] yeah no I understand, but I'm trying to see if I should work aroundit, or just tell them to take it off [18:57:57] is there any case where that banner SHOULD override something [18:58:18] ... I don't see it if there is - it's always in a reserved place and doesn't expand or anything [18:58:33] hm. Who do I talk to about this banner? Is it editable anywhere? [18:59:19] mooeypoo, I don't know why they put it in. Source code is at https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/wlm_2016_de . I don't have rights to edit it. [18:59:37] I don't see where it says the authors (if it does) [19:00:20] 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2602465 (10Dereckson) [19:00:53] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602467 (10Mooeypoo) Someone set this banner to have `z-index: 99999;` which in general is not a good idea, but... [19:00:57] addshore, do you happen to have access to this page? [19:01:12] which page? [19:01:18] oh *reads up* [19:01:27] addshore, https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/wlm_2016_de [19:01:33] indeed, I can see the page [19:02:07] #wlm-de{ ... z-index: 99999; } [19:02:09] :\ [19:02:37] I thought that's what krinkle was trying to fix, btw, with making the top/side bars separate from things in the body [19:02:49] I can't tell if I can edit anything or not! [19:03:05] addshore, it doesn't let me type into it [19:03:17] mooeypoo: same :/ [19:03:38] ahh, I am not an admin on meta :) [19:04:33] addshore, ok, I AndyRussG from fundraising tech, maybe he can help [19:04:40] if not, I'll see if we can contact a meta admin [19:04:44] :) [19:04:47] addshore, thanks for the report! [19:05:00] No worries, I just got to berlin, loaded the page and it looked all ugly ;) [19:05:16] hehe yeah.. insane z-index'es will do that [19:05:27] mooeypoo, Trizek has rights too. [19:05:36] ^ We need to fix a CentralNotice banner. [19:05:56] I would be much more impressed if it had a z-index: calc( 9999^99 ) or something. You know, at least be creative in saying "ALWAYS ON TOP!" [19:05:57] :P [19:06:02] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602489 (10Mattflaschen-WMF) The people at https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&offset=... [19:06:44] mooeypoo, we just need to wait for CSS to add AJAX, then just download all the resources, find the highest z-index, add 1, then put /* Mario */ as a comment. [19:06:57] rofl [19:06:59] Sounds like a plan! [19:09:17] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602509 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [19:09:43] matt_flaschen, thanks! [19:09:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2602527 (10jmatazzoni) [19:09:50] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build an augmenteed RCStream feed that includes ORES scores - https://phabricator.wikimedia.org/T142786#2602529 (10jmatazzoni) [19:14:12] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596519 (10jmatazzoni) Should be deduplicated with {T141319} [19:19:52] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2602588 (10jmatazzoni) a:05jmatazzoni>03None [19:33:54] 06Collaboration-Team-Triage, 10Notifications: Read cross-wiki notifications removed from cross-wiki notification history - https://phabricator.wikimedia.org/T144525#2602662 (10Pine) [19:34:14] 06Collaboration-Team-Triage, 10Notifications: Read cross-wiki notifications removed from cross-wiki notification history - https://phabricator.wikimedia.org/T144525#2602676 (10Pine) [19:57:53] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10hashar) [20:13:22] matt_flaschen: I'm not an admin on meta. [20:15:39] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Internationalization, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2602917 (10Guycn2) [20:16:10] Trizek, yeah, I know, but you're a CentralNotice admin. Can you type into the box at https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/wlm_2016_de [20:16:21] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Internationalization, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2602946 (10Guycn2) [20:17:38] matt_flaschen, actually... I can. when the page stops blinking. [20:18:33] oO [20:19:00] I'm a CentralNotice admin! [20:19:04] What!? [20:19:42] Trizek, maybe they added it when they asked you to translate something? [20:19:57] Maybe? [20:20:05] Trizek, anyway, can you just remove the whole "z-index: 99999" line, and save? We decided the z-index arms race had gone too far. ;) [20:20:07] * Trizek is going to check his rights log [20:20:42] Trizek, it fixes T144507 . [20:20:43] T144507: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507 [20:21:03] Done matt_flaschen [20:21:21] Thanks, Trizek [20:21:27] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602019 (10Trizek-WMF) z-index removed. [20:21:31] De nada matt_flaschen [20:22:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2603046 (10Mattflaschen-WMF) [20:23:30] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2602019 (10Mattflaschen-WMF) Thanks, Trizek. [20:24:13] Can we close that task, then, matt_flaschen? [20:24:36] Trizek, I put it in QA. [20:25:27] Sure. [20:27:01] (03CR) 10Mattflaschen: Clean up Special:Notifications output (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [20:27:23] (03PS13) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [20:32:54] (03CR) 10jenkins-bot: [V: 04-1] Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [20:33:51] (03CR) 10Mattflaschen: "npm failure is bogus, and it works fine, but there is a tiny bug." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [20:34:03] ^ mooey|lunch [20:35:33] * Trizek notes that comments on Gerrit are a way to end mooeypoo's lunch. :รพ [20:37:18] :D [20:37:33] Trizek: Re https://phabricator.wikimedia.org/T63747#2602361 , on which wikis do you want a list of Flow pages? [20:37:57] (03CR) 10Mooeypoo: Clean up Special:Notifications output (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [20:38:30] (03PS14) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [20:39:09] RoanKattouw: ar, ca, fr, he, pt, zh ; bs, eo, gom, pl, ru and ur + wikidata, outreach and mw.org [20:39:22] OK, thanks [20:40:07] I've tried to run queries on Quarry RoanKattouw, but I was not able to guess what was the code to use for wikidata, outreach and mw.org. [20:40:14] Oh I see [20:40:20] Did you manage for the others? [20:40:34] I didn't tried since months. [20:40:38] wikidata: wikidatawiki_p ; outreach: outreachwiki_p ; mw.org: mediawikiwiki_p [20:40:48] thanks [20:41:05] I did frwiki already, over here: https://quarry.wmflabs.org/query/12218 [20:42:40] Thanks RoanKattouw! I've been able to correct https://quarry.wmflabs.org/query/10041 for Wikidata. [20:43:08] Is there a way to create a query for a bunch of wikis at once, or is it a bad idea? [20:43:34] Not a good one that I know of, unfortunately [20:43:44] Although.... hmm [20:43:45] Lemme try something [20:43:46] RoanKattouw, you could query flowdb instead. [20:43:52] Except for the couple that are not on that. [20:43:57] Right [20:44:10] Trizek, do you know how to open the JS console? [20:44:32] yes matt_flaschen [20:44:36] You can put wgDBname there to get the code, then add _p (the _p is a Labs thing) [20:45:09] Oh yes, good trick [20:45:19] Okay. I can open the console, but that's all matt_flaschen :) [20:45:38] Trizek: Type wgDBname into the console and press enter [20:45:48] It should tell you the database name [20:45:56] Trizek: Anyway, take a look at https://quarry.wmflabs.org/query/12218 , that should let you do multiple wikis [20:47:11] Good trick, thanks! [20:48:04] Note that you have to change the wiki name twice on each line [20:48:32] That's cool, I didn't know you can UNION between different DBs. [20:49:39] "Use of "wgDBname" is deprecated. Use mw.config instead." [20:49:53] matt_flaschen, DBs are unionized now. [20:50:54] Trizek, yeah, I thought about adding 'Or mw.config.get( 'wgDBname' )' if the RL devs are around', but decided against it... [20:51:42] meh, vagrant provision is taking way too much time on my computer [20:52:25] mooeypoo, Flow is part of it, but it also helps to crack down on the roles. There are a couple that have unexpected dependencies that bring in a lot (e.g. GettingStarted). [20:52:26] I've helped to solve an Unbreak now! bug and I'm doing queries in SQL. I feel like playing an RPG: that's not me! [20:52:31] Trizek: Yeah, ignore the deprecation warning. In real code we make people write mw.config.get( 'wgDBname' ) nowadays, but in the console when we're lazy we secretly still write wgDBname [20:52:34] LOL [20:52:38] Trizek: Which UBN bug? [20:52:49] T144507 [20:52:49] T144507: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507 [20:52:56] https://phabricator.wikimedia.org/T144507 RoanKattouw [20:53:10] Oh, right [20:53:11] Thanks for that! [20:53:20] I'm (by accident) CentralBanner admin. [20:53:36] > z-index: 99999; [20:53:36] wat [20:54:05] legoktm, yeah we were going to just add z-index: 100001 (future-proofing) to Echo, but turned out there was another way. ;) [20:54:28] :D [20:54:36] might as well give everyone 3-d goggles at that point [20:54:42] :) [20:55:21] The Firefox inspector has a feature where it lays out the page in 3D [20:55:25] But I never quite got it to work right [20:56:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Wiki-Loves-Monuments: Wiki Loves Monuments Deutschland banner appears on top of notifications flyout - https://phabricator.wikimedia.org/T144507#2603163 (10Addshore) 05Open>03Resolved Looks fixed to me! [20:57:33] that looks better! :) [20:58:05] (03CR) 10Catrope: [C: 04-1] Hide xwiki widget separator when widget is expanded (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo) [20:58:18] 06Collaboration-Team-Triage, 10Flow: Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2603185 (10Trizek-WMF) [20:58:41] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2603200 (10Trizek-WMF) [20:58:43] 06Collaboration-Team-Triage, 10Flow: Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2603199 (10Trizek-WMF) [20:59:03] 06Collaboration-Team-Triage, 10Flow: Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2603185 (10Trizek-WMF) p:05Triage>03High [21:00:28] mooeypoo, although I now have to re-enable GettingStarted to test something. [21:03:17] When a query is queued on Quarry, I guess I can go to bed and be sure to have the result tomorrow? [21:04:12] Yes [21:04:18] It probably won't even take that long [21:04:44] Although if you're UNIONing those queries across ~10 DBs that might take a few minutes [21:04:53] The only thing is that if your query is too slow, it'll get killed [21:05:52] Ok, thanks RoanKattouw [21:06:20] But I forget what the limt is, and in any case, you can see that tomorrow too [21:09:14] Yep. [21:17:51] 06Collaboration-Team-Triage, 10Flow: Create a distribution list for Flow satisfaction survey - https://phabricator.wikimedia.org/T144547#2603231 (10Trizek-WMF) [21:18:45] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2603232 (10Trizek-WMF) [21:19:14] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2011357 (10Trizek-WMF) Scheduled for Sept. 6th. [21:21:15] FYI, https://quarry.wmflabs.org/query/10041 worked with multiple unions [21:22:17] guys, is there a way to find all subpages in my user page? even ones I forgot about? [21:22:26] I know one exists but forgot what it's called :\ how do I find it? [21:23:35] * Trizek goes to bed. [21:23:39] See you tomorrow! [21:23:44] bon nuit, Trizek [21:24:51] Merci mooeypoo ! [21:28:07] de rien! [21:28:16] (two more words in my lexicon!) [21:29:38] also, Trizek, every time I hear or say "rien" I hear Edith Piaf in my head [21:29:40] just saying. [21:30:58] (03PS2) 10Mooeypoo: Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) [21:45:32] mooeypoo, Special:PrefixIndex . [22:05:35] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements-Feed: Add ORES damaging scores to the ERI feed and set simplified labels to aid their interpretation - https://phabricator.wikimedia.org/T144464#2603401 (10Mattflaschen-WMF) >>! In T144464#2600893, @Ladsgroup wrote: > Also if you need a community to te... [22:05:42] Trizek: Oh nice, and you tweaked the namespace filter, I'd forgotten about ns1 on those wikis [23:04:27] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis, 13Patch-For-Review: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2603666 (10Mooeypoo) a:03Mooeypoo [23:04:40] RoanKattouw, matt_flaschen https://gerrit.wikimedia.org/r/#/c/308091/ [23:04:48] * mooeypoo hopes she did it right [23:05:00] https://meta.wikimedia.org/wiki/Schema:RecentChangesFilters <-- the new schema [23:11:10] (03CR) 10Mattflaschen: [C: 032] Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [23:11:44] ^ mooeypoo now your patch from March is merged, it would be awesome if you could review mine again. :) [23:12:22] https://gerrit.wikimedia.org/r/#/c/280366/ [23:15:44] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) (owner: 10Paladox) [23:18:05] (03Merged) 10jenkins-bot: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [23:22:11] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307820 (https://phabricator.wikimedia.org/T138356) (owner: 10Paladox) [23:24:05] mooeypoo, special:prefixindex, or just search for prefix:User:MSchottlender-WMF [23:24:11] (03Merged) 10jenkins-bot: Protect against target.getSurface() returning null [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) (owner: 10Paladox) [23:29:35] matt_flaschen, on it, just finishing up with the new logging schema [23:29:55] (03Merged) 10jenkins-bot: Pass full HTML documents into VE, not fragments [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307820 (https://phabricator.wikimedia.org/T138356) (owner: 10Paladox) [23:30:01] Thank you. [23:35:34] matt_flaschen, meh I need help searching a hook in production [23:35:52] matt_flaschen, can you see which extensions add to the $filters in SpecialRecentChangesFilters hook? [23:36:00] I need to make sure we have all active hooks in a list [23:36:29] I have the basic ones already, but in enwiki I see there are at least 2 more ('hidecategorization' and 'hideWikibase') and I am not sure if there are any others [23:36:40] mooeypoo: I think ORES does [23:37:31] mooeypoo, I just use GitHub, one sec. [23:38:27] how do you search all of them in github? O.o [23:38:29] mooeypoo, just FlaggedRevs: https://github.com/search?q=org%3Awikimedia+SpecialRecentChangesFilters&type=Code [23:39:03] mooeypoo, it will sometimes include ones that are not in production (since they're still on Gerrit). If you're not sure, of course you can just grep mediawiki-config. [23:39:47] Ah, but ORES uses ChangesListSpecialPageFilters [23:40:02] Ooh, nice [23:40:12] Yeah I noticed that FlaggedRevs has 3 hooks pointing to the same function [23:40:26] (ChangesList etc.) affects both Watchlist and RC. [23:40:39] hm, what does ORES add [23:40:55] hidenondamaging [23:41:44] mooeypoo, neither of these hooks have anything to do with user actions, FWIW. [23:43:02] They just are called internally when building the form. It still should work, but there are other hooks you could use too. [23:43:31] matt_flaschen: What do you mean exactly? [23:43:36] She's trying to figure out which filters can exist [23:43:43] There's no good way of finding all filters programmatically [23:44:00] You can't use the hook that gathers filters because you might not be the last to run [23:44:22] You also can't get it from object state (not even sure if it's stored there at all) because the filters hook is the only one that passes $this [23:44:32] RoanKattouw, no, I just mean when the hook is called. It says, "Fired when Special:RecentChanges has changed its query". I interpreted that as "when the user changes the selected query". [23:44:40] Maybe that's not what she meant, though. [23:44:51] RoanKattouw, we need to know ahead of time anyway since it's hard-coded in the schema. [23:44:58] Yes, good point [23:45:09] So, I'm pretty sure that hook is used to build the list of filters [23:45:25] including on first view [23:45:58] The way she's getting the /values/ of the filters is by looking at the WebRequest object [23:46:17] But it's hard to know what all the possible values are, and I figured grepping for uses of the hook that adds extension filters would be good [23:48:51] RoanKattouw, yeah, grepping the two hooks is a good idea, I was just a little confused by the hook description (also that one is deprecated so it would be better to switch) [23:49:05] Right [23:52:02] I have 'hidecategorization' and 'hideWikibase' which I assume also come from some extension, but I couldn't find which [23:54:04] ok hideWikibase comes from Extension:Wikidata and hidecategorization is apprently a core thing [23:54:16] How can we find any other filters? [23:55:51] mooeypoo, you need to also grep for ChangesListSpecialPageFilters. I should have made that more clear: https://github.com/search?q=org%3Awikimedia+ChangesListSpecialPageFilters&ref=searchresults&type=Code&utf8=%E2%9C%93 . [23:57:16] mooeypoo, those two combined plus SpecialRecentchanges.php + ChangesListSpecialPage.php should cover it. Also, make sure you check getName() if you use the new hook. [23:57:28] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Performance, 07Wikimedia-log-errors: 'Duplicate get(): echo:seen:alert:time and echo:seen:message:time - https://phabricator.wikimedia.org/T144534#2602820 (10Dereckson) Yes, that was present before. [23:58:22] what do you mean use getName ? [23:59:02] mooeypoo, if you use the new hook the first param will be the special page itself. You need to call $specialPage->getName() to make sure it's the RC page, or you'll also get watchlist which I assume we don't want. [23:59:15] Commented the same in a review. [23:59:39] https://www.mediawiki.org/wiki/Manual:Hooks/ChangesListSpecialPageFilters [23:59:53] getName is part of the SpecialPage class.