[00:19:37] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016): Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2596456 (10Krinkle) > but enabled on 74 wikis. 91 wikis actually (72 individual `*wiki`, `... [00:24:15] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Mobile: Different size boxes for bundled notifications - https://phabricator.wikimedia.org/T142662#2596467 (10Mooeypoo) a:03Mooeypoo [00:25:18] ok I'm off for the evening o7 [00:41:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Editing-Analysis: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596519 (10Catrope) [00:43:44] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: Instrument how often various filters on Special:Recentchanges are used - https://phabricator.wikimedia.org/T144331#2596532 (10Catrope) [00:48:21] 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2596542 (10Catrope) In my testing, I get the `Unable to get property 'model' of undefined or null reference` error when trying to edi... [01:42:38] 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2596592 (10Catrope) `Unable to get property 'model' of undefined or null reference` comes from ve.ce.Document.js line 198: `model = $... [01:57:02] (03PS1) 10Catrope: Pass full HTML documents into VE, not fragments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307672 (https://phabricator.wikimedia.org/T138536) [01:57:33] 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2596627 (10Catrope) >>! In T138356#2596592, @Catrope wrote: > `Unable to get property 'model' of undefined or null reference` comes f... [01:59:57] (03PS2) 10Catrope: Pass full HTML documents into VE, not fragments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307672 (https://phabricator.wikimedia.org/T138356) [02:05:30] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 13Patch-For-Review: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2596634 (10Catrope) a:05DLynch>03Catrope Turns out this is a race condi... [02:22:25] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 13Patch-For-Review: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2596639 (10Catrope) I was wrong again, it was a bug in `ve.init.Target` whi... [02:23:12] (03PS1) 10Catrope: Protect against target.getSurface() returning null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307677 (https://phabricator.wikimedia.org/T139972) [02:23:33] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10VisualEditor, 13Patch-For-Review: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2596641 (10Catrope) [02:23:40] 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer, 13Patch-For-Review: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2596642 (10Catrope) >>! In T138356#2596627, @Catrope wrote: >>>! In T138356#2596592, @Catrope wrote: >> `Unable... [02:24:03] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Browser-Support-Internet-Explorer, 13Patch-For-Review: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2596644 (10Catrope) [02:27:42] (03CR) 10Catrope: [C: 032] Add unwatch actions to bundle items [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [02:33:17] (03CR) 10Catrope: [C: 032] Add the best CSS rule to notifications: word-break: break-word; [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307663 (https://phabricator.wikimedia.org/T142662) (owner: 10Mooeypoo) [02:33:24] (03Merged) 10jenkins-bot: Add unwatch actions to bundle items [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [02:33:29] (03CR) 10Catrope: [C: 032] Fix line-height for notification item text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307637 (https://phabricator.wikimedia.org/T140523) (owner: 10Mooeypoo) [02:33:37] (03CR) 10Catrope: [C: 032] Adjust Special:Notifications width for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307642 (https://phabricator.wikimedia.org/T141949) (owner: 10Mooeypoo) [02:34:13] (03CR) 10Catrope: [C: 032] Fix sidebar counts Special:Notifications in monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307639 (https://phabricator.wikimedia.org/T143845) (owner: 10Mooeypoo) [02:34:36] 06Collaboration-Team-Triage, 10Augmented-Changes-Feed: Graph usage of Augmented Changes Feed - https://phabricator.wikimedia.org/T143729#2596651 (10Mattflaschen-WMF) [02:39:59] (03Merged) 10jenkins-bot: Add the best CSS rule to notifications: word-break: break-word; [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307663 (https://phabricator.wikimedia.org/T142662) (owner: 10Mooeypoo) [02:41:03] (03Merged) 10jenkins-bot: Fix line-height for notification item text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307637 (https://phabricator.wikimedia.org/T140523) (owner: 10Mooeypoo) [02:41:06] (03Merged) 10jenkins-bot: Adjust Special:Notifications width for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307642 (https://phabricator.wikimedia.org/T141949) (owner: 10Mooeypoo) [02:41:09] (03Merged) 10jenkins-bot: Fix sidebar counts Special:Notifications in monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307639 (https://phabricator.wikimedia.org/T143845) (owner: 10Mooeypoo) [03:24:54] Heading out, have a good night. [05:27:01] 06Collaboration-Team-Triage, 10Flow: "Error: One or more dependencies failed to load" in Flow on Arabic Wikipedia - https://phabricator.wikimedia.org/T144269#2596764 (10Meno25) >>! In T144269#2594932, @Trizek-WMF wrote: > That change has been introduced on the 26th by @Meno25: https://ar.wikipedia.org/w/index.... [06:15:06] 06Collaboration-Team-Triage, 10Flow: "Error: One or more dependencies failed to load" in Flow on Arabic Wikipedia - https://phabricator.wikimedia.org/T144269#2596838 (10ASammour) I think the problem is solved. The edit done by @Catrope fix the the error. But I can't really know why it was produce an error?. d... [06:23:10] 06Collaboration-Team-Triage, 10Flow: "Error: One or more dependencies failed to load" in Flow on Arabic Wikipedia - https://phabricator.wikimedia.org/T144269#2596840 (10Catrope) >>! In T144269#2596838, @ASammour wrote: > I think the problem is solved. The edit done by @Catrope fix the the error. But I can't re... [07:26:19] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, and 2 others: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2597097 (10Trizek-WMF) Removing user-notice. Not that important. But it would have been tot... [08:52:59] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Browser-Support-Internet-Explorer, 13Patch-For-Review: Editing comments in flow on mw.org does not work in IE 11 - https://phabricator.wikimedia.org/T138356#2597589 (10Paladox) Oh thanks :) [08:53:13] (03CR) 10Paladox: [C: 031] "Havent tested but looks good :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307672 (https://phabricator.wikimedia.org/T138356) (owner: 10Catrope) [08:57:14] (03CR) 10Paladox: [C: 031] Protect against target.getSurface() returning null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307677 (https://phabricator.wikimedia.org/T139972) (owner: 10Catrope) [09:51:34] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2597729 (10Elitre) >>! In T116417#2583026, @Ni... [10:57:17] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow as a Beta feature in Greek Wikipedia - https://phabricator.wikimedia.org/T144384#2597830 (10geraki) [10:57:36] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests: Enable Flow as a Beta feature in Greek Wikipedia (elwiki) - https://phabricator.wikimedia.org/T144384#2597844 (10geraki) [13:14:16] 06Collaboration-Team-Triage, 10Flow: "Error: One or more dependencies failed to load" in Flow on Arabic Wikipedia - https://phabricator.wikimedia.org/T144269#2598062 (10Aklapper) 05Open>03Resolved a:03Aklapper [13:30:08] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2598085 (10Pginer-WMF) The main problem seems to be that the counter in the badge is not consider... [14:01:20] 06Collaboration-Team-Triage, 10Flow: "Error: One or more dependencies failed to load" in Flow on Arabic Wikipedia - https://phabricator.wikimedia.org/T144269#2598168 (10Aklapper) a:05Aklapper>03Catrope [14:08:57] 06Collaboration-Team-Triage, 10Flow: [betalabs] Check mark for Resolved topics placed too low - https://phabricator.wikimedia.org/T132195#2598201 (10Pginer-WMF) The mark on mobile seems misplaced. One interesting thing I noticed is that it seems that on mobile the tick mark is placed as an inline-block (unlike... [14:12:10] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10UI-Standardization: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2598204 (10Pginer-WMF) >>! In T140962#2503762, @Mooeypoo wrote: > Should we specifically change these for Echo, or continue with standa... [14:14:41] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 07German-Community-Wishlist: Investigate case where no mention happens due to section mismatch - https://phabricator.wikimedia.org/T137897#2598235 (10Tobi_WMDE_SW) [14:14:52] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 07German-Community-Wishlist: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2598240 (10Tobi_WMDE_SW) [16:28:56] Flow is broken for me in mw-vagrant. It gets a 500 response when trying to convert between wikitext and html. Anybody else? [16:35:50] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2535636 (10Catrope) >>! In T142454#2598085, @Pginer-WMF wrote: > The main problem seems to be tha... [16:43:19] stephanebisson: There was some chatter between mooeypoo and matt_flaschen yesterday about Parsoid having made a change that breaks with MWV's Parsoid config [16:49:22] matt_flaschen, mooeypoo: was there a fix for the mwv parsoid config? [16:55:28] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-extensions-NewUserMessage: NewUserMessage should handle Flow properly; affects gomwiki/Konkani Wikipedia - https://phabricator.wikimedia.org/T131957#2598860 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [17:02:11] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Enable Flow as a Beta feature in Greek Wikipedia (elwiki) - https://phabricator.wikimedia.org/T144384#2598885 (10Trizek-WMF) Thank you for that request! I'll check some details and post a message on your... [17:02:37] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 05Goal: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#2598889 (10Trizek-WMF) [17:02:40] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Enable Flow as a Beta feature in Greek Wikipedia (elwiki) - https://phabricator.wikimedia.org/T144384#2598888 (10Trizek-WMF) [17:05:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): [betalabs] When a User session ends, the flyout displays 'Failed to fetch notifcations' - https://phabricator.wikimedia.org/T144231#2598891 (10Etonkovidova) Checked in betalabs - the proper message... [17:12:02] (03PS13) 10Mooeypoo: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [17:17:43] stephanebisson, yeah, https://gerrit.wikimedia.org/r/#/c/307661/ [17:18:38] matt_flaschen: that's pretty much what I ended up doing locally but I thought it was wrong [17:19:22] matt_flaschen: do you have any reference to tasks about it? [17:22:20] RoanKattouw, So I just fixed up the Echo part of he mobile 'mark all read' but the MobileFrontend part is still failing jenkins because it's looking for a message that is in that patch in Echo [17:22:30] for some reason it's ignoring the fact that there's a Depends-On statement [17:22:42] So whoever's reviewng, please ignore Jenkins' failure? :\ [17:22:49] stephanebisson, no, but we checked with subbu. They did the same thing in production: https://gerrit.wikimedia.org/r/#/c/305994/1/conf/wmf/localsettings.js . [17:23:06] Well, ignore for the sake of *review*. The Echo patch should still be merged first. [17:23:10] matt_flaschen: ah ok [17:23:24] Hmm, weird though, Depends-On should fix that [17:23:42] RoanKattouw, I know... maybe it failed because the Echo patch had a jenkins-failure ? [17:23:45] I'll try to rechck [17:23:57] That shouldn't be (directly) related [17:24:11] RoanKattouw, does the Depends-On need to be above the Change-Id ? [17:24:18] I don't think it matters [17:24:33] mooeypoo: Link me to the patch? [17:24:50] https://gerrit.wikimedia.org/r/#/c/306288/ [17:25:22] Just n case, I moved Depends-On up [17:25:56] woah https://integration.wikimedia.org/zuul/ <-- seems it'll take a while for Jenkins to check this [17:25:58] stephanebisson, BTW, Aaron was asking about your caching work. Did you see my email about the meeting? Also, is there an update on that for Scrum of Scrums? [17:28:13] mooeypoo: That looks right. Not sure if abbreviated change IDs are OK for Depends-On but I think I've seen that work before [17:29:25] stephanebisson, mooeypoo, RoanKattouw, anything for SoS (sorry for not asking earlier)? So far I have Flow caching, the unwatch work, Flow VE fixes, and the server-side message poster [17:29:27] I can put the full one [17:29:51] maybe mw.notify dilemma? Not sure [17:30:20] mooeypoo, oh yeah, we're blocked on that, right? Is it getting the necessary attention, or should I ask for more eyes? Task? [17:30:37] We're not blocked anymore, since I created our own widget [17:30:47] matt_flaschen: I saw your email about the meeting but I haven't gone. We're now 1) using WanCache, 2) deleting on write and setting on read. But it's really hard to tell (and to test) if we're doing the right thing with TTLs and options to prevent race conditions and stale values. I'll upload my WIP soon. [17:31:04] But it's something worth dealing with at some point. MobileFrontend isn't the only one to suffer from it, probably. It's moving along, but might be a good thing to know for other teams. [17:31:55] matt_flaschen, there's a long discussion in the patchset: https://gerrit.wikimedia.org/r/#/c/306560/ [17:33:00] stephanebisson, my understanding is it is supposed to prevent slave-lagged values automatically (after you delete it's supposed to block slave-lagged values from getting saved based on knowing the slave lag duration). [17:33:03] Thanks, mooeypoo. [17:36:09] matt_flaschen: In the examples I've seen you give it options based on the db you used to fetch the data and it figures out the slave lag and so on. In Flow, without removing the indexes completely (which would be my preference), cache manipulation and the db object and quite far from each other. [17:36:28] stephanebisson: If you have questions about WANCache, ask AaronSchulz in #wikimedia-perf, he tends to be happy to explain things and/or have his brain picked [17:38:40] RoanKattouw: I will when I have clear questions. WanCache in-code documentation is really good. It's Flow that confuses me. [17:38:53] Fair enough :) [17:39:12] And yes I agree, the WANCache is quite well-documented [17:50:51] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, and 2 others: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2599074 (10Etonkovidova) Re-checking for - all looks good - truncation for long titles A l... [18:05:23] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2599117 (10Mooeypoo) >>! In T142260#2564336, @Pginer-WMF wrote: > The visual metaphor used for bundles was about notifications being stacked on top of each other. The line... [18:24:15] jmatazzoni___, I setup the Q2 board: https://phabricator.wikimedia.org/project/view/2198/ . [18:48:37] (03PS11) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [18:52:32] (03CR) 10jenkins-bot: [V: 04-1] Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [19:17:17] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): In mobile view, bundled notifications extend outside the screen limit - https://phabricator.wikimedia.org/T140523#2599428 (10Etonkovidova) Checked for the font-size/line-height adjustments (checked... [19:23:37] mooeypoo: Patches for your review: https://gerrit.wikimedia.org/r/307677 https://gerrit.wikimedia.org/r/307672 [19:25:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Adjust the styling of excerpts inside bundled notifications - https://phabricator.wikimedia.org/T139960#2448070 (10Catrope) >>! In T139960#2492033, @SBisson wrote: > Should the same formatting be applied to `flow[usertalk]-new-topic`? Mayb... [19:29:11] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Mobile, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Different size boxes for bundled notifications - https://phabricator.wikimedia.org/T142662#2599528 (10Etonkovidova) The issue is fixed - checked in betalabs: {F4420780} In a foreign w... [19:29:57] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2599532 (10Jdforrester-WMF) [19:44:05] (03CR) 10Catrope: [C: 04-1] Add confirmation popup widget (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [19:45:14] (03CR) 10Mooeypoo: [C: 032] Pass full HTML documents into VE, not fragments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307672 (https://phabricator.wikimedia.org/T138356) (owner: 10Catrope) [19:53:00] (03Merged) 10jenkins-bot: Pass full HTML documents into VE, not fragments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307672 (https://phabricator.wikimedia.org/T138356) (owner: 10Catrope) [20:01:12] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Adjust the styling of excerpts inside bundled notifications - https://phabricator.wikimedia.org/T139960#2448070 (10Etonkovidova) Bundled replies have text excerpts and, accordingly, the text excerpts are now displayed grey (on both user-tal... [20:22:59] And I see it as a Milestone on Triage. So looks good. Thanks Matt! [20:28:38] (03PS1) 10Paladox: Pass full HTML documents into VE, not fragments [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307820 (https://phabricator.wikimedia.org/T138356) [20:30:07] RoanKattouw, I am disappointed... you can probably rewrite line #166 in a single-line horrifically-convoluted return condition, sir! https://gerrit.wikimedia.org/r/#/c/307677/1/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js [20:30:08] :P [20:30:44] Yes, I guess you can [20:30:58] RoanKattouw, seriously, though, why would we have a case where target exists but not surface? [20:31:01] return !this.target || !this.target.getSurface() || !blahblah.isEmpty(); I suppose [20:31:14] mooeypoo: Because VisualEditorWidget#setContent destroys and recreates the surface [20:31:21] RoanKattouw, that wasn't a serious invitation, it's clearer this way, I just thought it was amusing :P [20:32:09] though I guess that's not all that horrible condition. I expected a much more convoluted one. !( opposite of that ) ? :D [20:32:27] oh, right, ve recreates the surface. Ok, yeah [20:33:02] just saw the related patch in ve [20:33:50] (03CR) 10Mooeypoo: [C: 032] Protect against target.getSurface() returning null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307677 (https://phabricator.wikimedia.org/T139972) (owner: 10Catrope) [20:36:48] mooeypoo: Yeah, the horrible condition was the part where after you did clearSurfaces(), getSurface() would keep returning a dead/destroyed/detached surface [20:37:03] That's what caused a lot of the Flow/VE bugs, and was quite confusing to debug [20:38:18] yeah I think I remember someone saying something about it [20:40:25] (03PS1) 10Paladox: Protect against target.getSurface() returning null [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) [20:42:29] (03Merged) 10jenkins-bot: Protect against target.getSurface() returning null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307677 (https://phabricator.wikimedia.org/T139972) (owner: 10Catrope) [21:08:09] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/307873/ [21:09:42] hm I'm wondering if instead I should edit Linker::userLink() to be isolated. [21:21:39] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2600021 (10jmatazzoni) @Pginer-WMF, in meeting the other day we talked about the desirability of a... [21:33:50] (03PS12) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [21:46:02] (03PS15) 10Mooeypoo: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [21:48:06] (03PS16) 10Mooeypoo: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [21:48:10] (03CR) 10Mooeypoo: Add confirmation popup widget (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [21:55:04] RoanKattouw or mooeypoo, could you review https://gerrit.wikimedia.org/r/#/c/305746/ (GettingStarted) when you have a chance? [22:01:15] mooeypoo: You could ask legoktm for input, he's been changing things in Linker recently [22:01:22] hello [22:02:17] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build new filtering interface for ERI - https://phabricator.wikimedia.org/T144448#2600121 (10jmatazzoni) [22:02:44] mooeypoo: yeah, that would be better in user link I think [22:02:50] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2546290 (10jmatazzoni) [22:02:52] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build new filtering interface for ERI - https://phabricator.wikimedia.org/T144448#2600136 (10jmatazzoni) [22:03:57] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build new filtering interface for ERI - https://phabricator.wikimedia.org/T144448#2600121 (10jmatazzoni) [22:11:00] out for a late/long lunch, bbl. [22:12:25] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Add ORES good-faith and damaging scoring display and new user flag to RC Page - https://phabricator.wikimedia.org/T144451#2600193 (10jmatazzoni) [22:13:10] 36.1° N, 115.1° W [22:13:19] Wait no, that's a lat/long lunch. [22:13:23] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2546290 (10jmatazzoni) [22:13:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Add ORES good-faith and damaging scoring display and new user flag to RC Page - https://phabricator.wikimedia.org/T144451#2600193 (10jmatazzoni) [22:16:08] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Add ORES good-faith and damaging scoring display and new user flag to RC Page - https://phabricator.wikimedia.org/T144451#2600211 (10jmatazzoni) [22:17:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build new filtering interface for ERI - https://phabricator.wikimedia.org/T144448#2600121 (10jmatazzoni) [22:23:04] (03CR) 10Paladox: "+1" [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) (owner: 10Paladox) [22:38:31] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design beta feature option for new ORES filtering tools on RC page - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) [22:41:14] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2600331 (10jmatazzoni) [22:41:16] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design beta feature option for new ORES filtering tools on RC page - https://phabricator.wikimedia.org/T144457#2600330 (10jmatazzoni) [22:42:46] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design beta feature option for new ORES filtering tools on RC page - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) I'm assigning myself the first 2 parts of this, which are to think through the name and wording. [22:53:11] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 07Tracking: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2600352 (10jmatazzoni) [22:57:54] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design beta feature option for new ORES filtering tools on RC page - https://phabricator.wikimedia.org/T144457#2600366 (10jmatazzoni) [22:57:56] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build new filtering interface for ERI - https://phabricator.wikimedia.org/T144448#2600368 (10jmatazzoni) [22:57:58] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for displaying and filtering ORES Good-Faith and Damaging scores as well as New Users flag - https://phabricator.wikimedia.org/T142785#2600369 (10jmatazzoni) [22:58:00] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 07Tracking: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2600365 (10jmatazzoni) [22:58:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Launch ERI RC page features as a beta on relevant wikis - https://phabricator.wikimedia.org/T144458#2600352 (10jmatazzoni) [23:02:24] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2600380 (10jmatazzoni) 05Open>03Resolved [23:08:29] (03CR) 10Mattflaschen: "Paladox, I've asked you before not to +1 your own patches, particularly empty +1's (https://gerrit.wikimedia.org/r/#/c/151203/)." [extensions/Flow] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/307869 (https://phabricator.wikimedia.org/T139972) (owner: 10Paladox) [23:09:01] legoktm, can I ask you a question about this commit btw? If you already reviewed it a bit? [23:09:11] sure [23:09:14] what's up? [23:09:45] legoktm, I'm wondering if I should just wrap all Linker::userLink() output with but i was worried of changing the "meaning" of it (this means that the output will not be a link, but a ... output) [23:10:04] and that might cause issues. On the other hand, outputting it there would mean that even external stuff will get the same isolation behavior [23:10:20] so... should I do it, or should I stick to only isolating the 2 methods I already corrected in that patch? [23:10:52] legoktm, but I don't know if anything actually uses userLink() directly [23:11:18] lots of things do [23:11:19] oh, make that a yes. I grepped wrong last time. So, a lot of places. [23:11:20] yeah [23:11:23] but I think it make ense [23:11:34] makes sense* [23:11:48] to wrap it there directly, or only the two methods using it in Linker like I do now? [23:12:11] Sadly, we can't trust CSS here (otherwise I'd have just added a class and a base isolation style) :( [23:13:20] mooeypoo, it's probably fine since altUserName has to be plain text. If it were HTML there could be weird things like certain tags not allowed inside bdi. [23:13:48] Could you reverse it so is on outside and on inside? Don't know if that even makes a difference though. Your original idea seems alright. [23:14:24] matt_flaschen, I thought of that, but I am not sure I can inside userLink() without editing the way Linker::link() is done [23:14:27] mooeypoo: wrap userLink directly. [23:14:53] mooeypoo: also, if you want the tag inside, you can just put it on either side of the htmlspecialchars() call [23:15:03] hmmm [23:15:05] also, why can't we trust CSS? [23:15:08] good point [23:15:15] legoktm, sadly, bdi-isolation calls are not working well [23:15:23] oh [23:15:30] so browser support? [23:15:35] Some of them are defined explicitly to be 'internal' to the browser [23:15:44] it's consisent across browsers that they're not working well :P [23:15:45] mooeypoo, I don't even know any reason the should be on the outside, just responding to what you said. It's probably fine to do the on outside, but it could be done either way. [23:15:52] "embed" works fine, but isolate doesn't [23:16:04] Surprisingly there does not appear to be any CSS equivalent to tags [23:16:12] We tried this for a thing in Echo a few months ago [23:16:14] Yeah it's SUPPOSED to be 'isolate' [23:16:17] but that's not working :( [23:16:23] Went through every single value of the property and some of them don't even work as documented [23:16:45] matt_flaschen, legoktm okay, so I will change userLink directly. What are we agreeing on would be safer -- wrap with or put the inside? should be the same effect of isolation [23:16:53] A lot of them appear to behave the same as each other, and some come close, but none of them behave quite like [23:17:08] And yes vs shouldn't make a difference in the browser, [23:17:17] except for > a selectors etc [23:17:34] Hmmm good point for selectors. Would it be better to put it inside, then? [23:17:50] probably be safer on CSS [23:19:56] ok RoanKattouw matt_flaschen legoktm https://gerrit.wikimedia.org/r/#/c/307873/ [23:20:55] You guys think this changes anything worthwhile enough to announce or anything? I'm just worried about screwing up behavior that depends on ... something... in there. It's used in a lot of places. [23:25:01] But we can finally stop getting annoyed at usernames appearing as (MSchottlender_(WMF in RTL wikis (or vise versa in LTR wikis) [23:25:16] mooeypoo, you could put it in release notes, don't think it's likely to break stuff unless there is weird CSS). Doesn't impact the parser. [23:25:24] mooeypoo, so you're saying I changed my name for nothing?! [23:26:05] matt_flaschen, ?yrros ,mhu [23:26:06] :P [23:26:27] Seriously, though, these nicknames will *still* have issues (like in signatures for example) [23:26:33] but... they'll have ... *less* issues. [23:27:01] mooeypoo: you're going to have to update unit tests [23:27:17] oh, forgot about those. We have unit tests for the Linker ? [23:27:21] yeah :) [23:27:45] * mooeypoo found the file [23:28:07] wait.. what is going on in there [23:28:11] testUserLink( ... ) [23:28:18] it's not actually called anywhere [23:29:25] oh, my... it's... okay. Wow. [23:29:28] mooeypoo, there are also a lot of indirect failures. [23:29:46] I'm trying to figure out how to run that test, since I'm going to fix the test cases [23:30:03] mooeypoo: [23:30:25] php5 /vagrant/mediawiki/tests/phpunit/phpunit.php --wiki=wiki /vagrant/mediawiki/tests/phpunit/includes/SomeTest.php [23:30:36] matt_flaschen, woot, thanks! [23:30:38] Also works for directories. [23:31:05] There's something weird going on in those test failures, though. [23:31:23] hmmmm [23:31:25] It *looks* like before it was formatting it as a link then extracting the text, and now the extraction is broken due to bdi. [23:31:29] That's crazy, though, right? Right? [23:31:31] seems everything passes for me except for this: [23:31:33] -'::1' [23:31:34] +'::1' [23:31:39] ^^ why is the ::1 not being wrapped? [23:32:00] From Jenkins: 23:22:25 Tests: 11243, Assertions: 75339, Failures: 81, Skipped: 14. [23:32:27] mooeypoo, you updated the expected? [23:32:37] matt_flaschen, yep, I wrapped all of them with bdi [23:32:55] oh! omg, I forgot one. There are 3 ::1's [23:32:57] * mooeypoo grunts [23:33:15] I thought the failure was the other way around - that we use something else for anon use or something. My bad, sorry, ha [23:34:09] matt_flaschen, I am not getting any failures, so I assume these are from the other tests than the Linker [23:35:02] whaaat... [23:35:03] hm [23:35:07] mooeypoo, yeah, they are. See the Jenkins output. [23:35:09] I should run all the tests, then [23:35:12] yeha I see [23:36:03] mooeypoo, I think just includes/logging gets you all. [23:36:53] hm, I just had db errors when trying to run the whole test suite [23:36:55] :\ [23:47:18] brb [23:57:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016): Explore process for turning on RCPatrol for English and other relevant wikis - https://phabricator.wikimedia.org/T142782#2600491 (10jmatazzoni) Some interesting comments from @MattFlaschen-WMF on the notion of in...