[07:29:07] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Buttons of HTML e-mails don't like small screens - https://phabricator.wikimedia.org/T115808#2590048 (10Sjoerddebruin) Things didn't improve in the last few months: {F4412067}
[09:09:13] <wikibugs>	 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Measure survival rate of new users who go through the constructive review process - https://phabricator.wikimedia.org/T143754#2590233 (10Pginer-WMF) As a reference, [[ https://meta.wikimedia.org/wiki/Research:Newcomer_quality | in this research about new...
[10:53:11] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2590410 (10Paladox)
[11:24:59] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer: Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2590531 (10Sjoerddebruin)
[11:58:20] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2590560 (10Pginer-WMF) >>! In T142785#2582522, @Halfak wrote: > hey @Pginer-WMF, we're working on an even more basic integration of "good-faith...
[12:24:15] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Browser-Support-Internet-Explorer: Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2590611 (10Paladox)
[12:49:04] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Find the correct limits for mentions - https://phabricator.wikimedia.org/T142988#2590746 (10Tobi_WMDE_SW) 05Open>03Resolved
[12:49:19] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2590752 (10Tobi_WMDE_SW) 05Open>03Resolved
[12:57:54] <wikibugs>	 06Collaboration-Team-Triage, 10Thanks, 10Revision-Slider, 06TCB-Team, and 4 others: RevisionSlider fails to re-trigger the Thanks JS code when the diff changes - https://phabricator.wikimedia.org/T142636#2590772 (10Tobi_WMDE_SW)
[13:20:10] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Flow blue point turn off does not mark topics as read for watchlist - https://phabricator.wikimedia.org/T144179#2590869 (10IKhitron)
[14:24:11] <wikibugs>	 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2591064 (10Trizek-WMF) Discussed about th...
[15:47:19] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Flow blue point turn off does not mark topics as read for watchlist - https://phabricator.wikimedia.org/T144179#2591335 (10Aklapper) Flow notice about what kind of event? "On Refresh" of which specific page? Special:Watchlist ?  A...
[15:51:55] <grrrit-wm>	 (03PS1) 10WMDE-leszek: Re-add actions to Thanks links when a diff on the diff page changes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/307317 (https://phabricator.wikimedia.org/T142636) 
[15:53:45] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Flow blue point turn off does not mark topics as read for watchlist - https://phabricator.wikimedia.org/T144179#2591377 (10IKhitron)
[15:55:01] <wikibugs>	 06Collaboration-Team-Triage, 10Thanks, 10Revision-Slider, 06TCB-Team, and 4 others: RevisionSlider fails to re-trigger the Thanks JS code when the diff changes - https://phabricator.wikimedia.org/T142636#2591385 (10WMDE-leszek) @Legoktm yes, this makes sense. I've submitted https://gerrit.wikimedia.org/r/3...
[16:00:06] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Flow blue point turn off does not mark topics as read for watchlist - https://phabricator.wikimedia.org/T144179#2591433 (10IKhitron) Very well. Fixed. And here are the steps, for example: # User A creates some topic on Flow board...
[16:33:38] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2591781 (10Feldo) Any release date for this new toolbar?
[16:36:24] <wikibugs>	 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Design: Explore design solutions for finding users to help reviewing - https://phabricator.wikimedia.org/T137783#2591803 (10Pginer-WMF)
[17:01:05] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2591922 (10Trizek-WMF) No. There is still some design issues and the priority is not on having major changes on Flow at the moment.
[17:48:27] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2592079 (10Elitre) (The 2 things I miss the most in Flow so far are "Remove formatting" and a button to add curly brackets.)
[17:59:56] <grrrit-wm>	 (03CR) 10Mooeypoo: Style and text fixes for unwatch actions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo)
[18:23:26] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 6 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2592241 (10matej_suchanek)
[18:23:42] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review, and 3 others: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#2592247 (10greg) Status? Is this re-opened task still UBN! ? the associated patch is merged.  What ne...
[18:53:21] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: [betalabs] When a User session ends, the flyout displays 'Failed to fetch notifcations' - https://phabricator.wikimedia.org/T144231#2592465 (10Etonkovidova)
[19:02:05] <mooeypoo>	 etonkovidova, on it ^^
[19:02:39] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: [betalabs] When a User session ends, the flyout displays 'Failed to fetch notifcations' - https://phabricator.wikimedia.org/T144231#2592485 (10Mooeypoo) a:03Mooeypoo On it.
[19:04:15] <etonkovidova>	 mooeypoo: so, 'You can watch this page any time" -- 'this page' link is still displayed for unwatched topics ....
[19:15:08] <mooeypoo>	 etonkovidova, is that merged yet?
[19:15:10] <mooeypoo>	 I think it isn't merged
[19:15:17] <mooeypoo>	 it's part of the fix that RoanKattouw -1'ed and I answered
[19:15:35] <etonkovidova>	 mooeypoo: it says - merged. hmmm - and I see the empty star
[19:15:56] <etonkovidova>	 ah - ok will ask RoanKattouw
[19:16:03] <mooeypoo>	 etonkovidova, the empty star is merged (different patch, since it's in Echo repo, and the topic text is in Flow repo)
[19:16:24] <mooeypoo>	 etonkovidova, https://gerrit.wikimedia.org/r/#/c/307027/ <-- this is the 'topic' text change + style changes
[19:16:48] <mooeypoo>	 etonkovidova, sorry, the fixes are separate because one was in the Echo repository and the other in the Flow repo
[19:17:02] <mooeypoo>	 The star is generalized (in Echo) but the topic text is specific for Flow
[19:17:37] <RoanKattouw>	 mooeypoo: Wait, so does isBundled() mean "this is PART OF an expandable bundle", or "this IS a bundle"?
[19:17:45] <RoanKattouw>	 I thought it was the latter
[19:18:20] <RoanKattouw>	 Based on how the diff and agent links get dropped in the isBundled() case
[19:18:27] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2592533 (10Etonkovidova) Checked in betalabs   - the specs for...
[19:18:46] <mooeypoo>	 "bundled" (ed at the end) is the item is bundled. "isBundle" is this is a bundle. That's the nomenclature stephane and I agreed on, but... I ... may have misunderstood the code?
[19:18:57] <RoanKattouw>	 OK, that sounds reasonable
[19:18:58] <mooeypoo>	 This is the backend version of the front end nomenclature
[19:19:17] <RoanKattouw>	 But in https://gerrit.wikimedia.org/r/#/c/307027/2/includes/Notifications/PostEditedPresentationModel.php for instance you're reusing an existing if statement that drops agent and diff links in the non-bundle case
[19:19:21] <RoanKattouw>	 So I think that's bundleD
[19:19:31] <RoanKattouw>	 Sorry, bundle without the d
[19:19:44] <RoanKattouw>	 As in, I think that's for the whole thing rather than the subitems
[19:19:52] <RoanKattouw>	 Or, if it's the other way around, then that's wrong for the agent/diff links
[19:20:01] <mooeypoo>	 $this->isBundled
[19:20:04] <mooeypoo>	 there's a 'd' at the end
[19:20:07] <RoanKattouw>	 Yes
[19:20:15] <RoanKattouw>	 So then maybe your code is correct but the surrounding code is wrong?
[19:20:23] <mooeypoo>	 We don't want "unwatch" in the individual bundled items
[19:20:27] <mooeypoo>	 only in the general bundle itself
[19:20:30] <RoanKattouw>	 Yes, I understand that, but
[19:20:37] <RoanKattouw>	 If that code works the way you say it does
[19:20:56] <RoanKattouw>	 Then individual bundled items don't have agent and diff links and the general bundle does
[19:21:05] <RoanKattouw>	 And that seems backwards
[19:21:16] <mooeypoo>	 WARNING: Code-relevant self-confidence level dropping.
[19:21:31] <mooeypoo>	 That does seem backwards.
[19:21:45] <RoanKattouw>	 Because one post (this is PostEditedPresentationModel) could have been edited multiple times (different diff links) by multiple people (different agent links)
[19:21:46] <mooeypoo>	 Meh, did we get the terms wrong?
[19:21:54] <mooeypoo>	 Yes.
[19:21:59] <RoanKattouw>	 So either that code was already wrong, or your addition is wrong
[19:22:02] <mooeypoo>	 When you look at that bundle, where are the links?
[19:22:14] <mooeypoo>	 And if i am wrong, i'm wrong in the rest of the code, too, it seems
[19:22:56] <mooeypoo>	 meh please don't tell me $this->isBundled() is a *bundle* rather than a bundled item
[19:22:58] * mooeypoo sobs
[19:24:33] <mooeypoo>	 RoanKattouw, hang on, I'm finishing up a small fix and I'll double-check
[19:25:53] <RoanKattouw>	 OK
[19:26:27] <RoanKattouw>	 Yeah please check how it behaves. I'm equally willing to believe that the pre-existing code was wrong, because this stuff is confusing
[19:26:48] <RoanKattouw>	 But I am convinced that one of the two things is wrong
[19:27:02] <mooeypoo>	 yeah you're right
[19:27:11] <mooeypoo>	 I'll check in a minute after finishing this (small) patch
[19:28:35] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Making notifications about Flow topics/boards as read should also unbold them on Special:Watchlist - https://phabricator.wikimedia.org/T144179#2592563 (10Catrope)
[19:32:40] <mooeypoo>	 aaaaaa my computer is so slow with vagrant :(
[19:57:28] <grrrit-wm>	 (03PS1) 10Mooeypoo: Display a message when API fail due to session end [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) 
[20:00:54] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 07Browser-Support-Internet-Explorer: VisualEditor on Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2592666 (10Mattflaschen-WMF)
[20:01:52] <mooeypoo>	 RoanKattouw, you're right :(( 'isBundled' means this is the bundle
[20:01:58] <mooeypoo>	 not an item inside the bundle
[20:02:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Display a message when API fail due to session end [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) (owner: 10Mooeypoo)
[20:03:00] <mooeypoo>	 RoanKattouw, I am super confused, though. If I remove this from the general item and put it in the bundle, then it won't show on those items when they're unbundled either
[20:03:15] <mooeypoo>	 it seems we don't have a way to separate a bundled **item** from a regular item... 
[20:03:26] <mooeypoo>	 so I don't know if I can do what Pau requested at this moment.
[20:05:11] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review, and 3 others: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#2592672 (10Mattflaschen-WMF) p:05Unbreak!>03High Will be QA'ed then resolved.  Changing to High.
[20:29:31] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Cannot see or clear unread notifications at Beta Cluster - https://phabricator.wikimedia.org/T141816#2592713 (10Etonkovidova) Re-checked in betalabs -  no issues found.
[20:34:18] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Regression, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): [betalabs-Regression] Special:Notifications - the pagination does not follow default pattern of 50 messages per page - https://phabricator.wikimedia.org/T141463#2592717 (10Etonkovidova) Check...
[21:16:40] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 07Browser-Support-Internet-Explorer: VisualEditor on Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2592860 (10Catrope)
[21:16:42] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2592862 (10Catrope)
[21:17:03] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397842 (10Catrope) 05duplicate>03Open Dammit, I duped in the wrong direction AGAIN.
[21:17:25] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2592868 (10Catrope)
[21:17:27] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 07Browser-Support-Internet-Explorer: VisualEditor on Flow fails to allow you to edit a comment on Internet Explorer 11 - https://phabricator.wikimedia.org/T144164#2590410 (10Catrope)
[21:19:48] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 07Wikimedia-log-errors: Request has exceeded memory limit DiscussionParser::getFullSection - https://phabricator.wikimedia.org/T144141#2592872 (10Catrope) Does this appear in the logs often? Does this happen in wmf15 too, or is it new in wmf16? @Addshore et al re...
[21:22:16] <RoanKattouw>	 matt_flaschen: Are you working on (or do you plan to work on) https://phabricator.wikimedia.org/T144050 ? Asking for triage purposes
[21:24:05] <RoanKattouw>	 Given your WIP patch from 3 minutes ago I'm gonna guess the answer is "yes, after I finish the MessagePoster itself"
[21:24:36] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2592905 (10Catrope) a:03Catrope
[21:26:33] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Making notifications about Flow topics/boards as read should also unbold them on Special:Watchlist - https://phabricator.wikimedia.org/T144179#2590869 (10Quiddity) I've noted the proposal at https://www.mediawiki.org/wiki/Topic:Ta...
[21:27:44] <matt_flaschen>	 RoanKattouw, no, I wasn't actually planning to do that right now (if it ain't broke), just NewUserMessage (which kabwiki needs, which is why I'm working on this to begin with).
[21:27:55] <RoanKattouw>	 OK, thanks
[21:28:03] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2592912 (10Paladox) It seems we are getting a new error.  Could the priority be risen to high priority since it makes it diffulculty in editing your comment in flow please?
[21:28:15] <matt_flaschen>	 I accidentally put them in triage since I used subtasks.
[21:28:25] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10MediaWiki-Watchlist: Making notifications about Flow topics/boards as read should also unbold them on Special:Watchlist - https://phabricator.wikimedia.org/T144179#2592913 (10IKhitron) Thanks.
[21:30:38] <matt_flaschen>	 RoanKattouw, I'll do PageTriage, though, since it's broken.  The others (WikiLove and MassMessage) already work with Flow, so I'll leave them for now.  You can even untag them if you want.  I just wanted to have tasks as a TODO.
[21:31:13] <RoanKattouw>	 No worries, Joe just wanted to know if this is happening soon or not son
[21:31:15] <RoanKattouw>	 *not soon
[21:31:33] <matt_flaschen>	 Untag with the triage board I mean.  It only has that tag accidentally since I used a subtask.
[21:31:47] <RoanKattouw>	 Huh? I'd have to untag Echo to do that
[21:31:51] <RoanKattouw>	 Which I guess I could...
[21:32:02] <RoanKattouw>	 *untag Flow
[21:32:51] <matt_flaschen>	 RoanKattouw, T144050 and T144053 are not tagged Flow.
[21:32:51] <stashbot>	 T144053: Use server-side MessagePoster in MassMessage  - https://phabricator.wikimedia.org/T144053
[21:32:52] <stashbot>	 T144050: Use server-side MessagePoster in WikiLove - https://phabricator.wikimedia.org/T144050
[21:34:04] <matt_flaschen>	 Oh, never mind, WikiLove is also auto-tagged since we own that.
[21:34:23] <matt_flaschen>	 And the subtasks are in the other direction.
[21:35:49] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications: Create notice bundle for flow resolved topics - https://phabricator.wikimedia.org/T143524#2570531 (10Catrope) Do these "resolve topic" actions happen on the same page (Flow board), or on different pages? We typically only create bundles for notifications...
[21:38:34] <mooeypoo>	 RoanKattouw, it seems I can either put the 'stop watching' only in the individual bundled items (and then in normal items) or in BOTH the normal/bundled items *and* the bundle itself.
[21:41:30] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications: Create notice bundle for flow resolved topics - https://phabricator.wikimedia.org/T143524#2570531 (10jmatazzoni) Catrope wrote: > We typically only create bundles for notifications that are both of the same type and related to the same page/topic/somethin...
[21:43:21] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10ConfirmEdit (CAPTCHA extension), 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Flow not displaying Captcha of Extension:ConfirmEdit-ReCaptchaNoCaptcha - https://phabricator.wikimedia.org/T143516#2570309 (10Catrope) a:05Catrope>03Mattflaschen-WMF
[21:43:58] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Ask communities which have allowed Flow trials with manual enabling to switch to Beta feature activation - https://phabricator.wikimedia.org/T143470#2592964 (10Quiddity) a:03Trizek-WMF
[21:44:02] <grrrit-wm>	 (03PS1) 10Catrope: Override white background on hover for links in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307431 (https://phabricator.wikimedia.org/T144063) 
[21:44:13] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Hover state has white box in Monobook - https://phabricator.wikimedia.org/T144063#2592970 (10Catrope) a:03Catrope
[21:45:19] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Notifications: Create notice bundle for flow resolved topics - https://phabricator.wikimedia.org/T143524#2592973 (10IKhitron) For me and for now, the same page will be good enough, because I have less than 10 flow boards watched. In the future and for all, filtering is...
[21:46:34] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2592976 (10Mooeypoo) I'm running into a technical problem: Rig...
[21:47:20] <mooeypoo>	 RoanKattouw, ^^ meh
[21:48:51] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10VisualEditor: "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2592980 (10Quiddity)
[21:49:07] <RoanKattouw>	 mooeypoo: In the meantime, can you split the patch so the uncontroversial things (e.g. message changes) can be merged?
[21:49:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Override white background on hover for links in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307431 (https://phabricator.wikimedia.org/T144063) (owner: 10Catrope)
[21:49:39] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2592981 (10jmatazzoni)
[21:49:56] <mooeypoo>	 RoanKattouw, yes......... except my git cheatsheet is at the office. 
[21:50:29] <mooeypoo>	 RoanKattouw, can you remind me how to split out one file?
[21:50:42] <mooeypoo>	 luckily, no need for -p 
[21:51:29] <RoanKattouw>	 git reset HEAD^ filename
[21:51:30] <RoanKattouw>	 git commit --amend
[21:51:33] <RoanKattouw>	 git commit -a
[21:52:05] <RoanKattouw>	 Then use git log to inspect the order of the two commits and use git rebase -i HEAD~2 to reword or reorder
[21:52:46] <wikibugs>	 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Easy, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Copyedit for Echo i18n string - "this" to "these" - https://phabricator.wikimedia.org/T143072#2592985 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni
[21:56:45] <legoktm>	 mooeypoo: I like the git-cola GUI for helping me stage selective changes, because you can pick which lines you want to commit directly with your mouse and pretty diffs
[22:02:16] <mooeypoo>	 legoktm, typing git commands in the terminal makes me feel like the 90s-move-style hacker, though.
[22:02:28] <mooeypoo>	 Don't diss the vibe
[22:08:17] <grrrit-wm>	 (03PS3) 10Mooeypoo: Add unwatch actions to bundle items [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) 
[22:08:18] * mooeypoo hopes
[22:08:20] <grrrit-wm>	 (03PS1) 10Mooeypoo: Notification title fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307440 (https://phabricator.wikimedia.org/T132975) 
[22:08:57] <mooeypoo>	 \o/
[22:14:43] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Notification title fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307440 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo)
[22:18:03] <mooeypoo>	 woot
[22:18:32] <grrrit-wm>	 (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) (owner: 10Mooeypoo)
[22:22:34] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2593110 (10Quiddity) @SBisson has your recent work on target_page, for page-linked notifications, perhaps already fixed this?
[22:22:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Notification title fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307440 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo)
[22:23:00] <grrrit-wm>	 (03PS1) 10Catrope: Fix font size for notifications dotdotdot menu in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307442 
[22:23:42] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307431 (https://phabricator.wikimedia.org/T144063) (owner: 10Catrope)
[22:24:04] <RoanKattouw>	 mooeypoo: Please review https://gerrit.wikimedia.org/r/#/c/307431 and https://gerrit.wikimedia.org/r/#/c/307027
[22:24:40] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 07Mobile: Button in HTML emails don't look good on iOS - https://phabricator.wikimedia.org/T115808#2593127 (10Catrope)
[22:27:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix font size for notifications dotdotdot menu in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307442 (owner: 10Catrope)
[22:27:56] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) (owner: 10Mooeypoo)
[22:30:10] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307442 (owner: 10Catrope)
[22:30:24] <mooeypoo>	 RoanKattouw, is it background: initial or background: inherited ?
[22:30:36] <RoanKattouw>	 They mean different things
[22:30:43] <RoanKattouw>	 s/inherited/inherit
[22:31:00] <RoanKattouw>	 inherit = the value that my parent has
[22:31:03] <mooeypoo>	 Eh, again with the 'ed' stuff. I'll never get those right
[22:31:06] <RoanKattouw>	 (which may be more appropriate actually)
[22:31:16] <mooeypoo>	 yeah I know they're different, I'm asking which one you meant
[22:31:21] <RoanKattouw>	 initial = do what would happen if nobody had ever specified this property
[22:31:26] <RoanKattouw>	 (kind of)
[22:31:31] <RoanKattouw>	 I did mean initial
[22:31:42] <mooeypoo>	 I ... think maybe inherit, no? Otherwise, the initial is what was set in the skin though, no?
[22:31:46] <RoanKattouw>	 I think that's more or less equivalent to transparent in this case
[22:31:46] <mooeypoo>	 what does that change?
[22:31:57] <RoanKattouw>	 No, initial overrides (or really un-overrides) what the skin does
[22:32:16] <mooeypoo>	 isn't initial the initial state of the a { ... } without :hover  ?
[22:32:28] <RoanKattouw>	 I don't actually know
[22:32:38] <RoanKattouw>	 I just looked at what the default value of background-color was
[22:32:49] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Hover state has white box in Monobook - https://phabricator.wikimedia.org/T144063#2593133 (10jmatazzoni)
[22:32:58] <RoanKattouw>	 https://developer.mozilla.org/en-US/docs/Web/CSS/initial
[22:33:12] <RoanKattouw>	 It's the default/initial value of the property
[22:33:33] <mooeypoo>	 ... wow that's unhelpful
[22:33:37] <mooeypoo>	 default should be default
[22:33:52] <mooeypoo>	 I thought 'initial' was for state-changes. Like :hover etc
[22:34:41] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Paginate notifications by event ID, not timestamp - https://phabricator.wikimedia.org/T143964#2593142 (10jmatazzoni)
[22:34:52] <mooeypoo>	 so "initial" is reset to browser default?!
[22:35:15] <RoanKattouw>	 Yes
[22:35:26] <RoanKattouw>	 (Apparently, according to MDN)
[22:35:32] <mooeypoo>	 That's silly
[22:35:54] <mooeypoo>	 I can understand reset to the 'lowest' value (body or whatever) but ok
[22:36:24] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2593164 (10jmatazzoni)
[22:36:28] <mooeypoo>	 anywyas, I want to +2 but selenium seems to reject that
[22:37:02] <mooeypoo>	 RoanKattouw, also, you told me to review 2 things, but one of those is my own fix...
[22:37:23] <RoanKattouw>	 Really?
[22:37:28] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2593166 (10jmatazzoni)
[22:37:32] <mooeypoo>	 <RoanKattouw> mooeypoo: Please review https://gerrit.wikimedia.org/r/#/c/307431 and https://gerrit.wikimedia.org/r/#/c/307027
[22:37:40] <RoanKattouw>	 I meant https://gerrit.wikimedia.org/r/#/c/307431/1 and https://gerrit.wikimedia.org/r/#/c/307442/1
[22:37:48] <mooeypoo>	 https://gerrit.wikimedia.org/r/#/c/307431 <-- I want to +2 this but selenium fails it
[22:37:56] <RoanKattouw>	 Yes, that's a fake failure
[22:38:02] <RoanKattouw>	 You can +2 hoping it doesn't fail again
[22:38:09] * mooeypoo nods
[22:38:10] <RoanKattouw>	 I've also filed https://phabricator.wikimedia.org/T144247
[22:38:17] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] Override white background on hover for links in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307431 (https://phabricator.wikimedia.org/T144063) (owner: 10Catrope)
[22:38:27] <mooeypoo>	 woah
[22:38:37] <mooeypoo>	 OMG this is awesome, RoanKattouw 
[22:38:38] <mooeypoo>	 font-size: 1.27*0.95*0.95*0.875/0.75em;
[22:38:42] <mooeypoo>	 We should frame this
[22:39:42] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Probably the best font size ever." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307442 (owner: 10Catrope)
[22:40:02] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement: Ask communities which have allowed Flow trials with manual enabling to switch to Beta feature activation - https://phabricator.wikimedia.org/T143470#2593187 (10jmatazzoni)
[22:40:53] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-PageCuration: How did a PageTriage review log entry and notification appear a month after initial page-patrol - https://phabricator.wikimedia.org/T143286#2593194 (10jmatazzoni)
[22:42:46] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2593200 (10jmatazzoni)
[22:44:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Override white background on hover for links in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307431 (https://phabricator.wikimedia.org/T144063) (owner: 10Catrope)
[22:44:13] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2557561 (10jmatazzoni) p:05Triage>03High
[22:45:50] <mooeypoo>	 RoanKattouw, I read 'frivolous' as 'fabulous' and that just caused me to read the error message in a diva voice. I like this bug now.
[22:47:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix font size for notifications dotdotdot menu in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307442 (owner: 10Catrope)
[23:02:43] <grrrit-wm>	 (03PS1) 10Mattflaschen: Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307450 
[23:05:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307450 (owner: 10Mattflaschen)
[23:05:20] <grrrit-wm>	 (03PS1) 10Mattflaschen: Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307451 
[23:05:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307451 (owner: 10Mattflaschen)
[23:14:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307450 (owner: 10Mattflaschen)
[23:14:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix autoloader for I3a426b92892f4c00cab33a13f6a717751120367c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307451 (owner: 10Mattflaschen)
[23:22:29] <addshore>	 RoanKattouw: im currently on vacation (untill thursday) but will take a look at https://phabricator.wikimedia.org/T144141#2592872 then if noone else beats me!
[23:32:17] <RoanKattouw>	 addshore: Thanks! I'm also waiting for Dereckson to reply (does this happen often, etc)
[23:36:01] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2593274 (10Mooeypoo) >>! In T132975#2593261, @Quiddity wrote:...
[23:41:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Display a message when API fail due to session end [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) (owner: 10Mooeypoo)
[23:47:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Display a message when API fail due to session end [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307362 (https://phabricator.wikimedia.org/T144231) (owner: 10Mooeypoo)
[23:54:49] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "View changes" doesn't mark notification as read - https://phabricator.wikimedia.org/T143122#2557561 (10Etonkovidova) There is a mixed behavior for whether a notification will be  marked as read via clicking on 'View changes'.  It depends on whether 'View change...