[00:07:14] Due to T143952, marked on all of our maintained extensions that people should only use them with matching branches (we already had that for Flow). [00:07:15] T143952: Echo does not work with mediawiki 1.27.0 - https://phabricator.wikimedia.org/T143952 [00:08:15] (03CR) 10Mooeypoo: [C: 04-1] "Overall looks good, but small comments inline" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 (owner: 10Mattflaschen) [00:08:34] 06Collaboration-Team-Triage, 10Notifications: Echo does not work with mediawiki 1.27.0 - https://phabricator.wikimedia.org/T143952#2584493 (10Mattflaschen-WMF) Please use matching branches for Echo and core (e.g. master for both, or 1.27 for both). If that doesn't work, please comment with what versions or co... [00:10:34] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Schema-change: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427#2584679 (10Catrope) [00:11:23] (03CR) 10Mattflaschen: [C: 032] Remove unused method EchoEventMapper::fetchByUserBundleHash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306845 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [00:11:34] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Schema-change: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427#2334688 (10Catrope) [00:12:20] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#2584686 (10Catrope) [00:18:01] (03Merged) 10jenkins-bot: Remove unused method EchoEventMapper::fetchByUserBundleHash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306845 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [00:36:37] 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2584705 (10Catrope) [00:38:20] 06Collaboration-Team-Triage, 10Notifications: Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2584732 (10Catrope) [00:53:13] 06Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963#2584765 (10Catrope) [01:22:22] 06Collaboration-Team-Triage, 10Notifications: Paginate notifications by event ID, not timestamp - https://phabricator.wikimedia.org/T143964#2584799 (10Catrope) [01:26:42] 06Collaboration-Team-Triage, 10Notifications: Echo notification table indexes don't support the new feature changes - https://phabricator.wikimedia.org/T72363#2584815 (10Catrope) In light of {T143964}, I think we should not add `notification_timestamp` to the unread index, but just `notification_event`. [01:32:06] 06Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963#2584818 (10Catrope) [01:32:47] 06Collaboration-Team-Triage, 10Notifications: Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2584824 (10Catrope) [01:32:49] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Remove unused bundling DB fields - https://phabricator.wikimedia.org/T143763#2584826 (10Catrope) [01:32:51] 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2584825 (10Catrope) [01:32:53] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#2584827 (10Catrope) [01:32:55] 06Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963#2584765 (10Catrope) [01:32:57] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Schema-change: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427#2584828 (10Catrope) [01:33:19] (03CR) 10Mattflaschen: [C: 04-1] "You should probably remove maintenance/backfillReadBundles.php, since it no longer works with the current state of the repo/DB." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:35:30] (03CR) 10Mattflaschen: [C: 032] Fix call to irrelevant function in testFetchByUserOffset [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306848 (owner: 10Catrope) [01:35:57] (03PS1) 10Catrope: Add index on event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306862 (https://phabricator.wikimedia.org/T143961) [01:36:27] 06Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963#2584837 (10Catrope) [01:36:49] 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Add index on event_page_id - https://phabricator.wikimedia.org/T143961#2584838 (10Catrope) [01:41:24] 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2584844 (10Catrope) Hmm, it appears to still be used to mark notifications as read when certain pages are viewed, at https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/Hoo... [01:42:43] (03CR) 10Mattflaschen: "Also, I get:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:44:07] (03Merged) 10jenkins-bot: Fix call to irrelevant function in testFetchByUserOffset [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306848 (owner: 10Catrope) [01:54:10] (03CR) 10Mattflaschen: [C: 032] Add index on event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306862 (https://phabricator.wikimedia.org/T143961) (owner: 10Catrope) [02:00:32] (03PS2) 10Mattflaschen: Dynamic actions: Reuse label/description for those fields [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 [02:00:49] (03Merged) 10jenkins-bot: Add index on event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306862 (https://phabricator.wikimedia.org/T143961) (owner: 10Catrope) [02:08:58] (03CR) 10Mattflaschen: Dynamic actions: Reuse label/description for those fields (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 (owner: 10Mattflaschen) [02:10:07] Have a good night. [02:43:22] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2584910 (10Mooeypoo) Regarding the huge topics - We should probably send the truncat... [06:57:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2585126 (10Pginer-WMF) >>! In T132975#2584910, @Mooeypoo wrote: > Regarding the huge... [09:47:34] 06Collaboration-Team-Triage, 10Notifications: Echo does not work with mediawiki 1.27.0 - https://phabricator.wikimedia.org/T143952#2585352 (10Aklapper) 05Open>03Invalid Closing task as invalid as no further information can be provided in this venue (task reporter sock puppet account disabled). User is free... [10:48:42] (03PS1) 10Sbisson: Loading notifications starting with one big local bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306901 (https://phabricator.wikimedia.org/T143813) [11:02:01] 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2585446 (10SBisson) >>! In T143959#2584844, @Catrope wrote: > Hmm, it appears to still be used to mark notifications as read when certain pages are viewed, at https://phabricator.wiki... [14:07:50] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2585904 (10Trizek-WMF) [14:08:01] DONE! \o/ [14:08:13] * Trizek officially hates Qualtrics. [14:10:01] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2585915 (10Trizek-WMF) [14:10:04] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2585913 (10Trizek-WMF) 05Open>03Resolved Reviewed by @Jdforrester-WMF and @Catrope. [14:10:48] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993383 (10Trizek-WMF) [14:12:12] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Improve the "Why not VE?" section of the Flow FAQ - https://phabricator.wikimedia.org/T141758#2585930 (10Trizek-WMF) @Jdforrester-WMF, anything else to add to [[ https://www.mediawiki.or... [15:32:58] 06Collaboration-Team-Triage, 10Notifications, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2586309 (10Trizek-WMF) [15:39:51] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Improve the "Why not VE?" section of the Flow FAQ - https://phabricator.wikimedia.org/T141758#2586329 (10Jdforrester-WMF) LGTM. [15:45:38] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Document how to add a new Notification type created by an extension to the Help pages - https://phabricator.wikimedia.org/T141884#2586360 (10Trizek-WMF) Thanks Joe.... [15:46:09] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2586365 (10Trizek-WMF) [15:46:12] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Improve the "Why not VE?" section of the Flow FAQ - https://phabricator.wikimedia.org/T141758#2586361 (10Trizek-WMF) 05Open>03Resolved Thanks! :) [15:47:43] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2586367 (10Trizek-WMF) p:05Normal>03High [17:03:56] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: How did a PageTriage review log entry and notification appear a month after initial page-patrol - https://phabricator.wikimedia.org/T143286#2586660 (10Quiddity) [17:07:16] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: How did a PageTriage review log entry and notification appear a month after initial page-patrol - https://phabricator.wikimedia.org/T143286#2586681 (10Quiddity) @Etonkovidova I'm confused... What steps did you follow to get the 3 "marked as revi... [17:55:32] (03CR) 10Catrope: [C: 032] Loading notifications starting with one big local bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306901 (https://phabricator.wikimedia.org/T143813) (owner: 10Sbisson) [17:57:12] 06Collaboration-Team-Triage, 10Notifications: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959#2586953 (10Catrope) >>! In T143959#2585446, @SBisson wrote: > `etp_user` is technically used to populate and query `echo_target_page` but it doesn't do anything useful. There is nothi... [18:02:58] (03Merged) 10jenkins-bot: Loading notifications starting with one big local bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306901 (https://phabricator.wikimedia.org/T143813) (owner: 10Sbisson) [18:06:49] (03CR) 10Mooeypoo: [C: 032] Dynamic actions: Reuse label/description for those fields (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 (owner: 10Mattflaschen) [18:07:53] (03CR) 10Mooeypoo: [C: 032] Update for new secondary link format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306590 (owner: 10Mattflaschen) [18:12:56] (03Merged) 10jenkins-bot: Dynamic actions: Reuse label/description for those fields [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 (owner: 10Mattflaschen) [18:17:23] (03Merged) 10jenkins-bot: Update for new secondary link format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306590 (owner: 10Mattflaschen) [18:30:24] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587067 (10Mattflaschen-WMF) Should I include cross-wiki support? It exists on the client side, but I don't know a use case on the server-side currently. [18:30:58] ^ RoanKattouw [18:31:19] I'm inclined to leave it out. We can always add it later. [18:31:26] matt_flaschen: That seems... more effort than it's worth [18:32:02] It's not immediately obvious to me how cross-wiki server-side MessagePoster would even work (maybe an API request like XWN or something?) and it seems bug-prone [18:32:15] So if there's no use case for it currently, yeah let's just leave it out [18:34:15] RoanKattouw, yeah, I agree. I was also thinking it *could* be done with an API request. It would need a CentralAuth token (sounds good so far, right?)... But yeah, let's file under YAGNI. [18:34:37] lol @ CA token [18:34:51] I may need to forbid you from using that word for a while [18:35:50] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587078 (10Mattflaschen-WMF) @Catrope and I agreed on IRC to leave it out for now. [18:36:02] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587080 (10Mattflaschen-WMF) [19:10:01] stephanebisson, Matthias changed to stop backfilling in c6b2270. That's what I was thinking of. I thought that was reverted, but it wasn't. Instead, he did eeb6db856d1d6f20a74dac668642cf3fccfbaebc as a follow up (which fixes other peformance stuff). [19:11:47] stephanebisson, also, https://gerrit.wikimedia.org/r/#/c/249402/ was considered but never merged. [19:48:51] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-PageCuration: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030#2587268 (10Mattflaschen-WMF) [19:54:51] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2587272 (10Etonkovidova) As suggested by @Mooeypoo, two cases were checked and all l... [19:59:24] 06Collaboration-Team-Triage, 10WikiLove: Use server-side MessagePoster in WikiLove - https://phabricator.wikimedia.org/T144050#2587275 (10Mattflaschen-WMF) [19:59:46] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587302 (10Mattflaschen-WMF) [19:59:48] 06Collaboration-Team-Triage, 10WikiLove: Use server-side MessagePoster in WikiLove - https://phabricator.wikimedia.org/T144050#2587301 (10Mattflaschen-WMF) [20:08:16] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587338 (10Mattflaschen-WMF) > Note that both WikiLove and MassMessage are calling the API internally, I'm not sure if that's something we want to enco... [20:13:07] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2587360 (10Mattflaschen-WMF) [20:18:02] * Override prefix on CSRF token so the same code can be reused for [20:18:02] * all modules. This is a *TEMPORARY* hack please remove as soon as [20:18:02] * unprefixed tokens are working correctly again (bug 70099). [20:18:08] oops ;) [20:52:56] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Cannot see or clear unread notifications at Beta Cluster - https://phabricator.wikimedia.org/T141816#2587485 (10Quiddity) My problem at beta cluster is fixed. Thanks! (I won't resolve this, as I'm not sure if more work is needed.) [21:49:26] (03PS1) 10Mooeypoo: Change 'unwatch' icon to an empty star [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307023 (https://phabricator.wikimedia.org/T132975) [21:49:37] (03CR) 10jenkins-bot: [V: 04-1] Change 'unwatch' icon to an empty star [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307023 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [21:49:38] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10Revision-Scoring-As-A-Service-Backlog, 07Design: Design system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143455#2587585 (10Quiddity) [21:52:57] (03PS2) 10Mooeypoo: Change 'unwatch' icon to an empty star [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307023 (https://phabricator.wikimedia.org/T132975) [21:55:19] (03PS3) 10Mooeypoo: Style changes for unwatch actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307023 (https://phabricator.wikimedia.org/T132975) [21:58:17] (03PS4) 10Mooeypoo: Style changes for unwatch actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/307023 (https://phabricator.wikimedia.org/T132975) [22:12:04] 06Collaboration-Team-Triage, 10Notifications: Hover state has white box in Monobook - https://phabricator.wikimedia.org/T144063#2587640 (10Esanders) [22:28:45] (03PS1) 10Mooeypoo: Style and text fixes for unwatch actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) [22:28:54] (03CR) 10jenkins-bot: [V: 04-1] Style and text fixes for unwatch actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [22:45:47] (03PS2) 10Mooeypoo: Style and text fixes for unwatch actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307027 (https://phabricator.wikimedia.org/T132975) [23:15:37] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: In mobile view, bundled notifications extend outside the screen limit - https://phabricator.wikimedia.org/T140523#2587725 (10Mooeypoo) >>! In T140523#2544074, @Pginer-WMF wrote: > Wrapping works well in this context. > > On mobile we can e... [23:31:47] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: How did a PageTriage review log entry and notification appear a month after initial page-patrol - https://phabricator.wikimedia.org/T143286#2587742 (10Etonkovidova) @Quiddity (1) the multiple identical records 'marked the page as reviewed' is...