[00:43:47] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15), 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#2578040 (10Etonkovidova) s1-analytics-s... [02:18:53] RoanKattouw, yeah, it is a subproject. AFAICT, that's correct. ERI was always planned to have subprojects. [02:19:01] Heading out. [02:24:38] 06Collaboration-Team-Triage, 10Notifications: Remove notification_bundle_base - https://phabricator.wikimedia.org/T143763#2578078 (10Catrope) [02:40:47] 06Collaboration-Team-Triage, 10Notifications: Remove notification_bundle_base - https://phabricator.wikimedia.org/T143763#2578094 (10Catrope) a:03Catrope [03:56:28] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993177 (10Alsee) @Trizek-WMF, the goal is to get unbiased feedback, right? The current s... [04:11:48] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs] Special:Notifications page is not displayed - error: Call to a member function getFullURL() on a non-object (null) - https://phabricator.wikimedia.org/T143757#2578149 (10Catrope) a:03Mooeypoo Regression from Moriel's watch/unwatch changes. [08:38:08] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2578336 (10Whatamidoing-WMF) [09:33:46] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Echo: Ability to link accounts for notifications - https://phabricator.wikimedia.org/T50892#2578412 (10Aklapper) p:05Low>03Lowest Lowering priority as per T50892#2033411 [15:06:27] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#2579143 (10Trizek-WMF) [15:20:34] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2579178 (10Halfak) Looks good. What do you think the "Add filter" interaction should look like? One concern I have is that this will shake u... [15:41:17] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2579228 (10Pginer-WMF) >>! In T142785#2579178, @Halfak wrote: > Looks good. What do you think the "Add filter" interaction should look like?... [15:52:13] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2579266 (10Halfak) Thinking about it, the beta feature strategy seems good. We already do have "Enhanced RecentChanges", so there's already a... [16:40:40] 10Collaboration-Team-Archive-2015-2016, 10Notifications, 07Wikimedia-log-errors, 07WorkType-NewFunctionality: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#2579493 (10Nikerabbit) 05Resolved>03Open Apperently https://gerrit.wikimedia.org/r/#/c/301382/ re-introduces t... [16:40:52] (03CR) 10Nikerabbit: "This re-introduces T105890" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [16:48:38] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2579558 (10Etonkovidova) The changes have been made and they are in UI: `top: 9px; ` `left: 55%;... [16:58:34] (03PS1) 10Sbisson: Don't select echo_event.* [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306465 (https://phabricator.wikimedia.org/T105890) [17:00:03] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 13Patch-For-Review, and 2 others: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#2579609 (10SBisson) [17:04:44] 06Collaboration-Team-Triage, 10Notifications: Nowiki'd templates in Flow notification excerpts are parsed in emails and special page - https://phabricator.wikimedia.org/T143807#2579636 (10Quiddity) [17:25:11] 06Collaboration-Team-Triage, 10Notifications: Allow people to edit their "what links here" list - https://phabricator.wikimedia.org/T143809#2579704 (10Trizek-WMF) [17:38:01] (03CR) 10Catrope: [C: 032] Don't select echo_event.* [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306465 (https://phabricator.wikimedia.org/T105890) (owner: 10Sbisson) [17:46:13] (03Merged) 10jenkins-bot: Don't select echo_event.* [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306465 (https://phabricator.wikimedia.org/T105890) (owner: 10Sbisson) [18:15:37] 06Collaboration-Team-Triage, 10Notifications: Allow people to watch/unwatch pages for link notification purposes - https://phabricator.wikimedia.org/T143809#2579856 (10Catrope) [18:16:05] 06Collaboration-Team-Triage, 10Notifications: Allow people to watch/unwatch pages for link notification purposes - https://phabricator.wikimedia.org/T143809#2579704 (10Catrope) This is probably a semi-duplicate of one or more tasks around volume control, and maybe even an older task from 2013ish? @Quiddity ? [18:26:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2579875 (10Capt_Swing) [18:29:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2579895 (10Capt_Swing) [18:31:54] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2579901 (10Trizek-WMF) a:05Trizek-WMF>03jmatazzoni @jmatazzoni is going to write a text about the first fee... [18:37:24] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Empty notification panel when there is only one big local bundle - https://phabricator.wikimedia.org/T143813#2579913 (10SBisson) [18:39:11] (03PS1) 10Sbisson: Get the overfetched before bundling to avoid removing the base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306481 (https://phabricator.wikimedia.org/T143813) [18:44:07] (03PS1) 10Mooeypoo: Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) [18:48:07] 06Collaboration-Team-Triage, 10Flow: Flow incorrectly displays usernames as red links for usernames with spaces in them - https://phabricator.wikimedia.org/T143814#2579965 (10Ijon) [18:49:02] (03PS2) 10Mooeypoo: [wip] Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) [18:49:08] 06Collaboration-Team-Triage, 10Flow: Flow incorrectly displays usernames as red links for usernames with spaces in them - https://phabricator.wikimedia.org/T143814#2579993 (10Ijon) [18:49:14] (03CR) 10Catrope: [C: 032] Get the overfetched before bundling to avoid removing the base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306481 (https://phabricator.wikimedia.org/T143813) (owner: 10Sbisson) [18:50:25] (03PS3) 10Mooeypoo: [wip] Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) [18:52:15] 06Collaboration-Team-Triage, 10Notifications: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#682552 (10Lea_WMDE) The #tcb-team has worked on mention success and failure notifications in the past month (see {T139962}).... [18:55:46] (03Merged) 10jenkins-bot: Get the overfetched before bundling to avoid removing the base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306481 (https://phabricator.wikimedia.org/T143813) (owner: 10Sbisson) [18:57:06] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2580017 (10Lea_WMDE) @MZMcBride Both tasks were started due to the same wish. However, T138080 was thought to be a change in how ment... [19:14:45] stephanebisson, I fixed T143464 for MediaWiki-Vagrant. And the Zend shell to test it. [19:14:46] T143464: "Memcached::touch(): touch is only supported with binary protocol" - https://phabricator.wikimedia.org/T143464 [19:16:23] matt_flaschen: Thanks. I'll take a look. [19:23:27] 06Collaboration-Team-Triage, 10Flow: Flow incorrectly displays usernames as red links for usernames with spaces in them - https://phabricator.wikimedia.org/T143814#2579965 (10Mattflaschen-WMF) It's not whether it has a space (try "User:Whatamidoing (WMF)"). it's from global user pages. See bottom of https://... [19:52:51] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Page-deletion, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Failed restore and data loss on ar_rev_id collisions - https://phabricator.wikimedia.org/T135852#2580299 (10Etonkovidova) Re-checked both scenarios - the resul... [21:11:41] 06Collaboration-Team-Triage, 10Notifications: Allow people to watch/unwatch pages for link notification purposes - https://phabricator.wikimedia.org/T143809#2580587 (10Quiddity) This is a partial overlap with: * {T66090} - for the addition of pages. * {T46787} - for the exclusion of pages. [21:13:03] 06Collaboration-Team-Triage, 10Flow, 10Notifications: New Notification for Topics/Posts that are hidden in Flow - https://phabricator.wikimedia.org/T85185#2580593 (10Quiddity) [21:13:06] 06Collaboration-Team-Triage, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2580592 (10Quiddity) [21:22:34] (03PS4) 10Mooeypoo: Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) [21:23:11] matt_flaschen, stephanebisson ^^ this fixes a regrettable regression in Beta due to my 'unwatch' fix, if you can take a look [21:50:37] mooeypoo, sorry, internet was down. Reviewing now. [21:55:05] matt_flaschen, also, "good news"... the 'mark all read' mobile fix will now have a dependency on mw-core change. [21:55:09] yaaay............ [21:58:22] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/306560/ [22:01:17] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2580702 (10Quiddity) Big +1 for ButtonSelectWi... [22:19:35] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580751 (10Mooeypoo) [22:21:21] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580768 (10Mooeypoo) Posting my answer to the discussion in the commit: > Regarding th... [22:22:12] meh [22:22:28] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580751 (10Mooeypoo) a:03Mooeypoo [22:25:15] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2580788 (10Volker_E) @Quiddity Yes! That's T13... [22:37:35] mooeypoo, is there anything you want SWATted, or can it all wait for the train? [22:46:12] matt_flaschen, I don't think so... the regression fix that's waiting is still only a bug in beta [22:46:17] not in production [22:46:37] Okay, just checking, I also wasn't sure about the "mark all read" [22:46:38] (though we should fix that one soon, since it crashes Echo ... oops) [22:46:46] no that one's still in development [22:50:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580845 (10Mooeypoo) @Esanders pointed out an idea that would fix both issues: mw.noti... [22:56:29] mooeypoo, there's a bunch of other notices and undefined variables. [22:56:36] mooeypoo, fixing the ones in Echo now. [22:56:45] Didn't we say we would reuse 'label' even for dynamic actions? [22:58:12] matt_flaschen, what do you mean? [22:58:24] sorry, dealing with mw.notify stuff now, I'm a little confused about context [22:58:51] mooeypoo, I mean dynamic actions like watch/unwatch. They should still have a standard label. [22:58:58] And then progressive enhancement from there. [23:00:39] Well, the problem is that the secondary links have an optional descriptio [23:01:02] so "label" was a little too vague; which label? it seemed more reasonable to split it up to title/description [23:02:00] mooeypoo, yes, but we said that the dynamic actions would still work on old clients that don't understand the new fields. [23:02:04] Label has to be set for that to work. [23:02:15] mooeypoo, is title tooltip? [23:05:10] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580869 (10Esanders) You should give the global overlay an additional class so it can b... [23:08:55] mooeypoo, yeah, regular links also have the same label/description split. I'm going to put up some patches simplifying this. [23:15:59] * mooeypoo nods [23:16:48] matt_flaschen, in ooui title is DOM title="..." which is a yes. In PHP, title is a label. Or a Title object. Or a title string. Depending on context, because why not. [23:20:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837#2580884 (10Mooeypoo) So this sounds like a good idea, and it should work - but the way... [23:21:18] (03CR) 10Catrope: [C: 032] Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) (owner: 10Mooeypoo) [23:27:48] (03Merged) 10jenkins-bot: Followup on I75d0098e: Use getTopicTitleObj properly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306483 (https://phabricator.wikimedia.org/T143757) (owner: 10Mooeypoo) [23:49:14] mooeypoo, do you intentionally have both title/page URL even when only one is used. Asking becaus one of them is a broken variable, so checking whether to remove or fix. [23:49:28] For notification-dynamic-actions-*watch [23:50:39] matt_flaschen, for the general Echo one? Yeah, I figured it's safer to send both in case something overrides the message? [23:50:58] I took out the $query inside getFullUrl() but I may have forgotten to do that in the Echo fix [23:51:01] mooeypoo, okay. I don't know if someone would use the URL in the text, but I'll leave it. [23:51:22] matt_flaschen, the url is used in the description of the confirmation [23:51:39] mooeypoo, yeah, I mean the label. [23:51:43] 'Stop watching this topic' [23:51:47] Or board name [23:53:33] (03PS1) 10Mattflaschen: Dynamic actions: Reuse label/description for those fields [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306589 [23:55:01] (03PS1) 10Mattflaschen: Update for new secondary link format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/306590 [23:58:42] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Sidebar in Special:Notifications needs styling adjustment in monobook - https://phabricator.wikimedia.org/T143845#2580999 (10Mooeypoo)