[00:23:03] (03CR) 10Catrope: Maintenance: moderate notifications linked to missing pages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [00:44:12] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Document how to add a new Notification type created by an extension to the Help pages - https://phabricator.wikimedia.org/T141884#2574102 (10jmatazzoni) @Trizek-WMF Be... [02:35:53] Have a good night, see you tomorrow. [06:33:16] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech-Tool-Labs, 06Labs, and 2 others: Enable Flow on wikitech (labswiki and labtestwiki), then turn on for Tool talk namespace - https://phabricator.wikimedia.org/T127792#2054159 (10yuvipanda) *bump* on this? [09:32:15] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2574746 (10Pginer-WMF) ´ [09:33:15] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2574748 (10Pginer-WMF) I captured some ideas to improve the filtering mechanism on Recent changes in the mockup below: {M184} [10:02:51] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2574781 (10Pginer-WMF) That line generates a separation which is intended to be consistent with how the notification opens (notice in your example of F4339766 the bottom whi... [12:33:44] 06Collaboration-Team-Triage, 10Notifications, 07Epic: Notify user when username mentioned on article text (Main namespace) - https://phabricator.wikimedia.org/T143665#2575205 (10Rbirmann) [12:46:25] 06Collaboration-Team-Triage, 06Community-Tech, 06TCB-Team, 07Category, and 4 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2575252 (10Lea_WMDE) [16:18:41] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2576003 (10Etonkovidova) [16:31:30] 06Collaboration-Team-Triage, 10Flow, 10Thanks: error code:http - Error message for network connection can be improved - https://phabricator.wikimedia.org/T142781#2576090 (10Etonkovidova) [17:27:04] (03CR) 10Catrope: [C: 032] Add unwatch topic/board dynamic action for Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [17:29:17] (03CR) 10Catrope: [C: 032] Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [17:39:30] (03Merged) 10jenkins-bot: Add unwatch topic/board dynamic action for Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [17:43:10] (03Merged) 10jenkins-bot: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [18:23:59] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2576662 (10MZMcBride) I'm unclear on the relationship between this task and {T138080}. [18:46:26] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Write product definition for augmented feed and post to wiki - https://phabricator.wikimedia.org/T143719#2576823 (10jmatazzoni) [19:02:02] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Instrument augmented changes feed to monitor usage - https://phabricator.wikimedia.org/T143721#2576887 (10jmatazzoni) [19:04:03] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Instrument augmented changes feed to monitor usage - https://phabricator.wikimedia.org/T143721#2576904 (10jmatazzoni) [19:16:22] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2576943 (10Neil_P._Quinn_WMF) Removing #editing-analysis since it seems like there's nothing more for us to do here :) [19:16:55] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#2576945 (10Neil_P._Quinn_WMF) Removing #editing-analysis since it seems like there's nothing more for us to do here :) [19:32:21] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Instrument augmented changes feed to monitor usage - https://phabricator.wikimedia.org/T143721#2576887 (10jmatazzoni) [19:33:35] RoanKattouw: hmm... testwiki is noticeably slower than betalabs. Posting replies and edits takes about 10s vs 3-4s in betalabs. [19:42:39] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Write product definition for augmented feed and post to wiki - https://phabricator.wikimedia.org/T143719#2577160 (10jmatazzoni) [20:14:03] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Echo user when his another username is mentioned - https://phabricator.wikimedia.org/T143735#2577245 (10JAnD) [20:38:59] 06Collaboration-Team-Triage, 10Notifications: Notify user when username mentioned on article text (Main namespace) - https://phabricator.wikimedia.org/T143665#2577353 (10Mattflaschen-WMF) [20:40:24] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Notify user when another their other account is mentioned - https://phabricator.wikimedia.org/T143735#2577369 (10Mattflaschen-WMF) [20:40:38] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Notify user when their other account is mentioned - https://phabricator.wikimedia.org/T143735#2577245 (10Mattflaschen-WMF) [20:59:51] (03PS1) 10Mooeypoo: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [21:00:51] (03PS2) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [21:04:56] (03PS3) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [21:05:46] RoanKattouw, meh, 'doubleCheck' icon is not an OOUI icon... I'll need a white/inverted version of it.... [21:11:40] mooeypoo: Where does it come from? Perhaps we can stick it into RLIM [21:18:35] RoanKattouw, it was in nojs/mw.echo.icon.less [21:18:45] I just moved it to styles/ for this fix since we're using it in the JS too [21:18:56] Oh, right [21:19:07] (only reason it works right now in Special:Notifications is because that one loads nojs styles automatically.. but that's the wrong place for it) [21:19:20] I suppose if we migrated mw.echo.icon.less to an RLIM like badgeicons.json then we would have inverted icons [21:19:27] meh [21:19:36] * mooeypoo does not remember this process fondly [21:20:07] I mean just a .json file based RLIM like badgeicons.json [21:20:15] oh. [21:20:17] That should(TM) be straightforward(R) [21:20:21] ... [21:20:36] (No seriously, I believe that will be easy to do) [21:22:25] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2577484 (10jmatazzoni) [21:23:19] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Write product definition for augmented feed and post to wiki - https://phabricator.wikimedia.org/T143719#2576823 (10jmatazzoni) [21:23:21] 03Collab-Team-Q1-July-Sep-2016, 10Augmented-Changes-Feed: Set up augmented changes feed - https://phabricator.wikimedia.org/T143743#2577498 (10jmatazzoni) [21:27:30] RoanKattouw, ok, I'll do it after I eat [22:10:12] RoanKattouw, since we deleted those files, do you remember where I can find another example of them? [22:19:46] RoanKattouw, I added to the badgeicons.json file, but I am not really having much success with the variant definition [22:20:35] 06Collaboration-Team-Triage, 06Design-Research, 10Edit-Review-Improvements: Page Curation user workflows and Edit Review prototype concept validation - https://phabricator.wikimedia.org/T140161#2577711 (10Capt_Swing) We sent out a recruit message to 20 people, but only got one response. Closing this as "done... [22:23:59] RoanKattouw, aaaaaaa now the file doesn't appear at all, and I have no idea what I'm missing. [22:24:36] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2577725 (10Framawiki) [22:26:56] Let me see [22:28:12] mooeypoo: See e.g. resources/lib/oojs-ui/themes/mediawiki/icons-accessibility.json in MW core [22:29:02] RoanKattouw, let me push [22:29:08] there are 2 commits, one in Echo and one in MobileFrontend [22:29:33] (03PS4) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [22:29:55] RoanKattouw, the mobile frontend one : https://gerrit.wikimedia.org/r/306288 [22:32:23] RoanKattouw, the icons don't show up at all now, so I don't even know about the inverted one [22:32:47] Hmm well one thing is that either the inverted variant needs to have global:true or the doubleCheck icon needs to indicate that it needs the inverted variant [22:32:50] RoanKattouw, to test, see the notifications popup in mobile emulator, and have some unread local notifs in there [22:32:55] so the mark-all-read button shows up [22:33:13] RoanKattouw, ok, I can add that, but why is the icon not showing at all? [22:33:27] "variants": [ "inverted" ] [22:33:28] Good question [22:33:31] Lemme pull [22:34:20] also, how do I properly set the icon as inverted? IIRC I add a oo-ui-icon-inverted or something? or is it oo-ui-icon-doubleCheck-inverted ? [22:34:24] I can't find the examples we had [22:35:05] I'll look at that next [22:35:21] I think though that you just need the button to have certain properties and it'll do it automatically [22:35:33] RoanKattouw, on a good note, if you're already testing, please see if oyu like the little confirmation popup that comes up [22:35:35] it's timed [22:35:56] RoanKattouw, yeah, about that.. that's why I create a new IconWidget and not use IconElement mixin [22:36:04] but i need an icon not a button ;\ [22:36:11] Oh I see [22:36:21] Then lemme look once I figure out why RLIM isn't working at all [22:36:23] iconelement => icon doesn't show. Missing classes, I think. IconWidget => shows, but no inverted [22:36:29] Cause it'll be clear from the generated CSS hopefully [22:36:40] Yeah IconElement isn't meant to be instantiated, just mixed in [22:36:47] it was mixed in [22:36:50] Hmm [22:36:57] let's do one problem at a time, though [22:37:08] icon thing works as a widget, it's a smaller problem [22:37:12] I guess maybe you need FlaggedElement mixed in too and then some flag set? But we'll see. Also this comes from a non-OOUI module anyway [22:37:25] the icon itself just doesn't show atall, even non-inverted [22:37:53] [b5acab8d816702878639f809] /w/load.php?modules=ext.echo.badgeicons&only=styles&debug=true InvalidArgumentException from line 79 of /home/catrope/git/mediawiki/core/includes/resourceloader/ResourceLoaderImage.php: File type for different image files of 'default' not the same [22:38:01] what [22:38:25] I'm using the exact same thing that we use for --- wait, i'm an idiot... I'm not loading bagdeicons in mobile >,< [22:38:49] No that's using load.php [22:38:51] http://localhost/w/load.php?modules=ext.echo.badgeicons&only=styles&debug=true [22:39:29] RoanKattouw, loads for me [22:39:34] WTF [22:39:36] I get no errors. [22:40:05] (03PS5) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [22:40:07] shouldn't make a difference, but maybe? [22:40:11] that's my state^^ [22:40:32] Shouldn't matter, though. I just added the variants thing. [22:40:59] and, confirming, when I actually load ext.echo.badgeicons in MobileFrontend mobile overlay, I get the icon [22:41:01] but not the inverted one. [22:42:35] For some reason adding the variant breaks it [22:42:41] If I remove the variant it works locally [22:42:57] Works for me O.o [22:43:12] wait, the variant doesn't, but the icon (and the load.php result) work fine [22:43:31] Aha, if I make the variant global it works [22:44:00] RoanKattouw, whoops, the json has an extra comma [22:44:07] that might be the breaking point? [22:44:08] HA [22:44:11] Yes, probably [22:44:17] weird that it works for me, though O.o [22:44:17] That's why random edits to the JSON work [22:44:52] OK yes, so add "variants": [ "inverted" ] to the doubleCheck icon [22:44:53] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo) [22:44:57] And remove the excess comma [22:45:06] yep did that [22:45:09] Oh there we go, that's probably Jenkins telling us about that comma [22:45:26] ok, i fixed that locally. I get the icon... now how do I get the inverted one :\ [22:45:36] s/inverted/invert/ [22:45:48] .oo-ui-image-invert.oo-ui-icon-doubleCheck { [22:45:52] is the selector it generates [22:45:54] (03PS6) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [22:46:14] oh **image** [22:46:16] not icon [22:46:18] pfft [22:47:02] You'll probably have to set that class yourself because the MediaWikiTheme.js code that sets it is fairly specific to buttons [22:47:33] 06Collaboration-Team-Triage, 10Notifications: Echo: Ability to link accounts for notifications - https://phabricator.wikimedia.org/T50892#2577792 (10Quiddity) [22:47:35] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Notify user when their other account is mentioned - https://phabricator.wikimedia.org/T143735#2577794 (10Quiddity) [22:48:56] 06Collaboration-Team-Triage, 10Notifications: Echo: Ability to link accounts for notifications - https://phabricator.wikimedia.org/T50892#525054 (10Quiddity) [22:49:23] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Echo: Ability to link accounts for notifications - https://phabricator.wikimedia.org/T50892#525054 (10Quiddity) [22:52:43] RoanKattouw, trying, but it's not working. It's not adding the class, I'm so confused. [22:54:57] (03PS7) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [22:55:14] RoanKattouw, HELP. https://gerrit.wikimedia.org/r/#/c/306287/7/modules/ui/mw.echo.ui.ConfirmationPopupWidget.js [22:55:22] look at lines 27 and 29 [22:55:26] ONE OF THOSE SHOULD WORK, damnit [22:55:31] the class isn't even applied at all [22:55:33] what the hell [22:58:47] mooeypoo: I think you might need this.icon.$icon? [22:58:55] Or is that the same as $element [22:59:14] nope, I thought so, but no [22:59:16] Note there's no space in that CSS selector so .oo-ui-image-inverted and .oo-ui-icon-whatever need to be on the same element, not just descendants of each other [22:59:26] Although we can tweak that easily in Resources.php [22:59:35] 'selectorWithVariant' => '.oo-ui-image-{variant}.oo-ui-icon-{name}', [22:59:43] You can change that to generate whatever you need basically [22:59:44] IconWidget calls for IconElement with icon: this.$element [22:59:47] hah [22:59:56] And in the DOM, do you see both classes? [22:59:59] Which means this **is** the same element to apply the class to [23:00:00] no! [23:00:01] just one [23:00:04] I don't see the invert [23:00:06] what the hell [23:00:20] And the widget isn't wrapped, it's a [23:00:33] the icon widget, I mean. It's inside the confirmation widget [23:00:34] Hmm [23:00:44] I wonder if updateThemeStyles removes the variant class again or something [23:01:18] It probably does [23:01:19] hmm when am I calling that though [23:01:29] You're not, OOUI calls it internally [23:01:38] oh, because we are calling it in echo init [23:01:41] but not in mobile [23:02:01] When the state of the widget changes, it updates the variant classes and probably removes yours because the widget state says it shouldn't be there [23:02:05] Do you see the class applied? [23:02:11] pff [23:02:12] I haven't downloaded your patch [23:02:18] But I'm convinced that this is what's going on [23:02:22] that is ridiculous. [23:02:28] updateThemeClasses() is the dog eating your homework [23:02:38] Let me test this by re-applying that class when I .toggle() the widget [23:02:39] Yes, ideally it shouldn't remove variant classes [23:02:55] But also, why are you using an inverted IconWidget anyway [23:03:15] Oh, does ConfirmPopupWidget have a dark background? [23:03:16] because when I used IconElement mixin and appended this.$icon it didn't show [23:03:20] and yes [23:03:23] Right [23:03:34] https://phabricator.wikimedia.org/T141404#2566946 [23:03:40] First image, lower right corner [23:03:49] OK, yes [23:03:58] It's working great , except the icon :\ [23:04:30] RoanKattouw, i just added that class to the icon just before I show the widget, and it's still nt working. [23:04:40] BUT [23:04:44] the class is there finally [23:05:21] ... okay, this one's on me [23:05:27] inverted vs invert [23:05:41] I made that mistake originally, did try to tell you but I think it got lost in the conversation [23:05:55] yeah .. still not working [23:05:57] this is frustrating [23:06:11] this.icon.$element.addClass( 'oo-ui-image-inverted' ); [23:06:22] ^^ this should work. And the class does show... but the image isn't inverted. [23:06:50] (03PS8) 10Mooeypoo: [wip] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) [23:06:59] * mooeypoo glares at ooui inverted styles [23:07:31] OUCH [23:07:32] [V7zXKgpEEH8AAHegkSoAAAAI] /wiki/Especial:Notifications BadMethodCallException from line 59 of /srv/mediawiki/php-master/extensions/Flow/includes/Notifications/FlowPresentationModel.php: Call to a member function getFullURL() on a non-object (null) [23:07:36] In beta labs [23:07:41] O.o what [23:07:46] I think that's your code [23:07:53] Looks like it [23:08:00] but why.. [23:08:39] $title = $isTopic ? $this->getTopicTitleObj() : $this->event->getTitle(); [23:08:44] ^^ this should always give us the title [23:08:51] are there cases where notifications have no title !? [23:09:07] Yes but they shouldn't be rendering in that case [23:09:40] wait, line #59 is this: [23:09:41] $url = $title->getFullURL( [23:09:41] array( [23:09:41] 'topic_showPostId' => $firstChronologicallyPostId->getAlphadecimal(), [23:09:41] 'fromnotif' => 1, [23:09:42] ) [23:09:43] ); [23:09:53] That's not from my code, though... not sure why it would pop up now [23:10:25] I don't think I ever call for a post url, either. It's always either a topic or a board [23:10:40] Is $title obtained from getTopicTitle or getTopicTitleObj? [23:10:44] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2060691 (10Platonides) >>! I... [23:10:52] $title should be getTopicTitleObj [23:10:57] getTopicTitle is a string [23:11:07] (mutters about naming stuff) [23:11:43] that entire method is weird, btw. [23:12:02] seems like it's not really always for topic title, but more for extra params tht get treated like title strings when truncated? [23:12:10] anyways, it's definitely not a Title object [23:12:46] Yeah more or less [23:12:55] It gets the truncated topic title [23:13:02] unless you change the parameter [23:13:08] and then it gives you the truncated whatever-you-chose [23:13:23] Yes, but it's intended to be fed the extra param name for something that's a topic title [23:13:26] but anyways, I shouldn't be calling it [23:13:37] I am only using TopicTitleObj [23:13:55] ... at least I should be. That and $this->event-getTitle() which is a Title object too [23:14:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Measure survival rate of new users who go through the constructive review process - https://phabricator.wikimedia.org/T143754#2577841 (10jmatazzoni) [23:24:30] $event->getTitle() can return null [23:25:05] ... meh [23:25:21] RoanKattouw, i gtg, but i'll be back a little later if you need me for this bug [23:31:06] is Augmented-Changes-Feed part of Edit-Review-Improvements? [23:31:31] conceptually at least. [23:36:03] Yes [23:36:07] I think it was meant to be a subproject? [23:43:17] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs] Special:Notifications page is not displayed - error: Call to a member function getFullURL() on a non-object (null) - https://phabricator.wikimedia.org/T143757#2577932 (10Etonkovidova) [23:43:49] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs] Special:Notifications page is not displayed - error: Call to a member function getFullURL() on a non-object (null) - https://phabricator.wikimedia.org/T143757#2577944 (10Etonkovidova)