[07:08:11] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Combine Flow resolved and summarised events when they are part of the "mark as resolved" workflow - https://phabricator.wikimedia.org/T128848#2570971 (10Pginer-WMF) >>! In T128848#2570606, @Aklapper wrote: > Is this a duplicate of {T131722} ? Both refer... [13:04:31] (03CR) 10Sbisson: Moderate notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [13:30:50] 06Collaboration-Team-Triage, 10Flow, 10ConfirmEdit (CAPTCHA extension): Flow not displaying Captcha of Extension:ConfirmEdit-ReCaptchaNoCaptcha - https://phabricator.wikimedia.org/T143516#2570309 (10Mattflaschen-WMF) There is nothing special about NS_MAIN in Flow. You're right, it should respect the namespa... [13:33:01] 06Collaboration-Team-Triage, 10Flow, 10ConfirmEdit (CAPTCHA extension): Flow not displaying Captcha of Extension:ConfirmEdit-ReCaptchaNoCaptcha - https://phabricator.wikimedia.org/T143516#2571464 (10Mattflaschen-WMF) I should have been more clear. wgCaptchaTriggersOnNamespace should work currently as long a... [13:37:29] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Combine "Resolved" and "Summarized" notifications when both actions happen on Flow - https://phabricator.wikimedia.org/T131722#2571473 (10Mattflaschen-WMF) [13:37:31] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Combine Flow resolved and summarised events when they are part of the "mark as resolved" workflow - https://phabricator.wikimedia.org/T128848#2571471 (10Mattflaschen-WMF) [13:41:51] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, and 2 others: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2571499 (10Mattflaschen-WMF) Thanks, @matthiasmullie . [15:14:55] (03PS3) 10Sbisson: Maintenance: moderate notifications linked to missing pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) [15:15:09] (03CR) 10Sbisson: Maintenance: moderate notifications linked to missing pages (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [15:19:29] (03PS3) 10Sbisson: Locate events using EventMapper instead of TargetPageMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) [15:21:33] (03CR) 10Sbisson: "Not strictly needed but I think there's value in having the different pieces of code from Echo and Flow use the same entry point to fetch " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:23:45] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2571724 (10Mattflaschen-WMF) Final pass for conversion of namespace: P3872 . I also ran the populateC... [15:23:59] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2571728 (10Mattflaschen-WMF) Please let us know if you have questions. Thank you again for trying Flow. [15:43:58] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2571836 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [15:49:54] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 3 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2571868 (10Mattflaschen-WMF) The direct link for kab translations is https://translatewiki.net/w/i.php?ti... [16:02:11] (03CR) 10Sbisson: [C: 04-1] [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [16:56:12] will be 2 min late to meeting [17:15:10] (03CR) 10Catrope: [C: 032] Locate events using EventMapper instead of TargetPageMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [17:15:34] 06Collaboration-Team-Triage, 10Notifications, 07Privacy: Do not display content snippet of sent email - https://phabricator.wikimedia.org/T142910#2550442 (10Quiddity) This was discussed in various comments throughout {T121831}. Legal and Product said it was ok to include, but two editors expressed concerns. [17:16:08] (03CR) 10Catrope: Maintenance: moderate notifications linked to missing pages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [17:21:40] 06Collaboration-Team-Triage, 10Notifications, 07Privacy: Do not display content snippet of sent email - https://phabricator.wikimedia.org/T142910#2572318 (10Quiddity) 05Open>03declined Declining per T121831#2024034 [17:22:11] (03CR) 10jenkins-bot: [V: 04-1] Locate events using EventMapper instead of TargetPageMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [17:23:35] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [17:24:22] (03CR) 10Sbisson: Maintenance: moderate notifications linked to missing pages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [17:40:30] (03CR) 10Catrope: [C: 032] Locate events using EventMapper instead of TargetPageMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [17:50:47] (03Merged) 10jenkins-bot: Locate events using EventMapper instead of TargetPageMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [17:54:41] (03CR) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [18:06:31] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2572593 (10Volker_E) @Jdforrester-WMF The Togg... [19:28:37] mooeypoo, taking a look at T121939 . [19:28:37] T121939: Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939 [19:34:39] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#2573026 (10Mattflaschen-WMF) >>! In T121939#2565979, @Mooeypoo wrote: > This is of... [20:02:10] matt_flaschen: Do you know what needs to be done for T143464? The warning is really annoying and I can't tell if what I'm doing now is breaking because of that. [20:02:10] T143464: "Memcached::touch(): touch is only supported with binary protocol" - https://phabricator.wikimedia.org/T143464 [20:05:10] stephanebisson, no, I'll take a look after I fix the broken EventLogging. [20:05:31] matt_flaschen: Thanks. Let me know if I can do something. [20:06:10] stephanebisson, I was going to say "just comment it out for now", but I think it's in a binary library (on further review the file of the actual warning is not in the stack). [20:15:11] Hmm, Vagrant on EventLogging supposedly starts at boot, but it wasn't running until I did "sudo service eventlogging-devserver start" [20:15:38] EventLogging on Vagrant I mean [20:34:10] (03PS1) 10Mattflaschen: Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) [20:34:36] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#2573206 (10Mattflaschen-WMF) 'special-page-visit' wasn't being logged because it w... [20:36:18] (03PS2) 10Mattflaschen: Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) [20:37:18] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#2573231 (10Mattflaschen-WMF) Great catch, @Etonkovidova . [20:39:10] stephanebisson, I'm not clear on whether it's an issue in production too. I guess I'll check that, and if not, we can try to use their version in vagrant. [20:40:41] "In all such cases, the actual value sent may either be Unix time (number of seconds since January 1, 1970, as an integer), or a number of seconds starting from current time." [20:40:45] PHP, once again, we need to talk. [20:40:48] http://php.net/manual/en/memcached.expiration.php [20:45:56] I love TestingAccessWrapper. Such a pain to do that manually. [20:51:01] Works in production [20:53:59] is it a different php version? [21:18:50] mooeypoo: https://gerrit.wikimedia.org/r/#/c/306053 [21:49:53] (03CR) 10Mooeypoo: [C: 032] Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) (owner: 10Mattflaschen) [21:50:58] matt_flaschen, since upgrading Ubuntu to 16.04 vagrant now once again asks me for a password each time it loads -- do you remember how to set it up so it doesn't ask each time? [21:55:29] mooeypoo, https://www.vagrantup.com/docs/synced-folders/nfs.html#root-privilege-requirement . [21:55:44] (03CR) 10jenkins-bot: [V: 04-1] Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) (owner: 10Mattflaschen) [22:05:07] matt_flaschen, thanks! [22:05:39] matt_flaschen, meh, that looks like a fake fail to me... https://gerrit.wikimedia.org/r/306053 ? [22:06:05] (03CR) 10Mooeypoo: Add dynamic secondary actions to notification items (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [22:06:13] mooeypoo: Yup, fake fair. Vote 0 then +2 again [22:06:19] *fail [22:06:26] (03PS18) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [22:06:38] RoanKattouw, fail enough. [22:06:41] I don't know what a fake fair is. Perhaps an event selling fried things on a stick outside of the Us? [22:07:12] (03CR) 10Mooeypoo: Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) (owner: 10Mattflaschen) [22:07:27] RoanKattouw, do I wait for it to pass before +2ing again? [22:07:59] No [22:08:08] The +2 will trigger a Jenkins run, your 0 vote won't [22:08:10] (03CR) 10Mooeypoo: [C: 032] Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) (owner: 10Mattflaschen) [22:08:28] Saying "recheck" makes Jenkins check it again but not for merge, so that doesn't help anyway [22:08:35] I was going to ask that [22:08:37] ok [22:08:40] let's see if it likes it now [22:11:09] (03PS15) 10Mooeypoo: Add unwatch topic/board dynamic action for Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [22:11:36] RoanKattouw, even in my part of the U.S. that would be fairly fake. [22:11:58] In some areas, it might be fakely fair. [22:13:59] Yeah in mine too [22:14:23] matt_flaschen, hm, my sudoers file already has vagrant specific stuff [22:14:29] I wonder if the vars changed in the upgrade [22:15:06] appears they have [22:15:44] (03Merged) 10jenkins-bot: Fix special page visit logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306053 (https://phabricator.wikimedia.org/T121939) (owner: 10Mattflaschen) [22:17:14] rebooting to make sure that if I just destroyed my sudoers file, I do it next to Roan. [22:17:55] And with available online computers that give me access to matt_flaschen. [22:18:05] the linux experts! ... brb (hopefully) [22:19:58] I'm in! ... now let's see if vagrant loads. [22:21:30] mooeypoo, you know about visudo right? [22:21:35] You should always use that. [22:49:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 07User-notice: [betalabs-Regression] cross-wiki bundle displays only wiki names - no notifications - https://phabricator.wikimedia.org/T140836#2573929 (10Etonkovidova) Checked in betalabs - all cross-wiki bundled notifications can be expanded a... [22:53:46] (03PS19) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [22:58:13] (03CR) 10jenkins-bot: [V: 04-1] Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [23:04:54] (03PS20) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [23:07:20] (03CR) 10Catrope: [C: 031] "Looks good, let's merge this after the cut tomorrow." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [23:17:46] (03PS1) 10Catrope: Follow-up 8eda2aa3f: actually render the nojs message on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306074 [23:17:54] mooeypoo: ---^^ [23:23:18] (03CR) 10Mooeypoo: [C: 032] Follow-up 8eda2aa3f: actually render the nojs message on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306074 (owner: 10Catrope) [23:30:21] (03Merged) 10jenkins-bot: Follow-up 8eda2aa3f: actually render the nojs message on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306074 (owner: 10Catrope)